c85c64c787
Merge pull request #8630 from nextcloud/ldap-cachekey-sha256
...
use hash algo that's robust against collisions
2018-03-05 12:34:07 +01:00
3ced2c7ab2
Merge pull request #8601 from nextcloud/theming-fix-background-color
...
Remove too restrict check for background image/color
2018-03-05 11:28:41 +01:00
a8f56ac8c7
Merge pull request #8603 from nextcloud/enc-cleanup
...
kill old encryption migration steps
2018-03-05 11:16:27 +01:00
05ef2d70e7
Merge pull request #8590 from nextcloud/redirect-to-download-after-share
...
Sharing: redirect to download after authentification if requested
2018-03-05 11:11:43 +01:00
6c49cc0294
[tx-robot] updated from transifex
2018-03-05 01:12:12 +00:00
6975cef00b
[tx-robot] updated from transifex
2018-03-04 01:12:42 +00:00
3b000d4f91
[tx-robot] updated from transifex
2018-03-03 01:12:14 +00:00
5053877c45
Merge pull request #8619 from coliff/patch-1
...
Use correct input type for the url entry
2018-03-02 21:26:36 +01:00
8607992e85
do not create empty userid when attribute does not have allowed chars
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-02 17:44:06 +01:00
04f7252fc4
use hash algo that's robust against collisions
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-02 16:26:36 +01:00
064cb5ebce
Merge pull request #8612 from nextcloud/rakekniven-i18n-fix
...
Update commentstabview.js
2018-03-02 10:36:36 +01:00
8042e6b8fb
this was a migration step to ownCloud 8.0 to restructure the encryption folder which is no longer needed
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-03-02 10:09:52 +01:00
d838789259
Use correct input type for the url entry
...
Change `type="text"` to `type="url"`
2018-03-02 16:49:56 +09:00
777313db42
[tx-robot] updated from transifex
2018-03-02 01:12:16 +00:00
b348cd170a
Update commentstabview.js
...
Changed typo reported at GitHub.
See https://www.transifex.com/nextcloud/nextcloud/translate/#de_DE/$/91002505?issue=yes
2018-03-01 20:53:50 +01:00
6b931eb64b
Merge pull request #8588 from nextcloud/fix-breadcrumbs-width-calculation
...
Fix breadcrumbs width calculation
2018-03-01 20:13:26 +01:00
c521791653
Remove to restrict check for background image/color
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-01 14:39:31 +01:00
3824e6f631
fixup! fixup! Sharing: redirect to download after authentification if requested
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 13:17:08 +01:00
4c2aff0807
fixup! Sharing: redirect to download after authentification if requested
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-01 13:12:24 +01:00
0f3ba9444e
Merge pull request #8298 from nextcloud/bugfix/e2e-45/fix-activities-for-end2end-encryption
...
Fix activities for e2e encryption
2018-03-01 10:51:27 +01:00
6b4a2d01c3
Merge pull request #8574 from nextcloud/breadcrumb-flash-fix
...
Fixed breadcrumb menu flashing
2018-03-01 09:39:29 +01:00
a7fb9ff8da
[tx-robot] updated from transifex
2018-03-01 01:12:11 +00:00
7bcc821642
fixup! Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 19:03:00 +01:00
8c69d783e0
Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 17:35:42 +01:00
542dc2b335
Fix upload button visible on read-only folders
...
The div that contains the elements related to the creation of new files,
and thus the upload button, is always present in the DOM; it is hidden
or shown based on the folder permissions by adding or removing the
"hidden" CSS class. However, as the other CSS classes for the div are
"actions" and "creatable" and a "display: flex" rule was defined for
".actions.creatable" below the "display: none" rule for
".actions.hidden" the last one took precedence and the div ended being
always visible, even if the "hidden" CSS class was set. Now the rules
for the ".actions.hidden" selector are defined below the rules for the
".actions.creatable" selector and thus the "display: none" rule is
applied as expected.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 17:26:36 +01:00
a0641e43dc
fixup! Sharing: redirect to download after authentification if requested
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 17:08:25 +01:00
fb890807c0
Sharing: redirect to download after authentification if requested
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 17:05:55 +01:00
8b73560cac
Fix unit test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 16:04:45 +01:00
0b883ab9d9
Catch exception when the parent is deleted as well
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:40:01 +01:00
825c276e84
Do a recursion instead of an endless loop
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:16:18 +01:00
62e982a91f
Fix problem with deleted files
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:06 +01:00
d202bae3b5
Fix path handling for activities
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:06 +01:00
f8c27cb57d
Add special handling for e2e encryption
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:06 +01:00
03a25410f1
Extract duplicated logic into a method
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 15:06:05 +01:00
ad71abca6f
Update comments in tests
...
Menu and home are not always visible; home is always visible, but menu
is shown only when needed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
292476911f
Improve documentation of "getTotalWidth"
...
"getTotalWidth" is not more accurate; it is simply not clamped.
Moreover, "width/outerWidth" could be used in tests too, and also even
if "getTotalWidth" could be used in tests while others not that would
not be something to be stated in the API documentation, but in a
comment.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
d122d054d3
Do not show the crumbs again after hiding them
...
After the changes in the previous commit "_showCrumb" no longer shows
the menu, only the same crumb that was hidden by the last call to
"_hideCrumb". Therefore, if the crumb was hidden because it did not fit
there is no need to try to show it again, as it will still not fit.
Moreover, the calculated width for a hidden element is not always
accurate; in some cases the calculated width is lower than the actual
width (it happens, for example, when using a background image like the
"Share" icon), which causea the crumb to be shown even if there is not
enough room, which in the end causes the siblings to overflow the
contents.
No unit tests for this one, though; you will have to trust me on this,
sorry ;-)
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
10e9eeec45
Fix menu visibility
...
The crumb for the menu was shown like any other crumb when calling
"_showCrumb", but it was also shown when other crumbs were hidden
without taking into account the available width. This caused several
related problems, like the breadcrumbs taking too much space when the
menu was sometimes shown after the rest of the crumbs were adjusted to
the available width, or the menu being shown instead of the last crumb
even if there was room for it when the available width was increased.
Now the menu is always hidden before starting the resizing of the crumbs
to ensure that whether it was previously shown or not does not affect
the result. In a similar way, the menu will no longer be shown by
"_showCrumb", as it is not a regular crumb that has to be shown simply
if there is enough room. The menu is now shown as soon as any other
crumb is hidden; this ensures that the menu width will be taken into
account in further width checks. As when _updateMenu" is called it no
longer needs to take care of showing the menu this fixes the issue
revealed when fixing the test setup in the previous commit.
Finally, this implicitly fixes the failure in the breadcrumbs tests when
run on Firefox, as it was caused by the menu interfering in the
calculations of the other crumbs when increasing the width.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
1bcba56d8f
Fix setup to test the breadcrumbs menu
...
The "Shows only items not in the breadcrumb" test was failing when run
on Firefox, but not on PhantomJS. This was caused by the differences in
the starting width between both browsers and an incorrect setup of the
test (the width set for the crumbs was overriden when the breadcrumbs
were rendered again, and the breadcrumb was resized to 300 from an
indeterminate initial width).
Now the crumbs are rendered and then its width, padding and margin are
set to a known value. Then it is resized to 1000px, which ensures that
there will be enough room for all the crumbs and thus the menu will be
hidden, and finally it is resized to 300, which causes the middle crumb
to be hidden and the menu to be shown.
Note, however, that the test now always fails, no matter if it is run on
PhantomJS or on Firefox; if the menu crumb is hidden when "_updateMenu"
is called it will show it, but it will also wrongly try to add the menu
itself to the menu. As the "crumb-id" of the menu crumb is "-1" this
causes the last regular crumb to be added to the menu. This will be
fixed with other related issues in the next commit.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
92345f2c38
Take padding and margins of crumbs into account
...
When calculating the total width of the crumbs only its padding was
taken into account; now the margin is too. In a similar way, before
showing a crumb only its width was taken into account; now its padding
and margin are taken into account too.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
29c924f74b
Use hard-coded values for paddings and margins
...
This ensures that the resize tests do not depend on the values set in
the CSS files.
Note that this change causes a test to fail with Firefox, but not with
PhantomJS. This is due to a difference in the starting width used by
Firefox and by PhantomJS, and it will be fixed in a following commit.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
acdf091f84
Compress siblings before calculating the available width for crumbs
...
When the parent element of the breadcrumbs was resized to a larger width
and the siblings of the breadcrumbs expanded to fill all the available
width some crumbs could be hidden even if there was enough room for
them. The reason was that the width of the siblings being used to
calculate the available width for the breadcrumbs was the expanded width
of the siblings. Now as many crumbs as possible (that is, fitting in the
parent, no matter the siblings) are first shown so the expanding
siblings are compressed before calculating the available width.
Due to the lack of support for flexboxes in PhantomJS the related unit
test is skipped; it has to be run in other browser, like Firefox.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
a37007f872
Take all visible siblings into account
...
Other apps could add elements to the controls outside the creatable
actions div (for example, the button to switch to the gallery), so the
widths of all the visible siblings of the breadcrumbs have to be taken
into account in the size calculations.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
e37c4fd7f3
Take padding and margin of the creatable actions div into account
...
There are some differences in width handling between the browsers used
to run the tests, most likely due to their support (or lack of) of
certain CSS features: PhantomJS requires "width" to be set (probably
because it does not handle flex displays and treats it like a block, so
"min-width" does not matter in this case), while Firefox requires
"min-width" to be set (otherwise the children of "#controls" could be
compressed due to its use of flex display and the elements would end
with a different width than the one needed for the tests). Due to all
that the width of the breadcrumb siblings must be specified in the tests
using both "width" and "min-width".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
3850221ae1
Do not render the breadcrumbs again in resize tests
...
There is no need to call "setDirectory" again in resize tests; it is
enough to simply resize them (and isolates them better to just test the
resizing behaviour).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
a828e7b12a
Replace attribute with local variable
...
The "usedWidth" attribute was not used elsewhere outside the "_resize"
method, so it was replaced with a local variable. Moreover, it was also
renamed to a more suitable name ("availableWidth").
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
a9552de089
Set the width of the parent element in breadcrumb tests
...
Setting the width of the parent element of the breadcrumbs and then
explicitly calling "_resize" is enough to test the resizing behaviour.
This makes possible to remove the "setMaxWidth" method and its related
code, which was used only for testing purposes.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-02-28 15:03:26 +01:00
bb58d12bca
Check for app updates when there is a new major version available
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-28 14:27:35 +01:00
0e0d852b89
Merge pull request #8566 from nextcloud/provisioning_strict
...
Make the provisioning api app strict
2018-02-28 14:09:34 +01:00
4b05f03c34
Merge pull request #8569 from nextcloud/cleanup_unused_static_sharing
...
Remove unused static sharing helper code
2018-02-28 13:09:06 +01:00
d78026c3b4
Fixed breadcrumb menu flashing
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-28 11:04:27 +01:00
533e8351ad
[tx-robot] updated from transifex
2018-02-28 01:12:31 +00:00
7e8c84ec20
Remove unused static sharing helper code
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 22:40:59 +01:00
b369abc378
Merge pull request #8565 from nextcloud/bugfix/fat-48/make-outlook-and-thunderbird-addons-identifyable
...
Make the Outlook and Thunderbird addons identifyable
2018-02-27 22:27:26 +01:00
fbeaacdf1b
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 22:03:40 +01:00
77927442a6
Merge pull request #8496 from nextcloud/ext-strg-design-fixes
...
External storage design fixes and update
2018-02-27 15:59:06 +01:00
24b58a7683
Make the provisioning api app strict
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 15:47:59 +01:00
f81d4eb060
Make the Outlook and Thunderbird addons identifyable
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-27 14:37:32 +01:00
7bc3c2e057
Merge pull request #7363 from nextcloud/default-share-perms
...
Let the admin configure the default share permissions
2018-02-27 13:44:34 +01:00
01f420c7ac
Merge pull request #8051 from nextcloud/public-template
...
Public page template response
2018-02-27 13:33:19 +01:00
5f217e2d83
fixup! Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 13:25:42 +01:00
017e1325f1
Merge pull request #8285 from nextcloud/apps_files-smb-catch-exceptions-on-listing
...
Make SMB module more fault-tolerant
2018-02-27 13:10:54 +01:00
6ee9a2b35b
fixup! Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 13:05:39 +01:00
3285becdc1
fix unit tests
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
ebb15283a6
share api: use default permission of no permission is given
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
1615312bf1
add share permissions to settings page
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-02-27 12:29:25 +01:00
f1634cd3e2
fixup! Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:27:25 +01:00
4a1cbefc90
Fix files_sharing tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
038aad73c7
Add missing phpdoc for public API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:53 +01:00
4f83462f67
Add phpdoc, typehints and sanitize HTML
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
8a13851da8
Use PublicTemplateResponse for files_sharing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +01:00
324e96b780
Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 12:11:36 +01:00
6b45d7e549
Fixed actions and header missing th
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-27 11:35:11 +01:00
048ad0df1d
Merge pull request #8475 from sagorika1996/theme
...
Empty name not allowed in theming app
2018-02-27 11:30:59 +01:00
7394e8ae58
Empty name not allowed
...
Do not allow empty name in theming app.
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-02-27 10:54:21 +01:00
6994bce951
Loglevel is an int
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 10:45:35 +01:00
4077f16aec
Make ILogger strict
...
* Make implementations strict
* Add scalar typehints
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-27 10:41:46 +01:00
ad2eefe896
[tx-robot] updated from transifex
2018-02-27 01:14:26 +00:00
350b66b73d
Merge pull request #8485 from sagorika1996/rename
...
Rename dialog closed when not active
2018-02-26 21:36:39 +01:00
abb0a08ed5
Merge pull request #7933 from nextcloud/update-notification-vuejs
...
Migrate Update notifications to Vue.js
2018-02-26 18:55:08 +01:00
8867629cf1
Merge pull request #8359 from nextcloud/swift-v3
...
Support swift v3 authentication
2018-02-26 18:30:00 +01:00
4076c09195
Merge pull request #8463 from kyrofa/bugfix/8462/theming_app_outside_root
...
theming: handle not being in the serverroot
2018-02-26 18:27:54 +01:00
955e136fd9
Fix appname
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-26 17:47:42 +01:00
950e7e0467
Merge pull request #8455 from nextcloud/proper_mount_type_external
...
Properly set the mount type for external storages
2018-02-26 17:19:54 +01:00
612e875f60
Merge pull request #8355 from nextcloud/fix-comments-num-index
...
Fix comments (and systemtags) when involving users with numerical ids
2018-02-26 17:12:57 +01:00
a3c09f51c6
Merge pull request #8203 from Cybso/split-move-copy
...
Split move and copy operations
2018-02-26 16:06:20 +01:00
07a6821ab2
Merge pull request #8511 from nextcloud/ext-storage-error-warning-fix
...
Ext storage error warning fix
2018-02-26 15:36:46 +01:00
d40c61a71a
adjust external storage config format to the one used in primary storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-26 14:54:30 +01:00
31dd6d6aae
add support for v3 swift auth
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-26 14:54:08 +01:00
226e63695f
Merge pull request #8026 from nextcloud/feature/noid/allow-custom-html-in-html-emails
...
Allow custom HTML in HTML Emails
2018-02-26 13:38:39 +01:00
0f229d23f7
fixup! Fixed icons padding
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-26 13:03:44 +01:00
da2aafa5cf
Fixed icons padding
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-26 13:02:07 +01:00
695e32d0a6
Merge pull request #8491 from nextcloud/strict_request
...
Make Request strict
2018-02-26 11:02:30 +01:00
2f12094ea8
Merge pull request #8522 from nextcloud/fix-groupmembers-numids
...
Fix retrieval of group members with numerical uids from LDAP
2018-02-26 09:01:38 +01:00
8dcbea124e
Remove null check
...
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-02-25 07:08:59 -08:00
25c89a6feb
Add mock to setup
...
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-02-24 08:16:42 -08:00
a210247559
[tx-robot] updated from transifex
2018-02-24 01:12:16 +00:00
fdfa934078
Updated error message
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-23 12:13:10 +01:00
238c3a5201
fix retrieving group members with numerical uids from LDAP
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-23 12:05:50 +01:00
72af741e78
tests for retrieving group members with numerical uids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-23 12:04:48 +01:00
e01e1696da
Merge pull request #8507 from nextcloud/fix-change-icon
...
Add some whitespace around change.svg icon
2018-02-23 10:36:32 +01:00
98baf8915d
Merge pull request #8502 from nextcloud/properly-show-hints-in-ocs
...
Show hint in OCS API for user creation
2018-02-23 10:02:31 +01:00
69c88ad075
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-23 09:06:43 +01:00
68187e6036
[tx-robot] updated from transifex
2018-02-23 01:12:16 +00:00
930aad5aaa
Merge pull request #8499 from nextcloud/avoid-fruitless-login-attempts
...
Avoid fruitless login attempts
2018-02-22 19:19:40 +01:00
4a429cc810
Fixed default urls
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 18:17:42 +01:00
887241b355
Show error if no external storage configured
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 18:14:19 +01:00
6335c6c5ec
Fix dav server test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-22 15:51:19 +01:00
dc6ae9e622
Add some whitespace around change.svg icon
...
Signed-off-by: Marin Treselj <marin@pixelipo.com>
2018-02-22 15:46:21 +01:00
dab83c4a49
Select in popover fix
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:37 +01:00
323dd31056
Tooltip fix on status icon
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:37 +01:00
1f3eef9460
fixup! Changed config saving feedback design
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:34 +01:00
884605ac18
Better label styling
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:32 +01:00
0cc520f3a0
Changed config saving feedback design
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 15:45:32 +01:00
9aaf1c2a06
Show hint in OCS API for user creation
...
* adds a 107 error code together with the hint of the exception
* logs the exception as warning
* fixes #7946
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-22 14:16:49 +01:00
9bc75307e7
track the state of the bind result
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 13:05:33 +01:00
1e2a082cd2
Use popovermenu instead of dropdown and small fix to popovermenu
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-02-22 12:15:32 +01:00
49ec5ff4e4
2nd parameter to t() must be array
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 12:10:30 +01:00
6340e78be8
Use mixin for translations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:19:55 +01:00
59c007bedd
Use VueSelect instead of select2
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:42 +01:00
308c7db333
Move updatenotifications to webpack with .vue file
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:42 +01:00
b12b391d7c
Migrate the app to Vue.js
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:41 +01:00
52f8d75d1a
Rename legacy notification so it's less confusing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-22 10:17:41 +01:00
a660946ac6
Merge pull request #8490 from nextcloud/strict_systemtags
...
Make SystemTag strict
2018-02-22 10:01:20 +01:00
4b352a345b
[tx-robot] updated from transifex
2018-02-22 01:12:26 +00:00
096ea2c390
Properly cast
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 22:45:28 +01:00
dca75448d0
rename dialog closed when not active
...
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-02-21 23:16:27 +05:30
a1f1824116
theming: handle not being in the serverroot
...
Currently, the theming app assumes it's in the serverroot. However, with
Nextcloud's flexibility regarding configurable app paths, this is not a
safe assumption to make. If it happens to be an incorrect assumption,
the theming app fails to work.
Instead of relying on the serverroot, just use the path from the
AppManager and utilize relative paths for assets from there.
Fix #8462
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-02-20 22:45:10 -08:00
6591a3bc36
[tx-robot] updated from transifex
2018-02-21 01:12:10 +00:00
30017e3364
Properly set the mount type for external storages
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-20 15:51:12 +01:00
c48332a14f
[tx-robot] updated from transifex
2018-02-20 01:11:55 +00:00
817f2f8f49
adjust swift external storage to new openstack sdk
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-19 19:41:16 +01:00
7ad1e13961
Merge pull request #8158 from nextcloud/s3-minio
...
Use a more widely available method to test s3 settings
2018-02-19 17:09:36 +01:00
70b1f510f2
Use normal header() calls instead of private method calls
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-19 09:40:25 +01:00
b3ca73dc27
[tx-robot] updated from transifex
2018-02-19 01:11:54 +00:00
667d21ac7d
[tx-robot] updated from transifex
2018-02-18 01:12:03 +00:00
ac63c207a9
Merge pull request #8411 from nextcloud/add-strict-types-to-oc_app
...
Add strict types to OC_App
2018-02-17 21:34:20 +01:00
edee243b27
OC_App::loadApps now only accepts an array as type list
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 15:27:43 +01:00
d953db8683
[tx-robot] updated from transifex
2018-02-17 01:12:04 +00:00
f095001e4b
Fix info.xml files of shipped apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 10:24:03 +01:00
620ee00ac5
[tx-robot] updated from transifex
2018-02-16 01:12:10 +00:00
38ba64af77
Split move and copy operations
...
The new 'Move and copy' operation from #6040 requires UPDATE permissions
on the selected files. However, READ would be sufficient to create a
copy of a file (if not viewed as a public share). For this reason this patch:
- changes the permission of the 'MoveCopy' action to PERMISSION_READ
- changes the label of the action depending on the permissions
- changes the available buttons in the Move/Copy dialog depending on the
permissions.
The same changes are done to the filelist view for bulk actions.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-15 18:51:12 +01:00
339e320064
Fix existing usages
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-15 12:18:51 +01:00
c300a64520
Merge pull request #8277 from nextcloud/avatars-shared-all
...
Show share owner avatars on all file lists
2018-02-15 12:11:09 +01:00
01623d4aca
[tx-robot] updated from transifex
2018-02-14 21:37:31 +00:00
236086c457
Merge pull request #8335 from nextcloud/remove-unused-import
...
Remove unused import statements
2018-02-14 22:23:07 +01:00
aeb7503feb
fix systemtags event with numeric user ids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 17:02:54 +01:00
d3d045dd5c
Remove unused import statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
023d028c57
fix creating comments when file is accessible to users with numeric ids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:39 +01:00
a5a0a938f2
test creating comments with numeric user ids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:10 +01:00
c32a94b78d
Merge pull request #8337 from nextcloud/use-non-alias-method
...
Use non aliased method instead
2018-02-14 10:09:09 +01:00
d1fb939e86
Merge pull request #8338 from nextcloud/simplify-return-statement
...
Simplify return statement
2018-02-14 10:08:28 +01:00
ff1b343c4a
[tx-robot] updated from transifex
2018-02-14 01:11:53 +00:00
e2974f1133
Simplify return statement
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:55:24 +01:00
954da26e26
Use non aliased method instead
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:48:24 +01:00
3fc6d6234e
[tx-robot] updated from transifex
2018-02-13 10:48:27 +00:00
91c67eb667
[tx-robot] updated from transifex
2018-02-12 21:33:37 +00:00
4bd14ef308
Merge pull request #8308 from nextcloud/public_link_wa_preview
...
Show open graph preview in WhatsApp
2018-02-12 11:09:08 +01:00
20844c828a
Show open graph preview in WhatsApp
...
Whatsapp is picky about the size of the open graph images.
So we do some special handling.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-12 10:42:18 +01:00
a11415b167
Fix example regex for user agent matching
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-10 16:39:53 +01:00
8e251e5d5a
Make SMB module more fault-tolerant
...
Ignore unavailable files when fetching the share's mtime
or reading directory listings. This can happen on servers using a
distributed file system (DFS) with unavailable destinations, for example
when the remote server is offline.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-09 17:40:00 +01:00
ee77f37df2
[tx-robot] updated from transifex
2018-02-09 15:28:58 +00:00
cae311460a
Show share owner avatars on all file lists
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-09 11:42:47 +01:00
15b4797629
[tx-robot] updated from transifex
2018-02-09 01:10:53 +00:00
12c9bad5b2
Merge pull request #8100 from nextcloud/s3-folder-delete
...
Fix deleting folders when using s3 external storage
2018-02-08 14:11:12 +01:00
48ea714341
Use a more widely available method to test s3 settings
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-08 09:34:05 +01:00
e5c08621af
Merge pull request #8023 from nextcloud/webdavsearch_limit_order_fixing
...
Respect limit and order in webdav search
2018-02-08 09:11:39 +01:00
71382daf67
[tx-robot] updated from transifex
2018-02-08 01:10:28 +00:00
e4129b0dc7
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 14:55:50 +01:00
c1ff12e234
CacheJail should apply limit and offset after searching
...
Else the results might not be correct.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
6b5419ddf0
Adjust to updated searchdav library
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:41:15 +01:00
ec144281ef
Respect limit and order in webdav search
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
9d6d23d1f7
keep previous exception when transforming to dav exception
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:34:30 +01:00
3063131e6d
[tx-robot] updated from transifex
2018-02-07 11:31:55 +00:00
cf4ec7a4b6
Apply ldapUserFilter on members of group
...
Refers to issue #8220
user_ldap configured with custom filters for active directory access
(group-member-association is "member"). Then it can happen that the
members of a group contain members that don't belong to the users
available in Nextcloud (the most trivial reason is that the user filter
contains "(!(UserAccountControl:1.2.840.113556.1.4.803:=2))" to exclude
disabled users from being imported).
This can be fixed by applying the ldapUserFilter when resolving the UID
for a DN fetched from the group's member list.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-07 12:02:58 +01:00
2a3272331f
[tx-robot] updated from transifex
2018-02-07 01:10:23 +00:00
0225ea1b9a
Merge pull request #8155 from nextcloud/use-guest-css
...
Fix styling issues of guest pages
2018-02-05 12:14:09 +01:00
a0dfc7d34a
[tx-robot] updated from transifex
2018-02-05 01:10:16 +00:00
58b568fd5d
[tx-robot] updated from transifex
2018-02-04 01:10:28 +00:00
79e81c15c5
Merge pull request #8163 from nextcloud/fix_themeing_test
...
Fix theming test
2018-02-03 14:11:03 +01:00
7af48b4187
[tx-robot] updated from transifex
2018-02-03 01:10:30 +00:00
0bde91600a
Fix theming test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-02 21:26:33 +01:00
1ac352de6c
Add space on guest pages with custom logo
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-02 14:20:13 +01:00
39461a2e09
Make sure theming logo css only applies when a logo is set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-02 14:20:12 +01:00
6428cf552c
Merge pull request #8122 from nextcloud/fix-6851
...
fix reading the ldapIgnoreNamingRule config value
2018-02-02 09:34:03 +01:00
17a2dbb7de
[tx-robot] updated from transifex
2018-02-02 01:10:15 +00:00
b78da27d0a
[tx-robot] updated from transifex
2018-02-01 18:28:02 +00:00
b006f25457
[tx-robot] updated from transifex
2018-02-01 17:19:47 +00:00
4739076474
Use correct update server
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-01 13:22:36 +01:00
8f29f9a59b
typo
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 21:50:55 +01:00
372e06d742
Add all parameters to returnValueMap
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:12 +01:00
44b002665c
Remove deprecated isEnabled call from files_trashbin
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:13:15 +01:00
8753a816d8
fixes reading the sysconfig value
...
settings without the entry in the translation array are computed
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 13:46:13 +01:00
cb26f6d014
[tx-robot] updated from transifex
2018-01-31 01:10:51 +00:00
78e4f6f312
Merge pull request #8000 from nextcloud/fix_7983
...
Provide list of editable fields via OCS API
2018-01-30 22:46:20 +01:00
48884c9b6a
Merge pull request #8111 from nextcloud/only_encrypted_prop_on_folders
...
Only handle encrypted property on folders
2018-01-30 21:54:18 +01:00
9896b15ec8
Only handle encrypted property on folders
...
Exposing the encrypted property is required for E2E. However, there is
no need to expose this on files as then it is server side encryption
(which the clients don't care about).
Better to not confuse the output.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-30 12:25:49 +01:00
3867717107
[tx-robot] updated from transifex
2018-01-30 01:11:04 +00:00
4fcdfbf5de
Merge pull request #8078 from nextcloud/theming-validate-scss
...
SCSS hardening
2018-01-29 16:12:10 +01:00
84bd2b6bc9
fix invalidating folder cache for s3
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-29 15:09:15 +01:00
7afd77604e
adjust s3 bulk delete to new sdk syntax
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-01-29 15:06:10 +01:00
eb51f06a3b
Use ::class statement instead of string
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
1d8b90b8d3
[tx-robot] updated from transifex
2018-01-29 01:10:53 +00:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
5dbf733395
Fix theming tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 20:13:28 +01:00
6770213649
Do not rewrite absolute URLs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:08:45 +01:00
60e601f4ab
Only override image styles if the theming values are set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 19:05:10 +01:00
9be6050cc4
Merge pull request #8072 from nextcloud/type-casting
...
Use type casting instead of *val() method
2018-01-26 17:34:55 +01:00
97c216ea06
Merge pull request #8071 from nextcloud/remove-silly-code
...
Cleanup unused code
2018-01-26 15:47:06 +01:00
c67736a542
Merge pull request #7707 from nextcloud/bugfix/noid/birthdaycalendar-different-uids
...
generate different UIDs for Birthday, Anniversary and Death event
2018-01-26 15:46:46 +01:00
08d184816f
Merge pull request #8070 from nextcloud/remove-theming-migration
...
Remove theming migration
2018-01-26 15:46:29 +01:00
4c38d1ed01
Merge pull request #8054 from nextcloud/substr-use-index
...
Use index based string access for substr with length of 1
2018-01-26 15:40:44 +01:00
c005fc6755
Cleanup unused code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:25:19 +01:00
5e325730d6
Remove theming migration
...
Those images are alredy migrated after the instance has been updated to NC12
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-26 15:10:22 +01:00
2ad2eb38e8
Use type casting instead of *val() method
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:01:27 +01:00
ca493ab5b1
Merge pull request #8069 from nextcloud/no-catch-serverdown
...
do not catch and ignore ServerNotAvailable in the wrong spot
2018-01-26 14:01:07 +01:00
9ff51aafc5
Use index based string access for substr with length of 1
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 13:38:34 +01:00
119896a8d7
Fix tests
...
* Add factory for the federatedfilesharing app
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 12:49:11 +01:00
b61b906abe
do not catch ServerNotAvailable
...
might cause the user to be unavailable (race condition).
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-26 12:47:19 +01:00
6bbea33133
Simplify ternary operator statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 12:36:25 +01:00
c1e4f9f305
Use type casting instead of *val() method
...
It should be up to 6x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +01:00
f3723434ee
Don't expose language and password as editable
...
* Password might not always be editable
- Also chaging that will invalide apptokens etc which will directly
lock out your phone
* Chaging the language also doesn't make that much sense to me currently
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 11:22:20 +01:00
70b19761aa
Provide list of editable fields via OCS API
...
Fixes #7983
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-26 11:20:58 +01:00
a7ad7cb08e
Merge pull request #8053 from nextcloud/simplify-substr
...
Use short for of substr to not need strlen()
2018-01-26 10:25:09 +01:00
c2b1bd92d6
Merge pull request #8063 from nextcloud/inline-value
...
Return value immediately instead of assigning to a one-time variable
2018-01-26 10:15:39 +01:00
ec1d94c629
Merge pull request #8052 from nextcloud/fix-array-methods
...
Fix array method usages with a proper call
2018-01-26 09:53:13 +01:00
5a7a5e5352
Merge pull request #8058 from nextcloud/useless-return
...
Remove useless return statements
2018-01-26 09:51:26 +01:00
68f44a9a93
Merge pull request #8059 from nextcloud/use-stripos
...
Use stripos instead of strpos(strtolower(), 'something')
2018-01-26 09:50:31 +01:00
43ed8b446c
Merge pull request #8060 from nextcloud/proper-codeflow
...
Use proper code flow instead of not needed else branch
2018-01-26 09:49:30 +01:00
aebb443ca5
Merge pull request #8056 from nextcloud/array-push
...
Use $var[] = $a instead of array_push - 2x faster
2018-01-26 09:41:31 +01:00
469b3724b5
[tx-robot] updated from transifex
2018-01-26 01:10:52 +00:00
0a56d2185e
Return value immediately instead of assigning to a one-time variable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +01:00
16a558871c
Use proper code flow instead of not needed else branch
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 23:01:03 +01:00
464f024fa9
Use stripos instead of strpos(strtolower(), 'something')
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:59:50 +01:00
4dbee99b7b
Remove useless return statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:50:40 +01:00
870fe20acc
Use $var[] = $a instead of array_push - 2x faster
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:36:03 +01:00
e6efa755c9
Use short for of substr to not need strlen()
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:23:48 +01:00
7800a9bc24
Fix array method usages with a proper call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:20:10 +01:00
b9bbb894f8
Merge pull request #7916 from nextcloud/2fa_log
...
Add 2FA to logfile
2018-01-25 15:57:32 +01:00
8160d0bc2a
Merge pull request #8036 from nextcloud/phpunit6
...
Require PHPUnit 6.5 or higher
2018-01-25 14:50:46 +01:00
9e76577ead
Add tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:44:47 +01:00
a5fe6a6118
Update autoloader
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
b2ca1d6553
Make admin_audit listen to 2fa events
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-25 13:25:09 +01:00
3917a54113
Class "ProgressBar" is declared "final" and cannot be mocked.
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:26 +01:00
bf2be08c9f
Fix risky tests without assertions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:25 +01:00
870023365c
Fix "Undefined method setExpectedException()"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 18:10:16 +01:00
c3424df1f0
Require PHPUnit 6.5 or higher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-24 17:23:59 +01:00
5d7eded809
Fix missing clipboard icon in shared links
...
The clipboard icon in shared links appears either directly on the link
input field or, if any social sharing app is enabled, in a menu. The
clipboard icon uses the same CSS rules as other icons (like the
information icon) to be posioned on the end of the input field, and
those rules have to be "cancelled" when the icon is shown in the menu.
Fixes #7990
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-24 16:40:21 +01:00
cda811b6b4
Make filelist and sidebar use the fileid preview endpoint
...
This makes sure the preview is cached even after rename! yay!
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-24 11:24:18 +01:00
4537faa5da
Merge pull request #7918 from nextcloud/properly-log-exceptions
...
Properly log the full exception instead of only the message
2018-01-23 11:56:02 +01:00
Joas Schilling
Morris Jobke
Roeland Jago Douma
Nextcloud bot
Arthur Schiwon
Bjoern Schiessle
Christian Oliff
rakekniven
Julius Härtl
John Molakvoæ (skjnldsv)
Daniel Calviño Sánchez
Roeland Jago Douma
Sagorika Das
Robin Appelman
Kyle Fazzari
Marin Treselj
Roland Tapken