Daniel Calviño Sánchez
bc084070c8
Fix delete user acceptance test
...
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.
The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:29:54 +01:00
Daniel Calviño Sánchez
d5586ec437
Verify WaitFor::element... results with an assertion
...
WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-05 22:06:05 +01:00
Daniel Calviño Sánchez
caa2246568
Add missing waits when finding elements in the acceptance tests
...
As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-05 22:06:05 +01:00
Julius Härtl
b6e434f02a
Merge pull request #25945 from nextcloud/dependabot/npm_and_yarn/core-js-3.9.1
...
Bump core-js from 3.8.3 to 3.9.1
2021-03-05 15:21:35 +01:00
Julius Härtl
b4160f367b
Merge pull request #25735 from francoisfreitag/npm-ci
...
Remove Makefile rule clean-dev
2021-03-05 15:18:35 +01:00
Roeland Jago Douma
f5dc657e94
Move background job to DI
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 14:57:07 +01:00
Roeland Jago Douma
5ec2323f25
Move admin_audit to LoggerInterface
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 14:51:55 +01:00
Roeland Jago Douma
900e7f99aa
AccessibilityController to LoggerInterface
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 14:38:36 +01:00
Roeland Jago Douma
c7c5150ddb
Merge pull request #25932 from nextcloud/bugfix/noid/fix-fed-share-add-to-nc
...
Skip empty obsolete owner when adding to own NC
2021-03-05 14:33:16 +01:00
Joas Schilling
f92d21e80e
Merge pull request #25870 from nextcloud/techdept/settings/move_group_activity_events
...
Move group activities to events
2021-03-05 13:05:06 +01:00
dependabot-preview[bot]
6c8650d414
Bump core-js from 3.8.3 to 3.9.1
...
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js ) from 3.8.3 to 3.9.1.
- [Release notes](https://github.com/zloirock/core-js/releases )
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zloirock/core-js/commits/v3.9.1/packages/core-js )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 11:34:26 +01:00
Christoph Wurst
e47bd8324d
Merge pull request #25928 from nextcloud/enh/contactsmenu/entry
...
Type Entry and IEntry
2021-03-05 09:46:40 +01:00
Christoph Wurst
11e2286a82
Merge pull request #25588 from nextcloud/techdept/custom-psr-logger
...
Migrate custom loggers to PSR
2021-03-05 09:46:07 +01:00
Roeland Jago Douma
b1ca746395
Merge pull request #25947 from nextcloud/fix/provisioning_api/logger
...
Fixed error after merge in UsersController
2021-03-05 09:37:38 +01:00
Julius Härtl
9dc5b8274e
Deprecate getHTMLName on \OCP\Defaults
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-05 09:34:24 +01:00
Marco Ambrosini
8691084f17
Do not target vue buttons with server rules
...
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
2021-03-05 08:16:20 +00:00
Roeland Jago Douma
128b682b7c
Fixed error after merge in UsersController
...
This was moved to the LoggerInterface so the recent merge of #25589
broke master.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 09:14:01 +01:00
Roeland Jago Douma
ca1eed96be
Merge pull request #25731 from nextcloud/dependabot/npm_and_yarn/mocha-8.3.0
...
Bump mocha from 8.2.1 to 8.3.0
2021-03-05 09:05:06 +01:00
Roeland Jago Douma
4a9f3ef232
Merge pull request #25589 from nextcloud/provisioning-api-invalid-argument
...
forward invalid argument message to frontend when creating a user fails
2021-03-05 08:59:50 +01:00
dependabot-preview[bot]
ffdacf813e
Merge pull request #25726 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.7.7
2021-03-05 07:57:01 +00:00
Roeland Jago Douma
54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
...
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +01:00
Roeland Jago Douma
e6ef096e52
Merge pull request #25659 from nextcloud/smb-getmetadata-catch
...
catch notfound and forbidden exception in smb::getmetadata
2021-03-05 08:49:23 +01:00
Roeland Jago Douma
3c9a62721f
Merge pull request #25725 from lmamane/master
...
token login: emit preLogin event with LoginName
2021-03-05 08:46:46 +01:00
Roeland Jago Douma
85e48d796c
Merge pull request #25929 from nextcloud/techdept/psalm/25839/redundantcasts
...
Remove Redundantcasts
2021-03-05 08:42:54 +01:00
dependabot-preview[bot]
54b843cfc0
Bump mocha from 8.2.1 to 8.3.0
...
Bumps [mocha](https://github.com/mochajs/mocha ) from 8.2.1 to 8.3.0.
- [Release notes](https://github.com/mochajs/mocha/releases )
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mochajs/mocha/compare/v8.2.1...v8.3.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-05 07:23:24 +00:00
dependabot-preview[bot]
c1105b3fda
Bump handlebars from 4.7.6 to 4.7.7 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.7.6 to 4.7.7.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.6...v4.7.7 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-05 07:23:03 +00:00
Roeland Jago Douma
cfb337dc01
Merge pull request #25942 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
...
[Automated] Update psalm-baseline.xml
2021-03-05 07:22:03 +01:00
Nextcloud-PR-Bot
df2fea444c
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2021-03-05 04:33:46 +00:00
Nextcloud bot
a6c9688fd6
[tx-robot] updated from transifex
2021-03-05 02:22:00 +00:00
Joas Schilling
5c9dacf786
Merge pull request #25941 from nextcloud/techdept/CompositeExpression
...
Type CompositeExpression and ICompositeExpression
2021-03-04 22:38:31 +01:00
Roeland Jago Douma
d7f7d3bc51
Type CompositeExpression and ICompositeExpression
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 21:47:44 +01:00
Robin Appelman
b844293536
catch notfound and forbidden exception in smb::getmetadata
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-04 21:34:54 +01:00
Christoph Wurst
b0fe408d1f
Merge pull request #25927 from nextcloud/enh/sharebymail/set_expiration_on_creation
...
Sharebymail: set expiration on creation
2021-03-04 18:17:54 +01:00
Vincent Petry
9da935c62b
Merge pull request #25926 from nextcloud/enh/activity/hidden_files
...
Activity: show if files are hidden or not
2021-03-04 16:44:02 +01:00
Vincent Petry
5be9acab84
Skip empty obsolete owner when adding to own NC
...
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.
Fixes an issue where "Add to your Nextcloud" doesn't add anything.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-04 15:54:21 +01:00
Roeland Jago Douma
7b7358868d
Merge pull request #23665 from nextcloud/enh/querybuilder/execute_query_update
...
Add executeQuery and executeUpdate
2021-03-04 15:46:17 +01:00
Roeland Jago Douma
c3f1eb4f7f
Remove Redundantcasts
...
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:44:04 +01:00
Roeland Jago Douma
b14be34689
Type Entry and IEntry
...
* Fixed a docblock
* Typed the entries
Psalm happier, Roeland happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:30:21 +01:00
Roeland Jago Douma
76a6328d10
Add executeQuery and executeUpdate
...
Names shamelessly copied from Doctrine itself.
Internally it is still using the same flow. But I added some checks
around it.
This should make static analysis a bit more happy. Which in turn makes
me more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:03:31 +01:00
Roeland Jago Douma
d247a5fb47
Sharebymail: set expiration on creation
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 13:49:21 +01:00
Roeland Jago Douma
997259d1cd
Activity: show if files are hidden or not
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 13:14:52 +01:00
Roeland Jago Douma
3bbacb2f54
Merge pull request #25881 from nextcloud/techdept/psalm/sharesplugin
...
Fix the SharesPlugin
2021-03-04 12:33:20 +01:00
Christoph Wurst
cdc9a1efd9
Merge pull request #25912 from nextcloud/techdept/psalm/sharedstorage_some_types
...
Add some typing to SharedStorage
2021-03-04 12:31:17 +01:00
Roeland Jago Douma
f04a2ce19f
Pimp ActionProviderStore
...
* Fix paradoxale condition
* Add types
* Move away from ILogger
Makes psalm happy, and thus me happy
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 12:29:49 +01:00
blizzz
c3361a2b13
Merge pull request #25915 from nextcloud/bugfix/noid/option-always-show-unique-label
...
Add appconfig to always show the unique label of a sharee
2021-03-04 12:11:28 +01:00
Roeland Jago Douma
7b9ca4f7c2
Add some typing to SharedStorage
...
Makes psalm a bit more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 10:49:42 +01:00
Julius Härtl
69c2864aca
Add appconfig to always show the unique label of a sharee
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-04 09:25:45 +01:00
Joas Schilling
1e5fea0460
Only mark migrations as installed after execution
...
The problem is that if a developer creates a structural error in their migration file,
they will already be marked as executed and an not be rerun.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-04 08:49:42 +01:00
Roeland Jago Douma
9b573c6bd5
Merge pull request #25923 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
...
[Automated] Update psalm-baseline.xml
2021-03-04 07:25:57 +01:00
Nextcloud-PR-Bot
efdb881372
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2021-03-04 04:32:47 +00:00