Commit Graph

4674 Commits

Author SHA1 Message Date
Daniel Calviño Sánchez 038e665db9 Fix dropping a folder on a folder row
When the uploaded files have a relative path (that is, when a folder is
uploaded) it is first ensured that all the parent folders exist, which
is done by trying to create them. When a folder is created in the
currently opened folder the file list is updated and a row for the new
folder is added. However, this was done too when the folder already
existed, which caused the previous row to be removed and a new one added
to replace it.

For security reasons, some special headers need to be set in requests;
this is done automatically for jQuery by handling the "ajaxSend" event
in the document. In the case of DAV requests, if the headers are not set
the server rejects the request with "CSRF check not passed".

When a file or folder is dropped on a folder row the jQuery upload
events are chained from the initial drop event, which has the row as its
target. In order to upload the file jQuery performs a request, which
triggers the "ajaxSend" event in the row; this event then bubbles up to
the document, which is then handled by adding the special headers to the
request.

However, when a folder was dropped on a folder row that folder row was
removed when ensuring that the folder exists. The jQuery upload events
were still triggered on the row, but as it had been removed it had no
parent nodes, and thus the events did not bubble up. Due to this the
"ajaxSend" event never reached the document when triggered on the
removed row, the headers were not set, and the upload failed.

All this is simply fixed by not removing the folder row when trying to
create it if it existed already.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-29 13:04:19 +01:00
Christoph Wurst 8fcb9fcfdc
Merge pull request #13855 from tomasz-grobelny/faster_file_upload
Throttle getstoragestats.php calls and allow simultaneous uploads
2019-01-29 08:51:38 +01:00
Tomasz Grobelny f99ce0d546 Throttle getstoragestats.php calls and allow simultaneous uploads
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-01-27 22:59:14 +01:00
imsolost 5742ec79ab changed case on variable to match initial case
Signed-off-by: imsolost <imsolost@gmail.com>
2019-01-25 11:16:37 -08:00
imsolost 3e37620cc2 fixed replacement functions to catch all instances of parenthesis
Signed-off-by: imsolost <imsolost@gmail.com>
2019-01-25 11:16:37 -08:00
Joas Schilling 0ba9e3b8bd
Make the yellow favorite icon non-monochrome
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-22 16:13:29 +01:00
Joas Schilling 55cd351324
Add icon to restore activity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-22 15:37:07 +01:00
Roeland Jago Douma 03290df8d4
Merge pull request #13723 from kofemann/patch-1
apps: file-upload: fix typo in comments
2019-01-22 09:26:40 +01:00
Nextcloud bot af36746d7c
[tx-robot] updated from transifex 2019-01-22 01:12:25 +00:00
Tigran Mkrtchyan 0573413134 apps: file-upload: fix typo in comments
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
2019-01-21 19:11:13 +01:00
Morris Jobke 990bca8696
Merge pull request #13567 from nextcloud/fix/deuglify-upload-progress
Improve the upload progress bar layout
2019-01-21 13:54:04 +01:00
Nextcloud bot f12b589d40
[tx-robot] updated from transifex 2019-01-19 01:12:22 +00:00
Morris Jobke 743323ee48
Merge pull request #12381 from rummatee/master
Move/copy file picker: Remeber last destination and start in current folder
2019-01-18 17:20:54 +01:00
Nextcloud bot ac6ee0b8b7
[tx-robot] updated from transifex 2019-01-17 01:12:15 +00:00
Florian Schunk 332b4aee9d fix testing for undefined
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Florian Schunk ecb936495f also remember folder for multiselect actions
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Florian Schunk 37270fc525 remember last copied to directory
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Florian Schunk 528964e0b7 copy Dialog starts in current directory
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Nextcloud bot e35a5ef387
[tx-robot] updated from transifex 2019-01-16 01:12:34 +00:00
Morris Jobke 6ac66ea0a3
Merge pull request #12173 from nextcloud/filename-center
Ensure filename is possibly centered below file icons in grid view
2019-01-15 08:47:46 +01:00
Nextcloud bot 56ad07b85e
[tx-robot] updated from transifex 2019-01-15 01:12:14 +00:00
Julius Härtl e5c1049d04
Properly center text inside of the grid container
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-14 22:03:40 +01:00
Michael Weimann 5ed63b05c7
Deuglify the file upload progress bar
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2019-01-14 21:20:57 +01:00
Jan-Christoph Borchardt 4d103f8b97
Ensure filename is possibly centered below file icons in grid view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-14 20:19:10 +01:00
Nextcloud bot 8edd9b0e33
[tx-robot] updated from transifex 2019-01-14 01:12:00 +00:00
Nextcloud bot 363c0c31f4
[tx-robot] updated from transifex 2019-01-13 01:12:53 +00:00
Nextcloud bot ce89fe7f39
[tx-robot] updated from transifex 2019-01-12 01:11:54 +00:00
Nextcloud bot 75b8e98f8e
[tx-robot] updated from transifex 2019-01-11 01:12:31 +00:00
Nextcloud bot e8040d896a
[tx-robot] updated from transifex 2019-01-08 01:12:02 +00:00
Nextcloud bot 29dc12c885
[tx-robot] updated from transifex 2019-01-06 01:13:07 +00:00
Nextcloud bot a1b6333712
[tx-robot] updated from transifex 2019-01-05 01:11:57 +00:00
Nextcloud bot a1f9ed1d7d
[tx-robot] updated from transifex 2019-01-04 01:12:28 +00:00
Felix Nüsse d3171a80e0
Implemented short quota-design v2
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
2019-01-03 18:47:30 +01:00
Nextcloud bot cb4371c4f3
[tx-robot] updated from transifex 2019-01-01 01:11:35 +00:00
Nextcloud bot 8d5b74b6b6
[tx-robot] updated from transifex 2018-12-31 01:11:41 +00:00
Nextcloud bot eeceb684e8
[tx-robot] updated from transifex 2018-12-30 01:12:41 +00:00
Nextcloud bot 760c502f3c
[tx-robot] updated from transifex 2018-12-28 01:11:49 +00:00
Nextcloud bot 1c3f468d56
[tx-robot] updated from transifex 2018-12-27 01:11:41 +00:00
Nextcloud bot 3c83925f97
[tx-robot] updated from transifex 2018-12-26 01:11:56 +00:00
Nextcloud bot 9d5f7c7f62
[tx-robot] updated from transifex 2018-12-24 01:11:46 +00:00
Roeland Jago Douma bcea6c3697
Merge pull request #13212 from nextcloud/bugfix/noid/ie11-files-loading
Files list not rendering if user has favorites navigation unfolded
2018-12-21 14:20:41 +01:00
Julius Härtl 6bcc77a7c6
Replace ChildNode.before with custom before helper
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-21 12:03:34 +01:00
Roeland Jago Douma 8f16768a8b
Merge pull request #13183 from nextcloud/enhancement/whats_new_one_per_hour
Only check whatsnew once per hour
2018-12-21 09:21:16 +01:00
Nextcloud bot c0a6ad0a72
[tx-robot] updated from transifex 2018-12-21 01:11:48 +00:00
Roeland Jago Douma 00446ffb9e
Only check whatsnew once per hour
Store the last check in the session storage. (Which gets cleared on
logout). And only check once an hour.
Saves a request to the server on most requests when browsing.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-20 20:09:05 +01:00
Nextcloud bot 4be6aa5270
[tx-robot] updated from transifex 2018-12-20 01:11:44 +00:00
Nextcloud bot 3d53398d07
[tx-robot] updated from transifex 2018-12-19 01:11:46 +00:00
Nextcloud bot ffd2410a7e
[tx-robot] updated from transifex 2018-12-17 01:11:33 +00:00
Nextcloud bot 3068f07ad9
[tx-robot] updated from transifex 2018-12-16 01:12:32 +00:00
Nextcloud bot 5a2a78c692
[tx-robot] updated from transifex 2018-12-15 01:11:38 +00:00