Commit Graph

45894 Commits

Author SHA1 Message Date
Daniel Calviño Sánchez edab262b0e Add acceptance tests for comments on shared files and folders
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-12-07 14:08:50 +00:00
Nextcloud bot 95eecb4f33
[tx-robot] updated from transifex 2018-12-07 01:12:00 +00:00
Roeland Jago Douma aed094418a
Merge pull request #12860 from nextcloud/fix/stable14-fix-password-confirmation-ie11
[stable14] Fix password confirmation lib for ie11
2018-12-06 09:02:43 +01:00
Roeland Jago Douma 2d6cfdce58
Merge pull request #12869 from nextcloud/backport/12857/stable14
[stable14] Emit write update only once on touch
2018-12-06 08:30:31 +01:00
Nextcloud bot e772457d6b
[tx-robot] updated from transifex 2018-12-06 01:12:21 +00:00
Morris Jobke 50b2115f4e
Merge pull request #12862 from nextcloud/backport/12855/stable14
[stable14] Only execute query in propagateChange once
2018-12-06 00:05:49 +01:00
Roeland Jago Douma bdd974db3f Emit write update only once on touch
When a touch is done (i.e. when creating a new file in the node API)
The hooks contain 'write' and 'touch' (and the operation is touch as
well). This would cause a double write update. Which doesn't make sense.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-05 21:56:01 +00:00
Roeland Jago Douma ab31b26b0c Only execute query in propagateChange once
The second execute statement should be inside the if block. Else it gets
executed twice which makes no sense.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-05 20:45:15 +00:00
Christoph Wurst db480acf5c
Fix password confirmation lib for ie11
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-12-05 21:36:43 +01:00
Roeland Jago Douma 13b2617761
Merge pull request #12850 from nextcloud/stb14-missing-click-apps-update
[stable14] Fix missing click event on update button
2018-12-05 21:08:16 +01:00
Julius Härtl 52f4d0171f
Fix missing click event on update button
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-05 14:26:37 +01:00
Morris Jobke 133aec72c2
Merge pull request #12834 from nextcloud/backport/12831/stable14
[stable14] Do not update child all child shares on group share update
2018-12-05 09:35:03 +01:00
Roeland Jago Douma 218b83b656
Merge pull request #12817 from nextcloud/backport/12813/stable14
[stable14] Fix the system address book
2018-12-05 08:42:29 +01:00
Nextcloud bot f65ec57243
[tx-robot] updated from transifex 2018-12-05 01:12:15 +00:00
Roeland Jago Douma ab8f31b24c Do not update child all child shares on group share update
Else we overwrite the whole share for link shares. Basically breaking
them.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-04 21:53:35 +00:00
Roeland Jago Douma 8f984532cd
Merge pull request #12826 from nextcloud/backport/12822/stable14
[stable14] PHP module is named mbstring
2018-12-04 20:12:48 +01:00
Morris Jobke 316d79b2ae PHP module is named mbstring
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-04 17:57:19 +00:00
Roeland Jago Douma 2bb278ecb0 Fix the system address book
c23a66cda4 broke the system address book.
We now move the ACL rules for this special case up and all is good in
the world again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-04 14:21:16 +00:00
Roeland Jago Douma de83581694
Merge pull request #12748 from nextcloud/backport/14/11200/stable14
[stable14] Fix interaction with groups that contain a slash
2018-12-04 15:03:11 +01:00
Roeland Jago Douma 2d757a0e4c
Merge pull request #12812 from nextcloud/backport/12808/stable14
[stable14] Only run the AnonymousOptionsPlugion on Anonymous requests
2018-12-04 14:50:43 +01:00
Roeland Jago Douma 877b23a3fd Only run the AnonymousOptionsPlugion on Anonymous requests
Fixes #12744

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-04 12:12:11 +00:00
Nextcloud bot 70b8588d93
[tx-robot] updated from transifex 2018-12-04 01:12:26 +00:00
Nextcloud bot 34cbcb41cb
[tx-robot] updated from transifex 2018-12-03 01:11:52 +00:00
Nextcloud bot 2b35e12350
[tx-robot] updated from transifex 2018-12-02 01:12:56 +00:00
Nextcloud bot ba285c087e
[tx-robot] updated from transifex 2018-12-01 01:11:47 +00:00
Nextcloud bot bcc0956ec0
[tx-robot] updated from transifex 2018-11-30 01:12:17 +00:00
Morris Jobke 43b8cc46f8
Merge pull request #12745 from nextcloud/backport/12647/stable14
[stable14] update compatible versions for cloud federation api
2018-11-29 22:44:57 +01:00
Joas Schilling 6b6f923b8b Fix interaction with groups that contain a slash
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-29 21:57:21 +01:00
Robin Appelman 0b662f8aa3
update compatible versions for cloud federation api
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-29 21:42:30 +01:00
Roeland Jago Douma 58aaf8ecb8
Merge pull request #12738 from nextcloud/backport/12690/stable14
[stable14] Set Referrer-Policy also in addSecurityHeaders()
2018-11-29 19:35:42 +01:00
Peter Kraume 6dbfe24777 Set Referrer-Policy also in addSecurityHeaders()
Fix: #12689
Signed-off-by: Peter Kraume <peter.kraume@gmx.de>
2018-11-29 16:48:12 +00:00
Nextcloud bot 76cd8babd2
[tx-robot] updated from transifex 2018-11-29 01:11:52 +00:00
Morris Jobke 2b011b3626
Merge pull request #12715 from nextcloud/backport/12708/stable14
[stable14] Fix folder path containing leading slash when getting mount root by id
2018-11-28 23:05:42 +01:00
Robin Appelman 7ee9781087 Fix folder path containing leading slash when getting mount root by id
This fixes collabora on public link shared groupfolders

Fixes https://github.com/nextcloud/groupfolders/issues/225

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-28 19:07:51 +00:00
Daniel Kesselberg e1739e3da9
Merge pull request #12701 from nextcloud/stable14-12632-add-acceptance-tests-for-sharing-files-and-folders-with-another-user
[stable14] Add acceptance tests for sharing files and folders with another user
2018-11-28 14:11:55 +01:00
Nextcloud bot d572bdea74
[tx-robot] updated from transifex 2018-11-28 01:12:15 +00:00
Daniel Kesselberg b8311b0dd5
Merge pull request #12697 from nextcloud/backport/12649/stable14
[stable14] Make acceptance tests for comments more robust
2018-11-27 21:25:10 +01:00
Daniel Calviño Sánchez 876ee0fd76 Wait for the comment to be added before changing to another file
If the server is too slow, changing to a different file immediately
after sending a new comment but without waiting for the comment to be
shown for the original file could cause the new comment to be shown for
the current file instead.

This is, indeed, a bug in the comments. However, it is not possible to
test it reliably in the acceptance tests, as it depends on how fast the
server adds the message and how fast the client changes to a different
file; sometimes the test would fail and sometimes it would not.

Therefore, now it is waited for the comment to be added before changing
to another file, as in this case it can be reliably tested that changing
to a different file does not cause the comments from the previous file
to be shown in the current file (this was a different bug already fixed
and due to which this test was added in the first place).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 16:56:38 +00:00
Daniel Calviño Sánchez fc0a1d1015 Wait for the empty content element to be shown
When the "Comments" tab is open the empty content element is always in
the DOM, although it is only shown once the message collection was
fetched and there were no messages. Due to this it is necessary to
explicitly wait for it to be shown instead of relying on the implicit
wait made to find the element; otherwise it would be found immediately
and if the collection was not fetched yet it would not be visible,
causing the test to fail.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 16:56:38 +00:00
Roeland Jago Douma 2706bc7df7
Merge pull request #12684 from nextcloud/backport/12650/stable14
[stable14] Fix count on string
2018-11-27 16:28:56 +01:00
Daniel Kesselberg 5c10df6d2d Add return type
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-27 13:16:28 +00:00
Daniel Kesselberg 375ece362d Fix count on string
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-27 13:16:28 +00:00
Nextcloud bot 5fc0565695
[tx-robot] updated from transifex 2018-11-27 01:11:51 +00:00
Morris Jobke 24c4ab8265
Merge pull request #12639 from nextcloud/backport/12556/stable14
[stable14] extend anonymous options to work on every dav url
2018-11-26 11:02:46 +01:00
Nextcloud bot fd3e080aa6
[tx-robot] updated from transifex 2018-11-26 01:11:41 +00:00
Nextcloud bot 1901b750c7
[tx-robot] updated from transifex 2018-11-25 01:12:33 +00:00
Nextcloud bot 5238d79452
[tx-robot] updated from transifex 2018-11-24 01:11:37 +00:00
Robin Appelman ff9093e183 extend anonymous options to work on every dav url
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-23 19:37:52 +00:00
Daniel Calviño Sánchez c55054e2a5 Rename "FilesSharingAppContext" to "PublicShareContext"
Having both "FilesAppSharingContext" and "FilesSharingAppContext" was
confusing, so "FilesSharingAppContext" was renamed to a more descriptive
name.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-23 15:14:49 +01:00
Daniel Calviño Sánchez 6be19a5ca3 Extract locators and steps for sharing in Files app to their own context
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-23 15:14:49 +01:00