Commit Graph

978 Commits

Author SHA1 Message Date
Christoph Wurst 979b291a36
Show the full trace of an exception
Because often we catch the exception at some point and then the trace is
misleading. What's really interesting is the trace of the *previous*
exception.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-10 10:35:08 +01:00
Richard Steinmetz cb68bcef0f Fix password visibility toggles
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-10 12:53:23 +00:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Christian Wenz 8aa13f37b0 Add apple-touch-icon-precomposed (fixes #14818)
Signed-off-by: Christian Wenz <christian@wenz.org>
2020-10-02 21:49:14 +02:00
timm2k 4a352befca
Check if var debugMode exists
Closes #21150 a second time.
2nd appearance of debugMode may not seen in first fix.
2020-09-04 13:50:14 +02:00
Joas Schilling e66bc4a8a7
Send "429 Too Many Requests" in case of brute force protection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-19 11:20:35 +02:00
Morris Jobke d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +02:00
John Molakvoæ (skjnldsv) 1a1b3e20e4 Fix unified search
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-03 11:26:03 +00:00
Joas Schilling abec8a2c63
Add a clear message why you could end up there
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-06 13:49:09 +02:00
Roeland Jago Douma ac3137a166
Check if debugMode is defined before using it
Else the sabre error page (where the var is not defined) will throw
warnings all the time.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-02 15:46:59 +02:00
Joas Schilling ebedbf1579
Merge pull request #19646 from firlevapz/bugfix/19400/oauth2-login-opens-new-browser-window
Change OAuth2 redirect link to relative link
2020-07-01 09:39:55 +02:00
Morris Jobke bc02b0adb8
Merge pull request #20932 from nextcloud/Valdnet-patch-3
l10n: Changing the word "These" to "Following"
2020-05-13 22:59:03 +02:00
Valdnet 25023ae288
l10n: Addition of "The" 2020-05-13 14:17:57 +02:00
Valdnet 2f45cb3fe9
l10n: Changing the word "These" to "Following" 2020-05-11 21:19:05 +02:00
Roeland Jago Douma 1d35a1474b
Move the password confirmation form template to post
I know we use JS for this. But it triggers some false positives on
testing.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-11 21:18:38 +02:00
Roeland Jago Douma 0160817078
Install page app naming
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-07 19:54:57 +02:00
Gary Kim 74d40233f5
Comply with php-cs
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 14:28:21 +08:00
John Molakvoæ (skjnldsv) 6e79fb60d8
Fix public layout header title & description
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-30 13:32:28 +02:00
Loïc Hermann 6c60b85a87 Fix breadcrumb in move or copy file dialog
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-17 06:47:17 +00:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
Julius Härtl bba26cb2eb
Move install scripts to bundle
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-11 14:06:25 +01:00
Joas Schilling 585b09af3a
Prevent self-xss via invalid mysql user name on install screen
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-06 14:39:13 +01:00
Fabian Helm 5b1bb3703a Change OAuth2 redirect link to relative link
fix issue with third-party apps like rocket.chat
where browser in external window is opened
and thus oauth2 login does not work

Signed-off-by: Fabian Helm <firlevapz@gmail.com>
2020-02-25 21:51:58 +01:00
Christoph Wurst 607c55aaaa
Add new recommended 18 apps
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-24 10:30:47 +01:00
Roeland Jago Douma 060dd35ef9
Merge pull request #18873 from nextcloud/design/install-page
Install page design fixes
2020-01-15 07:24:57 +01:00
Christoph Wurst a673ff3a63 Fix max width on 2FA pages
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-14 19:37:54 +01:00
Jan-Christoph Borchardt 19397059d6
Add explanatory bit for recommended apps, fix #18631
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-01-14 14:18:16 +01:00
Julius Härtl 7e5956a906
Limit the size of the container on guest pages
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-10 17:09:40 +01:00
Roeland Jago Douma 86bccde9c7
Merge pull request #17861 from nextcloud/fix-tab-navigation-of-menu-in-public-share-pages
Fix tab navigation of menu in public share pages
2020-01-07 21:00:00 +01:00
Sascha Wiswedel e24c7a8900
fix wording log in vs. login
"log in" is used as verb, while "login" is a noun.
In this case, what's supposed to be cancelled is the login process - therefore the noun must be used.

Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2020-01-06 14:44:31 +01:00
Daniel Calviño Sánchez e32766bd11 Change menu toggle element from span to button
This makes possible to navigate to the menu toggle using the keyboard,
as well as being semantically more correct.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-12-30 10:29:36 +01:00
John Molakvoæ 5e0f820029
Add accessibility label to show password checkbox (#16642)
Add accessibility label to show password checkbox
2019-12-12 10:47:25 +01:00
Christoph Wurst 302558cfd2
Add a dedicated page for the recommended apps installation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-12-12 08:13:01 +01:00
Brent Nesbit eda4d559f8
Issue 15965 - Show password checkbox doesn't provide label or accessible name
Signed-off-by: Brent Nesbit <github@nesbit.me>
2019-12-10 18:37:35 +01:00
Christoph Wurst a8f2e6914d
Add checkbox to install recommended apps during setup
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-12-04 14:14:38 +01:00
Daniel Kesselberg 71c7442790
The loading animation is back
Refactor grant.js to Vanilla JS
Remove id="submit" because of side effects: https://stackoverflow.com/questions/22982741/form-submit-jquery-does-not-work
Fix arrow for login flow v1

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-10-26 23:08:52 +02:00
Daniel Kesselberg 1d82bb55db
Move "you can close this window" to newline
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-10-25 21:26:41 +02:00
Daniel Kesselberg 2108e8b4aa
Add icon-confirm-white to submit button
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-10-25 21:26:19 +02:00
Julius Härtl a9c089064b
Deprecate TemplateManager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-10-16 09:54:17 +02:00
Roeland Jago Douma 1ddd6b4080
Don't use an undefined index if not needed
It is not set. And not used. Just some copy paste leftover.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-10-03 16:17:19 +02:00
Joas Schilling 31eaa6e6f4
Fix typo in "which"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-10-01 12:27:32 +02:00
Jochen e2df446ca4 Remove aria label
https://github.com/nextcloud/server/pull/16832#discussion_r322078592

Signed-off-by: Jochen <rothjochen@gmail.com>
2019-09-10 20:29:13 +02:00
Jochen e0ee53a5f0 Added name as fallback, in case label is not set
https://github.com/nextcloud/server/pull/16832#discussion_r322380822

Signed-off-by: Jochen <rothjochen@gmail.com>
2019-09-09 20:31:08 +02:00
Jochen 493a756f3b Add null coalesce for label and style attribute
https://github.com/nextcloud/server/pull/16832#discussion_r322380822

Signed-off-by: Jochen <rothjochen@gmail.com>
2019-09-09 20:25:16 +02:00