Commit Graph

776 Commits

Author SHA1 Message Date
Morris Jobke 9497dca2b0
Update psalm-baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-12 19:38:06 +01:00
Joas Schilling d09a22069f
Update baseline, I'm sorry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
Daniel Calviño Sánchez 487c603f95 Add integration tests for default share permissions
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 11:51:28 +01:00
Morris Jobke cecf579e81
Update psalm-baseline.xml to accept new errors
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-10 13:43:51 +01:00
Morris Jobke f28c436fd5
Check in failing psalm checks
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-09 10:21:05 +01:00
Morris Jobke 8c9fe98446
Update psalm-baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 13:17:19 +02:00
Christoph Wurst 6536501579
Update the baseline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-16 09:15:54 +02:00
Christoph Wurst be3a46038f
Use own psalm instead of a global one
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-16 08:45:07 +02:00
Daniel Calviño Sánchez 0dd18e0356 Add integration tests to check that only the given path is transferred
Until recently (it was fixed in ac2999a26a) when a path was transferred
other shares with the target user were removed, so a test was added to
ensure that it does not happen again.

Besides that a test to ensure that other files with the target user are
not transferred was added too (it did not fail before, but seemed
convenient to have that covered too :-) ).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-24 12:47:47 +00:00
Daniel Calviño Sánchez bf9a24efbe Add integration tests for transferring files of a user with a risky name
The files:transfer-ownership performs a sanitization of users with
"risky" display names (including characters like "\" or "/").

In order to allow (escaped) double quotes in the display name the
regular expression used in the "user XXX with displayname YYY exists"
step had to be adjusted.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-24 12:47:47 +00:00
Daniel Calviño Sánchez 87b9dbdb56 Add integration test for transferring the path of a single file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-24 12:47:47 +00:00
Morris Jobke c6948c2517
Update baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 16:54:10 +02:00
Morris Jobke 04a3580d19
Remove phan config - was replaced by Psalm
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 14:46:29 +02:00
Morris Jobke 1c9a898875
Merge pull request #22761 from nextcloud/extend-integration-tests-for-files-transfer-ownership-command
Extend integration tests for "files:transfer-ownership" command
2020-09-14 17:50:53 +02:00
Morris Jobke 04c174ab89
Merge pull request #22665 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.7.0
Update behat/behat requirement from ~3.6.1 to ~3.7.0 in /build/integration
2020-09-10 12:52:31 +02:00
Daniel Calviño Sánchez 58d57b35ea Add integration tests for transferring ownership of reshares
Currently only transferring ownership of a reshare with a group to a
user in the group is possible.

When transferring ownership of a reshare with another user or with a
group to a user not in the group restoring the share fails (but the
command succeeds, it only fails for the specific files that are
reshares).

When transferring ownership of a path that is a reshare the command
fails (as when a specific path is provided the path tries to move the
file, it does not take into account reshares).

The added integration tests reflect the above behaviours.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:34:33 +02:00
Daniel Calviño Sánchez 0ce8096839 Check share ownership after transferring file ownership
The integration tests did not verify that the shares were actually
transferred between the users (or that they were removed due to being
transferred to the sharee).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:24:16 +02:00
Daniel Calviño Sánchez d3d01d6355 Check whether file exists or not after transferring ownership
The integration tests did not verify that the files were actually
transferred between the users, only that the files were downloadable.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:18:53 +02:00
Roeland Jago Douma c104c192ae
Merge pull request #22663 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.7
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
2020-09-09 21:24:28 +02:00
Roeland Jago Douma fe5f8c5010
Merge pull request #22600 from nextcloud/dependabot/npm_and_yarn/build/http-proxy-1.18.1
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
2020-09-09 20:55:08 +02:00
Nextcloud-PR-Bot 9c57fff01f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-09 04:23:34 +00:00
dependabot[bot] 94b228dca1
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.6.1...v3.7.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:56 +00:00
dependabot[bot] 20e6d04a69
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.6...1.0.7)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:47 +00:00
Christoph Wurst 1f7f93a695
Update license headers for Nextcloud 20 (again)
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
John Molakvoæ 54438c9d26
Merge pull request #21945 from nextcloud/fix-contact-download-picture
Changed Content-Disposition header to download Contact Photo with correct extension
2020-09-07 08:40:23 +02:00
Nextcloud-PR-Bot 14baa52a1a Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-06 04:22:33 +00:00
Jacob Neplokh e8a4feb1c6
Change Content-Disposition Header
- Make ALLOWED_CONTENT_TYPES public in order to use
- Add $fileName variable which uses "$node->getName()" to get the proper file name and "$file->getMimeType()" along with the ALLOWED_CONTENT_TYPES array in PhotoCache.php to get the proper file extension
- Make "$fileName" the name of the file in the Content-Disposition header when downloading a Contact's photo
- Add filename to the CardDAV integration image export test header
- Change headers in ImageExportPluginTest to reflect changes

Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
2020-09-05 11:46:25 -07:00
dependabot-preview[bot] 3e9359f930
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. **This update includes a security fix.**
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.17.0...1.18.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-04 18:10:40 +00:00
Nextcloud-PR-Bot 7511885c15 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-03 04:22:57 +00:00
Julius Härtl 9dc23867c6
Use proper branch name in phpdoc builds
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 08:47:16 +02:00
Roeland Jago Douma b5e9f7e846
Merge pull request #22432 from nextcloud/enh/phpdoc
Add php docs build script
2020-08-26 21:18:11 +02:00
Julius Härtl 8c33bfe86b
Add php docs build script
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-26 08:32:42 +02:00
Nextcloud-PR-Bot bc7abbdb85 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-08-26 04:21:23 +00:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Nextcloud-PR-Bot 067945ff10 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-08-21 04:21:23 +00:00
Morris Jobke d58e71f0e6
Fix psalm warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 21:12:15 +02:00
Morris Jobke bb8be58386
Fix psalm warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 18:30:48 +02:00
Morris Jobke 8381af626f
Accept psalm warning for now
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:46:00 +02:00
Morris Jobke 69bbbc32a1
Extend psalm baseline to ignore errors for now
One is a false positive - see https://github.com/vimeo/psalm/pull/4032

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 14:20:56 +02:00
Julien Veyssier 70d1d1997a
new weather status used in dashboard
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2020-08-20 00:21:08 +02:00
Morris Jobke d8bdb439a4
Merge pull request #22289 from nextcloud/techdebt/noid/fix-encryption-stream-invalid-scalar-arguments
Cast float to int to avoid invalid scalar argument warning
2020-08-19 22:08:15 +02:00
Morris Jobke c449d54204
Merge pull request #22304 from nextcloud/techdebt/noid/matching-param-names
Use matching parameter names form interfaces and implementations
2020-08-19 19:34:02 +02:00
Morris Jobke 4c6eb96471
Merge pull request #22280 from nextcloud/bugfix/noid/429-on-brute-force-maximum
Send "429 Too Many Requests" in case of brute force protection
2020-08-19 18:21:01 +02:00
Morris Jobke fedf9c69d9
Use matching parameter names form interfaces and implementations
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
Morris Jobke 60be722ee8
Merge pull request #22288 from nextcloud/techdebt/noid/fix-oc_image-invalid-scalar-arguments
Cast float/char to int to avoid invalid scalar argument warning
2020-08-19 17:55:56 +02:00
Morris Jobke e93bf71369
Fix the return type of OC_Template->fetchPage() to be string only
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 16:48:06 +02:00
Morris Jobke 5ced155032
Merge pull request #22285 from nextcloud/techdebt/noid/move-to-typed-event-in-list.php
Use dispatchTyped instead of dispatch on the new event dispatcher
2020-08-18 21:29:48 +02:00
Morris Jobke a5853d7ecc
Use dispatchTyped instead of dispatch on the new event dispatcher
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 20:27:46 +02:00
Morris Jobke 560ccf5d83
Cast float to int to avoid invalid scalar argument warning
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:56:36 +02:00
Morris Jobke 27e7332a9c
Cast float/char to int to avoid invalid scalar argument warning
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:51:59 +02:00