Commit Graph

22372 Commits

Author SHA1 Message Date
Roeland Jago Douma f37be3af96
Merge pull request #21352 from nextcloud/backport/21311/stable19
[stable19] Always sort shares in a reliable way
2020-06-11 13:23:07 +02:00
Nextcloud bot e146a2b7e6
[tx-robot] updated from transifex 2020-06-11 02:15:59 +00:00
Joas Schilling 0e94a968ef Reflect unreadable state in the UI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-10 08:57:21 +00:00
Joas Schilling c63039bb83 Always sort shares in a reliable way
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-10 06:55:29 +00:00
Nextcloud bot f40f7abbaf
[tx-robot] updated from transifex 2020-06-10 02:16:16 +00:00
Arthur Schiwon 5b63593956 clear LDAP cache after user deletion
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-09 08:23:42 +00:00
Roeland Jago Douma b20b92441e
Merge pull request #21308 from nextcloud/backport/21198/stable19
[stable19] Only use background fade if nextcloud blue is set
2020-06-09 09:50:13 +02:00
Nextcloud bot d753435452
[tx-robot] updated from transifex 2020-06-09 02:16:05 +00:00
Julius Härtl 69de44ecab Only use background fade if nextcloud blue is set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-08 11:45:56 +00:00
Roeland Jago Douma b876658d70
Merge pull request #21203 from nextcloud/backport/21091/stable19
[stable19] normalize sftp path in read and write stream
2020-06-08 12:15:00 +02:00
Roeland Jago Douma 418c288933
Merge pull request #21287 from nextcloud/backport/21274/stable19
[stable19] Enable passwordless for everyone not only admins.
2020-06-08 11:20:31 +02:00
Nextcloud bot 27549f6729
[tx-robot] updated from transifex 2020-06-08 02:16:05 +00:00
Daniel Kesselberg df75d3ab59 Enable passwordless for everyone not only admins.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-07 13:07:53 +00:00
Nextcloud bot 5795271cef
[tx-robot] updated from transifex 2020-06-07 02:15:59 +00:00
Roeland Jago Douma 513446cafb
Merge pull request #21210 from nextcloud/backport/20938/stable19
[stable19] Fix the Talk verification
2020-06-06 09:31:16 +02:00
Nextcloud bot bcc63c0c2b
[tx-robot] updated from transifex 2020-06-06 02:16:09 +00:00
Thomas Citharel 8cef51bbad Fix empty event UUID reminder notifications
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-06-05 07:04:43 +00:00
Roeland Jago Douma 70c174566b
Merge pull request #21242 from nextcloud/backport/21232/stable19
[stable19] Use \OC::$CLI instead of PHP_SAPI
2020-06-05 08:53:22 +02:00
Nextcloud bot dfe70692d7
[tx-robot] updated from transifex 2020-06-05 02:16:44 +00:00
Thomas Citharel 26f72d1aec Use \OC::$CLI instead of PHP_SAPI
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-06-04 17:06:54 +00:00
Daniel Calviño Sánchez 01ccbe68ff Restore previous state when failing to change video verification state
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-03 14:08:17 +00:00
Christoph Wurst c423a50938 Fix the Talk verification
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).

When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.

We'll have to backport to 18.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 13:51:42 +00:00
Robin Appelman 48c0ac2f12 normalize sftp path in read and write stream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-03 10:19:35 +00:00
Christoph Wurst 25dd585251 Do not only catch Exceptions but any Throwable during rmt share delete
When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 09:13:47 +00:00
Daniel Calviño Sánchez 9a5b51d43c Fix creating a mail share with a password
When a mail share was created with a password the given password was not
hashed, so it was not possible to open the share with that password.
Moreover, if passwords were enforced the given password was ignored and
a new one was set (although in this case it was hashed so it worked as
expected). Now the given password is properly hashed and not overriden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:43 +00:00
Daniel Calviño Sánchez 5de6eb07c0 Extend mail shares unit tests to check the password and mail template
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:42 +00:00
Daniel Calviño Sánchez e9ccb802e8 Fix reference to wrong class name
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 06:48:00 +00:00
Roeland Jago Douma d12e379c96
Merge pull request #21128 from nextcloud/backport/21123/stable19
[stable19] simplify getGroups, fixing wrong chunking logic
2020-05-28 14:59:50 +02:00
Arthur Schiwon 1e5295138a simplify getGroups, fixing wrong chunking logic
pagination is taken care of properly in the search logic in Access class

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-27 17:38:45 +00:00
Christoph Wurst 14b618bcaf
Fix devices & sessions sanitization
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-27 15:57:18 +02:00
Arthur Schiwon 557a3754c1 use the loginname to verify the old password in user password changes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 19:20:42 +00:00
Arthur Schiwon d0559a4871 fixes infinitely repeating LDPA search results with PHP <= 7.2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 09:56:10 +00:00
Morris Jobke 138eddc0f1
Merge pull request #21028 from nextcloud/backport/20629/stable19
[stable19] Don't load text file preview when text app is available (Fixes: #20615)
2020-05-20 13:54:17 +02:00
Julius Härtl dd15780edd Fix share update test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-18 13:47:39 +00:00
Roeland Jago Douma aac0dd1f20 Have share permissions on link shares if it is enabled
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-18 13:47:38 +00:00
Jonas Meurer be37ca1776 Don't load text file preview when text app is available (Fixes: #20615)
When opening a shared text document, the files_sharing app uses
internal preview support in case no other app to open the text file is
available.

So far, it only checks for the old files_texteditor app, not for the new
new text app. This commit fixes this by checking for both.

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2020-05-18 08:59:53 +00:00
Robin Appelman ffc3b48a40 update icewind/smb to 3.2.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-15 12:35:22 +00:00
John Molakvoæ 4bde23d239
Merge pull request #20878 from nextcloud/backport/20719/stable19 2020-05-11 14:55:16 +02:00
Georg Ehrke e048bf8550 Rename app-generated to z-app-generated, because macOS Contacts supports only one and will pick the first one alphabetically
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:56 +00:00
Georg Ehrke d1909526fc Implement ctag and etag in ContactsInteraction
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:55 +00:00
GretaD adbdecb1d6 Fix languages empty array
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 09:25:59 +00:00
John Molakvoæ (skjnldsv) 90a65f83e0 Do not process the same FileInfo twice
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-08 05:39:53 +00:00
Robin Appelman 614acc9419
add locking to resolve concurent move to trashbin conflicts
uses a lock to prevent two requests from moving a file to the trashbin concurrently
(causing sql duplicate key errors)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-06 20:36:55 +02:00
Morris Jobke 06732cf2af
Merge pull request #20832 from nextcloud/fix/sharing-filter-user-shares-only-fix-group-display
Do not filter id matching userId on non-user-share shares
2020-05-06 17:46:21 +02:00
Nextcloud bot 3bf4e7d673
[tx-robot] updated from transifex 2020-05-06 02:16:28 +00:00
John Molakvoæ (skjnldsv) a26ca1e638
Do not filter id matching userId on non-user-share shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv) edecd0931e Fix filtering our owner & current user from shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
Nextcloud bot 09d7854d0e
[tx-robot] updated from transifex 2020-05-05 02:16:14 +00:00
John Molakvoæ (skjnldsv) ff20da637e Fix federated link sharing permissions
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
Morris Jobke 6aceb39714
Merge pull request #19124 from nextcloud/bug/13647/ignore-delete-groups
Exclude groups from sharing: Skip delete groups
2020-05-04 10:02:32 +02:00