6c81c65eea
Also prevent null byte character
2016-09-01 12:24:14 +02:00
7cd86cfe59
Filter out %0A from paths
2016-09-01 10:06:06 +02:00
7fa66409ae
Display number of hidden files in files summary ( #25870 )
...
When dot files are hidden, the table summary and selection summary will
not show how many hidden files were included.
2016-08-29 14:47:41 +02:00
e0ae67545e
Merge pull request #956 from nextcloud/fix_952
...
When using permalinks don't error out if file id can't be found
2016-08-23 00:58:25 +02:00
f7deb2c2eb
Fix hidden files handling
...
Hidden files (dot files) are now always rendered in the DOM to make
sure that all file operations and selection still work as expected.
Their visibility is now toggled on CSS level.
2016-08-19 10:26:19 +02:00
cc9b36131c
When requesting a permalink to an invalid file redirect
...
We need to do the redirect to update address bar.
2016-08-19 10:10:19 +02:00
54f79a28f6
When using permalinks don't error out if file id can't be found
...
Fixes #952
* Use only the index route (since it went to showFile anyways)
* Fix tests
* Use getUserFolder to force init of users mounts
2016-08-19 08:15:30 +02:00
c1632c3abd
Merge pull request #893 from nextcloud/ie8_be_gone
...
IE8 be gone!
2016-08-17 09:02:58 +02:00
9fd274c447
Remove IE8 support from ViewController
...
* Update tests
* Fix getMock in tests
2016-08-16 20:58:33 +02:00
7ffb7b0d84
Use MockBuilder instead of createMock
...
CI uses an older PHPUnit
2016-08-15 16:43:22 +02:00
8a7a0f3287
Add unit tests
2016-08-15 16:25:34 +02:00
217b52085d
Fix javascript tests for sidebar animation
2016-07-30 16:30:05 +02:00
c662e4b983
fix js test
2016-07-27 12:59:43 +02:00
f18338d932
fix test
2016-07-25 10:41:53 +02:00
a4ba3eadd0
fix test
2016-07-22 15:20:55 +02:00
0215b004da
Update with robin
2016-07-21 18:13:58 +02:00
813f0a0f40
Fix apps/
2016-07-21 18:13:57 +02:00
ba16fd0d33
Merge branch 'master' into sync-master
2016-07-07 11:29:46 +02:00
cf6fe95cbf
Merge pull request #25325 from owncloud/filelist-prependslash
...
Filelist change dir auto-prepend slash
2016-07-06 12:44:03 +02:00
1f9d728538
Ignore invalid paths in the JS file list ( #25368 )
2016-07-06 11:55:02 +02:00
76c73d5ec3
Match on 405
2016-07-01 15:19:21 +02:00
4ac9eaab03
Match for /../
2016-07-01 15:01:48 +02:00
5b65591d84
Do not allow directory traversal using "../"
...
We should not allow directory traversals using "../" here.
To test access the following URL once with and then without this patch:
http://localhost/server/index.php/apps/files/?dir=../../This+Should+Not+Be+Here
2016-07-01 13:36:05 +02:00
4acb06923d
Filelist change dir auto-prepend slash
...
Prepend a slash to directories in case it was missing since many places
assume that it's there.
2016-07-01 11:10:37 +02:00
6670d37658
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-27 18:23:00 +02:00
b4cf297758
Prerender file list pages to include search results
...
When filtering the file list, if a result is on an unrendered page,
make sure to call _nextPage() to prerender the pages in order to
display all matching results.
2016-06-24 13:55:14 +02:00
51b067d603
Fix failing JS unit tests
...
* fixes #124
2016-06-16 11:00:58 +02:00
68a7aed27b
Adjust test to work with phpunit < 5.2
2016-06-08 09:24:00 +02:00
77db6d3dbd
Improve the UX for "not found" perma links
2016-06-07 13:53:16 +02:00
3538e90ba1
fixes size of the download spinner
2016-05-30 11:23:54 +02:00
aba539703c
Update license headers
2016-05-26 19:57:24 +02:00
b34bacd071
Move Files app to PSR-4 ( #24569 )
...
* Move lib/ of Files app to PSR-4
* Move tests to PSR-4
2016-05-12 12:07:06 +02:00
ceaac03bb5
Make permalinks work for trashed files ( #24537 )
...
Opening a permalink that points to a trashed file will now display the
file within the "Deleted Files" section in the files web UI.
2016-05-11 19:41:36 +02:00
254576e1f7
Do not encode slashes in "dir" URL param in files JS
2016-05-06 17:00:22 +02:00
112b703df0
Add anchor icon in sidebar to copy permalink
2016-05-06 16:46:59 +02:00
fdeafef6a0
Auto-add fileid in URL for currently displayed folder
2016-05-06 16:46:59 +02:00
093e9dd422
Add route to resolve fileid to files app URL
...
The following routes will redirect to the files app and display the
matching folder. If the fileid is a file, it will scroll to it.
- http://localhost/owncloud/index.php/f/$fileid
- http://localhost/owncloud/index.php/files/?dir=somedir&fileid=$fileid
2016-05-06 16:46:59 +02:00
7bfc617b03
Move activity manager to the namespace
2016-05-02 11:57:24 +02:00
6c5696d3a8
filter hidden files on the web interface
...
add checkbox to toggle show/hide hidden files
persist show hidden setting
fix settings menu layout
test ApiController::showHiddenFiles
don't show hidden files by default
Store config in Backbone model and inject it into FileList
Filter files only temporarily when rending the file list
Fix file rename validation
2016-04-19 16:08:56 +02:00
576f7244e6
fix default value, update js/php tests
2016-04-13 14:25:23 +02:00
950530b162
Display share status info in favorite list
...
Returns the shareTypes share status info to the favorites file list.
2016-03-17 15:35:21 +01:00
3a36163e91
Fix download spinner to work with CSS styles
...
A recent change replaced img elements with CSS icons for file actions.
This fix adjusts the logic to work properly with CSS icons instead of
images.
2016-03-04 10:48:08 +01:00
933f60e314
Update author information
...
Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)
2016-03-01 17:25:15 +01:00
e9237dd83c
Merge pull request #22671 from owncloud/issue-22670
...
Move the tag filter at the end for now
2016-02-26 10:48:55 +01:00
4549b82553
Move the tag filter at the end for now
2016-02-26 10:15:07 +01:00
867a8aca12
Fix favorite icon unit test for icon image
2016-02-25 23:01:09 +01:00
92cff0984d
Make file actions use icon CSS classes
...
This makes theming of file actions possible
2016-02-25 22:49:52 +01:00
27544144ce
Fix unit tests affected by side effects
...
The notification tests were not restoring the clock properly, but
indirectly helped other tests pass.
Since now we're restoring the clock properly, the other tests were fixed
to still work.
2016-02-22 17:25:32 +01:00
7af7d18cfa
Merge pull request #16783 from owncloud/handle-redirects-global
...
Adding global error handler for ajax calls which run into redirection…
2016-02-17 14:49:04 +01:00
d565290d16
Close file detail sidebar when selecting/unselecting files
...
Interacting with the checkboxes, also "Select all" will automatically
close the sidebar now.
2016-02-15 14:58:44 +01:00
b8b77709c0
Add handler for global ajax errors
2016-02-15 12:48:47 +01:00
847a2426b8
Fix unit tests for system tag filter section
2016-02-09 11:22:05 +01:00
ae367c7e97
Fix elementToFile to also return path when defined
...
Fixes issue when opening the share dialog for a file inside the favorite
list, and the file is from a subfolder
2016-02-08 22:33:39 +01:00
d537cae063
cleanup jobs for comments and comment read marks
2016-02-05 15:36:21 +01:00
f0caf41232
Cleanup job for system and user tag orphaned when file was deleted
...
Whenever a file was deleted (also from trash), the tag mapping is
pointing at a fileid that doesn't exist any more.
This cleanup job will delete such orphaned mapping entries.
2016-01-29 11:51:47 +01:00
22010517f5
Merge pull request #21752 from owncloud/files-delete-fix
...
Only check selection for delete permissions, not parent folder
2016-01-26 16:13:10 +01:00
6e096936e5
update JS humanFileSize to use KB instead of kB
2016-01-19 10:51:57 +01:00
df7db3685e
Remove faulty directory permissions test
2016-01-15 20:46:39 +00:00
682821c71e
Happy new year!
2016-01-12 15:02:18 +01:00
665d7b25b0
Add unit test for file update
2016-01-09 22:47:26 +01:00
d27826bac0
Correctly render uploadtext indicator only on folders
2015-12-18 18:09:46 +01:00
1f715289bf
Removed deprecated function OC_User::deleteUser
...
Replaced with proper OCP calls
2015-12-17 16:18:40 +01:00
835911bce5
Removed deprecated private OC_User::createUser
...
All function calls are replaced with the recommended (which was already
the body of the function).
2015-12-17 16:18:40 +01:00
4d9e12b8bc
Fix mount type root detection
...
Since Webdav doesn't contain that information, we need to rely on the
parent folder's mount type to find out whether a child item is a
shared/external root or not.
Fixed the mount type detection logic and added unit test.
Also added a fix that ignores detection if no parent folder exists (ex:
shared file list, favorites, etc)
2015-12-14 10:44:47 +01:00
baa5a69c55
Bring back file delete action text to be based on context
...
For received shares, the delete action becomes "Unshare" and for
personal mounts it becomes "Disconnect storage".
This also makes it possible from now on to pass a function to a file
action's "displayName" attribute.
2015-12-11 15:14:30 +01:00
ffc49a24f0
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-12-10 16:43:37 +01:00
e241d26316
Compute share permissions in the view
...
The share permissions are now computed in the View/FileInfo instead of
storing them directly/permanently on the storage
2015-12-08 13:04:22 +01:00
2ceae43989
Merge pull request #20545 from owncloud/scan-storage-in-background-job
...
Move files/ajax/scan.php to background job
2015-12-03 16:53:46 +01:00
8aaab0dbad
Allow framing 'self'
...
This is required by the pdf viewer, since the files app on master uses the AppFramework it had applied the more strict defaults which made it not work on master.
2015-12-02 17:30:40 +01:00
23046ca5b7
Inject the database connection
2015-11-30 17:14:47 +01:00
e9094b8a41
Only require the interface
2015-11-30 17:14:47 +01:00
6e0596432c
Add a unit test that executes the query
2015-11-30 17:14:47 +01:00
623d34972d
Oracle can not return statements but only values
...
So evaluate the condition directly and return 1 or 0
2015-11-30 17:12:48 +01:00
1480964768
Adding more test suites to group DB
2015-11-30 10:55:05 +01:00
3bb6dcea64
Apply DB group annotation ...
2015-11-30 10:55:05 +01:00
391bc49dab
Move files/ajax/scan.php to background job
...
The background job will now be executed in chunks of 500 users all 10 minutes.
2015-11-28 13:06:53 +01:00
fa2be0750c
Make files app use Webdav for most operations
2015-11-22 16:05:50 +01:00
8fc0e05564
Remove "Text file" entry in the "+" menu
...
The text editor app will register this instead.
Also made "fileList" a non-private attribute to make it possible for
plugins to access the attached file list object.
2015-11-19 15:36:21 +01:00
daa388ce8d
Move index.php from files to AppFramework
...
1. Allows it to use the more secure CSP rules of the AppFramework.
2. Adds some unit tests.
2015-11-16 21:10:11 +01:00
80cf4e84e3
Fix file action download spinner
2015-10-30 14:58:53 +01:00
9c9158e6b7
Fix icon update to be more consistent
...
Makes the details bar show the same icon as in the list.
2015-10-29 12:59:51 +01:00
8f09d5b67c
Update license headers
2015-10-26 14:04:01 +01:00
abd0ba1f25
Fix file upload, conflict dialog, also in public link
...
- Use "FileList" instead of "OCA.Files.App.fileList" that doesn't exist in public
link page.
- Fix public link upload by properly adding the form data using a new
utility function "addFormData". That one is needed because IE8 upload
and regular upload use a different format...
2015-10-21 12:18:06 +02:00
899165113c
Merge pull request #19742 from owncloud/shareinfo_performance
...
Do not calculate non essential info
2015-10-20 14:25:36 +02:00
416da0dfe9
fix delete orphan shares test with object home storage
2015-10-16 21:41:51 +02:00
204b3ca189
Do not register sidebar panels when no sidebar
2015-10-15 16:30:50 +02:00
5e9ca79788
Do not calculate non essential info
...
There is no need to calculate a human readable date on the server side.
We supply the mtime and a client can easily convert that himself if
needed. This is already done most of the time since the date is often
not in the exact right format.
There is also no need to attach icon info. We have that available in
javascript. And else the client should get the right icon based on the
mimetype for its platform.
* Updated tests
2015-10-13 14:56:55 +02:00
b945d71384
update licence headers via script
2015-10-05 21:15:52 +02:00
6bf6ff9564
If an inline files action provides an alt text show it
...
* Added unit tests for icon display
* Added unit tests for icon alt text display
2015-10-03 15:47:20 +02:00
4b3a5a257f
Fix moment.js "a few seconds ago" with "seconds ago"
...
* fixes #18627
2015-10-02 10:51:51 +02:00
750f19340f
Merge pull request #19310 from owncloud/hide-sort-indicator
...
hide sort indicator when in multiselect mode, ref #19056
2015-09-30 11:07:45 +02:00
733673b39d
Merge pull request #19365 from owncloud/files-detailsbar-interaction
...
Fix sidebar interaction
2015-09-29 14:44:28 +02:00
d52361b09b
Disable sorting when multiselect is enabled in file list
2015-09-29 13:24:33 +02:00
f9acf4627e
Fix sidebar interaction
...
- Clicking a file row or selecting it will open the sidebar.
- When sidebar is open, its contents update with the last selection.
- Dragging doesn't open the sidebar but does update its contents if it was
open already.
- Switching folders closes the sidebar.
- Close sidebar when highlighted file got deleted/removed from list
2015-09-28 15:23:37 +02:00
a8fb0038e9
Hide sidebar tab headers conditionally
...
Added canDisplay() in DetailsTabView that should return false if the tab
header of this tab must be hidden
2015-09-28 14:57:44 +02:00
72024ad201
Merge pull request #19404 from owncloud/files-sidebar-sorttabs
...
Fix tabs order in files sidebar
2015-09-28 12:55:38 +02:00
5e4a52d3c2
Fix tabs order in files sidebar
2015-09-28 12:30:12 +02:00
f35b6833ff
Fix order of actions in the files actions menu
2015-09-28 11:19:49 +02:00
004de1425e
Merge pull request #18630 from owncloud/files-combineuploadbutton
...
Combine upload action into the "New" menu
2015-09-07 14:03:57 +02:00
310d797284
Add versions tab to files sidebar
...
- move versions to a tab in the files sidebar
- added mechanism to auto-update the row in the FileList whenever values
are set to the FileInfoModel given to the sidebar
- updated tags/favorite action to make use of that new mechanism
2015-09-03 16:47:24 +02:00
73c61941e2
Tags in FileInfo map must be an array
...
Fixes FileList.elementToFile to make an array for the tags instead of
keeping the original joined string
2015-09-03 13:01:14 +02:00
4ba2333507
Added unit tests for "new" file menu and small fixes
...
- added unit tests for NewFileMenu
- use generateUrl for FileList.createFile and FileList.createDirectory
- added unit tests for FileList.createFile and FileList.createDirectory
2015-09-03 12:17:35 +02:00
3ea9f97c36
Fix sidebar thumbnail loading JS unit tests
2015-09-03 08:24:50 +02:00
c6053daf43
Fixes failing tests
2015-08-31 00:14:07 +02:00
5e6fa3c938
Fix trashbin sidebar
...
Do not display size as it is not available.
Use display name instead of name to remove the ".d123456" suffix.
2015-08-25 11:29:35 +02:00
37939fb0e8
Parse mtime from the data attributes
2015-08-24 17:16:20 +02:00
31d62c10bf
Merge pull request #17501 from tbartenstein/patch-1
...
Update fileinfo.php
2015-08-24 09:57:27 +02:00
5e1c2aecc7
fix unit test for folder renaming (icon)
...
fix unit test to go with #17501 and check for the new icon
2015-08-21 18:54:09 +02:00
ffff156965
Merge pull request #18310 from hasso/selection-string-fix
...
Fix the string counting a selected files/dirs
2015-08-18 10:43:17 +02:00
97bc73ad49
Update unit test to reflect the string change
2015-08-17 15:31:44 +03:00
e2549fa660
Improve right sidebar tabs behavior
...
Tab heads are not rendered if only one tab.
The tab contents is updated on-demand. This means that if a tab is not
visible it is not rendered at first. If the tab was already rendered
through switching, its model will not get updated until the next time it
becomes visible. This will prevent needless rerendering of invisible tab
contents, especially considering that some tabs might need extra ajax
requests.
2015-08-14 16:51:04 +02:00
c964eff17b
Make file actions work from sidebar
...
The favorite icon in the sidebar now triggers the file action and also
updates itself according to the model's state when triggered from the
file row.
The thumbnail triggers the default action.
Currently only one FileInfoModel is used for the selection and state
synchronization between views.
FileList reload now auto-closes the sidebar.
2015-08-12 17:30:20 +02:00
d04a6bce6f
Merge pull request #17709 from owncloud/fileactions-dropdown
...
Move file actions to dropdown
2015-08-11 15:13:59 +02:00
0abc637782
Merge pull request #18171 from owncloud/fix-language-of-files-activities-in-emails
...
Correctly make use of the languageCode argument in the files activity extension
2015-08-11 12:34:58 +02:00
984ae8140d
Fixed file actions menu to close when reclicking trigger
...
FileActionsMenu is now a backbone view.
The trigger and highlight handling is now done in the
FileActions.showMenu() method using events.
2015-08-11 11:35:46 +02:00
81c3bbad57
Correctly make use of the languageCode argument in the files activity extension
2015-08-10 14:40:33 +02:00
9454e9043a
Updated unit tests for file actions and actions menu
2015-08-10 14:12:34 +02:00
038d29b8de
Fix unit test for tipsy->tooltip change
2015-08-10 11:23:39 +02:00
9c402c761f
fix timezone issue with unittest
2015-08-07 01:22:45 +02:00
bdfab8108e
Fix sidebar mtime display unit test
2015-08-07 01:22:45 +02:00
781ba420c9
Use own tabs impl in files sidebar
...
Also change style.
2015-08-07 01:22:44 +02:00
734c6b0b6f
extend MainFileInfoDetailView JS tests
2015-08-07 01:22:43 +02:00
e0bcd56402
More work on right sidebar unit tests
2015-08-07 01:22:43 +02:00
3e44ca6dc2
Added unit tests for right sidebar
2015-08-07 01:22:43 +02:00
5699fff889
Merge pull request #17175 from owncloud/add-download-feedback
...
Add loading spinner to download icon
2015-07-30 16:34:35 +02:00
eb7a796ad9
Fix unit tests
2015-07-09 18:42:46 +02:00
3d8297c254
Fix unit tests and introduce better mocks of the HTML
2015-07-07 13:56:49 +02:00
d1f0ff372e
Merge pull request #17163 from owncloud/update-licenses
...
Update license headers
2015-06-27 20:22:23 +02:00
ca1da0acb7
add check if server returns a 500 and display error
...
resolves https://github.com/owncloud/core/issues/17170
2015-06-26 12:50:09 -04:00
f63915d0c8
update license headers and authors
2015-06-25 14:13:49 +02:00
5466dcadc0
adding correct blocking logic for fff
2015-06-22 11:42:42 -04:00
13617c8bf1
Check target name on rename with web UI
...
When renaming over the web UI, check early that the target name is
valid.
This prevents nonsensical error messages when renaming to a name with a
trailing backslash.
2015-05-29 19:30:09 +02:00
fdbc21fc6c
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2015-05-19 11:23:06 +00:00
69f88b38c9
Fix file name validation in New menu
2015-04-27 16:31:18 +02:00
f4bc852db3
Show hint if there is no delete permission
...
* add class .no-permission which shows the default delete icon
* fixes #15172
* add unit test for no permission and for delete permission
2015-04-23 21:49:59 +02:00
53a23364ef
Added empty content message for empty read-only folders
2015-04-21 14:31:13 +02:00
02614d214e
Merge pull request #15437 from owncloud/deleteorphanedfiles
...
[command] delete orphaned file cache entries
2015-04-10 00:09:56 +02:00
9c76d068c3
Merge pull request #15196 from owncloud/limit-file-activities-to-favorites
...
Limit file activities to favorites
2015-04-09 00:18:31 +02:00
f8cfc03f36
Replace originalStorage in tests with a proper teardown
...
The purpose of $originalStorage in unit tests was to remount the old
root.
However that storage itself is already wrapped by storage wrapper, so
remounting it would rewrap the storage several times.
This fix makes use of "loginAsUser()" and "logout()" from the TestCase
class to properly initialize and cleanup the FS as expected.
2015-04-08 12:45:38 +02:00
cefdcea021
[command] delete orphaned file cache entries
...
* ./occ files:cleanup
* delete file cache entries without an existing storage
2015-04-08 10:23:56 +02:00
e16d61e293
Remove server timezone dependency from files list test
2015-04-07 10:12:15 +02:00
730efe25a4
Make scrutinizer happy
2015-04-01 12:13:49 +02:00
efcc2e87ab
Adjust by/self filter aswell and fix tests
2015-03-31 17:35:04 +02:00
9233d32834
Move tag related code into a helper so we can test the query without a view
2015-03-30 17:21:06 +02:00
2b0906cdff
Adding a pending indicator to the files summary - fixes #14853
2015-03-27 01:16:29 +01:00
a8b756154a
Merge pull request #14495 from owncloud/update-mailmap-01
...
Updating .mailmap
2015-03-26 17:17:18 +01:00
b585d87d9d
Update license headers
2015-03-26 11:44:36 +01:00
92f0dba3c8
Show hidden files (dot files) in gray
2015-03-26 10:35:27 +01:00
dac4436807
Merge pull request #15170 from owncloud/middleclickbreadcrumb
...
Fix middle click on breadcrumb
2015-03-26 00:19:52 +01:00
b3de3d7245
Fix breadcrumb click JS unit test
2015-03-25 09:27:55 +01:00
Joas Schilling
Vincent Petry
Lukas Reschke
Roeland Jago Douma
Marius Blüm
Julius Haertl
Robin Appelman
Robin Appelman
Morris Jobke
Lukas Reschke
Joas Schilling
Vincent Chan
Joas Schilling
Christoph Wurst
Thomas Müller
Roeland Jago Douma
Arthur Schiwon
Robin McCorkell
Scrutinizer Auto-Fixer
Jan-Christoph Borchardt
Raghu Nayyar
tbartenstein
Hasso Tepper
Clark Tomlinson
Jenkins for ownCloud