Joas Schilling
570c1bf7c4
Display errors that happen on saving
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Joas Schilling
e17cd8acb4
Bump 3rdparty to include giggsey/libphonenumber-for-php
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Joas Schilling
c2913f18d2
Also return the phone number and twitter handle on the API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Joas Schilling
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Roeland Jago Douma
f480436c67
21 beta1
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 13:14:16 +01:00
John Molakvoæ
e02c9ec1bf
Merge pull request #24581 from nextcloud/bugfix/noid/setup-js
...
Do not load nonexisting setup.js
2020-12-07 09:17:06 +01:00
John Molakvoæ
76ffc46c01
Merge pull request #24578 from nextcloud/add-integration-tests-for-avatars
2020-12-07 09:16:52 +01:00
Julius Härtl
df769c025a
Do not load nonexisting setup.js
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-07 07:39:25 +01:00
Daniel Calviño Sánchez
b4b3276a5b
Add integration tests for getting guest avatars
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:48:00 +01:00
Daniel Calviño Sánchez
1552add4ca
Add integration tests for resized user avatars
...
Even on solid color images the resizing can cause some small artifacts
that slightly modify the color of certain pixels. Due to this now the
color comparison is no longer strict but fuzzy.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:48:00 +01:00
Daniel Calviño Sánchez
2cc22a06b4
Add integration tests for user avatars
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:47:56 +01:00
Daniel Calviño Sánchez
184742e6ff
Make possible to set body in requesttoken requests in integration tests
...
"sendingAToWithRequesttoken" needs to be used to test some non OCS
endpoints which require the request token to be sent in the request. Now
it is possible to specify the body (or, rather, additional contents
beside the cookies and the request token) for those requests, as it will
be needed for example to upload an avatar.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:32:00 +01:00
Daniel Calviño Sánchez
b553b43b68
Make possible to send requests as anonymous users in integration tests
...
Until now requests always had "auth" headers either for an admin or a
regular user, depending on the value of "currentUser". Now, if
"currentUser" starts by "anonymous" no "auth" header is sent, which
makes possible to also test requests with users not logged in.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:32:00 +01:00
Nextcloud bot
eab710c2fd
[tx-robot] updated from transifex
2020-12-07 02:20:42 +00:00
Nextcloud bot
e41e2fe003
[tx-robot] updated from transifex
2020-12-06 02:19:28 +00:00
Nextcloud bot
9a6569d4f2
[tx-robot] updated from transifex
2020-12-05 02:18:50 +00:00
Christoph Wurst
cbb34af53f
Do not update incompatible apps
...
Previously there was no (platform) dependency check for an app that was
installed before. So Nextcloud happily upgraded an app that now requires
a php version newer than the current one. Which means in the lucky case
you see a failing upgrade due to the language incompatibility, or in the
unlucky case you see unexpected errors later in production.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-04 17:05:22 +01:00
Christoph Wurst
24237f1a34
Check php compatibility of app store app releases
...
Apps might increase the minimum php version requirement, in which case
an update could break the app or even the whole instance. We must not
install those releases, or better, don't even show them for
update/installation. This extends the app fetcher code to filter out the
releases that are not installable.
The filter respects minimum and maximum requirements. E.g. apps that are
still only released for php7.3 won't show up for php7.4 instances. This
behavior is new but if an app lists an explicit version requirement,
then we ought to repect that.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-04 16:52:31 +01:00
Roeland Jago Douma
f0862dcfaa
Merge pull request #24552 from nextcloud/enh/remember_me_is_not_app_password
...
Remember me is not an app_password
2020-12-04 16:35:44 +01:00
Morris Jobke
0d7819eb6c
Merge pull request #24550 from nextcloud/enh/fix/new_session_id_if_decrypt_fails
...
Generate a new session id if the decrypting the session data fails
2020-12-04 12:52:59 +01:00
Morris Jobke
5cc348ae72
Fix typo
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-04 12:51:45 +01:00
Roeland Jago Douma
48b4b83b5a
Remember me is not an app_password
...
While technically they are stored the same. This session variable is
used to indicate that a user is using an app password to authenticate.
Like from a client. Or when having it generated automatically.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 12:40:28 +01:00
Roeland Jago Douma
858f623081
Generate a new session id if the decrypting the session data fails
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 11:42:40 +01:00
Joas Schilling
cb7b8998e4
Merge pull request #24545 from nextcloud/bugfix/noid/force-composerv2
...
Always install composer v2
2020-12-04 10:56:35 +01:00
Morris Jobke
3c62d2bcae
Merge pull request #24543 from nextcloud/bugfix/noid/dont-log-image-as-string
...
Don't log params of imagecreatefromstring
2020-12-04 10:42:49 +01:00
Julius Härtl
a1a4fa2ac2
Always install composer v2
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-04 10:11:02 +01:00
Vincent Petry
9b3361ce87
Don't log params of imagecreatefromstring
...
To prevent flooding the log with actual image data.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-04 09:30:20 +01:00
Christoph Wurst
32ded877dc
Merge pull request #24474 from nextcloud/enhancement/unified-search-result-attributes
...
Allow unified search results to have attributes
2020-12-04 08:42:15 +01:00
Nextcloud bot
3f88dbd259
[tx-robot] updated from transifex
2020-12-04 02:19:19 +00:00
Roeland Jago Douma
7d9004c885
Merge pull request #24535 from nextcloud/fix/multiple_file_download
...
Fix the download of multiple files from the webUI
2020-12-03 18:59:39 +01:00
Christoph Wurst
885dabb761
Add attributes to file search results
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-03 18:24:33 +01:00
Christoph Wurst
cc92d5a293
Allow unified search results to have attributes
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-03 18:24:33 +01:00
Morris Jobke
fc57f60ece
Merge pull request #24358 from nextcloud/dav-storage-copy
...
use storage copy implementation when doing dav copy
2020-12-03 15:03:13 +01:00
Roeland Jago Douma
c9cd633665
Fix the download of multiple files from the webUI
...
needed a setupFS call
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 13:20:01 +01:00
Joas Schilling
64bc7c79e8
Merge pull request #24498 from nextcloud/enhancement/nextcloud-log-normalizer
...
Replace abandoned log normalizer with our fork
2020-12-03 11:04:49 +01:00
Morris Jobke
d7207d838a
Merge pull request #24409 from nextcloud/bugfix/24399
...
Also run repair steps when encryption is disabled but a legacy key is present
2020-12-03 10:54:08 +01:00
Christoph Wurst
0e99d3c1a0
Merge pull request #24516 from nextcloud/enh/23278/add-icon-for-notification
...
Add icon to user limit notification
2020-12-03 09:58:28 +01:00
Julius Härtl
04d67d558e
Also handle legacy cipher support when encryption is disabled but an old master key is present
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-03 09:47:05 +01:00
Christoph Wurst
244c53dea1
Replace abandoned log normalizer with our fork
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-03 09:44:25 +01:00
Morris Jobke
4d64ec9944
Merge pull request #24519 from nextcloud/fix/bug/emailtemplate
...
Fix vsprint parameter
2020-12-03 09:13:58 +01:00
Christoph Wurst
fbc06d39c7
Merge pull request #24429 from nextcloud/3rdparty/closure
...
[3rdparty] Migrate to Opis/Closure
2020-12-03 08:44:53 +01:00
Roeland Jago Douma
3d315ec64f
Fix vsprint parameter
...
%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 08:25:11 +01:00
Morris Jobke
b52a1e196e
Merge pull request #24524 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
...
[Automated] Update psalm-baseline.xml
2020-12-03 06:47:11 +01:00
Nextcloud-PR-Bot
3c606cbec3
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-12-03 04:29:05 +00:00
Nextcloud bot
0dcc227a6b
[tx-robot] updated from transifex
2020-12-03 02:19:51 +00:00
Morris Jobke
2fb31e9b5d
Improve wording
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 21:42:32 +01:00
Morris Jobke
09754461df
Merge pull request #24459 from nextcloud/fix/23096/workflow-fix-mimetype-check-for-directories
...
Only execute plain mimetype check for directories and do the fallback…
2020-12-02 21:00:05 +01:00
Morris Jobke
40ebe24960
Update psalm-baseline.xml
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 20:27:14 +01:00
Roeland Jago Douma
04c037ebfd
[3rdparty] Migrate to Opis/Closure
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-02 20:16:57 +01:00
Morris Jobke
bd0a77269f
Add icon to user limit notification
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 20:13:33 +01:00