Commit Graph

8200 Commits

Author SHA1 Message Date
Rémy Jacquin 04e1cab5ee
Fix translation bug on lost password page
Fix nextcloud/password_policy#26

Signed-off-by: Rémy Jacquin <remy@remyj.fr>
2018-05-20 12:51:50 +02:00
John Molakvoæ (skjnldsv) 16af12e0a0
Fixed webpack config, groups flex thanks to @juliushaertl and groups tooltip
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-18 17:47:10 +02:00
John Molakvoæ (skjnldsv) 38b1020f52
Bump webpack, config, deps, fixes groups selects, improved design and added tooltip to groups +x indicator
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-18 16:39:34 +02:00
Nextcloud bot 514b374923
[tx-robot] updated from transifex 2018-05-18 00:13:45 +00:00
Roeland Jago Douma 9236c20a28
Merge pull request #9437 from nextcloud/feature/noid/imprint
allow to specify a link to a legal notice
2018-05-17 21:16:03 +02:00
Roeland Jago Douma 4a19079b06
Bump autosize to 4.0.2
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 16:42:16 +02:00
Roeland Jago Douma 6b7cf46727
Certain tokens can expire
However due to the nature of what we store in the token (encrypted
passwords etc). We can't just delete the tokens because that would make
the oauth refresh useless.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 16:10:19 +02:00
Morris Jobke 9f064b08b3
Merge pull request #9507 from nextcloud/dep/noid/update_dompurify_1_0_4
Bump DOMPurify to 1.0.4
2018-05-17 16:02:38 +02:00
Roeland Jago Douma 972bc9491a
Bump DOMPurity to 1.0.4
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-17 13:24:00 +02:00
Nextcloud bot ef665fde42
[tx-robot] updated from transifex 2018-05-17 00:13:46 +00:00
John Molakvoæ (skjnldsv) 170746dada
Design fixes
- Gap between columns
- Click on icon more closes the menu
- Fixed select height
- Focus input on new user click
- Cursor fix on select

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:24 +02:00
John Molakvoæ (skjnldsv) f0586b2eb1
Last login tooltip and v-tooltip server compatibility css
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
John Molakvoæ (skjnldsv) 6ada8254c9
Added language support in users list
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:21 +02:00
John Molakvoæ (skjnldsv) 2ae82137cd
Group filtering, disable state, ocs api final update
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:20 +02:00
John Molakvoæ (skjnldsv) c8f670dd8f
Settings to vuejs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:20 +02:00
Morris Jobke 3e513809c2
Merge pull request #9429 from nextcloud/feature/noid/move_webui_to_new_dav
Move the webui over to the new dav endpoint
2018-05-14 13:35:23 +02:00
Nextcloud bot 68dc6a306e
[tx-robot] updated from transifex 2018-05-14 00:13:27 +00:00
Nextcloud bot 5fcb3dd1dc
[tx-robot] updated from transifex 2018-05-12 00:13:00 +00:00
Arthur Schiwon 84ab102146
fix undo for url-typed inputs
and minor adjustments

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-11 15:57:32 +02:00
Nextcloud bot 01c21601e8
[tx-robot] updated from transifex 2018-05-10 00:13:09 +00:00
Arthur Schiwon 62f1156a56
allow to specify a link to a legal notice
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-09 15:52:41 +02:00
Nextcloud bot 412925e71d
[tx-robot] updated from transifex 2018-05-09 00:11:27 +00:00
Roeland Jago Douma d607e7b924
Move the webui over to the new dav endpoint
We should use the new dav endpoint everywhere now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-08 23:02:19 +02:00
Julius Härtl 897898a93b
Add data-id to settings navigation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-08 13:14:02 +02:00
Nextcloud bot 9fe95e8a7c
[tx-robot] updated from transifex 2018-05-08 00:11:34 +00:00
Morris Jobke 6180feeb9d
Merge pull request #9381 from nextcloud/feature/noid/add-autocomplete-to-migration-commands
Add autocomplete to migration commands
2018-05-07 18:46:50 +02:00
Morris Jobke 43c1e51a5f
Merge pull request #9151 from UncleAlbie/dialog-sort
Sort files in dialog by name.
2018-05-07 18:39:24 +02:00
John Molakvoæ e5b61781ec
Fixed padding
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-07 14:11:00 +02:00
John Molakvoæ (skjnldsv) fbe9166076
Highlight element change and alignement fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-07 14:11:00 +02:00
Joas Schilling b045272951
Add support for a highlighted navigation counter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-07 14:11:00 +02:00
Morris Jobke d161d4473e
Merge pull request #9029 from nextcloud/settings-restructure
Restructure server settings
2018-05-07 12:29:53 +02:00
Nextcloud bot cc09226564
[tx-robot] updated from transifex 2018-05-06 00:11:39 +00:00
Nextcloud bot 1ce3a618a8
[tx-robot] updated from transifex 2018-05-05 00:11:47 +00:00
Nextcloud bot bd2aede6a3
[tx-robot] updated from transifex 2018-05-04 00:11:52 +00:00
Morris Jobke 2d66f04aa0
Merge pull request #9340 from gboudreau/dev/chrome-devconsole-sourcemap-warnings
Resolves warnings in Chrome Dev Console
2018-05-03 16:58:41 +02:00
Joas Schilling f772b7b4dd
Add autocomplete to migration commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-05-03 16:52:56 +02:00
Julius Härtl 94528ad2be
Move quota icon to core
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 10:32:16 +02:00
Julius Härtl 4b550eb699
Move quota bar to info section and make it a bit simpler
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 10:32:14 +02:00
Julius Härtl 154a579651
Increase visibility of the warning color
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
Nextcloud bot 346e46af49
[tx-robot] updated from transifex 2018-05-03 00:11:58 +00:00
Nextcloud bot b87b0689c5
[tx-robot] updated from transifex 2018-04-30 00:11:48 +00:00
Guillaume Boudreau eb97035312
Resolves warnings in Chrome Dev Console:
"DevTools failed to parse SourceMap: .../core/vendor/..."
2018-04-29 09:29:56 -04:00
Morris Jobke d8350c69ef
Merge pull request #9309 from nextcloud/feature/noid/no_js_sharepermission_logic
Do not add sharePermission logic in JS
2018-04-27 14:01:40 +02:00
Nextcloud bot 9e3522af54
[tx-robot] updated from transifex 2018-04-27 00:11:53 +00:00
Roeland Jago Douma 0771dad57f
Do not add sharePermission logic in JS
We have a dedicated dav property. We should do all the magic in 1 place.
Not several.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 12:14:37 +02:00
Arthur Schiwon 38a90130ce
move log constants to ILogger
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
Nextcloud bot 9339c7d20f
[tx-robot] updated from transifex 2018-04-24 00:11:53 +00:00
Nextcloud bot 74b5ab8d39
[tx-robot] updated from transifex 2018-04-22 00:11:51 +00:00
Nextcloud bot 6b5132502e
[tx-robot] updated from transifex 2018-04-21 00:11:39 +00:00
Morris Jobke 0580f498f2
Merge pull request #9254 from nextcloud/fix-app-sidebar-offset
Also adjust app sidebar offset to new header height
2018-04-20 17:13:52 +02:00
Julius Härtl dbfd00897f
Also adjust app sidebar offset to new header height
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-20 14:22:06 +02:00
Nextcloud bot 8748e636f6
[tx-robot] updated from transifex 2018-04-20 00:12:00 +00:00
Morris Jobke 0bae516c66
Merge pull request #9224 from nextcloud/accessibility-improvements
Add labels for Contacts menu and Settings, thanks to @MarcoZehe
2018-04-19 14:47:17 +02:00
Morris Jobke 4d71e12a43
Merge pull request #9237 from nextcloud/fix-ids-of-permission-checkboxes-for-shares
Fix ids of permission checkboxes for shares
2018-04-19 14:11:51 +02:00
Nextcloud bot 7ca526f8ac
[tx-robot] updated from transifex 2018-04-19 00:11:50 +00:00
Daniel Calviño Sánchez f8e3b572c8 Remove no longer needed escaping of special characters
The escaping of special characters was needed when the ids of the
permission checkboxes for shares were based on the "shareWith" field.
Since they are based on the "shareId" field the escaping is no longer
needed, as the "sharedId" is expected to always contain compatible
characters.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 17:03:45 +02:00
Jan-Christoph Borchardt 0f9ba852bc
Fix form labels and main landmark on log in page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 16:14:09 +02:00
Jan-Christoph Borchardt 1c00f82ea5
Do not restrict zooming in
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:51:52 +02:00
Jan-Christoph Borchardt 0ee9924b16
Add aria-label to more-apps menu as well
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:40:47 +02:00
Jan-Christoph Borchardt 0d675eca56
Ensure proper color contrast according to WCAG AA
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:38:30 +02:00
Daniel Calviño Sánchez 1466586033 Fix ids of permission checkboxes for shares
The ids of permission checkboxes for shares were generated using the
"shareWith" field of the share. The "shareWith" field can contain spaces
(as spaces are allowed, for example, in user or circle names), so this
could cause the id attribute of the HTML element to contain spaces too,
which is forbidden by the HTML specification.

It is not just a "formal" issue, though; when the list was rendered, if
the id contained a space the selector to get the checkbox element was
wrong (as it ended being something like
"#canEdit-view1-name with spaces") and thus the initial state of the
checkbox was not properly set.

Besides that, "shareWith" can contain too single quotes, which would
even cause the jQuery selector to abort the search and leave the UI in
an invalid state.

Instead of adding more cases to the regular expression to escape special
characters and apply it too when the ids are created now the ids of
permission checkboxes for shares are based on the "shareId" field
instead of on "shareWith", as "shareId" is expected to always contain
compatible characters.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 15:25:23 +02:00
Jan-Christoph Borchardt df3c1ac283
Add proper ARIA attributes and structure to header for accessibility, thanks to @MarcoZehe
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:07:42 +02:00
Patrik Novotný e977246d7c Sort files in dialog by name.
Signed-off-by: Patrik Novotný <patrik.novotny@gmx.com>
2018-04-18 08:44:40 +02:00
Nextcloud bot d4aa4ff1f4
[tx-robot] updated from transifex 2018-04-18 00:13:30 +00:00
Morris Jobke 0d5142be70
Show a link to the docs instead of a button on the untrusted domain page
Before there was a button to "quickly" add the untrusted domain to the config. This button often didn't worked, because the generated URL was often untrusted as well. Thus removing it and providing proper docs seems to be the better approach to handle this rare case.

Also the log should not be spammed by messages for the untrusted domain accesses, because they are user related and not necessarily an administrative issue.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-17 17:47:11 +02:00
Morris Jobke db8bcfc5f6
Merge pull request #9172 from nextcloud/karma-avatar-tests-fix
Fix js tests with placeholder
2018-04-16 11:32:30 +02:00
Nextcloud bot 13b5e257ab
[tx-robot] updated from transifex 2018-04-14 00:11:46 +00:00
John Molakvoæ (skjnldsv) 6cb40cf0c4
Fix js tests with placeholder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-13 10:20:51 +02:00
Nextcloud bot b7a64f9c13
[tx-robot] updated from transifex 2018-04-13 00:11:47 +00:00
Jan-Christoph Borchardt 04f47a7653
Merge pull request #8535 from nextcloud/new-color-generator
New color generator algorithm
2018-04-12 14:37:53 +02:00
Morris Jobke d3f2b6aef4
Merge pull request #8820 from nextcloud/mtime-sort
Sorts filepicker files by modified date
2018-04-12 10:54:44 +02:00
Nextcloud bot af53f48ce2
[tx-robot] updated from transifex 2018-04-12 00:19:20 +00:00
Nextcloud bot ecc3bc64aa
[tx-robot] updated from transifex 2018-04-11 00:21:34 +00:00
Morris Jobke e302266a6a
Merge pull request #9137 from nextcloud/default-log-rotate-size
Set the default log rotate size to 100 MB
2018-04-11 02:10:54 +02:00
Morris Jobke 52c0e02bdc
Merge pull request #8910 from nextcloud/fix-login-error
Avoid to leak a user ID that is not a string to reach a user backend
2018-04-11 01:06:38 +02:00
Roeland Jago Douma a3c2035674
Merge pull request #9128 from nextcloud/bugfix/9076/make_oracle_happy
Also make the uid_lower migration work on oracle
2018-04-11 00:41:53 +02:00
Morris Jobke 058f8123e6
Set the default log rotate size to 100 MB
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 00:27:51 +02:00
Roeland Jago Douma a07f6d46e3
Use proper types
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-11 00:21:25 +02:00
Morris Jobke fd3c97b93b
Avoid to leak a user ID that is not a string to reach a user backend
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-11 00:03:30 +02:00
Jan-Christoph Borchardt 8d27dce716
Merge pull request #9002 from nextcloud/whitespace
More whitespace: Increase header height from 45px to 50
2018-04-10 23:05:01 +02:00
Julius Härtl 85cb130510
Fix max-width to fit the new margin
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-10 21:34:51 +02:00
Roeland Jago Douma 24cfee8cdd
Also make it the uid_lower migration work on oracle
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-10 10:47:31 +02:00
Nextcloud bot 323ee3cbdc
[tx-robot] updated from transifex 2018-04-10 00:12:10 +00:00
Roeland Jago Douma 123d9f0ce9
Merge pull request #8777 from nextcloud/various-css-fixes
Various css fixes
2018-04-09 10:19:50 +02:00
Roeland Jago Douma b2350810e0
Merge pull request #9115 from nextcloud/feature/noid/login_flow_wording
Improve login flow
2018-04-09 08:45:27 +02:00
Roeland Jago Douma 04f8b99dce
Merge pull request #9118 from nextcloud/video-switch
Add video switch icon
2018-04-09 07:12:24 +02:00
Roeland Jago Douma 177c8972cc
Improve login flow
* Add page explaining you are about to grant access
* Show grant access page after login

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-08 13:42:36 +02:00
Nextcloud bot 72e8ab14ac
[tx-robot] updated from transifex 2018-04-08 00:12:00 +00:00
Jan-Christoph Borchardt 203a8f293b
Add video switch icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-07 20:53:36 +02:00
Nextcloud bot 9f194bc682
[tx-robot] updated from transifex 2018-04-07 00:11:49 +00:00
Roeland Jago Douma 33b93db953
Remove unused parameter
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 21:44:23 +02:00
John Molakvoæ (skjnldsv) 275b9868b2
Fixed documentation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:45 +02:00
John Molakvoæ (skjnldsv) bca8d83f02
New algorithm
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-04-06 21:32:44 +02:00
Roeland Jago Douma 2b7d4d5069
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 19:58:37 +02:00
Roeland Jago Douma caee215120
Always remember me
Fixes #8004

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 15:44:28 +02:00
Roeland Jago Douma e970e9f710
Merge pull request #9076 from nextcloud/feature/7573/user_db_backend_index
Make select queries on user DB backend indexable
2018-04-06 14:56:19 +02:00
Roeland Jago Douma 31454c2072
Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 14:14:58 +02:00
Roeland Jago Douma f90299face
Silence phan
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 13:46:32 +02:00
Roeland Jago Douma 7a7d424e91
Add an uid_lower column to the oc_users table
Add a new column.
In the postSchemaChange copy over the values (with lower).

This should work just fine as this is a very simple operation.
Even if you have 1M users in the db backend this should be fast
enough.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 13:42:50 +02:00
Morris Jobke 2a2ab1b871
Merge pull request #9084 from nextcloud/public-page-template-extend
Public page template enhancements
2018-04-06 13:16:26 +02:00
Nextcloud bot a97b9bf605
[tx-robot] updated from transifex 2018-04-06 00:14:22 +00:00
Julius Härtl 2e60f91ab1
Move external share saving to template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 13:11:55 +02:00
Julius Härtl 30e76f9f14
Add footer to public page template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 12:22:01 +02:00
Julius Härtl bbeb3402b6
Move styling and menu handling to publicpage.js
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 12:21:39 +02:00
Nextcloud bot 0c12c06325
[tx-robot] updated from transifex 2018-04-05 00:11:47 +00:00
Julius Härtl 2887b9bdab
Fix arrow position on mobile
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:59 +02:00
Julius Härtl f37f145c55
Fix settings menu offset
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:59 +02:00
Julius Härtl 4a3538bbd8
Fix app menu, popovers and searchbox
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:58 +02:00
Julius Härtl bb37bdbfc4
Add more space to the logo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-04 15:05:58 +02:00
Jan-Christoph Borchardt 8089838f57
Increase header height from 45px to 50
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-04 15:05:58 +02:00
Nextcloud bot 5105f1d466
[tx-robot] updated from transifex 2018-04-03 00:11:47 +00:00
Nextcloud bot 25c479c0c5
[tx-robot] updated from transifex 2018-04-02 00:11:49 +00:00
Nextcloud bot 21b7611457
[tx-robot] updated from transifex 2018-04-01 00:11:48 +00:00
Nextcloud bot 0f398e7611
[tx-robot] updated from transifex 2018-03-31 00:13:51 +00:00
Nextcloud bot 9dad5ac59b
[tx-robot] updated from transifex 2018-03-28 00:21:16 +00:00
Nextcloud bot e2b44d199b
[tx-robot] updated from transifex 2018-03-26 00:13:15 +00:00
Nextcloud bot 89ebb8a663
[tx-robot] updated from transifex 2018-03-25 01:09:58 +00:00
Nextcloud bot 3b6a45b926
[tx-robot] updated from transifex 2018-03-24 01:12:19 +00:00
Morris Jobke 7892a0e293
Merge pull request #8936 from nextcloud/fix-gallery-selectors
Fix gallery buttons selector
2018-03-23 08:16:16 +01:00
Nextcloud bot 64948bf30c
[tx-robot] updated from transifex 2018-03-23 01:11:28 +00:00
Morris Jobke 8c6b6b1f0d
Merge pull request #8886 from nextcloud/navigation-indicator
Make active navigation indicator more obvious
2018-03-22 14:19:03 +01:00
John Molakvoæ (skjnldsv) 25ea0e68cf
Fix gallery buttons selector
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 12:59:05 +01:00
Roeland Jago Douma 6eb2088dd9
Merge pull request #8939 from nextcloud/fix-8701
Fix search text overlapping close button
2018-03-22 12:52:46 +01:00
Morris Jobke 91b9c0d2c4
Merge pull request #8909 from nextcloud/feature/noid/make-the-autocomplete-endpoint-ocs
Make the new autocomplete endpoint OCS
2018-03-22 11:53:23 +01:00
Julius Härtl 138ae59901
Make text of edit entry being aligned with other entries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-22 11:24:13 +01:00
Julius Härtl dd92923afa
Make active navigation indicator more obvious
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-22 11:19:54 +01:00
Julius Härtl dc169857a7
Fix search text overlapping clode button
fixes #8701

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-22 10:57:13 +01:00
Morris Jobke f843b7edfe
Merge pull request #8506 from nextcloud/use-appmanager
Use isInstalled of AppManger instead of reimplement it
2018-03-22 09:55:19 +01:00
Nextcloud bot c1b36e165e
[tx-robot] updated from transifex 2018-03-22 01:11:40 +00:00
Morris Jobke 6f455d5c41
Merge pull request #7196 from nextcloud/sharing-confirm-button
Add confirmation button to share input
2018-03-21 15:08:39 +01:00
Morris Jobke 514de5dfa1
Use isInstalled of AppManger instead of reimplement it
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 11:34:18 +01:00
John Molakvoæ (skjnldsv) ffa2eaeb56
Fixed inline confirm icon index
Fixed bullet/icon combination visibility

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-21 10:36:17 +01:00
Joas Schilling dabd7291c3
Make the new autocomplete endpoint OCS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-21 09:46:52 +01:00
Morris Jobke c8340ace5c
Merge pull request #7904 from nextcloud/fix_7224
Add Cache-control: immutable
2018-03-21 08:27:09 +01:00
Daniel Calviño Sánchez 203bf51543 Keep showing the working icon while there are pending operations
Before, whenever a pending operation (getting the suggestions,
confirming a share or selecting a recipient) finished the working icon
was hidden and the confirm button was shown again, even if there were
other pending operations (the most common case is typing slowly on the
input field, as several operations to get the suggestions could pile if
the server response is not received fast enough). Now, the working icon
is not hidden until the last pending operation finishes.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:35:26 +01:00
Daniel Calviño Sánchez a2c52cd6a5 Extract code to restore the UI after confirming a share
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:35:23 +01:00
Daniel Calviño Sánchez 9a0fbe307d Discard cached suggestions when adding a share
The suggestions depend on the results returned by the server, but also
on the sharees already shared with. Due to that adding a share changes
the suggestions, so now the cached suggestions are discarded when a
share is added.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:34:14 +01:00
Daniel Calviño Sánchez 6eb5cc5412 Reuse last suggestions if the same parameters are used
When a share is confirmed the suggestions are got to check if there is
an exact match. Usually the suggestions were already got with the same
parameters in order to fill the autocomplete dropdown, so to avoid a
superfluous request now the last suggestions are reused when got again,
although only if the same parameters as the last time are used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-21 04:31:08 +01:00
Nextcloud bot af3ab1de10
[tx-robot] updated from transifex 2018-03-21 01:11:55 +00:00
Daniel Calviño Sánchez 10a4f8e45e Confirm a share also by pressing enter on the input field
Besides confirming a share by clicking on the confirm button now it is
possible to do it by pressing enter on the input field.

Clicking on the confirm button implicitly hides the autocomplete
dropdown. On the other hand, pressing enter on the input field does not,
so the autocompletion must be disabled and closed when the confirmation
begins and then enabled again once it finishes. Otherwise the
autocomplete dropdown would be visible and it would be possible to
interact with it while the share is being confirmed.

The order in which the input field and the autompletion are disabled is
important. Internally, the autocompletion sets a timeout when the input
field is modified that requests the suggestions to the server and then
shows them in the dropdown. That timeout is not cancelled when the
autocompletion is disabled, but when the input field loses its focus and
the autocompletion is not disabled. Therefore, the input field has to be
disabled (which causes it to lose the focus) before the autocompletion
is disabled. Otherwise it could happen that while a share is being
confirmed the timeout ends, so an autocompletion request is sent and
then, once the share is successfully confirmed and thus the
autocompletion is enabled again, the request is received and the
autocomplete dropdown is shown with the old suggestions. Strange, but
possible nevertheless ;-)

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:05 +01:00
Daniel Calviño Sánchez 9371b61c4d Add a share when clicking on the confirm button
Clicking on the confirm button now adds a share, but only if there is
just a single exact match. If there are no exact matches or there is
more than one exact match no share is added, and the autocomplete
dropdown is shown again with all the suggestions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:05 +01:00
Daniel Calviño Sánchez 5e2a8cca1b Return also exact matches besides all suggestions
"_getSuggestions" returned all the suggestions from the server, which
are composed by exact matches and partial matches. Now the exact matches
are also returned on their own parameter. This will be used by the
button to confirm a share.

Note that until now the order of the suggestions was "exact users,
partial users, exact groups, partial groups, exact..."; this commit also
changes that order to become "exact users, exact groups, exact...,
partial users, partial groups, partial...". This is not a problem, as
the suggestions were used in the autocomplete dropdown, and this new
order is arguably better than the old one, as all exact matches appear
now at the beginning.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 89b0e34d9b Extract code to filter suggestions to its own function
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 1c440519c2 Show an error when getting the suggestions succeeds with failure content
Instead of silently failing now an error is shown to the user when the
ajax call to get the suggestions succeeds yet it returns failure content
(for example, if an "OCSBadRequestException" was thrown in the server).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez ed1452d7a0 Use "showTemporary" instead of explicitly hiding the notification
"OC.Notification.hide" expects the notification to be hidden to be
passed as an argument. As it was being used to show a temporary
notification the combination of "OC.Notification.show" and
"OC.Notification.hide" was replaced by a single call to
"OC.Notification.showTemporary".

The timeout could have been specified in the options of the call, but it
was left to the default value (7 seconds) for consistency with other
notifications.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez fcef15af80 Move stub setup outside the test method
Stubs should be restored outside the test method in which they are used
to ensure that they are properly restored no matter the result of the
test (for example, if an exception is thrown).

Besides that, this will make possible to reuse the stub in other sibling
tests without having to explicitly setup it in them.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez d606219576 Extract code to get suggestions to its own method
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 3980364b6d Add autocompletion tests for each type of share
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 8af9c553e6 Add tests for exact search results already shared with
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 375eab9df3 Add tests for emails and circles already shared with
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:04 +01:00
Daniel Calviño Sánchez 6fef01c481 Adjust search term to test
As the server response is faked the search term is ignored in the tests.
However, it is clearer to use a search term that would make the server
return what the faked response contains.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-20 19:09:03 +01:00
Jan-Christoph Borchardt ce7775acd0 Replace information icon with confirmation button in share input
The confirmation button right now is just an icon; its behaviour will be
added in the following commits.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-03-20 19:09:03 +01:00
Roeland Jago Douma 16ae91330c
Merge pull request #8887 from nextcloud/fix-appmenu-min-width
Add min width of two icons to the app menu
2018-03-20 08:03:52 +01:00
Nextcloud bot 615258ba26
[tx-robot] updated from transifex 2018-03-20 01:11:33 +00:00
Julius Härtl 1699b119dd
Add min width of two icons to the app menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-19 17:12:59 +01:00
Roeland Jago Douma 796b4f19f8
Add Cache-control: immutable
Cache generated CSS forever!
Also cache combined JS forever
Fix tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 14:21:53 +01:00
Nextcloud bot 2fab6b2620
[tx-robot] updated from transifex 2018-03-19 01:11:34 +00:00
Nextcloud bot d6bfc98df1
[tx-robot] updated from transifex 2018-03-18 01:11:46 +00:00
Nextcloud bot 3cac7911d5
[tx-robot] updated from transifex 2018-03-17 01:11:30 +00:00
Daniel Calviño Sánchez ed4b4458eb Use the display name in the avatar for a circle share
Before, the avatar for a circle share was generated using the
"share_with" field as the seed for "imageplaceholder". Due to this, when
the "share_with" field is set to the circle ID the character shown in
the avatar was just a random character instead of the first character of
the display name. Now the "share_with" is still used as the seed for the
colour, but the display name is used as the text of the avatar.

This adds support for "share_with" fields set to the circle ID while
being backwards compatible with "share_with" fields set to the circle
name.

Note that when "share_with" fields is set to the circle name the colour
of the avatar is different in the list of suggested sharees and in the
list of current sharees, but that also happened before these changes
(due to a different seed being used in each place).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-16 04:58:25 +01:00
Nextcloud bot b7e7ae5d6d
[tx-robot] updated from transifex 2018-03-16 01:11:31 +00:00
Nextcloud bot 055d15e305
[tx-robot] updated from transifex 2018-03-15 01:11:41 +00:00
Sagorika Das 6bac63adec sorts filepicker files by modified date
Signed-off-by: Sagorika Das <sagorika1996@gmail.com>
2018-03-14 18:11:50 +05:30
Morris Jobke 990ca145d7
Remove "Alternative logins" title on login page
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-14 11:38:57 +01:00
Roeland Jago Douma 2d5febd0b9
Merge pull request #8811 from nextcloud/remove_dep_util_link
Remove deprecated URL functions for OCP\Util
2018-03-14 09:49:51 +01:00
Nextcloud bot 7f00de841b
[tx-robot] updated from transifex 2018-03-14 01:11:29 +00:00
Roeland Jago Douma 83873e3da1
Remove deprecated URL functions for OCP\Util
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-13 22:04:08 +01:00
Nextcloud bot 3cae276149
[tx-robot] updated from transifex 2018-03-13 01:12:01 +00:00
Nextcloud bot 4e56a02450
[tx-robot] updated from transifex 2018-03-12 01:12:21 +00:00
Nextcloud bot 2c503ccdee
[tx-robot] updated from transifex 2018-03-11 01:12:13 +00:00
Nextcloud bot f08bc1bc6f
[tx-robot] updated from transifex 2018-03-10 01:11:58 +00:00
Morris Jobke f35c447525
Merge pull request #8757 from nextcloud/search_controller
Move search to proper Controller
2018-03-09 16:15:55 +01:00
Roeland Jago Douma 7674e591bd
Move search to proper Controller
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 14:36:48 +01:00
Nextcloud bot 20f1f757c4
[tx-robot] updated from transifex 2018-03-09 13:31:21 +00:00
Joas Schilling 81a3ac1226
Merge pull request #8736 from nextcloud/rakekniven-patch-1
Update login.php
2018-03-09 09:51:36 +01:00
Nextcloud bot a20e9d7891
[tx-robot] updated from transifex 2018-03-09 01:12:12 +00:00
Roeland Jago Douma 1329061d31
Merge pull request #8648 from nextcloud/feature/csrf-token-controller
Use session heartbeat to update CSRF token
2018-03-08 21:15:24 +01:00
rakekniven 1046fb5111
Update login.php
Fixed grammar issue.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#af/$/124614533?issue=yes
2018-03-08 20:08:11 +01:00
Christoph Wurst b9720703e8 Add CSRF token controller to retrieve the current CSRF token
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-03-08 16:48:50 +01:00
John Molakvoæ (skjnldsv) 5dbd09f07c
Align radio & checkboxes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:17:54 +01:00
John Molakvoæ (skjnldsv) 446a3a9d5a
Fixed ext share style and use varable for popover height
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 15:12:06 +01:00
John Molakvoæ (skjnldsv) e2910e17b0
Default left margin for entries without icons
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:38 +01:00
John Molakvoæ (skjnldsv) e77bddf56b
Css hack to add margin on first or last visible inputs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:38 +01:00
John Molakvoæ (skjnldsv) 966ceca8ea
Removed unwanted conflicting props
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 8d986160b8
Improved inline confirm icon with opacity and fixed ext share loading state
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 4e6043fd6b
Fixed tooltip positionning & error display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 955c2ee1a7
PoC inline icon-confirm with inputs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) a7a3640224
fixup! Updated popover rules to allow form inputs and added input submit for new File
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:37 +01:00
John Molakvoæ (skjnldsv) 3964616a9e
Updated popover rules to allow form inputs and added input submit for new File
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 13:17:36 +01:00
Morris Jobke d1aa96fef9
Merge pull request #8373 from nextcloud/right-header-stdrd
New standard for top right header
2018-03-07 12:33:11 +01:00
John Molakvoæ (skjnldsv) d9bd6f3253
Fixed public template
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-07 11:05:23 +01:00
Morris Jobke 3156d95e14
Merge pull request #8652 from nextcloud/navigation-controller-etag
Add ETag to NavigationController
2018-03-07 10:03:00 +01:00
Julius Härtl 11b6cc3f68
Replace logout href to avoid new etag on every request
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-06 09:51:28 +01:00
Nextcloud bot 3867a74f0d
[tx-robot] updated from transifex 2018-03-06 01:12:16 +00:00
Morris Jobke f72e9ae8a6
Merge pull request #8650 from nextcloud/fix-ie11-datepicker-display
Fixed date/time picker on IE11
2018-03-05 16:37:56 +01:00
Julius Härtl 723b8764d1
Add ETag to NavigationController
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-05 12:19:20 +01:00
Roeland Jago Douma 05ef2d70e7
Merge pull request #8590 from nextcloud/redirect-to-download-after-share
Sharing: redirect to download after authentification if requested
2018-03-05 11:11:43 +01:00
Nextcloud bot 6c49cc0294
[tx-robot] updated from transifex 2018-03-05 01:12:12 +00:00
John Molakvoæ (skjnldsv) c401a8cf26
Fixed loading state in apps nav menu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 16:24:14 +01:00
John Molakvoæ (skjnldsv) e70570cbd7
Fixed appsmenu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-04 16:10:45 +01:00