Commit Graph

4789 Commits

Author SHA1 Message Date
Joas Schilling d31f5251f1
Merge pull request #21748 from nextcloud/bugfix/noid/improve-error-reporting-with-sharing
Improve error reporting on sharing errors
2020-07-13 11:55:48 +02:00
Nextcloud bot 7868d4e3b2
[tx-robot] updated from transifex 2020-07-10 02:16:48 +00:00
Robin Appelman 118965ad98
better cleanup in share tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 11:14:45 +02:00
Roeland Jago Douma 1cf3280c8e
Lazy register the navigation
This makes sure that we do not translate unneeded strings on for example
webdav requests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-09 10:12:53 +02:00
Joas Schilling d9f12977d3
Improve error reporting on sharing errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-08 11:24:29 +02:00
Nextcloud bot 8ca1208bbb
[tx-robot] updated from transifex 2020-07-08 02:16:58 +00:00
Julius Härtl 6a67f84163
Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-07 09:23:32 +02:00
Nextcloud bot 09b9f94c38
[tx-robot] updated from transifex 2020-07-07 02:16:31 +00:00
Roeland Jago Douma 0bcc643d6e
Cleanup share by mail a bit
* Moved to ned IBootstrap
* Register everything via the capabilities api (So clients can use it as
  well)
  - This applies to the enforcing passwords
* Updated the sharing js code to use it
* removed app.php
* removed unused settings now
* typehints
* strict typing

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-06 09:45:08 +02:00
Nextcloud bot c52e6c8a47
[tx-robot] updated from transifex 2020-07-04 02:16:15 +00:00
Morris Jobke b6bbc709b2
Merge pull request #21280 from nextcloud/dependabot/npm_and_yarn/nextcloud/router-1.1.0
Bump @nextcloud/router from 1.0.2 to 1.1.0
2020-07-03 12:31:35 +02:00
dependabot-preview[bot] ec151e17c5 Bump @nextcloud/router from 1.0.2 to 1.1.0
Bumps [@nextcloud/router](https://github.com/nextcloud/nextcloud-router) from 1.0.2 to 1.1.0.
- [Release notes](https://github.com/nextcloud/nextcloud-router/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-router/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-router/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-03 06:42:35 +00:00
Nextcloud bot 0825530a1b
[tx-robot] updated from transifex 2020-07-03 02:17:12 +00:00
Roeland Jago Douma 1913b1b91f
Merge pull request #21591 from nextcloud/debt/noid/set-path-for-ocm-permissions
Pass $path to ocmPermissions2ncPermissions
2020-07-02 21:10:19 +02:00
Joas Schilling 47a21fad8c
Merge pull request #21597 from nextcloud/techdebt/noid/return-value-for-commands
Add return value to all commands
2020-07-01 11:52:14 +02:00
Nextcloud bot d94ef09998
[tx-robot] updated from transifex 2020-06-28 02:16:10 +00:00
Joas Schilling d7c0b9cced
Also always return in app commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 15:12:11 +02:00
Daniel Kesselberg 6b1af4ac8c
Pass $path to ocmPermissions2ncPermissions
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-25 23:42:36 +02:00
Roeland Jago Douma 7d4682da40
Merge pull request #21379 from nextcloud/fix-share-permission-checkboxes-enabled-when-permissions-can-not-be-set
Fix share permission checkboxes enabled when permissions can not be set
2020-06-24 21:20:17 +02:00
Joas Schilling a2f34f46b2
Fix tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 18:13:37 +02:00
Joas Schilling 89ed2c37bf
Update share type constant usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 16:49:16 +02:00
Nextcloud bot ce9d3b36df
[tx-robot] updated from transifex 2020-06-20 02:16:35 +00:00
Nextcloud bot dd0b9655b2
[tx-robot] updated from transifex 2020-06-19 02:16:27 +00:00
Joas Schilling b740d283a9
Don't initialize Application directly
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:18:15 +02:00
Nextcloud bot d1b03f5adf
[tx-robot] updated from transifex 2020-06-17 02:15:44 +00:00
Nextcloud bot f04d526681
[tx-robot] updated from transifex 2020-06-14 02:15:50 +00:00
Daniel Calviño Sánchez 3ffb482b4e Fix share permission checkboxes enabled when permissions can not be set
A sharee can reshare a file and set the edit, create, delete and share
permissions of the reshare only if the received share has edit, create,
delete and share permissions, or if they were revoked in the received
share after being set in the reshare. Therefore, the permission
checkboxes in the share menu should be enabled only if the user can set
them (otherwise trying to check them will lead to an error).

Note that "sharePermissions" has all the permissions if the file is not
a reshare but a file owned by the user.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-12 00:05:36 +02:00
Roeland Jago Douma 3000148e27
Merge pull request #21347 from nextcloud/fix/21188/pass_share_permissions_to_api_call
Pass the proper share permissions to the create share call
2020-06-10 10:35:48 +02:00
Nextcloud bot 9806dec9b3
[tx-robot] updated from transifex 2020-06-10 02:16:03 +00:00
Roeland Jago Douma d0525df63c
Pass the proper share permissions to the create share call
Fixes #21188

This way we do not run into the share permission issue

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-09 20:59:41 +02:00
Roeland Jago Douma 19712e2773
Merge pull request #21311 from nextcloud/techdebt/noid/make-share-order-reliable
Always sort shares in a reliable way
2020-06-09 10:33:41 +02:00
Nextcloud bot 99e14b5ada
[tx-robot] updated from transifex 2020-06-09 02:15:56 +00:00
Joas Schilling 56b04c65f7
Always sort shares in a reliable way
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-08 14:47:15 +02:00
Roeland Jago Douma c5a2caa0fb
Merge pull request #21278 from nextcloud/dependabot/npm_and_yarn/nextcloud/auth-1.3.0
Bump @nextcloud/auth from 1.2.3 to 1.3.0
2020-06-08 08:47:22 +02:00
Nextcloud bot f51c24a70a
[tx-robot] updated from transifex 2020-06-08 02:15:55 +00:00
dependabot-preview[bot] 807e286f42 Bump @nextcloud/auth from 1.2.3 to 1.3.0
Bumps [@nextcloud/auth](https://github.com/nextcloud/nextcloud-auth) from 1.2.3 to 1.3.0.
- [Release notes](https://github.com/nextcloud/nextcloud-auth/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-auth/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-auth/compare/v1.2.3...v1.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-07 08:47:37 +00:00
Nextcloud bot e212908cec
[tx-robot] updated from transifex 2020-06-07 02:15:50 +00:00
Nextcloud bot 4cf4ed3697
[tx-robot] updated from transifex 2020-06-06 02:16:00 +00:00
Christoph Wurst eaf4724acc
Move humanFileSize and OC.getCanonicalLocale to npm packages
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-05 08:48:49 +02:00
Nextcloud bot a5232d9805
[tx-robot] updated from transifex 2020-06-05 02:16:34 +00:00
Christoph Wurst 497350a7d3
Merge pull request #20938 from nextcloud/fix/share-talk-verification
Fix the Talk verification
2020-06-03 15:47:54 +02:00
Christoph Wurst 111c8c9e0e
Merge pull request #21181 from nextcloud/fix/remote-share-remove-error-handling
Do not only catch Exceptions but any Throwable during rmt share delete
2020-06-03 11:11:47 +02:00
Nextcloud bot f62f23ed1d
[tx-robot] updated from transifex 2020-06-03 02:16:18 +00:00
Christoph Wurst 09a632242d
Do not only catch Exceptions but any Throwable during rmt share delete
When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-02 09:21:09 +02:00
Daniel Calviño Sánchez fdac2ffe24 Restore previous state when failing to change video verification state
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-01 18:50:13 +02:00
Christoph Wurst 5d92a6a7c9 Fix the Talk verification
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).

When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.

We'll have to backport to 18.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-01 17:21:42 +02:00
Nextcloud bot a1bb18a837
[tx-robot] updated from transifex 2020-05-31 02:16:19 +00:00
Roeland Jago Douma b9e7fd2418 Remove the escape-html global
Already announced for 19 that it would go. So now it realy does go.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-29 08:34:10 +00:00
Daniel Calviño Sánchez 37f231333f Fix reference to wrong class name
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 01:41:06 +02:00
Nextcloud bot be7a198762
[tx-robot] updated from transifex 2020-05-24 02:15:55 +00:00