Commit Graph

711 Commits

Author SHA1 Message Date
dependabot-preview[bot] 5f2f7a6def
Bump handlebars from 4.1.2 to 4.2.0 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.2.0.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-08 18:14:32 +00:00
Roeland Jago Douma 1ee9122244
Fix npm audit warning in build
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-08-30 11:46:24 +02:00
dependabot-preview[bot] 88cf6e13af
[Security] Bump mixin-deep from 1.3.1 to 1.3.2 in /build
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.**
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-27 18:07:31 +00:00
dependabot[bot] 3eef078b4f
Bump js-yaml from 3.12.0 to 3.13.1 in /build
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.13.1.
- [Release notes](https://github.com/nodeca/js-yaml/releases)
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodeca/js-yaml/compare/3.12.0...3.13.1)

Signed-off-by: dependabot[bot] <support@github.com>
2019-08-08 07:43:03 +00:00
dependabot-preview[bot] 0d278eddf6
[Security] Bump fstream from 1.0.11 to 1.0.12 in /build
Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12. **This update includes a security fix.**
- [Release notes](https://github.com/npm/fstream/releases)
- [Commits](https://github.com/npm/fstream/compare/v1.0.11...v1.0.12)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-25 14:01:22 +00:00
dependabot-preview[bot] efd6c06658
Bump jsdoc from 3.6.2 to 3.6.3 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.2 to 3.6.3.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.2...3.6.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-21 01:12:55 +00:00
dependabot-preview[bot] 7a4e9f7a81
[Security] Bump lodash from 4.17.11 to 4.17.14 in /build
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. **This update includes security fixes.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-11 02:21:38 +00:00
Morris Jobke c5c14d09b1
Merge pull request #16186 from nextcloud/bugfix/noid/also-check-permissions-when-creating-a-share
Better check reshare permissions part2
2019-07-03 20:07:05 +02:00
Joas Schilling e4addbae3e
Better check reshare permissions when creating a share
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 14:00:13 +02:00
Roeland Jago Douma cf7bc3fe9d
Fix phan
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-06-27 22:29:45 +02:00
Daniel Calviño Sánchez f01a772a1a
Add integration test for increasing sub reshare permissions
The tests check an user share and a link share; there is a slight
difference in style between them as each one is based on the test above
it, which tests increasing reshare permissions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-06-27 15:27:30 +02:00
Daniel Calviño Sánchez 3802174f06
Do not create folders with admin user
The admin user is not deleted after each integration test is run, so
folders created by the admin user in one test are still there when the
next tests run; tests should be independent one from each other, so a
regular user that is created and deleted for each test should be used
instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-06-27 15:27:30 +02:00
Christoph Wurst 409acf1131
Fix js l10n registration to also work with more than one bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-06-26 10:07:21 +02:00
Arthur Schiwon 437b33ff63
add LDAP integr. test for receiving share candidates with group limitation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-14 06:23:58 +02:00
dependabot-preview[bot] 430f56a3a7
[Security] Bump tar from 2.2.1 to 2.2.2 in /build
Bumps [tar](https://github.com/npm/node-tar) from 2.2.1 to 2.2.2. **This update includes security fixes.**
- [Release notes](https://github.com/npm/node-tar/releases)
- [Commits](https://github.com/npm/node-tar/compare/v2.2.1...v2.2.2)
2019-05-24 23:26:19 +00:00
blizzz 755611866e
Merge pull request #15604 from nextcloud/fix/12682/fix-possible-override-of-uniquemember
fixes possible override of uniqueMember by autodetection
2019-05-22 19:09:28 +02:00
Arthur Schiwon 54299f4e66
set the ldapGroupMemberAssocAttr for group tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-22 12:48:12 +02:00
Morris Jobke d3511f69f9
Merge pull request #15499 from nextcloud/app-update-script
Add scripts to update server & apps or apps only
2019-05-21 17:42:57 +02:00
dependabot[bot] cb53a582e6
Bump jsdoc from 3.6.1 to 3.6.2 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.1 to 3.6.2.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.1...3.6.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-19 01:13:24 +00:00
Jan-Christoph Borchardt fa066da77c
Fix app update script for macOS
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-05-17 22:49:39 +02:00
Jan-Christoph Borchardt 8f0656aae9
Remove eduplicate git fetch from update scripts
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-05-17 22:49:39 +02:00
Jan-Christoph Borchardt bc61b15e2f
Adjust script to remove branches which are deleted on GitHub
Co-Authored-By: Morris Jobke <hey@morrisjobke.de>
2019-05-17 22:49:39 +02:00
Jan-Christoph Borchardt 934924577a
Fix for update script when submodule is not initialized
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-05-17 22:49:39 +02:00
Jan-Christoph Borchardt b403d72f51
Also add script to update both server and apps
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-05-17 22:49:38 +02:00
Jan-Christoph Borchardt 9f4ae034c1
Add script to update Nextcloud apps from latest git master, ref #15145
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-05-17 22:49:38 +02:00
Daniel Kesselberg bc35b59fc7
Remove whitespace
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-05-15 20:37:06 +02:00
Daniel Kesselberg 941018cfe5
Use DRONE_SOURCE_BRANCH instead of DRONE_COMMIT_REFSPEC
Looks like DRONE_COMMIT_REFSPEC is not available anymore on Drone 1.x

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-05-15 19:56:20 +02:00
Daniel Kesselberg 3e9f9ea06b
Update regex to also match version/x.y.z
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-05-15 19:36:01 +02:00
dependabot[bot] f0932344cb
Bump jsdoc from 3.6.0 to 3.6.1 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.0 to 3.6.1.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.0...3.6.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-12 01:12:56 +00:00
Arthur Schiwon 3a5d4abdf1
use webpack to compile handlebars
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-10 14:50:40 +02:00
Arthur Schiwon 3ec5ee47fa
adjust paths to template location
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-10 13:15:49 +02:00
dependabot[bot] 927c040fe8
Bump jsdoc from 3.5.5 to 3.6.0 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.5.5 to 3.6.0.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.5.5...3.6.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-05 01:12:46 +00:00
dependabot[bot] fa96185efe
Bump node-sass from 4.11.0 to 4.12.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.11.0 to 4.12.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.11.0...v4.12.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-05-01 19:15:19 +00:00
Roeland Jago Douma b222f66d46
Merge pull request #15090 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.1.2
Bump handlebars from 4.1.1 to 4.1.2 in /build
2019-04-17 22:56:14 +02:00
Julius Härtl 771ad85f85
Add integration tests for updating folder shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-04-16 15:03:52 +02:00
dependabot[bot] 2b41953686
Bump handlebars from 4.1.1 to 4.1.2 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.1...v4.1.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-15 07:13:24 +00:00
Roeland Jago Douma d2f9366b39
Run less phan processes
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-09 22:04:31 +02:00
Roeland Jago Douma 9a5edbb923
Do not try to compile templates that are not there
Makes for a bit cleaner drone output.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-08 09:12:59 +02:00
dependabot[bot] f410519da4
Bump handlebars from 4.1.0 to 4.1.1 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/v4.1.1/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.0...v4.1.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-03-23 02:12:57 +00:00
Arthur Schiwon a692f28320
add an integration test that ensures deletion of LDAP users
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-14 15:21:52 +01:00
Morris Jobke f6a12864a5
Disable failing federated sharing tests
Fails with:

 * build/integration/federation_features/federated.feature:183
 * build/integration/federation_features/federated.feature:232
 * build/integration/federation_features/federated.feature:247
 * build/integration/federation_features/federated.feature:263
<details><summary>Show full log</summary>

```
  Scenario: Reshare a federated shared file                                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:183
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
    When creating a share with                                                                          # FederationContext::creatingShare()
      | path        | /textfile0 (2).txt |
      | shareType   | 0                  |
      | shareWith   | user2              |
      | permissions | 19                 |
    Then the OCS status code should be "100"                                                            # FederationContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &000000007d8e0d3c00000000403fd08a (
          0 => '404'
      ) matches expected '100'.
    ...
{"message":"Can not find share with ID: 8"}

  Scenario: Overwrite a federated shared folder as recipient                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:232
    Given Using server "REMOTE"                                                                          # FederationContext::usingServer()
    And user "user1" exists                                                                              # FederationContext::assureUserExists()
    And user "user2" exists                                                                              # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                             # FederationContext::usingServer()
    And user "user0" exists                                                                              # FederationContext::assureUserExists()
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE"         # FederationContext::federateSharing()
    And User "user1" from server "REMOTE" accepts last pending share                                     # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                            # FederationContext::usingServer()
    And As an "user1"                                                                                    # FederationContext::asAn()
    And User "user1" modifies text of "/textfile0.txt" with text "BLABLABLA"                             # FederationContext::modifyTextOfFile()
    When User "user1" uploads file "../../data/user1/files/textfile0.txt" to "/PARENT (2)/textfile0.txt" # FederationContext::userUploadsAFileTo()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    ...
{"message":"Can not find share with ID: 10"}

  Scenario: Overwrite a federated shared file as recipient using old chunking                           # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:247
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    ...
{"message":"Can not find share with ID: 11"}

  Scenario: Overwrite a federated shared folder as recipient using old chunking                  # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:263
    Given Using server "REMOTE"                                                                  # FederationContext::usingServer()
    And user "user1" exists                                                                      # FederationContext::assureUserExists()
    And user "user2" exists                                                                      # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                     # FederationContext::usingServer()
    And user "user0" exists                                                                      # FederationContext::assureUserExists()
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
    And User "user1" from server "REMOTE" accepts last pending share                             # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                    # FederationContext::usingServer()
    And As an "user1"                                                                            # FederationContext::asAn()
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    ...
{"message":"Can not find share with ID: 12"}

```
</details>

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-13 18:01:24 +01:00
blizzz 3af7f2c2ea
Merge pull request #14464 from nextcloud/fix/noid/ldap-nested-group-filter
resolve user and groups in nested groups first before filtering the results
2019-03-07 22:31:51 +01:00
Arthur Schiwon 987db8e6c5
add missing config bits to integration tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-06 00:09:23 +01:00
Arthur Schiwon dfc7007242
with LDAP server set offline, config cannot be controlled via ocs anymore
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-05 23:13:49 +01:00
Daniel Kesselberg 75337ff621
DRONE_BRANCH is the target branch. DRONE_COMMIT_REFSPEC should work.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-03-05 15:20:47 +01:00
Morris Jobke 2bbef58153
Add test for updated CA bundle
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-05 15:10:33 +01:00
Arthur Schiwon 5dd2207c95
fix nested group retrieval also for 2 other cases
and also consolidate logic in one method

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-05 11:07:40 +01:00
Morris Jobke f7de518ec0
Exclude Makefile from check
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-02-25 15:49:29 +01:00
Daniel Kesselberg 75b7d6ae4e
Add install logic for enable command
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-19 21:03:06 +01:00
Daniel Kesselberg 76b5f44f05
Strict Types, Return Types
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-19 21:03:06 +01:00
Joas Schilling a1b87bc81e
Update PHP-Parser for 7.1 compatibility
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-14 20:04:17 +01:00
Roeland Jago Douma 51194a7901
Update expected file list
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-13 09:03:12 +01:00
dependabot[bot] c7543247ed
Bump handlebars from 4.0.12 to 4.1.0 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.12 to 4.1.0.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/v4.1.0/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.0.12...v4.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-02-11 09:56:11 +00:00
Roeland Jago Douma b40603d250
Merge pull request #13702 from nextcloud/feature/6717/rename-app-passwords
Make it possible to rename app passwords
2019-02-08 08:34:54 +01:00
Daniel Kesselberg 4532ed356d
Mock name for integration test
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-04 17:12:59 +01:00
Roeland Jago Douma 1b27c25dce
Remove from build file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-04 10:56:54 +01:00
Arthur Schiwon 4bd3916445
integration test: pages search scenario with multiple bases
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-28 14:20:03 +01:00
Arthur Schiwon 91b30ada8e
typo
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-28 14:19:31 +01:00
dependabot[bot] fdd4b11a1a
Bump karma-viewport from 1.0.3 to 1.0.4 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.3...1.0.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-12 02:12:42 +00:00
Christoph Wurst 69410a4f1c
Adjust release file list
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:01 +01:00
Christoph Wurst 1e80259051
Remove core.js
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:00 +01:00
Christoph Wurst 6da13f82ff
Remove Bower
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:01:59 +01:00
Jan-Christoph Borchardt 1799d0fd11
Switch around syntax of scour command for SVG image optimization
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-08 17:03:33 +01:00
dependabot[bot] 462cf270bc
Bump karma-viewport from 1.0.2 to 1.0.3 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.2...1.0.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-31 02:22:56 +00:00
dependabot[bot] c27d2ace47
Bump karma from 3.1.3 to 3.1.4 in /build
Bumps [karma](https://github.com/karma-runner/karma) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v3.1.3...v3.1.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-18 16:00:28 +00:00
dependabot[bot] 4124e1fc54
Bump node-sass from 4.10.0 to 4.11.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.10.0 to 4.11.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.10.0...v4.11.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-09 14:08:00 +00:00
dependabot[bot] 97e5fa5120
Bump karma from 3.1.1 to 3.1.3 in /build
Bumps [karma](https://github.com/karma-runner/karma) from 3.1.1 to 3.1.3.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v3.1.1...v3.1.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-03 02:16:14 +00:00
dependabot[bot] 47462064ca
Bump node-sass from 4.9.4 to 4.10.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.9.4 to 4.10.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.9.4...v4.10.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-05 08:27:57 +00:00
Roeland Jago Douma e94ee7cbca
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-01 11:31:41 +01:00
Morris Jobke b28a0c10bf
Merge pull request #11946 from nextcloud/bugfix/11945/fix-js-namespace-of-files-external
Fix JS namespace of files_external app
2018-10-30 14:57:57 +01:00
Joas Schilling 9645e545b3 Fix JS namespace of files_external app
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-30 09:43:26 +01:00
dependabot[bot] 3ca384cfcc
Bump karma from 2.0.4 to 3.1.1 in /build
Bumps [karma](https://github.com/karma-runner/karma) from 2.0.4 to 3.1.1.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v2.0.4...v3.1.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-25 13:51:04 +00:00
Julius Härtl b09f7ad822
Remove buildjsdocs.sh from files checker
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 14:33:52 +02:00
Julius Härtl 5d888984a0
Fix jsdocs build on server repo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 15:41:08 +02:00
Roeland Jago Douma 97ad1ba381
Merge pull request #11985 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.9.4
Bump node-sass from 4.9.3 to 4.9.4 in /build
2018-10-23 20:06:19 +02:00
dependabot[bot] 4367df4e56
Bump node-sass from 4.9.3 to 4.9.4 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.9.3 to 4.9.4.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.9.3...v4.9.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-22 18:25:52 +00:00
dependabot[bot] 5480227525
Update sabre/dav requirement from 3.2.2 to 3.2.3 in /build/integration
Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/commits/3.2.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-22 17:11:57 +00:00
Roeland Jago Douma c43e0d6e28
Move files_external to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 08:41:01 +02:00
Roeland Jago Douma bee5bbbf0e
Move files_drop to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-16 08:27:06 +02:00
Roeland Jago Douma 3797b8e7e3
Merge pull request #11834 from nextcloud/csp/federationmenu
Compile federationscope menu handlebars template
2018-10-15 21:23:19 +02:00
Roeland Jago Douma 8c4c4b700f
Move workflowengine to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 14:55:25 +02:00
Roeland Jago Douma d65438f931
Compile federationscope menu handlebars template
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 10:44:24 +02:00
Christoph Wurst 08b005fb0e
Move GitHub files to .github directory
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 11:35:46 +02:00
Christoph Wurst c62b9c7e70
Remove unused HHVM test executor
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 10:00:43 +02:00
Roeland Jago Douma b574d1c814
Move files_versions to compiled handlebars templates
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 09:53:45 +02:00
Roeland Jago Douma b0fd31496b
Move OC.Share to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 09:53:45 +02:00
Roeland Jago Douma cd7c17482e
Move systemtags to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 09:53:44 +02:00
Roeland Jago Douma d281f2625d
Move Comments to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-04 09:53:44 +02:00
John Molakvoæ (skjnldsv) b7d82e9262
Bump check script
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-02 17:26:07 +02:00
Roeland Jago Douma 335efcc43b
Move to 1 template file for files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-01 17:15:07 +02:00
Roeland Jago Douma 4f13430a95
Add drone step
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-28 21:15:46 +02:00
Roeland Jago Douma f4a15f7f42
Add script to compile handlebars templates
For now it is small and there is no real standard yet. But it is better
to start with something.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-28 21:00:23 +02:00
Morris Jobke d867f9f091
Merge pull request #11037 from nextcloud/trash-webui-dav
Use trashbin dav endpoint to list trash in webui
2018-09-28 16:03:24 +02:00
Arthur Schiwon 108a8d6c4c
extend integration tests with users with numerical IDs
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-09-28 11:19:48 +02:00
Robin Appelman d890cd6a4c
fix sharing trashbin integration tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-20 17:03:59 +02:00
Robin Appelman d4087811e5
more trashbin integration tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-20 17:03:53 +02:00
Robin Appelman 8491c9bdc6
fix trashbin integration tests and add a few more
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-20 17:03:50 +02:00
Robin Appelman 26e2957aea
quote paths in behat.yml
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-20 17:03:47 +02:00
Robin Appelman a623e09868
remove old trashbin endpoint
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-20 17:03:36 +02:00
dependabot[bot] 5d8a750463
Bump node-sass from 4.9.2 to 4.9.3 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.9.2 to 4.9.3.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.9.2...v4.9.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-09-03 07:12:34 +00:00
Morris Jobke a6fb5c5dba
Merge pull request #10663 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.5.0
Update behat/behat requirement from ~3.3.0 to ~3.5.0 in /build/integration
2018-08-20 17:09:04 +02:00
blizzz d05c815796
Merge pull request #8855 from nextcloud/feature/noid/ldap-integration-autotests
behat integration tests for LDAP
2018-08-14 14:14:22 +02:00
dependabot[bot] 9fc47bf66e
Update behat/behat requirement from ~3.3.0 to ~3.5.0 in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/commits/v3.5.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-08-13 01:14:46 +00:00
Arthur Schiwon 24ef41454c
don't add new LDAP configs if one is already present
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-12 23:49:59 +02:00
Arthur Schiwon 919c7b8531
improve fail info and disable cache for a case
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-12 22:45:22 +02:00
Daniel Kesselberg 58106b0a73
Pass HttpHeader as array
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-12 18:21:38 +02:00
Arthur Schiwon 96f5210fc4
Phpunit changed, use proper Assert class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-12 14:46:22 +02:00
Arthur Schiwon 59e35e3bf7
tests for user storage location
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 00:28:44 +02:00
Arthur Schiwon b069b13226
convert pagination tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon 0f6d98eed2
convert connection tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon f1cd4bc0c2
fix prov tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon 8808da816d
simplify tests and move some out to a new feature as we need a pristine
database for them

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon eaf352b8d1
integration test to ensure entries without displayname don't cause trouble
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon d1a8a909de
login does not save the response
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 4e8db8aa11
convert LDAP offline and backup server integration tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 3450ed4536
integration test checking the group filter
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
Arthur Schiwon b4eeb9eff5
check user details
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
Arthur Schiwon 86d145f069
behat integration tests for LDAP, basic setup
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:04 +02:00
Daniel Calviño Sánchez de403f2f3d Add integration test for creating room shares when Talk is not enabled
The test just ensures that the controller will gracefully reject the
creation instead of failing miserably; the integration tests when Talk
is enabled are in the Talk repository.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 1e16f7ecd9 Add integration tests for searching files by comments
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-25 18:53:45 +02:00
Daniel Calviño Sánchez b7474ed482
Fix transfering ownership of a share to user with same id as receiver
When the ownership of a user share is transfered to the receiver the
share is removed, as the receiver now owns the original file. However,
due to a missing condition, any share with a group, link or remote with
the same id as the user was removed, not only the user shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 15:05:42 +02:00
John Molakvoæ (skjnldsv) 4877cd050b
Bump karma config
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
Bjoern Schiessle 0c09f566c2
add some integration tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:49 +02:00
Joas Schilling e3b5ed602c
Fix the behat version to 3.3.*
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-09 11:10:25 +02:00
Morris Jobke 021bd261bc
Fix integration tests for Federation 2.0
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-04 11:23:39 +02:00
Bjoern Schiessle 34c4527cc4
add ocm-provider to the list of expected files
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:29 +02:00
Daniel Calviño Sánchez d523777843 Extend integration tests to get the info of a group share as a sharee
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-29 08:20:19 +02:00
Daniel Calviño Sánchez b506ec1c89 Check all paths for own files and shares
Add "PARENT (2)" and its subdirectories to the paths to be checked, as
before only the own "PARENT" folder was being checked, but not the
shared one.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-28 16:45:42 +02:00
Daniel Calviño Sánchez e1c28c403d Fix filenames in sharing integration tests
When a file is shared and the receiver of the share already has a file
with the same name that file is left untouched, and "(2)" is appended to
the name of the shared file.

As "textfile0.txt" is included in the user folder skeleton all the users
in the integration test have that file, so when it is shared the
receiver sees the share as "/textfile0 (2).txt", and her own file as
"/textfile0.txt".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-28 16:36:19 +02:00
John Molakvoæ (skjnldsv) a23a6004a5
Fix integration tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-25 17:12:27 +02:00
John Molakvoæ (skjnldsv) 49d0f0c499
Fixed phpunit Test class
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 07:24:41 +02:00
dependabot[bot] 9a32592aca
Update phpunit/phpunit requirement to ~6.5 in /build/integration
Updates the requirements on [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) to permit the latest version.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases)
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.5.md)
- [Commits](https://github.com/sebastianbergmann/phpunit/commits/6.5.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-13 07:24:40 +02:00
John Molakvoæ (skjnldsv) 885b6be733
Fixed tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-12 11:13:24 +02:00
John Molakvoæ (skjnldsv) 62667914a0
Copyright fix, changed vue settings output name and fixes template name
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-12 10:26:53 +02:00
John Molakvoæ (skjnldsv) fd147cc3fd
Bump updatenotification
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 09:28:06 +02:00
John Molakvoæ (skjnldsv) 14cb805cf1
Bump settings config
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 08:35:02 +02:00
John Molakvoæ (skjnldsv) 62e29abc5b
Add vue apps build tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-07 08:35:02 +02:00
Julius Härtl 2dd49206c7
Merge pull request #9673 from nextcloud/dependabot/composer/build/integration/guzzlehttp/guzzle-6.3.3
Update guzzlehttp/guzzle requirement to 6.3.3 in /build/integration
2018-05-30 14:44:04 +02:00
John Molakvoæ 50f6015821
Merge pull request #9680 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-tw-1.0.2
Update karma-viewport requirement to ^1.0.2 in /build
2018-05-30 13:21:43 +02:00
dependabot[bot] 4d78f2e45b
Update karma-viewport requirement to ^1.0.2 in /build
Updates the requirements on [karma-viewport](https://github.com/squidfunk/karma-viewport) to permit the latest version.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/commits/1.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 10:00:57 +00:00
dependabot[bot] d7f725008f
Update karma requirement to ^2.0.2 in /build
Updates the requirements on [karma](https://github.com/karma-runner/karma) to permit the latest version.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/commits/v2.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 10:00:50 +00:00
Julius Härtl 20b0658ff6
Merge pull request #9685 from nextcloud/dependabot/npm_and_yarn/build/node-sass-approx-4.9.0
Update node-sass requirement to ~4.9.0 in /build
2018-05-30 11:59:16 +02:00
Morris Jobke 69d633c403
Merge pull request #9679 from nextcloud/dependabot/npm_and_yarn/build/jsdoc-approx-3.5.5
Update jsdoc requirement to ~3.5.5 in /build
2018-05-30 11:35:28 +02:00
dependabot[bot] 81ccf33db4
Update guzzlehttp/guzzle requirement to 6.3.3 in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/commits/6.3.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 09:34:25 +00:00
dependabot[bot] 04764cf568
Update node-sass requirement to ~4.9.0 in /build
Updates the requirements on [node-sass](https://github.com/sass/node-sass) to permit the latest version.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/commits/v4.9.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:23:54 +00:00
dependabot[bot] fd107bc0e5
Update jsdoc requirement to ~3.5.5 in /build
Updates the requirements on [jsdoc](https://github.com/jsdoc3/jsdoc) to permit the latest version.
- [Release notes](https://github.com/jsdoc3/jsdoc/releases)
- [Changelog](https://github.com/jsdoc3/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc3/jsdoc/commits/3.5.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:23:35 +00:00
dependabot[bot] 354cac145c
Update sabre/dav requirement to 3.2.2 in /build/integration
Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version.
- [Release notes](https://github.com/sabre-io/dav/releases)
- [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sabre-io/dav/commits/3.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-05-30 08:23:11 +00:00
Daniel Calviño Sánchez 268a92731f Limit Sinon version to 5.0.7 at most
When using fake servers with Sinon.JS, the JavaScript test framework,
the XHR objects are also fake. In Sinon 5.0.8 the "setRequestHeader" of
XMLHttpRequest was modified to normalize the header values (as requested
by the spec), but since then only string values are accepted; null or
integer values can no longer be passed to "setRequestHeader", as it
expects the "replace" function to be available in the object. However,
in the tests null and integer values are passed to "setRequestHeader",
which causes them to fail.

Both Firefox and Chromium accept passing non-string values to their
"setRequestHeader" implementation, and it is done, for example, in
davclient.js; it is not clear yet whether Sinon got too restrictive or
the code calling "setRequestHeader" was too loose. Given that
davclient.js is an external dependency, as a temporary measure Sinon
version is forced to be 5.0.7 at most until either Sinon or davclient.js
are updated.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-05-28 08:06:20 +02:00
Roeland Jago Douma b3aec38e5e
Remove .lgtm file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-23 14:49:22 +02:00
Morris Jobke 6d5f4432cd
Merge pull request #9313 from nextcloud/phan-check-php-doc
Check doc block signature to match the specified return type
2018-05-07 15:45:41 +02:00