9f532df1a4
Show disabled even if empty if ldap enabled
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 11:11:11 +01:00
5cf8f4a407
Update logic for forwardedForHeadersWorking
...
As discussed in https://github.com/nextcloud/server/issues/11594 when discovering if
x-forwarded-for is working properly its not possible to use getRemoteAddr because
the "client ip" is returned. For this check the ip of the last hop would be required.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-25 23:01:37 +02:00
83e994c11f
Make it possible to enforce mandatory 2FA for groups
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-15 08:22:52 +02:00
67c3730fbb
Add admin interface to enforce 2FA
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-10 14:34:52 +02:00
ea21aa3f7a
Use numeric placeholders if there are multiple, so that RTL languages can operate better
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-09 14:32:14 +02:00
d1cb83424f
Merge pull request #11091 from nextcloud/bugfix/11088/cannot-read-passwd
...
Remove posix_getpwuid and compare only userid
2018-09-13 10:29:08 +02:00
a1c969a170
Merge pull request #10840 from webfoersterei/refactor/5530-urandom-check
...
Refactor secure randomness check
2018-09-13 09:29:42 +02:00
45dab2d2a2
Add int-typehint
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-12 15:05:17 +02:00
2e5d8ecca4
Remove posix_getpwuid and compare only userid
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-06 14:15:37 +02:00
a6bb19fa11
Fix path when app has wrong permission
...
Replace slow array function used in loop: https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-30 20:52:43 +02:00
8d8189c932
Allow any Random generator that implements ISecureRandom for setupCheck
...
Signed-off-by: Timo Förster <tfoerster@webfoersterei.de>
2018-08-24 23:12:02 +02:00
006e150c87
Change check if secure randomness is possible.
...
Signed-off-by: Timo Förster <tfoerster@webfoersterei.de>
2018-08-24 23:12:02 +02:00
2bab916c53
Adds license to files. Updates the branch.
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 20:46:23 +02:00
37869d9b2f
Merge pull request #10628 from nextcloud/feature/10154/app-directory-permission-check
...
Adds a permission check for app directories
2018-08-20 17:08:18 +02:00
c164409ee7
Adds a memory limit warning for console commands if the limit is below the recommended value
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
c2fced4463
Adds a setup check for the memory limit
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
1b74bfc999
do not trigger counting on LDAP
...
it's probably too many, degregading performance
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 15:39:52 +02:00
3f790bb85b
Excludes not writable app roots from the directory permission check
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:49:01 +02:00
b2e60e365d
Adds a setup check for app directory permissions.
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:47:55 +02:00
9057621d64
Merge pull request #10506 from nextcloud/fix/10504/not_all_apps_are_appstore
...
Not all apps are from the appstore
2018-08-02 19:32:51 +02:00
a9f8ee4e9d
Also allow to update apps which are currently not enabled
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-02 14:26:31 +02:00
2dcae4e8ea
Keep the data of the local app (especially the version)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-02 13:47:42 +02:00
106ce3368d
Not all apps are from the appstore
...
Fixes #10504
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-02 12:56:23 +02:00
882aab9d70
Fix detection if opcache extension is loaded
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:41 +02:00
7c6c3d0d76
Fix tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:41 +02:00
f6f49c77f7
opcache module check
...
Improved the speed of isOpcacheProperlySetup() (instant return instead of continuing when we're already failed), added a check for the opcache extension itself. Potentially fixes #9410
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:40 +02:00
6a0c54d5bf
Add warning to setup checks if the default mailer is still php
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
3cbe40ffac
If cronErros is empty json_decode will return NULL
...
Fixes #9867
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-19 16:26:06 +02:00
4c0d710479
Just pass uid to the Token stuff
...
We don't have user objects in the code everywhere
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-18 22:11:54 +02:00
9c4aecb539
Merge all setup checks into one controller
...
* renamed hasMissingIndexes to missingIndexes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 15:25:08 +02:00
cd87a40eb3
Merge pull request #9836 from nextcloud/feature/noid/merge-tips-and-tricks-into-setup-checks
...
Merge tips & tricks section into setup checks
2018-06-13 13:18:40 +02:00
4a0b7aaf6c
Merge tips & tricks section into setup checks
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 12:05:38 +02:00
624d191ef6
Fix wrong hint about missing indexes
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 11:56:43 +02:00
62667914a0
Copyright fix, changed vue settings output name and fixes template name
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-12 10:26:53 +02:00
f5ecd1c100
Add category field to apps that are only known from the app store
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-09 11:38:44 +02:00
b49f8e43bd
Merge pull request #9565 from nextcloud/feature/noid/app-settings
...
Migrate apps management to Vue.js
2018-06-06 18:05:04 +02:00
393d9aae74
Add a hint that some indexes are not added yet
...
* gives the admin a chance to discover the missing indexes and improve the performance of the instance without digging through the manual
* nicely integrated in the setup checks where this kind of hints belong to
* also adds an option to integrate this from an app based on events
* fix style of setting warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-06 16:55:01 +02:00
a045159637
Use icon instead of screenshot in the list view
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
a5509aa253
Move filtering to javascript
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
b4a7be20c8
Properly clear cache
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
5ac8af27dc
Cleanup controller code
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
664bc37a80
Remove old js code except for app navigation rebuild
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
30cd8ed837
Proper rendering of bundles
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
bf7cef10be
Simplify backend code
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
1ad8ea75b5
Fix active indicator and add proper separation between screenshot and preview
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
8b919ecdc4
Properly search for other apps
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
cd60e5b634
Move logic to app management mixin
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
492b76935c
Add link to developer docs and fix view if appstore is disabled
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
d7b928fd9b
Add install/remove to the new controller methods
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
eccc391bda
Load marked and return proper Template with CSP
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
bb50ee08e9
Fix app enabling for groups and allow requesting all apps
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
d9d5e975d8
Remove default categories from route endpoint
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
125d1d3d4e
Add file skeleton for app settings
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +02:00
8594fdc493
Move to AppFramework Controller
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Move app management ajax code to AppSettingsController
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:06 +02:00
c55cf79453
Added total count for subadmins
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
ddd1c8bc86
Disabled fix since new users list
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-24 17:52:15 +02:00
aa1c6fb6b4
Fixed IE design, subadmins groups update and multiselect base width
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-23 09:43:33 +02:00
e23e28b3cc
Various fixes
...
* Fixed subadmin group management
* Fixed pass policy prop retrieving
* Fixed fields subadmins were not supposed to see
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:25 +02:00
ae8ea57793
Bump tests and editorconfig
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:23 +02:00
62e1014b2e
Bump popovermenu item options and tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
72a76060bf
Fixed settings menu entry and group deletion
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
45f1efe953
Continued the upgrade to proper router link and added navigationItem router linkTo capability
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
2963fdc879
Bump user controller, cleaned old legacy and added route history mode
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:22 +02:00
c8f670dd8f
Settings to vuejs
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-05-16 09:50:20 +02:00
8b0c6c6df1
Do not hide additional settings if there are only legacy forms
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:24 +02:00
b841a477c6
log to $datadir/audit.log by default and add rotation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:10:53 +02:00
5fbf184134
destaticfy Log classes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 12:00:06 +02:00
38a90130ce
move log constants to ILogger
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
0d5142be70
Show a link to the docs instead of a button on the untrusted domain page
...
Before there was a button to "quickly" add the untrusted domain to the config. This button often didn't worked, because the generated URL was often untrusted as well. Thus removing it and providing proper docs seems to be the better approach to handle this rare case.
Also the log should not be spammed by messages for the untrusted domain accesses, because they are user related and not necessarily an administrative issue.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-17 17:47:11 +02:00
176b4d6832
Ping more privacy respecting organizations
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 21:43:51 +02:00
208e38e84e
Merge pull request #8255 from nextcloud/bugfix/noid/group-display-name
...
Full implement group display names
2018-03-15 12:07:30 +01:00
044d5a8d01
Inject public IGroupManager instead of private GroupManager
...
The public "IGroupManager" service returned by the dependency injection
system is automatically initialized with an "OC\Group\Database" backend.
However, no backend is automatically set in private "GroupManager"
instances. Therefore, a private "GroupManager" instance does not work as
expected when initialized through the dependency injection system.
Due to that this commit reverts a previous change in which the public
"IGroupManager" was replaced by a private "GroupManager" instance. That
change was needed when strict types were set, as "getSubAdmin()" is not
part of "IGroupManager" API, so the type had to be changed to
"GroupManager". Until a better solution is found strict types are
disabled again to be able to inject "IGroupManager" and also use
"getSubAdmin()".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-13 09:52:27 +01:00
d9d33d14e7
Make UserController strict
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 08:59:08 +01:00
5ad89371ed
Make ChangePasswordController strict
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-09 08:52:14 +01:00
9440e9bb1e
Fixed Controller Test
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:50 +01:00
00122fa027
Use group displayNames in users list
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-08 17:13:49 +01:00
82137f443d
Correctly return the group name
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:48 +01:00
4fa1d9628d
Set the correct active navigation entry
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-05 17:06:28 +01:00
8042e6b8fb
this was a migration step to ownCloud 8.0 to restructure the encryption folder which is no longer needed
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-03-02 10:09:52 +01:00
cf83eb5e77
Merge pull request #8336 from nextcloud/cleanup-unused-parameter
...
Cleanup unused parameter
2018-02-20 10:16:59 +01:00
cd2e5b549c
Merge pull request #8365 from nextcloud/fix-phpdoc
...
Fix typo in PHPDoc
2018-02-15 10:35:24 +01:00
9cb2aaa596
Fix typo in PHPDoc
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-15 10:21:31 +01:00
d3d045dd5c
Remove unused import statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
d18d323f21
Remove fromMailAddress from MailSettingsController
...
Was removed in https://github.com/nextcloud/server/pull/4379 (0a54d5ahttps://github.com/nextcloud/server/pull/4380 (bae64e8
2018-02-13 21:40:38 +01:00
b7c944fac1
Remove crypto and timefactory from UsersController
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:39:57 +01:00
f07d3a3b55
Link to NC 14 dev manual
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-08 21:26:04 +01:00
eb51f06a3b
Use ::class statement instead of string
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
6bbea33133
Simplify ternary operator statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 12:36:25 +01:00
0a56d2185e
Return value immediately instead of assigning to a one-time variable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +01:00
abd33bb619
Properly catch InvalidTokenException for better error response
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-24 13:56:12 +01:00
2a38605545
Properly log the full exception instead of only the message
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-23 10:57:21 +01:00
7618473a44
Add warning regarding freetype support
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-13 17:20:48 +01:00
ace96a406a
Show hint that PHP 5.6 will not be supported in Nextcloud 14 anymore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-08 10:02:41 +01:00
4d200851f9
Merge pull request #7292 from Neraste/fix/4789_disabled_users
...
Fix #4789 : Group admins cannot see disabled users
2017-11-27 17:29:59 +01:00
2622dda8c2
Fix #4789 : Group admins cannot see disabled users
2017-11-27 00:16:54 +01:00
df61d43529
Make isUpdateAvailable non-static
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-25 12:01:02 +01:00
eb0f3ebf75
Fix search in user managent when no group is selected
...
* also allows to search by displayname
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-14 17:32:03 +01:00
31c5c2a592
Change @georgehrke's email
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 20:38:59 +01:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 16:56:19 +01:00
John Molakvoæ (skjnldsv)
Daniel Kesselberg
Christoph Wurst
Joas Schilling
blizzz
Joas Schilling
Timo Förster
Michael Weimann
Morris Jobke
Roeland Jago Douma
Roeland Jago Douma
Cthulhux
Julius Härtl
Daniel Calviño Sánchez
Bjoern Schiessle
Lukas Reschke
Neraste