Commit Graph

56299 Commits

Author SHA1 Message Date
Robin Appelman a1935d0f74 cache baseurl in url generator
Servers don't tend to change their url in the middle of a request

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 19:38:41 +00:00
Roeland Jago Douma ae6c5f2af4
Merge pull request #26027 from nextcloud/backport/25933/stable20
[stable20] Hide expiration date field for remote shares
2021-03-10 15:46:53 +01:00
Vincent Petry aad21777d4 Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 09:08:28 +00:00
Roeland Jago Douma f240f895e7
Merge pull request #25878 from nextcloud/backport/25568/stable20
[stable20] disable trasbin during the moveFromStorage fallback
2021-03-10 09:34:02 +01:00
Julius Härtl 0c98c15555 Remove trash items from other trash backends when deleting all
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:02:38 +00:00
Nextcloud bot 8dc2b22e35
[tx-robot] updated from transifex 2021-03-10 02:23:17 +00:00
Roeland Jago Douma 0d021249f8
Merge pull request #25938 from nextcloud/backport/25927/stable20
[stable20] Sharebymail: set expiration on creation
2021-03-09 20:20:49 +01:00
Roeland Jago Douma 791868fa25
Merge pull request #25994 from nextcloud/backport/25975/stable20
[stable20] Add missing waits and asserts in acceptance tests
2021-03-09 09:34:25 +01:00
Nextcloud bot df04689af7
[tx-robot] updated from transifex 2021-03-09 02:24:13 +00:00
Roeland Jago Douma 5f3955446a
Merge pull request #26009 from nextcloud/dependabot/npm_and_yarn/stable20/elliptic-6.5.4
[Security] Bump elliptic from 6.5.3 to 6.5.4
2021-03-08 19:37:51 +01:00
dependabot-preview[bot] 7dffaabe8a
[Security] Bump elliptic from 6.5.3 to 6.5.4
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-08 16:52:54 +00:00
Daniel Calviño Sánchez ace7b9dfe1 Find directly the label instead of falling back to it
The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:37 +00:00
Daniel Calviño Sánchez f92a216dcf Assert also element visibility instead of just finding it
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:37 +00:00
Daniel Calviño Sánchez 30c91a7303 Add explicit locator for "Enable all" bundle button
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.

No "Disable all" locator was added as it was not currently needed
anywhere.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:36 +00:00
Daniel Calviño Sánchez 00b38db77f Find elements through the actor rather than the driver
"Actor::find" is a more robust way to look for elements, as it handles
some exceptions that may be thrown. Therefore, even if the elements are
not actually used and it is only checked whether they exist or not using
the actor is the preferred way when possible (and it also makes it
consistent with the rest of the acceptance tests).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:35 +00:00
Daniel Calviño Sánchez d293751ba7 Add locator for apps list
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:35 +00:00
Daniel Calviño Sánchez 5859458c52 Fix identation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:34 +00:00
Daniel Calviño Sánchez d548d212a2 Fix delete user acceptance test
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.

The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:33 +00:00
Daniel Calviño Sánchez dd1a554c79 Verify WaitFor::element... results with an assertion
WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:32 +00:00
Daniel Calviño Sánchez 8077dbf097 Add missing waits when finding elements in the acceptance tests
As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:32 +00:00
Roeland Jago Douma 0b8f41f5af
Merge pull request #25963 from nextcloud/backport/25712/stable20
[stable20] Fix admin password strengthify tooltip
2021-03-08 08:54:22 +01:00
Nextcloud bot 2046e71da2
[tx-robot] updated from transifex 2021-03-08 02:23:30 +00:00
Nextcloud bot 14b9c26b8a
[tx-robot] updated from transifex 2021-03-07 02:22:25 +00:00
Roeland Jago Douma f78c3f475b
Merge pull request #25956 from nextcloud/backport/25932/stable20
[stable20] Skip empty obsolete owner when adding to own NC
2021-03-06 10:55:08 +01:00
Nextcloud bot f209e862c2
[tx-robot] updated from transifex 2021-03-06 02:22:41 +00:00
Richard Steinmetz a8b780bdcb
Fix admin password strengthify tooltip
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-03-05 18:20:43 +01:00
Vincent Petry e92afefba7 Skip empty obsolete owner when adding to own NC
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.

Fixes an issue where "Add to your Nextcloud" doesn't add anything.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-05 13:38:09 +00:00
Roeland Jago Douma 41405facde
Merge pull request #25934 from nextcloud/backport/25926/stable20
[stable20] Activity: show if files are hidden or not
2021-03-05 14:29:27 +01:00
Roeland Jago Douma f70e6e8482
Merge pull request #25919 from nextcloud/backport/25805/stable20
[stable20] Clear multiselect after selection in share panel
2021-03-05 09:43:52 +01:00
Robin Appelman 326f7ac857 catch notfound and forbidden exception in smb::getmetadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-05 07:54:09 +00:00
Nextcloud bot b4d001db3a
[tx-robot] updated from transifex 2021-03-05 02:22:16 +00:00
Roeland Jago Douma 3089c744d2 Sharebymail: set expiration on creation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 18:52:43 +00:00
Roeland Jago Douma ede08b0f09 Activity: show if files are hidden or not
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 16:04:27 +00:00
Nextcloud bot 21ff951ca3
[tx-robot] updated from transifex 2021-03-04 02:22:30 +00:00
Vincent Petry d3db0f5000 Clear multiselect after selection in share panel
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-03 16:43:57 +00:00
blizzz 6ee39e204f
Merge pull request #25844 from nextcloud/backport/25757/stable20
[stable20] fix detecting cyclic group memberships
2021-03-03 10:43:21 +01:00
Roeland Jago Douma ff5491bf69
Merge pull request #25873 from nextcloud/backport/25869/stable20
[stable20] Fix namespacing
2021-03-03 08:46:21 +01:00
Roeland Jago Douma fbb719b29d
Merge pull request #25900 from nextcloud/backport/25860/stable20
[stable20] do not die after LDAP auth failed with expired acc
2021-03-03 08:35:16 +01:00
Nextcloud bot 25fbc9fdd6
[tx-robot] updated from transifex 2021-03-03 02:21:42 +00:00
Arthur Schiwon 4b9037e849 do not die after LDAP auth failed with expired acc
- some servers return error code 53

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-02 20:40:06 +00:00
Robin Appelman 59d157f1f2 disable trasbin during the moveFromStorage fallback
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-02 13:28:00 +00:00
Anna Larch 4b9e638cca Fix namespacing
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-03-02 10:10:29 +00:00
Roeland Jago Douma 9fea75d7d7
Merge pull request #25858 from nextcloud/backport/25856/stable20
[stable20] Card::getOwner should return the actual value
2021-03-02 09:24:40 +01:00
Nextcloud bot 5c474ee142
[tx-robot] updated from transifex 2021-03-02 02:22:41 +00:00
Roeland Jago Douma 622a3b8c74 Card::getOwner should return the actual value
I guess we never call this at runtime or it would already ahve done boom
very loudly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 17:30:33 +00:00
Roeland Jago Douma acb8fac983
Merge pull request #25848 from nextcloud/backport/25715/stable20
[stable20] Bump the ca location
2021-03-01 18:26:08 +01:00
Roeland Jago Douma 200a3db58e Bump the ca location
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 12:37:56 +00:00
Roeland Jago Douma b94ef32ed8
Merge pull request #25740 from nextcloud/backport/25602/stable20
[stable20] Avoid creating two share links when password is enforced
2021-03-01 12:49:36 +01:00
Arthur Schiwon ce6d64b122 fix detecting cyclic group memberships
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-01 11:13:14 +00:00
Julius Härtl fc935f1bc8
Avoid creating two share links when password is enforced
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 10:05:20 +01:00