extra debug for readonly stat

Signed-off-by: Robin Appelman <robin@icewind.nl>

apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php

@@ -64,10 +64,21 @@ class NativeFileInfo implements IFileInfo {
 			$rawAttributes = explode(',', $this->share->getAttribute($this->path, 'system.dos_attr.*'));
 			$this->attributeCache = [];
 			foreach ($rawAttributes as $rawAttribute) {
-				list($name, $value) = explode(':', $rawAttribute);
+				[$name, $value] = explode(':', $rawAttribute);
 				$name = strtolower($name);
 				if ($name == 'mode') {
-					$this->attributeCache[$name] = (int)hexdec(substr($value, 2));
+					$mode = (int)hexdec(substr($value, 2));
+					if ($mode > 0x1000) {
+						$readonly = !(bool)($mode & 0x80); // 0x80: owner write permissions
+					} else {
+						$readonly = (bool)($mode & IFileInfo::MODE_READONLY);
+					}
+					if ($readonly) {
+						\OC::$server->getLogger()->warning("Readonly file mode $value for ". $this->path);
+						$stat = $this->share->getStat($this->path);
+						\OC::$server->getLogger()->warning("Stat for readonly file is is: ". json_encode($stat));
+					}
+					$this->attributeCache[$name] = $mode;
 				} else {
 					$this->attributeCache[$name] = (int)$value;
 				}
@@ -112,7 +123,7 @@ class NativeFileInfo implements IFileInfo {
 
 		// Let us ignore the ATTR_NOT_CONTENT_INDEXED for now
 		$mode &= ~0x00002000;
-		
+
 		return $mode;
 	}
 
@@ -136,7 +147,15 @@ class NativeFileInfo implements IFileInfo {
 		if ($mode > 0x1000) {
 			return !(bool)($mode & 0x80); // 0x80: owner write permissions
 		} else {
-			return (bool)($mode & IFileInfo::MODE_READONLY);
+			$readonly = (bool)($mode & IFileInfo::MODE_READONLY);
+			if ($readonly && $this->path = "") {
+				// there seems to be a difference behavior between the various ways of getting the mode when querying the root, double check readonly status
+				$stat = $this->share->getStat($this->path);
+				\OC::$server->getLogger()->warning("Readonly root detected, stat for root is: ". json_encode($stat));
+				return (bool)($stat['mode'] && IFileInfo::MODE_READONLY);
+			} else {
+				return $readonly;
+			}
 		}
 	}
 

apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php

@@ -115,6 +115,10 @@ class NativeShare extends AbstractShare {
 		return $info;
 	}
 
+	public function getStat(string $path): array {
+		return $this->getState()->stat($this->buildUrl($path));
+	}
+
 	/**
 	 * Multibyte unicode safe version of basename()
 	 *