Fix sharing creation insert and get

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

lib/private/Share20/DefaultShareProvider.php

@@ -204,32 +204,24 @@ class DefaultShareProvider implements IShareProvider {
 		$qb->setValue('file_target', $qb->createNamedParameter($share->getTarget()));
 
 		// Set the time this share was created
-		$qb->setValue('stime', $qb->createNamedParameter(time()));
+		$time = time();
+		$qb->setValue('stime', $qb->createNamedParameter($time));
 
 		// insert the data and fetch the id of the share
-		$this->dbConn->beginTransaction();
-		$qb->execute();
-		$id = $this->dbConn->lastInsertId('*PREFIX*share');
+		$qb->executeUpdate();
 
-		// Now fetch the inserted share and create a complete share object
-		$qb = $this->dbConn->getQueryBuilder();
-		$qb->select('*')
-			->from('share')
-			->where($qb->expr()->eq('id', $qb->createNamedParameter($id)));
+		// Update mandatory data
+		$id = $qb->getLastInsertId();
+		$share->setId($id);
+		$share->setProviderId($this->identifier());
 
-		$cursor = $qb->execute();
-		$data = $cursor->fetch();
-		$this->dbConn->commit();
-		$cursor->closeCursor();
-
-		if ($data === false) {
-			throw new ShareNotFound();
-		}
+		$shareTime = new \DateTime();
+		$shareTime->setTimestamp($time);
+		$share->setShareTime($shareTime);
 
 		$mailSendValue = $share->getMailSend();
-		$data['mail_send'] = ($mailSendValue === null) ? true : $mailSendValue;
+		$share->setMailSend(($mailSendValue === null) ? true : $mailSendValue);
 
-		$share = $this->createShare($data);
 		return $share;
 	}
 

lib/public/Share/Exceptions/ShareNotFound.php

@@ -28,4 +28,18 @@ namespace OCP\Share\Exceptions;
  * @since 9.0.0
  */
 class ShareNotFound extends GenericShareException {
+
+	/**
+	 * @param string $message
+	 * @param string $hint
+	 * @param int $code
+	 * @param \Exception|null $previous
+	 * @since 9.0.0
+	 */
+	public function __construct($message = '', ...$arguments) {
+		if (empty($message)) {
+			$message = 'Share not found';
+		}
+		parent::__construct($message, ...$arguments);
+	}
 }