mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
27,900 Commits 349 Branches 696 Tags 1.6 GiB
JavaScript 49%
PHP 47.6%
Gherkin 1.2%
Vue 1.2%
CSS 0.6%
Other 0.4%
Go to file
Lukas Reschke 13e817e901 Throw exception on `getPath` if file does not exist 
Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened.

This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs.

While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page.

I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.
 		2015-10-25 17:58:21 +01:00
.idea Add newline that was removed by 15be763d46 2014-12-10 09:38:32 +01:00
3rdparty@ba133e82fe Bump 3rdparty for guzzlehttp/http to 5.3.0 2015-10-23 22:02:53 +02:00
apps Throw exception on `getPath` if file does not exist 2015-10-25 17:58:21 +01:00
build added tests for apps 2015-10-22 13:28:48 +00:00
config Add syslog_tag docu to sample config 2015-10-23 13:43:41 +02:00
core [tx-robot] updated from transifex 2015-10-25 01:55:04 -04:00
l10n Merge pull request #19398 from owncloud/fix-tranifex 2015-09-28 10:49:06 +02:00
lib Throw exception on `getPath` if file does not exist 2015-10-25 17:58:21 +01:00
ocs Combine OCS API getUser method code into provisioning_api app 2015-10-13 21:07:48 +02:00
ocs-provider Reference v2 in the provider list 2015-10-13 16:45:16 +02:00
resources/config Updated some mimetypes 2015-10-02 15:28:23 +02:00
settings [tx-robot] updated from transifex 2015-10-25 01:55:04 -04:00
tests Throw exception on `getPath` if file does not exist 2015-10-25 17:58:21 +01:00
themes Update example theme with App URLs and PHPDoc 2015-10-05 11:15:14 +02:00
.bowerrc ability to add bower resources 2014-11-03 20:54:40 +01:00
.gitignore Consolidate webdav code - move all to one app 2015-10-16 13:17:12 +02:00
.gitmodules use https as submodule url 2014-03-21 19:38:22 +01:00
.htaccess Remove legacy non-working rewrites in .htaccess 2015-10-15 14:22:43 +02:00
.jshintrc enable laxbreak option in jshintrc to comply with our coding guide lines 2014-11-04 12:51:54 +01:00
.mailmap deduplicate @xenopathic 2015-10-06 09:52:19 +02:00
.scrutinizer.yml Specify PHP 5.4 as version for scrutinizer 2015-10-14 22:50:47 +02:00
.tag Add .tag file to make tar balls tracable 2014-06-14 17:40:32 +02:00
.user.ini Also set output_buffering in .user.ini to 0 2015-09-29 17:49:37 +02:00
AUTHORS Add myself as author 2014-09-19 17:24:12 +02:00
CONTRIBUTING.md Add information how to report security bugs 2015-05-29 19:28:45 +02:00
COPYING-AGPL Really add AGPL file 2011-02-09 15:12:09 +00:00
COPYING-README correct icon license, we use Elementary icons, not Silk anymore 2014-07-15 11:35:49 +02:00
README.md Update doc links in README for 9.0 2015-10-21 13:13:12 +02:00
autotest-external.sh Use a universal shebang 2015-09-27 13:03:31 +02:00
autotest-hhvm.sh Combine autotest-hhvm.sh with autotest.sh 2015-05-04 16:37:23 +02:00
autotest-js.sh Use a universal shebang 2015-09-27 13:03:31 +02:00
autotest.cmd Restore the development config after running the tests 2014-12-02 12:41:33 +01:00
autotest.sh Fix termination of the ceph docker 2015-10-16 21:41:51 +02:00
bower.json add backbone.js 2015-08-06 00:00:40 +02:00
buildjsdocs.sh Use a universal shebang 2015-09-27 13:03:31 +02:00
console.php update licence headers via script 2015-10-05 21:15:52 +02:00
cron.php update licence headers via script 2015-10-05 21:15:52 +02:00
db_structure.xml Use integer for availability instead of bool 2015-09-15 10:18:32 +02:00
index.html Try to prefer index.php over index.html in the same directory 2013-04-24 15:11:53 +02:00
index.php update licence headers via script 2015-10-05 21:15:52 +02:00
issue_template.md Add example command to the issue_template.md 2015-07-07 11:18:25 +02:00
occ Use a more universal shebang 2014-11-19 17:34:03 +01:00
public.php update licence headers via script 2015-10-05 21:15:52 +02:00
remote.php Consolidate webdav code - move all to one app 2015-10-16 13:17:12 +02:00
robots.txt Add robot.txt 2013-01-28 16:39:53 -06:00
status.php update licence headers via script 2015-10-05 21:15:52 +02:00
version.php increase core version and add dav version number 2015-10-21 11:36:44 +02:00

README.md

ownCloud

ownCloud gives you freedom and control over your own data. A personal cloud which runs on your own server.

Build Status on Jenkins CI

Git master: Build Status

Quality:

  • Scrutinizer: Scrutinizer Quality Score
  • CodeClimate: Code Climate

Dependencies:

Dependency Status

Dependency Status

Installation instructions

https://doc.owncloud.org/server/9.0/developer_manual/app/index.html

Contribution Guidelines

https://owncloud.org/contribute/

Get in touch

Important notice on translations

Please submit translations via Transifex: https://www.transifex.com/projects/p/owncloud/

Transifex

For more detailed information about translations: http://doc.owncloud.org/server/9.0/developer_manual/core/translation.html