202530f4f3
When no cookies are sent it is not required to perform any check for the strict or lax cookie, it does not provide any significant security advantage.
It does however interfer with the Android client which requests thumbnails from the unofficial API at `/index.php/apps/files/api/v1/thumbnail/256/256/{filename}`. This endpoint expects the strict cookie to be existent to not leak the existence of files. The Android client authenticates against this endpoint using Basic Auth and without cookies in some cases at least. This will make these endpoints work again with such cases.
To test this issue the following cURL command once without the patch and once with:
> curl http://localhost/index.php/apps/files/api/v1/thumbnail/256/256/welcome.txt -u admin -v
Without the patch the request is redirected (which the client does not obey) and with the patch the preview is returned.
|
||
|---|---|---|
| .. | ||
| ContentSecurityPolicyTest.php | ||
| DataResponseTest.php | ||
| DispatcherTest.php | ||
| DownloadResponseTest.php | ||
| EmptyContentSecurityPolicyTest.php | ||
| HttpTest.php | ||
| JSONResponseTest.php | ||
| OCSResponseTest.php | ||
| RedirectResponseTest.php | ||
| RequestTest.php | ||
| ResponseTest.php | ||
| StreamResponseTest.php | ||
| TemplateResponseTest.php | ||
| requeststream.php | ||