nextcloud/core/templates
Lukas Reschke a04feff9a7
Properly allow \OCP\Authentication\IApacheBackend to specify logout URL
Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string.
This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result
in `<a href="foo">`.

This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with
054e161eb5 inside the navigation manager where one cannot simply inject attributes.

Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112,
people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects
you to the IdP and properly logs you out there as well.

Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to
use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout
URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but
I'm not aware of any and there's simply no way to fix this properly otherwise.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-08-18 12:22:44 +02:00
..
filetemplates Fix #24655 2016-05-17 20:43:02 +02:00
loginflow Remove quotes around device name 2017-08-14 11:48:56 +02:00
lostpassword Update email template for lost password email 2017-04-12 15:19:53 -05:00
403.php Fix 403 and 404 redirect 2017-07-26 16:30:09 +02:00
404.php Fix 403 and 404 redirect 2017-07-26 16:30:09 +02:00
error.php Replace unecessary unescaped prints with print 2017-03-29 00:43:44 +02:00
exception.php Move away from OC_L10N 2016-10-28 21:46:28 +02:00
filepicker.html show empty folder message in filepicker 2016-10-21 16:35:55 +02:00
installation.php Fix value of attribute "autocapitalize" 2017-03-18 16:06:57 +01:00
layout.base.php Streamline templates, more DRY 2017-05-25 11:13:43 +02:00
layout.guest.php Logo claim is not used anymore 2017-08-02 23:08:45 +02:00
layout.noscript.warning.php Deduplicate template code and do not translate the links 2015-02-09 16:01:52 +01:00
layout.user.php Revert "Proof of concept #5593 - inline SVG icon for icon-contacts" 2017-08-03 17:27:24 +02:00
login.php Replace loading icon GIF with pure CSS loading icon 2017-08-03 21:09:43 +02:00
message.html Remove uninterpreted PHP 2016-08-19 14:24:26 +02:00
tags.html addressing #14982 self-closing tags ending slash doesn't have a purpose & should be removed 2015-03-17 23:57:23 +01:00
twofactorselectchallenge.php Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 2017-08-18 12:22:44 +02:00
twofactorshowchallenge.php Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 2017-08-18 12:22:44 +02:00
untrustedDomain.php Initial work on Apps page split: 2016-08-09 18:05:09 +02:00
update.admin.php reduce info on update screens, introduce button to refresh 2016-08-04 12:48:25 +02:00
update.use-cli.php Allow to enforce update via web UI 2017-05-11 10:22:44 -05:00
update.user.php addressing #14982 self-closing tags ending slash doesn't have a purpose & should be removed 2015-03-17 23:57:23 +01:00