mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
nextcloud/tests/lib
History
Lukas Reschke a04feff9a7
Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 
Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string.
This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result
in `<a href="foo">`.

This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with
054e161eb5 inside the navigation manager where one cannot simply inject attributes.

Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112,
people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects
you to the IdP and properly logs you out there as well.

Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to
use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout
URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but
I'm not aware of any and there's simply no way to fix this properly otherwise.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 		2017-08-18 12:22:44 +02:00
..
Accounts fix email verification status 2017-04-28 23:41:37 -03:00
Activity Fix activity manager tests 2016-11-16 09:25:45 +01:00
App Add new bundle 2017-07-26 11:49:03 +02:00
AppFramework Remove explicit type hints for Controller 2017-08-01 17:32:03 +02:00
Archive Remove unneeded checks if it runs on a Windows machine 2016-07-08 15:55:17 +02:00
Authentication Merge pull request #4894 from nextcloud/generic-security-activities 2017-05-19 00:50:44 +02:00
BackgroundJob Add duration of last job execution to the table 2017-04-25 17:39:58 +02:00
Cache Make cache tests a bit more clear 2017-05-04 19:37:40 -03:00
Command Add proper tests 2016-12-19 15:35:31 +01:00
Comments Can not insert auto increment on oracle 2017-08-02 09:48:16 +02:00
Contacts/ContactsMenu Do not show an email action for contacts with emtpy email addresses 2017-05-02 14:12:04 +02:00
DB Fix querybuilder and functionbuilder tests 2017-08-02 09:48:16 +02:00
Diagnostics Adjust query/event logging code in favour of more complex owncloud/diagnostics (#27643) 2017-04-26 13:19:43 +02:00
Encryption Don't use deprecated getMock() anymore 2017-04-20 12:30:21 +02:00
Federation clean cloud ids 2017-02-09 13:31:06 +01:00
Files Cleanup unused methods 2017-08-15 14:29:26 +02:00
GlobalScale add new config switched for the global scale architecture 2017-05-29 18:19:28 +02:00
Group Remove legacy OC_User_Backend and OC_User_Interface 2017-07-24 20:42:55 +02:00
Hooks Move tests/ to PSR-4 (#24731) 2016-05-20 15:38:20 +02:00
Http/Client Merge pull request #2912 from nextcloud/increase-coverage-response.php 2017-01-02 16:01:47 +01:00
IntegrityCheck Add proper tests 2016-12-19 15:35:31 +01:00
L10N Use symfony/translation for L10N plurals 2017-08-07 19:53:36 +02:00
Lock Fix getMock DBLockingProviderTest 2016-09-13 09:09:53 +02:00
Lockdown Save the scope of an auth token in the session 2017-04-05 17:58:33 +02:00
Log Delete the correct config value 2017-04-20 12:23:12 +02:00
Mail Rename renderHTML to renderHtml 2017-04-19 15:46:41 -05:00
Memcache Make cache tests a bit more clear 2017-05-04 19:37:40 -03:00
Migration Fix getMock Migration 2016-09-07 20:42:38 +02:00
Notification Use a php class for the definitions to avoid loading problems 2016-11-09 08:52:07 +01:00
OCS PrivateData to app 2017-07-21 08:51:14 +02:00
Preview fix preview tests 2017-05-02 13:43:48 +02:00
PublicNamespace Move tests/ to PSR-4 (#24731) 2016-05-20 15:38:20 +02:00
Repair Fix RepairMimeTypeTest 2017-08-09 16:04:57 +02:00
RichObjectStrings Add test and adjust PHP function arguments 2016-11-09 10:49:57 +01:00
Security Add bruteforce capabilities 2017-07-13 11:23:08 +02:00
Session Move tests/ to PSR-4 (#24731) 2016-05-20 15:38:20 +02:00
Settings Always log cron execution 2017-08-17 09:45:11 +02:00
Share Cleanup unused methods 2017-08-15 14:29:26 +02:00
Share20 Move pre_shared and post_shared events to EventDispatcher 2017-08-03 15:14:29 +02:00
SystemTag test setTagGroups with empty groupids 2017-03-19 22:01:46 -06:00
Template Properly handle if the deps file if for some reason empty 2017-07-19 00:10:46 +02:00
Traits fix and extend dav test to also test the master-key setup 2017-07-06 11:47:11 +02:00
Updater Update the URLs in tests to use example.org 2017-08-01 11:16:04 +02:00
User Fix SessionTest 2017-08-09 16:13:54 +02:00
Util Stricter phan config fixes 2017-08-01 08:20:13 +02:00
APITest.php FIx lib/ a-d 2016-05-19 09:27:21 +02:00
AllConfigTest.php Don't use deprecated getMock() anymore 2017-04-20 12:30:21 +02:00
AppConfigTest.php Fix tests 2017-01-12 10:49:22 +01:00
AppTest.php Fix tests 2017-05-20 16:38:32 -05:00
AutoLoaderTest.php Fix unit tests 2016-05-20 16:35:07 +02:00
AvatarManagerTest.php Add using casing check/fix for initMountPoints 2016-11-02 22:21:46 +01:00
AvatarTest.php avatar to appdata 2016-10-05 11:00:16 +02:00
CapabilitiesManagerTest.php Add tests for public capabilties 2017-06-30 11:21:15 +02:00
ConfigTest.php Check for boolean false and add tests 2017-04-04 15:56:50 -05:00
ContactsManagerTest.php FIx lib/ a-d 2016-05-19 09:27:21 +02:00
DateTimeFormatterTest.php Fix more tests 2016-10-28 22:16:28 +02:00
ErrorHandlerTest.php FIx lib/ a-d 2016-05-19 09:27:21 +02:00
FileChunkingTest.php Fix getMock FileChunkingTest 2016-09-07 20:42:37 +02:00
FilesTest.php Make sure memory limit is > post size and upload filesize 2016-09-13 16:50:36 +02:00
HTTPHelperTest.php Fix getMock HTTPHelper 2016-09-07 20:42:37 +02:00
HelperStorageTest.php fix quota tests for external storage 2017-05-12 11:32:16 -05:00
HookHelper.php Move tests/ to PSR-4 (#24731) 2016-05-20 15:38:20 +02:00
ImageTest.php Use 90% JPEG quality for thumbnails and previews by default 2017-02-22 14:53:15 +01:00
InfoXmlTest.php Add the AppContainer 2017-03-22 11:24:16 +01:00
InstallerTest.php Fix the installer tests 2017-07-05 13:02:16 +02:00
LargeFileHelperGetFileSizeTest.php Remove unneeded Windows logic 2016-09-01 10:47:57 +02:00
LargeFileHelperTest.php Move tests/ to PSR-4 (#24731) 2016-05-20 15:38:20 +02:00
LegacyHelperTest.php Simplify isSubDirectory check 2016-10-07 21:56:43 +02:00
LoggerTest.php Better fallback for unknown log types 2017-01-10 12:59:13 +01:00
NaturalSortTest.php Fix lib/ 2016-05-19 09:38:52 +02:00
NavigationManagerTest.php Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 2017-08-18 12:22:44 +02:00
RepairStepTest.php Don't use deprecated getMock() anymore 2017-04-20 12:30:21 +02:00
ServerTest.php Remove IDb interface which was deprecated for 3 years already 2016-12-14 11:42:16 +01:00
SetupTest.php Move OC_Defaults to OCP\Defaults 2017-04-09 21:43:01 -05:00
SubAdminTest.php Move tests/ to PSR-4 (#24731) 2016-05-20 15:38:20 +02:00
TagsTest.php Merge pull request #6123 from nextcloud/cleanup-shareItem 2017-08-15 13:57:00 +02:00
TempManagerTest.php Fix getMock TempManagerTest 2016-09-07 20:42:38 +02:00
TemplateFunctionsTest.php Fix lib/ 2016-05-19 09:38:52 +02:00
TestCase.php Move OC_Defaults to OCP\Defaults 2017-04-09 21:43:01 -05:00
TestMoveableMountPoint.php Move tests/ to PSR-4 (#24731) 2016-05-20 15:38:20 +02:00
UpdaterTest.php Prevent migration from ownCloud 11 to Nextcloud 12 2017-01-23 12:04:46 +01:00
UrlGeneratorTest.php Add tests and inject IRequest 2017-06-16 10:51:31 +02:00
UserTest.php Remove warning 2017-01-05 12:17:30 +01:00
UtilCheckServerTest.php Use SystemConfig instead of AllConfig for DB stuff 2017-03-19 15:53:49 -06:00
UtilTest.php Use IConfig instead of static OCP\Config 2017-07-27 13:43:18 +02:00