547 lines
16 KiB
PHP
547 lines
16 KiB
PHP
<?php
|
|
/**
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
*
|
|
* @author Björn Schießle <bjoern@schiessle.org>
|
|
* @author Joas Schilling <coding@schilljs.com>
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
*
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
|
|
namespace OCA\Files_Sharing\Tests\Controller;
|
|
|
|
use OC\Federation\CloudIdManager;
|
|
use OCA\Files_Sharing\Controller\ShareesAPIController;
|
|
use OCA\Files_Sharing\Tests\TestCase;
|
|
use OCP\AppFramework\Http;
|
|
use OCP\AppFramework\OCS\OCSBadRequestException;
|
|
use OCP\Federation\ICloudIdManager;
|
|
use OCP\Http\Client\IClientService;
|
|
use OCP\Share;
|
|
|
|
/**
|
|
* Class ShareesTest
|
|
*
|
|
* @group DB
|
|
*
|
|
* @package OCA\Files_Sharing\Tests\API
|
|
*/
|
|
class ShareesAPIControllerTest extends TestCase {
|
|
/** @var ShareesAPIController */
|
|
protected $sharees;
|
|
|
|
/** @var \OCP\IUserManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $userManager;
|
|
|
|
/** @var \OCP\IGroupManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $groupManager;
|
|
|
|
/** @var \OCP\Contacts\IManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $contactsManager;
|
|
|
|
/** @var \OCP\IUserSession|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $session;
|
|
|
|
/** @var \OCP\IRequest|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $request;
|
|
|
|
/** @var \OCP\Share\IManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
protected $shareManager;
|
|
|
|
/** @var IClientService|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $clientService;
|
|
|
|
/** @var ICloudIdManager */
|
|
private $cloudIdManager;
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
|
|
$this->userManager = $this->getMockBuilder('OCP\IUserManager')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->groupManager = $this->getMockBuilder('OCP\IGroupManager')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->contactsManager = $this->getMockBuilder('OCP\Contacts\IManager')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->session = $this->getMockBuilder('OCP\IUserSession')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->request = $this->getMockBuilder('OCP\IRequest')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->shareManager = $this->getMockBuilder('OCP\Share\IManager')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->clientService = $this->createMock(IClientService::class);
|
|
|
|
$this->cloudIdManager = new CloudIdManager();
|
|
|
|
$this->sharees = new ShareesAPIController(
|
|
'files_sharing',
|
|
$this->request,
|
|
$this->groupManager,
|
|
$this->userManager,
|
|
$this->contactsManager,
|
|
$this->getMockBuilder('OCP\IConfig')->disableOriginalConstructor()->getMock(),
|
|
$this->session,
|
|
$this->getMockBuilder('OCP\IURLGenerator')->disableOriginalConstructor()->getMock(),
|
|
$this->getMockBuilder('OCP\ILogger')->disableOriginalConstructor()->getMock(),
|
|
$this->shareManager,
|
|
$this->clientService,
|
|
$this->cloudIdManager
|
|
);
|
|
}
|
|
|
|
public function dataSearch() {
|
|
$noRemote = [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_EMAIL];
|
|
$allTypes = [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_REMOTE, Share::SHARE_TYPE_EMAIL];
|
|
|
|
return [
|
|
[[], '', 'yes', true, true, $noRemote, false, true, true],
|
|
|
|
// Test itemType
|
|
[[
|
|
'search' => '',
|
|
], '', 'yes', true, true, $noRemote, false, true, true],
|
|
[[
|
|
'search' => 'foobar',
|
|
], '', 'yes', true, true, $noRemote, false, true, true],
|
|
[[
|
|
'search' => 0,
|
|
], '', 'yes', true, true, $noRemote, false, true, true],
|
|
|
|
// Test itemType
|
|
[[
|
|
'itemType' => '',
|
|
], '', 'yes', true, true, $noRemote, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 0,
|
|
], '', 'yes', true, true, $noRemote, false, true, true],
|
|
|
|
// Test shareType
|
|
[[
|
|
'itemType' => 'call',
|
|
], '', 'yes', true, true, $noRemote, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => 0,
|
|
], '', 'yes', true, false, [0], false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => '0',
|
|
], '', 'yes', true, false, [0], false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => 1,
|
|
], '', 'yes', true, false, [1], false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => 12,
|
|
], '', 'yes', true, false, [], false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => 'foobar',
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => [0, 1, 2],
|
|
], '', 'yes', false, false, [0, 1], false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => [0, 1],
|
|
], '', 'yes', false, false, [0, 1], false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => $allTypes,
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => $allTypes,
|
|
], '', 'yes', false, false, [0, 1], false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => $allTypes,
|
|
], '', 'yes', true, false, [0, 6], false, true, false],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'shareType' => $allTypes,
|
|
], '', 'yes', false, true, [0, 4], false, true, false],
|
|
|
|
// Test pagination
|
|
[[
|
|
'itemType' => 'folder',
|
|
'page' => 1,
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'page' => 10,
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
|
|
// Test perPage
|
|
[[
|
|
'itemType' => 'folder',
|
|
'perPage' => 1,
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
'perPage' => 10,
|
|
], '', 'yes', true, true, $allTypes, false, true, true],
|
|
|
|
// Test $shareWithGroupOnly setting
|
|
[[
|
|
'itemType' => 'folder',
|
|
], 'no', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
], 'yes', 'yes', true, true, $allTypes, true, true, true],
|
|
|
|
// Test $shareeEnumeration setting
|
|
[[
|
|
'itemType' => 'folder',
|
|
], 'no', 'yes', true, true, $allTypes, false, true, true],
|
|
[[
|
|
'itemType' => 'folder',
|
|
], 'no', 'no', true, true, $allTypes, false, false, true],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataSearch
|
|
*
|
|
* @param array $getData
|
|
* @param string $apiSetting
|
|
* @param string $enumSetting
|
|
* @param bool $remoteSharingEnabled
|
|
* @param bool $emailSharingEnabled
|
|
* @param array $shareTypes
|
|
* @param bool $shareWithGroupOnly
|
|
* @param bool $shareeEnumeration
|
|
* @param bool $allowGroupSharing
|
|
*/
|
|
public function testSearch($getData, $apiSetting, $enumSetting, $remoteSharingEnabled, $emailSharingEnabled, $shareTypes, $shareWithGroupOnly, $shareeEnumeration, $allowGroupSharing) {
|
|
$search = isset($getData['search']) ? $getData['search'] : '';
|
|
$itemType = isset($getData['itemType']) ? $getData['itemType'] : 'irrelevant';
|
|
$page = isset($getData['page']) ? $getData['page'] : 1;
|
|
$perPage = isset($getData['perPage']) ? $getData['perPage'] : 200;
|
|
$shareType = isset($getData['shareType']) ? $getData['shareType'] : null;
|
|
|
|
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
|
|
$config = $this->createMock(IConfig::class);
|
|
$config->expects($this->exactly(2))
|
|
->method('getAppValue')
|
|
->with('core', $this->anything(), $this->anything())
|
|
->willReturnMap([
|
|
['core', 'shareapi_only_share_with_group_members', 'no', $apiSetting],
|
|
['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', $enumSetting],
|
|
]);
|
|
|
|
$this->shareManager->expects($itemType === 'file' || $itemType === 'folder' ? $this->once() : $this->never())
|
|
->method('allowGroupSharing')
|
|
->willReturn($allowGroupSharing);
|
|
|
|
/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject $request */
|
|
$request = $this->createMock(IRequest::class);
|
|
/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGenerator */
|
|
$urlGenerator = $this->createMock(IURLGenerator::class);
|
|
|
|
/** @var \PHPUnit_Framework_MockObject_MockObject|\OCA\Files_Sharing\Controller\ShareesAPIController $sharees */
|
|
$sharees = $this->getMockBuilder('\OCA\Files_Sharing\Controller\ShareesAPIController')
|
|
->setConstructorArgs([
|
|
'files_sharing',
|
|
$request,
|
|
$config,
|
|
$urlGenerator,
|
|
$this->shareManager,
|
|
$this->collaboratorSearch
|
|
])
|
|
->setMethods(['isRemoteSharingAllowed', 'shareProviderExists'])
|
|
->getMock();
|
|
|
|
$this->collaboratorSearch->expects($this->once())
|
|
->method('search')
|
|
->with($search, $shareTypes, $this->anything(), $perPage, $this->invokePrivate($sharees, 'offset'))
|
|
->willReturn([[], false]);
|
|
|
|
$sharees->expects($this->any())
|
|
->method('isRemoteSharingAllowed')
|
|
->with($itemType)
|
|
->willReturn($remoteSharingEnabled);
|
|
|
|
$this->shareManager->expects($this->any())
|
|
->method('shareProviderExists')
|
|
->with(\OCP\Share::SHARE_TYPE_EMAIL)
|
|
->willReturn($emailSharingEnabled);
|
|
|
|
$this->assertInstanceOf(Http\DataResponse::class, $sharees->search($search, $itemType, $page, $perPage, $shareType));
|
|
|
|
$this->assertSame($shareWithGroupOnly, $this->invokePrivate($sharees, 'shareWithGroupOnly'));
|
|
$this->assertSame($shareeEnumeration, $this->invokePrivate($sharees, 'shareeEnumeration'));
|
|
}
|
|
|
|
public function dataSearchInvalid() {
|
|
return [
|
|
// Test invalid pagination
|
|
[[
|
|
'page' => 0,
|
|
], 'Invalid page'],
|
|
[[
|
|
'page' => '0',
|
|
], 'Invalid page'],
|
|
[[
|
|
'page' => -1,
|
|
], 'Invalid page'],
|
|
|
|
// Test invalid perPage
|
|
[[
|
|
'perPage' => 0,
|
|
], 'Invalid perPage argument'],
|
|
[[
|
|
'perPage' => '0',
|
|
], 'Invalid perPage argument'],
|
|
[[
|
|
'perPage' => -1,
|
|
], 'Invalid perPage argument'],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataSearchInvalid
|
|
*
|
|
* @param array $getData
|
|
* @param string $message
|
|
*/
|
|
public function testSearchInvalid($getData, $message) {
|
|
$page = isset($getData['page']) ? $getData['page'] : 1;
|
|
$perPage = isset($getData['perPage']) ? $getData['perPage'] : 200;
|
|
|
|
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
|
|
$config = $this->createMock(IConfig::class);
|
|
$config->expects($this->never())
|
|
->method('getAppValue');
|
|
|
|
/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject $request */
|
|
$request = $this->createMock(IRequest::class);
|
|
/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGenerator */
|
|
$urlGenerator = $this->createMock(IURLGenerator::class);
|
|
|
|
/** @var \PHPUnit_Framework_MockObject_MockObject|\OCA\Files_Sharing\Controller\ShareesAPIController $sharees */
|
|
$sharees = $this->getMockBuilder('\OCA\Files_Sharing\Controller\ShareesAPIController')
|
|
->setConstructorArgs([
|
|
'files_sharing',
|
|
$request,
|
|
$config,
|
|
$urlGenerator,
|
|
$this->shareManager,
|
|
$this->collaboratorSearch
|
|
])
|
|
->setMethods(['isRemoteSharingAllowed'])
|
|
->getMock();
|
|
$sharees->expects($this->never())
|
|
->method('isRemoteSharingAllowed');
|
|
|
|
$this->collaboratorSearch->expects($this->never())
|
|
->method('search');
|
|
|
|
try {
|
|
$sharees->search('', null, $page, $perPage, null);
|
|
$this->fail();
|
|
} catch (OCSBadRequestException $e) {
|
|
$this->assertEquals($message, $e->getMessage());
|
|
}
|
|
}
|
|
|
|
public function dataIsRemoteSharingAllowed() {
|
|
return [
|
|
['file', true],
|
|
['folder', true],
|
|
['', false],
|
|
['contacts', false],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataIsRemoteSharingAllowed
|
|
*
|
|
* @param string $itemType
|
|
* @param bool $expected
|
|
*/
|
|
public function testIsRemoteSharingAllowed($itemType, $expected) {
|
|
$this->assertSame($expected, $this->invokePrivate($this->sharees, 'isRemoteSharingAllowed', [$itemType]));
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSBadRequestException
|
|
* @expectedExceptionMessage Missing itemType
|
|
*/
|
|
public function testSearchShareesNoItemType() {
|
|
$this->invokePrivate($this->sharees, 'searchSharees', ['', null, [], [], 0, 0, false]);
|
|
}
|
|
|
|
public function dataGetPaginationLink() {
|
|
return [
|
|
[1, '/ocs/v1.php', ['perPage' => 2], '<?perPage=2&page=2>; rel="next"'],
|
|
[10, '/ocs/v2.php', ['perPage' => 2], '<?perPage=2&page=11>; rel="next"'],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataGetPaginationLink
|
|
*
|
|
* @param int $page
|
|
* @param string $scriptName
|
|
* @param array $params
|
|
* @param array $expected
|
|
*/
|
|
public function testGetPaginationLink($page, $scriptName, $params, $expected) {
|
|
$this->request->expects($this->once())
|
|
->method('getScriptName')
|
|
->willReturn($scriptName);
|
|
|
|
$this->assertEquals($expected, $this->invokePrivate($this->sharees, 'getPaginationLink', [$page, $params]));
|
|
}
|
|
|
|
public function dataIsV2() {
|
|
return [
|
|
['/ocs/v1.php', false],
|
|
['/ocs/v2.php', true],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataIsV2
|
|
*
|
|
* @param string $scriptName
|
|
* @param bool $expected
|
|
*/
|
|
public function testIsV2($scriptName, $expected) {
|
|
$this->request->expects($this->once())
|
|
->method('getScriptName')
|
|
->willReturn($scriptName);
|
|
|
|
$this->assertEquals($expected, $this->invokePrivate($this->sharees, 'isV2'));
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataTestSplitUserRemote
|
|
*
|
|
* @param string $remote
|
|
* @param string $expectedUser
|
|
* @param string $expectedUrl
|
|
*/
|
|
public function testSplitUserRemote($remote, $expectedUser, $expectedUrl) {
|
|
list($remoteUser, $remoteUrl) = $this->sharees->splitUserRemote($remote);
|
|
$this->assertSame($expectedUser, $remoteUser);
|
|
$this->assertSame($expectedUrl, $remoteUrl);
|
|
}
|
|
|
|
public function dataTestSplitUserRemote() {
|
|
$userPrefix = ['user@name', 'username'];
|
|
$protocols = ['', 'http://', 'https://'];
|
|
$remotes = [
|
|
'localhost',
|
|
'local.host',
|
|
'dev.local.host',
|
|
'dev.local.host/path',
|
|
'dev.local.host/at@inpath',
|
|
'127.0.0.1',
|
|
'::1',
|
|
'::192.0.2.128',
|
|
'::192.0.2.128/at@inpath',
|
|
];
|
|
|
|
$testCases = [];
|
|
foreach ($userPrefix as $user) {
|
|
foreach ($remotes as $remote) {
|
|
foreach ($protocols as $protocol) {
|
|
$baseUrl = $user . '@' . $protocol . $remote;
|
|
|
|
$testCases[] = [$baseUrl, $user, $protocol . $remote];
|
|
$testCases[] = [$baseUrl . '/', $user, $protocol . $remote];
|
|
$testCases[] = [$baseUrl . '/index.php', $user, $protocol . $remote];
|
|
$testCases[] = [$baseUrl . '/index.php/s/token', $user, $protocol . $remote];
|
|
}
|
|
}
|
|
}
|
|
return $testCases;
|
|
}
|
|
|
|
public function dataTestSplitUserRemoteError() {
|
|
return array(
|
|
// Invalid path
|
|
array('user@'),
|
|
|
|
// Invalid user
|
|
array('@server'),
|
|
array('us/er@server'),
|
|
array('us:er@server'),
|
|
|
|
// Invalid splitting
|
|
array('user'),
|
|
array(''),
|
|
array('us/erserver'),
|
|
array('us:erserver'),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataTestSplitUserRemoteError
|
|
*
|
|
* @param string $id
|
|
* @expectedException \Exception
|
|
*/
|
|
public function testSplitUserRemoteError($id) {
|
|
$this->sharees->splitUserRemote($id);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataTestFixRemoteUrl
|
|
*
|
|
* @param string $url
|
|
* @param string $expected
|
|
*/
|
|
public function testFixRemoteUrl($url, $expected) {
|
|
$this->assertSame($expected,
|
|
$this->invokePrivate($this->sharees, 'fixRemoteURL', [$url])
|
|
);
|
|
}
|
|
|
|
public function dataTestFixRemoteUrl() {
|
|
return [
|
|
['http://localhost', 'http://localhost'],
|
|
['http://localhost/', 'http://localhost'],
|
|
['http://localhost/index.php', 'http://localhost'],
|
|
['http://localhost/index.php/s/AShareToken', 'http://localhost'],
|
|
];
|
|
}
|
|
}
|