2125 lines
70 KiB
PHP
2125 lines
70 KiB
PHP
<?php
|
|
/**
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
*
|
|
* @author Björn Schießle <bjoern@schiessle.org>
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
|
* @author Vincent Petry <pvince81@owncloud.com>
|
|
*
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
namespace OCA\Files_Sharing\Tests\Controller;
|
|
|
|
use OCP\AppFramework\Http\DataResponse;
|
|
use OCP\AppFramework\OCS\OCSNotFoundException;
|
|
use OCP\Files\File;
|
|
use OCP\Files\Folder;
|
|
use OCP\Files\Storage;
|
|
use OCP\IL10N;
|
|
use OCA\Files_Sharing\Controller\ShareAPIController;
|
|
use OCP\Files\NotFoundException;
|
|
use OCP\IGroupManager;
|
|
use OCP\IUserManager;
|
|
use OCP\IRequest;
|
|
use OCP\IURLGenerator;
|
|
use OCP\IUser;
|
|
use OCP\Files\IRootFolder;
|
|
use OCP\Lock\LockedException;
|
|
use OCP\Share\IManager;
|
|
use OCP\Share;
|
|
use Test\TestCase;
|
|
use OCP\Share\IShare;
|
|
|
|
/**
|
|
* Class ShareAPIControllerTest
|
|
*
|
|
* @package OCA\Files_Sharing\Tests\Controller
|
|
* @group DB
|
|
*/
|
|
class ShareAPIControllerTest extends TestCase {
|
|
|
|
/** @var string */
|
|
private $appName = 'files_sharing';
|
|
|
|
/** @var \OC\Share20\Manager|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $shareManager;
|
|
|
|
/** @var IGroupManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $groupManager;
|
|
|
|
/** @var IUserManager|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $userManager;
|
|
|
|
/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $request;
|
|
|
|
/** @var IRootFolder|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $rootFolder;
|
|
|
|
/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $urlGenerator;
|
|
|
|
/** @var string|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $currentUser;
|
|
|
|
/** @var ShareAPIController */
|
|
private $ocs;
|
|
|
|
/** @var IL10N|\PHPUnit_Framework_MockObject_MockObject */
|
|
private $l;
|
|
|
|
protected function setUp() {
|
|
$this->shareManager = $this->createMock(IManager::class);
|
|
$this->shareManager
|
|
->expects($this->any())
|
|
->method('shareApiEnabled')
|
|
->willReturn(true);
|
|
$this->groupManager = $this->createMock(IGroupManager::class);
|
|
$this->userManager = $this->createMock(IUserManager::class);
|
|
$this->request = $this->createMock(IRequest::class);
|
|
$this->rootFolder = $this->createMock(IRootFolder::class);
|
|
$this->urlGenerator = $this->createMock(IURLGenerator::class);
|
|
$this->currentUser = 'currentUser';
|
|
|
|
$this->l = $this->createMock(IL10N::class);
|
|
$this->l->method('t')
|
|
->will($this->returnCallback(function($text, $parameters = []) {
|
|
return vsprintf($text, $parameters);
|
|
}));
|
|
|
|
$this->ocs = new ShareAPIController(
|
|
$this->appName,
|
|
$this->request,
|
|
$this->shareManager,
|
|
$this->groupManager,
|
|
$this->userManager,
|
|
$this->rootFolder,
|
|
$this->urlGenerator,
|
|
$this->currentUser,
|
|
$this->l
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return ShareAPIController|\PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private function mockFormatShare() {
|
|
return $this->getMockBuilder(ShareAPIController::class)
|
|
->setConstructorArgs([
|
|
$this->appName,
|
|
$this->request,
|
|
$this->shareManager,
|
|
$this->groupManager,
|
|
$this->userManager,
|
|
$this->rootFolder,
|
|
$this->urlGenerator,
|
|
$this->currentUser,
|
|
$this->l,
|
|
])->setMethods(['formatShare'])
|
|
->getMock();
|
|
}
|
|
|
|
private function newShare() {
|
|
return \OC::$server->getShareManager()->newShare();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Wrong share ID, share doesn't exist
|
|
*/
|
|
public function testDeleteShareShareNotFound() {
|
|
$this->shareManager
|
|
->expects($this->exactly(2))
|
|
->method('getShareById')
|
|
->will($this->returnCallback(function($id) {
|
|
if ($id === 'ocinternal:42' || $id === 'ocFederatedSharing:42') {
|
|
throw new \OCP\Share\Exceptions\ShareNotFound();
|
|
} else {
|
|
throw new \Exception();
|
|
}
|
|
}));
|
|
|
|
$this->shareManager->method('outgoingServer2ServerSharesAllowed')->willReturn(true);
|
|
|
|
$this->ocs->deleteShare(42);
|
|
}
|
|
|
|
public function testDeleteShare() {
|
|
$node = $this->getMockBuilder(File::class)->getMock();
|
|
|
|
$share = $this->newShare();
|
|
$share->setSharedBy($this->currentUser)
|
|
->setNode($node);
|
|
$this->shareManager
|
|
->expects($this->once())
|
|
->method('getShareById')
|
|
->with('ocinternal:42')
|
|
->willReturn($share);
|
|
$this->shareManager
|
|
->expects($this->once())
|
|
->method('deleteShare')
|
|
->with($share);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$expected = new DataResponse();
|
|
$result = $this->ocs->deleteShare(42);
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage could not delete share
|
|
*/
|
|
public function testDeleteShareLocked() {
|
|
$node = $this->getMockBuilder(File::class)->getMock();
|
|
|
|
$share = $this->newShare();
|
|
$share->setSharedBy($this->currentUser)
|
|
->setNode($node);
|
|
$this->shareManager
|
|
->expects($this->once())
|
|
->method('getShareById')
|
|
->with('ocinternal:42')
|
|
->willReturn($share);
|
|
$this->shareManager
|
|
->expects($this->never())
|
|
->method('deleteShare')
|
|
->with($share);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED)
|
|
->will($this->throwException(new LockedException('mypath')));
|
|
|
|
$this->ocs->deleteShare(42);
|
|
}
|
|
|
|
/*
|
|
* FIXME: Enable once we have a federated Share Provider
|
|
|
|
public function testGetGetShareNotExists() {
|
|
$this->shareManager
|
|
->expects($this->once())
|
|
->method('getShareById')
|
|
->with('ocinternal:42')
|
|
->will($this->throwException(new \OC\Share20\Exception\ShareNotFound()));
|
|
|
|
$expected = new \OC\OCS\Result(null, 404, 'wrong share ID, share doesn\'t exist.');
|
|
$this->assertEquals($expected, $this->ocs->getShare(42));
|
|
}
|
|
*/
|
|
|
|
public function createShare($id, $shareType, $sharedWith, $sharedBy, $shareOwner, $path, $permissions,
|
|
$shareTime, $expiration, $parent, $target, $mail_send, $token=null,
|
|
$password=null) {
|
|
$share = $this->getMockBuilder(IShare::class)->getMock();
|
|
$share->method('getId')->willReturn($id);
|
|
$share->method('getShareType')->willReturn($shareType);
|
|
$share->method('getSharedWith')->willReturn($sharedWith);
|
|
$share->method('getSharedBy')->willReturn($sharedBy);
|
|
$share->method('getShareOwner')->willReturn($shareOwner);
|
|
$share->method('getNode')->willReturn($path);
|
|
$share->method('getPermissions')->willReturn($permissions);
|
|
$time = new \DateTime();
|
|
$time->setTimestamp($shareTime);
|
|
$share->method('getShareTime')->willReturn($time);
|
|
$share->method('getExpirationDate')->willReturn($expiration);
|
|
$share->method('getTarget')->willReturn($target);
|
|
$share->method('getMailSend')->willReturn($mail_send);
|
|
$share->method('getToken')->willReturn($token);
|
|
$share->method('getPassword')->willReturn($password);
|
|
|
|
if ($shareType === \OCP\Share::SHARE_TYPE_USER ||
|
|
$shareType === \OCP\Share::SHARE_TYPE_GROUP ||
|
|
$shareType === \OCP\Share::SHARE_TYPE_LINK) {
|
|
$share->method('getFullId')->willReturn('ocinternal:'.$id);
|
|
}
|
|
|
|
return $share;
|
|
}
|
|
|
|
public function dataGetShare() {
|
|
$data = [];
|
|
|
|
$cache = $this->getMockBuilder('OC\Files\Cache\Cache')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$cache->method('getNumericStorageId')->willReturn(101);
|
|
|
|
$storage = $this->getMockBuilder(Storage::class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$storage->method('getId')->willReturn('STORAGE');
|
|
$storage->method('getCache')->willReturn($cache);
|
|
|
|
$parentFolder = $this->getMockBuilder('OCP\Files\Folder')->getMock();
|
|
$parentFolder->method('getId')->willReturn(3);
|
|
|
|
$file = $this->getMockBuilder('OCP\Files\File')->getMock();
|
|
$file->method('getId')->willReturn(1);
|
|
$file->method('getPath')->willReturn('file');
|
|
$file->method('getStorage')->willReturn($storage);
|
|
$file->method('getParent')->willReturn($parentFolder);
|
|
$file->method('getMimeType')->willReturn('myMimeType');
|
|
|
|
$folder = $this->getMockBuilder('OCP\Files\Folder')->getMock();
|
|
$folder->method('getId')->willReturn(2);
|
|
$folder->method('getPath')->willReturn('folder');
|
|
$folder->method('getStorage')->willReturn($storage);
|
|
$folder->method('getParent')->willReturn($parentFolder);
|
|
$folder->method('getMimeType')->willReturn('myFolderMimeType');
|
|
|
|
// File shared with user
|
|
$share = $this->createShare(
|
|
100,
|
|
\OCP\Share::SHARE_TYPE_USER,
|
|
'userId',
|
|
'initiatorId',
|
|
'ownerId',
|
|
$file,
|
|
4,
|
|
5,
|
|
null,
|
|
6,
|
|
'target',
|
|
0
|
|
);
|
|
$expected = [
|
|
'id' => 100,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_USER,
|
|
'share_with' => 'userId',
|
|
'share_with_displayname' => 'userDisplay',
|
|
'uid_owner' => 'initiatorId',
|
|
'displayname_owner' => 'initiatorDisplay',
|
|
'item_type' => 'file',
|
|
'item_source' => 1,
|
|
'file_source' => 1,
|
|
'file_target' => 'target',
|
|
'file_parent' => 3,
|
|
'token' => null,
|
|
'expiration' => null,
|
|
'permissions' => 4,
|
|
'stime' => 5,
|
|
'parent' => null,
|
|
'storage_id' => 'STORAGE',
|
|
'path' => 'file',
|
|
'storage' => 101,
|
|
'mail_send' => 0,
|
|
'uid_file_owner' => 'ownerId',
|
|
'displayname_file_owner' => 'ownerDisplay',
|
|
'mimetype' => 'myMimeType',
|
|
];
|
|
$data[] = [$share, $expected];
|
|
|
|
// Folder shared with group
|
|
$share = $this->createShare(
|
|
101,
|
|
\OCP\Share::SHARE_TYPE_GROUP,
|
|
'groupId',
|
|
'initiatorId',
|
|
'ownerId',
|
|
$folder,
|
|
4,
|
|
5,
|
|
null,
|
|
6,
|
|
'target',
|
|
0
|
|
);
|
|
$expected = [
|
|
'id' => 101,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_GROUP,
|
|
'share_with' => 'groupId',
|
|
'share_with_displayname' => 'groupId',
|
|
'uid_owner' => 'initiatorId',
|
|
'displayname_owner' => 'initiatorDisplay',
|
|
'item_type' => 'folder',
|
|
'item_source' => 2,
|
|
'file_source' => 2,
|
|
'file_target' => 'target',
|
|
'file_parent' => 3,
|
|
'token' => null,
|
|
'expiration' => null,
|
|
'permissions' => 4,
|
|
'stime' => 5,
|
|
'parent' => null,
|
|
'storage_id' => 'STORAGE',
|
|
'path' => 'folder',
|
|
'storage' => 101,
|
|
'mail_send' => 0,
|
|
'uid_file_owner' => 'ownerId',
|
|
'displayname_file_owner' => 'ownerDisplay',
|
|
'mimetype' => 'myFolderMimeType',
|
|
];
|
|
$data[] = [$share, $expected];
|
|
|
|
// File shared by link with Expire
|
|
$expire = \DateTime::createFromFormat('Y-m-d h:i:s', '2000-01-02 01:02:03');
|
|
$share = $this->createShare(
|
|
101,
|
|
\OCP\Share::SHARE_TYPE_LINK,
|
|
null,
|
|
'initiatorId',
|
|
'ownerId',
|
|
$folder,
|
|
4,
|
|
5,
|
|
$expire,
|
|
6,
|
|
'target',
|
|
0,
|
|
'token',
|
|
'password'
|
|
);
|
|
$expected = [
|
|
'id' => 101,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_LINK,
|
|
'share_with' => 'password',
|
|
'share_with_displayname' => 'password',
|
|
'uid_owner' => 'initiatorId',
|
|
'displayname_owner' => 'initiatorDisplay',
|
|
'item_type' => 'folder',
|
|
'item_source' => 2,
|
|
'file_source' => 2,
|
|
'file_target' => 'target',
|
|
'file_parent' => 3,
|
|
'token' => 'token',
|
|
'expiration' => '2000-01-02 00:00:00',
|
|
'permissions' => 4,
|
|
'stime' => 5,
|
|
'parent' => null,
|
|
'storage_id' => 'STORAGE',
|
|
'path' => 'folder',
|
|
'storage' => 101,
|
|
'mail_send' => 0,
|
|
'url' => 'url',
|
|
'uid_file_owner' => 'ownerId',
|
|
'displayname_file_owner' => 'ownerDisplay',
|
|
'mimetype' => 'myFolderMimeType',
|
|
];
|
|
$data[] = [$share, $expected];
|
|
|
|
return $data;
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataGetShare
|
|
*/
|
|
public function testGetShare(\OCP\Share\IShare $share, array $result) {
|
|
/** @var ShareAPIController|\PHPUnit_Framework_MockObject_MockObject $ocs */
|
|
$ocs = $this->getMockBuilder(ShareAPIController::class)
|
|
->setConstructorArgs([
|
|
$this->appName,
|
|
$this->request,
|
|
$this->shareManager,
|
|
$this->groupManager,
|
|
$this->userManager,
|
|
$this->rootFolder,
|
|
$this->urlGenerator,
|
|
$this->currentUser,
|
|
$this->l,
|
|
])->setMethods(['canAccessShare'])
|
|
->getMock();
|
|
|
|
$ocs->expects($this->any())
|
|
->method('canAccessShare')
|
|
->willReturn(true);
|
|
|
|
$this->shareManager
|
|
->expects($this->once())
|
|
->method('getShareById')
|
|
->with($share->getFullId())
|
|
->willReturn($share);
|
|
|
|
$userFolder = $this->getMockBuilder('OCP\Files\Folder')->getMock();
|
|
$userFolder
|
|
->method('getRelativePath')
|
|
->will($this->returnArgument(0));
|
|
|
|
$userFolder->method('getById')
|
|
->with($share->getNodeId())
|
|
->willReturn([$share->getNode()]);
|
|
|
|
$this->rootFolder->method('getUserFolder')
|
|
->with($this->currentUser)
|
|
->willReturn($userFolder);
|
|
|
|
$this->urlGenerator
|
|
->method('linkToRouteAbsolute')
|
|
->willReturn('url');
|
|
|
|
$initiator = $this->getMockBuilder(IUser::class)->getMock();
|
|
$initiator->method('getUID')->willReturn('initiatorId');
|
|
$initiator->method('getDisplayName')->willReturn('initiatorDisplay');
|
|
|
|
$owner = $this->getMockBuilder(IUser::class)->getMock();
|
|
$owner->method('getUID')->willReturn('ownerId');
|
|
$owner->method('getDisplayName')->willReturn('ownerDisplay');
|
|
|
|
$user = $this->getMockBuilder(IUser::class)->getMock();
|
|
$user->method('getUID')->willReturn('userId');
|
|
$user->method('getDisplayName')->willReturn('userDisplay');
|
|
|
|
$group = $this->getMockBuilder('OCP\IGroup')->getMock();
|
|
$group->method('getGID')->willReturn('groupId');
|
|
|
|
$this->userManager->method('get')->will($this->returnValueMap([
|
|
['userId', $user],
|
|
['initiatorId', $initiator],
|
|
['ownerId', $owner],
|
|
]));
|
|
$this->groupManager->method('get')->will($this->returnValueMap([
|
|
['group', $group],
|
|
]));
|
|
|
|
$this->assertEquals($result, $ocs->getShare($share->getId())->getData()[0]);
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Wrong share ID, share doesn't exist
|
|
*/
|
|
public function testGetShareInvalidNode() {
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setSharedBy('initiator')
|
|
->setSharedWith('recipient')
|
|
->setShareOwner('owner');
|
|
|
|
$this->shareManager
|
|
->expects($this->once())
|
|
->method('getShareById')
|
|
->with('ocinternal:42')
|
|
->willReturn($share);
|
|
|
|
$this->ocs->getShare(42);
|
|
}
|
|
|
|
public function testCanAccessShare() {
|
|
$share = $this->getMockBuilder(IShare::class)->getMock();
|
|
$share->method('getShareOwner')->willReturn($this->currentUser);
|
|
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
|
|
$share = $this->getMockBuilder(IShare::class)->getMock();
|
|
$share->method('getSharedBy')->willReturn($this->currentUser);
|
|
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
|
|
$share = $this->getMockBuilder(IShare::class)->getMock();
|
|
$share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_USER);
|
|
$share->method('getSharedWith')->willReturn($this->currentUser);
|
|
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
|
|
$share = $this->getMockBuilder(IShare::class)->getMock();
|
|
$share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_USER);
|
|
$share->method('getSharedWith')->willReturn($this->getMockBuilder(IUser::class)->getMock());
|
|
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
|
|
$share = $this->getMockBuilder(IShare::class)->getMock();
|
|
$share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_GROUP);
|
|
$share->method('getSharedWith')->willReturn('group');
|
|
|
|
$user = $this->createMock(IUser::class);
|
|
$this->userManager->method('get')
|
|
->with($this->currentUser)
|
|
->willReturn($user);
|
|
|
|
$group = $this->getMockBuilder('OCP\IGroup')->getMock();
|
|
$group->method('inGroup')->with($user)->willReturn(true);
|
|
$group2 = $this->getMockBuilder('OCP\IGroup')->getMock();
|
|
$group2->method('inGroup')->with($user)->willReturn(false);
|
|
|
|
$this->groupManager->method('get')->will($this->returnValueMap([
|
|
['group', $group],
|
|
['group2', $group2],
|
|
['groupnull', null],
|
|
]));
|
|
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
|
|
$share = $this->createMock(IShare::class);
|
|
$share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_GROUP);
|
|
$share->method('getSharedWith')->willReturn('group2');
|
|
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
|
|
// null group
|
|
$share = $this->createMock(IShare::class);
|
|
$share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_GROUP);
|
|
$share->method('getSharedWith')->willReturn('groupnull');
|
|
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
|
|
$share = $this->createMock(IShare::class);
|
|
$share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_LINK);
|
|
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Please specify a file or folder path
|
|
*/
|
|
public function testCreateShareNoPath() {
|
|
$this->ocs->createShare();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Wrong path, file/folder doesn't exist
|
|
*/
|
|
public function testCreateShareInvalidPath() {
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('invalid-path')
|
|
->will($this->throwException(new \OCP\Files\NotFoundException()));
|
|
|
|
$this->ocs->createShare('invalid-path');
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage invalid permissions
|
|
*/
|
|
public function testCreateShareInvalidPermissions() {
|
|
$share = $this->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(File::class)->getMock();
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
|
|
$path->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->ocs->createShare('valid-path', 32);
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Please specify a valid user
|
|
*/
|
|
public function testCreateShareUserNoShareWith() {
|
|
$share = $this->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(File::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
|
|
$path->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_USER);
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Please specify a valid user
|
|
*/
|
|
public function testCreateShareUserNoValidShareWith() {
|
|
$share = $this->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(File::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
$path->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
$this->userManager->method('userExists')
|
|
->with('invalidUser')
|
|
->willReturn(false);
|
|
|
|
$this->ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_USER, 'invalidUser');
|
|
}
|
|
|
|
public function testCreateShareUser() {
|
|
$share = $this->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
|
|
/** @var \OCA\Files_Sharing\Controller\ShareAPIController $ocs */
|
|
$ocs = $this->getMockBuilder(ShareAPIController::class)
|
|
->setConstructorArgs([
|
|
$this->appName,
|
|
$this->request,
|
|
$this->shareManager,
|
|
$this->groupManager,
|
|
$this->userManager,
|
|
$this->rootFolder,
|
|
$this->urlGenerator,
|
|
$this->currentUser,
|
|
$this->l,
|
|
])->setMethods(['formatShare'])
|
|
->getMock();
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(File::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
|
|
$this->userManager->method('userExists')->with('validUser')->willReturn(true);
|
|
|
|
$path->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('createShare')
|
|
->with($this->callback(function (\OCP\Share\IShare $share) use ($path) {
|
|
return $share->getNode() === $path &&
|
|
$share->getPermissions() === (
|
|
\OCP\Constants::PERMISSION_ALL &
|
|
~\OCP\Constants::PERMISSION_DELETE &
|
|
~\OCP\Constants::PERMISSION_CREATE
|
|
) &&
|
|
$share->getShareType() === \OCP\Share::SHARE_TYPE_USER &&
|
|
$share->getSharedWith() === 'validUser' &&
|
|
$share->getSharedBy() === 'currentUser';
|
|
}))
|
|
->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_USER, 'validUser');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Please specify a valid group
|
|
*/
|
|
public function testCreateShareGroupNoValidShareWith() {
|
|
$share = $this->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
$this->shareManager->method('createShare')->will($this->returnArgument(0));
|
|
$this->shareManager->method('allowGroupSharing')->willReturn(true);
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(File::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
|
|
$path->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_GROUP, 'invalidGroup');
|
|
}
|
|
|
|
public function testCreateShareGroup() {
|
|
$share = $this->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
|
|
/** @var ShareAPIController|\PHPUnit_Framework_MockObject_MockObject $ocs */
|
|
$ocs = $this->getMockBuilder(ShareAPIController::class)
|
|
->setConstructorArgs([
|
|
$this->appName,
|
|
$this->request,
|
|
$this->shareManager,
|
|
$this->groupManager,
|
|
$this->userManager,
|
|
$this->rootFolder,
|
|
$this->urlGenerator,
|
|
$this->currentUser,
|
|
$this->l,
|
|
])->setMethods(['formatShare'])
|
|
->getMock();
|
|
|
|
$this->request
|
|
->method('getParam')
|
|
->will($this->returnValueMap([
|
|
['path', null, 'valid-path'],
|
|
['permissions', null, \OCP\Constants::PERMISSION_ALL],
|
|
['shareType', '-1', \OCP\Share::SHARE_TYPE_GROUP],
|
|
['shareWith', null, 'validGroup'],
|
|
]));
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
|
|
$this->groupManager->method('groupExists')->with('validGroup')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())
|
|
->method('allowGroupSharing')
|
|
->willReturn(true);
|
|
|
|
$path->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('createShare')
|
|
->with($this->callback(function (\OCP\Share\IShare $share) use ($path) {
|
|
return $share->getNode() === $path &&
|
|
$share->getPermissions() === \OCP\Constants::PERMISSION_ALL &&
|
|
$share->getShareType() === \OCP\Share::SHARE_TYPE_GROUP &&
|
|
$share->getSharedWith() === 'validGroup' &&
|
|
$share->getSharedBy() === 'currentUser';
|
|
}))
|
|
->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_GROUP, 'validGroup');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Group sharing is disabled by the administrator
|
|
*/
|
|
public function testCreateShareGroupNotAllowed() {
|
|
$share = $this->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
|
|
$this->groupManager->method('groupExists')->with('validGroup')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())
|
|
->method('allowGroupSharing')
|
|
->willReturn(false);
|
|
|
|
$this->ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_GROUP, 'invalidGroup');
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Public link sharing is disabled by the administrator
|
|
*/
|
|
public function testCreateShareLinkNoLinksAllowed() {
|
|
$this->request
|
|
->method('getParam')
|
|
->will($this->returnValueMap([
|
|
['path', null, 'valid-path'],
|
|
['shareType', '-1', \OCP\Share::SHARE_TYPE_LINK],
|
|
]));
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$this->rootFolder->method('getUserFolder')->with($this->currentUser)->will($this->returnSelf());
|
|
$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
|
|
|
|
$this->shareManager->method('newShare')->willReturn(\OC::$server->getShareManager()->newShare());
|
|
|
|
$this->ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_LINK);
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSForbiddenException
|
|
* @expectedExceptionMessage Public upload disabled by the administrator
|
|
*/
|
|
public function testCreateShareLinkNoPublicUpload() {
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$this->rootFolder->method('getUserFolder')->with($this->currentUser)->will($this->returnSelf());
|
|
$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
|
|
|
|
$this->shareManager->method('newShare')->willReturn(\OC::$server->getShareManager()->newShare());
|
|
$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
|
|
|
|
$this->ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_LINK, null, 'true');
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Public upload is only possible for publicly shared folders
|
|
*/
|
|
public function testCreateShareLinkPublicUploadFile() {
|
|
$path = $this->getMockBuilder(File::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$this->rootFolder->method('getUserFolder')->with($this->currentUser)->will($this->returnSelf());
|
|
$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
|
|
|
|
$this->shareManager->method('newShare')->willReturn(\OC::$server->getShareManager()->newShare());
|
|
$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_LINK, null, 'true');
|
|
}
|
|
|
|
public function testCreateShareLinkPublicUploadFolder() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$this->rootFolder->method('getUserFolder')->with($this->currentUser)->will($this->returnSelf());
|
|
$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
|
|
|
|
$this->shareManager->method('newShare')->willReturn(\OC::$server->getShareManager()->newShare());
|
|
$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('createShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) use ($path) {
|
|
return $share->getNode() === $path &&
|
|
$share->getShareType() === \OCP\Share::SHARE_TYPE_LINK &&
|
|
$share->getPermissions() === (\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE) &&
|
|
$share->getSharedBy() === 'currentUser' &&
|
|
$share->getPassword() === null &&
|
|
$share->getExpirationDate() === null;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_LINK, null, 'true', '', '');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testCreateShareLinkPassword() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$this->rootFolder->method('getUserFolder')->with($this->currentUser)->will($this->returnSelf());
|
|
$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
|
|
|
|
$this->shareManager->method('newShare')->willReturn(\OC::$server->getShareManager()->newShare());
|
|
$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('createShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) use ($path) {
|
|
return $share->getNode() === $path &&
|
|
$share->getShareType() === \OCP\Share::SHARE_TYPE_LINK &&
|
|
$share->getPermissions() === \OCP\Constants::PERMISSION_READ &&
|
|
$share->getSharedBy() === 'currentUser' &&
|
|
$share->getPassword() === 'password' &&
|
|
$share->getExpirationDate() === null;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_LINK, null, 'false', 'password', '');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testCreateShareValidExpireDate() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$this->request
|
|
->method('getParam')
|
|
->will($this->returnValueMap([
|
|
['path', null, 'valid-path'],
|
|
['shareType', '-1', \OCP\Share::SHARE_TYPE_LINK],
|
|
['publicUpload', null, 'false'],
|
|
['expireDate', '', '2000-01-01'],
|
|
['password', '', ''],
|
|
]));
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$this->rootFolder->method('getUserFolder')->with($this->currentUser)->will($this->returnSelf());
|
|
$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
|
|
|
|
$this->shareManager->method('newShare')->willReturn(\OC::$server->getShareManager()->newShare());
|
|
$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('createShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) use ($path) {
|
|
$date = new \DateTime('2000-01-01');
|
|
$date->setTime(0,0,0);
|
|
|
|
return $share->getNode() === $path &&
|
|
$share->getShareType() === \OCP\Share::SHARE_TYPE_LINK &&
|
|
$share->getPermissions() === \OCP\Constants::PERMISSION_READ &&
|
|
$share->getSharedBy() === 'currentUser' &&
|
|
$share->getPassword() === null &&
|
|
$share->getExpirationDate() == $date;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_LINK, null, 'false', '', '2000-01-01');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Invalid date, date format must be YYYY-MM-DD
|
|
*/
|
|
public function testCreateShareInvalidExpireDate() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(false);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$this->rootFolder->method('getUserFolder')->with($this->currentUser)->will($this->returnSelf());
|
|
$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
|
|
|
|
$this->shareManager->method('newShare')->willReturn(\OC::$server->getShareManager()->newShare());
|
|
$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_LINK, null, 'false', '', 'a1b2d3');
|
|
}
|
|
|
|
/**
|
|
* Test for https://github.com/owncloud/core/issues/22587
|
|
* TODO: Remove once proper solution is in place
|
|
*/
|
|
public function testCreateReshareOfFederatedMountNoDeletePermissions() {
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$this->shareManager->method('newShare')->willReturn($share);
|
|
|
|
/** @var ShareAPIController|\PHPUnit_Framework_MockObject_MockObject $ocs */
|
|
$ocs = $this->getMockBuilder(ShareAPIController::class)
|
|
->setConstructorArgs([
|
|
$this->appName,
|
|
$this->request,
|
|
$this->shareManager,
|
|
$this->groupManager,
|
|
$this->userManager,
|
|
$this->rootFolder,
|
|
$this->urlGenerator,
|
|
$this->currentUser,
|
|
$this->l,
|
|
])->setMethods(['formatShare'])
|
|
->getMock();
|
|
|
|
$userFolder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$this->rootFolder->expects($this->once())
|
|
->method('getUserFolder')
|
|
->with('currentUser')
|
|
->willReturn($userFolder);
|
|
|
|
$path = $this->getMockBuilder(Folder::class)->getMock();
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('instanceOfStorage')
|
|
->with('OCA\Files_Sharing\External\Storage')
|
|
->willReturn(true);
|
|
$path->method('getStorage')->willReturn($storage);
|
|
$path->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
|
|
$userFolder->expects($this->once())
|
|
->method('get')
|
|
->with('valid-path')
|
|
->willReturn($path);
|
|
|
|
$this->userManager->method('userExists')->with('validUser')->willReturn(true);
|
|
|
|
$this->shareManager
|
|
->expects($this->once())
|
|
->method('createShare')
|
|
->with($this->callback(function (\OCP\Share\IShare $share) {
|
|
return $share->getPermissions() === \OCP\Constants::PERMISSION_READ;
|
|
}))
|
|
->will($this->returnArgument(0));
|
|
|
|
$ocs->createShare('valid-path', \OCP\Constants::PERMISSION_ALL, \OCP\Share::SHARE_TYPE_USER, 'validUser');
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSNotFoundException
|
|
* @expectedExceptionMessage Wrong share ID, share doesn't exist
|
|
*/
|
|
public function testUpdateShareCantAccess() {
|
|
$node = $this->getMockBuilder(Folder::class)->getMock();
|
|
$share = $this->newShare();
|
|
$share->setNode($node);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->ocs->updateShare(42);
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSBadRequestException
|
|
* @expectedExceptionMessage Wrong or no update parameter given
|
|
*/
|
|
public function testUpdateNoParametersLink() {
|
|
$node = $this->getMockBuilder(Folder::class)->getMock();
|
|
$share = $this->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setNode($node);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->ocs->updateShare(42);
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSBadRequestException
|
|
* @expectedExceptionMessage Wrong or no update parameter given
|
|
*/
|
|
public function testUpdateNoParametersOther() {
|
|
$node = $this->getMockBuilder(Folder::class)->getMock();
|
|
$share = $this->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
|
|
->setNode($node);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->ocs->updateShare(42);
|
|
}
|
|
|
|
public function testUpdateLinkShareClear() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$node = $this->getMockBuilder(Folder::class)->getMock();
|
|
$share = $this->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPassword('password')
|
|
->setExpirationDate(new \DateTime())
|
|
->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setNode($node);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) {
|
|
return $share->getPermissions() === \OCP\Constants::PERMISSION_READ &&
|
|
$share->getPassword() === null &&
|
|
$share->getExpirationDate() === null;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$this->shareManager->method('getSharedWith')
|
|
->willReturn([]);
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, null, '', 'false', '');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testUpdateLinkShareSet() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) {
|
|
$date = new \DateTime('2000-01-01');
|
|
$date->setTime(0,0,0);
|
|
|
|
return $share->getPermissions() === (\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE) &&
|
|
$share->getPassword() === 'password' &&
|
|
$share->getExpirationDate() == $date;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$this->shareManager->method('getSharedWith')
|
|
->willReturn([]);
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, null, 'password', 'true', '2000-01-01');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
/**
|
|
* @dataProvider publicUploadParamsProvider
|
|
*/
|
|
public function testUpdateLinkShareEnablePublicUpload($permissions, $publicUpload, $expireDate, $password) {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPassword('password')
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
$this->shareManager->method('getSharedWith')->willReturn([]);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) {
|
|
return $share->getPermissions() === (\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE) &&
|
|
$share->getPassword() === 'password' &&
|
|
$share->getExpirationDate() === null;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, $permissions, $password, $publicUpload, $expireDate);
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSBadRequestException
|
|
* @expectedExceptionMessage Invalid date. Format must be YYYY-MM-DD
|
|
*/
|
|
public function testUpdateLinkShareInvalidDate() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$ocs->updateShare(42, null, 'password', 'true', '2000-01-a');
|
|
}
|
|
|
|
public function publicUploadParamsProvider() {
|
|
return [
|
|
[null, 'true', null, 'password'],
|
|
// legacy had no delete
|
|
[
|
|
\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE,
|
|
null, null, 'password'
|
|
],
|
|
// correct
|
|
[
|
|
\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE,
|
|
null, null, 'password'
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider publicUploadParamsProvider
|
|
* @expectedException \OCP\AppFramework\OCS\OCSForbiddenException
|
|
* @expectedExceptionMessage Public upload disabled by the administrator
|
|
*/
|
|
public function testUpdateLinkSharePublicUploadNotAllowed($permissions, $publicUpload, $expireDate, $password) {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(false);
|
|
|
|
$ocs->updateShare(42, $permissions, $password, $publicUpload, $expireDate);
|
|
}
|
|
|
|
/**
|
|
* @expectedException \OCP\AppFramework\OCS\OCSBadRequestException
|
|
* @expectedExceptionMessage Public upload is only possible for publicly shared folders
|
|
*/
|
|
public function testUpdateLinkSharePublicUploadOnFile() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$file = $this->getMockBuilder(File::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setNode($file);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$ocs->updateShare(42, null, 'password', 'true', '');
|
|
}
|
|
|
|
public function testUpdateLinkSharePasswordDoesNotChangeOther() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$date = new \DateTime('2000-01-01');
|
|
$date->setTime(0,0,0);
|
|
|
|
$node = $this->getMockBuilder(File::class)->getMock();
|
|
$share = $this->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPassword('password')
|
|
->setExpirationDate($date)
|
|
->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setNode($node);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) use ($date) {
|
|
return $share->getPermissions() === \OCP\Constants::PERMISSION_ALL &&
|
|
$share->getPassword() === 'newpassword' &&
|
|
$share->getExpirationDate() === $date;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, null, 'newpassword', null, null);
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testUpdateLinkShareExpireDateDoesNotChangeOther() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$node = $this->getMockBuilder(File::class)->getMock();
|
|
$share = $this->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPassword('password')
|
|
->setExpirationDate(new \DateTime())
|
|
->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setNode($node);
|
|
|
|
$node->expects($this->once())
|
|
->method('lock')
|
|
->with(\OCP\Lock\ILockingProvider::LOCK_SHARED);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) {
|
|
$date = new \DateTime('2010-12-23');
|
|
$date->setTime(0,0,0);
|
|
|
|
return $share->getPermissions() === \OCP\Constants::PERMISSION_ALL &&
|
|
$share->getPassword() === 'password' &&
|
|
$share->getExpirationDate() == $date;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, null, null, null, '2010-12-23');
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testUpdateLinkSharePublicUploadDoesNotChangeOther() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$date = new \DateTime('2000-01-01');
|
|
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPassword('password')
|
|
->setExpirationDate($date)
|
|
->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) use ($date) {
|
|
return $share->getPermissions() === (\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE) &&
|
|
$share->getPassword() === 'password' &&
|
|
$share->getExpirationDate() === $date;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$this->shareManager->method('getSharedWith')
|
|
->willReturn([]);
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, null, null, 'true', null);
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testUpdateLinkSharePermissions() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$date = new \DateTime('2000-01-01');
|
|
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPassword('password')
|
|
->setExpirationDate($date)
|
|
->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) use ($date) {
|
|
return $share->getPermissions() === (\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE) &&
|
|
$share->getPassword() === 'password' &&
|
|
$share->getExpirationDate() === $date;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$this->shareManager->method('getSharedWith')->willReturn([]);
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, 7, null, null, null);
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testUpdateLinkSharePermissionsShare() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$date = new \DateTime('2000-01-01');
|
|
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPassword('password')
|
|
->setExpirationDate($date)
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) use ($date) {
|
|
return $share->getPermissions() === (\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE) &&
|
|
$share->getPassword() === 'password' &&
|
|
$share->getExpirationDate() === $date;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$this->shareManager->method('getSharedWith')->willReturn([]);
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, 31, null, null, null);
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testUpdateOtherPermissions() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$file = $this->getMockBuilder(File::class)->getMock();
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setPermissions(\OCP\Constants::PERMISSION_ALL)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_USER)
|
|
->setNode($file);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
$this->shareManager->expects($this->once())->method('updateShare')->with(
|
|
$this->callback(function (\OCP\Share\IShare $share) {
|
|
return $share->getPermissions() === \OCP\Constants::PERMISSION_ALL;
|
|
})
|
|
)->will($this->returnArgument(0));
|
|
|
|
$this->shareManager->method('getSharedWith')->willReturn([]);
|
|
|
|
$expected = new DataResponse(null);
|
|
$result = $ocs->updateShare(42, 31, null, null, null);
|
|
|
|
$this->assertInstanceOf(get_class($expected), $result);
|
|
$this->assertEquals($expected->getData(), $result->getData());
|
|
}
|
|
|
|
public function testUpdateShareCannotIncreasePermissions() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$folder = $this->createMock(Folder::class);
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share
|
|
->setId(42)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareOwner('anotheruser')
|
|
->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
|
|
->setSharedWith('group1')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder);
|
|
|
|
// note: updateShare will modify the received instance but getSharedWith will reread from the database,
|
|
// so their values will be different
|
|
$incomingShare = \OC::$server->getShareManager()->newShare();
|
|
$incomingShare
|
|
->setId(42)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareOwner('anotheruser')
|
|
->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
|
|
->setSharedWith('group1')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder);
|
|
|
|
$this->request
|
|
->method('getParam')
|
|
->will($this->returnValueMap([
|
|
['permissions', null, '31'],
|
|
]));
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->shareManager->expects($this->any())
|
|
->method('getSharedWith')
|
|
->will($this->returnValueMap([
|
|
['currentUser', \OCP\Share::SHARE_TYPE_USER, $share->getNode(), -1, 0, []],
|
|
['currentUser', \OCP\Share::SHARE_TYPE_GROUP, $share->getNode(), -1, 0, [$incomingShare]]
|
|
]));
|
|
|
|
$this->shareManager->expects($this->never())->method('updateShare');
|
|
|
|
try {
|
|
$ocs->updateShare(42, 31);
|
|
$this->fail();
|
|
} catch (OCSNotFoundException $e) {
|
|
$this->assertEquals('Cannot increase permissions', $e->getMessage());
|
|
}
|
|
}
|
|
|
|
public function testUpdateShareCannotIncreasePermissionsLinkShare() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$folder = $this->createMock(Folder::class);
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share
|
|
->setId(42)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareOwner('anotheruser')
|
|
->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder);
|
|
|
|
// note: updateShare will modify the received instance but getSharedWith will reread from the database,
|
|
// so their values will be different
|
|
$incomingShare = \OC::$server->getShareManager()->newShare();
|
|
$incomingShare
|
|
->setId(42)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareOwner('anotheruser')
|
|
->setShareType(\OCP\Share::SHARE_TYPE_USER)
|
|
->setSharedWith('currentUser')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->shareManager->expects($this->any())
|
|
->method('getSharedWith')
|
|
->will($this->returnValueMap([
|
|
['currentUser', \OCP\Share::SHARE_TYPE_USER, $share->getNode(), -1, 0, [$incomingShare]],
|
|
['currentUser', \OCP\Share::SHARE_TYPE_GROUP, $share->getNode(), -1, 0, []]
|
|
]));
|
|
|
|
$this->shareManager->expects($this->never())->method('updateShare');
|
|
$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
|
|
|
|
try {
|
|
$ocs->updateShare(42, null, null, 'true');
|
|
$this->fail();
|
|
} catch (OCSNotFoundException $e) {
|
|
$this->assertEquals('Cannot increase permissions', $e->getMessage());
|
|
}
|
|
}
|
|
|
|
public function testUpdateShareCanIncreasePermissionsIfOwner() {
|
|
$ocs = $this->mockFormatShare();
|
|
|
|
$folder = $this->createMock(Folder::class);
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share
|
|
->setId(42)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareOwner($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
|
|
->setSharedWith('group1')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder);
|
|
|
|
// note: updateShare will modify the received instance but getSharedWith will reread from the database,
|
|
// so their values will be different
|
|
$incomingShare = \OC::$server->getShareManager()->newShare();
|
|
$incomingShare
|
|
->setId(42)
|
|
->setSharedBy($this->currentUser)
|
|
->setShareOwner($this->currentUser)
|
|
->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
|
|
->setSharedWith('group1')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder);
|
|
|
|
$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
|
|
|
|
$this->shareManager->expects($this->any())
|
|
->method('getSharedWith')
|
|
->will($this->returnValueMap([
|
|
['currentUser', \OCP\Share::SHARE_TYPE_USER, $share->getNode(), -1, 0, []],
|
|
['currentUser', \OCP\Share::SHARE_TYPE_GROUP, $share->getNode(), -1, 0, [$incomingShare]]
|
|
]));
|
|
|
|
$this->shareManager->expects($this->once())
|
|
->method('updateShare')
|
|
->with($share)
|
|
->willReturn($share);
|
|
|
|
$result = $ocs->updateShare(42, 31);
|
|
$this->assertInstanceOf(DataResponse::class, $result);
|
|
}
|
|
|
|
public function dataFormatShare() {
|
|
$file = $this->getMockBuilder(File::class)->getMock();
|
|
$folder = $this->getMockBuilder(Folder::class)->getMock();
|
|
$parent = $this->getMockBuilder(Folder::class)->getMock();
|
|
|
|
$file->method('getMimeType')->willReturn('myMimeType');
|
|
$folder->method('getMimeType')->willReturn('myFolderMimeType');
|
|
|
|
$file->method('getPath')->willReturn('file');
|
|
$folder->method('getPath')->willReturn('folder');
|
|
|
|
$parent->method('getId')->willReturn(1);
|
|
$folder->method('getId')->willReturn(2);
|
|
$file->method('getId')->willReturn(3);
|
|
|
|
$file->method('getParent')->willReturn($parent);
|
|
$folder->method('getParent')->willReturn($parent);
|
|
|
|
$cache = $this->getMockBuilder('OCP\Files\Cache\ICache')->getMock();
|
|
$cache->method('getNumericStorageId')->willReturn(100);
|
|
$storage = $this->getMockBuilder(Storage::class)->getMock();
|
|
$storage->method('getId')->willReturn('storageId');
|
|
$storage->method('getCache')->willReturn($cache);
|
|
|
|
$file->method('getStorage')->willReturn($storage);
|
|
$folder->method('getStorage')->willReturn($storage);
|
|
|
|
$owner = $this->getMockBuilder(IUser::class)->getMock();
|
|
$owner->method('getDisplayName')->willReturn('ownerDN');
|
|
$initiator = $this->getMockBuilder(IUser::class)->getMock();
|
|
$initiator->method('getDisplayName')->willReturn('initiatorDN');
|
|
$recipient = $this->getMockBuilder(IUser::class)->getMock();
|
|
$recipient->method('getDisplayName')->willReturn('recipientDN');
|
|
|
|
$result = [];
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setShareType(\OCP\Share::SHARE_TYPE_USER)
|
|
->setSharedWith('recipient')
|
|
->setSharedBy('initiator')
|
|
->setShareOwner('owner')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($file)
|
|
->setShareTime(new \DateTime('2000-01-01T00:01:02'))
|
|
->setTarget('myTarget')
|
|
->setId(42);
|
|
|
|
/* User backend down */
|
|
$result[] = [
|
|
[
|
|
'id' => 42,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_USER,
|
|
'uid_owner' => 'initiator',
|
|
'displayname_owner' => 'initiator',
|
|
'permissions' => 1,
|
|
'stime' => 946684862,
|
|
'parent' => null,
|
|
'expiration' => null,
|
|
'token' => null,
|
|
'uid_file_owner' => 'owner',
|
|
'displayname_file_owner' => 'owner',
|
|
'path' => 'file',
|
|
'item_type' => 'file',
|
|
'storage_id' => 'storageId',
|
|
'storage' => 100,
|
|
'item_source' => 3,
|
|
'file_source' => 3,
|
|
'file_parent' => 1,
|
|
'file_target' => 'myTarget',
|
|
'share_with' => 'recipient',
|
|
'share_with_displayname' => 'recipient',
|
|
'mail_send' => 0,
|
|
'mimetype' => 'myMimeType',
|
|
], $share, [], false
|
|
];
|
|
|
|
/* User backend up */
|
|
$result[] = [
|
|
[
|
|
'id' => 42,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_USER,
|
|
'uid_owner' => 'initiator',
|
|
'displayname_owner' => 'initiatorDN',
|
|
'permissions' => 1,
|
|
'stime' => 946684862,
|
|
'parent' => null,
|
|
'expiration' => null,
|
|
'token' => null,
|
|
'uid_file_owner' => 'owner',
|
|
'displayname_file_owner' => 'ownerDN',
|
|
'path' => 'file',
|
|
'item_type' => 'file',
|
|
'storage_id' => 'storageId',
|
|
'storage' => 100,
|
|
'item_source' => 3,
|
|
'file_source' => 3,
|
|
'file_parent' => 1,
|
|
'file_target' => 'myTarget',
|
|
'share_with' => 'recipient',
|
|
'share_with_displayname' => 'recipientDN',
|
|
'mail_send' => 0,
|
|
'mimetype' => 'myMimeType',
|
|
], $share, [
|
|
['owner', $owner],
|
|
['initiator', $initiator],
|
|
['recipient', $recipient],
|
|
], false
|
|
];
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setShareType(\OCP\Share::SHARE_TYPE_USER)
|
|
->setSharedWith('recipient')
|
|
->setSharedBy('initiator')
|
|
->setShareOwner('owner')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($file)
|
|
->setShareTime(new \DateTime('2000-01-01T00:01:02'))
|
|
->setTarget('myTarget')
|
|
->setId(42);
|
|
|
|
/* User backend down */
|
|
$result[] = [
|
|
[
|
|
'id' => 42,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_USER,
|
|
'uid_owner' => 'initiator',
|
|
'displayname_owner' => 'initiator',
|
|
'permissions' => 1,
|
|
'stime' => 946684862,
|
|
'parent' => null,
|
|
'expiration' => null,
|
|
'token' => null,
|
|
'uid_file_owner' => 'owner',
|
|
'displayname_file_owner' => 'owner',
|
|
'path' => 'file',
|
|
'item_type' => 'file',
|
|
'storage_id' => 'storageId',
|
|
'storage' => 100,
|
|
'item_source' => 3,
|
|
'file_source' => 3,
|
|
'file_parent' => 1,
|
|
'file_target' => 'myTarget',
|
|
'share_with' => 'recipient',
|
|
'share_with_displayname' => 'recipient',
|
|
'mail_send' => 0,
|
|
'mimetype' => 'myMimeType',
|
|
], $share, [], false
|
|
];
|
|
|
|
// with existing group
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
|
|
->setSharedWith('recipientGroup')
|
|
->setSharedBy('initiator')
|
|
->setShareOwner('owner')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($file)
|
|
->setShareTime(new \DateTime('2000-01-01T00:01:02'))
|
|
->setTarget('myTarget')
|
|
->setId(42);
|
|
|
|
$result[] = [
|
|
[
|
|
'id' => 42,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_GROUP,
|
|
'uid_owner' => 'initiator',
|
|
'displayname_owner' => 'initiator',
|
|
'permissions' => 1,
|
|
'stime' => 946684862,
|
|
'parent' => null,
|
|
'expiration' => null,
|
|
'token' => null,
|
|
'uid_file_owner' => 'owner',
|
|
'displayname_file_owner' => 'owner',
|
|
'path' => 'file',
|
|
'item_type' => 'file',
|
|
'storage_id' => 'storageId',
|
|
'storage' => 100,
|
|
'item_source' => 3,
|
|
'file_source' => 3,
|
|
'file_parent' => 1,
|
|
'file_target' => 'myTarget',
|
|
'share_with' => 'recipientGroup',
|
|
'share_with_displayname' => 'recipientGroupDisplayName',
|
|
'mail_send' => 0,
|
|
'mimetype' => 'myMimeType',
|
|
], $share, [], false
|
|
];
|
|
|
|
// with unknown group / no group backend
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setShareType(Share::SHARE_TYPE_GROUP)
|
|
->setSharedWith('recipientGroup2')
|
|
->setSharedBy('initiator')
|
|
->setShareOwner('owner')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($file)
|
|
->setShareTime(new \DateTime('2000-01-01T00:01:02'))
|
|
->setTarget('myTarget')
|
|
->setId(42);
|
|
$result[] = [
|
|
[
|
|
'id' => 42,
|
|
'share_type' => Share::SHARE_TYPE_GROUP,
|
|
'uid_owner' => 'initiator',
|
|
'displayname_owner' => 'initiator',
|
|
'permissions' => 1,
|
|
'stime' => 946684862,
|
|
'parent' => null,
|
|
'expiration' => null,
|
|
'token' => null,
|
|
'uid_file_owner' => 'owner',
|
|
'displayname_file_owner' => 'owner',
|
|
'path' => 'file',
|
|
'item_type' => 'file',
|
|
'storage_id' => 'storageId',
|
|
'storage' => 100,
|
|
'item_source' => 3,
|
|
'file_source' => 3,
|
|
'file_parent' => 1,
|
|
'file_target' => 'myTarget',
|
|
'share_with' => 'recipientGroup2',
|
|
'share_with_displayname' => 'recipientGroup2',
|
|
'mail_send' => 0,
|
|
'mimetype' => 'myMimeType',
|
|
], $share, [], false
|
|
];
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setShareType(\OCP\Share::SHARE_TYPE_LINK)
|
|
->setSharedBy('initiator')
|
|
->setShareOwner('owner')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($file)
|
|
->setShareTime(new \DateTime('2000-01-01T00:01:02'))
|
|
->setTarget('myTarget')
|
|
->setPassword('mypassword')
|
|
->setExpirationDate(new \DateTime('2001-01-02T00:00:00'))
|
|
->setToken('myToken')
|
|
->setId(42);
|
|
|
|
$result[] = [
|
|
[
|
|
'id' => 42,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_LINK,
|
|
'uid_owner' => 'initiator',
|
|
'displayname_owner' => 'initiator',
|
|
'permissions' => 1,
|
|
'stime' => 946684862,
|
|
'parent' => null,
|
|
'expiration' => '2001-01-02 00:00:00',
|
|
'token' => 'myToken',
|
|
'uid_file_owner' => 'owner',
|
|
'displayname_file_owner' => 'owner',
|
|
'path' => 'file',
|
|
'item_type' => 'file',
|
|
'storage_id' => 'storageId',
|
|
'storage' => 100,
|
|
'item_source' => 3,
|
|
'file_source' => 3,
|
|
'file_parent' => 1,
|
|
'file_target' => 'myTarget',
|
|
'share_with' => 'mypassword',
|
|
'share_with_displayname' => 'mypassword',
|
|
'mail_send' => 0,
|
|
'url' => 'myLink',
|
|
'mimetype' => 'myMimeType',
|
|
], $share, [], false
|
|
];
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setShareType(\OCP\Share::SHARE_TYPE_REMOTE)
|
|
->setSharedBy('initiator')
|
|
->setSharedWith('user@server.com')
|
|
->setShareOwner('owner')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setNode($folder)
|
|
->setShareTime(new \DateTime('2000-01-01T00:01:02'))
|
|
->setTarget('myTarget')
|
|
->setId(42);
|
|
|
|
$result[] = [
|
|
[
|
|
'id' => 42,
|
|
'share_type' => \OCP\Share::SHARE_TYPE_REMOTE,
|
|
'uid_owner' => 'initiator',
|
|
'displayname_owner' => 'initiator',
|
|
'permissions' => 1,
|
|
'stime' => 946684862,
|
|
'parent' => null,
|
|
'expiration' => null,
|
|
'token' => null,
|
|
'uid_file_owner' => 'owner',
|
|
'displayname_file_owner' => 'owner',
|
|
'path' => 'folder',
|
|
'item_type' => 'folder',
|
|
'storage_id' => 'storageId',
|
|
'storage' => 100,
|
|
'item_source' => 2,
|
|
'file_source' => 2,
|
|
'file_parent' => 1,
|
|
'file_target' => 'myTarget',
|
|
'share_with' => 'user@server.com',
|
|
'share_with_displayname' => 'user@server.com',
|
|
'mail_send' => 0,
|
|
'mimetype' => 'myFolderMimeType',
|
|
], $share, [], false
|
|
];
|
|
|
|
$share = \OC::$server->getShareManager()->newShare();
|
|
$share->setShareType(\OCP\Share::SHARE_TYPE_USER)
|
|
->setSharedBy('initiator')
|
|
->setSharedWith('recipient')
|
|
->setShareOwner('owner')
|
|
->setPermissions(\OCP\Constants::PERMISSION_READ)
|
|
->setShareTime(new \DateTime('2000-01-01T00:01:02'))
|
|
->setTarget('myTarget')
|
|
->setId(42);
|
|
|
|
$result[] = [
|
|
[], $share, [], true
|
|
];
|
|
|
|
return $result;
|
|
}
|
|
|
|
/**
|
|
* @dataProvider dataFormatShare
|
|
*
|
|
* @param array $expects
|
|
* @param \OCP\Share\IShare $share
|
|
* @param array $users
|
|
* @param $exception
|
|
*/
|
|
public function testFormatShare(array $expects, \OCP\Share\IShare $share, array $users, $exception) {
|
|
$this->userManager->method('get')->will($this->returnValueMap($users));
|
|
|
|
$recipientGroup = $this->createMock('\OCP\IGroup');
|
|
$recipientGroup->method('getDisplayName')->willReturn('recipientGroupDisplayName');
|
|
$this->groupManager->method('get')->will($this->returnValueMap([
|
|
['recipientGroup', $recipientGroup],
|
|
]));
|
|
|
|
$this->urlGenerator->method('linkToRouteAbsolute')
|
|
->with('files_sharing.sharecontroller.showShare', ['token' => 'myToken'])
|
|
->willReturn('myLink');
|
|
|
|
|
|
$this->rootFolder->method('getUserFolder')
|
|
->with($this->currentUser)
|
|
->will($this->returnSelf());
|
|
|
|
if (!$exception) {
|
|
$this->rootFolder->method('getById')
|
|
->with($share->getNodeId())
|
|
->willReturn([$share->getNode()]);
|
|
|
|
$this->rootFolder->method('getRelativePath')
|
|
->with($share->getNode()->getPath())
|
|
->will($this->returnArgument(0));
|
|
}
|
|
|
|
try {
|
|
$result = $this->invokePrivate($this->ocs, 'formatShare', [$share]);
|
|
$this->assertFalse($exception);
|
|
$this->assertEquals($expects, $result);
|
|
} catch (NotFoundException $e) {
|
|
$this->assertTrue($exception);
|
|
}
|
|
}
|
|
}
|