mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Updated unit tests for SMB 

- coverage for touch return value
- fixed directory provider to exclude unsupported cases
This commit is contained in:
Vincent Petry 2013-11-26 12:53:03 +01:00
parent e102eec89a
commit 712b47757a
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/files_external/tests/smb.php
View File

@ -29,6 +29,11 @@ class SMB extends Storage {
} }
} }
public function directoryProvider() {
// doesn't support leading/trailing spaces
return array(array('folder'));
}
public function testRenameWithSpaces() { public function testRenameWithSpaces() {
$this->instance->mkdir('with spaces'); $this->instance->mkdir('with spaces');
$result = $this->instance->rename('with spaces', 'foo bar'); $result = $this->instance->rename('with spaces', 'foo bar');

3
tests/lib/files/storage/storage.php
View File

@ -236,7 +236,8 @@ abstract class Storage extends \PHPUnit_Framework_TestCase {
public function testTouchCreateFile() { public function testTouchCreateFile() {
$this->assertFalse($this->instance->file_exists('foo')); $this->assertFalse($this->instance->file_exists('foo'));
$this->instance->touch('foo'); // returns true on success
$this->assertTrue($this->instance->touch('foo'));
$this->assertTrue($this->instance->file_exists('foo')); $this->assertTrue($this->instance->file_exists('foo'));
} }