Merge pull request #12900 from owncloud/more-accessibility

More accessibility fixes for Files
This commit is contained in:
Thomas Müller 2014-12-18 01:21:01 +01:00
commit 82f8726903
7 changed files with 31 additions and 6 deletions

View File

@ -106,6 +106,7 @@
if (part.img) { if (part.img) {
$image = $('<img class="svg"></img>'); $image = $('<img class="svg"></img>');
$image.attr('src', part.img); $image.attr('src', part.img);
$image.attr('alt', part.alt);
$link.append($image); $link.append($image);
} }
this.breadcrumbs.push($crumb); this.breadcrumbs.push($crumb);
@ -151,6 +152,7 @@
crumbs.push({ crumbs.push({
dir: '/', dir: '/',
name: '', name: '',
alt: t('files', 'Home'),
img: OC.imagePath('core', 'places/home.svg') img: OC.imagePath('core', 'places/home.svg')
}); });
for (var i = 0; i < parts.length; i++) { for (var i = 0; i < parts.length; i++) {

View File

@ -289,7 +289,9 @@
} }
var $actionLink = $('<a href="#" original-title="' + var $actionLink = $('<a href="#" original-title="' +
escapeHTML(deleteTitle) + escapeHTML(deleteTitle) +
'" class="action delete icon-delete" />' '" class="action delete icon-delete">' +
'<span class="hidden-visually">' + escapeHTML(deleteTitle) + '</span>' +
'</a>'
); );
var $container = context.$file.find('td:last'); var $container = context.$file.find('td:last');
$container.find('.delete').remove(); $container.find('.delete').remove();

View File

@ -710,6 +710,7 @@
'<input id="select-' + this.id + '-' + fileData.id + '<input id="select-' + this.id + '-' + fileData.id +
'" type="checkbox" class="selectCheckBox"/><label for="select-' + this.id + '-' + fileData.id + '">' + '" type="checkbox" class="selectCheckBox"/><label for="select-' + this.id + '-' + fileData.id + '">' +
'<div class="thumbnail" style="background-image:url(' + icon + '); background-size: 32px;"></div>' + '<div class="thumbnail" style="background-image:url(' + icon + '); background-size: 32px;"></div>' +
'<span class="hidden-visually">' + t('files', 'Select') + '</span>' +
'</label>' '</label>'
); );
} else { } else {

View File

@ -6,7 +6,9 @@
</ul> </ul>
<div id="app-settings"> <div id="app-settings">
<div id="app-settings-header"> <div id="app-settings-header">
<button class="settings-button" data-apps-slide-toggle="#app-settings-content"></button> <button class="settings-button" data-apps-slide-toggle="#app-settings-content">
<span class="hidden-visually"><?php p($l->t('Settings'));?></span>
</button>
</div> </div>
<div id="app-settings-content"> <div id="app-settings-content">
<h2><?php p($l->t('WebDAV'));?></h2> <h2><?php p($l->t('WebDAV'));?></h2>

View File

@ -39,7 +39,8 @@
<div id="uploadprogresswrapper"> <div id="uploadprogresswrapper">
<div id="uploadprogressbar"></div> <div id="uploadprogressbar"></div>
<input type="button" class="stop icon-close" <input type="button" class="stop icon-close"
style="display:none" value="" /> style="display:none" value=""
alt="<?php p($l->t('Cancel upload'))?>" />
</div> </div>
</div> </div>
<div id="file_action_panel"></div> <div id="file_action_panel"></div>
@ -61,7 +62,9 @@
<th id='headerName' class="hidden column-name"> <th id='headerName' class="hidden column-name">
<div id="headerName-container"> <div id="headerName-container">
<input type="checkbox" id="select_all_files" class="select-all"/> <input type="checkbox" id="select_all_files" class="select-all"/>
<label for="select_all_files"></label> <label for="select_all_files">
<span class="hidden-visually"><?php p($l->t('Select all'))?></span>
</label>
<a class="name sort columntitle" data-sort="name"><span><?php p($l->t( 'Name' )); ?></span><span class="sort-indicator"></span></a> <a class="name sort columntitle" data-sort="name"><span><?php p($l->t( 'Name' )); ?></span><span class="sort-indicator"></span></a>
<span id="selectedActionsList" class="selectedActions"> <span id="selectedActionsList" class="selectedActions">
<a href="" class="download"> <a href="" class="download">

View File

@ -725,7 +725,18 @@ label.infield {
/* VARIOUS REUSABLE SELECTORS */ /* VARIOUS REUSABLE SELECTORS */
.hidden { display:none; } .hidden {
display: none;
}
.hidden-visually {
position: absolute;
left:-10000px;
top: auto;
width: 1px;
height: 1px;
overflow: hidden;
}
.bold { font-weight:bold; } .bold { font-weight:bold; }
.center { text-align:center; } .center { text-align:center; }
.inlineblock { display: inline-block; } .inlineblock { display: inline-block; }

View File

@ -61,7 +61,8 @@
<?php if ($_['enableAvatars']): ?> <?php if ($_['enableAvatars']): ?>
<div class="avatardiv<?php if ($_['userAvatarSet']) { print_unescaped(' avatardiv-shown"'); } else { print_unescaped('" style="display: none"'); } ?>> <div class="avatardiv<?php if ($_['userAvatarSet']) { print_unescaped(' avatardiv-shown"'); } else { print_unescaped('" style="display: none"'); } ?>>
<?php if ($_['userAvatarSet']): ?> <?php if ($_['userAvatarSet']): ?>
<img src="<?php p(link_to('', 'index.php').'/avatar/'.$_['user_uid'].'/32?requesttoken='.$_['requesttoken']); ?>"> <img src="<?php p(link_to('', 'index.php').'/avatar/'.$_['user_uid'].'/32?requesttoken='.$_['requesttoken']); ?>"
alt="" />
<?php endif; ?> <?php endif; ?>
</div> </div>
<?php endif; ?> <?php endif; ?>
@ -90,6 +91,9 @@
</div> </div>
<form class="searchbox" action="#" method="post"> <form class="searchbox" action="#" method="post">
<label for="query" class="visually-hidden">
<?php p($l->t('Search'));?>
</label>
<input id="searchbox" class="svg" type="search" name="query" <input id="searchbox" class="svg" type="search" name="query"
value="<?php if(isset($_POST['query'])) {p($_POST['query']);};?>" value="<?php if(isset($_POST['query'])) {p($_POST['query']);};?>"
autocomplete="off" tabindex="2" /> autocomplete="off" tabindex="2" />