mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #22175 from nextcloud/fix/noid/warning-continue-break 

use break not continue in switch to avoid warning
This commit is contained in:
Morris Jobke 2020-08-11 09:41:36 +02:00 committed by GitHub
parent bc4df68e56 7c07f0c7f3
commit dffa155fc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
apps/user_ldap/lib/Group_LDAP.php
View File

@ -877,8 +877,8 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I
]) ])
]); ]);
$ldap_users = $this->access->fetchListOfUsers($filter, $attrs, 1); $ldap_users = $this->access->fetchListOfUsers($filter, $attrs, 1);
if (count($ldap_users) < 1) { if (empty($ldap_users)) {
continue; break;
} }
$groupUsers[] = $this->access->dn2username($ldap_users[0]['dn'][0]); $groupUsers[] = $this->access->dn2username($ldap_users[0]['dn'][0]);
break; break;
@ -886,13 +886,13 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I
//we got DNs, check if we need to filter by search or we can give back all of them //we got DNs, check if we need to filter by search or we can give back all of them
$uid = $this->access->dn2username($member); $uid = $this->access->dn2username($member);
if (!$uid) { if (!$uid) {
continue; break;
} }
$cacheKey = 'userExistsOnLDAP' . $uid; $cacheKey = 'userExistsOnLDAP' . $uid;
$userExists = $this->access->connection->getFromCache($cacheKey); $userExists = $this->access->connection->getFromCache($cacheKey);
if ($userExists === false) { if ($userExists === false) {
continue; break;
} }
if ($userExists === null || $search !== '') { if ($userExists === null || $search !== '') {
if (!$this->access->readAttribute($member, if (!$this->access->readAttribute($member,
@ -904,7 +904,7 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I
if ($search === '') { if ($search === '') {
$this->access->connection->writeToCache($cacheKey, false); $this->access->connection->writeToCache($cacheKey, false);
} }
continue; break;
} }
$this->access->connection->writeToCache($cacheKey, true); $this->access->connection->writeToCache($cacheKey, true);
} }