Commit Graph

58212 Commits

Author SHA1 Message Date
John Molakvoæ (skjnldsv) 3612a1097a
Default message for ShareNotFound exception
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-04-22 08:50:17 +02:00
John Molakvoæ (skjnldsv) 3d4929bd57
Add proper message to created share not found
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-04-22 08:50:17 +02:00
Roeland Jago Douma a384cb4e5a
Merge pull request #26648 from nextcloud/Valdnet-patch-7
l10n: Spelling unification
2021-04-21 11:15:54 +02:00
John Molakvoæ 31d88209f7
Merge pull request #25991 from nextcloud/update-acceptance-tests-to-selenium3 2021-04-21 09:31:29 +02:00
Roeland Jago Douma db2aea2f04
Merge pull request #26673 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-04-21 08:24:28 +02:00
Nextcloud-PR-Bot 1ac183fb05 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-21 04:11:37 +00:00
Nextcloud bot e58344fb2a
[tx-robot] updated from transifex 2021-04-21 02:25:58 +00:00
Morris Jobke 9e8690d912
Merge pull request #26654 from nextcloud/bugfix/noid/fix-security-credentials-manager-test
Fix security credentials manager test
2021-04-20 22:03:52 +02:00
Morris Jobke 5448306238
Merge pull request #26658 from nextcloud/bugfix/noid/continue-on-denied-acls
Do not stop directory listing when ACL is blocking access
2021-04-20 21:35:19 +02:00
Morris Jobke ea0f022816
Merge pull request #26661 from nextcloud/bugfix/noid/fix-ldap-unit-test
Fix LDAP unit tests
2021-04-20 21:34:21 +02:00
Morris Jobke 6c0bb2c338
Merge pull request #26594 from nextcloud/enh/2fa/bootstrap
Move 2FA registration to IBootstrap
2021-04-20 21:30:15 +02:00
Morris Jobke 25406ebba2
Merge pull request #26652 from nextcloud/bugfix/noid/fix-broken-test
Fix broken Expiration test
2021-04-20 21:28:36 +02:00
Roeland Jago Douma a34085e1a2 Move 2fa backupscode to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 5ee9e1f784 Move 2FA registration to IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 46872e3921
Merge pull request #26617 from nextcloud/fix/oracle-column-check-unrelated-migrations
Do not check Oracle column constraints in unrelated migrations
2021-04-20 20:49:06 +02:00
Roeland Jago Douma f31d24dd7a
Merge pull request #26647 from nextcloud/bugfix/noid/empty-filename
Fail when creating new files with an empty path
2021-04-20 20:47:16 +02:00
Roeland Jago Douma 85bdf6c0fc
Merge pull request #26660 from nextcloud/bugfix/noid/fix-twofactor-backupcodes-tests
Fix twofactor backup code tests
2021-04-20 20:44:33 +02:00
Roeland Jago Douma d34d3d168d
Merge pull request #26659 from nextcloud/bugfix/noid/fix-updatenotification-test
Fix update notification tests
2021-04-20 20:43:56 +02:00
Roeland Jago Douma 1e767b4f44
Merge pull request #26662 from nextcloud/bugfix/noid/fix-dav-unit-tests
Fix DAV unit tests
2021-04-20 20:43:24 +02:00
Roeland Jago Douma cd5dd31ab0
Merge pull request #26663 from nextcloud/bugfix/noid/fix-support-test
Fix support tests
2021-04-20 20:42:32 +02:00
Joas Schilling 7f70f3e182
Fix support tests
2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

Had to use the Database user backend, as using multiple interfaces is deprecated:
https://github.com/sebastianbergmann/phpunit/issues/3955
> This functionality should be deprecated as "having to use it" is almost always a symptom of bad design.
> More importantly, though, the support for the creation of test doubles that implement multiple interfaces
> resulted in code that is hard to maintain.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:36:15 +02:00
Joas Schilling 379664974c
Fix DAV unit tests
6) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAccept
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

7) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptSequence
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

8) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptRecurrenceId
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

9) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptTokenNotFound
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

10) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptExpiredToken
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

11) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testDecline
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

12) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testProcessMoreOptionsResult
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

13) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set

14) OCA\DAV\Tests\unit\DAV\Migration\RefreshWebcalJobRegistrarTest::testRun
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:30:21 +02:00
Joas Schilling 39e248d330
Fix LDAP unit tests
20) OCA\user_ldap\tests\Jobs\UpdateGroupsTest::testHandleKnownGroups
Trying to configure method "fetchAll" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:22:52 +02:00
Joas Schilling fe8d98f84b
Fix twofactor backup code tests
16) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_11bf8381, its return declaration is ": void"

17) OCA\TwoFactorBackupCodes\Tests\Unit\Controller\SettingsControllerTest::testCreateCodes
Method getBackupCodesState may not return value of type string, its return declaration is ": array"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:18:15 +02:00
Julius Härtl 8f01bc65f1
Continue iterating over diretory contents and just hide file if denied by acl
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 17:17:09 +02:00
Joas Schilling 42140ab53f
Fix update notification tests
18) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"

19) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_2134ee38, its return declaration is ": void"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:15:31 +02:00
Joas Schilling c6978bac80
Fix security credentials manager test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:04:24 +02:00
Joas Schilling fc6fbb6499
Fix broken Expiration test
15) Warning
The data provider specified for OCA\Files_Trashbin\Tests\ExpirationTest::testGetMaxAgeAsTimestamp is invalid.
PHPUnit\Util\Exception: Method timestampTestData does not exist

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:53:00 +02:00
Morris Jobke 94322971a5
Merge pull request #26550 from nextcloud/fix/noid/prefer-cloudshare-over-mail-take2
hide mail share if a cloud share is possible – backend only solution
2021-04-20 14:26:14 +02:00
blizzz 92ca49d21d
save a whitespace today
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:03:01 +02:00
Arthur Schiwon f8d1ee5cfa
ignore mail shares of related remote share results
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:02:35 +02:00
Jan C. Borchardt 9d1e2c5082
Merge pull request #26548 from nextcloud/design/files-accessibility
Files & Core accessibility fixes
2021-04-20 13:51:40 +02:00
Valdnet a923761acb
l10n: Spelling unification
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-20 11:33:31 +02:00
Julius Härtl 8398762d78
Fail when creating new files with an empty path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 11:20:20 +02:00
Morris Jobke 67ab4dd6c7
Merge pull request #26624 from nextcloud/enh/sharing/readperm
Consider read permission in sharing tab
2021-04-20 09:27:45 +02:00
Julius Härtl 59f8685af2
Merge pull request #26633 from nextcloud/enh/sharee/lookup_later
Make lookup search explicit
2021-04-20 05:38:00 -01:00
Nextcloud bot 79116e825c
[tx-robot] updated from transifex 2021-04-20 02:25:58 +00:00
Morris Jobke a67f0b0c47
Merge pull request #26615 from nextcloud/enh/ffs/require_read
Require read permissions for federated shares
2021-04-19 21:50:48 +02:00
Jan C. Borchardt 738ac612d2
Fix accessibility of federation menu privacy buttons
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt 64e90cdc66
Fix accessibility of profile picture section
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:54 +02:00
Jan C. Borchardt f86a2239e7
Fix missing label of Files navigation sublist toggles
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
Jan C. Borchardt abedc275d9
Fix missing label of grid view toggle
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
Jan C. Borchardt 34396091e8
Fix screenreader label of search icon
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 21:02:53 +02:00
Jan C. Borchardt 749a266f78
Add proper labels for personal settings privacy toggles
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:47 +02:00
Jan C. Borchardt 317c77f70f
Improve focus feedback for file list actions
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
Jan C. Borchardt a649fbc404
Fix summary footer position and text contrast
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2021-04-19 20:34:46 +02:00
Roeland Jago Douma 2ef326d6b6
Merge pull request #26618 from nextcloud/bugfix/noid/fix-english-language
Fix English source string
2021-04-19 20:08:04 +02:00
Roeland Jago Douma dcd45427a6 Make lookup search explicit
Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 20:05:21 +02:00
Roeland Jago Douma adab9deb3e
Merge pull request #26601 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-3.1.2
Bump @nextcloud/dialogs from 3.1.1 to 3.1.2
2021-04-19 19:53:14 +02:00
Daniel Calviño Sánchez 4b376a107b Add automatic handling of "ElementNotInteractable" exceptions
In the WebDriver protocol, when a command fails because it can not
interact with the target element, an "element not interactable" error is
generated. It can be a transitive issue (for example, due to an
animation), so when the error is received the command should be tried
again, just like done, for example, with "ElementNotVisible" exceptions.

However, the last version of the "instaclick/php-webdriver" library
compatible with the Selenium Driver of Mink did not support yet that
WebDriver error. And even if Chrome is run using the old protocol an
unknown "element not interactable" error can be received anyway in some
cases. When an unknown error is received by the
"instaclick/php-webdriver" library it is thrown as a generic Exception
so, until the library can be updated, the message of generic exceptions
is checked and the command is retried if it matched.

For the time being "element not interactable" errors are handled like
"ElementNotVisible" exceptions; this may need to change once the error
is better understood.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-19 16:35:11 +02:00