ff93dd7eb1
Merge pull request #5466 from jlehtoranta/ldap-connectivity-fixes
...
LDAP Connectivity Fixes
2017-09-04 18:31:32 +02:00
ab92e2ee14
listen to deletion hooks for proper handling, adjust and add tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-08-31 23:03:21 +02:00
c6f6413bb1
Fix ldap tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-08-09 21:10:15 +02:00
6a62b4784a
LDAP: Add testStartTlsNegotiationFailure unit test
...
Signed-off-by: Jarkko Lehtoranta <devel@jlranta.com>
2017-07-23 14:50:01 +03:00
3a6511eac8
LDAP: Add testBindWithInvalidCredentials unit test
...
Signed-off-by: Jarkko Lehtoranta <devel@jlranta.com>
2017-07-23 14:50:01 +03:00
97e14cccf2
LDAP: Fix testUseBackupServer unit test
...
Signed-off-by: Jarkko Lehtoranta <devel@jlranta.com>
2017-07-23 14:50:01 +03:00
a619d349bf
add convenience script to run all tests at once
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-05-26 11:31:26 +02:00
f11d998371
Make IDE happy
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-05-26 11:30:43 +02:00
10ef98a3b1
add missing INotificationManager when creating User backend, LDAP
...
UserManager
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-05-26 11:25:54 +02:00
43f451e9e0
Fix usersInGroup retrieval
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-04-25 15:07:05 +02:00
b1d646640a
Merge branch 'master' of https://github.com/Xuanwo/server into Xuanwo-master2
2017-04-25 12:42:17 +02:00
8db21ad8c8
user_ldap: Add support for gidNumber
...
This patch is based on the work of @dleeuw (https://github.com/dleeuw )
(See https://github.com/nextcloud/server/issues/2640#issuecomment-269615883 for more details).
The difference is user & group data will be written into cache to have
better performance, and functions splited from primaryGroupID series to
make them more readable.
Fixed https://github.com/nextcloud/server/issues/2640
Signed-off-by: Xuanwo <xuanwo@yunify.com>
2017-04-25 10:06:47 +08:00
42e805f057
Merge pull request #1023 from GitHubUser4234/ldap_password_renew_pr
...
Handle password expiry in user_ldap
2017-04-24 12:17:04 +02:00
229d17e13b
Change LDAP method names
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-12 10:10:07 -05:00
1729e4471f
Update comments to Nextcloud
...
* based on PR by @Ardinis
* see #4311
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-11 23:16:27 -05:00
5fa218051b
unit test adjustment
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2017-04-07 18:06:50 +08:00
0ea8729d1d
lower case for attributes
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2017-04-06 19:17:24 +08:00
bd907a5dac
usertest adjustment
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2017-03-31 17:30:59 +08:00
9ed4fb0494
usertest adjustment
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2017-03-31 16:54:22 +08:00
5e7723f15c
restore ldap_password_renew_pr
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2017-03-31 15:16:22 +08:00
4622bebded
Include tests for "default" and "none" quotas
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-03-29 13:32:16 +02:00
ebd1a7d4b2
Add new testes to cover more cases
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-03-29 13:32:16 +02:00
e9b96062e6
Adjust current tests to match the expectations
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-03-29 13:32:16 +02:00
a5ba1f7803
Remove legacy class OC_Group and OC_User
...
* basically a straight replacement of the wrapped code at the calling code parts
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-09 17:35:09 -06:00
a4266f59ae
Merge pull request #3521 from nextcloud/ldap-fix-uuid-attr-detection
...
Fix Borken UUID Attribute Detection
2017-02-20 21:34:55 +01:00
25a2cb8c6e
Only request "IndexIgnore" if mod_autoindex is loaded
...
Signed-off-by: Robert Scheck <robert@fedoraproject.org>
2017-02-20 13:09:15 +01:00
ce97ab92c6
add tests to DB group
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-02-17 20:12:30 +01:00
42ddb12fd9
Background jobs can take 4k of characters only. We find a good batch size.
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-02-17 20:06:25 +01:00
497ee3e3e6
Add repair steps
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-02-17 18:45:33 +01:00
45615cc940
add integration test for uuid attr detection
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-02-17 12:05:51 +01:00
b740a21399
Fix integration test by not relying on Fake instances
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-02-17 02:04:42 +01:00
3a603ab8b4
Merge pull request #3264 from nextcloud/ldap-deny-long-dns
...
Gracefully deny users or groups with too long DNs
2017-01-26 01:15:43 -06:00
03ae7b654f
Gracefully deny users or groups with too long DNs
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-01-25 17:10:51 +01:00
95ef625a9d
Fix tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-25 11:24:42 +01:00
5812e99f1d
Fix app section tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-19 15:30:40 +01:00
4c5e7d270a
Add tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-23 19:58:43 +01:00
861c8572c0
restore ldap_password_pr
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
remove notification part
Signed-off-by: Roger Szabo <roger.szabo@web.de>
blizzz comments
Signed-off-by: Roger Szabo <roger.szabo@web.de>
morris comment
Signed-off-by: Roger Szabo <roger.szabo@web.de>
improved error message for changing password
Signed-off-by: Roger Szabo <roger.szabo@web.de>
blizz comments 20161013
Signed-off-by: Roger Szabo <roger.szabo@web.de>
Signed-off-by: Roger Szabo <roger.szabo@web.de>
Adjust HintException usage
Signed-off-by: Roger Szabo <roger.szabo@web.de>
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2016-11-23 19:02:48 +01:00
a49d571799
fix and tidy up tests after merge conflicts
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-13 15:34:40 +02:00
c4fcd1f282
Update tests for phunit 5.5
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-13 01:06:45 +02:00
7d2f70ef72
Use more IConfig and add unit tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 10:51:13 +02:00
bdf4bf4669
DI IConfig into ldap helper
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 10:18:18 +02:00
a30341823e
cache loginName2UserName and cover the method with unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 01:39:57 +02:00
979612fa08
get rid of test warnings
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-06 22:53:14 +02:00
01cf85e4e5
Fix the User_LDAP app
2016-09-12 16:48:11 +02:00
5fb2eee5df
Fix getMock user_ldap
2016-09-06 09:29:27 +02:00
4d31caa6f8
fix a few minor code smells
2016-08-29 14:34:37 +02:00
7ffb7b0d84
Use MockBuilder instead of createMock
...
CI uses an older PHPUnit
2016-08-15 16:43:22 +02:00
8a7a0f3287
Add unit tests
2016-08-15 16:25:34 +02:00
bd65a17203
Nextcloud license header for new files
2016-07-28 15:13:00 +08:00
2719dcabed
Merge branch 'master' of https://github.com/nextcloud/server
2016-07-27 15:17:29 +08:00
1c64ee67af
comments amended
2016-07-27 15:16:57 +08:00
32fb6beac3
final changes
2016-07-27 15:10:35 +08:00
686cb599b6
fix autoloading in LPAP integration tests, resolves #544
2016-07-25 11:05:59 +02:00
02ec8b1726
New LDAPProvider for user_ldap
2016-07-22 16:46:29 +08:00
813f0a0f40
Fix apps/
2016-07-21 18:13:57 +02:00
7c0de08cc4
Escape special characters ( #25429 )
...
* Escape LIKE parameter
* Escape LIKE parameter
* Escape LIKE parameter
* Escape LIKE parameter
* Escape LIKE parameter
* Use correct method in the AbstractMapping class
* Change the getNamesBySearch method so that input can be properly escaped while still supporting matches
* Don't escape hardcoded wildcard
2016-07-20 14:46:47 +02:00
059778bef0
Add unit test for LDAP multi group caching
2016-06-09 17:57:07 +02:00
aba539703c
Update license headers
2016-05-26 19:57:24 +02:00
2c0743c46b
Fix the tests again
2016-05-25 16:51:02 +02:00
b9a26bca3b
Fix throws docs
2016-05-25 16:06:09 +02:00
3ef8c95b37
Move tests/ to PSR-4
2016-05-25 16:06:09 +02:00
c807a26bd8
Move Access to PSR-4
2016-05-25 16:04:59 +02:00
aa7b600383
Move Configuration to PSR-4
2016-05-25 16:04:59 +02:00
af0a6961b1
Move Connection to PSR-4
2016-05-25 16:04:59 +02:00
387019a212
Move FilesystemHelper to PSR-4
2016-05-25 16:04:58 +02:00
7db6b487f5
Move Helper to PSR-4
2016-05-25 16:04:58 +02:00
391531851c
Move interface to PSR-4
2016-05-25 16:04:58 +02:00
3690ce1b36
Move LDAP to PSR-4
2016-05-25 16:04:58 +02:00
6feccccbd5
Move LogWrapper to PSR-4
2016-05-25 16:04:57 +02:00
d4e828f39e
Move wizard
2016-05-25 16:04:57 +02:00
3f5e76162d
Move lib\user to PSR-4
2016-05-25 16:04:56 +02:00
b7fa527791
Move User_LDAP and User_Proxy to PSR-4
2016-05-25 16:04:56 +02:00
cbba55a26c
Move Group_LDAP and Group_Proxy to PSR-4
2016-05-25 16:04:56 +02:00
62a59854f0
Fix LDAP race conditions
...
* getFromCache is wrapped in isCached
* inbetween the two calls the cache entry hits it's TTL
* getFromCache returns null
* this fix only checkes if the returned value is null and
return only non-null values
2016-04-20 21:50:28 +02:00
16df1c5188
apps: Fix typos (found by codespell) ( #23862 )
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-04-12 12:52:51 +02:00
8442516e10
Merge pull request #23329 from owncloud/fix-21555
...
Avatar must be saved after login is done and external storages set up…
2016-03-21 09:47:50 +01:00
d8621c78ed
Avatar must be saved after login is done and external storages set up properly, fixes #21555
2016-03-16 20:51:03 +01:00
8e0bd5630c
fix writing to cache when fallback server should be used immediately
2016-03-16 14:44:18 +01:00
933f60e314
Update author information
...
Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)
2016-03-01 17:25:15 +01:00
d19c47a381
More fixed tests :)
2016-02-09 18:11:30 +01:00
69a4cd2898
Merge pull request #22102 from owncloud/ldap_2nddispname-master
...
[LDAP] add second field for additional/optional display name attribute
2016-02-06 13:27:01 +01:00
e370b601db
fix unit tests
2016-02-03 22:45:33 +01:00
c1871f5787
Port of test_ldap_2nddispname to master
2016-02-03 13:55:39 +01:00
77069f5582
Use IUser::setEMailAddress in ldap as well
2016-01-20 15:21:33 +01:00
dd733d8925
Merge pull request #20804 from owncloud/fix-ldap-process-user-wo-displayname
...
LDAP: do not attempt to process user records without display name, fi…
2016-01-20 11:33:26 +01:00
682821c71e
Happy new year!
2016-01-12 15:02:18 +01:00
1ed6132899
LDAP: do not attempt to process user records without display name, fixes fatal error
2016-01-11 11:21:02 +01:00
70b58cf367
Merge pull request #17924 from owncloud/ldap-fix-appending-port
...
ensure an LDAP URL is used, append the port to the host URL when necessary, and just in one place
2016-01-08 12:34:15 +01:00
35a2639701
unit test on getHome in combination with OfflineUser
2015-12-11 17:25:57 +01:00
aedbc0c626
adjust unit test
2015-12-11 12:52:12 +01:00
a32b002cff
always use an LDAP URL when connecting to LDAP
2015-12-05 00:09:15 +01:00
f9fc254672
Add DB group to some files_external tests
...
Adding group Db to federation tests and ldap tests
Add group DB to Test_UrlGenerator
Adding group DB to trashbin and versions tests
Adding group DB to Test_Util_CheckServer for pg
2015-11-30 10:55:10 +01:00
253e4bcf63
integration tests
2015-11-04 12:26:21 +01:00
16aa339475
add method to count users by loginname and use it for diagnose test, fixes #20151
2015-10-30 18:20:50 +01:00
f96e552164
fix attribute casing to ensure array keys work
2015-10-27 19:10:38 +01:00
e1d61284f8
fix update quota with known value
2015-10-27 18:07:40 +01:00
8f09d5b67c
Update license headers
2015-10-26 14:04:01 +01:00
d486949705
Adjust unit tests
2015-10-16 10:37:08 +02:00
3f083353c1
Merge pull request #19635 from owncloud/fix-ldap-value-limitation
...
allow an attribute to return more than one value
2015-10-13 14:09:52 +02:00
d127b3f0d2
adjust tests
2015-10-09 14:30:49 +02:00
c8021441d0
Merge pull request #19489 from owncloud/fix-18297
...
fix possible infinite loop when reading groups in the wizard
2015-10-07 14:55:48 +02:00
0385a62363
Merge pull request #19597 from owncloud/update-license-headers
...
update licence headers via script
2015-10-06 11:18:35 +02:00
b945d71384
update licence headers via script
2015-10-05 21:15:52 +02:00
353a8e442f
fix possible infinite loop when reading groups in the wizard
2015-10-05 19:10:30 +02:00
fc273ac88c
trim by default, add unit tests
2015-10-05 13:42:20 +02:00
0dde79b75b
memberOf resembles a DN as well and is actively used
2015-09-28 18:40:01 +02:00
002b6bf059
do not throw exception when no attribute is specified
2015-09-23 17:27:40 +02:00
9d03b7c6b7
read all relevant user attributes on login and user search, in one query. saves us some.
2015-09-23 16:38:39 +02:00
27af0e82dd
Merge pull request #18042 from GreenArchon/master
...
Properly nest groups when using memberOf to detect group membership, …
2015-08-26 11:42:47 +02:00
6787774a32
integration tests for hardening user home retrieval
2015-08-06 09:31:07 +02:00
7604bcb3cb
Properly nest groups when using memberOf to detect group membership, fixes #17759
2015-08-03 20:15:22 -04:00
0967a54755
fix test after rebasing
2015-07-27 17:34:45 +02:00
85b7bde7d4
add integration tests for avatar update
2015-07-27 17:27:00 +02:00
68706de45b
refactor integration tests to make it easier to add new ones
2015-07-27 17:27:00 +02:00
933f087d21
Merge pull request #17526 from owncloud/fix-17516
...
LDAP: when checking group for matching filter, also take base DN into…
2015-07-27 08:38:45 +02:00
4699a29a70
Fixing line comments and indentation
2015-07-21 22:19:53 +02:00
b961a29b0c
fix indentation. no code changes, whitespace only.
2015-07-20 01:21:52 +02:00
4f910221c4
fix runtime caching in ldap's user manager, fixes #17631
2015-07-17 18:57:56 +02:00
bfdf39b9bd
LDAP: when checking group for matching filter, also take base DN into consideration. Fixes #17516
2015-07-09 12:19:04 +02:00
0a23d566ba
Merge pull request #17255 from owncloud/fix-17119
...
[LDAP] Filter user groups obtained by memberof
2015-07-01 00:33:39 +02:00
5f4db0540a
tests solidity
2015-06-30 14:09:11 +02:00
646f2f1d41
adjust unit test
2015-06-30 13:56:25 +02:00
663cd7af4d
integration test
2015-06-30 12:52:27 +02:00
f63915d0c8
update license headers and authors
2015-06-25 14:13:49 +02:00
0e522a0b01
delete user test to take getHome into account to ensure it is also deleted subsequently
2015-06-17 14:13:01 +02:00
090478a95e
if possible, getUserGroups should get memberships using memberOf virtual attribute
2015-06-03 17:38:27 +02:00
6b218039ba
Fixes returns of group memberships and counting if all members have the specific groups as primary set.
2015-05-19 12:56:07 +02:00
9b6a988926
add integration test to ensure correct behaviour on lost connections
2015-04-24 15:50:03 +02:00
85d0fc5cf6
LDAP tests: swithc var_dump to exception
2015-04-18 15:09:15 +02:00
fafecd1c05
fix cherrypicking
2015-04-10 11:08:24 +02:00
077ab27281
fix_tests
...
Conflicts:
apps/user_ldap/tests/user_ldap.php
2015-04-10 09:12:37 +02:00
40edaa5a69
adjust tests
2015-04-09 12:00:11 +02:00
b585d87d9d
Update license headers
2015-03-26 11:44:36 +01:00
7520d0fb3d
offset needs to be considered in computed limit
2015-03-23 16:51:40 +01:00
06aef4e8b1
Revert "Updating license headers"
...
This reverts commit 6a1a4880f0
2015-02-26 11:37:37 +01:00
52495dc995
Merge pull request #13740 from owncloud/fix-12190-2
...
Include primary groups in user and login filter when restricting group access and also fix user counting in primary groups
2015-02-24 16:37:49 +01:00
6a1a4880f0
Updating license headers
2015-02-23 12:13:59 +01:00
31de757514
fix counting of users in primary group
2015-01-28 15:52:59 +01:00
6c335ee6fc
add test for mapping's getList method
2015-01-07 12:39:29 +01:00
b9235e2a24
inject DB Connection to user manager
2015-01-07 00:52:18 +01:00
40ecd30fba
inject oc config to User_LDAP
2015-01-06 23:28:49 +01:00
e724b78694
smaller fixes: coding style, PHPdoc, typos and few for DI
2015-01-06 17:50:06 +01:00
61ed363f82
planned refactorings for OC 8
2014-12-20 18:28:29 +01:00
144d95de7d
basic adjustments for OC 8. I.e. no visible issues, LDAP tests pass.
2014-12-20 16:09:04 +01:00
4fa39250e7
LDAP User Cleanup: Port from stable7 without further adjustements
...
LDAP User Cleanup
background job for user clean up
adjust user backend for clean up
register background job
remove dead code
dependency injection
make Helper non-static for proper testing
check whether it is OK to run clean up job. Do not forget to pass arguments.
use correct method to get the config from server
methods can be private, proper indirect testing is given
no automatic user deletion
make limit readable for test purposes
make method less complex
add first tests
let preferences accept limit and offset for getUsersForValue
DI via constructor does not work for background jobs
after detecting, now we have retrieving deleted users and their details
we need this method to be public for now
finalize export method, add missing getter
clean up namespaces and get rid of unnecessary files
helper is not static anymore
cleanup according to scrutinizer
add cli tool to show deleted users
uses are necessary after recent namespace change
also remove user from mappings table on deletion
add occ command to delete users
fix use statement
improve output
big fixes / improvements
PHP doc
return true in userExists early for cleaning up deleted users
bump version
control state and interval with one config.php setting, now ldapUserCleanupInterval. 0 will disable it. enabled by default.
improve doc
rename cli method to be consistent with others
introduce ldapUserCleanupInterval in sample config
don't show last login as unix epoche start when no login happend
less log output
consistent namespace for OfflineUser
rename GarbageCollector to DeletedUsersIndex and move it to user subdir
fix unit tests
add tests for deleteUser
more test adjustements
Conflicts:
apps/user_ldap/ajax/clearMappings.php
apps/user_ldap/appinfo/app.php
apps/user_ldap/lib/access.php
apps/user_ldap/lib/helper.php
apps/user_ldap/tests/helper.php
core/register_command.php
lib/private/preferences.php
lib/private/user.php
add ldap:check-user to check user existance on the fly
Conflicts:
apps/user_ldap/lib/helper.php
forgotten file
PHPdoc fixes, no code change
and don't forget to adjust tests
2014-12-19 19:47:54 +01:00
ec0f80fee9
Split mapping from Access and Helper classes into it's own. Fully test them, too.
...
remove unused methods
split mapping methods off from Access class
fix DB query handling
move 'clear mapping' methods from static helper to new mapping class
add tests
test directly with DB
finishing tests and fix return value from setDNbyUUID
add corresponding class for groups and make abstract test class neutral. helper tests is now obsolete as the tested functions were moved to the new mapper class.
add missing info to PHPDoc
add unmap method
fix namespaces
fix test inheritance
PHPDoc and a small code restructure for scrutinizer, no effective changes
PostgreSQL does not accept LIMIT in DELETE queries
phpdoc fixes, no code changes
2014-12-19 18:26:12 +01:00
02095d4f20
Merge pull request #11837 from owncloud/fix-11328
...
unify count filters and introduce display name attribute detection
2014-11-24 18:13:01 +01:00
f725cc66a3
consolidate user count filter in wizard and user back end
2014-11-20 18:31:39 +01:00
76ebd3a050
Make apps/ extend the \Test\TestCase and fix overwritten methods
2014-11-19 14:52:09 +01:00
9368de5a8b
Merge pull request #11789 from owncloud/fix-11762
...
[LDAP] Login: dont fail with 500 if configured display name attribute is not set
2014-11-11 11:16:41 +01:00
Morris Jobke
Arthur Schiwon
Roeland Jago Douma
Jarkko Lehtoranta
Xuanwo
Roger Szabo
Juan Pablo Villafáñez
Lukas Reschke
Robert Scheck
Joas Schilling
Victor Dubiniuk
Jörn Friedrich Dreyer
root
Aaron Wood
Vincent Petry
Lukas Reschke
Joas Schilling
Stefan Weil
Thomas Müller
Arthur Schiwon
Frédéric Fortier
Viktor Szépe
Jenkins for ownCloud
Joas Schilling