Commit Graph

54621 Commits

Author SHA1 Message Date
Daniel Calviño Sánchez 05cbdddb0d Fix valid storages removed when cleaning remote storages
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:02:28 +00:00
Daniel Calviño Sánchez 1e7e6c900c Add integration tests for "sharing:cleanup-remote-storages" OCC command
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:02:26 +00:00
Nextcloud bot 0e30c82f30
[tx-robot] updated from transifex 2021-03-18 02:25:29 +00:00
Morris Jobke f302616544
Merge pull request #26092 from nextcloud/backport/25722/stable19
[stable19] apply object store copy optimization when 'cross storage' copy is wit…
2021-03-17 20:09:11 +01:00
Morris Jobke 9176410018
Merge pull request #26169 from nextcloud/backport/26072/stable19
[stable19] remove explicit fclose from S3->writeStream
2021-03-17 13:46:24 +01:00
kesselb 21b67e3b5b
Merge pull request #26164 from nextcloud/backport/26153/stable19
[stable19] Use correct exception type hint in catch statement
2021-03-17 11:08:46 +01:00
Robin Appelman 68fb72b028 remove explicit fclose from S3->writeStream
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:15 +00:00
Morris Jobke 10b024642f Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:49:42 +00:00
Nextcloud bot 709788e08f
[tx-robot] updated from transifex 2021-03-17 02:24:47 +00:00
kesselb 8daf30e278
Merge pull request #26135 from nextcloud/backport/25136/stable19
[stable19] do cachejail search filtering in sql
2021-03-16 17:41:19 +01:00
Robin Appelman b2903064c9
only use share cacheentry when available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman 1d1d4de991
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman b9b2c6d2fa
fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman 75a48fbc2a
fix cachjail searching for root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
Robin Appelman 564390e303
do cachejail search filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
Christoph Wurst f9c9e27e46
Merge pull request #26129 from nextcloud/backport/26115/stable19
[stable19] Log exceptions when creating share
2021-03-16 11:09:15 +01:00
Nextcloud bot 95b55423e8
[tx-robot] updated from transifex 2021-03-16 02:25:09 +00:00
Vincent Petry e43c93881e Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:34 +00:00
Christoph Wurst 3ac0601e26
Merge pull request #26060 from nextcloud/backport/25911/stable19
[stable19] Only clear share password model when actually saved
2021-03-15 09:48:23 +01:00
Nextcloud bot 901472a899
[tx-robot] updated from transifex 2021-03-15 02:24:26 +00:00
Nextcloud bot bbb616a604
[tx-robot] updated from transifex 2021-03-14 02:24:05 +00:00
Nextcloud bot 2a955bf864
[tx-robot] updated from transifex 2021-03-13 02:23:21 +00:00
Robin Appelman b39f9fb2c9 apply object store copy optimization when 'cross storage' copy is within the same object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 16:16:38 +00:00
Vincent Petry 20c16e21c2
Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-12 12:23:36 +01:00
Nextcloud bot 54affce466
[tx-robot] updated from transifex 2021-03-12 02:23:09 +00:00
Roeland Jago Douma 586cbde4ba
Merge pull request #26041 from nextcloud/backport/25916/stable19
[stable19] Remove trash items from other trash backends when deleting all
2021-03-11 10:34:44 +01:00
Nextcloud bot c750417f19
[tx-robot] updated from transifex 2021-03-11 02:23:35 +00:00
Roeland Jago Douma 0a7a401f95
Merge pull request #26028 from nextcloud/backport/25933/stable19
[stable19] Hide expiration date field for remote shares
2021-03-10 15:46:47 +01:00
Vincent Petry 6e394ac9d6 Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 08:45:54 +00:00
Julius Härtl 37b161b526 Remove trash items from other trash backends when deleting all
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:05:03 +00:00
Nextcloud bot efcc3dd99f
[tx-robot] updated from transifex 2021-03-10 02:23:25 +00:00
Nextcloud bot 6db532444f
[tx-robot] updated from transifex 2021-03-09 02:24:20 +00:00
Roeland Jago Douma 1ca8eba6c8
Merge pull request #26010 from nextcloud/dependabot/npm_and_yarn/stable19/elliptic-6.5.4
[Security] Bump elliptic from 6.5.3 to 6.5.4
2021-03-08 20:42:02 +01:00
dependabot-preview[bot] 3f166960d8
[Security] Bump elliptic from 6.5.3 to 6.5.4
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-08 17:11:25 +00:00
Julius Härtl 594932c96c
Merge pull request #25964 from nextcloud/backport/25712/stable19
[stable19] Fix admin password strengthify tooltip
2021-03-08 10:29:33 +01:00
Nextcloud bot ad8a1bcc12
[tx-robot] updated from transifex 2021-03-08 02:23:37 +00:00
Nextcloud bot 82244f1466
[tx-robot] updated from transifex 2021-03-07 02:22:31 +00:00
Roeland Jago Douma e73ea889ab
Merge pull request #25957 from nextcloud/backport/25932/stable19
[stable19] Skip empty obsolete owner when adding to own NC
2021-03-06 10:54:10 +01:00
Nextcloud bot 3bf923ec55
[tx-robot] updated from transifex 2021-03-06 02:22:48 +00:00
Richard Steinmetz d11b3683af
Fix admin password strengthify tooltip
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-03-05 18:26:16 +01:00
Vincent Petry f21e25182b Skip empty obsolete owner when adding to own NC
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.

Fixes an issue where "Add to your Nextcloud" doesn't add anything.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-05 13:40:41 +00:00
Roeland Jago Douma bcb840ce04
Merge pull request #25845 from nextcloud/backport/25757/stable19
[stable19] fix detecting cyclic group memberships
2021-03-05 08:43:35 +01:00
Nextcloud bot 8d9d540257
[tx-robot] updated from transifex 2021-03-05 02:22:23 +00:00
Nextcloud bot 18ba1854db
[tx-robot] updated from transifex 2021-03-04 02:22:39 +00:00
Arthur Schiwon 7afb588059
fix detecting cyclic group memberships
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-03 10:53:24 +01:00
Roeland Jago Douma 4a111afc8d
Merge pull request #25901 from nextcloud/backport/25860/stable19
[stable19] do not die after LDAP auth failed with expired acc
2021-03-03 08:35:21 +01:00
Nextcloud bot 7d5f7cef93
[tx-robot] updated from transifex 2021-03-03 02:21:51 +00:00
Arthur Schiwon 4b3961c412 do not die after LDAP auth failed with expired acc
- some servers return error code 53

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-02 20:40:11 +00:00
kesselb 3177ab8ba9
Merge pull request #25859 from nextcloud/backport/25856/stable19
[stable19] Card::getOwner should return the actual value
2021-03-02 09:20:34 +01:00
Nextcloud bot 47bb51cfeb
[tx-robot] updated from transifex 2021-03-02 02:22:49 +00:00