Commit Graph

22202 Commits

Author SHA1 Message Date
Roeland Jago Douma 7799eef90e
Merge pull request #20390 from nextcloud/refactor/no-closing-tag
Do not use closing tags
2020-04-10 08:34:18 +02:00
Nextcloud bot 078b12a9b0
[tx-robot] updated from transifex 2020-04-10 02:18:23 +00:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
Azul 43f0d2a3b5 Allow opening files for editing in new tabs
In a file list files with a default action
have an href that will trigger the action.
This way ctrl-click and middle button click open the default action in a new tab.

In order to achieve this a new param `openfile` was introduced to the files app.
It will make the files app trigger the default action for the file in question.
This also allows linking to file content rather than just the details display.

Introduce fileList.getDefaultActionUrl()
to create a link with that param set.
It's overwritten in the trashbin fileList
so that anchors continue to have `#` as a href.

Fix the link generation for subfolders of public shares:
58a87d0 was the last commit that touched the linkTo function in public.js.
It included the params as arguments to the generateUrl function.
Turns out this completely ignores the dir parameter now.
The inclusion was reverted in other places
so revert it here as well.
Also change `dir` to `path` in the param as that is respected
when following the link.

Add Test for the new link url for files with default action.
Remove test for multiple selects with ctrl-click
as that is not what we are doing anymore.

Signed-off-by: Azul <azul@riseup.net>
2020-04-09 16:41:09 +02:00
Christoph Wurst 64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
Christoph Wurst 3a415e4139
Remove space between switch case and colon
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:17:53 +02:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst 42625a46be
Remove spaces after method or function call
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
Christoph Wurst 709584b853
Do not use closing tags
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:01:17 +02:00
Christoph Wurst c56a273b39
Merge pull request #20383 from nextcloud/techdebt/function-spacing
Unify function spacing to PSR2 recommendation
2020-04-09 15:53:09 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
John Molakvoæ 66b743385e
Merge pull request #20355 from nextcloud/fix/comments/clear-input/19585
Clear comment on successful post
2020-04-09 13:46:20 +02:00
Christoph Wurst 2a529e453a
Use a blank line after the opening tag
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:50:14 +02:00
Christoph Wurst 41b5e5923a
Use exactly one empty line after the namespace declaration
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
John Molakvoæ 732a239cfd
Merge pull request #20363 from nextcloud/smb-3.2.3
update icewind/smb to 3.2.3
2020-04-09 08:16:43 +02:00
Nextcloud bot b537e9fbc7
[tx-robot] updated from transifex 2020-04-09 02:18:26 +00:00
Christoph Wurst 85e369cddb
Fix multiline comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
Azul d2728cbdc1 refactor: fileActions.getCurrentDefaultFileAction()
fileActions.getCurrentDefaultFileAction() returns the default file action
for the currently selected file.

There were a number of places querying for the mime, type and permissions
of that file first to then query for the default action.

Signed-off-by: Azul <azul@riseup.net>
2020-04-08 18:19:58 +02:00
Robin Appelman 2340f4f2d5
update icewind/smb to 3.2.3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-08 17:30:47 +02:00
Joas Schilling 3ea37d0d10
Show the displayname instead of the user id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-08 16:09:03 +02:00
Joas Schilling f8a5812f98
Try to use the display name of file transfers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-08 15:41:20 +02:00
Roeland Jago Douma 981278a666
Merge pull request #20315 from nextcloud/dependabot/npm_and_yarn/handlebars-4.7.6
Bump handlebars from 4.7.4 to 4.7.6
2020-04-08 15:37:58 +02:00
dependabot-preview[bot] 32209c0d92 Bump handlebars from 4.7.4 to 4.7.6
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.4 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.4...v4.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-08 12:59:43 +00:00
John Molakvoæ (skjnldsv) 05821ab243 Clear comment on successful post
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-08 06:29:38 +00:00
Nextcloud bot 8146e1988c
[tx-robot] updated from transifex 2020-04-08 02:18:45 +00:00
Roeland Jago Douma e266666380
Merge pull request #20188 from nextcloud/bug/19662/add-default-title-for-event-in-invitatios
Add default titles for titleless events in invitations
2020-04-07 11:22:17 +02:00
Nextcloud bot 9895aff4d9
[tx-robot] updated from transifex 2020-04-07 02:18:10 +00:00
Christoph Wurst 8119e0b18e
Inline usages of OCP.Toast in bundled files
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-06 17:19:57 +02:00
Christoph Wurst 01a70e5d0f
Use external Toast implementation and deprecate the OCP API
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-06 17:00:58 +02:00
Roeland Jago Douma 1d62b9786f
Merge pull request #20276 from nextcloud/files-external-param-tooltop
allow setting tooltips for external storage config options
2020-04-06 16:42:39 +02:00
dependabot-preview[bot] 52f4feca92 Bump @nextcloud/l10n from 1.1.1 to 1.2.2
Bumps [@nextcloud/l10n](https://github.com/nextcloud/nextcloud-l10n) from 1.1.1 to 1.2.2.
- [Release notes](https://github.com/nextcloud/nextcloud-l10n/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-l10n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-l10n/compare/v1.1.1...v1.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-06 13:50:12 +00:00
Roeland Jago Douma 9a4193f557
Merge pull request #19761 from nextcloud/bugfix/19658/add_missing_index_to_original_migration
Add missing index to original migration
2020-04-06 09:44:34 +02:00
Nextcloud bot d25885441e
[tx-robot] updated from transifex 2020-04-06 02:18:03 +00:00
Roeland Jago Douma 513dea13cc
Merge pull request #20309 from nextcloud/rakekniven-patch-2
l10n: Triple dot to ellipsis.
2020-04-05 13:53:41 +02:00
Roeland Jago Douma 4e9cd2b307
Merge pull request #20308 from nextcloud/rakekniven-patch-1
l10n: Changed spelling of WebAuthn
2020-04-05 13:06:56 +02:00
npmbuildbot[bot] 922221bbb3 Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-05 07:29:38 +00:00
Nextcloud bot cac1480bf8
[tx-robot] updated from transifex 2020-04-05 02:18:04 +00:00
rakekniven 531187ce58
l10n: Triple dot to ellipsis.
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-04-04 23:09:12 +02:00
rakekniven a4dc7f772b
l10n: Changed spelling of WebAuthn
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-04-04 23:04:33 +02:00
rakekniven e5b3ee615e
l10n: Changed spelling of WebAuthn
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-04-04 23:02:10 +02:00
rakekniven ee83fc0d2b
l10n: Changed spelling of WebAuthn
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-04-04 23:00:43 +02:00
Roeland Jago Douma 4a292126e5
Merge pull request #20139 from nextcloud/unify-default-value-for-restricting-user-enumeration-with-settings
Unify default value for restricting user enumeration with settings
2020-04-04 10:33:04 +02:00
Roeland Jago Douma 0e53be44d5
Merge pull request #20273 from nextcloud/dependachristoph/npm_and_yarn/handlebars-minimist
Update handlebars to get rid of minimist
2020-04-04 10:27:02 +02:00
Roeland Jago Douma 5c6f9ca278
Merge pull request #20284 from nextcloud/bugfix/noid/catch-no-user-in-cron
Properly catch NoUserException during upload cleanup
2020-04-04 10:25:53 +02:00
Nextcloud bot 3a0b70696c
[tx-robot] updated from transifex 2020-04-04 02:17:51 +00:00
Julius Härtl fba7bcfcc4
Catch NoUserException when running the upload cleanup as cronjob
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-03 23:06:26 +02:00
Robin Appelman 857957b45e
allow setting tooltips for external storage config options
allows explaining non-obvious config options a bit more

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-03 15:44:53 +02:00
Nextcloud bot 4e8bbc4e34
[tx-robot] updated from transifex 2020-04-03 12:08:12 +00:00
Thomas Citharel 058ffa37ff
Add default titles for titleless events in invitations
Closes #19662

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-03 13:49:25 +02:00
Roeland Jago Douma 054df038de
Merge pull request #20285 from nextcloud/fix/l10n-webauthn
Ignore compiled webauthn settings
2020-04-03 13:46:32 +02:00
Roeland Jago Douma ecdd2590f9
Ignore compiled webauthn settings
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-03 13:45:38 +02:00
Christoph Wurst 62b9db5780
Update handlebars to get rid of minimist
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-03 11:04:46 +02:00
Roeland Jago Douma 475d549ec6
Merge pull request #19913 from nextcloud/bugfix/noid/remove-user-name-from-public-sharing-page
Remove user name from public sharing page
2020-04-03 10:33:05 +02:00
Roeland Jago Douma 8306b42ef2
Merge pull request #20217 from nextcloud/dependabot/npm_and_yarn/regenerator-runtime-0.13.5
Bump regenerator-runtime from 0.13.3 to 0.13.5
2020-04-03 10:16:52 +02:00
dependabot-preview[bot] 4f8a847f59 Bump regenerator-runtime from 0.13.3 to 0.13.5
Bumps [regenerator-runtime](https://github.com/facebook/regenerator) from 0.13.3 to 0.13.5.
- [Release notes](https://github.com/facebook/regenerator/releases)
- [Commits](https://github.com/facebook/regenerator/compare/regenerator-runtime@0.13.3...regenerator-runtime@0.13.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-03 06:59:22 +00:00
Roeland Jago Douma a8452b236b
Merge pull request #20244 from CHRINIMUE/add-progress-bar-to-public-upload
Add basic progressbar to public upload page
2020-04-03 08:50:15 +02:00
Julius Härtl 3a88ad741d
Query Application class on publicwebdav
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-02 17:07:53 +02:00
Joas Schilling bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
Add optional comments reference_id
2020-04-02 11:34:21 +02:00
Joas Schilling 81455479bc
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-02 09:59:44 +02:00
Joas Schilling 1c4422ca3d
Add a test and fix the existing ones
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-01 17:15:59 +02:00
Joas Schilling f878ea9606
Remove user name from public sharing page
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-01 17:14:38 +02:00
Roeland Jago Douma 19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19
Update the license headers for Nextcloud 19
2020-04-01 12:44:21 +02:00
Roeland Jago Douma 53db05a1f6
Start with webauthn
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-03-31 22:17:07 +02:00
Christopher Mueller 49291b905a fix wrong indentation
Signed-off-by: Christopher Mueller <chrinimue@posteo.me>
2020-03-31 18:09:24 +00:00
Christopher Mueller 79320200cc add translation strings & add margin to uploaded files-list
Signed-off-by: Christopher Mueller <chrinimue@posteo.me>
2020-03-31 17:47:22 +00:00
Christopher Mueller 0c14c9d7ea add progressbar for every element & better design
Signed-off-by: Christopher Mueller <chrinimue@posteo.me>
2020-03-31 14:21:28 +00:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
Christopher Mueller b69d76feee Add basic progressbar to public upload page
Signed-off-by: Christopher Mueller <chrinimue@posteo.me>
2020-03-31 10:56:59 +00:00
Joas Schilling 720dc4e93d
Add optional column oc_comments.reference_id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +02:00
Christoph Wurst 5a0856c4ab
Merge pull request #20219 from nextcloud/dependabot/npm_and_yarn/webpack-4.42.1
Bump webpack from 4.42.0 to 4.42.1
2020-03-31 09:36:26 +02:00
Nextcloud bot 186d5ff5ed
[tx-robot] updated from transifex 2020-03-31 02:19:03 +00:00
John Molakvoæ fa4162e86f
Merge pull request #20208 from nextcloud/smb-folder-contents-normalize-path
normalize smb path while listing folder contents
2020-03-30 10:06:39 +02:00
John Molakvoæ 20ecbd60fd
Merge pull request #20207 from nextcloud/smb-3.2.1
update icewind/smb to 3.2.1
2020-03-30 10:05:48 +02:00
dependabot-preview[bot] 548f9dcbb3 Bump webpack from 4.42.0 to 4.42.1
Bumps [webpack](https://github.com/webpack/webpack) from 4.42.0 to 4.42.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.42.0...v4.42.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-03-30 07:49:32 +00:00
Roeland Jago Douma 2200cc8562
Merge pull request #19325 from nextcloud/dependachristoph/composer/sabre-4.0
Update Sabre (and friends) to 4.0
2020-03-30 09:34:25 +02:00
Nextcloud bot 9e8ac1d24a
[tx-robot] updated from transifex 2020-03-30 02:18:34 +00:00
Nextcloud bot 89710bbdcf
[tx-robot] updated from transifex 2020-03-29 02:20:14 +00:00
Nextcloud bot df463f90be
[tx-robot] updated from transifex 2020-03-28 02:18:15 +00:00
Christoph Wurst 463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
Remove unused imports
2020-03-27 17:14:08 +01:00
Robin Appelman ef7bb5225a
normalize smb path while listing folder contents
currently when listing `'/'`, it will include a double slash in the paths used for the listing logic
this causes unneeeded cache misses in the statCache

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 17:04:53 +01:00
Robin Appelman b41e62db99
update icewind/smb to 3.2.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 16:57:55 +01:00
Georg Ehrke 55081b7fd2
RequestTestCase: Default type for headers needs to be array
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
Georg Ehrke 80b7ef9b41
Adjust FakeLockerPluginTest to new Sabre version
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
Georg Ehrke 5e2c802bb7
Set custom ProdId in Birthday service, do not depend on Sabre Versio number for unit tests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
Georg Ehrke 102a328e65
Fix usage of Sabre\HTTP\Request in unit tests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
Georg Ehrke 52ba75f644
Sabre/DAV 4.0: beforeMethod is now beforeMethod:*
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
Roeland Jago Douma ad63c1da1b
Merge pull request #20186 from szaimen/patch-2
Fix "Use this address..." String
2020-03-27 10:25:46 +01:00
Nextcloud bot f680f19364
[tx-robot] updated from transifex 2020-03-27 02:18:20 +00:00
szaimen 1096c56509
Fix "Use this address..." String
Signed-off-by: szaimen <szaimen@e.mail.de>
2020-03-26 17:43:13 +01:00
John Molakvoæ 36d76ee94f
Merge pull request #19872 from nextcloud/techdebt/bable-polyfill-to-core-js
Migrate from @babel/polyfill to core-js@3
2020-03-26 16:42:05 +01:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
Christoph Wurst fa9c206fc8
Migrate from @babel/polyfill to core-js@3
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 13:22:35 +01:00
blizzz 62403d0932
Merge pull request #20123 from lippl/bugfix/ldap-user_count-warning
Bugfix - Prevent PHP Warning for count on null on LDAP
2020-03-26 11:28:26 +01:00
Christoph Wurst 25ab122245
Merge pull request #20172 from nextcloud/techdebt/phpunit-short-return
Use the shorter phpunit syntax for mocked return values
2020-03-26 09:25:19 +01:00
Philipp Staiger 8769d97f62 single squashed commit for bug fix
Signed-off-by: Philipp Staiger <philipp@staiger.it>
2020-03-26 09:01:35 +01:00