61b38a16fa
Fixes the following UI issues,
...
1. Increased the size of the delete, edit, close and submit buttons to take up 44x44px.
2. Now showing the delete button at all times when editing to avoid usability issues with touch screens.
3. Edit icon is also shown at all times, rather than only on hover.
4. Reduced the gap between comments a wee bit.
5. Fixed issues with focus event now working properly for edit and delete.
6. Removed absolute positioning of elements for alignment.
7. Fixed issue with tooltips becoming too high due to padding around actions. Occurred due to my changes.
8. Changed the position of the submit and close icons.
9. Fixed issue with jumping of the delete icon in Firefox. Occurred due to my changes.
10. Fixed issue with wrapping of content due to long author names. Occurred due to my changes.
11. Fixed issue with longer comments not appearing properly. This might have occurred due to my changes.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
b3e1026cab
Fixes div being added placed directly under ul during editing of comments.
...
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
facd1cae2f
Fixes issue where saving a non-modified comment kept the edit window open.
...
Now irrespective of the whether the comment has been modified we are going to go back to the view mode.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
e2b44d199b
[tx-robot] updated from transifex
2018-03-26 00:13:15 +00:00
89ebb8a663
[tx-robot] updated from transifex
2018-03-25 01:09:58 +00:00
64948bf30c
[tx-robot] updated from transifex
2018-03-23 01:11:28 +00:00
dabd7291c3
Make the new autocomplete endpoint OCS
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-21 09:46:52 +01:00
615258ba26
[tx-robot] updated from transifex
2018-03-20 01:11:33 +00:00
7f00de841b
[tx-robot] updated from transifex
2018-03-14 01:11:29 +00:00
3cae276149
[tx-robot] updated from transifex
2018-03-13 01:12:01 +00:00
4e56a02450
[tx-robot] updated from transifex
2018-03-12 01:12:21 +00:00
f08bc1bc6f
[tx-robot] updated from transifex
2018-03-10 01:11:58 +00:00
3867a74f0d
[tx-robot] updated from transifex
2018-03-06 01:12:16 +00:00
6c49cc0294
[tx-robot] updated from transifex
2018-03-05 01:12:12 +00:00
6975cef00b
[tx-robot] updated from transifex
2018-03-04 01:12:42 +00:00
3b000d4f91
[tx-robot] updated from transifex
2018-03-03 01:12:14 +00:00
b348cd170a
Update commentstabview.js
...
Changed typo reported at GitHub.
See https://www.transifex.com/nextcloud/nextcloud/translate/#de_DE/$/91002505?issue=yes
2018-03-01 20:53:50 +01:00
612e875f60
Merge pull request #8355 from nextcloud/fix-comments-num-index
...
Fix comments (and systemtags) when involving users with numerical ids
2018-02-26 17:12:57 +01:00
f095001e4b
Fix info.xml files of shipped apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 10:24:03 +01:00
d3d045dd5c
Remove unused import statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
023d028c57
fix creating comments when file is accessible to users with numeric ids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:39 +01:00
a5a0a938f2
test creating comments with numeric user ids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:10 +01:00
3fc6d6234e
[tx-robot] updated from transifex
2018-02-13 10:48:27 +00:00
91c67eb667
[tx-robot] updated from transifex
2018-02-12 21:33:37 +00:00
15b4797629
[tx-robot] updated from transifex
2018-02-09 01:10:53 +00:00
a0dfc7d34a
[tx-robot] updated from transifex
2018-02-05 01:10:16 +00:00
58b568fd5d
[tx-robot] updated from transifex
2018-02-04 01:10:28 +00:00
c1e4f9f305
Use type casting instead of *val() method
...
It should be up to 6x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +01:00
7800a9bc24
Fix array method usages with a proper call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:20:10 +01:00
db411f8771
Bump apps
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 11:40:53 +01:00
f578b69729
Update composer
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:16:10 +01:00
0280cff66f
Composer updated
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-04 16:31:16 +01:00
298b79410d
[tx-robot] updated from transifex
2018-01-04 09:48:31 +00:00
282567fced
format links in comments
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-03 13:11:20 +01:00
4c0c3c0bef
Show max warning comment lenth again
...
Fixes #7414
Since we no longer use an input field we have to use text instead of
val.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-02 10:28:09 +01:00
49b095b78e
Use proper authorative-autoloader for app autoloaders
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-14 08:31:31 +01:00
099a340bf5
The user displayNameResolver is specific to users, not the comments app
...
Other apps like spreed rely on it, and only can resolver per type can
be registered anyhow.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-12 17:36:31 +01:00
a684f033bd
[tx-robot] updated from transifex
2017-12-10 01:10:25 +00:00
855acc727b
[tx-robot] updated from transifex
2017-12-09 01:10:24 +00:00
5724e75827
Merge pull request #7252 from nextcloud/send-comment-on-enter
...
Submit comments with Enter and use Shift+Enter for new lines
2017-12-08 15:31:10 +01:00
9b1f3b969e
Fix Enter sending comment instead of adding autocomplete item to message
...
When the autocomplete popover is shown the At.js plugin listens on the
message input field for key down events, and when Enter is pressed it
adds the selected item to the message. However, as "_onTypeComment" also
handles key down events for the message input field, when Enter was
pressed the comment was submitted and At.js had no chance to add the
item before that happened. Now when Enter is pressed and the
autocomplete popover is shown the comment is not submitted, and thus
At.js adds the selected item to the message as expected.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-07 15:38:46 +01:00
9505c56447
[tx-robot] updated from transifex
2017-12-06 01:10:23 +00:00
f25d55c972
[tx-robot] updated from transifex
2017-12-05 01:10:20 +00:00
567757c793
[tx-robot] updated from transifex
2017-12-04 01:10:30 +00:00
cec236f0af
[tx-robot] updated from transifex
2017-12-02 01:10:32 +00:00
ffc627e18e
[tx-robot] updated from transifex
2017-12-01 01:10:20 +00:00
c43f64d56b
Add unit tests for posting comments with enter key
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-30 19:30:27 +01:00
d03fcbca77
Set text only in the message div of the new comment form
...
When finding ".message" elements on "view.$el" the message area for the
new comment form and all the comments were matched. Now the selector was
restricted to match only the message area for the new comment form.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-30 19:29:19 +01:00
49ec86a81f
[tx-robot] updated from transifex
2017-11-30 01:13:19 +00:00
f03aa0480a
Merge pull request #7316 from nextcloud/fix-silent-conflicts-due-to-merging-7256-after-7251
...
Fix silent conflicts due to merging #7256 after #7251
2017-11-29 15:38:24 +01:00
095eba0aa3
[tx-robot] updated from transifex
2017-11-29 01:10:12 +00:00
0c45778219
Fix silent conflicts due to merging #7256 after #7251
...
Although #7256 was merged cleanly some of the changes really conflicted
with those introduced by the last commit of #7251 , and this broke the
appearance of the author row of comments. This commit fixes those silent
conflicts and restores the appearance of the author row.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-28 02:35:39 +01:00
a0ce2c1204
[tx-robot] updated from transifex
2017-11-28 01:09:52 +00:00
e428ef9d75
Merge pull request #7256 from nextcloud/fix-cursor-for-avatar-and-user-names-in-comments
...
Fix cursor for avatar and user names in comments
2017-11-27 15:14:40 +01:00
cfae590ac9
Merge pull request #7266 from nextcloud/fix-input-field-not-disabled-while-a-comment-is-being-sent
...
Fix input field not disabled while a comment is being sent
2017-11-27 13:40:03 +01:00
7bb42438fa
Merge pull request #7280 from nextcloud/fix-working-icon-position-when-sending-or-deleting-a-comment
...
Fix working icon position when sending or deleting a comment
2017-11-27 12:19:21 +01:00
c5446ebd9a
Merge pull request #7251 from nextcloud/contact-menu-position-fix
...
Fixed contact menu position on comments
2017-11-27 12:14:30 +01:00
d15ca9ffaf
Replace with non-deprecated JS call
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-11-27 11:53:24 +01:00
4af12dcab1
Fix unit tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 08:50:44 +01:00
011e05574f
that has since been deleted, ID to node
...
You were mentioned in a group chat by a user that has since been deleted
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 08:50:39 +01:00
ea4414f9bc
Disable contacts menu for mentions to current user in comment messages
...
The contacts menu is not shown for avatars and user names in the author
row if they represent the current user. For consistency, and because the
contacts menu provides no value when shown for the current user, this
commit also disables the contacts menu for mentions to the current user.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 00:10:53 +01:00
8eb19a278c
Disable contacts menu for mentioned users in comments being composed
...
The contacts menu does not provide too much value for users mentioned in
a message being composed, so it is now disabled in this case.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 00:05:54 +01:00
107952ff00
Fix cursor for author row and avatars in comments
...
When it was on an author row the cursor was shown as a pointer, even if
clicking on the author row itself does nothing. On the other hand,
avatars used the default cursor, even if clicking on them either shows
the contacts menu (in the case of the author row, only when the avatar
is for a different user than the current one) or inserts a mention (for
avatars shown in the list of suggested mentions), depending on the case.
Now, the author row uses the default cursor, and avatars (and their
associated user name) use a pointer cursor if clicking on them will
trigger an action (either showing the contacts menu or inserting a
mention).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-26 23:56:03 +01:00
9bb2bb7870
Show delete working icon at the same position as the delete icon
...
When a comment was being deleted the submit working icon was shown. Now
the submit working icon is kept hidden in that case and a specific
delete working icon, which is shown at the same position as the delete
icon, is used instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-24 16:31:37 +01:00
6e9c0b9085
Show submit working icon at the same position as the submit confirm icon
...
The submit confirm icon is shown as the background image of an
absolutely positioned input element, so the CSS rules for the submit
working icon were modified to match those of the submit confirm icon.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-24 16:30:58 +01:00
5e6d4ad27c
Disable elements while a comment is being deleted
...
When a comment is being deleted the "disabled" class is added to the
comment div, which causes it to look disabled. However, the input
elements and the content editable div were not truly disabled, and thus
it was still possible to interact with them. This commit ensures that
they are properly disabled while the comment is being deleted.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-24 13:17:55 +01:00
bbe00079cc
Fix input field not disabled while a comment is being sent
...
Since the change of the text area to a content editable div the input
field was no longer disabled while a new comment was being sent. It was
caused by still trying to disable the div using the "disabled" property,
which works only on real input fields; when using a content editable div
the way to disable it is by setting "contenteditable" to "false".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-23 14:34:09 +01:00
5591ea6e8b
Fixed alignment of items in comments
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2017-11-23 12:26:22 +01:00
60a73bab1c
Submit comments with Enter and use Shift+Enter for new lines
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-23 03:27:16 +01:00
4eb9c0142d
Fix contacts menu vertical position for comment authors
...
The contacts menu was being shown as "inline-block", which caused the
top of the menu to be aligned to the top of the author row.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-23 02:12:09 +01:00
5d85af79b6
Force breaks on extremely long words
...
If not broken extremely long words overflow their container.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-17 15:10:50 +01:00
6ca4abfc0b
[tx-robot] updated from transifex
2017-11-11 01:10:09 +00:00
ede6499de4
[tx-robot] updated from transifex
2017-11-10 01:09:43 +00:00
79c9439c50
[tx-robot] updated from transifex
2017-11-08 01:09:21 +00:00
f9b7109de3
[tx-robot] updated from transifex
2017-11-07 01:08:57 +00:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 16:56:19 +01:00
bd7d0de86f
Add variable for border-radius
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-11-03 14:08:21 +01:00
7e1e9430b6
[tx-robot] updated from transifex
2017-11-03 01:09:06 +00:00
f1570c2c04
update autoloader
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-11-01 16:30:20 +01:00
e2805f02aa
Merge branch 'master' into autocomplete-gui
2017-11-01 15:37:29 +01:00
2b4b3b1986
adjust jsunit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-11-01 11:44:01 +01:00
ce12cd91db
Merge pull request #6875 from nextcloud/app_autoloaders
...
Move server apps to dedicated autoloader
2017-11-01 11:15:27 +01:00
b3ff9a2248
Merge pull request #6849 from nextcloud/fix-missing-translation-of-personal-calendar-in-activity
...
Fix missing translation of "Personal" calendar in activities
2017-10-31 15:05:26 +01:00
582d2d36ee
fix avatar loading for generic placeholders
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-31 14:42:21 +01:00
d0f2f5f1de
remove more vendor-imported files that aren't necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-31 14:06:16 +01:00
bcfac75b06
simplify registration of manager in server container
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-31 13:55:03 +01:00
4b24dea6c7
only ship minimized js files
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-31 12:28:22 +01:00
d5f1cef642
fix comment sorter
...
background: we have a flat hierarchy of comments, not a tree. therefore we
can also remove again the unnecessary additions.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-30 15:59:43 +01:00
61db8615f4
preserve line breaks
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-30 11:10:04 +01:00
ca72c0150b
configurable amount of autocomplete results in comments
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-27 13:50:38 +02:00
bd951e926f
avatar css fixes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-27 12:34:24 +02:00
eace507043
apply our theming
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-27 00:32:47 +02:00
aa2fd30775
autocomplete on demand
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-26 15:25:24 +02:00
112b0d57a8
Comments Autoloader
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-10-24 20:40:11 +02:00
43e498844e
Use ::class in test mocks
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-10-24 17:45:32 +02:00
1860190305
[tx-robot] updated from transifex
2017-10-24 00:08:45 +00:00
28016a2a70
Box-shadow does not need vendor prefix anymore
...
https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
http://caniuse.com/#search=box-shadow
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-10-23 20:14:31 +02:00
fb40afc4d4
enable autocomplete when editing comments
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-23 18:00:39 +02:00
eb8f1247fe
fix unstable comment order
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-23 15:37:36 +02:00
143ff6a622
Add a doc why this should not be removed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-23 12:35:55 +02:00
de8a475b0b
fix contactsmenu-popup
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:14:34 +02:00
ccbcce978f
convert mentions after save to the plain format we use
...
also ensures proper rendering, even of edited comments
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:14:34 +02:00
8d9f485b35
when writing a comment, render mentions as they'd appear anywhere
...
i.e. avatar with displaymenu and contactsmenu-popover
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:14:33 +02:00
ec5607544c
turn textarea to contenteditable div
...
we will need it for nice formatting of the mentioned user
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:14:33 +02:00
d1afbedc5f
setup atwho autocomplete
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:14:33 +02:00
8e60a2bd28
add At.js and dependencies
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:14:33 +02:00
04fafdd505
fix class name in info.xml
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:13:37 +02:00
8722458d2a
ensure that sorting is stable
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:13:37 +02:00
fd6daf8d19
AutoCompletion backend
...
* introduce a Controller for requests
* introduce result sorting mechanism
* extend Comments to retrieve commentors (actors) in a tree
* add commenters sorter
* add share recipients sorter
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-22 14:13:32 +02:00
436daf92e5
[tx-robot] updated from transifex
2017-10-07 00:08:31 +00:00
3d981c0d40
[tx-robot] updated from transifex
2017-10-04 00:08:27 +00:00
8be053516b
[tx-robot] updated from transifex
2017-09-30 00:08:25 +00:00
e5d39e63d1
[tx-robot] updated from transifex
2017-09-28 00:08:36 +00:00
10c7ecb5e9
Use the wrapper to get the parameters which was added in #6369
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-19 15:01:43 +02:00
5ce3c7003b
[tx-robot] updated from transifex
2017-09-13 00:08:12 +00:00
521ede8f5f
Allow translations of the comments activity in the emails too
...
Message and object data is not available on emails atm,
so we can not use them either...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-05 18:10:32 +02:00
7b8bd8188e
[tx-robot] updated from transifex
2017-08-25 00:08:59 +00:00
6b978ebd29
[tx-robot] updated from transifex
2017-08-19 00:08:26 +00:00
c9612b9324
[tx-robot] updated from transifex
2017-08-11 00:08:20 +00:00
8549fcf6e4
[tx-robot] updated from transifex
2017-08-09 00:08:20 +00:00
201bbb962c
Fix Comments
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-08-01 08:20:16 +02:00
d95b46ffb7
[tx-robot] updated from transifex
2017-07-24 00:08:01 +00:00
ce7c62d9bb
[tx-robot] updated from transifex
2017-07-22 00:08:07 +00:00
125767265d
[tx-robot] updated from transifex
2017-07-17 00:08:02 +00:00
a23cdd04bb
[tx-robot] updated from transifex
2017-07-15 00:08:54 +00:00
3865c77279
[tx-robot] updated from transifex
2017-07-14 00:08:37 +00:00
261513b04a
[tx-robot] updated from transifex
2017-07-13 00:08:31 +00:00
13295c2d1d
[tx-robot] updated from transifex
2017-07-12 00:08:43 +00:00
cf8db31bce
[tx-robot] updated from transifex
2017-07-09 00:08:31 +00:00
b4deba2078
Merge pull request #5483 from nextcloud/issue-5075-png-files-for-activity-emails
...
Use PNGs for icons in activity emails
2017-07-07 11:05:00 +02:00
146c699eb4
[tx-robot] updated from transifex
2017-06-21 00:08:15 +00:00
90fa27694a
Use PNG version of the icons for shipped activities
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-20 13:48:51 +02:00
26d6c4a64a
[tx-robot] updated from transifex
2017-06-17 00:08:26 +00:00
74654288e6
[tx-robot] updated from transifex
2017-06-16 00:08:44 +00:00
7a269ae872
[tx-robot] updated from transifex
2017-06-15 00:08:40 +00:00
dc61fb999d
[tx-robot] updated from transifex
2017-06-14 00:08:39 +00:00
ea64cb0028
[tx-robot] updated from transifex
2017-06-13 00:08:22 +00:00
a74901fce1
[tx-robot] updated from transifex
2017-06-08 00:08:26 +00:00
bb884c341f
[tx-robot] updated from transifex
2017-06-06 00:08:45 +00:00
8801b68d45
[tx-robot] updated from transifex
2017-06-01 00:08:38 +00:00
b9b7f8bede
[tx-robot] updated from transifex
2017-05-30 00:08:44 +00:00
4be17dff0f
[tx-robot] updated from transifex
2017-05-29 00:08:33 +00:00
6cc26efbc5
[tx-robot] updated from transifex
2017-05-24 00:08:22 +00:00
9c8a838624
[tx-robot] updated from transifex
2017-05-23 00:08:29 +00:00
3ec9d91bd0
Split multi-author entries
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-22 10:39:49 +02:00
bc8fbc1a67
Bump app versions as well
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-22 10:35:25 +02:00
fdfe8f7f15
Adjust version requirement
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-22 10:32:05 +02:00
15f7fe022b
Merge pull request #4554 from nextcloud/pointer-cursor-on-clickable-user
...
Make it clear that you can now click on usernames
2017-05-16 16:29:09 +02:00
fb78774eb8
[tx-robot] updated from transifex
2017-05-10 00:08:31 +00:00
0db3a413b3
Fix mentioned user not clickable after posting or editing a comment
...
The contactsMenu plugin was called on avatar elements from
_postRenderItem, which is called when a new comment is added to the
collection. Due to this contactsMenu was not called when messages were
edited; when a new comment is posted _postRenderItem is called, but at
that time the "mentions" attribute is not filled yet, so "@username" is
not replaced by avatars in the message and thus contactsMenu has no
avatars to be called on.
Calling contactsMenu was moved to a new method, _postRenderMessage,
which is called from _postRenderItem and from the success callback when
fetching the model in _onSubmitSuccess (which replaces "@username" by
avatars in the message after posting or editing a comment).
Fixes #4555
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-05-08 22:24:33 +02:00
002018d8ad
Add missing unit tests for comments with mentions
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-05-08 21:55:22 +02:00
2152d5f1f6
[tx-robot] updated from transifex
2017-05-01 00:07:32 +00:00
5bc593a92c
Make it clear that you can now click on usernames
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-27 15:33:16 +02:00
6d7714f182
fix CommentsTabsView js test
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-04-26 09:28:15 +02:00
897bd5cfef
add contactsmenu popover to comments
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-04-26 09:28:14 +02:00
e5fe41e16b
[tx-robot] updated from transifex
2017-04-26 00:07:43 +00:00
5be1010d45
Fix invalid character
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-25 11:06:27 +02:00
4004e39f75
Move systemtags and comments to new accesslist functions
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-04-20 14:34:28 +02:00
adf316c3af
[tx-robot] updated from transifex
2017-04-20 00:07:36 +00:00
c40b7acb09
[tx-robot] updated from transifex
2017-04-18 20:47:45 +00:00
df2235c71f
[tx-robot] updated from transifex
2017-04-17 00:07:33 +00:00
0f96d5a641
[tx-robot] updated from transifex
2017-04-14 00:07:36 +00:00
f984cf0987
[tx-robot] updated from transifex
2017-03-30 00:07:41 +00:00
6309b9ec1d
[tx-robot] updated from transifex
2017-03-28 00:07:53 +00:00
d9ebc2626f
[tx-robot] updated from transifex
2017-03-27 00:07:55 +00:00
0981f9a18a
[tx-robot] updated from transifex
2017-03-26 01:07:03 +00:00
bdd71b6081
Merge JS for comments
...
Shaves off 6 requests.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-03-24 19:49:43 +01:00
40228c0c2b
added quit option in commentstabview.js
...
added quit option in notif in app.js
added quit option in notif in file-upload.js
added quit option in notif in fileinfomodel.js
added quit option in notif in filelist.js
added quit option in notif in filelist.js
added quit option in notif in tagsplugin.js
added quit option in notif in statusmanager.js
added quit option in notif in external.js
added quit option in notif in versionstabview.js
added quit option in notif in notification.js
changes according to the latest review.
timeout removed since there is a button to close it
translation capability added
typo fixed
test files updated
small errors fixed
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-23 13:12:29 -06:00
9e1e7dac47
[tx-robot] updated from transifex
2017-03-18 01:07:50 +00:00
37fcc41004
[tx-robot] updated from transifex
2017-03-12 01:08:05 +00:00
d4200a08cc
Get the user folder of the correct user
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-03-09 21:07:37 +01:00
53195b156c
[tx-robot] updated from transifex
2017-03-02 16:48:52 +00:00
aecec74a04
[tx-robot] updated from transifex
2017-03-01 01:07:42 +00:00
556b958af2
[tx-robot] updated from transifex
2017-02-25 01:25:07 +00:00
47c6a8019f
[tx-robot] updated from transifex
2017-02-16 01:07:44 +00:00
41276f720b
[tx-robot] updated from transifex
2017-02-15 01:07:29 +00:00
c5dffc465c
Merge pull request #3472 from nextcloud/enable-avatars-always
...
Always enable avatars
2017-02-14 09:22:02 -06:00
7113af3f91
[tx-robot] updated from transifex
2017-02-14 01:07:20 +00:00
200a28255e
Always enable avatars
...
* we introduced this setting in the begining because our
avatar support caused some performance issues, but we
fixed them and should only provide one way how Nextcloud
looks
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-02-13 17:53:33 -06:00
5e4bbb394c
[tx-robot] updated from transifex
2017-02-07 01:08:50 +00:00
b946ec9d6c
[tx-robot] updated from transifex
2017-02-02 01:07:05 +00:00
1952560ac7
[tx-robot] updated from transifex
2017-02-01 01:06:57 +00:00
05e3aa491a
[tx-robot] updated from transifex
2017-01-26 01:07:15 +00:00
30e9d67ee9
[tx-robot] updated from transifex
2017-01-24 01:07:14 +00:00
d0c6179ec1
[tx-robot] updated from transifex
2017-01-21 01:07:47 +00:00
c35ea15916
[tx-robot] updated from transifex
2017-01-11 15:20:22 +00:00
bb84db02cb
Cleanup comment tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-09 12:03:34 +01:00
e675c2a66c
Set the comment link on render instead of creation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-09 11:18:33 +01:00
4f9ff96f79
[tx-robot] updated from transifex
2017-01-09 08:24:58 +00:00
2e0cf21f7f
[tx-robot] updated from transifex
2017-01-04 12:09:43 +00:00
acad4ba93e
[tx-robot] updated from transifex
2017-01-03 01:07:46 +00:00
fdf10e242d
Merge pull request #2850 from nextcloud/downstream-26603
...
Fixed size issues on main detail view and disappearing of share recipients (#26603 )
2017-01-02 21:19:43 +01:00
5c50df72b7
[tx-robot] updated from transifex
2017-01-01 01:07:30 +00:00
b399ad2fee
[tx-robot] updated from transifex
2016-12-28 01:07:41 +00:00
754760fdbe
mention property to follow same style
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-12-23 17:01:58 +01:00
969c19b2e9
Fixed size issues on main detail view and disappearing of share recipients ( #26603 )
...
* fixed size issues on main detail view and disappearing of share recipients
* Changes due to code comments
* Moved reloadProperties() to FileInfoModel
* Solved Scrutinizer issues
* Bugfix: undefined value used on error
* check if options are set for FileInfoModel.initialize()
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-12-23 16:56:55 +01:00
fe9a38d5b5
[tx-robot] updated from transifex
2016-12-21 01:07:18 +00:00
f50252c7c1
[tx-robot] updated from transifex
2016-12-20 12:02:31 +00:00
6de0eb0b74
Remove leading slash from sharing activity
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-12-15 15:53:48 +01:00
edec1fafe7
Update app versions and requirements
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-12-13 20:41:55 +01:00
0c6c85bafb
[tx-robot] updated from transifex
2016-12-12 01:07:18 +00:00
ea7a69f198
[tx-robot] updated from transifex
2016-12-11 01:07:18 +00:00
7cb99e74db
[tx-robot] updated from transifex
2016-12-10 01:07:15 +00:00
2a647f4d3a
[tx-robot] updated from transifex
2016-12-06 01:07:19 +00:00
dda39728e3
[tx-robot] updated from transifex
2016-12-05 01:07:41 +00:00
181cf9c7f3
[tx-robot] updated from transifex
2016-12-03 01:07:26 +00:00
b2f46bfa04
Adjust all implementations in the server repo
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-12-01 11:35:23 +01:00
4ca7f9c896
[tx-robot] updated from transifex
2016-12-01 01:07:17 +00:00
f075c22c72
[tx-robot] updated from transifex
2016-11-30 14:18:08 +00:00
41dcceeb35
[tx-robot] updated from transifex
2016-11-30 01:07:16 +00:00
0fb912e724
[tx-robot] updated from transifex
2016-11-29 17:57:47 +00:00
a84dacc16f
[tx-robot] updated from transifex
2016-11-29 17:03:24 +00:00
e8ea9a5d27
[tx-robot] updated from transifex
2016-11-29 01:06:47 +00:00
cd9d1f589f
Merge pull request #2237 from nextcloud/rich-strings-and-icons-for-mention-notifications
...
Rich strings and icons for mention notifications
2016-11-28 18:13:54 +01:00
4e682d4113
[tx-robot] updated from transifex
2016-11-28 01:06:56 +00:00
9788cf04ee
[tx-robot] updated from transifex
2016-11-27 01:07:08 +00:00
8f4ec8583d
[tx-robot] updated from transifex
2016-11-26 01:06:57 +00:00
d2489ebee4
Adjust tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-23 11:31:35 +01:00
bfecdd4422
Use the comment icon for the notifications
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-23 11:19:44 +01:00
56cfd0a6e4
Set the rich object string for comment notifications
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-23 11:19:41 +01:00
a02d0975dd
Merge pull request #2154 from nextcloud/comments-activities-update
...
Move comments activities to the new API
2016-11-22 09:56:22 +01:00
97af4f762d
[tx-robot] updated from transifex
2016-11-20 01:06:44 +00:00
041dd937cf
Update test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-18 16:51:50 +01:00
cf205fcaa5
Use the display name for users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-16 12:20:04 +01:00
8105ba9929
Move comments activities to the new API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-16 12:20:03 +01:00
bc1008ac38
Use 11.0 instead 9.2
...
As discussed we're changing the version from 9.2 to 11.0 to make some more sense.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-15 14:45:58 +01:00
8c1cd07de3
[tx-robot] updated from transifex
2016-11-14 01:07:06 +00:00
cfda17d8f3
[tx-robot] updated from transifex
2016-11-10 01:07:14 +00:00
8d7df51a0e
[tx-robot] updated from transifex
2016-11-08 01:06:57 +00:00
ca3616cb58
[tx-robot] updated from transifex
2016-11-05 01:07:14 +00:00
122fbf0092
[tx-robot] updated from transifex
2016-11-02 01:07:09 +00:00
20f45e6fe4
[tx-robot] updated from transifex
2016-11-01 01:06:57 +00:00
6d2d069c17
[tx-robot] updated from transifex
2016-10-31 01:06:55 +00:00
1187a8c183
[tx-robot] updated from transifex
2016-10-30 00:06:56 +00:00
035890aeb1
[tx-robot] updated from transifex
2016-10-29 00:07:14 +00:00
48ce0ef19c
Merge pull request #1926 from nextcloud/fix-comment-mentions-in-activities
...
Fix comment mentions in activities
2016-10-28 22:47:15 +02:00
286482656b
Fix comment mentions in activities
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-28 12:32:10 +02:00
ad597d498d
[tx-robot] updated from transifex
2016-10-28 00:07:11 +00:00
cde7f535bd
Merge pull request #1738 from nextcloud/comments-provide-displaynames-with-mentions
...
comment mentions: show displayname not uid
2016-10-26 14:02:49 +02:00
b12b52b73b
fix JS test and introduce tests for rendering mentions to displaynames
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-25 18:33:59 +02:00
e23a298a81
[tx-robot] updated from transifex
2016-10-25 09:36:09 +00:00
ab3954745c
avoid that all avatars are copied to the author row when editing comments
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-21 22:57:06 +02:00
763a99ec30
consolidate error handling
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 13:56:49 +02:00
bc18a2900e
fix avatar displaying after submit (either edit or new)
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 12:47:53 +02:00
185433967e
display avatar (if enabled) alongside displaynames
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:34:00 +02:00
70bd6cafd4
fix regex
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:34:00 +02:00
b21ce6ee5e
improve regex, fixes replacements of usernames with same trunk
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:34:00 +02:00
0e926efc9b
show displayname not uid in commit mentions
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:34:00 +02:00
5d98ab83e9
resolve displayname via manager and registerable resolvers
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:34:00 +02:00
fea3e20a80
move mention extraction to (I)Comment and report mentions via DAV
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-19 00:33:55 +02:00
943d9737e4
[tx-robot] updated from transifex
2016-10-18 00:06:51 +00:00
96f8f209b9
Merge pull request #1449 from nextcloud/comments-user-mention
...
Notifications for simple @-mentioning in comments
2016-10-17 09:30:47 +02:00
70c7781aa8
apply some polish
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-14 15:36:05 +02:00
1bcd2ca8e3
emit pre-update event for comments
...
* notifications can be cleaned up, no polluted DB
* updating comments will re-notify users or remove notifications, depending on the message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-12 18:06:22 +02:00
675230f86d
Merge pull request #1407 from nextcloud/multiline_comments
...
Bring back multiline comments
2016-10-11 16:17:51 +02:00
dcddd4b9d5
fix textarea submit
2016-10-11 12:33:20 +02:00
0beecbf2c5
[tx-robot] updated from transifex
2016-10-08 00:06:50 +00:00
a9671a4dc2
adjust wording of the notification
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-08 01:17:51 +02:00
a35d4e7b44
remove notifications of deleted comments from the DB
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-08 01:10:49 +02:00
006da9afd7
use different files route/controller
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 17:27:33 +02:00
e1073cf442
Notificacations for simple @-mentioning in comments
...
(WIP) notify user when mentioned in comments
Fix doc, and create absolute URL for as notification link.
PSR-4 compatibility changes
also move notification creation to comments app
Do not notify yourself
unit test for controller and application
smaller fixes
- translatable app name
- remove doubles in mention array
- micro perf optimization
- display name: special label for deleted users, keep user id for users that could not be fetched from userManager
Comment Notification-Listener Unit Test
fix email adresses
remove notification when triggering comment was deleted
add and adjust tests
add missing @license tags
simplify NotificationsController registration
appinfo simplification, php docs
make string easier to translate
adjust test
replace dispatcher-based listeners with a registration method and interface
safer to not pass optional data parameter to setSubject for marking as processed. ID and mention suffices
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
update comment
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 17:11:19 +02:00
fe2116ecf7
Merge pull request #1519 from nextcloud/better-comments-in-activity-sidebar
...
Better comments in activity sidebar
2016-10-05 23:56:10 +02:00
43265befac
Update file header
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-05 14:33:54 +02:00
dba72a48cd
Fix activity rendering plugin name
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-05 14:21:26 +02:00
ed70d4a2dc
Mark the methods as copied
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-05 14:21:26 +02:00
bd0c9489f6
Make sure the CSS rules apply to the activityTabView as well
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-05 14:21:25 +02:00
724cd50e52
Register a ActivityTabView plugin
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-05 14:21:25 +02:00
fe6c9f7f47
Remove resolved FIXME
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-05 14:21:25 +02:00
b8cf2fb58b
Do not shorten comments in the activity sidebar
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-05 14:21:22 +02:00
671f16f706
Add icons to activity navigation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-05 11:38:06 +02:00
c83b3e6bd5
Fix js test
2016-10-04 13:07:44 +02:00
5ca50d9f31
Add autosize to comments input
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-04 13:04:56 +02:00
07a1be2e06
[tx-robot] updated from transifex
2016-10-03 00:12:47 +00:00
6297d201df
[tx-robot] updated from transifex
2016-10-02 00:16:25 +00:00
da03018add
[tx-robot] updated from transifex
2016-10-01 00:08:23 +00:00
99076a8c0d
[tx-robot] updated from transifex
2016-09-30 00:08:13 +00:00
4b873b35b7
[tx-robot] updated from transifex
2016-09-29 00:07:08 +00:00
2eab2ffa22
Merge pull request #1553 from nextcloud/fix-comment-count-translation
...
Fix comment count tooltip
2016-09-28 23:17:05 +02:00
c9c64141ee
Fix comment count tooltip
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-09-28 10:54:37 +02:00
71830b285c
Svgo optimization
...
Signed-off-by: John Molakvoæ <fremulon@protonmail.com>
2016-09-27 20:56:26 +02:00
810f72df46
[tx-robot] updated from transifex
2016-09-27 00:09:46 +00:00
6a873acf46
[tx-robot] updated from transifex
2016-09-22 00:11:32 +00:00
d24e78d1ff
[tx-robot] updated from transifex
2016-09-21 00:09:40 +00:00
70660d0d6c
[tx-robot] updated from transifex
2016-09-20 00:09:37 +00:00
bcc4b5cd0a
[tx-robot] updated from transifex
2016-09-18 00:09:26 +00:00
4fdee00c27
[tx-robot] updated from transifex
2016-09-15 00:12:37 +00:00
7ffadc7e26
[tx-robot] updated from transifex
2016-09-14 00:10:31 +00:00
f5aafdc897
[tx-robot] updated from transifex
2016-09-09 00:09:31 +00:00
b992bf2142
[tx-robot] updated from transifex
2016-09-08 00:10:21 +00:00
1110ef52ed
[tx-robot] updated from transifex
2016-09-07 00:09:25 +00:00
5d48809609
[tx-robot] updated from transifex
2016-09-06 00:09:18 +00:00
8b484eedf0
[tx-robot] updated from transifex
2016-09-05 00:09:10 +00:00
fc02c4a980
[tx-robot] updated from transifex
2016-09-04 00:09:21 +00:00
e7f618ef14
[tx-robot] updated from transifex
2016-09-03 00:09:24 +00:00
ab876619dc
[tx-robot] updated from transifex
2016-09-02 00:09:11 +00:00
80e8d3db35
Use live timestamp on comments tab
2016-09-01 09:02:36 +02:00
4a5cd74fb2
[tx-robot] updated from transifex
2016-09-01 00:09:24 +00:00
28792a010c
Prevent parse error on editing an HTML comment
2016-08-29 14:18:34 +02:00
6d7c5e2265
Merge pull request #903 from nextcloud/allow-disable-comments
...
Revert "Always add activities for comments to the stream"
2016-08-18 16:51:42 +02:00
71d81eef08
Merge pull request #927 from nextcloud/drop-unneeded-statements
...
white-space: pre-wrap is supported on all current browsers
2016-08-18 15:09:43 +02:00
Abijeet
Nextcloud bot
Joas Schilling
rakekniven
Morris Jobke
Arthur Schiwon
Roeland Jago Douma
Daniel Calviño Sánchez
Roeland Jago Douma
Lukas Reschke
Allan Nordhøy
John Molakvoæ (skjnldsv)
Jan-Christoph Borchardt
Georg Ehrke
noveens
Michael Jobst
skjnldsv
Arthur Schiwon
Vincent Petry
Joas Schilling