5cd1880daa
Fix a few RedundantCast
...
Reported by psalm
For #25641
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:00:32 +01:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
2ea3cb7c93
Drop redundant indes
...
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +01:00
e9ae943bba
Properly handle SMB ACL blocking scanning a directory
...
This makes sure that a possible ForbiddenException is properly passed
through the storage as a ForbiddenException and can be catched when
trying to fetch the quota info of a parent folder
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 11:26:22 +01:00
10214fbee0
Merge pull request #25214 from nextcloud/dependabot/composer/phpseclib/phpseclib-2.0.30
...
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30
2021-01-21 10:25:02 +01:00
1e35ece8e5
Fix potential empty result
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 10:09:45 +01:00
6c1e294edd
Compare and store the login name via the event
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 08:50:17 +01:00
831c807eaf
Also fix the username when it changed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 08:46:08 +01:00
76367c5c38
Don't save credentials of another user
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 08:46:07 +01:00
4373afeae1
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-19 21:19:02 +01:00
c1d4f8161b
Migrate internal classes to the OCP db col types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
24d436cb60
Remove unneeded casts that were found by Psalm
...
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521 )
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +01:00
518e91b008
dont offer to edit external config settings if we can't edit them
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-08 15:06:42 +01:00
275f15c1fb
Merge pull request #23261 from nextcloud/enh/external-storage-session-type
...
Expose session based authentication through mount point type
2021-01-07 21:29:13 +01:00
72f16a46e8
Revert "allow using any ldap property as login name when using login credentials"
2021-01-07 14:01:32 +01:00
58f3f5cc28
allow using any ldap property as login name when using external storage login credentials
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-04 19:53:07 +01:00
73c7d0dc81
Bump icewind/streams from 0.7.1 to 0.7.2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-29 09:07:36 +01:00
35e5cc88f0
Expose session based authentication through mount point type
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-21 22:55:06 +01:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
0d42d996d1
Adjust further columns
...
- calendarsubscriptions.lastmodified -> not null
- external_config.value -> allow null
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-09 12:13:33 +01:00
8d962579db
set mountid for personal external storage mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-02 14:25:48 +01:00
fd649afb1f
Remove the deprecated update.php
...
* It was documented as deprecated.
* The app code checker warned about it
* It's been three years
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 13:02:59 +01:00
f771205f5f
Remove unused and deprecated methods from files_external MountConfig
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-10 22:38:10 +01:00
8027dcbc6f
Don't leave cursors open when tests fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
b7be09ab2c
Check if array elements exist before using them
...
It seems that in some recent upgrade here. Not always the entries we
expect are returned. So we should first check if they exist. As to not
spam the log.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-25 22:03:40 +01:00
060286c51a
Merge pull request #23021 from nextcloud/notify-saved-login-auth
...
allow using saved login credentials for notify
2020-10-13 19:39:31 +02:00
9bdf0eed65
Merge pull request #23020 from nextcloud/disable-notify-self-check
...
add option to disable notify self check
2020-10-08 11:27:08 +00:00
ea80d1d68f
also give storage backend it's change to manipulate the config
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-07 15:43:44 +02:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
6fed17a342
allow using saved login credentials for notify
...
when only the user is provided, we use to provided user to try and get saved login credentials
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-23 15:49:27 +02:00
a79f9605b4
add option to disable notify self check
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-23 15:16:16 +02:00
43b3049a4f
improve handling of out of space errors for smb
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-17 17:23:33 +02:00
99c9423766
Remove @suppress SqlInjectionChecker
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 15:53:56 +02:00
2004ae4603
Set delimiter so that the CommonPrefixes response can properly be determined
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 08:11:55 +02:00
fc96fa0cc7
fix s3 doesDirectoryExist check for empty directories
...
if a directory is empty, only the 'marker' object `/` exists.
since not all s3 implementations return just the prefix when listing objects by prefix,
when listing objects by the folder prefix, nothing will be returned if the directory is empty.
by not including the trailing slash in the prefix, the folder marked will always be returned if it exists
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-10 08:11:55 +02:00
bb06b6cce4
Fix reading empty files from objectstorage
...
Since we try to do range requests this will fail hard.
However since empty files are not that interesting to read anyways we
just read from an emptry memory stream.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-09 20:45:13 +02:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
ac73982395
Merge pull request #21734 from nextcloud/external-s3-no-touch
...
disable touch to update mtime for external s3 storage
2020-08-20 16:07:59 +02:00
fedf9c69d9
Use matching parameter names form interfaces and implementations
...
Found by Psalm 3.14.1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
...
Ref #21787
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +02:00
6f8147b18f
Fix some MissingDocblockType or InvalidDocblock warnings.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 15:10:48 +02:00
afd52c6b12
Remove setCustomJs of the files_external FrontendDefinitionTrait
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 21:49:50 +02:00
ba3a855ad8
Remove unused method uploadFile
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-13 08:02:28 +02:00
0b0cc48c88
Move event listener to dedicated class
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-30 12:04:56 +02:00
d1bd3ba594
update saved credentials on password change
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 11:43:15 +02:00
c864e5dfc2
remove saved credentails if the user no longer has any storage configured using them
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 11:43:15 +02:00
7ad0f66fc4
Only save login credentials in database once there is an external storage that needs it
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 11:43:15 +02:00
638e9438a9
Merge pull request #21728 from nextcloud/bugfix/noid/s3-external-mtime-cache
...
Reuse cache for directory mtime/size if filesystem changes can be ignored
2020-07-15 18:26:48 +02:00
cbbbbee8b1
Merge pull request #21785 from nextcloud/techdebt/noid/remove-classmap-in-files_external
...
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH us…
2020-07-13 16:47:12 +02:00
e357d46863
filter files containing a hash in the path for ftp storages
...
the php ftp streamwrapper doesn't handle hashes correctly and will break when it tries to enter a path containing a hash.
By filtering out paths containing a hash we can at least stop the external storage from breaking completely
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-10 14:18:40 +02:00
Roeland Jago Douma
dependabot-preview[bot]
Julius Härtl
Morris Jobke
Joas Schilling
Christoph Wurst
Robin Appelman
blizzz
Vincent Petry
Daniel Kesselberg