mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
55,076 Commits 349 Branches 696 Tags 1.6 GiB
Commit Graph

18235 Commits

Author SHA1 Message Date
Julius Härtl b51746212e
Add base renderAs template 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-08-04 09:48:43 +02:00
Morris Jobke 489fecac32
Merge pull request #22057 from nextcloud/fix/20009/contactsmenu-limit-users 
contactsmanager shall limit number of results early
 2020-08-03 15:15:46 +02:00
John Molakvoæ (skjnldsv) 1a1b3e20e4 Fix unified search 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-08-03 11:26:03 +00:00
Georg Ehrke 0fad921840
Add user-status app 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-07-31 16:45:27 +02:00
Arthur Schiwon 7c56283c3c
contactsmanager shall limit number of results early 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-07-31 12:42:17 +02:00
Morris Jobke e19bbce7f6
Merge pull request #22060 from nextcloud/trashbin-s3-fixes 
Object store trashbin fixes
 2020-07-31 10:10:33 +02:00
Robin Appelman 6cb550d567
fix instanceof ISettings check for activity settings 
boolean logic is hard

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-30 17:53:14 +02:00
Robin Appelman 8c3b22859c
dont update mimetype when moving to trash 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-30 16:11:45 +02:00
Joas Schilling a32e6a7958
Merge pull request #21993 from nextcloud/fix/lower_route_not_found_level 
Log the route not found exception on a lower level
 2020-07-30 10:59:31 +02:00
Morris Jobke 084f5063f2
Deprecate BeforeUserRemovedEvent because it can't be triggered in all cases 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-30 10:21:08 +02:00
Morris Jobke 4a7d7e446f
User.php: rename of old dispatcher to legacyDispatcher 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-30 10:21:08 +02:00
Morris Jobke 36ee37ec0a
Migrate OC_Group post_removeFromGroup hook to actual event object 
Ref #14552

This adds a BeforeUserRemovedEvent to the LDAP backend because it was missing. It's not really before, but we don't have the before state.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-30 10:21:08 +02:00
Joas Schilling 5993bd45f3
Correctly remove usergroup shares on removing group members 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-30 09:47:31 +02:00
Joas Schilling 2af77b2ed7
Merge pull request #22034 from nextcloud/bugfix/noid/parse-url-returns-null 
parse_url returns null in case a parameter is not found
 2020-07-29 18:07:50 +02:00
Morris Jobke 7e28286e9d
Merge pull request #21542 from nextcloud/activity-notifications 
basic settings system for activity notifications
 2020-07-29 15:36:38 +02:00
Joas Schilling 9127731c52
parse_url returns null in case a parameter is not found 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-29 08:32:20 +02:00
Nextcloud bot 1f42a8b5cb
[tx-robot] updated from transifex 2020-07-29 02:16:52 +00:00
Joas Schilling bab4fb98eb
Fix overwriteService() for apps 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-28 09:38:43 +02:00
Elijah Martin-Merrill 56ed563b0c fix memory leak caused by not destroying image in Preview/Generate.php 
Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>
 2020-07-27 10:52:44 -04:00
Nextcloud bot 4cac0f6895
[tx-robot] updated from transifex 2020-07-27 02:16:32 +00:00
Nextcloud bot 34c3d0a977
[tx-robot] updated from transifex 2020-07-25 02:16:36 +00:00
Roeland Jago Douma b57019bcaa
Log the route not found exception on a lower level 
This should be logged but it is not that critical to wanner level 3

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-24 15:39:53 +02:00
Morris Jobke 15561b4e0a
Merge pull request #21977 from onehappycat/issue_21960 
Ignore whitespace in sharing by mail
 2020-07-24 13:37:36 +02:00
Robin Appelman c8427781b4
implement old settings interface 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-24 13:03:35 +02:00
Julius Härtl e1b696929f
Move NotFoundResponse to a proper TemplateResponse 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-24 08:58:14 +02:00
Nextcloud bot c4a6666e6c
[tx-robot] updated from transifex 2020-07-24 02:16:52 +00:00
onehappycat e04525c186 Ignore whitespace in sharing by mail 
Signed-off-by: onehappycat <one.happy.cat@gmx.com>
 2020-07-23 22:20:18 +02:00
Morris Jobke ce314d9484
Merge pull request #21814 from nextcloud/techdebt/noid/federated_share_added-into-typed-event 
Move federated_share_added into a typed event
 2020-07-23 21:42:48 +02:00
Morris Jobke 173f8abc7e
Merge pull request #21628 from nextcloud/external-to-s3-trashbin-fix 
fix moving files from external storage to object store trashbin
 2020-07-23 21:35:18 +02:00
Robin Appelman c8cf2e8a5b
fix renameFromStorage messing with folder mimetype 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 20:31:35 +02:00
Simon Spannagel 1fc54d3479 Fix header logo size in notification mails 
Signed-off-by: Simon Spannagel <simonspa@kth.se>
 2020-07-23 17:52:21 +02:00
Robin Appelman ad7798f9c9
use exceptions for error signaling in writeStream 
this remove the ambiguity when writing zero length files

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:52 +02:00
Robin Appelman 5949849322
fix moving files from external storage to object store trashbin 
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.

By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:44 +02:00
Roeland Jago Douma e0cc95f3aa
Allow user backends to specify a custom logout url 
* Allows SSO backends to do a global logout

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-23 10:42:40 +02:00
Morris Jobke 0763a17332
Move federated_share_added into a typed event 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 08:33:17 +02:00
Nextcloud bot 99d0ba5f7e
[tx-robot] updated from transifex 2020-07-23 02:17:03 +00:00
Morris Jobke 346f647962
Merge pull request #21870 from nextcloud/fix/bootstrap-context-container-interfaces 
Make the bootstrap context return ContainerInterface instances
 2020-07-22 20:38:50 +02:00
Morris Jobke 7b250db60b
Merge pull request #21658 from nextcloud/trashbin-configurable-size 
allow admin to configure the max trashbin size
 2020-07-21 20:46:43 +02:00
Morris Jobke 7870ca0663
Use the proper IAppContainer and IServerContainer type hints to know which code runs with which container 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-21 20:44:05 +02:00
Christoph Wurst e029055e76
Make the bootstrap context return ContainerInterface instances 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-21 20:42:24 +02:00
Robin Appelman 5eb1e75e24
build autoloader 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-21 19:26:59 +02:00
Robin Appelman aa051875f9
improve default notification fallback 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-21 17:40:22 +02:00
Robin Appelman fb5ae20722
basic settings system for activity notifications 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-21 17:12:38 +02:00
Morris Jobke 09e6b26bdd
Merge pull request #21875 from nextcloud/techdebt/deprecate-ilogger 
Deprecate ILogger in favor of the PSR-3 logger
 2020-07-20 16:45:14 +02:00
Morris Jobke 9ae75a3ca9
Merge pull request #21850 from nextcloud/techdebt/noid/register-alternative-logins 
Allow to register AlternativeLogin on RegistrationContext
 2020-07-20 14:20:03 +02:00
Morris Jobke 9271d65641
Merge pull request #21880 from nextcloud/webauthn/discourage_user_auth 
Discourage webauthn user interaction
 2020-07-20 09:24:08 +02:00
Morris Jobke a1a1349977
Merge pull request #21891 from nextcloud/techdebt/undeprecate-iappcontainer-iservercontainer 
Undeprecate IAppContainer and IServerContainer
 2020-07-19 22:16:59 +02:00
Nextcloud bot d925c45373
[tx-robot] updated from transifex 2020-07-19 02:17:06 +00:00
Christoph Wurst 22ff03969e
Undeprecate IAppContainer and IServerContainer 
With 4152216bd8 these two interfaces got
deprecated with the reasoning that we only need the base PSR interface.
However, there are cases where in Nextcloud you still want to have a
specific container (the one for the app vs the one for the server) when
you either have a container injected or query one from a container.

With a single interface that would not be possible. So it's probably
better if we leave the two interfaces, but only have them extend the PSR
interface. IContainer – with the custom methods – shall still be phased
out, but the two other sub interfaces can stay for tagging purposes.
Tagging means that no methods shall be added.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-17 10:17:18 +02:00
Christoph Wurst 9bc6a8437d
Deprecate the query mothod on the server container 
The interface method has already been deprecated, but if some code uses
the concrete type instead, the deprecation is not shown (by phpstorm),
so I think it's better to have this method tagged as well.

The "fix" for this deprecation is to simply use `get` instead of
`query`. Right now this will work 100% the same, but the goal is to slim
down the interface and only use what PSR-11 offers.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-17 08:05:07 +02:00
Nextcloud bot 2c79083f27
[tx-robot] updated from transifex 2020-07-17 02:17:12 +00:00
Joas Schilling cae849bcf9
Merge pull request #21869 from nextcloud/techdebt/noid/add-constants-for-magic-strings 
Add constants for the magic strings of template rendering
 2020-07-16 22:00:57 +02:00
Roeland Jago Douma 884f3d009a
Discourage webauthn user interaction 
Else people might have the feeling this is also doing 2FA. And since it
is only prefered it can be ignored and hacked around.

Once we have proper 2FA with webauthn in one go this probably needs to
be revisted.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-16 21:10:07 +02:00
Roeland Jago Douma dfcb49b9b7
Merge pull request #21873 from nextcloud/techdebt/deprecate-server-container-getters 
Deprecate the server container getters
 2020-07-16 20:27:36 +02:00
Christoph Wurst 8a433a7226
Deprecate ILogger 
The logger service was always intended to follow the PSR-3 interface.
It's time to embrace this and switch over to the "official" API,
hence this custom interface can be slowly phased out.

With Nextcloud 20 the logger also got support for
* App id filled out automatically
* Exceptions handling (as replacement for logException)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 19:19:23 +02:00
Christoph Wurst c889021334
Add a scoped PSR logger for apps 
Just like for ILogger we should have a version that has the app ID
pre-set for the context (unless overwritten) so that each log entry can
be traced back to the app that produced it.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 19:11:56 +02:00
Christoph Wurst efd2835b23
Deprecate the server container getters 
Service locators are an anti pattern. These getters just make it more
appealing to do the wrong thing. If you want to locate a service the bad
way, just use the `get` method on a container – it will do the same in
also one line of code.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 18:59:56 +02:00
Joas Schilling 49970639fa
Add constants for the magic strings of template rendering 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-16 15:47:28 +02:00
Joas Schilling 0dfcc132ca
Allow to register AlternativeLogin on RegistrationContext 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-16 14:20:24 +02:00
Christoph Wurst 4152216bd8
Use PSR container interface and deprecate our own abstraction 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-16 13:35:45 +02:00
Nextcloud bot 89fe5415f8
[tx-robot] updated from transifex 2020-07-16 02:19:30 +00:00
Morris Jobke c4b53538af
Better event description for BeforeTemplateRenderedEvent in files and files_sharing 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-15 20:15:51 +02:00
Morris Jobke fc41810d2f
Merge pull request #21822 from nextcloud/enh/events/additionalscripts 
Add real events to load additionalscripts
 2020-07-15 19:50:01 +02:00
Morris Jobke cc258ad51a
Merge pull request #21844 from bladewing/bladewing-harden-against-mimetype-mismatch 
Avoid substr() error when strpos returns false
 2020-07-15 19:33:09 +02:00
Roeland Jago Douma 7d7ba61625
Add real events to load additionalscripts 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-15 14:07:18 +02:00
Christoph Wurst b9a911f0b3
Deprecate the internal Symfony dispatcher adapter 
This type is not known on the public API, yet we should make sure that
any usage of this class is noticed and migrated as soon as possible.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-15 13:57:35 +02:00
lui87kw 3fe3d1fca3 Extra white space to follow other ifs 
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
 2020-07-15 10:18:47 +02:00
bladewing 7dafd5831f Avoid substr() error when strpos returns false 
"Exception: substr() expects parameter 3 to be int, bool given" can occur on Line 378 $mimePart = substr($icon, 0, strpos($icon, '-'));
This happens, when '-' is not found and strpos returns false instead of an int.
When this occurs, e.g., Activity hangs.

Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
 2020-07-15 10:18:47 +02:00
Julius Härtl 35bdb998ef
Dashboard strict typing 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:12 +02:00
Julius Härtl 31a1494529
Add load method for apps to bootstrap their panels 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:11 +02:00
Julius Härtl b71de68f43
Cleanup public api methods 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:11 +02:00
Julius Härtl f7c04b0415
Deprecate panel register event right away but keep it for not breaking backward compatible apps 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:28:11 +02:00
Julius Härtl 81e5593133
Move to lazy panel registration during registration context 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:27:57 +02:00
Julius Härtl 86a7d1641a
Update autoloader 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:24:52 +02:00
Julius Härtl 544fcdb549
Deprecate old dashboard API 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:24:51 +02:00
Julius Härtl 673d70dfc5
Add new dashboard public API 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:24:50 +02:00
Morris Jobke 157c652762
Merge pull request #21825 from nextcloud/fix/appframework/services 
Fix AppFramework services
 2020-07-14 17:07:38 +02:00
Morris Jobke fba64a972f
Merge pull request #21812 from nextcloud/feature/noid/app-bootstrap-without-app.php 
Do not load app.php if Application implements IBootstrap
 2020-07-14 17:06:06 +02:00
Roeland Jago Douma dca2469462
Merge pull request #21833 from nextcloud/docfix/noid/irequest_getHeader 
Fix PHPDoc of IRequest::getHeader
 2020-07-14 16:43:09 +02:00
Morris Jobke 6f167f0dd1
Merge pull request #21828 from nextcloud/enhancement/lazy-bootstrap-registration-delegation 
Delegate bootstrap registration lazily
 2020-07-14 16:37:04 +02:00
Roeland Jago Douma fa9dfd83c9
Fix AppFramework services 
* We can't just register an alias as the services need the appId to be
  injected. if we just register an alias this blows up since the main
  container doesn't have the appId.
* Moved the Authtokens over to show the PoC works

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-14 16:01:14 +02:00
Morris Jobke d9cc2f0213
Do not load app.php if Application implements IBootstrap 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-14 15:55:23 +02:00
Christoph Wurst f03f88b437
Delegate bootstrap registration lazily 
* Keep the registration context
* Expose the context object for other components
* Ensure registration is only run once

Search providers are migrated for demonstration.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-14 15:33:32 +02:00
Georg Ehrke 3bdfb380fc
Fix PHPDoc of IRequest::getHeader 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-07-14 14:20:43 +02:00
Christoph Wurst ab303dddcd
Make the PSR-3 adapter exception-aware 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-14 09:38:51 +02:00
Morris Jobke cbbbbee8b1
Merge pull request #21785 from nextcloud/techdebt/noid/remove-classmap-in-files_external 
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH us…
 2020-07-13 16:47:12 +02:00
Morris Jobke 7569bc15bd
Merge pull request #21789 from nextcloud/ftp-filter-hash 
filter files containing a hash in the path for ftp storages
 2020-07-13 10:56:16 +02:00
Robin Appelman e357d46863
filter files containing a hash in the path for ftp storages 
the php ftp streamwrapper doesn't handle hashes correctly and will break when it tries to enter a path containing a hash.

By filtering out paths containing a hash we can at least stop the external storage from breaking completely

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-10 14:18:40 +02:00
Nextcloud bot 7868d4e3b2
[tx-robot] updated from transifex 2020-07-10 02:16:48 +00:00
Morris Jobke 065ef14cb0
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH usage in files_external 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-10 00:02:59 +02:00
Roeland Jago Douma 10d862e243
Merge pull request #21759 from nextcloud/enh/lazy_subscription 
Make the subscription registry lazy
 2020-07-09 15:43:48 +02:00
Roeland Jago Douma 725872c23a
Make the subscription registry lazy 
This will allow to do lazy registration here which should allow for
loading less (or at least only when needed!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-09 12:21:06 +02:00
Robin Appelman 70906a359f
ensure home storage is initialized on first setup 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-09 11:14:45 +02:00
Roeland Jago Douma 43efac345e
Use the correct mountpoint to calculate 
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-09 11:14:44 +02:00
Morris Jobke 9e88456768
Fix regression in return value of OC_Util::checkDataDirectoryPermissions due to #21761 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-09 09:29:44 +02:00
Roeland Jago Douma f3768e2a2a
Merge pull request #21761 from nextcloud/fix/permission_check_translation 
Kill another unneeded translation
 2020-07-09 08:28:57 +02:00
Nextcloud bot 5864501d3f
[tx-robot] updated from transifex 2020-07-09 02:17:35 +00:00
Roeland Jago Douma c7d9636e82
Kill another unneeded translation 
We should only translate things when we actually need them.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-08 21:47:16 +02:00
Roeland Jago Douma ce5cb5ac33
Merge pull request #21758 from nextcloud/fix/routes/defaults 
Fix supporting defaults for routes
 2020-07-08 20:42:28 +02:00
Roeland Jago Douma 3f447b9c8c
Fix supporting defaults for routes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-08 19:52:45 +02:00
Roeland Jago Douma 76eb793f9b
Only translate if we need the string 
This translation was done in each call. Over and over and over again.
All while it was probably not used in 99.99999% of the cases. A small
gain. But still.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-08 15:12:01 +02:00
Roeland Jago Douma 7a92113fec
Merge pull request #21643 from nextcloud/enh/no_routeactionhadler_inits 
Do not create a RouteActionHandler object for each route
 2020-07-08 09:28:05 +02:00
Morris Jobke abe222c979
Merge pull request #21739 from nextcloud/techdebt/14552/migrate-OC-initSession 
Remove hook for initSession
 2020-07-08 09:02:37 +02:00
Nextcloud bot 8ca1208bbb
[tx-robot] updated from transifex 2020-07-08 02:16:58 +00:00
Morris Jobke 8d2d051841
Remove hook for initSession 
It's not used anyways and allowed to manipulate the state of the session. Also removed the code handling this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-07 21:44:36 +02:00
Robin Appelman 050e2fe346
allow admin to configure the max trashbin size 
this allows an admin to configure the max trashbin size instead of always relying on the users quota.

The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-07 14:45:08 +02:00
Roeland Jago Douma edc1c77dd9
Do not create a RouteActionHandler object for each route 
This is not required and doesn't allow us to be properly lazy. On top of
it this doesnt allow us to cache the routes (since closures/objects
can't be cached).

This is the first small step into cleaning up the routing we have

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-07 12:33:22 +02:00
Morris Jobke cd7a6276f2
Merge pull request #21676 from J0WI/fix-chmod-on-fd 
Fix chmod on file descriptor
 2020-07-07 09:44:57 +02:00
Morris Jobke 560c485e5d
Merge pull request #21714 from nextcloud/td/remove/getAppFolder 
Remove old deprecated getAppFolder
 2020-07-06 22:36:55 +02:00
Roeland Jago Douma 7d128ebf3e
Remove old deprecated getAppFolder 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-06 22:06:58 +02:00
Holger Hees e70249e089
Update SecurityMiddleware.php 
OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header.

in other areas OC::$WEBROOT is always used together with an /
 2020-07-06 21:34:46 +02:00
Morris Jobke 4e8552929b
Merge pull request #20729 from nextcloud/cleanup/noid/shared-tags-code 
Tags.php and the old sharing mechanism
 2020-07-06 21:30:48 +02:00
Roeland Jago Douma 37b2121ccf
Deprecate registerRoutes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-06 15:15:20 +02:00
Morris Jobke 37856cd377
Cascading effect - more code that now is not used anymore 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-06 14:13:53 +02:00
Morris Jobke e20db42a0c
Tags.php and the old sharing mechanism 
The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-06 14:12:12 +02:00
Morris Jobke e878c0a054
Merge pull request #21074 from jvsalo/shared-lock-multi-release 
Fix releasing a shared lock multiple times
 2020-07-06 14:06:41 +02:00
Morris Jobke fb69d6d195
Merge pull request #21238 from nextcloud/techdebt/noid/deferrable-notification-apps 
Allow notification apps to defer and flush the sending
 2020-07-06 13:50:25 +02:00
Morris Jobke 6c825ee9a0
Merge pull request #21665 from nextcloud/debt/noid/job-list 
Fix wrong phpdoc for execute method
 2020-07-06 11:14:14 +02:00
Morris Jobke b1cdd0dd9b
Use formal type hints instead of informal PHPDoc 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-06 10:13:23 +02:00
Morris Jobke e900f424ce
Merge pull request #21636 from nextcloud/lock-exception-readable-path 
add proper paths to locking exceptions
 2020-07-05 22:37:12 +02:00
Morris Jobke d3d11cb826
Merge pull request #21626 from nextcloud/enhancement/injectible-callables 
Callable parameter injection
 2020-07-05 22:03:12 +02:00
Roeland Jago Douma 4d8b4ef3cc
Merge pull request #21533 from nextcloud/techdebt/noid/dedicated-method-to-get-a-users-language 
Techdebt/noid/dedicated method to get a users language
 2020-07-04 08:56:13 +02:00
Nextcloud bot c52e6c8a47
[tx-robot] updated from transifex 2020-07-04 02:16:15 +00:00
J0WI 356bc50420 Only clear the realpath cache 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-07-03 22:47:13 +02:00
J0WI ea08a01999 clearstatcache() on rmdir 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-07-03 22:42:27 +02:00
J0WI 6ca1599ea4 Fix chmod on file descriptor 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-07-03 20:53:58 +02:00
Joas Schilling 3d559159f0
Allow notification apps to defer and flush the sending 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-03 16:44:43 +02:00
Christoph Wurst 4a3ea04baa
Callable parameter injection 
This is like what we have to DI and classes, but for callables.

The motivating factor is to get rid of *service locators* in the `boot`
method of apps as a new pattern is about to emerge where we have lots of
`query` calls on the app or server container in order to fetch some
services.

With this little helper it's possible to call another (public) method
and magically have everything injected.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-03 14:37:46 +02:00
Joas Schilling db8267db26
Use the new method everywhere 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-03 10:59:43 +02:00
Daniel Kesselberg 9b10d35477
Fix wrong phpdoc for execute method 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-03 10:47:15 +02:00
Christoph Wurst 318d553dbd
Merge pull request #21662 from nextcloud/fix/s3-bucket-compat-static-call 
Fix static method call for s3 bucket compat check
 2020-07-03 10:22:53 +02:00
Joas Schilling 19e1efd1dd
Merge pull request #21439 from nextcloud/feature/noid/move-autocomplete-filter-event-to-new-dispatcher-and-class 
Move AutoComplete::filterResults to new event dispatcher and GenericE…
 2020-07-03 10:03:34 +02:00
Christoph Wurst d3a4bc91f7
Fix static method call for s3 bucket compat check 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-03 09:02:58 +02:00
Nextcloud bot 0825530a1b
[tx-robot] updated from transifex 2020-07-03 02:17:12 +00:00
Roeland Jago Douma d53e005458
Merge pull request #21360 from nextcloud/root-storage-prevent-scanning 
prevent the root storage from accidentally scanning user folders
 2020-07-02 21:07:16 +02:00
Roeland Jago Douma c79f8b9543
Merge pull request #21580 from therealklanni/master 
Add audio formats to htaccess
 2020-07-02 20:59:54 +02:00
Roeland Jago Douma 0157e30ad4
Merge pull request #21599 from nextcloud/debt/noid/type-to-types 
Replace TYPE with TYPES
 2020-07-02 12:21:01 +02:00
Joas Schilling 74a9cadc50
Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-02 11:13:13 +02:00
Joas Schilling b997edad10
Add a dedicated method to get the language for another user 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-01 10:20:07 +02:00
Joas Schilling 35c6b1236f
Move AutoComplete::filterResults to new event dispatcher and GenericEvent 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-01 09:57:33 +02:00
Nextcloud bot 40165340f5
[tx-robot] updated from transifex 2020-07-01 02:16:15 +00:00
Daniel Kesselberg 87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Roeland Jago Douma 873be16c8d
Merge pull request #21588 from nextcloud/bug/21214/method-signature 
Update presign method to match with interface again.
 2020-06-30 20:36:30 +02:00
Roeland Jago Douma c709dda597
Merge pull request #21589 from nextcloud/debt/noid/wrong-exception-call 
Set retry = false for forbidden exception.
 2020-06-30 20:35:47 +02:00
Roeland Jago Douma bc29e361b2
Merge pull request #21596 from nextcloud/debt/noid/share-return-mismatch 
Replace Share with IShare and add missing return
 2020-06-30 19:40:26 +02:00
Robin Appelman da2d425044
add proper paths to locking exceptions 
while some code paths do wrap the "raw" locking exception into one with a proper path, not all of them do
by adding the proper path to the original exception we ensure that we always have the usefull information in out logs

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-06-30 18:10:42 +02:00
Christoph Wurst 8e9726be5c
Log usages of the deprecated app.php file 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-30 09:43:40 +02:00
Nextcloud bot c0c841bc93
[tx-robot] updated from transifex 2020-06-30 02:16:10 +00:00
Daniel Kesselberg 4d44d6be2e
Replace Share with IShare and add missing return. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-26 10:57:55 +02:00
Daniel Kesselberg e984357cfc
Set retry = false for forbidden exception. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-25 23:34:41 +02:00
Daniel Kesselberg 8aa99aa8ff
Update presign method to match with interface again. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-25 22:56:28 +02:00
Joas Schilling b7060be18d
Fix robots "noindex, nofollow" signals 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-25 08:29:43 +02:00
Kevin Lanni c2f2eaf8cc
Add audio formats to htaccess 
Signed-off-by: Kevin Lanni <therealklanni@gmail.com>
 2020-06-24 20:33:51 -07:00
Roeland Jago Douma b6ce75066d
Merge pull request #21558 from nextcloud/part-file-rename-mask 
relax permissions mask check for detecting part file rename
 2020-06-24 21:05:07 +02:00
Joas Schilling a2f34f46b2
Fix tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-24 18:13:37 +02:00
Joas Schilling 89ed2c37bf
Update share type constant usage 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-24 16:49:16 +02:00
Christoph Wurst 654cd18864
Merge pull request #20916 from nextcloud/feature/unified-search-api 
Add unified search API
 2020-06-24 15:38:03 +02:00
Christoph Wurst 27b8637e3e
Deprecate \OCP\ISearch 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 14:20:26 +02:00
Christoph Wurst f8e08a74ba
Implement unified search for Files 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 14:20:26 +02:00
Christoph Wurst 4488e846a5
Add unified search API 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 14:20:25 +02:00
Joas Schilling 7972a5fda6
Merge pull request #21525 from nextcloud/techdebt/noid/contacts-manager 
Techdebt fix contacts manager
 2020-06-24 13:55:31 +02:00
Robin Appelman 35d75dbb38
relax permissions mask check for detecting part file rename 
with files drop uploads the original file name isn't always used for the '.ocTransferId' source path

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-06-24 13:06:14 +02:00
Joas Schilling 95652d4469
Fix language in share notes email for users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-23 22:01:40 +02:00
Joas Schilling ad0731a63c
Make annotations case insensitive 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-23 20:18:23 +02:00
Joas Schilling 8ec1b8132e
Merge pull request #21452 from nextcloud/bugfix/21451/allow-autocomplete-by-displayname-again 
Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
 2020-06-23 14:02:17 +02:00
blizzz 859941db32
Merge pull request #21479 from nextcloud/fix/21474/allow_specifying_cookie_type 
Allow to specify the cookie type for appframework responses
 2020-06-22 13:00:12 +02:00
blizzz a899b4775d
Merge pull request #21475 from nextcloud/enh/noid/flow-event-dispatcher 
flow to not use deprecated event dispatcher methods
 2020-06-22 11:18:50 +02:00
Joas Schilling 404080abb4
More imports 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-22 11:10:44 +02:00
Joas Schilling 3997856d76
Fix code style 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-22 11:09:32 +02:00
Joas Schilling 7ed79b64b4
Fix undefined class "IAddressbook" on docs 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-22 11:08:23 +02:00
Roeland Jago Douma fbf9772a3e
Allow to specify the cookie type for appframework responses 
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.

Helps with #21474

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-06-22 08:38:44 +02:00
Nextcloud bot ce9d3b36df
[tx-robot] updated from transifex 2020-06-20 02:16:35 +00:00
Arthur Schiwon 3706eae777
flow to not use deprecated event dispatcher methods 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-19 23:03:07 +02:00
Roeland Jago Douma 6ec8042d88
Merge pull request #21469 from nextcloud/bugfix/noid/event-service-listener-registration 
Fix event service listener registration
 2020-06-19 21:28:29 +02:00
Roeland Jago Douma 59093abfaf
Merge pull request #21483 from nextcloud/fix/scss/timeout 
Give up after 10 seconds in SCSS timeout
 2020-06-19 21:26:26 +02:00
Roeland Jago Douma 4768526b81
Give up after 10 seconds in SCSS timeout 
Else we keep idling for ages which leads to bad UX

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-06-19 14:39:31 +02:00
Joas Schilling a7f26cfe28
Don't log Keys 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-19 13:44:27 +02:00
Christoph Wurst 2b7b7144d4
Allow crash reporters registration during app bootstrap 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-19 10:38:26 +02:00
Joas Schilling 9cf32a3999
Fix event service listener registration 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-18 15:00:19 +02:00
Joas Schilling 1151394739
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-18 11:33:43 +02:00
Christoph Wurst 32bf95c774
Continue with next app when one errors during register 
My patch at #21461 had a little error in that it exits the method when a
query exception is encountered during the register step of an app. What
we actually want is to continue with the next app and finish the overall
registration procedure.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-18 09:17:00 +02:00
Roeland Jago Douma a915b45190
Merge pull request #21461 from nextcloud/fix/catch-app-register-boot-exceptions 
Catch all exceptions when an app is registering or booting
 2020-06-18 08:59:45 +02:00
Nextcloud bot e324c90a8d
[tx-robot] updated from transifex 2020-06-18 02:16:35 +00:00
Christoph Wurst 5ab5a5f89e
Catch all exceptions when an app is registering or booting 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-17 21:07:42 +02:00
Christoph Wurst 5bc8510b3b
Load the app.php before running apps' boot method 
Some apps require the composer autoloader from app.php. If we run boot
before including that file, classes and functions from dependencies
won't be found.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-17 14:44:02 +02:00
Joas Schilling 9ff7a9c38e
Fix PHP CS 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-17 12:08:17 +02:00
Joas Schilling 2ec7b59688
Move back to IGroupManager::displayNamesInGroup() 
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-17 11:59:56 +02:00
Joas Schilling 3539bd1751
Merge pull request #21434 from nextcloud/bugfix/noid/dont-break-with-GenericEventWrapper 
Don't break event listeners with the GenericEventWrapper
 2020-06-17 11:55:14 +02:00
Christoph Wurst 6328053105
Merge pull request #21406 from nextcloud/fix/aws-disable-csm 
Disable Client-Side Monitoring on AWS storage
 2020-06-17 10:58:27 +02:00
Christoph Wurst c5d2958ac7
Migrate Settings to new bootstrap mechanism 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-17 09:22:22 +02:00
Christoph Wurst 69571fb536
Add dedicated API for apps' bootstrapping process 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-17 09:22:21 +02:00
Joas Schilling c76fa60571
Don't break event listeners with the GenericEventWrapper 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-16 19:30:36 +02:00
Christoph Wurst 68794ebc92
Emit an event for every disabled 2FA provider during cleanup 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-16 14:38:33 +02:00
Christoph Wurst 5e52c110bb
Merge pull request #21416 from nextcloud/fix/user-deleted-token-cleanup 
Clean up auth tokens when user is deleted
 2020-06-16 10:01:29 +02:00
Christoph Wurst 3474afa938
Clean up auth tokens when user is deleted 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-15 19:24:04 +02:00
Julius Härtl 294e40db5f
Avoid duplicate matches in wide and exact results 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-06-15 09:34:57 +02:00
Christoph Wurst 9d392891be
Disable Client-Side Monitoring on AWS storage 
The S3 client enables this by default and then tries to read
`.aws/config`. This causes `open_basedir` restriction related error for
some setups. So this patch disables the CSM because it's most likely
unused anyway.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-15 09:13:08 +02:00
Joas Schilling b6d5979d0a
Increase timeout of the appstore requests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-12 13:01:06 +02:00
Roeland Jago Douma c3267a58c9
Merge pull request #21358 from nextcloud/enhancement/search-group-by-displayname 
Allow group search by display name
 2020-06-11 16:10:34 +02:00
Robin Appelman e9b5514186
prevent the root storage from accidentally scanning user folders 
while this scan *should* never be triggered, it's good to have some failsafe to ensure
that the users home contents don't end up getting scanned in the root storage

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-06-11 15:41:33 +02:00