28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +02:00
1762a409f9
Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods
...
Format control structures, classes, methods and function
2020-04-10 16:38:23 +02:00
eba3726e1e
Merge pull request #19495 from nextcloud/preview-generate-batch
...
optimize batch generation of previews
2020-04-10 15:57:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
edf8ce32cf
Merge pull request #20403 from nextcloud/techdebt/utf8-encoding
...
Use utf8 encoding everywhere
2020-04-10 14:05:23 +02:00
8f9bac26f8
fix preview generation tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-10 13:39:45 +02:00
71b073839f
Merge pull request #20402 from nextcloud/techdebt/elseif
...
Use elseif instead of else if
2020-04-10 13:28:15 +02:00
a0e94e6670
Use utf8 encoding everywhere
...
PSR2 likes that and so do I
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:43:54 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
d6e17fb017
Merge pull request #20256 from nextcloud/dependabot/composer/nikic/php-parser-4.3.0
...
Bump nikic/php-parser from 4.2.1 to 4.3.0
2020-04-10 09:11:32 +02:00
94e602d7b9
Merge pull request #20281 from nextcloud/bugfix/noid/use-primary-element-color
...
Use the primary element color in case it primary color is too bright
2020-04-10 08:53:48 +02:00
0b53084ccb
Use the primary element color in case it primary color is too bright
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-10 06:49:21 +00:00
b68680596d
Merge pull request #20313 from nextcloud/dependabot/npm_and_yarn/underscore-1.10.2
...
Bump underscore from 1.9.2 to 1.10.2
2020-04-10 08:35:43 +02:00
fb64fda4d8
Merge pull request #20385 from nextcloud/skeeable-http-harden
...
harden seekable http stream a bit against failures
2020-04-10 08:34:52 +02:00
7799eef90e
Merge pull request #20390 from nextcloud/refactor/no-closing-tag
...
Do not use closing tags
2020-04-10 08:34:18 +02:00
078b12a9b0
[tx-robot] updated from transifex
2020-04-10 02:18:23 +00:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
3a415e4139
Remove space between switch case and colon
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:17:53 +02:00
f4c09f299d
Make sure there is exactly one newline after imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
bcd13296de
Make sure every file ends with an empty newline
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
a8a06a82d2
Remove trailing whitespaces from comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
42625a46be
Remove spaces after method or function call
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
709584b853
Do not use closing tags
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:01:17 +02:00
c56a273b39
Merge pull request #20383 from nextcloud/techdebt/function-spacing
...
Unify function spacing to PSR2 recommendation
2020-04-09 15:53:09 +02:00
f0dd71ccd2
Merge pull request #20376 from nextcloud/fix/tags-ellipsis
...
Fix systemtags overflow
2020-04-09 15:18:16 +02:00
60de74ac40
harden seekable http stream a bit against failures
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 14:37:01 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
66b743385e
Merge pull request #20355 from nextcloud/fix/comments/clear-input/19585
...
Clear comment on successful post
2020-04-09 13:46:20 +02:00
19e97e86c6
Merge pull request #20379 from nextcloud/techdebt/blank-lines
...
Use one blank line after the opening tag and namespace declaration
2020-04-09 13:44:39 +02:00
7d386872e5
optimize batch generation of previews
...
by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file
the main use case for this is the preview generator app (pr for that comming next)
in my local testing this saves about 25% of time when using the preview generator app
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 12:50:59 +02:00
5cd12cd7c3
allow generating multiple preview sizes for a single file at once
...
this saves having to do some of the overhead multiple times
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 12:50:55 +02:00
2a529e453a
Use a blank line after the opening tag
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:50:14 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
813bdc1ce8
Merge pull request #20375 from nextcloud/techdebt/fix-array-indent-style
...
Fix (array) indent style to always use one tab
2020-04-09 11:25:38 +02:00
21b7e51010
Merge pull request #20303 from nextcloud/version/19/beta2
...
19 beta 2
2020-04-09 10:24:28 +02:00
01389d395e
Fix systemtags overflow
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-09 10:19:42 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
1575bd838f
Merge pull request #20368 from nextcloud/refactor/psr1
...
Migrate to PSR1 coding style
2020-04-09 08:41:06 +02:00
732a239cfd
Merge pull request #20363 from nextcloud/smb-3.2.3
...
update icewind/smb to 3.2.3
2020-04-09 08:16:43 +02:00
b537e9fbc7
[tx-robot] updated from transifex
2020-04-09 02:18:26 +00:00
e9795d01f1
Merge pull request #16035 from nextcloud/share-search-hide-on-match
...
dont show remote and email options if we have an exact match for local user email
2020-04-09 00:08:34 +02:00
22edb626b6
Merge pull request #20370 from nextcloud/techdebt/fix-multiline-comments
...
Fix multiline comments
2020-04-09 00:05:53 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
c4998efcfc
Migrate to PSR1 coding style
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 21:58:05 +02:00
91fc9e19c1
Bump underscore from 1.9.2 to 1.10.2
...
Bumps [underscore](https://github.com/jashkenas/underscore ) from 1.9.2 to 1.10.2.
- [Release notes](https://github.com/jashkenas/underscore/releases )
- [Commits](https://github.com/jashkenas/underscore/compare/1.9.2...1.10.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-08 18:27:38 +00:00
Christoph Wurst
Christoph Wurst
Roeland Jago Douma
Robin Appelman
John Molakvoæ
Joas Schilling
Nextcloud bot
John Molakvoæ (skjnldsv)
blizzz
dependabot-preview[bot]