1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
bcd13296de
Make sure every file ends with an empty newline
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
bbba7bc45a
Merge pull request #20321 from nextcloud/enh/noid/check-translation-for-triple-dot
...
Check for triple dots in translations in CI
2020-04-08 20:10:05 +02:00
283b8a5e74
Check for triple dots in translations in CI
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-07 12:06:40 +08:00
d7eac53ee1
Bump handlebars from 4.7.3 to 4.7.6 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.7.3 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.3...v4.7.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-05 10:57:12 +00:00
dbdd30d4d4
Merge pull request #20216 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.6
...
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
2020-04-03 08:51:27 +02:00
32577f2f57
Merge pull request #20209 from nextcloud/techdebt/php-cs-config
...
Add a shared php coding style fixer config
2020-04-01 13:25:16 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
3eac89d448
Add shared php-cs config
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 13:45:10 +02:00
aaaabd1678
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
...
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport ) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases )
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG )
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.5...1.0.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-29 01:13:34 +00:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
23eb0462e5
Use lowercase true, false and null constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +01:00
97949109ef
Merge pull request #19368 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.7.3
...
Bump handlebars from 4.5.3 to 4.7.3 in /build
2020-03-24 21:47:36 +01:00
ec63327472
Force compatible EventDispatcher version in integration tests
...
Nextcloud requires EventDispatcher from Symfony 4.4. Behat required
Symfony 4.x until Behat 3.5, but since Behat 3.6 it supports Symfony 5.x
too. However, as the EventDispatcher version was not restricted in the
"composer.json" file Composer installed the latest compatible version
with all the dependencies, which happened to be Symfony 5.x. To prevent
that now the EventDispatcher is explicitly limited to Symfony 4.4 only.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-12 10:45:23 +01:00
d3d6d8de3a
Bump handlebars from 4.5.3 to 4.7.3 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.5.3 to 4.7.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.3...v4.7.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-10 19:14:40 +00:00
cb2877abd3
Update behat/behat requirement in /build/integration
...
Updates the requirements on [behat/behat](https://github.com/Behat/Behat ) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases )
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Behat/Behat/compare/v3.5.0...v3.6.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-12 19:28:54 +00:00
1829ee816d
Update guzzlehttp/guzzle requirement in /build/integration
...
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle ) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases )
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md )
- [Commits](https://github.com/guzzle/guzzle/compare/6.3.3...6.5.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-09 02:14:17 +00:00
e5e612a292
Merge pull request #18518 from nextcloud/security-polixy
...
Set up a security policy
2020-02-06 21:24:52 +01:00
bf5174afe0
Bump karma-viewport from 1.0.4 to 1.0.5 in /build
...
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport ) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases )
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG )
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.4...1.0.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-02 02:13:24 +00:00
be506f7b29
Set up a security policy
...
Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
2020-01-21 16:25:52 +01:00
fc77f530d7
Don't show link shares hash in inherited share list
...
This adds no value at all. Just showing the text "(Shared link)" now.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-15 09:21:53 +01:00
6127c288e8
Fix license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +01:00
edf8893479
Fix tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-10 23:44:17 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
a166796378
Update license script apps
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:38 +01:00
ccf7d87c11
integration tests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
add tests on non-owner pov
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
duplicate
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
small fixes
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
removed tags
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2019-12-03 08:10:27 +01:00
407c2c13ab
Merge pull request #18159 from nextcloud/tests/comments-integration
...
Do not call count on null
2019-12-02 08:53:02 +01:00
330cb7047e
Do not call count on null
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-11-29 09:59:35 +01:00
3cda67c8b1
Fix integration
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-28 10:22:05 +01:00
8a15447d63
Bump handlebars from 4.5.2 to 4.5.3 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.2...v4.5.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-24 02:12:31 +00:00
54f8f75f6f
Accept incoming shares in integration tests
...
Now all incoming shares need to be explicitly accepted before being able
to use the shared file or get information about a reshare (although
getting the information of the incoming share is possible before
accepting it).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 15:47:11 +01:00
9004e90f5d
Replace direct calls to share API with specific share steps
...
This makes possible to use steps that reference the last share, which
will be needed to accept pending shares.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 13:11:49 +01:00
847bd0f05b
Remove extra spaces at the end of lines
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 13:10:35 +01:00
43b58ca30f
Bump handlebars from 4.5.1 to 4.5.2 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.5.1 to 4.5.2.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.1...v4.5.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-17 02:13:10 +00:00
f166744f17
Bump handlebars from 4.4.5 to 4.5.1 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.4.5 to 4.5.1.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.5...v4.5.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-10 02:12:31 +00:00
f3009bc76e
Add .editorconfig to expected files
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2019-11-08 08:28:39 +08:00
eebcf89091
Cleanup sharing leftovers
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-11-05 19:03:44 +01:00
515171a653
Transpile also dependencies in node_modules
...
Some of the dependencies in node_modules, such as "p-queue", are not ES5
compatible, so they need to be transpiled to work in older browsers like
Internet Explorer 11.
Besides not excluding the dependencies for babel-loader in
"webpack.common.js" the global Babel configuration must be defined in
"babel.config.js", as in Babel 7.X, when ".babelrc.js" is used, all the
dependencies in "node_modules" are ignored (even if whitelisted in the
configuration file itself).
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:56:00 +01:00
ea6f423e2c
Extend data returned when searching remote shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:55:59 +01:00
11faf739c2
Merge pull request #17698 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.13.0
...
Bump node-sass from 4.12.0 to 4.13.0 in /build
2019-10-27 22:34:49 +01:00
64ce503bce
Bump handlebars from 4.4.3 to 4.4.5 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.4.3 to 4.4.5.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.3...v4.4.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-27 10:18:39 +00:00
baeb369a67
Bump node-sass from 4.12.0 to 4.13.0 in /build
...
Bumps [node-sass](https://github.com/sass/node-sass ) from 4.12.0 to 4.13.0.
- [Release notes](https://github.com/sass/node-sass/releases )
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/node-sass/compare/v4.12.0...v4.13.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-27 07:47:52 +00:00
d0b205d0dd
Add more integration tests for getting shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-26 14:22:17 +02:00
eaa98ed343
Add integration tests for getting shares including subfiles
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-25 18:37:36 +02:00
Christoph Wurst
Joas Schilling
Gary Kim
dependabot-preview[bot]
Roeland Jago Douma
Christoph Wurst
Daniel Calviño Sánchez
Ruben Barkow
Roeland Jago Douma
John Molakvoæ (skjnldsv)
Maxence Lange
Julius Härtl