Daniel Calviño Sánchez
0ddd892736
Fix TypeError when "email" is not given in the controller request
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:57 +02:00
Daniel Calviño Sánchez
0dfd0ec77a
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:56 +02:00
Daniel Calviño Sánchez
bedb97fd57
Add more unit tests for setting user settings
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:55 +02:00
Daniel Calviño Sánchez
1c8295610b
Change default test data to values less similar to empty values
...
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:52 +02:00
Daniel Calviño Sánchez
91e06bc08a
Extract default test data to a helper getter
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:49 +02:00
Daniel Calviño Sánchez
32fd379b66
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:48 +02:00
Nextcloud bot
a335ff969d
[tx-robot] updated from transifex
2021-04-23 02:26:35 +00:00
Robin Appelman
9318f2d668
update icewind/smb to 3.4.1
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-22 18:01:54 +00:00
Morris Jobke
3c9b923eb1
Merge pull request #26684 from nextcloud/backport/26474/stable20
...
[stable20] Mention MariaDB in MySQL support warning
2021-04-22 09:47:45 +02:00
Nextcloud bot
bef596de06
[tx-robot] updated from transifex
2021-04-22 02:26:44 +00:00
Claas Augner
3082777bfd
Mention MariaDB in MySQL support warning
2021-04-21 14:45:41 +00:00
Julius Härtl
0a24fcfc34
Continue iterating over diretory contents and just hide file if denied by acl
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-21 07:24:25 +00:00
Nextcloud bot
80d93acff0
[tx-robot] updated from transifex
2021-04-21 02:26:25 +00:00
Vincent Petry
cea228ef50
Update psalm baseline
...
And backport error suppression from stable21 in SFTP class.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-20 17:13:31 +02:00
Roeland Jago Douma
e5edc58d11
Make lookup search explicit
...
Speedsup sharee lookup quite a bit.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 08:37:48 +00:00
Morris Jobke
bd16ddd675
Merge pull request #26637 from nextcloud/backport/26615/stable20
...
[stable20] Require read permissions for federated shares
2021-04-20 09:06:40 +02:00
Nextcloud bot
a4c55e4601
[tx-robot] updated from transifex
2021-04-20 02:26:21 +00:00
Roeland Jago Douma
0324e078f8
Require read permissions for federated shares
...
Else they end up as weird shares that can't be properly utilized by
other parties anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 19:54:24 +00:00
Roeland Jago Douma
12504d4ab7
Do not allow adding file drop shares to your own cloud
...
There is no reason for this and you can't create such shares normally
anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 13:01:05 +00:00
Nextcloud bot
ed5f446ec1
[tx-robot] updated from transifex
2021-04-19 02:26:26 +00:00
Nextcloud bot
90ea283913
[tx-robot] updated from transifex
2021-04-18 02:24:30 +00:00
Nextcloud bot
36a16bcf63
[tx-robot] updated from transifex
2021-04-17 02:24:25 +00:00
Nextcloud bot
e57f65cdfe
[tx-robot] updated from transifex
2021-04-16 02:26:13 +00:00
Nextcloud bot
36d2bb05cf
[tx-robot] updated from transifex
2021-04-15 02:25:32 +00:00
Nextcloud bot
d35011b3f7
[tx-robot] updated from transifex
2021-04-14 02:27:12 +00:00
Nextcloud bot
bb6dc44afb
[tx-robot] updated from transifex
2021-04-13 02:25:18 +00:00
Valdnet
1e4fc523fe
l10n: Add word user in FederatedShareProvider.php
...
Standardizing text strings with other Nextcloud applications.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-12 06:43:54 +00:00
Nextcloud bot
0cdfea022d
[tx-robot] updated from transifex
2021-04-12 02:25:16 +00:00
Nextcloud bot
7faa8e697b
[tx-robot] updated from transifex
2021-04-11 02:25:03 +00:00
Nextcloud bot
ff2a0b3126
[tx-robot] updated from transifex
2021-04-10 02:31:32 +00:00
Nextcloud bot
e78e509618
[tx-robot] updated from transifex
2021-04-09 02:25:30 +00:00
Nextcloud bot
e09760f2bc
[tx-robot] updated from transifex
2021-04-08 02:24:23 +00:00
Nextcloud bot
f1fd067db1
[tx-robot] updated from transifex
2021-04-07 02:24:36 +00:00
Nextcloud bot
45e63c949c
[tx-robot] updated from transifex
2021-04-06 02:25:51 +00:00
Nextcloud bot
ef6a2cfc8f
[tx-robot] updated from transifex
2021-04-05 02:25:05 +00:00
Nextcloud bot
bc1331f2c9
[tx-robot] updated from transifex
2021-04-04 02:25:07 +00:00
Nextcloud bot
9d0c2b1984
[tx-robot] updated from transifex
2021-04-03 02:43:54 +00:00
Nextcloud bot
7eb7a91b06
[tx-robot] updated from transifex
2021-04-02 02:26:26 +00:00
Nextcloud bot
9df8953adf
[tx-robot] updated from transifex
2021-04-01 02:24:59 +00:00
Nextcloud bot
35db1b5996
[tx-robot] updated from transifex
2021-03-31 02:25:11 +00:00
Roeland Jago Douma
99e2e5f6b9
Merge pull request #26258 from nextcloud/backport/26198/stable20
...
[stable20] Handle limit offset and sorting in files search
2021-03-30 20:53:11 +02:00
Nextcloud bot
60aa785092
[tx-robot] updated from transifex
2021-03-30 02:24:39 +00:00
Roeland Jago Douma
dd9890c5b8
Merge pull request #26262 from nextcloud/backport/26046/stable20
...
[stable20] update icewind/smb to 3.4.0
2021-03-29 21:14:39 +02:00
Nick Sweeting
03df8abca3
change calendar invite emails to use pngs instead of svgs
...
Signed-off-by: Nick Sweeting <git@sweeting.me>
2021-03-29 16:16:33 +00:00
Nextcloud bot
dae4431427
[tx-robot] updated from transifex
2021-03-29 02:24:18 +00:00
Nextcloud bot
86850feaf9
[tx-robot] updated from transifex
2021-03-28 02:24:24 +00:00
Nextcloud bot
53aa26b6c6
[tx-robot] updated from transifex
2021-03-27 02:24:47 +00:00
John Molakvoæ
20cb2b49e6
Merge pull request #26305 from nextcloud/backport/22201/stable20
...
[stable20] Delete old birthday calendar object when moving contact to another ad…
2021-03-26 08:57:48 +01:00
John Molakvoæ
2262115043
Merge pull request #26297 from nextcloud/backport/26287/stable20
...
[stable20] Fix l10n
2021-03-26 08:08:53 +01:00
Christian Weiske
92ac67c3d2
Delete old birthday calendar object when moving contact to another address book
...
When an contact is moved to another address book, the contact is copied to
the second address book.
During copying, the birthday event is created - but it gets the same UID
as the contact's birthday event in the first address book.
To prevent the "Calendar object with uid already exists" error that followed,
we need to delete the old entry before the new one is created.
Resolves: https://github.com/nextcloud/server/issues/20492
Signed-off-by: Christian Weiske <cweiske@cweiske.de>
2021-03-26 07:01:33 +00:00
Nextcloud bot
1a05043008
[tx-robot] updated from transifex
2021-03-26 02:25:53 +00:00
Valdnet
ab374f2cde
Fix l10n
...
Issue: #26286
2021-03-25 12:58:49 +00:00
Arthur Schiwon
d78b213310
adds ldap user:reset command
...
- allows to delete data of existing LDAP users, which otherwise is safe
guarded
- ensures that the user is not being deleted on LDAP through a plugin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-25 13:36:16 +01:00
Nextcloud bot
f6cbda9e60
[tx-robot] updated from transifex
2021-03-25 02:25:57 +00:00
Robin Appelman
10bf93aa24
pass order from unified search to file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:01:11 +01:00
Robin Appelman
60551ced9e
use "newer" node search api directly in unified search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 16:00:06 +01:00
Valdnet
680a54c47d
l10n: Separate ellipsis
...
Unifying the text string with the others.
2021-03-24 13:26:48 +00:00
Nextcloud bot
c555e86e63
[tx-robot] updated from transifex
2021-03-24 02:25:25 +00:00
Robin Appelman
4bbf7058af
update icewind/smb to 3.4.0
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 19:08:48 +01:00
Nextcloud bot
1c9904aafc
[tx-robot] updated from transifex
2021-03-23 02:24:24 +00:00
Valdnet
70e89e44ec
l10n: Add changes to text string for user
2021-03-22 10:30:52 +00:00
Valdnet
68a707c158
l10n: Add word user in ShareByMailProvider.php
...
Standardizing text strings with other Nextcloud applications.
2021-03-22 10:30:51 +00:00
Nextcloud bot
208f84d2e4
[tx-robot] updated from transifex
2021-03-22 02:24:06 +00:00
Nextcloud bot
efdb5cc53c
[tx-robot] updated from transifex
2021-03-21 02:23:27 +00:00
Roeland Jago Douma
7b294aee0d
Merge pull request #26217 from nextcloud/backport/26145/stable20
...
[stable20] add (hidden) option to always show smb root as writable
2021-03-20 10:53:48 +01:00
Nextcloud bot
01d05c6435
[tx-robot] updated from transifex
2021-03-20 02:24:00 +00:00
Robin Appelman
728488fcf5
add (hidden) option to always show smb root as writable
...
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.
This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.
This can be enabled using
```bash
occ files_external:config <mount id> root_force_writable true
```
where you can find your mount id using
```bash
occ files_external:list
```
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 15:47:23 +00:00
Nextcloud bot
97d9b3fe0c
[tx-robot] updated from transifex
2021-03-19 02:25:14 +00:00
Julius Härtl
96287f336e
Add appconfig to always show the unique label of a sharee
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-18 13:07:03 +00:00
Morris Jobke
939db1f466
Merge pull request #26190 from nextcloud/backport/25331/stable20
...
[stable20] Fix valid storages removed when cleaning remote storages
2021-03-18 13:09:22 +01:00
Daniel Calviño Sánchez
ec454e7c2b
Fix valid storages removed when cleaning remote storages
...
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.
The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.
Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 07:59:45 +00:00
Robin Appelman
57042ab107
limit constructing of result objects in file search
...
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.
this saves about 40% of the time spend in the search request in my local testing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:22:31 +01:00
Nextcloud bot
a50f4a42bc
[tx-robot] updated from transifex
2021-03-18 02:25:22 +00:00
Morris Jobke
4f18ff9815
Merge pull request #25944 from nextcloud/backport/25659/stable20
...
[stable20] catch notfound and forbidden exception in smb::getmetadata
2021-03-17 20:13:57 +01:00
Morris Jobke
3c1402c2d9
Merge pull request #25876 from nextcloud/psalm/stable20/update
...
[stable20] Update psalm baseline
2021-03-17 14:17:20 +01:00
Vincent Petry
67e0b194b6
Update and fix baseline
...
Backported some bits of stable21 to make Psalm happy.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-17 12:04:08 +01:00
Morris Jobke
9749514649
Use correct exception type hint in catch statement
...
Found by psalm update 4.6.2 to 4.6.3 in #26111
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:47:07 +00:00
Nextcloud bot
fdabe1172b
[tx-robot] updated from transifex
2021-03-17 02:24:39 +00:00
Robin Appelman
7fd53b91c3
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:22 +01:00
Christoph Wurst
a6357ebcba
Merge pull request #26130 from nextcloud/backport/26115/stable20
...
[stable20] Log exceptions when creating share
2021-03-16 11:09:44 +01:00
Nextcloud bot
7332b6f75e
[tx-robot] updated from transifex
2021-03-16 02:25:00 +00:00
Vincent Petry
20ebdf4fe0
Log exceptions when creating share
...
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.
In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:43 +00:00
Christoph Wurst
3e18eca7a0
Merge pull request #26059 from nextcloud/backport/25911/stable20
...
[stable20] Only clear share password model when actually saved
2021-03-15 09:48:19 +01:00
Nextcloud bot
25f27569f5
[tx-robot] updated from transifex
2021-03-15 02:24:17 +00:00
Nextcloud bot
049895f3e7
[tx-robot] updated from transifex
2021-03-14 02:23:58 +00:00
Nextcloud bot
b6af167c65
[tx-robot] updated from transifex
2021-03-13 02:23:14 +00:00
Nextcloud bot
60756e8e3e
[tx-robot] updated from transifex
2021-03-12 02:23:01 +00:00
Vincent Petry
51ba0faeaf
Only clear share password model when actually saved
...
Instead of always clearing the password in the share model, now only do
it when it was actually saved.
Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 10:20:59 +00:00
Roeland Jago Douma
b306b88a41
Merge pull request #26040 from nextcloud/backport/25916/stable20
...
[stable20] Remove trash items from other trash backends when deleting all
2021-03-11 10:34:32 +01:00
Nextcloud bot
28378720f1
[tx-robot] updated from transifex
2021-03-11 02:23:28 +00:00
Roeland Jago Douma
ae6c5f2af4
Merge pull request #26027 from nextcloud/backport/25933/stable20
...
[stable20] Hide expiration date field for remote shares
2021-03-10 15:46:53 +01:00
Vincent Petry
aad21777d4
Hide expiration date field for remote shares
...
Remote shares currently do not support expiration date.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 09:08:28 +00:00
Roeland Jago Douma
f240f895e7
Merge pull request #25878 from nextcloud/backport/25568/stable20
...
[stable20] disable trasbin during the moveFromStorage fallback
2021-03-10 09:34:02 +01:00
Julius Härtl
0c98c15555
Remove trash items from other trash backends when deleting all
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:02:38 +00:00
Nextcloud bot
8dc2b22e35
[tx-robot] updated from transifex
2021-03-10 02:23:17 +00:00
Roeland Jago Douma
0d021249f8
Merge pull request #25938 from nextcloud/backport/25927/stable20
...
[stable20] Sharebymail: set expiration on creation
2021-03-09 20:20:49 +01:00
Nextcloud bot
df04689af7
[tx-robot] updated from transifex
2021-03-09 02:24:13 +00:00
Nextcloud bot
2046e71da2
[tx-robot] updated from transifex
2021-03-08 02:23:30 +00:00
Nextcloud bot
14b9c26b8a
[tx-robot] updated from transifex
2021-03-07 02:22:25 +00:00
Roeland Jago Douma
f78c3f475b
Merge pull request #25956 from nextcloud/backport/25932/stable20
...
[stable20] Skip empty obsolete owner when adding to own NC
2021-03-06 10:55:08 +01:00