Commit Graph

56427 Commits

Author SHA1 Message Date
Morris Jobke 83a75c670b
Replace static call to Share::unshare with ShareManager->deleteShare in tests
And then cleanup all the code that is dead then...

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-30 09:51:18 +01:00
John Molakvoæ 9409968451
Merge pull request #24439 from nextcloud/techdebt/noid/legacy-share-cleanup 2020-11-30 09:05:02 +01:00
Nextcloud bot c1161e27b4
[tx-robot] updated from transifex 2020-11-30 02:19:45 +00:00
Morris Jobke 6564a95160
Remove now unused methods in Share.php due to the reduced code complexity in Share::getItems
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 23:28:16 +01:00
Morris Jobke 10e5ae5e18
Remove unused method Share Helper::generateTarget
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 22:52:52 +01:00
Morris Jobke a125d8aaa1
Reduce code complexity in Share::getItems by tracing all remaining callers
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 22:30:09 +01:00
Morris Jobke 596df8fc6f
Remove unused Share::getItemSharedWithBySource()
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 22:24:12 +01:00
Roeland Jago Douma f7fa292beb
Merge pull request #24405 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2020-11-29 14:02:36 +01:00
Nextcloud-PR-Bot f94741ddee Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-29 04:27:32 +00:00
Nextcloud bot 6e1269d912
[tx-robot] updated from transifex 2020-11-29 02:19:11 +00:00
dependabot-preview[bot] 82c7d3c0f8
Bump @babel/core from 7.12.7 to 7.12.9
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.7 to 7.12.9.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.9/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-11-28 02:22:24 +00:00
Nextcloud bot 099b7590a9
[tx-robot] updated from transifex 2020-11-28 02:18:24 +00:00
dependabot-preview[bot] fa1269f817
Bump babel-loader from 8.2.1 to 8.2.2
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.1...v8.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-11-28 02:17:57 +00:00
Christoph Wurst 334f3943ab
Migrate LDAP's install.php to a repair step
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 15:13:01 +01:00
blizzz 6c513f8b43
Merge pull request #24413 from nextcloud/techdebt/remvoe-ldap-update-php
Remove the obsolete update.php of user_ldap
2020-11-27 14:56:28 +01:00
Christoph Wurst fd649afb1f
Remove the deprecated update.php
* It was documented as deprecated.
* The app code checker warned about it
* It's been three years

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 13:02:59 +01:00
Christoph Wurst a8437f1b18
Remove the obsolete update.php of user_ldap
This was necessary long time ago for backwards compat with older
instances that were upgraded. Since this script has been run many times
with all the previous major versions, it's finally time to remove this.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 12:18:06 +01:00
Julius Härtl ada55a941e
Merge pull request #24395 from nextcloud/techdebt/composer-require-simplexml
Require ext-simplexml via composer
2020-11-27 10:54:17 +01:00
Nextcloud bot 7718a8a4b8
[tx-robot] updated from transifex 2020-11-27 02:18:17 +00:00
blizzz fad8dd3933
Merge pull request #24393 from nextcloud/techdebt/unused-updater-check-app-upgrade
Remove dead method \OC\Updater::checkAppUpgrade
2020-11-26 18:11:51 +01:00
Robin Appelman 7956cef622
rebuild autoloader scripts with 2.0.7
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:49:03 +01:00
Robin Appelman 3e2e694ea9
dont use system composer for autoload checker
this ensures that the same composer version is used by everyone (and ci)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:48:46 +01:00
Robin Appelman 88f35d52d2
rename cache event to follow new naming standards
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:39:46 +01:00
Robin Appelman 23fb497ff5
extend cache events
- adds cache remove event
- expose storage id in event
- emit events during cache move

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:22:03 +01:00
Christoph Wurst ef26c1aedd
Require ext-simplexml via composer
This makes phpunit (and static analysis?) happy

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-26 15:16:16 +01:00
Christoph Wurst 7dd39a91ee
Remove dead method \OC\Updater::checkAppUpgrade
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-26 14:48:41 +01:00
Christoph Wurst 54e3beba16
Merge pull request #24319 from nextcloud/techdebt/noid/streamline-user-creation-and-deletion-events
Streamline user creation and deletion events
2020-11-26 14:09:54 +01:00
blizzz f8a4e07a8c
Merge pull request #24375 from nextcloud/fix/noid/display-remote-sharers-filelist
formatting remote sharer should take protocol, path into account
2020-11-26 14:08:13 +01:00
Arthur Schiwon f3f819b542
formatting remote sharer should take protocol, path into account
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-26 12:49:16 +01:00
Christoph Wurst bb7e1bdfb7
Merge pull request #24382 from nextcloud/bugfix/noid/urlencode-inherited-shares
Properly encode path when fetching inherited shares
2020-11-26 10:23:16 +01:00
Julius Härtl 5b3558861d
Properly encode path when fetching inherited shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-26 09:25:17 +01:00
Daniel Kesselberg 35098a9973
A valid user session is required for circles.
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-26 09:00:09 +01:00
Daniel Kesselberg efef6e9b78
Update phpdoc for circleToPrincipal
as the QueryException is already catched inside circleToPrincipal.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-26 09:00:04 +01:00
Nextcloud bot aea31d5ddd
[tx-robot] updated from transifex 2020-11-26 02:18:48 +00:00
Christoph Wurst 82984b5c79
Merge pull request #24374 from nextcloud/bugfix/23542
Use proper bundles for files client and fileinfo
2020-11-25 17:09:06 +01:00
Roeland Jago Douma 2172432420
Merge pull request #23912 from nextcloud/objectstore-copy
use in objectstore copy
2020-11-25 16:09:26 +01:00
Julius Härtl b06b0315c6
Files client and info bundles are always loaded so we don't need to load them again
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-25 15:11:03 +01:00
Roeland Jago Douma 6166e1a157
Use proper OCP\BackgroundJobs\Job
And typehunt the IJobList

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-25 15:03:06 +01:00
Christoph Wurst e165dcbe35
Merge pull request #24357 from nextcloud/fix/vcf-export-group-multiline
Make sure we add new line between vcf groups exports
2020-11-25 12:24:27 +01:00
Christoph Wurst 82864ef8a7
Merge pull request #24363 from nextcloud/fix/versions-expire-storage-not-available
Catch storage not available in versions expire command
2020-11-25 11:37:33 +01:00
Christoph Wurst 01790537f6
Merge pull request #24361 from nextcloud/fix/noid/fedshares-displaynames-again
send expected format of cloud id
2020-11-25 09:49:20 +01:00
Christoph Wurst 12d1c27b7f
Catch storage not available in versions expire command
External storage with session credentials is not accessible without a
user session, hence background jobs and CLI commands can't work with
them. The previously unhandled exception causes logged errors in the
nextcloud log. This patch catches the specific exception and logs it as
warnings. So for a production instance the error won't spam their logs
for this non-recoverable and technically unsolvable error if the minimum
log level is set to the default of 3 (error).

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-25 09:28:38 +01:00
Nextcloud bot 81bf307845
[tx-robot] updated from transifex 2020-11-25 02:18:53 +00:00
Arthur Schiwon 9cfa8a6c44
send expected format of cloud id
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-24 23:14:43 +01:00
John Molakvoæ (skjnldsv) e18899a06d
Make sure we add new line between vcf groups exports
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-24 18:33:39 +01:00
blizzz 5d03b5c5dd
Merge pull request #24162 from nextcloud/fix/noid/fedshares-displaynamez
set the display name of federated sharees from addressbook
2020-11-24 17:23:37 +01:00
blizzz 6156a49f6e
Merge pull request #24341 from nextcloud/fix/sharing-enforce-expire-checkbox
Fix the config key on the sharing expire checkbox
2020-11-24 15:49:49 +01:00
Robin Appelman 9d4848e863
use in objectstore copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-24 15:16:58 +01:00
Roeland Jago Douma f37155d28b
Merge pull request #24331 from nextcloud/bugfix/fix-contactsmenu-position
Fix contacts menu position and show uid as a tooltip
2020-11-24 14:27:36 +01:00
Christoph Wurst 2526c5e042
Fix the config key on the sharing expire checkbox
We don't use `shareapi_internal_enforce_expire_date` anywhere.
`shareapi_enforce_internal_expire_date` is the one we want.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-24 14:17:41 +01:00