Joas Schilling
b9a26bca3b
Fix throws docs
2016-05-25 16:06:09 +02:00
Joas Schilling
3ef8c95b37
Move tests/ to PSR-4
2016-05-25 16:06:09 +02:00
Joas Schilling
c807a26bd8
Move Access to PSR-4
2016-05-25 16:04:59 +02:00
Joas Schilling
aa7b600383
Move Configuration to PSR-4
2016-05-25 16:04:59 +02:00
Joas Schilling
af0a6961b1
Move Connection to PSR-4
2016-05-25 16:04:59 +02:00
Joas Schilling
387019a212
Move FilesystemHelper to PSR-4
2016-05-25 16:04:58 +02:00
Joas Schilling
7db6b487f5
Move Helper to PSR-4
2016-05-25 16:04:58 +02:00
Joas Schilling
391531851c
Move interface to PSR-4
2016-05-25 16:04:58 +02:00
Joas Schilling
3690ce1b36
Move LDAP to PSR-4
2016-05-25 16:04:58 +02:00
Joas Schilling
6feccccbd5
Move LogWrapper to PSR-4
2016-05-25 16:04:57 +02:00
Joas Schilling
d4e828f39e
Move wizard
2016-05-25 16:04:57 +02:00
Joas Schilling
3f5e76162d
Move lib\user to PSR-4
2016-05-25 16:04:56 +02:00
Joas Schilling
b7fa527791
Move User_LDAP and User_Proxy to PSR-4
2016-05-25 16:04:56 +02:00
Joas Schilling
cbba55a26c
Move Group_LDAP and Group_Proxy to PSR-4
2016-05-25 16:04:56 +02:00
Morris Jobke
62a59854f0
Fix LDAP race conditions
...
* getFromCache is wrapped in isCached
* inbetween the two calls the cache entry hits it's TTL
* getFromCache returns null
* this fix only checkes if the returned value is null and
return only non-null values
2016-04-20 21:50:28 +02:00
Stefan Weil
16df1c5188
apps: Fix typos (found by codespell) ( #23862 )
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-04-12 12:52:51 +02:00
Thomas Müller
8442516e10
Merge pull request #23329 from owncloud/fix-21555
...
Avatar must be saved after login is done and external storages set up…
2016-03-21 09:47:50 +01:00
Arthur Schiwon
d8621c78ed
Avatar must be saved after login is done and external storages set up properly, fixes #21555
2016-03-16 20:51:03 +01:00
Arthur Schiwon
8e0bd5630c
fix writing to cache when fallback server should be used immediately
2016-03-16 14:44:18 +01:00
Lukas Reschke
933f60e314
Update author information
...
Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)
2016-03-01 17:25:15 +01:00
Arthur Schiwon
d19c47a381
More fixed tests :)
2016-02-09 18:11:30 +01:00
Thomas Müller
69a4cd2898
Merge pull request #22102 from owncloud/ldap_2nddispname-master
...
[LDAP] add second field for additional/optional display name attribute
2016-02-06 13:27:01 +01:00
Arthur Schiwon
e370b601db
fix unit tests
2016-02-03 22:45:33 +01:00
Arthur Schiwon
c1871f5787
Port of test_ldap_2nddispname to master
2016-02-03 13:55:39 +01:00
Thomas Müller
77069f5582
Use IUser::setEMailAddress in ldap as well
2016-01-20 15:21:33 +01:00
Thomas Müller
dd733d8925
Merge pull request #20804 from owncloud/fix-ldap-process-user-wo-displayname
...
LDAP: do not attempt to process user records without display name, fi…
2016-01-20 11:33:26 +01:00
Thomas Müller
682821c71e
Happy new year!
2016-01-12 15:02:18 +01:00
Arthur Schiwon
1ed6132899
LDAP: do not attempt to process user records without display name, fixes fatal error
2016-01-11 11:21:02 +01:00
Thomas Müller
70b58cf367
Merge pull request #17924 from owncloud/ldap-fix-appending-port
...
ensure an LDAP URL is used, append the port to the host URL when necessary, and just in one place
2016-01-08 12:34:15 +01:00
Arthur Schiwon
35a2639701
unit test on getHome in combination with OfflineUser
2015-12-11 17:25:57 +01:00
Arthur Schiwon
aedbc0c626
adjust unit test
2015-12-11 12:52:12 +01:00
Arthur Schiwon
a32b002cff
always use an LDAP URL when connecting to LDAP
2015-12-05 00:09:15 +01:00
Thomas Müller
f9fc254672
Add DB group to some files_external tests
...
Adding group Db to federation tests and ldap tests
Add group DB to Test_UrlGenerator
Adding group DB to trashbin and versions tests
Adding group DB to Test_Util_CheckServer for pg
2015-11-30 10:55:10 +01:00
Arthur Schiwon
253e4bcf63
integration tests
2015-11-04 12:26:21 +01:00
Arthur Schiwon
16aa339475
add method to count users by loginname and use it for diagnose test, fixes #20151
2015-10-30 18:20:50 +01:00
Arthur Schiwon
f96e552164
fix attribute casing to ensure array keys work
2015-10-27 19:10:38 +01:00
Arthur Schiwon
e1d61284f8
fix update quota with known value
2015-10-27 18:07:40 +01:00
Lukas Reschke
8f09d5b67c
Update license headers
2015-10-26 14:04:01 +01:00
Lukas Reschke
d486949705
Adjust unit tests
2015-10-16 10:37:08 +02:00
Thomas Müller
3f083353c1
Merge pull request #19635 from owncloud/fix-ldap-value-limitation
...
allow an attribute to return more than one value
2015-10-13 14:09:52 +02:00
Arthur Schiwon
d127b3f0d2
adjust tests
2015-10-09 14:30:49 +02:00
Thomas Müller
c8021441d0
Merge pull request #19489 from owncloud/fix-18297
...
fix possible infinite loop when reading groups in the wizard
2015-10-07 14:55:48 +02:00
Thomas Müller
0385a62363
Merge pull request #19597 from owncloud/update-license-headers
...
update licence headers via script
2015-10-06 11:18:35 +02:00
Morris Jobke
b945d71384
update licence headers via script
2015-10-05 21:15:52 +02:00
Arthur Schiwon
353a8e442f
fix possible infinite loop when reading groups in the wizard
2015-10-05 19:10:30 +02:00
Arthur Schiwon
fc273ac88c
trim by default, add unit tests
2015-10-05 13:42:20 +02:00
Arthur Schiwon
0dde79b75b
memberOf resembles a DN as well and is actively used
2015-09-28 18:40:01 +02:00
Arthur Schiwon
002b6bf059
do not throw exception when no attribute is specified
2015-09-23 17:27:40 +02:00
Arthur Schiwon
9d03b7c6b7
read all relevant user attributes on login and user search, in one query. saves us some.
2015-09-23 16:38:39 +02:00
Morris Jobke
27af0e82dd
Merge pull request #18042 from GreenArchon/master
...
Properly nest groups when using memberOf to detect group membership, …
2015-08-26 11:42:47 +02:00
Arthur Schiwon
6787774a32
integration tests for hardening user home retrieval
2015-08-06 09:31:07 +02:00
Frédéric Fortier
7604bcb3cb
Properly nest groups when using memberOf to detect group membership, fixes #17759
2015-08-03 20:15:22 -04:00
Arthur Schiwon
0967a54755
fix test after rebasing
2015-07-27 17:34:45 +02:00
Arthur Schiwon
85b7bde7d4
add integration tests for avatar update
2015-07-27 17:27:00 +02:00
Arthur Schiwon
68706de45b
refactor integration tests to make it easier to add new ones
2015-07-27 17:27:00 +02:00
Morris Jobke
933f087d21
Merge pull request #17526 from owncloud/fix-17516
...
LDAP: when checking group for matching filter, also take base DN into…
2015-07-27 08:38:45 +02:00
Viktor Szépe
4699a29a70
Fixing line comments and indentation
2015-07-21 22:19:53 +02:00
Arthur Schiwon
b961a29b0c
fix indentation. no code changes, whitespace only.
2015-07-20 01:21:52 +02:00
Arthur Schiwon
4f910221c4
fix runtime caching in ldap's user manager, fixes #17631
2015-07-17 18:57:56 +02:00
Arthur Schiwon
bfdf39b9bd
LDAP: when checking group for matching filter, also take base DN into consideration. Fixes #17516
2015-07-09 12:19:04 +02:00
Thomas Müller
0a23d566ba
Merge pull request #17255 from owncloud/fix-17119
...
[LDAP] Filter user groups obtained by memberof
2015-07-01 00:33:39 +02:00
Arthur Schiwon
5f4db0540a
tests solidity
2015-06-30 14:09:11 +02:00
Arthur Schiwon
646f2f1d41
adjust unit test
2015-06-30 13:56:25 +02:00
Arthur Schiwon
663cd7af4d
integration test
2015-06-30 12:52:27 +02:00
Morris Jobke
f63915d0c8
update license headers and authors
2015-06-25 14:13:49 +02:00
Arthur Schiwon
0e522a0b01
delete user test to take getHome into account to ensure it is also deleted subsequently
2015-06-17 14:13:01 +02:00
Arthur Schiwon
090478a95e
if possible, getUserGroups should get memberships using memberOf virtual attribute
2015-06-03 17:38:27 +02:00
Arthur Schiwon
6b218039ba
Fixes returns of group memberships and counting if all members have the specific groups as primary set.
2015-05-19 12:56:07 +02:00
Arthur Schiwon
9b6a988926
add integration test to ensure correct behaviour on lost connections
2015-04-24 15:50:03 +02:00
Morris Jobke
85d0fc5cf6
LDAP tests: swithc var_dump to exception
2015-04-18 15:09:15 +02:00
Jörn Friedrich Dreyer
fafecd1c05
fix cherrypicking
2015-04-10 11:08:24 +02:00
Jörn Friedrich Dreyer
077ab27281
fix_tests
...
Conflicts:
apps/user_ldap/tests/user_ldap.php
2015-04-10 09:12:37 +02:00
Arthur Schiwon
40edaa5a69
adjust tests
2015-04-09 12:00:11 +02:00
Jenkins for ownCloud
b585d87d9d
Update license headers
2015-03-26 11:44:36 +01:00
Arthur Schiwon
7520d0fb3d
offset needs to be considered in computed limit
2015-03-23 16:51:40 +01:00
Morris Jobke
06aef4e8b1
Revert "Updating license headers"
...
This reverts commit 6a1a4880f0
.
2015-02-26 11:37:37 +01:00
Lukas Reschke
52495dc995
Merge pull request #13740 from owncloud/fix-12190-2
...
Include primary groups in user and login filter when restricting group access and also fix user counting in primary groups
2015-02-24 16:37:49 +01:00
Jenkins for ownCloud
6a1a4880f0
Updating license headers
2015-02-23 12:13:59 +01:00
Arthur Schiwon
31de757514
fix counting of users in primary group
2015-01-28 15:52:59 +01:00
Arthur Schiwon
6c335ee6fc
add test for mapping's getList method
2015-01-07 12:39:29 +01:00
Arthur Schiwon
b9235e2a24
inject DB Connection to user manager
2015-01-07 00:52:18 +01:00
Arthur Schiwon
40ecd30fba
inject oc config to User_LDAP
2015-01-06 23:28:49 +01:00
Arthur Schiwon
e724b78694
smaller fixes: coding style, PHPdoc, typos and few for DI
2015-01-06 17:50:06 +01:00
Arthur Schiwon
61ed363f82
planned refactorings for OC 8
2014-12-20 18:28:29 +01:00
Arthur Schiwon
144d95de7d
basic adjustments for OC 8. I.e. no visible issues, LDAP tests pass.
2014-12-20 16:09:04 +01:00
Arthur Schiwon
4fa39250e7
LDAP User Cleanup: Port from stable7 without further adjustements
...
LDAP User Cleanup
background job for user clean up
adjust user backend for clean up
register background job
remove dead code
dependency injection
make Helper non-static for proper testing
check whether it is OK to run clean up job. Do not forget to pass arguments.
use correct method to get the config from server
methods can be private, proper indirect testing is given
no automatic user deletion
make limit readable for test purposes
make method less complex
add first tests
let preferences accept limit and offset for getUsersForValue
DI via constructor does not work for background jobs
after detecting, now we have retrieving deleted users and their details
we need this method to be public for now
finalize export method, add missing getter
clean up namespaces and get rid of unnecessary files
helper is not static anymore
cleanup according to scrutinizer
add cli tool to show deleted users
uses are necessary after recent namespace change
also remove user from mappings table on deletion
add occ command to delete users
fix use statement
improve output
big fixes / improvements
PHP doc
return true in userExists early for cleaning up deleted users
bump version
control state and interval with one config.php setting, now ldapUserCleanupInterval. 0 will disable it. enabled by default.
improve doc
rename cli method to be consistent with others
introduce ldapUserCleanupInterval in sample config
don't show last login as unix epoche start when no login happend
less log output
consistent namespace for OfflineUser
rename GarbageCollector to DeletedUsersIndex and move it to user subdir
fix unit tests
add tests for deleteUser
more test adjustements
Conflicts:
apps/user_ldap/ajax/clearMappings.php
apps/user_ldap/appinfo/app.php
apps/user_ldap/lib/access.php
apps/user_ldap/lib/helper.php
apps/user_ldap/tests/helper.php
core/register_command.php
lib/private/preferences.php
lib/private/user.php
add ldap:check-user to check user existance on the fly
Conflicts:
apps/user_ldap/lib/helper.php
forgotten file
PHPdoc fixes, no code change
and don't forget to adjust tests
2014-12-19 19:47:54 +01:00
Arthur Schiwon
ec0f80fee9
Split mapping from Access and Helper classes into it's own. Fully test them, too.
...
remove unused methods
split mapping methods off from Access class
fix DB query handling
move 'clear mapping' methods from static helper to new mapping class
add tests
test directly with DB
finishing tests and fix return value from setDNbyUUID
add corresponding class for groups and make abstract test class neutral. helper tests is now obsolete as the tested functions were moved to the new mapper class.
add missing info to PHPDoc
add unmap method
fix namespaces
fix test inheritance
PHPDoc and a small code restructure for scrutinizer, no effective changes
PostgreSQL does not accept LIMIT in DELETE queries
phpdoc fixes, no code changes
2014-12-19 18:26:12 +01:00
Morris Jobke
02095d4f20
Merge pull request #11837 from owncloud/fix-11328
...
unify count filters and introduce display name attribute detection
2014-11-24 18:13:01 +01:00
Arthur Schiwon
f725cc66a3
consolidate user count filter in wizard and user back end
2014-11-20 18:31:39 +01:00
Joas Schilling
76ebd3a050
Make apps/ extend the \Test\TestCase and fix overwritten methods
2014-11-19 14:52:09 +01:00
Morris Jobke
9368de5a8b
Merge pull request #11789 from owncloud/fix-11762
...
[LDAP] Login: dont fail with 500 if configured display name attribute is not set
2014-11-11 11:16:41 +01:00
blizzz
dc9ea893fd
Merge pull request #11172 from owncloud/user-ldap-no-bcmath
...
Fix ldap convertSID2Str() / Remove BCMath dependency
2014-11-03 14:03:26 +01:00
Andreas Fischer
d1410b46a9
user_ldap: Reimplement convertSID2Str() without BCMath dependency.
...
Also explicitly format sub-id integers as unsigned, which is required for
32-bit systems.
2014-11-03 12:07:53 +01:00
Arthur Schiwon
05b2a037f2
dont fail with 500 if configured display name attribute is not set
2014-10-27 15:58:23 +01:00
Arthur Schiwon
e16122f2a1
add one simple cache test
2014-10-17 20:16:04 +02:00
Thomas Müller
7e2bff8545
adding unit test to truncate the table
2014-09-16 16:17:25 +02:00
Arthur Schiwon
aa0ddf21b5
adjust static method vars as well
2014-08-29 11:14:36 +02:00
Arthur Schiwon
371cab367d
trigger email detection by Wizard upon any user filter filter change. before it happenend only upon user automatic list filter creation, but not on manual editing
2014-08-29 11:14:36 +02:00
Arthur Schiwon
f47a4a8c15
add unit test for mail detection
2014-08-29 11:14:35 +02:00
Arthur Schiwon
441c600c90
remove Access as hard dependency, inject it instead
2014-08-29 11:14:16 +02:00
Arthur Schiwon
1c0cc6c7bc
fix wizard test, adjust to changed parameters of the tested method, introduced by 9caa354cfc
2014-08-28 11:53:40 +02:00
Arthur Schiwon
dbd51d15e1
Port of #8623
...
set result entry identifier earlier, i.e. before a continue for the same level can happen. otherwise will always get the same value and we end up in an infinite loop
add unit test to make sure the infinite loop never comes back
Conflicts:
apps/user_ldap/tests/wizard.php
2014-08-28 11:52:33 +02:00
Arthur Schiwon
97fd39e983
unify tests
2014-08-18 16:55:08 +02:00
Arthur Schiwon
eb7d70fc39
adjust login test to code changes
2014-08-12 16:13:17 +02:00
Arthur Schiwon
fc6793f2ae
better check whether string resembles a DN, fixes #9887
2014-08-11 16:40:41 +02:00
blizzz
1d520108c5
Merge pull request #9576 from owncloud/bcmath-check
...
LDAP Active Directory Primary Groups support depends on bcmath module
2014-07-18 19:15:36 +02:00
Philippe Jung
c13cb6145b
File written by blizzz
2014-07-14 22:21:56 +02:00
Arthur Schiwon
537468f4c4
make tests deal with missing bcmath
2014-07-11 14:08:19 +02:00
Arthur Schiwon
da490bdbbe
support for AD primary groups
...
support for primary groups
actually the problem is only known on AD, it is only needed to take care of their attributes
adjust to ADs special behaviour
this change was not intended
cache the SID value so it is not requested over and over again
theres only one, use singular
we are access
add tests for new Access methods
add tests for new Group methods
address scrutinizer findings, mostly doc
call ldap_explode_dn from ldap wrapper, enables tests without php5-ldap
PHP Doc
yo dawg, i heard you like backslashes … php doc fix
PHPDoc updated and typos fixed while reviewing
2014-07-08 21:32:21 +02:00
Arthur Schiwon
452efa5fab
Port of LDAP Wizard: get correct total no of users, groups and complete list of groups on big setups #9002
...
fix PHPdoc
Conflicts:
apps/user_ldap/lib/connection.php
add method to count groups on LDAP
Conflicts:
apps/user_ldap/lib/access.php
LDAP Wizard: count users and groups with the power of paged search
Conflicts:
apps/user_ldap/lib/wizard.php
consolidate requirement check
fix PHPdoc
Conflicts:
apps/user_ldap/lib/access.php
Wizard: get really all groups from LDAP by power of Paged Search
Conflicts:
apps/user_ldap/lib/wizard.php
make all this work in an early configuration state in the wizard by marking the config active and ignoring the validation state.
Conflicts:
apps/user_ldap/lib/connection.php
simplify two methods a bit, because they are not used for group search anymore
Conflicts:
apps/user_ldap/lib/wizard.php
remove unused vars; increase scrutinizer happiness
2014-06-25 11:45:55 +02:00
Arthur Schiwon
ba82d80f32
adjust group tests
2014-06-03 12:59:11 +02:00
Arthur Schiwon
3fed96af0e
clean up
2014-06-03 12:59:11 +02:00
Arthur Schiwon
5336e9a156
newlines
2014-06-03 12:59:10 +02:00
Arthur Schiwon
d52fbd7e55
adjust test to changed convention in storing quota
2014-06-03 12:59:10 +02:00
Arthur Schiwon
e07ebdd7d0
adjust user backend test
2014-06-03 12:59:10 +02:00
Arthur Schiwon
b0d1b2557c
adjust Access test
2014-06-03 12:59:09 +02:00
Arthur Schiwon
6d64d7ec3f
LDAP: put out fetching of user meta data into a fully tested class of its own and update them (mail, quota, etc.) directly after mapping. Fixes #7785 properly on master
2014-06-03 12:59:09 +02:00
Morris Jobke
dc36d30953
Remove all occurences of @brief and @returns from PHPDoc
...
* test case added to avoid adding them later
2014-05-19 17:50:53 +02:00
Robin McCorkell
c4f1de63a8
Fix PHPDoc in /apps
2014-05-16 22:21:57 +01:00
Lukas Reschke
cd3ed01483
Fix Typo
...
I guess that should be `default` and not `defautl`, wondering how this ever worked.
2014-05-11 15:24:42 +02:00
Lukas Reschke
340089f270
Merge pull request #8059 from owncloud/countUsersInGroup
...
add optional countUsersInGroup method to group backends
2014-04-14 20:45:12 +02:00
blizzz
9feebeaf40
Merge pull request #7837 from owncloud/fix_7530
...
LDAP: fix determining objectclasses takes long
2014-04-09 12:27:17 +02:00
Arthur Schiwon
2407321625
add tests for LDAP
2014-04-08 12:57:06 +02:00
Arthur Schiwon
422ccf4cdb
add test for cloning and keeping configuration seperate
2014-03-21 15:31:30 +01:00
Arthur Schiwon
6f605ecd67
make tests work on systems without php5_ldap
2014-03-21 10:08:17 +01:00
Arthur Schiwon
3d2ab76347
add tests for cumulativeSearchOnAttribute
2014-03-21 00:17:51 +01:00
Arthur Schiwon
d5690a174e
LDAP: fix and extend tests
2014-02-20 14:05:45 +01:00
Arthur Schiwon
677d83d45f
LDAP: add tests for countUsers
2014-01-08 12:24:29 +01:00
Arthur Schiwon
3e1bdd8a04
remove outdated (thus failing) and anyway insufficient group tests - for now
2013-09-27 13:34:16 +02:00
Arthur Schiwon
05ee6606f1
give test file a proper name
2013-09-27 13:34:16 +02:00
Arthur Schiwon
2cebd8b92e
added user_ldap tests via public api calls
2013-09-27 13:34:16 +02:00
Arthur Schiwon
84f522f406
LDAP: simple tests for the user backend
2013-09-27 13:34:15 +02:00
Thomas Mueller
ef88ceba8c
drop SimpleTest compatibility
2013-01-24 16:47:17 +01:00
Felix Moeller
30d7993e01
Checkstyle fixes: NoSpaceAfterComma
2012-11-04 11:10:46 +01:00
Felix Moeller
e73b817a38
Checkstyle: NoSpaceAfterComma
2012-10-23 22:53:54 +02:00
Thomas Mueller
3829460ab8
adding space between) and {
2012-09-07 15:22:01 +02:00
Bart Visscher
db18218a1b
Space before tab fixes
2012-08-29 20:34:44 +02:00
Arthur Schiwon
a6c5309e16
LDAP: adjust test after refactoring
2012-07-25 12:56:09 +02:00
Arthur Schiwon
819af69972
group LDAP: simple basic tests
2012-04-15 14:50:03 +02:00
Arthur Schiwon
54a9fd2e6a
group LDAP: implemented inGroup()
2012-04-15 14:50:03 +02:00
Arthur Schiwon
e160acefe3
test for ldap group backend
2012-04-14 18:08:40 +02:00