Commit Graph

23500 Commits

Author SHA1 Message Date
Roeland Jago Douma e7a8061130
Merge pull request #23659 from nextcloud/dependabot/npm_and_yarn/camelcase-6.1.0
Bump camelcase from 6.0.0 to 6.1.0
2020-10-26 20:46:39 +01:00
dependabot-preview[bot] 61f7e34d66 Bump camelcase from 6.0.0 to 6.1.0
Bumps [camelcase](https://github.com/sindresorhus/camelcase) from 6.0.0 to 6.1.0.
- [Release notes](https://github.com/sindresorhus/camelcase/releases)
- [Commits](https://github.com/sindresorhus/camelcase/compare/v6.0.0...v6.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-26 18:56:57 +00:00
Roeland Jago Douma 7570daf123
Merge pull request #23696 from nextcloud/fix/noid/fix-share-download-error-message
Return correct error message on share download without read permission
2020-10-26 19:42:54 +01:00
Morris Jobke 0390a90d70
Return correct error message on share download without read permission
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-26 16:22:27 +01:00
Arthur Schiwon fd1fd5afa4
user share manager to determine share ownership
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:28 +01:00
Arthur Schiwon 951887e922
fixes determining whether former user is a share owner
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:28 +01:00
Arthur Schiwon 2e455f632a
split instantiation from business logic in OfflineUser
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:28 +01:00
Arthur Schiwon 002c56de17
add test for active shares flag
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-26 16:05:23 +01:00
blizzz a744583545
Merge pull request #23620 from nextcloud/techdebt/noid/ldap-proxy-classes
LDAP simplify User_Proxy and Group_Proxy signatures
2020-10-26 16:04:12 +01:00
timm2k 60efad45cf
Update CheckSetupController.php 2020-10-26 09:42:01 +01:00
Nextcloud bot f9ea3d8689
[tx-robot] updated from transifex 2020-10-26 02:18:04 +00:00
Roeland Jago Douma b7be09ab2c
Check if array elements exist before using them
It seems that in some recent upgrade here. Not always the entries we
expect are returned. So we should first check if they exist. As to not
spam the log.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-25 22:03:40 +01:00
John Molakvoæ (skjnldsv) 68f1f44e58
Enable theming background transparency
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-25 19:15:52 +01:00
Nextcloud bot ca1dc0009d
[tx-robot] updated from transifex 2020-10-25 02:18:28 +00:00
dependabot-preview[bot] ac249b37e2
Merge pull request #23663 from nextcloud/dependabot/npm_and_yarn/p-queue-6.6.2 2020-10-24 09:50:15 +00:00
dependabot-preview[bot] f350623ea7 Bump p-queue from 6.6.1 to 6.6.2
Bumps [p-queue](https://github.com/sindresorhus/p-queue) from 6.6.1 to 6.6.2.
- [Release notes](https://github.com/sindresorhus/p-queue/releases)
- [Commits](https://github.com/sindresorhus/p-queue/compare/v6.6.1...v6.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-24 08:41:46 +00:00
Nextcloud bot 153ff3d9b7
[tx-robot] updated from transifex 2020-10-24 02:18:45 +00:00
John Molakvoæ 2a154f57ce
Merge pull request #23627 from nextcloud/fix/autocomplete-placeholder-email
Fix sharing input placeholder for emails
2020-10-23 14:39:58 +02:00
John Molakvoæ (skjnldsv) f0c47bfb6d Fix sharing input placeholder for emails
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-23 11:48:23 +00:00
Arthur Schiwon 86e5e7d927
LDAP simplify User_Proxy and Group_Proxy signatures
- make User_Proxy and Group_Proxy easy to instantiate
- simplify dependent code
- move commands to info.xml
- make UpdateGroups job class non-static

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-23 12:25:31 +02:00
Roeland Jago Douma bd4c9d973f
Merge pull request #23632 from nextcloud/techdebt/noid/remove-unused-css
Remove unused sharedfilelist
2020-10-23 10:01:17 +02:00
Nextcloud bot 9aedda5542
[tx-robot] updated from transifex 2020-10-23 02:18:51 +00:00
Vincent Petry 07ec86805d
Remove unused sharedfilelist
It isn't loaded anywhere

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-22 15:21:33 +02:00
Vincent Petry 805676309b
Bring back the restore share button
Fix disabled default file action to still use an anchor element, as this
is used in many other places (and potentially apps).

Adjusted anchor style to not look like it's clickable and added extras
to make sure everything inside still looks clickable as before.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-22 15:06:11 +02:00
Nextcloud bot ca8195d49d
[tx-robot] updated from transifex 2020-10-22 02:19:07 +00:00
Nextcloud bot 2c21adb5a6
[tx-robot] updated from transifex 2020-10-21 02:18:44 +00:00
John Molakvoæ 766590d204
Merge pull request #23173 from nextcloud/feat/comments-sidebar-vue 2020-10-20 20:46:21 +02:00
John Molakvoæ (skjnldsv) 6cd7549509
Bump @nextcloud/vue to 3.0.0
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-20 18:02:45 +02:00
Morris Jobke 8676882bcb
Merge pull request #23581 from nextcloud/fix/theming-tests
Fix theming manifest tests
2020-10-20 14:49:20 +02:00
John Molakvoæ (skjnldsv) 3e1916080a
Add ICommentsManager::load method
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 14:39:28 +02:00
John Molakvoæ (skjnldsv) afa7376522
Cleanup old comments tab
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 13:58:07 +02:00
John Molakvoæ (skjnldsv) e7f5516b4d
Init vue comments tab
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 13:58:06 +02:00
Vincent Petry 08813f541d
UX improvements change status dialog
Focus on the custom message field after picking an emoji.
Hitting the enter key while in the custom message field now triggers
saving.
Disable save buttons while saving is in progress.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-20 12:19:00 +02:00
Vincent Petry f7e1706022
Fix status clearing with initial empty value
When selecting an emoji but not specifying a message, the internal
message value was null which caused a server validation error on
sending.

This fixes the SetStatusModal to always work with an empty string
upfront, as this is the value the field would have if edited and cleared
manually.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-20 12:18:13 +02:00
John Molakvoæ (skjnldsv) a7c4369941
Fix theming manifest tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 11:03:24 +02:00
John Molakvoæ (skjnldsv) 620be7dc22
Also expire share type email
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 10:20:26 +02:00
Nextcloud bot f116595b3f
[tx-robot] updated from transifex 2020-10-20 02:18:38 +00:00
John Molakvoæ 46e04a30a4
Merge pull request #23520 from nhirokinet/patch-1
manifest to report correct favicon size
2020-10-19 19:00:37 +02:00
blizzz 6d2471d36e
Merge pull request #23566 from nextcloud/fix/noid/groupsbymember-apply-group-filter-early-if-possible
LDAP: when nesting is not enabled, the group filter can be applied right away
2020-10-19 15:34:52 +02:00
Roeland Jago Douma 8355f95bef
Merge pull request #23415 from nextcloud/bugfix/23304/some-emojis-are-in-general-other-types
Some emojis are in CHAR_CATEGORY_GENERAL_OTHER_TYPES
2020-10-19 15:05:34 +02:00
dependabot-preview[bot] b2d1c8b335
Merge pull request #22954 from nextcloud/dependabot/npm_and_yarn/v-click-outside-3.1.2 2020-10-19 11:58:30 +00:00
Arthur Schiwon 2ee26b691c
tame psalm. why does it ignore '@property'?
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-19 13:44:32 +02:00
Arthur Schiwon d741c5ab30
when nesting is not enabled, the group filter can be applied right away
- helps performance, but skipping unnecessary entries
- reduces reoccuring info-level log output against groups that do not
  qualify ("no or empty name")

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-19 13:44:32 +02:00
Joas Schilling 8ad1bf69f8
Merge pull request #23497 from nextcloud/bugfix/noid/caldav-timerange-array
CalDavBackend: check if timerange is array before accessing
2020-10-19 12:54:14 +02:00
dependabot-preview[bot] 7f00dbedc2 Bump v-click-outside from 3.1.1 to 3.1.2
Bumps [v-click-outside](https://github.com/ndelvalle/v-click-outside) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/ndelvalle/v-click-outside/releases)
- [Commits](https://github.com/ndelvalle/v-click-outside/compare/v3.1.1...v3.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-19 10:50:01 +00:00
dependabot-preview[bot] d34bdb3428 Bump file-loader from 6.1.0 to 6.1.1
Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/webpack-contrib/file-loader/releases)
- [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/file-loader/compare/v6.1.0...v6.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-19 08:18:12 +00:00
Nextcloud bot b5fd0d98ec
[tx-robot] updated from transifex 2020-10-19 02:17:57 +00:00
Nextcloud bot 25b4b90fdd
[tx-robot] updated from transifex 2020-10-18 02:17:43 +00:00
John Molakvoæ (skjnldsv) 9172b9ad20
Fix sidebar legacy fileinfo
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-17 15:55:14 +02:00
nhirokinet 3a05334f18 manifest to report correct favicon size
In the environment where php-imagick with SVG support is correctly installed, this endpoint returns 512x512 image.
d9015a8c94/apps/theming/lib/Controller/IconController.php (L146)

The problem is in the environment without php-imagick or without SVG support, this will fall back to original, whose default is 128x128; but I thought this is a separate problem. (For this, default image may be enlarged. Should I create another issue if this is important one?)

Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-10-16 15:36:56 +00:00
Julius Härtl 439e21e087
Merge pull request #23348 from nohn/gh20679
Fix #20679 - be more alert about 2FA consequences
2020-10-16 11:57:43 +02:00
Christoph Wurst caa739f96e
Merge pull request #23492 from nextcloud/tests/22305/unreliable-SharedMountTest
SharedMountTest.php:367 is unreliable
2020-10-16 08:39:06 +02:00
Simon Spannagel 9956d13b90 CalDavBackend: check if timerange is array before accessing
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-16 07:50:36 +02:00
Nextcloud bot b13d9bcca6
[tx-robot] updated from transifex 2020-10-16 02:18:11 +00:00
Morris Jobke 512d2edc35
SharedMountTest.php:367 is unreliable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 00:36:23 +02:00
John Molakvoæ 4bcf2ac639
Merge pull request #15999 from gary-kim/bugfix/15954/set-favicon-ico 2020-10-15 17:09:29 +02:00
John Molakvoæ 20e8b266b5
Merge pull request #23448 from nextcloud/fix/sidebar-standalone
Fix app sidebar mountpoint
2020-10-15 07:46:17 +02:00
Nextcloud bot ce57372471
[tx-robot] updated from transifex 2020-10-15 02:18:25 +00:00
Gary Kim dfa17e9174
Allow setting favicon with a .ico file
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-10-14 18:19:23 -04:00
Morris Jobke 02fa6a77c3
Merge pull request #23097 from nextcloud/bugfix/noid/trashbin-query-versions
Restrict query when searching for versions of trashbin files
2020-10-14 22:50:02 +02:00
John Molakvoæ (skjnldsv) 2ead7732a7 Fix app sidebar mountpoint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-14 16:17:53 +00:00
Julius Härtl 2616a784c9
Restrict query when searching for versions of trashbin files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-14 16:38:30 +02:00
Christoph Wurst f464ef050b
Fix type errors detected by Psalm
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-14 15:40:12 +02:00
Nextcloud bot 42fcc74b67
[tx-robot] updated from transifex 2020-10-14 02:18:46 +00:00
dependabot-preview[bot] 12baebce29 Bump dompurify from 2.0.15 to 2.1.1
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.15 to 2.1.1.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.0.15...2.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-13 21:43:15 +00:00
Nextcloud bot 55b923e1fd
[tx-robot] updated from transifex 2020-10-13 19:33:40 +00:00
Morris Jobke 0c67de3109
Merge pull request #23286 from nextcloud/design/deleted-sorting
Sort deleted files by most recently deleted first
2020-10-13 19:42:13 +02:00
blizzz 060286c51a
Merge pull request #23021 from nextcloud/notify-saved-login-auth
allow using saved login credentials for notify
2020-10-13 19:39:31 +02:00
Morris Jobke 776c65de99
Merge pull request #23410 from nextcloud/fix/encryption-decrypt-position-type
The encryption decrypt position can be int or string
2020-10-13 17:50:31 +02:00
Morris Jobke f8ed08ca2a
Merge pull request #23295 from nextcloud/fix/versions-no-space-no-versions-undefined-index
Fix undefined index and consequential damages in versions code
2020-10-13 17:35:35 +02:00
Jan C. Borchardt 0f2f857dc3
Sort deleted files by most recently deleted first
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 17:29:52 +02:00
Morris Jobke 7525fb3408
Merge pull request #23350 from st3iny/fix/14849/share-api-preview-availability
Inidicate preview availability in share api responses
2020-10-13 17:27:27 +02:00
Joas Schilling ee7eb6f2b3
Some emojis are in CHAR_CATEGORY_GENERAL_OTHER_TYPES
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-13 15:32:34 +02:00
Richard Steinmetz 89f7e2ab64
Indicate preview availability in share api responses
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-10-13 14:12:42 +02:00
Christoph Wurst b2de9a6f9e
The encryption decrypt position can be int or string
The public API said string, internally we treated it as int. In reality
both are used. Let's reflect that in the documented argument type.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-13 10:51:22 +02:00
Joas Schilling 00bf7eb60a
Merge pull request #23396 from nextcloud/tests/22305/flipping-versioningtest
VersioningTest.php:729 is unreliable and should be disabled
2020-10-13 09:08:29 +02:00
Nextcloud bot 85570abc9a
[tx-robot] updated from transifex 2020-10-13 02:18:40 +00:00
Morris Jobke 6ce05bc7d7
Return all keys in getAllVersions() instead
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-12 22:17:06 +02:00
Christoph Wurst 02fa3253fe
Fix undefined index and consequential damages in versions code
If the user has no space and there are no versions, there won't be an
`all` index in the versions entry. Hence this triggers a warning and
becomes `null`, afterwards `count`, `foreach` and friends will happily
throw even more warnings and errors because they don't want to play with
`null`. Thus adding a fallback to an empty array.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-12 22:17:06 +02:00
Morris Jobke f2d05eacc6
VersioningTest:729 is unreliable and should be disabled
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-12 22:03:42 +02:00
Morris Jobke deb499d34e
Merge pull request #23300 from sharidas/transfer-ownership-same-user
Stop transfer of ownership between same users
2020-10-12 21:52:37 +02:00
Morris Jobke 78da9532ba
Merge pull request #23317 from nextcloud/fix/contact-update
handle nested properties for contact updates
2020-10-12 21:49:04 +02:00
call-me-matt 1b2386d108
handle nested properties, fixes #20544
Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
2020-10-12 21:27:38 +02:00
John Molakvoæ (skjnldsv) 5a6a5a1639
Drop X-NEXTCLOUD-UID
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-12 16:56:20 +02:00
John Molakvoæ (skjnldsv) 698d4f55f2
Expose CLOUD federation for local users as well
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-12 15:17:14 +02:00
John Molakvoæ fd452e5531
Merge pull request #23323 from nextcloud/dependabot/npm_and_yarn/moment-2.29.1
Bump moment from 2.29.0 to 2.29.1
2020-10-12 14:05:00 +02:00
Morris Jobke b6364cc483
Merge pull request #23310 from nextcloud/enhancement/psalm-typed-qb-mapper
Add template typing to the QBMapper
2020-10-12 13:10:05 +02:00
dependabot-preview[bot] 5dd93369b5 Bump moment from 2.29.0 to 2.29.1
Bumps [moment](https://github.com/moment/moment) from 2.29.0 to 2.29.1.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.0...2.29.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-12 11:05:53 +00:00
Christoph Wurst 2664c7f75f
Type some of the core mappers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-12 11:10:09 +02:00
dependabot-preview[bot] 060eb396a2 Bump @nextcloud/vue from 2.6.9 to 2.7.0
Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 2.6.9 to 2.7.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Commits](https://github.com/nextcloud/nextcloud-vue/compare/v2.6.9...v2.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-12 08:31:03 +00:00
Sujith Haridasan 08bdc549bb Stop transfer of ownership between same users
Stop the transfer of ownership between same user.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
2020-10-12 09:31:49 +05:30
Nextcloud bot 8ae4ff6648
[tx-robot] updated from transifex 2020-10-12 02:18:06 +00:00
Sebastian Nohn d0205ae128 Fix #20679 - be more alert about 2FA consequences
Signed-off-by: Sebastian Nohn <sebastian@nohn.net>
2020-10-11 13:57:29 +02:00
Nextcloud bot d9c3b99907
[tx-robot] updated from transifex 2020-10-11 02:18:42 +00:00
Nextcloud bot 4295fe67b7
[tx-robot] updated from transifex 2020-10-10 02:18:44 +00:00
Roeland Jago Douma 2ec160aec8
Merge pull request #23264 from nextcloud/bug/23177/escape-html
Add local version of escapeHTML
2020-10-09 09:25:05 +02:00
Nextcloud bot 9c21bd22b5
[tx-robot] updated from transifex 2020-10-09 02:18:45 +00:00
Roeland Jago Douma 0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2
Remove setup check for php mail
2020-10-08 22:40:37 +02:00
Joas Schilling 51fbcb0801
Use PSR Logger in event dispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-08 16:52:56 +02:00
Roeland Jago Douma e10cad4a71
Merge pull request #23275 from nextcloud/fix/dashboard-statuses-sort
Fix dashboard statuses sort
2020-10-08 15:23:09 +02:00