Commit Graph

23037 Commits

Author SHA1 Message Date
Morris Jobke 264250937e Return all keys in getAllVersions() instead
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 15:46:34 +00:00
Christoph Wurst 92ac576e1c Fix undefined index and consequential damages in versions code
If the user has no space and there are no versions, there won't be an
`all` index in the versions entry. Hence this triggers a warning and
becomes `null`, afterwards `count`, `foreach` and friends will happily
throw even more warnings and errors because they don't want to play with
`null`. Thus adding a fallback to an empty array.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-13 15:46:31 +00:00
Morris Jobke 68c106b689 VersioningTest:729 is unreliable and should be disabled
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 07:13:14 +00:00
Nextcloud bot 17dd0b8248
[tx-robot] updated from transifex 2020-10-13 02:18:49 +00:00
Morris Jobke ad191f8846
Merge pull request #23282 from nextcloud/backport/23269/stable19
[stable19] Fix the user remove from group in UI
2020-10-12 21:39:37 +02:00
Sujith Haridasan 904e33abcb Fix the user remove from group in UI
Fix the removal of user from the group in UI.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-12 15:48:08 +00:00
Nextcloud bot 2a32e73fc2
[tx-robot] updated from transifex 2020-10-12 02:18:15 +00:00
Nextcloud bot 66a50d1a7f
[tx-robot] updated from transifex 2020-10-11 02:18:52 +00:00
Nextcloud bot 132efb8123
[tx-robot] updated from transifex 2020-10-10 02:18:54 +00:00
Nextcloud bot 8ac3a6d954
[tx-robot] updated from transifex 2020-10-09 02:18:54 +00:00
Roeland Jago Douma 759f47cba3
Merge pull request #23212 from nextcloud/backport/23096/stable19
[stable19] Also check the path based mimetype for flow rule checks
2020-10-08 11:52:09 +02:00
Nextcloud bot bafa390482
[tx-robot] updated from transifex 2020-10-08 02:18:54 +00:00
Robin Appelman 683142e1f3
also give storage backend it's change to manipulate the config
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-07 15:44:09 +02:00
Nextcloud bot bf530996d6
[tx-robot] updated from transifex 2020-10-07 02:18:24 +00:00
Robin Appelman 597cc797a1
allow using saved login credentials for notify
when only the user is provided, we use to provided user to try and get saved login credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-06 17:05:31 +02:00
Roeland Jago Douma 8f5adecb3b
Merge pull request #23196 from nextcloud/backport/23175/stable19
[stable19] Fix legacy update notifications
2020-10-06 13:28:37 +02:00
Morris Jobke c75378ac86
Merge pull request #23186 from nextcloud/backport/23109/stable19
[stable19] dont hold a transaction during the move to trash
2020-10-06 09:11:44 +02:00
Julius Härtl 9e3bdcd63c Make sure to check the mimetype on the path if a secure one could not be detemined though the content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-06 06:08:08 +00:00
Nextcloud bot 85e5e7141b
[tx-robot] updated from transifex 2020-10-06 02:18:48 +00:00
Sujith Haridasan 17705b69aa Fix the user email issue while creating a user
When the user is created, the provisioning api
was not adding the email address of the user
when provided if the `send email to new user`
is not set.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
2020-10-05 19:34:19 +00:00
mrtnmtth aa989b7777 Fix legacy update notifications
Signed-off-by: mrtnmtth <mrtn.mtth@gmx.de>
2020-10-05 14:08:14 +00:00
Robin Appelman f6bf519e55
dont hold a transaction during the move to trash
because moving to trash can take a long time, keeping a transaction active for the duration can lead to issues

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-05 15:27:31 +02:00
Nextcloud bot 3759bef671
[tx-robot] updated from transifex 2020-10-05 02:18:52 +00:00
Nextcloud bot a1b2b5ddd4
[tx-robot] updated from transifex 2020-10-04 02:18:24 +00:00
Nextcloud bot 993d07de8c
[tx-robot] updated from transifex 2020-10-02 11:06:28 +00:00
Roeland Jago Douma 8b25f10d2c
Merge pull request #23137 from nextcloud/fix/19/settings_ignore_js
[stable19] Fix ignoring the correct settings files for translations
2020-10-02 12:44:44 +02:00
Roeland Jago Douma 3250629946
[stable19] Fix ignoring the correct settings files for translations
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-02 12:34:54 +02:00
Roeland Jago Douma 916f6124b0
Merge pull request #22941 from nextcloud/backport/22395/stable19
[stable19] Fix settings chunk loading
2020-10-01 10:51:07 +02:00
Joas Schilling eec45af773
Merge pull request #23086 from nextcloud/backport/22983/stable19
[stable19] Sync all users to the system addresssbook
2020-10-01 09:31:03 +02:00
Nextcloud bot 99e5940a7f
[tx-robot] updated from transifex 2020-10-01 02:18:43 +00:00
Nextcloud bot 27d982e4bb
[tx-robot] updated from transifex 2020-09-30 02:18:26 +00:00
Joas Schilling ee29d6ab11 Sync all users to the system addresssbook
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-29 07:18:56 +00:00
Nextcloud bot 0d4ea5fc63
[tx-robot] updated from transifex 2020-09-29 02:18:06 +00:00
Roeland Jago Douma 164096aa26
Merge pull request #22804 from nextcloud/backport/stable19/22116-22648-22761
[stable19] Fix share transfer of single files and on the transfered node
2020-09-28 19:15:12 +02:00
Roeland Jago Douma bd037f8298
Merge pull request #22988 from nextcloud/backport/22533/stable19
[stable19] Flow: do not hide "matches" and "does not match" checkers
2020-09-28 19:13:17 +02:00
Roeland Jago Douma c091fbd5b9
Merge pull request #23002 from nextcloud/backport/22940/stable19
[stable19] Never copy the share link when the password is forced
2020-09-28 18:56:57 +02:00
Joas Schilling 2169b7d484
Never copy the share link when the password is forced
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-28 16:19:50 +02:00
Roeland Jago Douma 93dbaed5c3
Merge pull request #23049 from nextcloud/backport/23034/stable19
[stable19] Fix numeric folders throwing on markDirty
2020-09-28 15:00:56 +02:00
Nextcloud bot 26b1d3d9e4
[tx-robot] updated from transifex 2020-09-28 02:17:58 +00:00
Nextcloud bot a10b6c8277
[tx-robot] updated from transifex 2020-09-27 02:17:34 +00:00
Nextcloud bot 3b0a89be04
[tx-robot] updated from transifex 2020-09-26 02:17:59 +00:00
Joas Schilling 3fe6b5b5f8 Fix numeric folders throwing on markDirty
TypeError: strpos() expects parameter 1 to be string, int given

The problem is that in cacheNode() we strip of any slashes, so
a folder "0/" will be trimmed to "0" and be used as an array key.
Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-25 13:14:58 +00:00
Nextcloud bot 066eafb172
[tx-robot] updated from transifex 2020-09-25 02:18:59 +00:00
Nextcloud bot 2c7b88454d
[tx-robot] updated from transifex 2020-09-24 02:17:59 +00:00
Nextcloud bot 617174b519
[tx-robot] updated from transifex 2020-09-23 02:18:00 +00:00
Arthur Schiwon 83beefc3eb
do not hide "matches" and "does not match" checkers
- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-22 12:42:56 +02:00
Nextcloud bot dcceb1360f
[tx-robot] updated from transifex 2020-09-22 02:17:57 +00:00
Nextcloud bot c2977c5c0f
[tx-robot] updated from transifex 2020-09-21 02:17:33 +00:00
Nextcloud bot 1681e74d2d
[tx-robot] updated from transifex 2020-09-20 02:17:17 +00:00
Nextcloud bot c8f9fa1830
[tx-robot] updated from transifex 2020-09-18 19:05:38 +00:00
John Molakvoæ (skjnldsv) 9d15d718bb
Fix settings chunk loading
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-18 15:57:38 +02:00
Julius Härtl 7ea6ed6224
Merge pull request #22926 from nextcloud/backport/22915/stable19
[stable19] improve handling of out of space errors for smb
2020-09-18 13:13:36 +02:00
Nextcloud bot 34793138c7
[tx-robot] updated from transifex 2020-09-18 02:17:08 +00:00
Robin Appelman 67543d77a0 improve handling of out of space errors for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-17 18:43:43 +00:00
Julius Härtl 818b69ec54
Transfer shares if no path provided
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-17 19:03:07 +02:00
Julius Härtl 14c3f1ebd8
Transfer shares of the transferred root node
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-17 19:03:07 +02:00
Nextcloud bot 8c2c8fd831
[tx-robot] updated from transifex 2020-09-17 02:27:15 +00:00
Robin Appelman f140e3a03a only get the permissions from the share source if it's not already cached
this prevents having to setup the share source when doing metadata stuff on the share root

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-16 17:29:02 +00:00
Nextcloud bot c1a7a026f6
[tx-robot] updated from transifex 2020-09-16 02:17:02 +00:00
Nextcloud bot 871d9a614e
[tx-robot] updated from transifex 2020-09-15 10:48:39 +00:00
Georg Ehrke ac87e46dff Mitigate encoding issue with user principal uri
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-14 06:20:32 +00:00
Roeland Jago Douma 9e88559e94
Merge pull request #22775 from nextcloud/fix/noid/stable19-ldap-group-update-events
[stable19] makes LDAP's group updater dispatch type events
2020-09-11 08:45:49 +02:00
Roeland Jago Douma d43eeab39d
Merge pull request #22778 from nextcloud/backport/22739/stable19
[stable19] Don't fail if copying a file of 0 byte size
2020-09-11 08:45:21 +02:00
Roeland Jago Douma b9ef2a543f
Merge pull request #22776 from nextcloud/backport/22747/stable19
[stable19] fix s3 doesDirectoryExist check for empty directories
2020-09-11 08:45:06 +02:00
Roeland Jago Douma cd29f22ee7
Merge pull request #22591 from nextcloud/backport/22577/stable19
[stable19] Better error message when blocked by access control
2020-09-11 08:43:52 +02:00
Arthur Schiwon 51fa743c7a
makes LDAP's group updater dispatch type events
* fixes group share updates on added users

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-10 15:18:47 +02:00
Julius Härtl f5dec3702b Properly catch exception from writing to stream when copying a file
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 13:18:11 +00:00
Julius Härtl b946d2c444 Set delimiter so that the CommonPrefixes response can properly be determined
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 13:14:28 +00:00
Robin Appelman 30ea77c673 fix s3 doesDirectoryExist check for empty directories
if a directory is empty, only the 'marker' object `/` exists.

since not all s3 implementations return just the prefix when listing objects by prefix,
when listing objects by the folder prefix, nothing will be returned if the directory is empty.
by not including the trailing slash in the prefix, the folder marked will always be returned if it exists

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-10 13:14:28 +00:00
Roeland Jago Douma b5cb33ed36
Merge pull request #22753 from nextcloud/backport/22651/stable19
[stable19] Fix reading empty files from objectstorage
2020-09-10 08:45:01 +02:00
Julius Härtl 7dc51204d3
Merge pull request #22630 from nextcloud/backport/22583/stable19 2020-09-10 08:43:53 +02:00
Roeland Jago Douma 24b69b2402 Fix reading empty files from objectstorage
Since we try to do range requests this will fail hard.
However since empty files are not that interesting to read anyways we
just read from an emptry memory stream.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-09 19:47:23 +00:00
Morris Jobke 969da6cca6
Merge pull request #22713 from nextcloud/backport/stable19/22557
[stable19] Do not fail if share for mountpoint is no longer available
2020-09-09 15:10:11 +02:00
Joas Schilling 30db37bbf2 Don't use SELECT DISTINCT when to_char() is used in a WHERE statement
Nice bug in Oracle

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-08 07:42:12 +00:00
Julius Härtl 57eef41da0
Do not fail if share for mountpoint is no longer available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-08 09:14:45 +02:00
Arthur Schiwon 8b291adb08
add repair step to clean up DB off lastFeatureRefresh entries in user prefs
- also removes related app setting "updateAttributesInterval"

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-07 10:50:17 +02:00
Nextcloud bot c3a6f50206
[tx-robot] updated from transifex 2020-09-07 02:16:49 +00:00
Arthur Schiwon 303bac6c75 these code bits were part of old logic that was already refactored out
- only references were in unit tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-06 17:57:08 +00:00
Nextcloud bot 55bad53353
[tx-robot] updated from transifex 2020-09-06 02:17:02 +00:00
Nextcloud bot 123d33bdd3
[tx-robot] updated from transifex 2020-09-05 02:16:55 +00:00
Joas Schilling 94f4e5142f Better error message when blocked by access control
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-04 13:53:18 +00:00
Roeland Jago Douma dc60a81284
Merge pull request #22515 from nextcloud/backport/22472/stable19
[stable19] Fix writing BLOBs to postgres with recent contacts interaction
2020-09-04 12:38:16 +02:00
Roeland Jago Douma 757a35bd01
Merge pull request #22442 from nextcloud/backport/22421/stable19
[stable19] show better quota warning for group folders and external storage
2020-09-04 12:34:15 +02:00
Roeland Jago Douma e7cda28ed4 Upgrade icewind/smb to 3.2.7
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-04 08:28:22 +00:00
Roeland Jago Douma 77edd1e11d
Merge pull request #22553 from nextcloud/backport/22528/stable19
[stable19] Change free space calculation
2020-09-04 08:52:25 +02:00
Nextcloud bot 4c7db572fd
[tx-robot] updated from transifex 2020-09-04 02:17:28 +00:00
Julius Härtl f4dfb96d8d Do not keep the part file if the forbidden exception has retry set to false
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-03 11:06:41 +00:00
Daniel Kesselberg 82239d8e3e Tests only: Forward calls to getUserValue and getAppValue
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-03 07:33:21 +00:00
Daniel Kesselberg 0a5045ec8e Change free space calculation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-03 07:33:20 +00:00
Nextcloud bot 03702d4a70
[tx-robot] updated from transifex 2020-09-03 02:16:48 +00:00
Nextcloud bot 91dfaed96c
[tx-robot] updated from transifex 2020-09-02 02:17:22 +00:00
Nextcloud bot b13326ef1a
[tx-robot] updated from transifex 2020-09-01 02:16:18 +00:00
Christoph Wurst 7ada6e5ab0 Fix writing BLOBs to postgres with recent contacts interaction
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-31 13:09:40 +00:00
Nextcloud bot 07ffd36697
[tx-robot] updated from transifex 2020-08-31 02:16:20 +00:00
Nextcloud bot ba0d3183ce
[tx-robot] updated from transifex 2020-08-30 02:16:16 +00:00
Nextcloud bot b5003ec78c
[tx-robot] updated from transifex 2020-08-29 02:17:58 +00:00
Nextcloud bot fba73a5c39
[tx-robot] updated from transifex 2020-08-28 02:16:32 +00:00
Nextcloud bot 348525426c
[tx-robot] updated from transifex 2020-08-27 02:16:52 +00:00
Robin Appelman a004eedd1e fix tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-26 19:17:43 +00:00
Robin Appelman 4025b95e03 show better quota warning for group folders and external storage
instead of showing the generic 'Your storage is full' message, better explain that it's the group folder/external storage that is full

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-26 19:17:43 +00:00
Roeland Jago Douma c9a1379bdf
Merge pull request #22410 from nextcloud/backport/22359/stable19
[stable19] fix possible leaking scope in Flow
2020-08-26 20:22:37 +02:00
Roeland Jago Douma 7aeb222426
Merge pull request #22427 from nextcloud/backport/21988/stable19
[stable19] Combine body-login rules in theming and fix twofactor and guest styling on bright colors
2020-08-26 20:20:55 +02:00
Nextcloud bot d3efe74f12
[tx-robot] updated from transifex 2020-08-26 02:16:39 +00:00
Julius Härtl 277bcf8f3a Combine body-login rules in theming and fix twofactor and guest styling on bright colors
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-25 19:49:22 +00:00
John Molakvoæ ce8e020ea9
Merge pull request #22414 from nextcloud/backport/22358/stable19 2020-08-25 18:04:14 +02:00
Arthur Schiwon 38e9e72351
compiled assets
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-25 12:27:52 +02:00
Arthur Schiwon 7f6e2c5953 fix possible leaking scope in Flow
- a configured flow can be brought into consideration, despite its event
  was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-25 08:42:24 +00:00
Roeland Jago Douma 5cf3c27a03
Merge pull request #22400 from nextcloud/backport/22394/stable19
[stable19] Fix missing FN from federated contact
2020-08-25 09:38:44 +02:00
Nextcloud bot 1277b89a0c
[tx-robot] updated from transifex 2020-08-25 02:17:52 +00:00
John Molakvoæ (skjnldsv) 060672734b Fix missing FN from federated contact
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-24 16:07:25 +00:00
Arthur Schiwon 8860ab6c5d
fix event icon sizes and text alignment
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-24 14:14:41 +02:00
Roeland Jago Douma b3a32f1887
Merge pull request #22337 from nextcloud/backport/22322/stable19
[stable19] Only copy the link when updating a share or no password was forced
2020-08-24 12:20:00 +02:00
Roeland Jago Douma d8c958907f
Make legacy cipher opt in
* Systems that upgrade have this enabled by default
* New systems disable it
* We'll have to add some wargning in the setup checks if this is enabled

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-24 11:50:04 +02:00
Joas Schilling 2215cbc352 Only copy the link when updating a share or no password was forced
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-24 08:49:01 +00:00
Nextcloud bot 14927afaf7
[tx-robot] updated from transifex 2020-08-24 02:16:55 +00:00
Nextcloud bot 0ed1d67c7f
[tx-robot] updated from transifex 2020-08-23 02:16:53 +00:00
Nextcloud bot 3b85a547df
[tx-robot] updated from transifex 2020-08-22 02:16:39 +00:00
Roeland Jago Douma 687b37fa3c
Merge pull request #22348 from nextcloud/backport/22346/stable19
[stable19] l10n:Correct appid for WebAuthn
2020-08-21 11:06:11 +02:00
Roeland Jago Douma 9c99245ed7
Merge pull request #22341 from nextcloud/backport/22335/stable19
[stable19] Remove encryption option for nextcloud external storage
2020-08-21 09:24:35 +02:00
Roeland Jago Douma cb28b81675
Merge pull request #22333 from nextcloud/backport/22236/stable19
[stable19] CalDAV: Add ability to limit sharing to owner
2020-08-21 09:23:35 +02:00
Michiel Janssens 4478854403 l10n:Correct appid for WebAuthn
Signed-off-by: Michiel Janssens <michiel@nexigon.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-21 07:02:33 +00:00
Nextcloud bot 8b5c9a820d
[tx-robot] updated from transifex 2020-08-21 02:16:55 +00:00
Roeland Jago Douma 779df24b62 Remove encryption option for nextcloud external storage
Fixes #16017

Since it never worked we should not show it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-20 16:29:32 +00:00
Georg Ehrke 7f8e43c7a7 Add ability to limit sharing to owner
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-20 12:51:09 +00:00
Morris Jobke 442d174ac3
Merge pull request #22309 from nextcloud/backport/22221/stable19-2
[stable19] fixing a logged deprecation message
2020-08-20 08:02:01 +02:00
Nextcloud bot db324278b5
[tx-robot] updated from transifex 2020-08-20 02:17:50 +00:00
Arthur Schiwon c8956e8893
simplified backport of #22221, fixing a deprecation log message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-19 23:03:22 +02:00
Morris Jobke d7aa1c00ed
Merge pull request #21983 from nextcloud/backport/21628/stable19
[stable19] fix moving files from external storage to object store trashbin
2020-08-19 21:29:01 +02:00
Joas Schilling fef5925ed4
Merge pull request #22239 from nextcloud/backport/22128/stable19
[stable19] Delete chunks if the move on an upload failed
2020-08-19 15:54:36 +02:00
Nextcloud bot fd9ebeefa2
[tx-robot] updated from transifex 2020-08-19 02:17:21 +00:00
Nextcloud bot 6bcb656c5d
[tx-robot] updated from transifex 2020-08-18 02:17:38 +00:00
Nextcloud bot 6bdafb1aa9
[tx-robot] updated from transifex 2020-08-17 02:16:48 +00:00
Nextcloud bot b0470cca30
[tx-robot] updated from transifex 2020-08-16 02:16:38 +00:00
Nextcloud bot 9d77e2ce40
[tx-robot] updated from transifex 2020-08-15 02:17:25 +00:00
Roeland Jago Douma 10ee9791ff
Merge pull request #21975 from nextcloud/backport/21658/stable19
[stable19] allow admin to configure the max trashbin size
2020-08-14 05:58:57 +02:00
Nextcloud bot cb4c197555
[tx-robot] updated from transifex 2020-08-14 02:32:09 +00:00
Julius Härtl 2b34f0e785 Return proper status when file didn't exist before
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:06 +00:00
Julius Härtl b83c858e6d Adjust chunking test for non-existing target node
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:06 +00:00
Julius Härtl 242b19f18e Delete chunks if the move on an upload failed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:05 +00:00
Morris Jobke 5ed3f43927
Add app config option to disable "Email was changed by admin" activity
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 13:31:49 +02:00
Roeland Jago Douma 45bdfd2198
Merge pull request #22131 from nextcloud/backport/22062/stable19-take2
[stable19] fix display of remote users in incoming share notifications
2020-08-13 09:41:22 +02:00
Roeland Jago Douma 1d123c0ccb
Merge pull request #22181 from nextcloud/backport/21775/stable19
[stable19] Do not exit if available space cannot be determined on file transfer
2020-08-13 05:21:52 +02:00
Nextcloud bot 6327b8a6fb
[tx-robot] updated from transifex 2020-08-13 02:16:48 +00:00
blizzz 33db8a97c9
Merge pull request #22203 from nextcloud/backport/21559/stable19
[stable19] shortcut in reading nested group members when IN_CHAIN is available
2020-08-12 13:42:08 +00:00
Arthur Schiwon f32b1e4856 remove logging message carrying no valuable information
the exception caught is not an error, but due to valid configuration and
code flow is expecting this. For an admin it is confusing, and it carries
no information worth for debugging.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 09:18:39 +00:00
Arthur Schiwon 8fd575527d
adapt tests for nc19
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 10:23:13 +02:00
Roeland Jago Douma 8c753f87fc SSE enhancement
Do not blind concatenate ints. Lets add a _ between them. So that we can
distrinquis them properly

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-12 07:11:19 +00:00
Nextcloud bot 659fb3cf06
[tx-robot] updated from transifex 2020-08-12 02:16:59 +00:00
Arthur Schiwon ebb565f7a8
do not flip available state to unavailable, allow empty results
- the detection relies that the first, requested result is not empty
- it might be empty though – groups without members
- protect switching from available to unavailable
  - switching the other way around was also not envisaged either

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 00:34:15 +02:00
Arthur Schiwon 74bde3eb49 LDAP: shortcut in reading nested group members when IN_CHAIN is available
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-11 22:24:38 +00:00
Roeland Jago Douma eded52eae7
Merge pull request #22183 from nextcloud/backport/21173/stable19
[stable19] Fix empty 'more' apps navigation after installing an app
2020-08-11 20:25:55 +02:00
Roeland Jago Douma e55591b0f8
Merge pull request #22171 from nextcloud/backport/21728/stable19
[stable19] Reuse cache for directory mtime/size if filesystem changes can be ignored
2020-08-11 15:18:52 +02:00
Jan-Christoph Borchardt 53d99755c5 Fix empty 'more' apps navigation after installing an app
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-08-11 09:30:40 +00:00
Morris Jobke 7f49492117 Use constant instead of magic number
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-11 09:20:08 +00:00
Julius Härtl 3606b4a8ba Do not exit if available space cannot be determined on file transfer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-11 09:20:03 +00:00
Daniel Kesselberg 778e5afcc5 Remove unexpected argument
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-11 07:47:32 +00:00
Nextcloud bot df92a97f5b
[tx-robot] updated from transifex 2020-08-11 02:17:07 +00:00
Julius Härtl 112e2f6747 Reuse cache for directory mtime/size if filesystem changes can be ignored
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-10 13:32:29 +00:00
Nextcloud bot 72e4cd0b93
[tx-robot] updated from transifex 2020-08-09 02:16:47 +00:00
Nextcloud bot 724b59476d
[tx-robot] updated from transifex 2020-08-07 02:16:51 +00:00
Joas Schilling 5728f23b57
Short php syntax
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-06 12:43:47 +02:00
Joas Schilling f213617704
Fix missing placeholders in translations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-06 12:43:47 +02:00
Arthur Schiwon c6becac993
effectively revert 17fae47bdb fixing i10n
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-06 12:43:47 +02:00
Arthur Schiwon f13d5a3ec0
coding style fixes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-06 12:43:47 +02:00
Arthur Schiwon 69a3829940
fix check for Cloud ID, missing return statements, wrong param use
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-06 12:43:47 +02:00
Nextcloud bot dd60e3282d
[tx-robot] updated from transifex 2020-08-06 02:17:22 +00:00
Nextcloud bot 02680cf93d
[tx-robot] updated from transifex 2020-08-05 02:17:09 +00:00
Nextcloud bot 789db73ca5
[tx-robot] updated from transifex 2020-08-04 02:16:40 +00:00
Nextcloud bot 9d56c5142b
[tx-robot] updated from transifex 2020-08-01 02:17:12 +00:00
Robin Appelman 193b3ead51
fix object store trashbin handling
object stores are "special" given how they interact with the cache on their own

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-31 17:21:28 +02:00
Arthur Schiwon b791ea755d reset the cookie internally in new API when abandoning paged results op
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-07-31 08:19:23 +00:00
Nextcloud bot 891e0ccd6e
[tx-robot] updated from transifex 2020-07-31 02:17:32 +00:00
Morris Jobke dba3b513e3
Merge pull request #22050 from nextcloud/dependabot/npm_and_yarn/stable19/elliptic-6.5.3
[Security] Bump elliptic from 6.5.2 to 6.5.3
2020-07-31 00:45:05 +02:00
dependabot-preview[bot] b609a0fe23 [Security] Bump elliptic from 6.5.2 to 6.5.3
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-30 16:05:56 +00:00
Morris Jobke de70dcf708
Merge pull request #21981 from nextcloud/backport/21972/stable19
[stable19] Fix PHPUnit deprecation warnings
2020-07-30 11:03:54 +02:00
Julius Härtl 7e08cb757b
Properly fetch translation for remote wipe confirmation dialog
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-29 08:47:55 +02:00
Nextcloud bot 73132b56d4
[tx-robot] updated from transifex 2020-07-29 02:17:02 +00:00
Nextcloud bot d44a545a32
[tx-robot] updated from transifex 2020-07-28 02:16:48 +00:00
Nextcloud bot 4ceda884ac
[tx-robot] updated from transifex 2020-07-27 02:16:42 +00:00
Nextcloud bot 46715762ce
[tx-robot] updated from transifex 2020-07-25 02:16:45 +00:00
Morris Jobke 874a1ef500
Merge pull request #21978 from nextcloud/backport/21973/stable19
[stable19] Fix risky test in twofactor_backupcodes
2020-07-24 13:20:05 +02:00
Nextcloud bot a05efb5217
[tx-robot] updated from transifex 2020-07-24 02:17:02 +00:00
Robin Appelman b6a600e653 rollback cache rename if trashbin move fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:23 +00:00
Robin Appelman c567b1d6b2 fix moving files from external storage to object store trashbin
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.

By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:22 +00:00
Morris Jobke c813a9e4fb Replace deprecated assertArraySubset with logic that does the same
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:26:45 +00:00
Morris Jobke c4bedf468e Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:26:45 +00:00
Morris Jobke 1d290e15e8 Use assertStringContainsString instead of assertContains on strings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:26:44 +00:00
Morris Jobke 5e97f39dad Fix risky test in twofactor_backupcodes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:25:40 +00:00
Joas Schilling c0317e95e0 Improve error reporting on sharing errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-23 19:14:26 +00:00
Morris Jobke 4570534fed
Merge pull request #21967 from nextcloud/backport/21963/stable19
[stable19] Respect default share permissions
2020-07-23 17:28:38 +02:00
Robin Appelman 38db847164 allow admin to configure the max trashbin size
this allows an admin to configure the max trashbin size instead of always relying on the users quota.

The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 14:30:07 +00:00
npmbuildbot[bot] 9ba82fe435 Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-23 13:07:03 +00:00
Roeland Jago Douma fad4f95d56
Merge pull request #21955 from nextcloud/backport/21949/stable19
[stable19] update icewind/smb to 3.2.6
2020-07-23 12:28:05 +02:00
Roeland Jago Douma 3811a5ebad Respect default share permissions
Else we'll always create new shares with the max permissions.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 08:55:55 +00:00
Nextcloud bot 7246ffff9b
[tx-robot] updated from transifex 2020-07-23 02:17:13 +00:00
Robin Appelman d588471f2f update icewind/smb to 3.2.6
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-22 20:22:31 +00:00
Nextcloud bot 5b5cc637e8
[tx-robot] updated from transifex 2020-07-22 02:16:48 +00:00
Julius Härtl ba55e0ad53 Encryption is ready if master key is enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-21 11:44:58 +00:00
Nextcloud bot 0a90eeb62c
[tx-robot] updated from transifex 2020-07-21 02:17:16 +00:00
Morris Jobke d2c152f46b
Merge pull request #21876 from nextcloud/backport/21855/stable19
[stable19] fix typo in revokeShare()
2020-07-20 14:15:15 +02:00
Nextcloud bot ec69ab4ed4
[tx-robot] updated from transifex 2020-07-19 02:17:16 +00:00
Nextcloud bot e56d52fbc0
[tx-robot] updated from transifex 2020-07-18 02:17:08 +00:00
Nextcloud bot 95093e4f27
[tx-robot] updated from transifex 2020-07-17 02:17:21 +00:00
Roeland Jago Douma 387c179e55
Merge pull request #21840 from nextcloud/backport/21838/stable19
[stable19] Do not log RequestedRangeNotSatisfiable exceptions in DAV
2020-07-16 20:46:10 +02:00
Roeland Jago Douma 6506860561
Merge pull request #21782 from nextcloud/backport/21777/stable19
[stable19] lower minimum search length to 2 characters
2020-07-16 20:44:53 +02:00
Sergej Pupykin e400719f73 fix typo 2020-07-16 18:17:26 +00:00
Nextcloud bot 1822eec68f
[tx-robot] updated from transifex 2020-07-16 02:19:41 +00:00
Morris Jobke c50e13c30e
Merge pull request #21834 from nextcloud/backport/21832/stable19
[stable19] Build source maps on production build again
2020-07-15 12:56:00 +02:00
Nextcloud bot 49562ba840
[tx-robot] updated from transifex 2020-07-15 02:19:49 +00:00
Roeland Jago Douma a3238c3790 Do not log RequestedRangeNotSatisfiable exceptions in DAV
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-14 19:47:14 +00:00
Julius Härtl e16b221cf3 Build source maps on production build again
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-14 13:47:20 +00:00
Nextcloud bot 46b2469329
[tx-robot] updated from transifex 2020-07-14 02:17:30 +00:00
Nextcloud bot 72b59cbc14
[tx-robot] updated from transifex 2020-07-13 02:17:14 +00:00
Nextcloud bot 7cb5614d7a
[tx-robot] updated from transifex 2020-07-12 02:16:58 +00:00
Nextcloud bot 7b84055158
[tx-robot] updated from transifex 2020-07-11 02:17:28 +00:00
Nextcloud bot 6c8cc35b28
[tx-robot] updated from transifex 2020-07-10 02:17:02 +00:00
Robin Appelman a7d4a69898 lower minimum search length to 2 characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 20:28:50 +00:00
Robin Appelman 379cfdda3c better cleanup in share tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 12:33:20 +00:00
Nextcloud bot b19525ebbc
[tx-robot] updated from transifex 2020-07-09 02:17:46 +00:00
Nextcloud bot 667ca8dcb0
[tx-robot] updated from transifex 2020-07-08 02:17:07 +00:00
Julius Härtl 1e930441c4 Do not quote properties when optimizing bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-07 07:55:51 +00:00
Nextcloud bot 882c0c1b26
[tx-robot] updated from transifex 2020-07-07 02:16:41 +00:00
Morris Jobke 62f71a04d2
Merge pull request #21574 from nextcloud/backport/21379/stable19
[stable19] Fix share permission checkboxes enabled when permissions can not be set
2020-07-06 22:59:53 +02:00
Morris Jobke 42d899c4d5
Merge pull request #21710 from nextcloud/backport/21074/stable19
[stable19] Fix releasing a shared lock multiple times
2020-07-06 22:52:46 +02:00
Jaakko Salo 3f1b055828 In LockPlugin, only release a lock if it was acquired
When uploading new files, getNodeForPath() will not succeed
yet so the lock cannot be acquired.

In that case, don't try to unlock it either.

Signed-off-by: Jaakko Salo <jaakkos@gmail.com>
2020-07-06 12:11:47 +00:00
Morris Jobke 2b72b5cea5
Fix unit tests from #18895
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-06 13:34:02 +02:00
Georg Ehrke da522dc3d5 Changes the Birthday calendar color to slightly brighter one
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-06 11:25:17 +00:00
Roeland Jago Douma facace8234
Merge pull request #21342 from nextcloud/backport/21252/stable19
[stable19] update icewind/smb to 3.2.5
2020-07-04 08:58:17 +02:00
Nextcloud bot 4e21bc608c
[tx-robot] updated from transifex 2020-07-04 02:16:25 +00:00
Nextcloud bot a5b279a488
[tx-robot] updated from transifex 2020-07-03 02:17:21 +00:00
Morris Jobke 79b3923a42
Merge pull request #21584 from nextcloud/backport/21530/stable19
[stable19] Remove rescanDelay from directory mtime
2020-07-02 23:35:17 +02:00
Joas Schilling bfdcc4692f
Merge pull request #21405 from nextcloud/backport/21221/stable19
[stable19] Fix pagination of contacts search
2020-07-01 11:53:08 +02:00
Nextcloud bot c0b3cd90a6
[tx-robot] updated from transifex 2020-07-01 02:16:24 +00:00
Roeland Jago Douma eabebe8191
Merge pull request #21583 from nextcloud/backport/21576/stable19
[stable19] fix strings being passed where arrays where expected
2020-06-30 20:41:38 +02:00
Roeland Jago Douma d87245f84c
Merge pull request #21622 from nextcloud/backport/21594/stable19
[stable19] Precalculate the primary element color for dark mode too
2020-06-30 20:31:14 +02:00
Nextcloud bot b7bab49eb8
[tx-robot] updated from transifex 2020-06-30 02:16:20 +00:00
Daniel Calviño Sánchez 87be93126f Fix share permission checkboxes enabled when permissions can not be set
A sharee can reshare a file and set the edit, create, delete and share
permissions of the reshare only if the received share has edit, create,
delete and share permissions, or if they were revoked in the received
share after being set in the reshare. Therefore, the permission
checkboxes in the share menu should be enabled only if the user can set
them (otherwise trying to check them will lead to an error).

Note that "sharePermissions" has all the permissions if the file is not
a reshare but a file owned by the user.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-29 20:16:03 +00:00
Joas Schilling b33c074d6e Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-29 12:08:33 +00:00
Joas Schilling 1c2d8faf34 Precalculate the primary element color for dark mode too
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-29 12:08:33 +00:00
Nextcloud bot e5e833a519
[tx-robot] updated from transifex 2020-06-29 02:16:45 +00:00
Nextcloud bot b2a6b874c4
[tx-robot] updated from transifex 2020-06-28 02:16:19 +00:00
Nextcloud bot 207d3e4a7c
[tx-robot] updated from transifex 2020-06-27 02:16:52 +00:00
Julius Härtl 737b65894b Remove rescanDelay from directory mtime
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-25 14:54:09 +00:00
Arthur Schiwon 43b8b0c14f fix strings being passed where arrays where expected
also brought type hints up to internal API level

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-25 08:06:29 +00:00
Nextcloud bot 8a0185d29b
[tx-robot] updated from transifex 2020-06-25 02:16:52 +00:00
blizzz 58804caf89
Merge pull request #21568 from nextcloud/backport/21564/stable19
[stable19] fix obsolete usage of OCdialogs
2020-06-24 22:44:26 +02:00
Arthur Schiwon 2a3ebe4353 comment was wrong, block is needed nevertheless
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-24 19:07:38 +00:00
Arthur Schiwon 003407e094 fix obsolete usage of OCdialogs
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-24 17:01:17 +00:00
Nextcloud bot 7824599d71
[tx-robot] updated from transifex 2020-06-24 02:16:54 +00:00
Nextcloud bot 86fdf17eed
[tx-robot] updated from transifex 2020-06-23 02:17:20 +00:00
Joas Schilling 127cfeee90 Clarify that the email is always shared within the instance
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-22 06:51:59 +00:00
Nextcloud bot 973c933b71
[tx-robot] updated from transifex 2020-06-21 02:16:17 +00:00
Nextcloud bot b9c7865045
[tx-robot] updated from transifex 2020-06-20 02:16:46 +00:00
blizzz 8e02367453 be more clear about the condition
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
2020-06-19 18:03:07 +00:00
Arthur Schiwon 6f49974851 getXbyY can still return false, e.g. when using ldap write support
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-19 18:03:07 +00:00
Nextcloud bot e5b468fb1a
[tx-robot] updated from transifex 2020-06-19 02:16:37 +00:00
Nextcloud bot 085b076d84
[tx-robot] updated from transifex 2020-06-18 02:16:45 +00:00
Nextcloud bot 556bc6aed3
[tx-robot] updated from transifex 2020-06-17 02:15:53 +00:00
Nextcloud bot c9f0f5a0d9
[tx-robot] updated from transifex 2020-06-16 02:16:14 +00:00
Joas Schilling a8ef2418f2 Fix pagination of contacts search
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-15 06:49:03 +00:00
Nextcloud bot d6923b4bb5
[tx-robot] updated from transifex 2020-06-15 02:16:06 +00:00
Nextcloud bot 3bc6265896
[tx-robot] updated from transifex 2020-06-14 02:16:01 +00:00
Roeland Jago Douma 778f8e87f3
Merge pull request #21354 from nextcloud/backport/21347/stable19
[stable19] Pass the proper share permissions to the create share call
2020-06-11 13:45:21 +02:00
Roeland Jago Douma f37be3af96
Merge pull request #21352 from nextcloud/backport/21311/stable19
[stable19] Always sort shares in a reliable way
2020-06-11 13:23:07 +02:00
Nextcloud bot e146a2b7e6
[tx-robot] updated from transifex 2020-06-11 02:15:59 +00:00
Joas Schilling 0e94a968ef Reflect unreadable state in the UI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-10 08:57:21 +00:00
Roeland Jago Douma 009432dee0 Pass the proper share permissions to the create share call
Fixes #21188

This way we do not run into the share permission issue

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-10 08:55:37 +00:00
Joas Schilling c63039bb83 Always sort shares in a reliable way
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-10 06:55:29 +00:00
Nextcloud bot f40f7abbaf
[tx-robot] updated from transifex 2020-06-10 02:16:16 +00:00
Robin Appelman 61ea03d981 update icewind/smb to 3.2.5
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-09 12:29:43 +00:00
Arthur Schiwon 5b63593956 clear LDAP cache after user deletion
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-09 08:23:42 +00:00
Roeland Jago Douma b20b92441e
Merge pull request #21308 from nextcloud/backport/21198/stable19
[stable19] Only use background fade if nextcloud blue is set
2020-06-09 09:50:13 +02:00
Nextcloud bot d753435452
[tx-robot] updated from transifex 2020-06-09 02:16:05 +00:00
Julius Härtl 69de44ecab Only use background fade if nextcloud blue is set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-08 11:45:56 +00:00
Roeland Jago Douma b876658d70
Merge pull request #21203 from nextcloud/backport/21091/stable19
[stable19] normalize sftp path in read and write stream
2020-06-08 12:15:00 +02:00
Roeland Jago Douma 418c288933
Merge pull request #21287 from nextcloud/backport/21274/stable19
[stable19] Enable passwordless for everyone not only admins.
2020-06-08 11:20:31 +02:00
Nextcloud bot 27549f6729
[tx-robot] updated from transifex 2020-06-08 02:16:05 +00:00
Daniel Kesselberg df75d3ab59 Enable passwordless for everyone not only admins.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-07 13:07:53 +00:00
Nextcloud bot 5795271cef
[tx-robot] updated from transifex 2020-06-07 02:15:59 +00:00
Roeland Jago Douma 513446cafb
Merge pull request #21210 from nextcloud/backport/20938/stable19
[stable19] Fix the Talk verification
2020-06-06 09:31:16 +02:00
Nextcloud bot bcc63c0c2b
[tx-robot] updated from transifex 2020-06-06 02:16:09 +00:00
Thomas Citharel 8cef51bbad Fix empty event UUID reminder notifications
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-06-05 07:04:43 +00:00
Roeland Jago Douma 70c174566b
Merge pull request #21242 from nextcloud/backport/21232/stable19
[stable19] Use \OC::$CLI instead of PHP_SAPI
2020-06-05 08:53:22 +02:00
Nextcloud bot dfe70692d7
[tx-robot] updated from transifex 2020-06-05 02:16:44 +00:00
Thomas Citharel 26f72d1aec Use \OC::$CLI instead of PHP_SAPI
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-06-04 17:06:54 +00:00
Daniel Calviño Sánchez 01ccbe68ff Restore previous state when failing to change video verification state
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-03 14:08:17 +00:00
Christoph Wurst c423a50938 Fix the Talk verification
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).

When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.

We'll have to backport to 18.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 13:51:42 +00:00
Robin Appelman 48c0ac2f12 normalize sftp path in read and write stream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-03 10:19:35 +00:00
Christoph Wurst 25dd585251 Do not only catch Exceptions but any Throwable during rmt share delete
When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 09:13:47 +00:00
Daniel Calviño Sánchez 9a5b51d43c Fix creating a mail share with a password
When a mail share was created with a password the given password was not
hashed, so it was not possible to open the share with that password.
Moreover, if passwords were enforced the given password was ignored and
a new one was set (although in this case it was hashed so it worked as
expected). Now the given password is properly hashed and not overriden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:43 +00:00
Daniel Calviño Sánchez 5de6eb07c0 Extend mail shares unit tests to check the password and mail template
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:42 +00:00
Daniel Calviño Sánchez e9ccb802e8 Fix reference to wrong class name
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 06:48:00 +00:00
Roeland Jago Douma d12e379c96
Merge pull request #21128 from nextcloud/backport/21123/stable19
[stable19] simplify getGroups, fixing wrong chunking logic
2020-05-28 14:59:50 +02:00
Arthur Schiwon 1e5295138a simplify getGroups, fixing wrong chunking logic
pagination is taken care of properly in the search logic in Access class

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-27 17:38:45 +00:00
Christoph Wurst 14b618bcaf
Fix devices & sessions sanitization
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-27 15:57:18 +02:00
Arthur Schiwon 557a3754c1 use the loginname to verify the old password in user password changes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 19:20:42 +00:00
Arthur Schiwon d0559a4871 fixes infinitely repeating LDPA search results with PHP <= 7.2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 09:56:10 +00:00
Morris Jobke 138eddc0f1
Merge pull request #21028 from nextcloud/backport/20629/stable19
[stable19] Don't load text file preview when text app is available (Fixes: #20615)
2020-05-20 13:54:17 +02:00
Julius Härtl dd15780edd Fix share update test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-18 13:47:39 +00:00
Roeland Jago Douma aac0dd1f20 Have share permissions on link shares if it is enabled
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-18 13:47:38 +00:00
Jonas Meurer be37ca1776 Don't load text file preview when text app is available (Fixes: #20615)
When opening a shared text document, the files_sharing app uses
internal preview support in case no other app to open the text file is
available.

So far, it only checks for the old files_texteditor app, not for the new
new text app. This commit fixes this by checking for both.

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2020-05-18 08:59:53 +00:00
Robin Appelman ffc3b48a40 update icewind/smb to 3.2.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-15 12:35:22 +00:00
John Molakvoæ 4bde23d239
Merge pull request #20878 from nextcloud/backport/20719/stable19 2020-05-11 14:55:16 +02:00
Georg Ehrke e048bf8550 Rename app-generated to z-app-generated, because macOS Contacts supports only one and will pick the first one alphabetically
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:56 +00:00
Georg Ehrke d1909526fc Implement ctag and etag in ContactsInteraction
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:55 +00:00
GretaD adbdecb1d6 Fix languages empty array
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 09:25:59 +00:00
John Molakvoæ (skjnldsv) 90a65f83e0 Do not process the same FileInfo twice
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-08 05:39:53 +00:00
Robin Appelman 614acc9419
add locking to resolve concurent move to trashbin conflicts
uses a lock to prevent two requests from moving a file to the trashbin concurrently
(causing sql duplicate key errors)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-06 20:36:55 +02:00
Morris Jobke 06732cf2af
Merge pull request #20832 from nextcloud/fix/sharing-filter-user-shares-only-fix-group-display
Do not filter id matching userId on non-user-share shares
2020-05-06 17:46:21 +02:00
Nextcloud bot 3bf4e7d673
[tx-robot] updated from transifex 2020-05-06 02:16:28 +00:00
John Molakvoæ (skjnldsv) a26ca1e638
Do not filter id matching userId on non-user-share shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv) edecd0931e Fix filtering our owner & current user from shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
Nextcloud bot 09d7854d0e
[tx-robot] updated from transifex 2020-05-05 02:16:14 +00:00
John Molakvoæ (skjnldsv) ff20da637e Fix federated link sharing permissions
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
Morris Jobke 6aceb39714
Merge pull request #19124 from nextcloud/bug/13647/ignore-delete-groups
Exclude groups from sharing: Skip delete groups
2020-05-04 10:02:32 +02:00
Nextcloud bot 43fefee847
[tx-robot] updated from transifex 2020-05-04 02:16:18 +00:00
Nextcloud bot d2f165e448
[tx-robot] updated from transifex 2020-05-03 02:16:16 +00:00
Gary Kim 8dd23f9854
Fix expiry datepicker allowing all dates
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.

This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.

Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 18:58:41 +08:00
Nextcloud bot e77e0b0e2f
[tx-robot] updated from transifex 2020-05-02 02:16:32 +00:00
John Molakvoæ (skjnldsv) 31172a0cd9 Process shares only once, better debug and expiration date code
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-01 13:39:57 +00:00
Roeland Jago Douma b7b7b2872c
Fix owner on publicownerwrapper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-01 10:50:26 +02:00
Roeland Jago Douma c724eb24d5
Merge pull request #20380 from nextcloud/design/notification-mails
Fix design and layout of notification mails
2020-05-01 08:53:39 +02:00
Roeland Jago Douma da9ad9ec78
Merge pull request #20291 from nextcloud/fix/user_menu_not_focused
Fix focus for user actionmenu
2020-05-01 08:42:06 +02:00
Nextcloud bot 9f448d864b
[tx-robot] updated from transifex 2020-05-01 02:16:47 +00:00
Jan-Christoph Borchardt e981669e89
Fix notification mail tests
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-05-01 03:00:42 +02:00
GretaD 9b1f98f6fd Fix the keyboard tab for actionmenu
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-30 19:03:56 +00:00
Roeland Jago Douma b2b8be83f8
Merge pull request #20538 from nextcloud/fix/20520/share-expire
Fix share expiration date not shown
2020-04-30 20:55:05 +02:00
Jan-Christoph Borchardt ae665e2175
Merge pull request #20744 from nextcloud/fix/public-design
Fix public layout header title & description
2020-04-30 19:02:32 +02:00
Gary Kim 02b5ded840
Fix share expiration date not shown
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-30 22:35:52 +08:00
Morris Jobke 0f9b88c5a9
Merge pull request #20718 from nextcloud/fix/public_share_owner_activity_mess
Add a wrapper to fall back to the share owner on public shares
2020-04-30 13:46:13 +02:00
John Molakvoæ (skjnldsv) 6e79fb60d8
Fix public layout header title & description
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-30 13:32:28 +02:00
Joas Schilling 5b5550dbba
Merge pull request #20677 from nextcloud/followup/17718/scaling-user-provisioning
Scaling user provisioning for subadmins with many groups
2020-04-30 12:49:57 +02:00
Roeland Jago Douma b8b53a2d9a
Merge pull request #19436 from nextcloud/bugfix/noid/dav-quota-calculation
Do not include mountpoints when calculating quota usage on WebDAV
2020-04-30 09:13:19 +02:00
Roeland Jago Douma a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar
Provide links to calendar in event creation/update activities
2020-04-30 09:10:56 +02:00
Roeland Jago Douma bc66bdc072
Add a wrapper to fall back to the share owner on public shares
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 08:57:01 +02:00
Roeland Jago Douma 2df57b270c
Merge pull request #20720 from nextcloud/bugfix/noid/temporary-fix-contacts-search
Temporary fix contacts search
2020-04-30 08:52:50 +02:00
Nextcloud bot 523a8ba5c3
[tx-robot] updated from transifex 2020-04-30 02:17:11 +00:00
Roeland Jago Douma d466a7b808 Allow to navigate to others with access from the sidebar
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 17:53:35 +00:00
Joas Schilling f662d3663b
Temporary fix contacts search
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-29 14:48:41 +02:00
Christoph Wurst b219eadb8f
Merge pull request #20714 from nextcloud/fix/license-headers-19
Update license headers for 19
2020-04-29 14:24:27 +02:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
dependabot-preview[bot] 08296c04c0 Bump webpack from 4.42.1 to 4.43.0
Bumps [webpack](https://github.com/webpack/webpack) from 4.42.1 to 4.43.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.42.1...v4.43.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 09:23:51 +00:00
Nextcloud bot 297276baba
[tx-robot] updated from transifex 2020-04-29 02:16:55 +00:00
Morris Jobke 192cf12440
Merge pull request #20636 from nextcloud/tests/noid/tests-for-update-notifications-controller
Add tests for update notification controller for non-default updater …
2020-04-28 16:18:18 +02:00
Morris Jobke 773e9d0554
Add tests for update notification controller for non-default updater server URL
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-04-28 15:28:47 +02:00
blizzz 0c701cec56
Merge pull request #20676 from clementhk/ldap-group
Don't remove last user in ldap group when limit is -1
2020-04-28 12:58:02 +02:00
Roeland Jago Douma c69686a29d
Merge pull request #20673 from nextcloud/enh/tweaks-app-data-scan
Set exit code if something went wrong.
2020-04-28 12:04:25 +02:00
Nextcloud bot ef566a1f40
[tx-robot] updated from transifex 2020-04-28 02:16:22 +00:00
Morris Jobke 31ebc827f7
Merge pull request #20558 from nextcloud/dependabot/npm_and_yarn/vue-click-outside-1.1.0
Bump vue-click-outside from 1.0.7 to 1.1.0
2020-04-27 11:08:21 +02:00
Morris Jobke 1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
Morris Jobke 3c5c4caa4d
Merge pull request #20632 from nextcloud/bugfix/20624
Only catch anonymous OPTIONS for Office
2020-04-27 10:38:32 +02:00
Nextcloud bot e56ffe5992
[tx-robot] updated from transifex 2020-04-27 02:16:13 +00:00
Clement Wong 9f5f505acf Don't remove last user in ldap group when limit is -1
Signed-off-by: Clement Wong <git@clement.hk>
2020-04-27 02:33:00 +02:00
Daniel Kesselberg 3294f53942
Set exit code if something went wrong.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-26 20:37:21 +02:00
Thomas Citharel deb2ea9cea
Provide links to calendar in event creation/update activities
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
Nextcloud bot 0eeb660679
[tx-robot] updated from transifex 2020-04-26 02:16:12 +00:00
Mikael Hammarin 6ffde74928
Patch to optimize for large installations (>5000 users >20000 groups) where subadmins have access to many of groups (>250)
- UsersController:editUser() calls isUserAccessible() even if the user is admin

This fix reduces API calls to editUser (ex change locale/display name) from >2 minutes (!) to ~3 seconds per call in average.

Signed-off-by: Mikael Hammarin <mikael@try2.se>
2020-04-25 14:37:46 +02:00
Nextcloud bot 39f6f1ba34
[tx-robot] updated from transifex 2020-04-25 02:16:01 +00:00
Julius Härtl 902d12555e
Do not include mountpoints when calculating quota usage on WebDAV
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 18:15:43 +02:00
Daniel Kesselberg 16f29d81bf
Ignore delete groups
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-24 18:10:02 +02:00
dependabot-preview[bot] dc46743ef5 Bump vue-click-outside from 1.0.7 to 1.1.0
Bumps [vue-click-outside](https://github.com/vue-bulma/click-outside) from 1.0.7 to 1.1.0.
- [Release notes](https://github.com/vue-bulma/click-outside/releases)
- [Commits](https://github.com/vue-bulma/click-outside/commits/v1.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-24 14:58:19 +00:00
Roeland Jago Douma 768b012000
Merge pull request #20570 from nextcloud/fix/20235/use_uploadfile
Use a proper upload file so propfinds return 404
2020-04-24 16:31:38 +02:00
Roeland Jago Douma 4114bce1e5
Merge pull request #17623 from j3l11234/master
Add support for download share on old android browser
2020-04-24 16:01:45 +02:00
Julius Härtl d7161b4eee
Only catch anonymous OPTIONS for Office
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 14:46:07 +02:00
Roeland Jago Douma 8c07b6e07a
Merge pull request #20626 from nextcloud/enh/scan-appdata-folder-arg
Add folder argument to files:scan-app-data
2020-04-24 13:07:17 +02:00
blizzz 212138daa1
Merge pull request #19919 from nextcloud/enh/noid/ldpa_group_perf
LDAP Group Backend optimizations
2020-04-24 12:27:27 +02:00
Nextcloud bot 84a3536159
[tx-robot] updated from transifex 2020-04-24 02:27:55 +00:00
blizzz 038045d55e
Merge pull request #18816 from nextcloud/bugfix/noid/paginate-contacts-search
Use paginated search for contacts
2020-04-23 22:20:58 +02:00
Arthur Schiwon 4babdc082b
formatting
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-23 21:34:05 +02:00
Julius Härtl 6709833dc7
Use paginated search for contacts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:08:16 +02:00
blizzz 24e58947d6
Merge pull request #20618 from nextcloud/bugfix/noid/fix-workflow-ui
Fix workflow UI
2020-04-23 17:16:33 +02:00
Joas Schilling 335b1f15f3
Fix workflow UI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-23 13:52:04 +02:00
Robin Appelman 7a4ea4a6b6
make php-cs happy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-23 13:35:30 +02:00
Nextcloud bot 79e3823d72
[tx-robot] updated from transifex 2020-04-23 02:16:54 +00:00
blizzz 4a8871f5f2
Merge pull request #19399 from nextcloud/smb-read-acl
Add option to check share ACL's when listing directories
2020-04-22 23:16:12 +02:00
Roeland Jago Douma 8c5bb22bc1
Merge pull request #20576 from nextcloud/fix/dav/oc-etag
Make sure that OC-ETag is set again
2020-04-22 22:21:22 +02:00
John Molakvoæ d0a57a33a9
Merge pull request #20595 from nextcloud/fix/ie11-fallback-upload
Fix IE11 upload fallback methods
2020-04-22 22:06:56 +02:00
Morris Jobke f0ad46dec8
Merge pull request #20575 from nextcloud/fix/sharing-suggestions
Fix Sharing recommendation user display
2020-04-22 14:56:01 +02:00
Roeland Jago Douma acdc68e1e2
Merge pull request #20591 from nextcloud/fix/settings
Fix settings routing
2020-04-22 14:45:25 +02:00
Robin Appelman 7f32fe6d50
add tooltip to option
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-22 14:25:33 +02:00
John Molakvoæ (skjnldsv) 754fd40e40
Fix IE11 upload fallback methods
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-22 13:40:23 +02:00
Morris Jobke 8ffa762486
Merge pull request #20536 from nextcloud/fix/noid/ldap-73api-read-wo-pagedresults
do not run paged results against ldap_read ops on PHP7.3+
2020-04-22 13:37:43 +02:00
Roeland Jago Douma e983ae3b06
Add folder argument to files:scan-app-data
If you need to rescan something but don't feel like rescanning your
whole preview stash.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-22 13:27:33 +02:00
Roeland Jago Douma c870b6ab2e
Fix new routing in settings etc
Also prefix resources
Unify the prefix handling
Handle urls with and without slash

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-22 13:09:25 +02:00
Nextcloud bot ac57bbcf99
[tx-robot] updated from transifex 2020-04-22 02:17:06 +00:00
Robin Appelman 23e2baeb95
Add option to check share ACL's when listing directories
If a file or folder in a directory doesn't have read permissions they
will not be shown

Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.

Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-21 16:26:12 +02:00
Roeland Jago Douma 8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
Arthur Schiwon 75c686d825
do not run paged results against ldap_read ops on PHP7.3+
- previously it was needed as the PHP LDAP handling of paged results was
strange
- but now the read operation would fail, e.g. with extra home dir attribute
set ("Home dir attribute can't be read from LDAP for uid: foobar"

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-21 15:47:49 +02:00
Julius Härtl 5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:29 +02:00
Julius Härtl 45c3ee7f36
Set proper share type when converting link shares to federated shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:28 +02:00
Daniel Kesselberg 0e925285b7
Add test that shares and tags are ignored for chunk files.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-21 14:00:52 +02:00
Roeland Jago Douma aa79f9ada2
Merge pull request #20577 from nextcloud/bugfix/noid/sabre4_aftermethod
Fix usages of afterMethod -> afterMethod:*
2020-04-21 13:26:13 +02:00
Morris Jobke 89bd8ea449
Merge pull request #20564 from go2sh/fix_fileinfo
Set fileInfo correctly for LegacyTabs
2020-04-21 12:24:54 +02:00
Roeland Jago Douma 8730cc6764
Use a proper upload file so propfinds return 404
Fixes #20235

By using an UploadFile we make sure that we don't need to have another
check everywhere for the path. But we just have ot check (which we have
to anyway) if it is a proper Connector/File (or directory).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:33:28 +02:00
Georg Ehrke effcd58e14
Fix usages of afterMethod -> afterMethod:*
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-21 10:19:06 +02:00
Roeland Jago Douma 4ee56689a8
Make sure that OC-ETag is set again
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:14:31 +02:00
John Molakvoæ (skjnldsv) 7eceba7dae Fix Sharing recommendation user display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-21 07:48:10 +00:00
Nextcloud bot f0c1041d2e
[tx-robot] updated from transifex 2020-04-21 02:16:40 +00:00
Robin Appelman 9735b5d61f
Add method to storage backends to get directory content with metadata
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-20 15:45:04 +02:00
Nextcloud bot b1a90da347
[tx-robot] updated from transifex 2020-04-20 02:16:12 +00:00
Christoph Seitz c9e0ea525b Set fileInfo correctly for LegacyTabs
Watch for changes of the fileInfo prop and propagate it to,
the underlying component.

Fixes #20106.

Signed-off-by: Christoph Seitz <christoph.seitz@posteo.de>
2020-04-19 22:56:30 +02:00
Nextcloud bot e9930aebc7
[tx-robot] updated from transifex 2020-04-19 02:16:10 +00:00
Joas Schilling 1b93d5f1db
PHP CS fixes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 685d7b0637
Directly use the class to get the service
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 031b6656d1
Reduce noise in test output
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 9654a924ab
Fix route definitions of cloud_federation_api
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling e45c87cd2e
Fix creating the share controller
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 708b4991d9
Fix legacy routes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling f93d55eebd
PHP CS fixes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 3f8168b6e5
Allow some apps to have root URLs in their own routing file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Roeland Jago Douma 64196ddd19
Merge pull request #20449 from liamjack/fix/19066/empty_file_versions
Array offset error due to empty file versions array
2020-04-18 10:54:19 +02:00
Roeland Jago Douma ad603fd13a
Merge pull request #20540 from nextcloud/fix/mail-test
Fix mailer test
2020-04-18 10:34:04 +02:00
Roeland Jago Douma 2fc35d10e4
Added trailing space
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-18 10:26:35 +02:00
Nextcloud bot 148bdabd58
[tx-robot] updated from transifex 2020-04-18 02:16:28 +00:00
Arthur Schiwon ab550d682f
do not rerun expensive sanitizer against already processed DNs
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:49:47 +02:00
Arthur Schiwon 32000dd1af
read records from DB for lists at once, not one by one.
Keep a runtime cache of dn-id-mapping

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:39:54 +02:00
Arthur Schiwon cc31c38277
don't circulate with only one backend
- saves some overhead costs
- in some occasions saves LDAP requests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:38:52 +02:00
Arthur Schiwon e8ddb4718c
consolidate groupsMatchFilter in groupsExist
- less duplication
- profiting of the same cache entry

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:38:07 +02:00
Roeland Jago Douma ed56619a20
Merge pull request #19901 from nextcloud/bugfix/noid/vcard-photo-handling
Improved vcard photo handling
2020-04-17 11:43:20 +02:00
John Molakvoæ 7c4b7e9329
Merge pull request #20529 from nextcloud/fix/Card-multiple
Update list of multiple properties
2020-04-17 10:39:19 +02:00
John Molakvoæ 36f9ad32f2
Merge pull request #20447 from liamjack/fix/13287/welcome_email
Increase max-height on button in welcome email template
2020-04-17 09:42:49 +02:00
John Molakvoæ (skjnldsv) 29541322c1
Update list of multiple properties
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-17 09:38:47 +02:00
Morris Jobke 9bd9c2bf32
Merge pull request #20381 from nextcloud/fix/allow_edit_admin_user
Allow to edit admin user
2020-04-17 09:06:58 +02:00
Nextcloud bot a8809f079b
[tx-robot] updated from transifex 2020-04-17 02:16:31 +00:00
GretaD d17c58eeec
Allow to edit admin user
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-16 11:59:01 +02:00
Roeland Jago Douma 8971403ada
Merge pull request #20511 from nextcloud/fix/cs-fixer-ldap
PHP-CS-Fixer green
2020-04-16 10:37:49 +02:00
Roeland Jago Douma d9990b09b8
PHP-CS-Fixer green
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:25:17 +02:00
Roeland Jago Douma bb4dedb015
Provide the proper language to the mailer
Else we can't properly translate the footer in the recipients e-mail
language.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:04:13 +02:00
Nextcloud bot 078ac97939
[tx-robot] updated from transifex 2020-04-16 02:17:30 +00:00
Georg Ehrke fe4527a8e2
Update Contact Size after removing photo
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-15 15:49:49 +02:00
Joas Schilling 648c8df516
Don't populate the PHOTO property when it's not an image
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:39 +02:00
Joas Schilling bb754cb363
Always transform the etag and read the data
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:36 +02:00
Joas Schilling 2e9f105786
Use table variable everywhere
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:12 +02:00
Arthur Schiwon 73271aa086
DAV's exception logger should deal with any Throwable
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-15 15:28:37 +02:00
blizzz 8bc381f104
Merge pull request #20037 from nextcloud/fix/19127/deprecated-ldap_control_paged_result_1
do not use deprecated API for LDAP paged results
2020-04-15 15:02:51 +02:00
Morris Jobke d8557d0d8a
Merge pull request #19540 from jlutran/fixKeystoneV3Auth
Fix issues with Keystone auth v3 in files_external app
2020-04-15 14:05:32 +02:00
Joas Schilling 5c0637bc90
Merge pull request #20138 from nextcloud/bugfix/noid/make-remote-checking-more-generic
Make remote checking more generic
2020-04-15 12:48:49 +02:00
Roeland Jago Douma 19171d77e2
Merge pull request #19191 from laurisb/patch-1
Improve Opcache detection
2020-04-15 11:03:05 +02:00
Julien Lutran 3e849daf11
Fix issues with Keystone auth v3 in files_external app
Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
2020-04-15 10:33:08 +02:00
Roeland Jago Douma d63abebc93
Merge pull request #19351 from nextcloud/dav-upload-hash
Return hashes of uploaded content for dav uploads
2020-04-15 10:23:22 +02:00
Roeland Jago Douma b212151af1
Merge pull request #20476 from nextcloud/techdebt/php-cs-check-action
Add php-cs check action
2020-04-15 08:30:29 +02:00
Joas Schilling fd0c1a3bb2
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 08:06:51 +02:00
Nextcloud bot bccd13ffae
[tx-robot] updated from transifex 2020-04-15 02:17:12 +00:00
Joas Schilling 609b8aff12
Also disallow ; in remote urls
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-14 18:56:06 +02:00
Joas Schilling 5e402f8aae
Check all remotes for local access
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-14 18:56:06 +02:00
Christoph Wurst 833d1d2c3b
Fix php-cs formatting
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-14 17:53:44 +02:00
Roeland Jago Douma d7a74d0e35
Merge pull request #20472 from nextcloud/fix/19848/make-sure-destination-is-not-a-directory
Verify that destination is not a directory.
2020-04-14 15:20:46 +02:00
Arthur Schiwon 84619a5b9c
use serverControls directly with LDAP calls, fixes 19127
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-14 12:58:28 +02:00
Daniel Kesselberg 91ab811824
Verify that destination is not a directory.
Otherwise file_put_contents will fail later.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 12:52:12 +02:00
John Molakvoæ (skjnldsv) 47146a1992 Properly display share error messages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-14 08:39:40 +00:00