Commit Graph

19199 Commits

Author SHA1 Message Date
Roeland Jago Douma a34085e1a2 Move 2fa backupscode to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 5ee9e1f784 Move 2FA registration to IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 46872e3921
Merge pull request #26617 from nextcloud/fix/oracle-column-check-unrelated-migrations
Do not check Oracle column constraints in unrelated migrations
2021-04-20 20:49:06 +02:00
Roeland Jago Douma f31d24dd7a
Merge pull request #26647 from nextcloud/bugfix/noid/empty-filename
Fail when creating new files with an empty path
2021-04-20 20:47:16 +02:00
Joas Schilling 3cf447ac44
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +02:00
Joas Schilling 2b8e47dcac
Correclty use plural for share exception
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:40 +02:00
Joas Schilling 5a514a9a41
Correctly replace all PHP placeholders with the parameters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:05 +02:00
Joas Schilling 439457d2b4
Fix languages that miss a string in the translation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
Joas Schilling a4c6749b02
Add a check for the pipe character
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
Joas Schilling 157147cb8e
"Symfony\Component\Translation\PluralizationRules" is deprecated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
Arthur Schiwon f8d1ee5cfa
ignore mail shares of related remote share results
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:02:35 +02:00
Julius Härtl 8398762d78
Fail when creating new files with an empty path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 11:20:20 +02:00
Nextcloud bot 79116e825c
[tx-robot] updated from transifex 2021-04-20 02:25:58 +00:00
Christoph Wurst 2ab8268128
Do not check Oracle column constraints in unrelated migrations
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-19 13:05:34 +02:00
Roeland Jago Douma fc11617222 Deprecate the old way
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +02:00
Roeland Jago Douma 808e589035 Allow registering NotifierServices trough IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +02:00
Joas Schilling 25d11b5197
Fix constraint violation detection in QB Mapper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 10:12:17 +02:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry 8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Nextcloud bot 8ef920fdf9
[tx-robot] updated from transifex 2021-04-15 02:25:10 +00:00
Roeland Jago Douma f031dd61c1
Merge pull request #26551 from nextcloud/fix/noid/redis-exists-bool
ensure redis returns bool for hasKey
2021-04-14 13:37:23 +02:00
Roeland Jago Douma 644ce9e4f0
Merge pull request #26529 from J0WI/getSystemValue-type
Use correct getSystemValue type
2021-04-14 13:36:56 +02:00
Nextcloud bot 7081c63d09
[tx-robot] updated from transifex 2021-04-14 02:26:51 +00:00
Arthur Schiwon 9f5480eef4
ensure redis returns bool for hasKey
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-13 23:07:54 +02:00
Joas Schilling 421914b4d0
Merge pull request #26467 from nextcloud/feature/noid/allow-apps-to-log-to-audit
Allow apps to log actions into the audit_log
2021-04-13 08:52:08 +02:00
Nextcloud bot bab06b9abb
[tx-robot] updated from transifex 2021-04-13 02:24:57 +00:00
J0WI 74a7c2eefc Use correct getSystemValue type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-12 22:54:50 +02:00
Roeland Jago Douma 789bb0d0ac
Merge pull request #26266 from nextcloud/future-proof-networking
Improve networking checks
2021-04-12 12:42:33 +02:00
Joas Schilling 6d502041e0
Fix version
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-12 10:31:10 +02:00
Joas Schilling 99e5367208
Move to another namespace and class name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 12:51:57 +02:00
Joas Schilling ca939214bd
Allow apps to log actions into the audit_log
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 10:32:45 +02:00
Nextcloud bot 9de329a4c2
[tx-robot] updated from transifex 2021-04-09 02:25:11 +00:00
Roeland Jago Douma 2bedbc1793
Merge pull request #26439 from nextcloud/increase-subnet-matcher
Increase subnet matcher
2021-04-08 14:48:27 +02:00
Lukas Reschke 2befac662c Limit size of properties to 2048 characters
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-08 11:55:51 +02:00
Lukas Reschke e5a4236e68 Increase subnet matcher
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-07 12:28:59 +00:00
Nextcloud bot c391e8692b
[tx-robot] updated from transifex 2021-04-07 02:24:14 +00:00
Lukas Reschke 4b4971ab52
Merge pull request #24966 from nextcloud/jknockaert-patch-1
avoid fread on directories and unencrypted files
2021-04-06 13:45:10 +02:00
Lukas Reschke 5fe1f134f9 Strictify null check
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:39:24 +00:00
Lukas Reschke d5c7bb2188 Generate autoload files
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +00:00
Lukas Reschke 5f3abffe6f Improve networking checks
Whilst we currently state that SSRF is generally outside of our threat model, this is something where we should invest to improve this.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +00:00
Nextcloud bot e9075b02cd
[tx-robot] updated from transifex 2021-04-06 02:25:33 +00:00
Nextcloud bot bb3ba96b37
[tx-robot] updated from transifex 2021-04-05 02:24:46 +00:00
Nextcloud bot bfd926938f
[tx-robot] updated from transifex 2021-04-04 02:24:48 +00:00
Nextcloud bot 6f55d2e293
[tx-robot] updated from transifex 2021-04-03 02:25:32 +00:00
Nextcloud bot 4bea123c7a
[tx-robot] updated from transifex 2021-04-02 02:26:04 +00:00
Morris Jobke 5fb909faa5
Merge pull request #24055 from nextcloud/bugfix/noid/enfore-no-notnull-for-boolean-to-store-false
Enforce no notnull for boolean to store false
2021-04-01 18:30:26 +02:00
Julius Härtl 6fd571461c
Properly handle creating the template directory in a subfolder (fixes #25787)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +02:00
Julius Härtl 37591f05dc
Get the parent directory before creating a file from a template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +02:00
Julius Härtl bbc64cfabc
Merge pull request #26394 from nextcloud/feature/noid/updatable-account-data
Allow apps to write/update account data
2021-04-01 08:05:54 +02:00
Robin Appelman 65b78515bd
make ILDAPProviderFactory usable when there is no ldap setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-31 15:23:33 +02:00
Joas Schilling fcedbc85d0
Allow apps to write/update account data
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 15:18:25 +02:00
Joas Schilling f9d4fa2d38
Rename the method to match what it does
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:18 +02:00
Joas Schilling 3696ef5b96
Don't allow Notnull for boolean columns
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +02:00
Joas Schilling 133a6f4fe4
Document the constraints we test against
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +02:00
Joas Schilling c98cab137c
Fix exception messages spacing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:10 +02:00
Nextcloud bot 855b5fc638
[tx-robot] updated from transifex 2021-03-31 02:24:50 +00:00
kesselb 2212a67fbc
Merge pull request #25961 from nextcloud/enh/events/2fa_provider
Add real events for enabled 2fa providers for users
2021-03-30 23:13:36 +02:00
Roeland Jago Douma f3738eeff7
Merge pull request #25280 from nextcloud/explicit-file-permissions
Set umask before operations that create local files
2021-03-30 21:55:50 +02:00
Roeland Jago Douma 7c30d1aa2d
Merge pull request #26219 from nextcloud/relative-path-null
getRelativePath can return null
2021-03-30 21:10:05 +02:00
Arthur Schiwon be3ae9a44b
gracefully handle deleteFromSelf when share is already gone
- handling race conditions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 12:59:40 +02:00
Joas Schilling 602de272c0
Merge pull request #26243 from nextcloud/enh/noid/avatar-privacy-new-scope
Avatar privacy and new scope
2021-03-29 09:01:12 +02:00
Nextcloud bot be83a32411
[tx-robot] updated from transifex 2021-03-28 02:24:04 +00:00
Morris Jobke 83c7b54ba6
Merge pull request #26327 from nextcloud/fix-get-return
fix return value of Root::get
2021-03-27 22:26:32 +01:00
Nextcloud bot aec9c8437a
[tx-robot] updated from transifex 2021-03-27 02:24:25 +00:00
Robin Appelman c8736e7a23
fix return value of Root::get
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-26 21:29:24 +01:00
Vincent Petry 5a8b7c1cb2
Update autoloader for PlaceholderAvatar
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +01:00
Vincent Petry cc54f718f5
Add known user check in avatar when v2-private scope
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +01:00
Vincent Petry bb008be28a
Added PlaceholderAvatar with own cached images
When avatar scope is private, the PlaceholderAvatar is used to deliver a
placeholder avatar based on the user's initials.

This was implemented as a separate class for now to avoid messing with
the existing UserAvatar implementation and its generated vs
non-generated logic.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
Vincent Petry b73df5846c
Add property scope tests for AccountManager
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
Vincent Petry 266a6fb5f8
OCS allow reading and writing account property scopes
Extends the provisioning API to allow a user to get and set their own
account property scopes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry 278a73789e
Map old account scope properties to new names
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry b81a1c1bdb
Add new v2-private account scope
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.

Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:05 +01:00
Roeland Jago Douma a75f0e62fa
Merge pull request #26308 from nextcloud/enhancement/timed-job-interval-description
Document that the TimedJob interval is in seconds
2021-03-26 10:45:50 +01:00
Roeland Jago Douma 9fd29173cf
Merge pull request #26281 from hosting-de/fix/email
Change my email address
2021-03-26 09:59:35 +01:00
Christoph Wurst 389623a910
Document that the TimedJob interval is in seconds
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-26 09:13:05 +01:00
Morris Jobke 81fef4ddee
Log when a storage is marked as unavailable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 16:19:08 +01:00
Roeland Jago Douma f97491eb8f
Merge pull request #26285 from nextcloud/techdebt/noid/cleanup-update-events
Remove event listener to udpate events that are not present anymore
2021-03-25 11:12:34 +01:00
Morris Jobke ad16b19ec7
Merge pull request #21484 from nextcloud/better-forbidden-path-errors
show better error messages when a file with a forbidden path is encountered
2021-03-25 09:15:52 +01:00
Morris Jobke 3388758d04
Remove event listener to udpate events that are not present anymore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 09:01:09 +01:00
Roeland Jago Douma c15172bc4e
Merge pull request #21641 from nextcloud/techdebt/noid/bye-bye-database-xml
Bye bye database xml
2021-03-25 08:58:07 +01:00
Nextcloud bot 9af8c0b380
[tx-robot] updated from transifex 2021-03-25 02:25:39 +00:00
Morris Jobke ab48d5e8cb
Cleanup unneeded code around database.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-24 22:15:44 +01:00
Joas Schilling bb0c50717c
Bye bye database.xml
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 20:04:12 +01:00
Robin Appelman aee4caed07
show better error messages when a file with a forbidden path is encountered
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 17:13:09 +01:00
Robin Appelman db0e198fe0
improve type handling of Avatar::generateAvatarFromSv
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 17:09:53 +01:00
Johannes Leuker e9ca59ef0a Change my email address
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-24 15:13:56 +01:00
Robin Appelman 8a92229485
getStorage can also return null
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:56:40 +01:00
Robin Appelman e8184eaaad
proper error for search results outside user folder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:33:35 +01:00
Robin Appelman f842608c95
getRelativePath can return null
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:30:29 +01:00
Joas Schilling 02c011c4f7
Make debugging easier which header is being set
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 13:22:44 +01:00
John Molakvoæ (skjnldsv) 2074d87d0c
Catch invalid cache source storage path
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-24 10:36:51 +01:00
Robin Appelman e5dc1a8085
Set umask before operations that create local files
this solves issues where "other php stuff" is messing with the umask

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 14:52:31 +01:00
Nextcloud bot a81408a8e1
[tx-robot] updated from transifex 2021-03-23 02:24:02 +00:00
Morris Jobke 1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node
Handle limit offset and sorting in files search
2021-03-22 21:48:51 +01:00
Morris Jobke 1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +01:00
Morris Jobke 268acd301d
Merge pull request #25529 from nextcloud/fix-non-lgc-glyphs-in-avatars-and-txt-file-previews
Fix non LGC glyphs in avatars and txt file previews
2021-03-22 21:06:22 +01:00
Roeland Jago Douma 3c5cf825b3 Add real events for enabled 2fa providers for users
* Shiny new events
* Listener to still emit the old event

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-22 20:57:10 +01:00
Joas Schilling f35d7adf7d
Don't hardcode the product name to Nextcloud but use the theming value
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-22 16:32:35 +01:00
John Molakvoæ (skjnldsv) 15767643f2
Fix sharebymail tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +01:00
Daniel Calviño Sánchez f99876997a
Remove duplicated query for email shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +01:00