fcedbc85d0
Allow apps to write/update account data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 15:18:25 +02:00
f9d4fa2d38
Rename the method to match what it does
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:18 +02:00
3696ef5b96
Don't allow Notnull for boolean columns
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +02:00
133a6f4fe4
Document the constraints we test against
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +02:00
c98cab137c
Fix exception messages spacing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:10 +02:00
855b5fc638
[tx-robot] updated from transifex
2021-03-31 02:24:50 +00:00
2212a67fbc
Merge pull request #25961 from nextcloud/enh/events/2fa_provider
...
Add real events for enabled 2fa providers for users
2021-03-30 23:13:36 +02:00
f3738eeff7
Merge pull request #25280 from nextcloud/explicit-file-permissions
...
Set umask before operations that create local files
2021-03-30 21:55:50 +02:00
7c30d1aa2d
Merge pull request #26219 from nextcloud/relative-path-null
...
getRelativePath can return null
2021-03-30 21:10:05 +02:00
be3ae9a44b
gracefully handle deleteFromSelf when share is already gone
...
- handling race conditions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 12:59:40 +02:00
602de272c0
Merge pull request #26243 from nextcloud/enh/noid/avatar-privacy-new-scope
...
Avatar privacy and new scope
2021-03-29 09:01:12 +02:00
be83a32411
[tx-robot] updated from transifex
2021-03-28 02:24:04 +00:00
83c7b54ba6
Merge pull request #26327 from nextcloud/fix-get-return
...
fix return value of Root::get
2021-03-27 22:26:32 +01:00
aec9c8437a
[tx-robot] updated from transifex
2021-03-27 02:24:25 +00:00
c8736e7a23
fix return value of Root::get
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-26 21:29:24 +01:00
5a8b7c1cb2
Update autoloader for PlaceholderAvatar
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +01:00
cc54f718f5
Add known user check in avatar when v2-private scope
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +01:00
bb008be28a
Added PlaceholderAvatar with own cached images
...
When avatar scope is private, the PlaceholderAvatar is used to deliver a
placeholder avatar based on the user's initials.
This was implemented as a separate class for now to avoid messing with
the existing UserAvatar implementation and its generated vs
non-generated logic.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
b73df5846c
Add property scope tests for AccountManager
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
266a6fb5f8
OCS allow reading and writing account property scopes
...
Extends the provisioning API to allow a user to get and set their own
account property scopes.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
b81a1c1bdb
Add new v2-private account scope
...
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.
Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:05 +01:00
a75f0e62fa
Merge pull request #26308 from nextcloud/enhancement/timed-job-interval-description
...
Document that the TimedJob interval is in seconds
2021-03-26 10:45:50 +01:00
9fd29173cf
Merge pull request #26281 from hosting-de/fix/email
...
Change my email address
2021-03-26 09:59:35 +01:00
389623a910
Document that the TimedJob interval is in seconds
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-26 09:13:05 +01:00
81fef4ddee
Log when a storage is marked as unavailable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 16:19:08 +01:00
f97491eb8f
Merge pull request #26285 from nextcloud/techdebt/noid/cleanup-update-events
...
Remove event listener to udpate events that are not present anymore
2021-03-25 11:12:34 +01:00
ad16b19ec7
Merge pull request #21484 from nextcloud/better-forbidden-path-errors
...
show better error messages when a file with a forbidden path is encountered
2021-03-25 09:15:52 +01:00
3388758d04
Remove event listener to udpate events that are not present anymore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 09:01:09 +01:00
c15172bc4e
Merge pull request #21641 from nextcloud/techdebt/noid/bye-bye-database-xml
...
Bye bye database xml
2021-03-25 08:58:07 +01:00
9af8c0b380
[tx-robot] updated from transifex
2021-03-25 02:25:39 +00:00
ab48d5e8cb
Cleanup unneeded code around database.xml
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-24 22:15:44 +01:00
bb0c50717c
Bye bye database.xml
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 20:04:12 +01:00
aee4caed07
show better error messages when a file with a forbidden path is encountered
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 17:13:09 +01:00
db0e198fe0
improve type handling of Avatar::generateAvatarFromSv
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 17:09:53 +01:00
e9ca59ef0a
Change my email address
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-24 15:13:56 +01:00
8a92229485
getStorage can also return null
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:56:40 +01:00
e8184eaaad
proper error for search results outside user folder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:33:35 +01:00
f842608c95
getRelativePath can return null
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:30:29 +01:00
02c011c4f7
Make debugging easier which header is being set
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 13:22:44 +01:00
2074d87d0c
Catch invalid cache source storage path
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-24 10:36:51 +01:00
e5dc1a8085
Set umask before operations that create local files
...
this solves issues where "other php stuff" is messing with the umask
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 14:52:31 +01:00
a81408a8e1
[tx-robot] updated from transifex
2021-03-23 02:24:02 +00:00
1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node
...
Handle limit offset and sorting in files search
2021-03-22 21:48:51 +01:00
1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
...
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +01:00
268acd301d
Merge pull request #25529 from nextcloud/fix-non-lgc-glyphs-in-avatars-and-txt-file-previews
...
Fix non LGC glyphs in avatars and txt file previews
2021-03-22 21:06:22 +01:00
3c5cf825b3
Add real events for enabled 2fa providers for users
...
* Shiny new events
* Listener to still emit the old event
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-22 20:57:10 +01:00
f35d7adf7d
Don't hardcode the product name to Nextcloud but use the theming value
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-22 16:32:35 +01:00
15767643f2
Fix sharebymail tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +01:00
f99876997a
Remove duplicated query for email shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +01:00
a100186e5e
Sharing link & mail parity
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +01:00
ae19cb168f
[tx-robot] updated from transifex
2021-03-22 02:23:45 +00:00
8c7e246d98
[tx-robot] updated from transifex
2021-03-21 02:23:12 +00:00
cb2745a541
[tx-robot] updated from transifex
2021-03-20 02:23:44 +00:00
b38618c813
use node search api for legacy file search endpoint
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:08:01 +01:00
bfe3712372
handle ordering in folder search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:07:54 +01:00
82891cd498
Fix phpcs issues in encryption update
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 14:12:10 +01:00
76170a58eb
Log and continue when failing to update encryption keys during for individual files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-19 14:12:07 +01:00
feed42dd6d
folder filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:41:00 +01:00
1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message
...
expand 'path is already shared' error message
2021-03-19 13:39:22 +01:00
de713967c0
cleanup fileinfo creation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:35:37 +01:00
7bf5adb1fa
Merge pull request #26200 from nextcloud/bugfix/26197/fix-expiration-validation-confusion
...
Update user share must use correct expiration validation
2021-03-19 10:51:21 +01:00
a428f7d1e0
format
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:44:30 +01:00
bd229e7548
handle limit and offset in folder file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:38:31 +01:00
50e374c12f
only require user to be set in a query that handles tags
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:16:28 +01:00
a9e3d2a10f
Update user share must use correct expiration validation
...
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.
To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-18 17:12:28 +01:00
f8bca545df
unify handling of Folder::search methods into "new" query objects
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 16:35:41 +01:00
0d8b3baf61
Use executeQuery and executeUpdate in the QBMapper
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-18 15:40:18 +01:00
9e3775618b
log full expection during repair step
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:17 +01:00
c75b82adbb
dont error the entire repair process when a repair step errors
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:16 +01:00
37feee4e87
Merge pull request #24384 from nextcloud/cleanup/remove-old-migration-check
...
Remove dead code from checking core/apps before upgrades
2021-03-17 21:29:19 +01:00
a2f3077ee8
Skip db migration simulation for core schema changes
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-17 21:08:22 +01:00
459e0b311b
Merge pull request #25924 from nextcloud/bugfix/noid/only-mark-migrations-as-installed-after-executing-them-in-case-the-developer-broke-them
...
Only mark migrations as installed after execution
2021-03-17 20:29:28 +01:00
f56e5bb0db
Merge pull request #25676 from nextcloud/drop/utl-is-ie
...
Drop \OCP\Util::isIe
2021-03-17 20:18:11 +01:00
0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
...
Improve search results when only phonebook-matches can we autocompleted
2021-03-17 15:22:03 +01:00
cf434d5107
Also limit to user group in case enumeration is enabled for groups and phonenumbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 11:20:30 +01:00
ab5c19bb08
Merge pull request #26131 from nextcloud/fix/initialstate-templates
...
Fix default missing initial state for templates
2021-03-17 10:18:03 +01:00
3379e69ecc
Fix parameter types in docs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +01:00
9a189bc710
Improve search results when only phonebook-matches can we autocompleted
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +01:00
dd477d30f9
dont allow creating users with __groupfolders as uid
...
Fixes https://github.com/nextcloud/groupfolders/issues/338
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 19:03:10 +01:00
f1e2fb426e
Merge pull request #26013 from nextcloud/object-store-copy-cache-id
...
Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-16 16:11:17 +00:00
e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
...
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
223fe2aae6
Fix default missing initial state for templates
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-15 17:23:30 +01:00
a550649708
expand 'path is already shared' error message
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 15:55:08 +01:00
f512705f8f
Merge pull request #26003 from nextcloud/enh/simplefile/getid
...
Add getID function to the simplefile implementation
2021-03-15 14:41:15 +01:00
d7748e2b4d
verify that cache entry is valid
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:23:02 +01:00
c2fc3195dd
also implement for FailedCache and NullCache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:22:43 +01:00
ad636ae12d
use returned file id for object store copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:22:40 +01:00
d2bcb57a54
add ICopyFromCache trait to expose existing implementation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:22:36 +01:00
32551b9ff7
Merge pull request #25722 from nextcloud/objectstore-copy-cross
...
apply object store copy optimization when 'cross storage' copy is wit…
2021-03-12 16:10:18 +00:00
bf39adb49b
Merge pull request #26049 from nextcloud/search-file-limit-results
...
limit constructing of result objects in file search
2021-03-12 12:58:49 +01:00
7ac6eee129
Merge pull request #26079 from nextcloud/bugfix/noid/chunk-phone-search
...
Chunk the array of phone numbers
2021-03-12 11:20:35 +01:00
2e08c8b5a1
Chunk the array of phone numbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 08:49:23 +01:00
98d2f3bc5c
Merge pull request #26072 from nextcloud/s3-no-explicit-close
...
remove explicit fclose from S3->writeStream
2021-03-12 08:21:54 +01:00
cd3ef614be
[tx-robot] updated from transifex
2021-03-12 02:22:44 +00:00
3eb764e65d
remove explicit fclose from S3->writeStream
...
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 18:05:04 +01:00
b62ee577d7
implement PagedProvider for file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 17:18:38 +01:00
424db15dea
limit constructing of result objects in file search
...
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.
this saves about 40% of the time spend in the search request in my local testing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 14:49:57 +01:00
dd1248d672
Merge pull request #26047 from nextcloud/JakubOnderka-patch-2
...
Fix warning in AppFetcher.php when appstore is disabled
2021-03-11 10:51:35 +01:00
b78dc6a6bf
Merge pull request #26050 from nextcloud/view-search-reuse-usermanager
...
reuse usermanager instance when processing search results
2021-03-11 10:27:30 +01:00
6db7731742
Merge pull request #26015 from nextcloud/dependabot/composer/psr/container-1.1.1
...
Bump psr/container from 1.0.0 to 1.1.1
2021-03-11 08:50:32 +01:00
56b08c04c7
Merge pull request #26031 from nextcloud/feature/noid/allow-autocomplete-based-on-phone-sync
...
Allow autocomplete based on phone sync
2021-03-11 08:29:21 +01:00
b4f6aca624
Clean up the logic of the contacts store a bit
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:48:17 +01:00
61ed57b757
Rename some parameters and methods to make the API more clear
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +01:00
7287a15acb
Bump psr/container from 1.0.0 to 1.1.1
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-10 19:44:09 +01:00
f98fed3f8a
reuse usermanager instance when processing search results
...
saves some time when processing large search results
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 19:35:13 +01:00
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +01:00
c048f0100f
cache baseurl in url generator
...
Servers don't tend to change their url in the middle of a request
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 17:22:31 +01:00
236aa194e2
Restrict autocompletion also based on the phonebook known users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
c7be18c0d6
Add a service to find out if a user knows another user
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
1992d11d7d
Fix warning in AppFetcher.php when appstore is disabled
...
Signed-off-by: Jakub Onderka <ahoj@jakubonderka.cz>
2021-03-10 16:30:02 +01:00
f1bb4e5699
Add a KnownUsers database with model
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 15:05:48 +01:00
c87b1a50d9
apply object store copy optimization when 'cross storage' copy is within the same object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-09 20:31:27 +01:00
7f3051e5bf
Drop \OCP\Util::isIe
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-09 20:29:42 +01:00
fad86afd26
Merge pull request #25533 from nextcloud/resend-share-notifications-on-recreate
...
send share notification instead of erroring on duplicate share
2021-03-09 19:44:22 +01:00
61f13583a2
Merge pull request #25677 from nextcloud/drop/cache-factory-create
...
Drop \OC\Memcache\Factory::create
2021-03-09 19:37:34 +01:00
3da33ce3fc
send share notification instead of erroring on duplicate share
...
when creating a share that already exists, instead of erroring, resend the notifications
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-09 19:20:37 +01:00
95af966f60
Merge pull request #26017 from nextcloud/enh/boostrap/initialstate
...
Move initialstate bootstrap to proper types classes
2021-03-09 16:28:59 +01:00
45cfeefd1b
Merge pull request #25930 from nextcloud/techdept/psalm/25839/RedundantPropertyInitializationCheck
...
Fix RedundantPropertyInitializationCheck
2021-03-09 13:06:55 +01:00
618805b14f
Fix RedundantPropertyInitializationCheck
...
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:49:45 +01:00
2e6cab4d82
Move initialstate bootstrap to proper types classes
...
For more type safety
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:19:23 +01:00
30e096f3f5
Allow overwriting isAuthenticated
...
* Some implementations might check for different things
* IT will not change how the current ones work
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:17:30 +01:00
cc2beee872
Add getID function to the simplefile implementation
...
Sometimes it is useful to get the actual fileid
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 14:59:36 +01:00
43b333331d
Merge pull request #25997 from nextcloud/techdept/psalm/redundantcast
...
Fix some redundant casts
2021-03-08 14:28:11 +01:00
615721df82
Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore
...
Pimp ActionProviderStore
2021-03-08 09:20:45 +01:00
43c8298dec
Merge pull request #25948 from nextcloud/techdebt/noid/depreate-getHTMLName
...
Deprecate getHTMLName on \OCP\Defaults
2021-03-08 08:54:42 +01:00
69b26c73f3
Fix some redundant casts
...
Happier psalm
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:51:08 +01:00
e8f087d7d1
[tx-robot] updated from transifex
2021-03-08 02:23:08 +00:00
c28542ef7f
[tx-robot] updated from transifex
2021-03-07 02:22:07 +00:00
41f9fdab1c
[tx-robot] updated from transifex
2021-03-06 02:22:22 +00:00
e47bd8324d
Merge pull request #25928 from nextcloud/enh/contactsmenu/entry
...
Type Entry and IEntry
2021-03-05 09:46:40 +01:00
11e2286a82
Merge pull request #25588 from nextcloud/techdept/custom-psr-logger
...
Migrate custom loggers to PSR
2021-03-05 09:46:07 +01:00
9dc5b8274e
Deprecate getHTMLName on \OCP\Defaults
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-05 09:34:24 +01:00
54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
...
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +01:00
e6ef096e52
Merge pull request #25659 from nextcloud/smb-getmetadata-catch
...
catch notfound and forbidden exception in smb::getmetadata
2021-03-05 08:49:23 +01:00
3c9a62721f
Merge pull request #25725 from lmamane/master
...
token login: emit preLogin event with LoginName
2021-03-05 08:46:46 +01:00
85e48d796c
Merge pull request #25929 from nextcloud/techdept/psalm/25839/redundantcasts
...
Remove Redundantcasts
2021-03-05 08:42:54 +01:00
a6c9688fd6
[tx-robot] updated from transifex
2021-03-05 02:22:00 +00:00
d7f7d3bc51
Type CompositeExpression and ICompositeExpression
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 21:47:44 +01:00
b844293536
catch notfound and forbidden exception in smb::getmetadata
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-04 21:34:54 +01:00
c3f1eb4f7f
Remove Redundantcasts
...
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:44:04 +01:00
b14be34689
Type Entry and IEntry
...
* Fixed a docblock
* Typed the entries
Psalm happier, Roeland happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:30:21 +01:00
76a6328d10
Add executeQuery and executeUpdate
...
Names shamelessly copied from Doctrine itself.
Internally it is still using the same flow. But I added some checks
around it.
This should make static analysis a bit more happy. Which in turn makes
me more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:03:31 +01:00
f04a2ce19f
Pimp ActionProviderStore
...
* Fix paradoxale condition
* Add types
* Move away from ILogger
Makes psalm happy, and thus me happy
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 12:29:49 +01:00
1e5fea0460
Only mark migrations as installed after execution
...
The problem is that if a developer creates a structural error in their migration file,
they will already be marked as executed and an not be rerun.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-04 08:49:42 +01:00
365d31743f
[tx-robot] updated from transifex
2021-03-04 02:22:10 +00:00
5325c3002c
Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api
...
Remove deprecated \OCP\API
2021-03-03 21:57:34 +01:00
a58b4ceaab
Merge pull request #25889 from nextcloud/techdept/psalm/fix_group_manager_function_return_type
...
Fix types in the Group Manager
2021-03-03 20:55:52 +01:00
cc744740b7
Remove deprecated \OCP\API
...
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +01:00
68ec18323d
Fix types in the Group Manager
...
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 14:52:47 +01:00
Joas Schilling
Nextcloud bot
kesselb
Roeland Jago Douma
Arthur Schiwon
Joas Schilling
Morris Jobke
Robin Appelman
Vincent Petry
Christoph Wurst
Johannes Leuker
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Daniel Calviño Sánchez
Julius Härtl
Christoph Wurst
Jakub Onderka
Lukas Reschke