bc66bdc072
Add a wrapper to fall back to the share owner on public shares
...
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 08:57:01 +02:00
2df57b270c
Merge pull request #20720 from nextcloud/bugfix/noid/temporary-fix-contacts-search
...
Temporary fix contacts search
2020-04-30 08:52:50 +02:00
523a8ba5c3
[tx-robot] updated from transifex
2020-04-30 02:17:11 +00:00
f662d3663b
Temporary fix contacts search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-29 14:48:41 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
ef566a1f40
[tx-robot] updated from transifex
2020-04-28 02:16:22 +00:00
3c5c4caa4d
Merge pull request #20632 from nextcloud/bugfix/20624
...
Only catch anonymous OPTIONS for Office
2020-04-27 10:38:32 +02:00
deb2ea9cea
Provide links to calendar in event creation/update activities
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
39f6f1ba34
[tx-robot] updated from transifex
2020-04-25 02:16:01 +00:00
902d12555e
Do not include mountpoints when calculating quota usage on WebDAV
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 18:15:43 +02:00
768b012000
Merge pull request #20570 from nextcloud/fix/20235/use_uploadfile
...
Use a proper upload file so propfinds return 404
2020-04-24 16:31:38 +02:00
d7161b4eee
Only catch anonymous OPTIONS for Office
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 14:46:07 +02:00
6709833dc7
Use paginated search for contacts
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:08:16 +02:00
8c5bb22bc1
Merge pull request #20576 from nextcloud/fix/dav/oc-etag
...
Make sure that OC-ETag is set again
2020-04-22 22:21:22 +02:00
0e925285b7
Add test that shares and tags are ignored for chunk files.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-21 14:00:52 +02:00
8730cc6764
Use a proper upload file so propfinds return 404
...
Fixes #20235
By using an UploadFile we make sure that we don't need to have another
check everywhere for the path. But we just have ot check (which we have
to anyway) if it is a proper Connector/File (or directory).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:33:28 +02:00
effcd58e14
Fix usages of afterMethod -> afterMethod:*
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-21 10:19:06 +02:00
4ee56689a8
Make sure that OC-ETag is set again
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:14:31 +02:00
b1a90da347
[tx-robot] updated from transifex
2020-04-20 02:16:12 +00:00
ed56619a20
Merge pull request #19901 from nextcloud/bugfix/noid/vcard-photo-handling
...
Improved vcard photo handling
2020-04-17 11:43:20 +02:00
29541322c1
Update list of multiple properties
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-17 09:38:47 +02:00
fe4527a8e2
Update Contact Size after removing photo
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-15 15:49:49 +02:00
648c8df516
Don't populate the PHOTO property when it's not an image
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:39 +02:00
bb754cb363
Always transform the etag and read the data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:36 +02:00
2e9f105786
Use table variable everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:12 +02:00
73271aa086
DAV's exception logger should deal with any Throwable
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-15 15:28:37 +02:00
5c0637bc90
Merge pull request #20138 from nextcloud/bugfix/noid/make-remote-checking-more-generic
...
Make remote checking more generic
2020-04-15 12:48:49 +02:00
d63abebc93
Merge pull request #19351 from nextcloud/dav-upload-hash
...
Return hashes of uploaded content for dav uploads
2020-04-15 10:23:22 +02:00
fd0c1a3bb2
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 08:06:51 +02:00
5e402f8aae
Check all remotes for local access
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-14 18:56:06 +02:00
91ab811824
Verify that destination is not a directory.
...
Otherwise file_put_contents will fail later.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 12:52:12 +02:00
0408c37b3d
Only delete the default calendar setting when the default calendar
...
itself is deleted
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:43 +02:00
ebdf66b706
Provide dav setting for user's default calendar
...
And add tests to handle schedule-default-calendar-URL
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:42 +02:00
57403c7020
dont set headers for cli
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-13 12:57:29 +02:00
c2677682c4
Return hashes of uploaded content for dav uploads
...
hashes are set in "X-Hash-MD5", "X-Hash-SHA1" and "X-Hash-SHA256" headers.
these headers are set for file uploads and the MOVE request at the end of a multipart upload.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-13 12:57:27 +02:00
6187cea304
[tx-robot] updated from transifex
2020-04-13 02:19:45 +00:00
d32ea71c30
[tx-robot] updated from transifex
2020-04-12 03:09:11 +00:00
b5a30d5cd6
Merge pull request #20426 from nextcloud/techdebt/psr2
...
It is done
2020-04-11 08:21:35 +02:00
de52e1cda7
[tx-robot] updated from transifex
2020-04-11 02:18:37 +00:00
734c62bee0
Format code according to PSR2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
3a415e4139
Remove space between switch case and colon
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:17:53 +02:00
a8a06a82d2
Remove trailing whitespaces from comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
42625a46be
Remove spaces after method or function call
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
e266666380
Merge pull request #20188 from nextcloud/bug/19662/add-default-title-for-event-in-invitatios
...
Add default titles for titleless events in invitations
2020-04-07 11:22:17 +02:00
9a4193f557
Merge pull request #19761 from nextcloud/bugfix/19658/add_missing_index_to_original_migration
...
Add missing index to original migration
2020-04-06 09:44:34 +02:00
4a292126e5
Merge pull request #20139 from nextcloud/unify-default-value-for-restricting-user-enumeration-with-settings
...
Unify default value for restricting user enumeration with settings
2020-04-04 10:33:04 +02:00
fba7bcfcc4
Catch NoUserException when running the upload cleanup as cronjob
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-03 23:06:26 +02:00
4e8bbc4e34
[tx-robot] updated from transifex
2020-04-03 12:08:12 +00:00
058ffa37ff
Add default titles for titleless events in invitations
...
Closes #19662
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-03 13:49:25 +02:00
3a88ad741d
Query Application class on publicwebdav
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-02 17:07:53 +02:00
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +02:00
81455479bc
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-02 09:59:44 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
2200cc8562
Merge pull request #19325 from nextcloud/dependachristoph/composer/sabre-4.0
...
Update Sabre (and friends) to 4.0
2020-03-30 09:34:25 +02:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
55081b7fd2
RequestTestCase: Default type for headers needs to be array
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
80b7ef9b41
Adjust FakeLockerPluginTest to new Sabre version
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
5e2c802bb7
Set custom ProdId in Birthday service, do not depend on Sabre Versio number for unit tests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
102a328e65
Fix usage of Sabre\HTTP\Request in unit tests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
52ba75f644
Sabre/DAV 4.0: beforeMethod is now beforeMethod:*
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
25ab122245
Merge pull request #20172 from nextcloud/techdebt/phpunit-short-return
...
Use the shorter phpunit syntax for mocked return values
2020-03-26 09:25:19 +01:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
23eb0462e5
Use lowercase true, false and null constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +01:00
5a33cb0b78
Register an address book with recent contacts
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 16:16:45 +01:00
ba14c41a1c
Merge pull request #20145 from nextcloud/bugfix/noid/generated-avatars-and-nophoto-cache
...
Fix generated avatars and nophoto cache files
2020-03-25 11:14:13 +01:00
3427653676
Merge pull request #19986 from nextcloud/bugfix/19980/fix_uid_as_uri
...
RefreshWebcalService: randomly generate calendar-object uri
2020-03-25 08:11:49 +01:00
e4d85fa284
[tx-robot] updated from transifex
2020-03-25 02:18:27 +00:00
f3a5bd6753
Fix generated avatars and nophoto cache files
...
Since nextcloud/server#19493 newFile() by default does not write the file anymore.
Setting an empty string as content will make it write the file immediate,
without having to call putContent() afterwards.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-24 18:23:38 +01:00
3e338c9075
Merge pull request #18788 from nextcloud/fix/18782/translate-busy-in-caldav
...
Translate 'Busy' in CalDAV
2020-03-24 15:12:21 +01:00
d4f25b01b8
Unify default value for restricting user enumeration with settings
...
If the value was never enabled or disabled, the settings show "Restrict
username enumeration to groups" as disabled. However, in some components
it was enabled by default, which caused an inconsistency in the
behaviour with respect to the settings, for example in the contacts
menu.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-24 14:30:59 +01:00
be4cf8992d
[tx-robot] updated from transifex
2020-03-23 02:19:02 +00:00
42dde6d623
Add check that DateTime parameters are of correct type
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-03-22 14:24:13 +01:00
01db6d4609
Add extra test case to exclude by timerange
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-03-22 14:24:13 +01:00
b0fbba05f2
Added test testSearch
...
Signed-off-by: dartcafe <github@dartcafe.de>
2020-03-22 14:24:13 +01:00
65c591093e
fix OCA\DAV\CalDAV\CalDavBackend search $options
...
Signed-off-by: dartcafe <github@dartcafe.de>
2020-03-22 14:24:13 +01:00
019ba27943
Merge pull request #20042 from nextcloud/fix/noid/styled-dav-browser-error
...
fix dav browser error page not styled
2020-03-22 14:23:17 +01:00
82f8a167a6
use core templates for displaying dav errors in the browser
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-03-20 22:39:22 +01:00
47271e56ee
Fix tests due to config adjustments
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:46:13 +01:00
ae4dc3467c
Return empty system addressbook since we cannot easily limit it to groups
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
0fa897fcfc
Limit enumeration in principal search
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
b285e19dc8
fix dav browser error page not styled
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-03-19 23:44:14 +01:00
150f39ed50
Update autoloaders for composer v1.10.1
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-19 09:48:49 +01:00
4a21ce27ff
[tx-robot] updated from transifex
2020-03-19 02:20:00 +00:00
e44c276aab
rebuild autoloader
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
861c897e93
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
15a21ee19a
remove the detour trough node and work with path directly
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
Roeland Jago Douma
Roeland Jago Douma
Nextcloud bot
Joas Schilling
Christoph Wurst
Morris Jobke
Thomas Citharel
Julius Härtl
Daniel Kesselberg
Georg Ehrke
John Molakvoæ (skjnldsv)
Arthur Schiwon
Joas Schilling
Robin Appelman
John Molakvoæ
Christoph Wurst
Daniel Calviño Sánchez
dartcafe