mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
40,234 Commits 349 Branches 696 Tags 1.6 GiB
Commit Graph

40234 Commits

Author SHA1 Message Date
Lukas Reschke a04feff9a7
Properly allow \OCP\Authentication\IApacheBackend to specify logout URL 
Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string.
This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result
in `<a href="foo">`.

This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with
054e161eb5 inside the navigation manager where one cannot simply inject attributes.

Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112,
people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects
you to the IdP and properly logs you out there as well.

Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to
use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout
URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but
I'm not aware of any and there's simply no way to fix this properly otherwise.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-08-18 12:22:44 +02:00
Nextcloud bot 231cffffb9
[tx-robot] updated from transifex 2017-08-18 00:08:15 +00:00
Morris Jobke 0d956cb4aa Merge pull request #6161 from nextcloud/drone-s3 
Enable S3 tests on drone again
 2017-08-17 19:18:13 +02:00
Lukas Reschke e37cf2d6f0 Merge pull request #6158 from nextcloud/always-log-cron-execution 
Always log cron execution
 2017-08-17 11:14:12 +02:00
Morris Jobke 1c38a83927 Always log cron execution 
There was a setting to disable the last execution of cron. There is no known
problem with this write access and it was also questioned when this feature
was build in https://github.com/owncloud/core/pull/7689#issuecomment-38264707

Recently there was also a bug report about a non-visible last cron execution
(#6088) - let's better remove this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-17 09:45:11 +02:00
Morris Jobke 4ee4d15f01 Enable object storage tests again 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-17 09:40:12 +02:00
Morris Jobke 96a404dfb3 Remove windows config settings in tests 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-17 09:39:49 +02:00
Roeland Jago Douma a53aa40b4d Merge pull request #6126 from nextcloud/trigger-search 
Trigger search after re-focus
 2017-08-17 09:16:13 +02:00
Nextcloud bot 0ceb06fde5
[tx-robot] updated from transifex 2017-08-17 00:08:14 +00:00
Joas Schilling fff192f78f Merge pull request #6136 from nextcloud/fix_groupmanagement 
Fix group management which was broken since #5847
 2017-08-16 14:05:48 +02:00
Morris Jobke f0eb882c2e Merge pull request #6146 from nextcloud/downstream-28073 
Downstream - removal of outdated API
 2017-08-16 11:03:47 +02:00
Vincent Petry 653610559d Bye bye Dropbox v1 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-16 11:03:25 +02:00
Morris Jobke 4c558c99f3 Merge pull request #6130 from nextcloud/cleanup-unused-methods 
Cleanup unused methods
 2017-08-16 08:55:06 +02:00
Nextcloud bot d7406e5159
[tx-robot] updated from transifex 2017-08-16 00:08:33 +00:00
Morris Jobke 8c97218b95 Merge pull request #6128 from nextcloud/primary-font-color-in-capabilities 
Add the primary font color to the capabilities as well
 2017-08-15 21:27:28 +02:00
Morris Jobke 60a485b80d Merge pull request #6132 from nextcloud/do-not-log-maintenance-mode 
Do not log WebDAV maintenance mode exception
 2017-08-15 21:26:18 +02:00
Lukas Reschke f698aa11e7 Merge pull request #6101 from cbartz/patch-1 
Missing array assignment in Swift.php
 2017-08-15 18:17:58 +02:00
Tobia De Koninck 23039e882f Fix group management which was broken since #5847 
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
 2017-08-15 17:47:54 +02:00
Lukas Reschke 422c3e302a Merge pull request #6099 from nextcloud/issue-3457-no-exception-on-sharee-error 
Catch exceptions on error of cloud id resolution
 2017-08-15 17:04:42 +02:00
Morris Jobke fc12bd0be6 Do not log WebDAV maintenance mode exception 
Log the maintenance mode exception only in debug level. Fixes #6124

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-15 15:03:39 +02:00
Morris Jobke a55e794bfd Cleanup unused methods 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-15 14:29:26 +02:00
Morris Jobke cf7c4a4439 Merge pull request #6123 from nextcloud/cleanup-shareItem 
Cleanup usage of shareItem in internal code base
 2017-08-15 13:57:00 +02:00
Morris Jobke c5f14ac884 Merge pull request #6121 from nextcloud/cleanup-registerBackend 
Use proper methods for registerBackend
 2017-08-15 13:52:49 +02:00
Morris Jobke 49b28ebf84 Merge pull request #6118 from nextcloud/cleanup-checkPasswordProtectedShare 
Use proper methods for checkPasswordProtectedShare
 2017-08-15 13:52:05 +02:00
Joas Schilling b7b4cfd6a1
Add the primary font color to the capabilities as well 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-08-15 13:50:08 +02:00
Morris Jobke 5f06380a4f Trigger search after re-focus 
If the share input field is unfocused, the autocomplete list is closed. Once
the field was focused again it was not properly opened again. This adds a
trigger to redo the search and show the results again.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-15 13:36:51 +02:00
Morris Jobke 8366dfa50b Cleanup usage of shareItem in internal code base 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-15 11:57:18 +02:00
Morris Jobke 895b9c2309 Use proper methods for registerBackend 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-15 11:29:15 +02:00
Morris Jobke 3e13e94254 Use proper methods for checkPasswordProtectedShare 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-15 11:28:05 +02:00
Morris Jobke c5c23b30b9 Merge pull request #6116 from nextcloud/cleanup-unused-methods 
Cleanup unused methods
 2017-08-15 11:26:26 +02:00
Morris Jobke f640b56bfa Cleanup unused methods 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-15 10:09:47 +02:00
Nextcloud bot cc40f02684
[tx-robot] updated from transifex 2017-08-15 00:08:15 +00:00
Joas Schilling bd6524455b Document that it throws 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-08-14 22:20:57 +02:00
Joas Schilling 2e73112256 Catch exceptions on error of cloud id resolution 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-08-14 22:20:57 +02:00
Roeland Jago Douma e0f479a4eb Merge pull request #6098 from nextcloud/fix-federation-scope 
Fix federation scope dropdown
 2017-08-14 19:24:27 +02:00
Christopher Bartz bbd8797f1e Remove tmpFiles Array in Swift.php 
tmpFiles Array is unnecessary and there has been
a reference without an assignment which lead to a bug making swift external
storage unuseable.
 2017-08-14 17:35:04 +02:00
Morris Jobke 5b2d6b080f Merge pull request #6080 from nextcloud/header-bottom-border 
Add buttom border for header
 2017-08-14 17:29:03 +02:00
Robin Appelman ca3aef0486 Merge pull request #5872 from nextcloud/swift-filter-dot 
Filter magic dot object when swift directory
 2017-08-14 15:11:53 +02:00
Morris Jobke 317521c7e7 Merge pull request #6091 from nextcloud/authpage-design 
Add heading to account access page
 2017-08-14 14:27:09 +02:00
Morris Jobke 95b7fa306e Merge pull request #6097 from nextcloud/issue-6078-accounts-table-missing 
Make sure the accounts table exists
 2017-08-14 12:14:09 +02:00
Morris Jobke 44c6745159 Remove quotes around device name 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-14 11:48:56 +02:00
Morris Jobke ba8d26a150 Merge pull request #6090 from nextcloud/federationscope-title-bold 
Bold federation scope title in dropdown menu, as intended
 2017-08-14 11:47:47 +02:00
Morris Jobke 3d1f6a041d Fix federation scope dropdown 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-14 11:16:24 +02:00
Morris Jobke 228baa45fd Update autoloader 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-14 11:11:18 +02:00
Morris Jobke bd43758118 Highlight client identifier in auth grant page 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-14 10:42:19 +02:00
Joas Schilling 1c2f628d8e
Fix headers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-08-14 09:53:48 +02:00
Joas Schilling 601f795122
Make sure the accounts table exists 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2017-08-14 09:52:41 +02:00
Morris Jobke 995ddc61d1 Add buttom border for header 
* allows to distinct the header from the rest of the UI for bright colors
* ref #5654

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-08-14 09:40:55 +02:00
Nextcloud bot d1f3e1de96
[tx-robot] updated from transifex 2017-08-14 00:08:21 +00:00
Nextcloud bot ded780a45a
[tx-robot] updated from transifex 2017-08-13 00:08:14 +00:00