9afff2fb20
Properly set uid and create and update
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-01 15:00:49 +01:00
9b3cc72f7c
fix writeStream for jail wrapper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-31 21:10:57 +01:00
93de63777e
extend storage api to allow directly writing a stream to storage
...
this removes the need for temporary storages with some external storage backends.
The new method is added to a separate interface to maintain compatibility with
storage backends implementing the storage interface directly (without inheriting common)
Currently the interface is implemented for objectstorage based storages and local storage
and used by webdav uploads
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-31 21:10:44 +01:00
0efd29f41f
first check if the user is already logged in and then try to authenticate via apache, this way we suppress wrong audit log messages about failed login attempts
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-30 22:14:52 +01:00
1293affc84
Merge pull request #12020 from nextcloud/bugfix/11795/calendar_invitation_fallback_lang
...
Calendar invitation: use system default instead of sender's language as fallback
2018-10-30 22:05:20 +01:00
b9c5e569d3
Update AddressBookImpl documentation
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 14:43:08 +01:00
61af607525
Make enhancing entries with type property optional
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
8b92a6c9cb
Add type of properties to address book results
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
45d8aeb9f2
Remove federated sharing address books which are the same as local ones
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:33 +01:00
70e4884e02
Implement the size of an assembly stream
...
This will make it possible to act propely on moves of future files if we
need to know the size (like for max size virus scanning).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-26 10:43:11 +02:00
5c51d84a67
Calendar invitation: use system default instead of sender's language as fallback
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-24 18:39:30 +02:00
b853102a8f
Merge pull request #11886 from nextcloud/feature/noid/principal_search_displayname
...
Principal property search for users and groups with {DAV:}display name
2018-10-23 21:26:31 +02:00
2f518b6ac8
lazy open first source stream in assemblystream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-22 16:11:13 +02:00
5cfb5ec176
allow group principal search for dav displayname property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
218253db76
allow user principal search for dav displayname property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
10f0296ad6
overwrite Sabre/DAV's handler for calendar-user-type to report correct user type
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
325e366b58
add correct calendar-user-type to resource and room backend
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:13 +02:00
543c863434
Merge pull request #11931 from nextcloud/bug/do_not_emit_pre_hooks_twice_objectstore
...
Do not emit preHooks twice on non-part-storage
2018-10-19 19:56:42 +02:00
851f525889
Merge pull request #11668 from nextcloud/bugfix/7726/convert_caldav_subscription_source_to_long_text
...
convert source column in calendarsubscription table to (long) text
2018-10-19 15:49:17 +02:00
b51e503aea
Do not emit preHooks twice on non-part-storage
...
The old code would emit the hooks twice. Thus having the version written
twice. Which is not very performant as it is first read twice as well.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 12:19:53 +02:00
4e53ea6dbd
Merge pull request #11822 from nextcloud/bugfix/noid/forbid_freebusy_but_allow_local_delivery
...
allow local delivery of schedule message while prohibiting FreeBusy requests
2018-10-18 11:35:51 +02:00
f5dc7b7f07
move disableFreeBusy check from User principal backend to Scheduling Outbox collection. This allows to keep local delivery of scheduling messages while prohibiting FreeBusy requests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-16 20:27:33 +02:00
b458ed9c82
Properly escape column name in "createFunction" call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-16 15:24:02 +02:00
b83918ed6d
convert source column in calendarsubscription table to (long) text
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-15 13:16:31 +02:00
ea21aa3f7a
Use numeric placeholders if there are multiple, so that RTL languages can operate better
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-09 14:32:14 +02:00
1c6f666bbf
adjust Calendar resource / room interfaces to use class implementation
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-08 01:25:20 +02:00
8743fe6bba
Merge pull request #11435 from nextcloud/assemblystream-node-to-small
...
throw an error if a node is smaller than expected in assemblystream
2018-10-01 18:12:49 +02:00
f1f74a39b6
throw an error if a node is smaller than expected in assemblystream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-28 15:40:08 +02:00
6b7a69752c
AssemblyStream is also eof if we have no more source stream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-28 15:09:43 +02:00
83639a9898
remove LogicException, because it's also triggered with legitimate parameters
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-09-05 14:10:26 +02:00
3806ecb242
use the same ignored properties list for both CustomerPropertiesBackends
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-28 18:27:53 +02:00
e2a64c713f
cast timestamps older than unix epoch to 0
...
This change solves issues #10870 , which is caused by method castValue of class FileSearchBackend: It casts the timestamps older than the unix epoch to false., see my comment https://github.com/nextcloud/server/pull/10835#discussion_r212806153 .
2018-08-27 07:44:24 +02:00
b76e6be441
disallow negative mtime in dav search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 16:20:07 +02:00
7aad5b7721
Merge pull request #10543 from nextcloud/ignore-deactivated-users
...
Do not show deactivated users in sharees and contacts
2018-08-10 15:01:14 +02:00
523fdb612c
Add room shares to DAV and recent files "share-types" property
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
c05a0b9fa6
Adding test for table schedulingobjects and fixing postgres LOB
...
(cherry picked from commit afd4ebf0404e8bcd7cba0bec2dce177e97632f8a)
Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
2018-08-06 13:53:32 +02:00
a311798674
Remove users from system addressbook when user deactivated
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-08-06 09:30:21 +02:00
6c5670f6d2
Update IMipPlugin.php
...
Added space before ellipsis
2018-07-30 15:05:55 +02:00
c94ac53e60
Typo fix: Triple dot to ellipsis
...
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2018-07-29 10:15:02 +02:00
1a156c298e
Replace contacts-dark icon with contacts
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:47:54 +02:00
a2df728fb8
Merge pull request #9581 from nextcloud/dav-acl-no-files
...
disable dav acl plugin for files resource
2018-07-20 12:16:45 +02:00
14bc9ffda4
Fixed tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:59 +02:00
d4a51447d1
Fix getting ocs share permissions if a storage is not available
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-18 14:42:39 +02:00
daed1bed57
Also shorten the name of the invitation tokens
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-12 12:11:11 +02:00
b7de6d7a24
Shorten resource table names to allow install on oracle again
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-12 11:55:19 +02:00
d9aa5ed96d
Merge pull request #9942 from nextcloud/feature/2338/invitation_response_in_email
...
Include accept / decline links in CalDAV invitation emails
2018-07-11 19:53:22 +02:00
8399d6070e
always log exceptions on dav write
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-09 14:25:54 +02:00
7025f16017
Merge pull request #9345 from nextcloud/federation20
...
Federation 2.0
2018-07-03 23:13:47 +02:00
27089422e1
Improved logging of smb connection errors
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-03 14:56:37 +02:00
6e9dbe7d15
Merge pull request #10078 from nextcloud/bugfix/activity-277/invalid-actor-and-calendar-for-link-shares
...
Correctly parse the subject parameters for link (un)shares of calendars
2018-07-02 15:43:36 +02:00
a0a6aff772
Correctly parse the subject parameters for link (un)shares of calendars
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-02 13:57:48 +02:00
1f9f5e2e5e
Fix lazy search backend
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-07-02 13:42:41 +02:00
cdf8abb060
look for correct OCM permissions
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-02 11:29:31 +02:00
4aa4e4080c
Include accept / decline links in CalDAV invitation emails
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-29 10:44:44 +02:00
79f16f9d46
Merge pull request #10037 from nextcloud/dav-options-search
...
Fix search related results in OPTIONS requests
2018-06-29 09:36:12 +02:00
89b6ee1a45
Merge pull request #9773 from nextcloud/feature/noid/resource_booking
...
resource booking
2018-06-29 06:51:49 +02:00
b21bec5c73
Fix search related results in OPTIONS requests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-28 14:54:46 +02:00
f3949cf1a8
Add groupware settings section
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-27 19:16:21 +02:00
cba783f5df
Calendar resource booking: unit tests / adding missing annotations
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:59:04 +02:00
8f061f5407
periodically query calendar resource / room backends for updated resource / room information
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:59:01 +02:00
b832edabbf
apply group restrictions to resources
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:07 +02:00
2da510af0b
add resource / room principals
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-25 04:58:07 +02:00
f017f431f6
properly lock the target file on dav upload when not using part files
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-11 15:26:41 +02:00
7ea41a1461
enable caldav for webdav subtree public-calendars
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-08 13:12:34 +02:00
ea4f4b8417
Add sabre plugin to allow anonymous options requests to the dav root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-01 17:20:42 +02:00
f5e16dfaa7
Merge pull request #9609 from nextcloud/bugfix/3830/invitations_for_shared_calendars
...
send invitations for shared calendars
2018-06-01 12:40:53 +02:00
c3fc789b2c
Merge pull request #9550 from nextcloud/bugfix/noid/override_freebusy_sharing_rules
...
allow admins to disable FreeBusy without modifying ShareAPI capabilities
2018-06-01 12:00:56 +02:00
7f301be188
Merge pull request #9583 from nextcloud/files-home-userfolder
...
use getUserFolder instead of getFileInfo when constructing FilesHome
2018-05-29 16:50:01 +02:00
26c1e33d11
Move repairstep to a custom command
...
People that have issues can run it manually
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-28 13:26:55 +02:00
8bf8e92092
Adding repair step which cleans shares of invalid principals
...
edacf22fbc
2018-05-27 20:51:36 +02:00
69e650d0e8
CalDAV and CardDAV plugins need to be registered for the principals collection as well
...
9f2e6431b8
2018-05-27 20:51:36 +02:00
240006bdf5
When sharing calendars and addressbooks the principal has to be verified to be valid
...
d3fb8fcdd3
2018-05-27 20:51:36 +02:00
c5d5c7dc12
Do not load calendar/addressbook plugins if not needed
...
Fixes #6711
Based on f0fb21cf35
2018-05-27 20:51:32 +02:00
a9c313ce45
send invitations for shared calendars
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-25 20:41:50 +02:00
51724a35a4
use getUserFolder instead of getFileInfo when constructing FilesHome
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-24 14:17:53 +02:00
491f01efba
disable dav acl plugin for files resource
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-05-24 14:00:14 +02:00
367ca563b4
allow admins to override FreeBusy capabilities without modifying ShareAPI capabilities
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-05-22 19:16:26 +02:00
d161d4473e
Merge pull request #9029 from nextcloud/settings-restructure
...
Restructure server settings
2018-05-07 12:29:53 +02:00
7cb467b476
Merge pull request #9355 from nextcloud/dav-upload-lock
...
only allow a single concurrent dav write to a file
2018-05-03 16:28:39 +02:00
a77efe0a55
Move dav settings to main server settings
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:22 +02:00
a56ec1062a
Merge pull request #9346 from nextcloud/techdep/noid/needsPartFile_to_storage
...
Use an actual function of the storage to determine needsPartFile
2018-05-02 16:03:31 +02:00
953691abb2
External mount does not get DELETE and UPDATE if readonly
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:18:56 +02:00
055a003661
Use an actual function of the storage to determine needsPartFile
...
We have a function for it so better to override that. Also because other
codes that might check this should get the right value.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:02:36 +02:00
f212c692ac
Merge pull request #9178 from nextcloud/feature/9142/directdownload
...
Add directdownload endpoint
2018-05-01 14:54:44 +02:00
dd1b0799a4
only allow a single concurrent dav write to a file
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-26 11:16:51 +02:00
38a90130ce
move log constants to ILogger
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
1c75ddac45
Improve the directContoller
...
* Tests
* No directdownload from storage yet (as it is not tested at all)
* No direct links for folders
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:38 +02:00
d5222d68f0
Add tests for DirectFile and DirectHome
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
392337fa13
Throttle requests to unknown tokens
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
b6c58e75b7
Add backgroundjob to cleanup expired direct links
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
042340ccf6
Check if a direct link is expired
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
6a385dd20b
Add directDownload support of storage
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
164d998856
No listing
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
b3e7865d9b
Dav endpoint returns proper data
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
5c6d3b4f41
Request a direct link
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
f984664bee
First step of DAV endpoint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
9ab5b6a4f1
Add DB mapping
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
b0c801c764
Add directdownload table
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 10:35:37 +02:00
dd34cb7540
Less deprecated calls to OCP\Util::writeLog
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-22 20:41:49 +02:00
bc3fde9f75
log more information about insufficient storage in dav plugin
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-17 15:29:37 +02:00
fed9140abd
Merge pull request #9148 from nextcloud/dav-read-exception
...
transform exception during file read to sabre exceptions
2018-04-11 16:03:12 +02:00
2626d11f78
Merge pull request #9097 from nextcloud/bugfix/7661/use_mb_substr
...
Use multibyte substring
2018-04-11 15:55:55 +02:00
e6a7ddc1c6
transform exception during file read to sabre exceptions
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-11 14:45:35 +02:00
0864d1c51d
Use multibyte substring
...
Fixes #7661
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 22:26:38 +02:00
373a1d5391
more consistent naming
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:15 +02:00
2ebf26e444
admin_audit and dav listen to announce and revoke signals
...
also place them in doc
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:38:43 +02:00
bd8352d4c4
Merge pull request #8996 from brandonkirsch/fix-onenote-dav
...
Fix webdav support for OneNote clients
2018-04-03 13:27:29 +02:00
e8b7e9e75d
Do not treat is-encrypted as customer property
...
fixes #8977
Else for all files in a folder we would launch off more queries.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-28 08:34:50 +02:00
c5005bbab5
Fix webdav support for OneNote clients
2018-03-26 15:32:12 -04:00
e6a2c13ac1
MethodNotAllowed is not a Fatal error
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 12:15:31 +02:00
c306bc29d1
Make displayname selectable
...
It is dav. so if it is not properly set we just return a 404 anyway.
2018-03-22 16:46:21 +01:00
208e38e84e
Merge pull request #8255 from nextcloud/bugfix/noid/group-display-name
...
Full implement group display names
2018-03-15 12:07:30 +01:00
ed5008597f
Merge pull request #8112 from nextcloud/fix-integer-overflow
...
Fix integer overflow in ChunkingPlugin
2018-03-09 10:27:17 +01:00
db9b2398dd
Fix group displaynames in activity
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-08 17:13:49 +01:00
f5ef9e02b2
emit pre-hooks earlier when not using part files
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-08 13:02:35 +01:00
fc4e0501f0
Fix integer overflow in ChunkingPlugin
...
Avoids errors when the size exceeds MAX_INT because of the cast to int. Better cast it to float to avoid this.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-06 18:47:26 +01:00
236086c457
Merge pull request #8335 from nextcloud/remove-unused-import
...
Remove unused import statements
2018-02-14 22:23:07 +01:00
d3d045dd5c
Remove unused import statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
e2974f1133
Simplify return statement
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:55:24 +01:00
e5c08621af
Merge pull request #8023 from nextcloud/webdavsearch_limit_order_fixing
...
Respect limit and order in webdav search
2018-02-08 09:11:39 +01:00
c1ff12e234
CacheJail should apply limit and offset after searching
...
Else the results might not be correct.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
6b5419ddf0
Adjust to updated searchdav library
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:41:15 +01:00
ec144281ef
Respect limit and order in webdav search
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-07 13:41:15 +01:00
9d6d23d1f7
keep previous exception when transforming to dav exception
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-02-07 13:34:30 +01:00
9896b15ec8
Only handle encrypted property on folders
...
Exposing the encrypted property is required for E2E. However, there is
no need to expose this on files as then it is server side encryption
(which the clients don't care about).
Better to not confuse the output.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-30 12:25:49 +01:00
eb51f06a3b
Use ::class statement instead of string
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
97c216ea06
Merge pull request #8071 from nextcloud/remove-silly-code
...
Cleanup unused code
2018-01-26 15:47:06 +01:00
c67736a542
Merge pull request #7707 from nextcloud/bugfix/noid/birthdaycalendar-different-uids
...
generate different UIDs for Birthday, Anniversary and Death event
2018-01-26 15:46:46 +01:00
c005fc6755
Cleanup unused code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:25:19 +01:00
c1e4f9f305
Use type casting instead of *val() method
...
It should be up to 6x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +01:00
c2b1bd92d6
Merge pull request #8063 from nextcloud/inline-value
...
Return value immediately instead of assigning to a one-time variable
2018-01-26 10:15:39 +01:00
ec1d94c629
Merge pull request #8052 from nextcloud/fix-array-methods
...
Fix array method usages with a proper call
2018-01-26 09:53:13 +01:00
0a56d2185e
Return value immediately instead of assigning to a one-time variable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +01:00
4dbee99b7b
Remove useless return statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:50:40 +01:00
7800a9bc24
Fix array method usages with a proper call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:20:10 +01:00
c7d9e5fd63
Merge pull request #7354 from nextcloud/refacor-update-page-print
...
Refactor method to check if update is needed
2018-01-22 22:50:05 +01:00
24c58d39f4
Merge pull request #7909 from nextcloud/fix-migration-type-hints
...
Fix the type hints of migrations and correctly inject the wrapped sch…
2018-01-17 13:47:58 +01:00
4a5282ba21
Fix the type hints of migrations and correctly inject the wrapped schema into migrations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 11:37:36 +01:00
8614eb91db
Fix avatarHome
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 15:37:47 +01:00
91d3677446
Make sure the arrays are arrays
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-12 14:08:00 +01:00
e5cc8ebe7a
Return proper principal on the uploads collection listing
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-10 08:35:20 +01:00
1b8fc260c6
generate different UIDs for Birthday, Anniversary and Death event
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-01-04 20:15:24 +01:00
876238ce8b
Merge pull request #7533 from nextcloud/oc-28545-handle-oc-total-length-in-new-chunking
...
[oc] Handle OC-Total-Length in new chunking
2018-01-03 16:18:24 +01:00
0b4d18673e
Do not log user errors as log level 4
...
* hides log entries for the case the parent folder does not exist
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-03 11:58:55 +01:00
0585b776fb
Do no run SyncJob in cron
...
Fixes #7184
The SyncJob can be very resource intensive. Since it requests all users
on the system to create the system addressbook. In order to do this it
creates a vcard for every user and updates the addressbook.
There is no need for this job since the proper signals are emitted and
handled in the carddav backend to update the addressbook live.
Worst comes to worst there is always the occ command to bring the
address book in sync again.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-02 10:00:01 +01:00
8c5d656f3b
Handle OC-Total-Length in new chunking
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-15 14:46:36 +01:00
1ceeab9229
Fix unit tests for CalendarManager
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-12 09:33:52 +01:00
d98dea1eb1
Merge pull request #6884 from nextcloud/feature/3003/opt_out_of_birthday_calendar
...
Opt out of birthday calendar
2017-12-12 08:29:26 +01:00
f6ef779f97
Make ContactsStore a public API
...
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2017-12-11 18:18:58 +01:00
ba3c608a00
Merge pull request #6590 from nextcloud/dav-create-activities-for-publishing
...
Create activities for (un)publishing calendar events
2017-12-11 17:13:11 +01:00
c76c7a96fc
Update wording
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-11 16:28:40 +01:00
4c32de22bb
Create activities for (un)publishing calendar events
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2017-12-11 16:28:40 +01:00
6802e2b59a
Principal search: Take sharing settings into account
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-12-11 16:04:55 +01:00
f543039858
exclude shared calendars from freeBusy
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-12-11 16:04:55 +01:00
787e3d51b4
Fix functions to search for principals in the backend.
...
Add a "searchPrincipals" function to the NC principal backend.
Fix the "findByUri" function to respect the prefixPath.
Signed-off-by: Christoph Seitz <christoph.seitz@posteo.de>
2017-12-11 16:04:55 +01:00
80b27fdb93
Merge pull request #7342 from nextcloud/fix_carddav_converter
...
CardDAV convertor check should not be to wide
2017-12-11 16:03:07 +01:00
5b20600da9
Merge pull request #7313 from nextcloud/ensure-that-x-oc-mtime-header-is-an-integer-with-chunked-uploads
...
Ensure that X-OC-MTime header is an integer with chunked uploads
2017-12-11 15:07:05 +01:00
40633c5e54
CardDAV convertor check should not be to wide
...
Case: email is set to null, but the avatar is set. In the old case the
email would set $emptyValue but $noImage would still be false. This we
would set the empty string as email.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-11 11:58:02 +01:00
de8fefeb18
Merge pull request #7395 from nextcloud/remove-unused
...
Remove unused variables
2017-12-06 13:09:01 +01:00
a73f86912f
Remove unused variables
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-05 09:58:15 +01:00
d2fe30d464
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-04 15:23:20 +01:00
c8a29ec942
A failed storage is a not available storage
...
We have to double check. Since getting the info of the root returns a
generic entry. But actually the stroage is not available. Else we get
very weird sync and web behavior.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-04 15:23:11 +01:00
f22e02cd79
Refactor method to check if update is needed
...
There was only one call, that actually needed the parameter to be set to true. So this change moved the print of the page to that location and replaces all other occurences with a direct call to the underlying OCP API.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-30 16:04:07 +01:00
2a7b1bae10
Reject X-OC-MTime header if given as a string with hexadecimal notation
...
In PHP 7.X hexadecimal notation support was removed from "is_numeric",
so "sanitizeMtime" directly rejected those values; in PHP 5.X, on the
other hand, "sanitizeMtime" returned 0 when a string with hexadecimal
notation was given (as it was the behaviour of "intval"). To provide a
consistent behaviour between PHP versions, and given that it does not
make much sense to send X-OC-MTime in hexadecimal notation, now
X-OC-MTime is always rejected if given as a string with hexadecimal
notation.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-28 01:08:52 +01:00
ffe034abb0
Don't use runInSeparateProcess
...
Directly calling "header" in the PHPUnit process causes the "Cannot
modify header information - headers already sent by" error to be thrown.
Instead of running the test in a separate process, which is slower, this
commit wraps the call to "header" in a method that can be mocked in the
tests.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 20:39:45 +01:00
2af3d8a9b2
Make possible to provide a specific HTTP request object to File
...
This will be used in a following commit to test how the X-OC-MTime
header is handled.
This commit is based on the "make File::put() more testable" commit
(included in 018d45cad97e0) from ownCloud by Artur Neumann.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 20:39:41 +01:00
01e346b2ae
Ensure that X-OC-MTime header is an integer also with chunked uploads
...
This commit extends the changes introduced in pull request #3793 also to
chunked uploads.
The "sanitizeMTime" method name is the same used in the equivalent pull
request to this one from ownCloud (28066).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-27 20:37:51 +01:00
3f7267e0e9
Merge pull request #6901 from nextcloud/bugfix/4014/catch_parsing_error
...
catch errors when parsing calendar data for calendar query requests
2017-11-27 17:50:37 +01:00
573551253e
Merge pull request #7308 from nextcloud/do-not-log-InvalidSyncToken
...
Log InvalidSyncToken on DAV in debug level
2017-11-27 17:27:41 +01:00
ea117bac31
catch errors when parsing calendar data for calendar query requests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-27 17:14:18 +01:00
88905c6293
Log InvalidSyncToken on DAV in debug level
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 16:37:11 +01:00
26a5fff423
Log NotImplementedException on DAV in debug level
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 16:17:01 +01:00
f347e2e4a6
Merge pull request #7047 from nextcloud/add-support-for-files-with-no-permissions
...
Add support for files with no permissions
2017-11-20 16:15:52 +01:00
eeb0cfdaf5
Merge pull request #7152 from nextcloud/bugfix/noid/adjust_calendarobject_size_after_applying_class
...
remove cached size from shared calendar objects
2017-11-17 08:28:34 +01:00
20868e17e8
Merge pull request #7193 from nextcloud/bugfix/noid/invitation-email-refinements
...
refine invitation email
2017-11-16 21:11:44 +01:00
f32fbbca2e
Merge pull request #6840 from nextcloud/feature/5282/calendar_api
...
Calendar API for apps
2017-11-16 21:10:35 +01:00
b073b13d9f
refine invitation email
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-16 13:54:19 +01:00
072652b2af
show name of organizer in from name of invitation email
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-14 21:23:27 +01:00
19b77039d7
remove cached size from shared calendar objects
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-12 17:30:22 +01:00
2b51d84b98
generate birthday calendars in a background job after admin enabled them
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-11 16:17:18 +01:00
a87d986041
create a user's birthday calendar right after they requested it
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-11 11:28:34 +01:00
ef6f41a16c
respect admin / user choice about birthday calendars in corresponding hooks
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-11 02:15:57 +01:00
d59b3392ab
disallow users to create calendars with reserved names
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-11 02:15:56 +01:00
1c106a66b1
adapt occ 'dav:sync-birthday-calendar command
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-11 02:15:56 +01:00
5068d56fb0
add CalDAV interface that allows users to re-enable their birthday calendar
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-11 02:15:50 +01:00
dc34622008
remember when a user deleted their contact birthdays calendar
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-10 23:05:04 +01:00
8b22bfea4f
Add admin checkbox to disable birthday calendars
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-09 17:12:06 +01:00
7784672cc0
add option to filter CalendarAPI by componenttype
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-09 15:14:58 +01:00
fa416e031b
integrate Dav app with Calendar API
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-09 15:14:58 +01:00
b754a2e385
Merge pull request #7042 from nextcloud/bugfix/noid/ensure_unique_uid_for_calendar_objects
...
ensure uid for calendar objects is unique
2017-11-07 21:55:09 +01:00
f55732a18f
Merge pull request #7075 from nextcloud/remove-unused-variables
...
Remove unused variables
2017-11-07 16:18:40 +01:00
31c5c2a592
Change @georgehrke's email
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 20:38:59 +01:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 16:56:19 +01:00
4df08f296b
ensure uid for calendar objects is unique
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-06 14:25:08 +01:00
5445b1ff17
Remove unused variables
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 09:43:45 +01:00
43147aeada
fancify invitation emails
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-03 11:20:03 +01:00
1bb048d11f
Correctly use the email templating
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-11-03 11:20:03 +01:00
b14b933062
Language depending dates
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-11-03 11:20:03 +01:00
cf04093fa6
Fix phpStorm complaints
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-11-03 11:20:03 +01:00
c899f35261
DAV: Initial email customization support
...
Signed-Off-By: Leon Klingele <leon@struktur.de>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-11-03 11:19:39 +01:00
555d582f35
Return whether the file is readable or not in the DAV permissions
...
Until now it was safe to assume that every file was readable by its
owner, so there was no need to return whether the file was readable or
not. However, with the introduction of end to end encryption that is no
longer the case, and it is now necessary to explicitly provide that
information.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-02 19:37:00 +01:00
b3ff9a2248
Merge pull request #6849 from nextcloud/fix-missing-translation-of-personal-calendar-in-activity
...
Fix missing translation of "Personal" calendar in activities
2017-10-31 15:05:26 +01:00
143ff6a622
Add a doc why this should not be removed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-23 12:35:55 +02:00
1855204ad9
remove reminders from read-only shared calendars
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-10-22 14:19:29 +02:00
bb1af9b284
Merge pull request #6811 from nextcloud/feature/noid/disable_caldav_invitations
...
Opt out of IMip CalDAV Plugin
2017-10-19 11:57:52 +02:00
bdb0265644
Fix missing translation of "Personal" calendar in activities
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-16 18:41:33 +02:00
b958725f78
Make it possible to opt out of IMip Plugin for CalDAV
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-10-16 13:49:46 +02:00
7828cf454e
add admin settings panel for dav app
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-10-16 13:49:08 +02:00
79c4538511
Dav: codestyle fixes in PluginManager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-10-14 20:51:59 +02:00
a829ac787a
Let apps register Sabre plugins or collections
...
upstream #26761
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-10-14 20:50:53 +02:00
7c53f921a9
Use ::class to avoid errors
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-13 12:36:20 +02:00
fd5465d509
Fix class name, regression from 44cf67accd
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-13 12:35:52 +02:00
3b4ab6560b
Check if the user/group exists for dav shares
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-10-05 12:48:10 +02:00
155d451cf8
Fix copy paste errors
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-29 11:10:57 +02:00
c65e591e88
Restore the sequencial order
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-29 11:10:57 +02:00
740d820194
Migrate ids to bigint in the dav app
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-29 11:10:57 +02:00
e0a4c61350
Merge pull request #6633 from nextcloud/dav-remove-like-when-not-needed
...
Don't add a LIKE condition when it's not needed
2017-09-25 12:12:50 +02:00
4ac32223da
Add indexes to cards and cards_properties tables
...
Fixes #6170
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-09-25 10:27:46 +02:00
f1bfd4433e
Don't add a LIKE condition when it's not needed
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2017-09-25 09:10:44 +02:00
d5b5fc7fca
Fix unsigned state
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-19 12:49:42 +02:00
8768faacaa
Fix migration naming
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-09-19 12:44:46 +02:00
32234a23da
Move DAV app to migrations
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-09-18 14:35:27 +02:00
ab63c89ab3
Fix quota calculation on new dav upload endpoint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-09-13 19:28:38 +02:00
8e6d86a862
Merge pull request #5304 from nextcloud/bugfix/2855/dont_send_invitations_for_past_events
...
don't send invitation emails for past events
2017-09-06 22:48:46 +02:00
1724fed8c5
Merge pull request #5415 from nextcloud/search-cache-node
...
cache nodes from search results
2017-09-06 10:16:01 +02:00
a1df91da9d
Sabre/VObject returns DateTimeImmutable, not a simple DateTime
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-09-05 13:13:37 +02:00
86f28669fc
don't send invitation emails for past events
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-09-05 13:13:37 +02:00
f0158e42e9
Merge pull request #6309 from nextcloud/new-dav-event
...
add a new dav event to allow apps to register their own sabredav plugins
2017-09-04 12:12:46 +02:00
baba99a7e6
not to backquote LIMIT on CalDavBackend.php
2017-09-03 23:51:49 +09:00
f8cc8e1c9e
add a new dav event to allow apps to register their own sabredav plugins
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-08-30 14:05:18 +02:00
e83e1c7c23
add propfind to detect encryption status
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2017-08-28 14:02:25 +02:00
37e8b698f7
cache nodes from search results
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-08-26 10:18:19 +02:00
fc12bd0be6
Do not log WebDAV maintenance mode exception
...
Log the maintenance mode exception only in debug level. Fixes #6124
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-08-15 15:03:39 +02:00
231bb47ae6
Fix file size comparison
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-08-01 13:56:12 +02:00
89238164e1
Fix comparisons in the dav app
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-08-01 13:55:07 +02:00
61a6adff14
Fix sabre test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-08-01 08:20:17 +02:00
fc369dd86e
[DAV] Fix URLUtil::splitPath usage
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-08-01 08:20:17 +02:00
f57a3aa81b
[DAV][CalDAV] Fixes
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-08-01 08:20:16 +02:00
e1f52fc901
Stricter phan config fixes
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-08-01 08:20:13 +02:00
89b747d066
refactor chunked assembly stream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-07-21 12:49:39 +02:00
3d2600b039
Add Phan plugin to check for SQL injections
...
This adds a phan plugin which checks for SQL injections on code using our QueryBuilder, while it isn't perfect it should already catch most potential issues.
As always, static analysis will sometimes have false positives and this is also here the case. So in some cases the analyzer just doesn't know if something is potential user input or not, thus I had to add some `@suppress SqlInjectionChecker` in front of those potential injections.
The Phan plugin hasn't the most awesome code but it works and I also added a file with test cases.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-07-20 22:48:13 +02:00
984933e586
Only use readable chars in Share Tokens
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-07-18 15:44:34 +02:00
b4deba2078
Merge pull request #5483 from nextcloud/issue-5075-png-files-for-activity-emails
...
Use PNGs for icons in activity emails
2017-07-07 11:05:00 +02:00
b27819785e
Don't log passwords on dav exceptions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-29 17:20:10 +02:00
eb9aedf44b
Enhance the logging if the part file can not be renamed
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-06-22 17:50:14 -05:00
90fa27694a
Use PNG version of the icons for shipped activities
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-06-20 13:48:51 +02:00
698a7cb7f0
Merge pull request #5124 from nextcloud/allow-dirlisting-with-unreadable-items
...
Allow dir-listing also when one child is blocked by access control
2017-06-16 10:47:08 +02:00
ca3c69c8ae
Merge pull request #5298 from nextcloud/bugfix/4885/calendar_shares_url_special_char_issue
...
urldecode group principals in Cal- and CardDAV backend
2017-06-14 23:10:40 -05:00
ac565cecad
Merge pull request #5300 from nextcloud/bugfix/noid/fix_proppatch_requests_to_groupshares
...
allow users to send PropPatch request when calendar is group-shared with them
2017-06-14 23:00:39 -05:00
John Molakvoæ (skjnldsv)
Robin Appelman
Bjoern Schiessle
blizzz
Julius Härtl
Roeland Jago Douma
Georg Ehrke
Roeland Jago Douma
Morris Jobke
Joas Schilling
Christian
Daniel Calviño Sánchez
Thomas Müller
Thomas Citharel
rakekniven
Brandon Kirsch
Tobia De Koninck
Christoph Seitz
Lukas Reschke
Leon Klingele
Vincent Petry
nhirokinet