ea10a1292a
Use "?" instead of user ID as seed for the image placeholder
...
The seed of the image placeholder is needed to generate the background
color of the image, but as the background color is later overriden any
seed could be used. When no text is explicitly given the seed is used as
text too, so there is no need to pass the user ID and simply using "?"
as seed is enough.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-09-20 18:20:58 +02:00
ff71dd07a6
Unify appearance of avatars for undefined and unknown users
...
When calling the jQuery avatar plugin with a user that did not exist
(that is, users for which "/avatar/{user}/{size}" return a JSON response
with an empty "displayname" value) "?" on a grey background was shown.
However, if the jQuery avatar plugin was called with an undefined
JavaScript value then "?" was shown on a bluish background. This commit
unifies both cases to use the grey background.
The unit tests were also modified to ensure that the grey background is
used in both cases.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-09-20 17:19:35 +02:00
582fb5d129
Update the URLs in tests to use example.org
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-08-01 11:16:04 +02:00
f2d999aa70
Update setupchecks.js
...
Fixed typo and removed doclink symbol.
Reported at transifex
Update util.php
Another l10n improvement from transifex.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-31 13:41:45 +02:00
1fedf450ac
Update Opcache recommendation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-21 18:21:28 -05:00
646db7f88d
Merge pull request #4518 from nextcloud/downstream-25838
...
Fix share indicator handling
2017-04-26 19:23:27 +02:00
17a31a51c6
Fix share indicator handling
...
Properly update the fileInfoModel with the updated share types, which
also updates the file list row indicator properly
2017-04-26 13:38:12 +02:00
6bbc682c4b
handle 404 separately
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-04-26 09:30:21 +02:00
99b201a188
unit test jquery.contactsmenu
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2017-04-26 09:28:15 +02:00
0f0b04b7d9
Fix test
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2017-04-26 00:06:56 +02:00
5c61852c25
Fix failing contacts menu js test data
...
When we test wheter action menus in the contacts menu close
when clicking other ones, we have to provide test data
that actually causes the view to render the menu.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-04-25 20:47:18 +02:00
d091793ceb
Contacts menu
...
* load list of contacts from the server
* show last message of each contact
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-04-25 20:47:17 +02:00
82c9eb1c56
Merge pull request #4462 from danxuliu/fix-sharing-password-protected-link
...
Fix sharing a password protected link
2017-04-25 14:12:44 +02:00
58cc1251be
Use "complete" callback in onPasswordEntered
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-04-24 22:18:52 +02:00
6e9f49f397
Add "complete" callback support for addShare
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-04-24 21:31:53 +02:00
488020cf2e
Add "complete" callback support for updateShare
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-04-24 21:24:30 +02:00
726c6c73f4
Add missing unit test cases and conditions
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-04-24 21:24:05 +02:00
153d053ee7
Fix working icon not hidden when successfully setting a password
...
When a request to set the password of a shared link is sent a working
icon is shown. However, as there was no "success" callback, the icon was
never hidden again after successfully setting the password (it worked
fine if there was an error, though).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-04-24 11:33:07 +02:00
2317d7bb49
Fix sinon.stub deprecation warnings
...
Calls to `sinon.stub(obj, 'meth', fn)` are deprecated and therefore
replaced by `sinon.stub(obj, 'meth).callsFake(fn)` as instructed by
the deprecation warning.
This makes the js unit testing output readable again.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-04-24 10:39:37 +02:00
1c0bffe87f
Fix translations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-18 16:40:53 -05:00
46a32045d7
Update karma, use sinon from npm
...
Update karma library and use sinon JS library provided by
karma-jasmine-sinon instead of local file.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-23 23:35:41 -06:00
ac1aff7d92
Merge pull request #3950 from nextcloud/downstream-27149
...
Forbid to upload part files via web UI
2017-03-20 11:44:57 +01:00
11f838f9e4
Add ignore_files to config,
...
test files against ignore_files list on upload
fix typo and indentation
Move blacklist declaration to lib/public/Files/FileInfo.php,
Rename *ignored to *blacklisted
Mocked blacklist_files for testing
Mocked blacklist_files for testing
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-20 01:17:12 -06:00
703f2e6a61
Clear onpopstate handlers after unit tests
...
Fixes issue when running Karma tests in Firefox.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-19 23:15:21 -06:00
6c8d48b0f6
Harden t() with DOMPurify
...
This mitigates issues where developers pass untrusted user-input through t() which may lead to XSS issues.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-03-16 14:17:42 +01:00
bb2ec51bbb
Fix unit tests of master
...
Follow up to #3802
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-03-16 12:46:02 +01:00
b5a6f03362
Merge pull request #3643 from nextcloud/replace-deprecated-tipsy
...
Replace deprecated $.tipsy(...) by $.tooltip(...)
2017-02-28 10:49:14 +01:00
413d671d9e
Merge pull request #3635 from individual-it/fix_quota_validation
...
better quota validation
2017-02-28 00:27:51 -06:00
9790fe7f5d
make values with white spaces possible
...
a user might enter values with white spaces, and that should be possible
and valid
Signed-off-by: Artur Neumann <info@individual-it.net>
2017-02-28 08:25:34 +05:45
f1fccaca06
better quota validation
...
this fixes #3634
1. fixed computerFileSize to be more picky about incorrect values
2. more tests for computerFileSize
3. use computerFileSize to validate user quota
Signed-off-by: Artur Neumann <info@individual-it.net>
2017-02-28 07:38:11 +05:45
3e7e49884e
Replace deprecated $.tipsy(...) by $.tooltip(...)
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-02-27 22:25:05 +01:00
cee8853658
Show info in admin settings about PHP opcache if disabled
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-02-22 23:45:48 -06:00
200a28255e
Always enable avatars
...
* we introduced this setting in the begining because our
avatar support caused some performance issues, but we
fixed them and should only provide one way how Nextcloud
looks
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-02-13 17:53:33 -06:00
dd9ee2db6f
fix tests, longer wait time, update notification stub
...
Signed-off-by: m3ntalsp00n <m3ntalsp00n@gmail.com>
2017-02-04 18:51:52 +10:00
da28a1612e
expect warning to be shown
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-01-13 11:33:12 +01:00
9d56d5e94d
add spies for l10n warnings
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-01-13 11:20:19 +01:00
6347d97c7f
Merge pull request #2512 from nextcloud/cleanup-system-tag-usage
...
Only allow admins to delete tags
2017-01-06 16:17:09 +01:00
14256d631c
Use group display name in sharing API + UI
2016-12-22 18:35:32 +01:00
d4c088cb79
Verify input, add more unit tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-19 17:29:20 +01:00
ec4bca619d
Add test for unparseable string
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-19 17:29:13 +01:00
ff018d48cf
Implements all comments from @PVince81
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-19 17:29:05 +01:00
6217393d6a
Adding computerFileSize in OC.Util
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-12-19 17:28:58 +01:00
9ea432f88c
Adjust the JS unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-12-06 17:50:57 +01:00
a2867c0664
Properly check the data dir
...
* fixes #1364
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-12-05 23:35:35 +01:00
e055fbd4da
adjust js tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-12-02 13:40:23 +01:00
e7a146bd62
fix tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-11-29 13:40:41 +01:00
34849f7bd3
fix unit tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-11-23 18:02:23 +01:00
d001dbd259
Adjust unit tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-11-21 11:30:03 +01:00
0f06034239
Replace more vendor naming
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-11-11 08:54:21 +01:00
d235c4833f
remove the 'shareapi_allow_mail_notification' setting
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-02 21:17:05 +01:00
f556c58c22
remove 'send mail notification' option from sharing, replaced by send-by-mail feature
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2016-11-02 18:30:38 +01:00
57e61250ac
Remove notify recipient option
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-26 20:52:36 +02:00
25d9dce067
JS utility function to compare paths
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-24 21:45:00 +02:00
361f008c70
Make it possible to filter by tags with REPORT method
...
Enhanced the REPORT method on the Webdav endpoint and added a
"oc:favorite" filter rule. When set, it will return a flat list of
results filtered with only favorite files.
The web UI was also adjusted to use this REPORT method instead of the
private API endpoint.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-19 11:06:29 +02:00
6d688e89c1
Merge pull request #1453 from nextcloud/do-not-reload-if-connection-lost
...
do not reload the page if the server is (temporarily) unreachable
2016-10-06 14:58:02 +02:00
5ae6d62811
do not reload the page if the server is (temporarily) unreachable
2016-10-03 10:24:47 +02:00
5cda383460
Make can edit checkbox work for file shares
2016-10-03 09:06:51 +02:00
9b01574465
adjust js tests
2016-08-25 13:47:14 +02:00
0f3674a446
Group incoming shares for resharing in JS
2016-08-03 10:16:28 +02:00
217b52085d
Fix javascript tests for sidebar animation
2016-07-30 16:30:05 +02:00
6da54a6987
Merge pull request #374 from lpszBuffer/master
...
Alters 'No Internet Connection' error message. #181
2016-07-21 18:55:58 +01:00
b236100619
Alters 'No Internet Connection' error message. #181
2016-07-20 19:12:10 -05:00
4d67429cf0
Use an icon to set the email instead of a button with string
2016-07-20 15:07:46 +02:00
61e604c2d9
adjusts tests to removal of svg fallback
2016-07-01 16:36:37 +02:00
fb087a0261
Use temporary htaccesstest.txt for data dir security check
2016-06-07 18:36:13 +02:00
66e93561da
Rename "not-assignble" to "restricted"
2016-05-20 17:56:02 +02:00
88740f035d
Act on effective system tag canAssign permission
...
Whenever the server returns true for the can-assign Webdav property of
a system tag, it means the current user is allowed to assign,
regardless of the value of user-assignable.
This commit brings the proper logic to the web UI to make it possible
for users to assign when they have the permission.
2016-05-20 17:56:02 +02:00
2c4ef37025
Merge pull request #24126 from owncloud/err-reload-delay
...
Delay reloading the page if an ajax error occurs, show notification
2016-04-22 11:23:39 +02:00
62024d74d4
Add test for reload delay
2016-04-20 22:09:59 +01:00
6b66f2dfb4
Merge pull request #23990 from owncloud/heartbeat-debounce
...
Debounce heartbeat ajax calls to lower the number of requests
2016-04-20 21:23:10 +02:00
2d772eaaa8
Debounce heartbeat ajax calls to lower the number of requests
...
fixes #22397
2016-04-18 14:19:26 +02:00
5900e46f01
Turn off jQuery animations when testing
2016-04-18 10:41:02 +02:00
3e1f1ccc76
downgrade jquery, update jquery-migrate
2016-04-15 13:55:23 +02:00
e03d289b70
Use 6 months as SSL STS header threshold
...
* this uses 6 months (6 * 30 * 24 * 60 * 60 = 15552000)
* old value was half a year (365 / 2 * 24 * 60 * 60 = 15768000)
* fixes #23957
2016-04-13 08:47:34 +02:00
8d11c3b87b
Merge pull request #23487 from owncloud/core-globalajaxerrorwhengoingaway
...
Detect user navigating away, don't interpret as ajax error
2016-04-01 17:03:55 +02:00
06e7856400
Adjust core unit tests for unload/reload cases
2016-03-23 10:53:40 +01:00
61c5717281
Merge pull request #23463 from owncloud/lets-consistently-use-no-referer
...
Consistently use rel=noreferrer
2016-03-23 09:14:54 +01:00
86581f6626
Merge pull request #22065 from owncloud/systemtags-create-same-prefix
...
Allow creating tags where another one with same prefix exists
2016-03-21 11:15:49 +01:00
6ad957906e
Consistently use rel=noreferrer
...
When linking to external entities we should consistently use rel=noreferrer
2016-03-20 15:27:20 +01:00
2ca3c0d461
Adjust wording a bit
...
**Before:**
> Your PHP version (5.4.16) is no longer supported by PHP. We encourage you to upgrade your PHP version to take advantage of performance and security updates provided by PHP.
**After:**
> You are currently running PHP 5.4.0. We encourage you to upgrade your PHP version to take advantage of performance and security updates provided by the PHP Group as soon as your distribution supports it.
Fixes https://github.com/owncloud/enterprise/issues/1170
2016-03-11 17:39:35 +01:00
0091df2bc8
Improved JS L10N bundle merging + tests
2016-02-29 17:39:21 +01:00
27544144ce
Fix unit tests affected by side effects
...
The notification tests were not restoring the clock properly, but
indirectly helped other tests pass.
Since now we're restoring the clock properly, the other tests were fixed
to still work.
2016-02-22 17:25:32 +01:00
8ea80e114a
Accumulate notifications instead of blinking
...
This makes it possible to display multiple notifications.
If the options.type is set to "error", it will also add a close button.
2016-02-22 17:25:32 +01:00
8abdcb8085
Fix error ins source language strings
...
https://www.transifex.com/owncloud-org/owncloud/translate/#en_GB/core/50786279
https://www.transifex.com/owncloud-org/owncloud/translate/#en_GB/settings-1/50555028
2016-02-19 15:04:16 +01:00
7af7d18cfa
Merge pull request #16783 from owncloud/handle-redirects-global
...
Adding global error handler for ajax calls which run into redirection…
2016-02-17 14:49:04 +01:00
e1fd86ccb6
Unlock sharee input field when sharing fails
...
Fixes #22441
When addShares fails (for whatever reason) we should unlock the sharee
input field so the user does not have to reload the page.
2016-02-17 09:21:12 +01:00
b8b77709c0
Add handler for global ajax errors
2016-02-15 12:48:47 +01:00
2054dbd4c8
Merge pull request #22350 from owncloud/fix_22304
...
WebUI feedback when sharing
2016-02-15 10:45:42 +01:00
33ef240b39
Search tags case insensitive
...
fixes : #22352
* Added unit tests
2016-02-14 20:41:39 +01:00
92c131b481
Updated unit tests
2016-02-12 14:31:00 +01:00
1301ec9351
Only show link shares for the current user
...
Currently we have no way to display multiple links in the UI.
So just display the link share for the current user.
Fixes #22275
2016-02-10 16:00:55 +01:00
e378a757ff
Add system tags filter section for files app
2016-02-09 10:59:29 +01:00
23f0515771
Fix JS DAV files client unit tests
...
Instead of trying to mock the promise, just stub davclient.js' request
object.
2016-02-04 15:39:18 +01:00
22be3867f1
Allow creating tags where another one with same prefix exists
...
When creating a new entry, compare the full tag name and not only the
prefix.
2016-02-02 10:42:35 +01:00
faf48e42b7
Move data protection check to javascript
...
fixes #20199
2016-02-01 18:57:58 +01:00
df3f6fee10
Properly forward error messages in share dialog
2016-01-28 17:18:33 +01:00
7e1de0e3c2
Fix share default expiration date calculation
...
Now using UTC dates with moment js to accurately add the number of days
2016-01-28 15:25:34 +01:00
b063ddb05b
Share dialog use OCS API
2016-01-28 15:25:34 +01:00
de8852a760
Merge pull request #21958 from owncloud/systemtags-style
...
Use boxes for system tags, shorten permission text
2016-01-28 12:54:52 +01:00
1473e156f4
Use boxes for system tags, shorten permission text
...
Permission text now doesn't appear when all permissions are there, or
shows as "invisible" or "not assignable", which should better cover all
use cases.
Changed select2 style to use boxes in the input field.
2016-01-28 11:24:13 +01:00
Daniel Calviño Sánchez
Morris Jobke
rakekniven
Roeland Jago Douma
Vincent Petry
Georg Ehrke
Jan-Christoph Borchardt
Christoph Wurst
Joas Schilling
Lukas Reschke
Felix Heidecke
Roeland Jago Douma
Artur Neumann
m3ntalsp00n
Patrick Paysant
Robin Appelman
Bjoern Schiessle
Arthur Schiwon
Julius Haertl
William Bargent
Derek
Thomas Müller
Hendrik Leppelsack
Lukas Reschke
Robin McCorkell
Christoph Wurst
Roeland Jago Douma
Vincent Chan