Commit Graph

5165 Commits

Author SHA1 Message Date
Vincent Petry 6997344931
Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 12:00:41 +01:00
Nextcloud bot f82edda9c1
[tx-robot] updated from transifex 2021-03-15 02:23:58 +00:00
John Molakvoæ (skjnldsv) 31ddfb0294
Fix SharingInput Multiselect
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:30:15 +01:00
John Molakvoæ (skjnldsv) 7f06a0cf8e
Compile js
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:14:48 +01:00
Vincent Petry 3462444def
Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 09:07:30 +01:00
dependabot-preview[bot] 613a5760f1 Bump css-loader from 5.0.1 to 5.1.1
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 5.0.1 to 5.1.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v5.0.1...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 16:47:32 +01:00
Christoph Wurst 7f3051e5bf Drop \OCP\Util::isIe
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-09 20:29:42 +01:00
Vincent Petry 77401e8c1c
Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-09 10:40:14 +01:00
Roeland Jago Douma 988b9f49c5 Fix invalid check after constructing DateTime
We construct an object. Either that works on not.But the result can't be
false.

Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:32:34 +01:00
Nextcloud bot e8f087d7d1
[tx-robot] updated from transifex 2021-03-08 02:23:08 +00:00
dependabot-preview[bot] 6c8650d414 Bump core-js from 3.8.3 to 3.9.1
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.8.3 to 3.9.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.9.1/packages/core-js)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 11:34:26 +01:00
Robin Appelman b844293536 catch notfound and forbidden exception in smb::getmetadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-04 21:34:54 +01:00
Christoph Wurst cdc9a1efd9
Merge pull request #25912 from nextcloud/techdept/psalm/sharedstorage_some_types
Add some typing to SharedStorage
2021-03-04 12:31:17 +01:00
Roeland Jago Douma 7b9ca4f7c2 Add some typing to SharedStorage
Makes psalm a bit more happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 10:49:42 +01:00
Julius Härtl 69c2864aca
Add appconfig to always show the unique label of a sharee
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-04 09:25:45 +01:00
Nextcloud bot 365d31743f
[tx-robot] updated from transifex 2021-03-04 02:22:10 +00:00
Vincent Petry c541094be0 Clear multiselect after selection in share panel
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-03 11:38:00 +01:00
Roeland Jago Douma ce430c3613
Merge pull request #25892 from nextcloud/techdept/initialstate/part1
Move some settings over to the IInitialState
2021-03-03 11:08:42 +01:00
Roeland Jago Douma bc961baa40 Move some settings over to the IInitialState
The old one has been deprecated. Part one of many.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +01:00
Roeland Jago Douma 5c952e83fc Pimp sharingcheckmiddleware
Reported by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 20:36:04 +01:00
Roeland Jago Douma 19e2136963 Update autoloader files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:36:21 +01:00
dependabot-preview[bot] b486e26b81 Bump @babel/core from 7.12.16 to 7.13.8
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.16 to 7.13.8.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.8/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 21:30:34 +00:00
Nextcloud bot 9a90bfba32
[tx-robot] updated from transifex 2021-03-01 02:20:19 +00:00
Nextcloud bot c8f7a808fd
[tx-robot] updated from transifex 2021-02-25 02:21:21 +00:00
Nextcloud bot b89fbaf52d
[tx-robot] updated from transifex 2021-02-24 02:22:06 +00:00
Nextcloud bot ff54a0481b
[tx-robot] updated from transifex 2021-02-23 02:39:25 +00:00
John Molakvoæ 1eca8d21ee
Merge pull request #25602 from nextcloud/bugfix/noid/only-create-share-once
Avoid creating two share links when password is enforced
2021-02-22 12:08:49 +01:00
Nextcloud bot ac2577a594
[tx-robot] updated from transifex 2021-02-20 02:37:22 +00:00
Julius Härtl 9073c09c62 Avoid creating two share links when password is enforced
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-19 11:16:38 +00:00
dependabot-preview[bot] eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
Nextcloud bot 5f194dad24
[tx-robot] updated from transifex 2021-02-18 02:21:54 +00:00
Nextcloud bot 57212a99f9
[tx-robot] updated from transifex 2021-02-17 02:21:05 +00:00
Roeland Jago Douma 2ea3cb7c93 Drop redundant indes
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +01:00
Roeland Jago Douma 9929adde08
Merge pull request #25594 from wankdanker/files_sharing_owner_display_name
Use ownerDisplayName for SharingEntry Tooltip
2021-02-15 13:17:25 +01:00
Nextcloud bot 69f0d7d5d4
[tx-robot] updated from transifex 2021-02-13 02:20:27 +00:00
Dan VerWeire 1f47ae7c1b Use ownerDisplayName for SharingEntry Tooltip
Some NC installations may use a LDAP UUID for the username. If that
is the case, then the tooltip for who a file/folder was shared by may say something
like `Shared with Steve McQueen (smqueen@yada.com) by FKDJ39-38D794JG-4398GJODF9H3G-4534`.

This commit changes the value showed for the owner to the full display name.

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-12 07:32:26 +00:00
Roeland Jago Douma 983f7f3e49
Merge pull request #25493 from Worteks/fix-filessharing-debug
fix(log): remove debug log in _formatRemoteShare, suggested by @maxbes
2021-02-08 21:40:05 +01:00
Nextcloud bot 26a20ed13f
[tx-robot] updated from transifex 2021-02-08 02:20:05 +00:00
dependabot-preview[bot] a21a8adb2b Bump @babel/preset-env from 7.12.11 to 7.12.13
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.11 to 7.12.13.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.13/packages/babel-preset-env)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-07 11:36:26 +00:00
Samuel 69df6c41de fix(ci): build additionalScripts
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-07 11:06:11 +01:00
Nextcloud bot f19287ae57
[tx-robot] updated from transifex 2021-02-07 02:20:51 +00:00
Vincent Petry 50004bc4a5
Sharing dropdown now opens below
Fixes an issue where the dropdown list was not visible on small screens
as it would appear above the field and be hidden behind the container
border.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-05 14:47:01 +01:00
Samuel 73338a061b fix(debug): remove debug log in _formatRemoteShare, suggested by @maxbes
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 10:45:44 +01:00
Joas Schilling 9de00f3d24
This is 22
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-03 08:38:41 +01:00
Nextcloud bot 8c41589b30
[tx-robot] updated from transifex 2021-02-03 02:19:44 +00:00
Nextcloud bot e18c608cb4
[tx-robot] updated from transifex 2021-02-02 02:19:50 +00:00
Nextcloud bot 86678ba5df
[tx-robot] updated from transifex 2021-02-01 02:19:36 +00:00
Nextcloud bot fcbe4c5be5
[tx-robot] updated from transifex 2021-01-30 02:20:34 +00:00
Nextcloud bot d31013f1b8
[tx-robot] updated from transifex 2021-01-29 02:21:15 +00:00
Daniel Calviño Sánchez 9ccabff6ba Fix valid storages removed when cleaning remote storages
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-28 21:42:31 +01:00
Christoph Wurst 299f37c5d9
Update all composer autoloader files
The format changed between 2.0.8 and 2.0.9.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-28 14:24:34 +01:00
dependabot-preview[bot] 10ac729118
Bump core-js from 3.8.2 to 3.8.3
Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.2 to 3.8.3.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.8.2...v3.8.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-27 19:19:00 +01:00
Nextcloud bot baba83e185
[tx-robot] updated from transifex 2021-01-27 02:20:46 +00:00
Robin Appelman 5ae0be08b4
fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:54 +01:00
Nextcloud bot b2f183a26c
[tx-robot] updated from transifex 2021-01-26 02:21:31 +00:00
Nextcloud bot b98860eeb3
[tx-robot] updated from transifex 2021-01-25 02:20:31 +00:00
Nextcloud bot 7668c86116
[tx-robot] updated from transifex 2021-01-23 02:20:02 +00:00
Nextcloud bot 7989247574
[tx-robot] updated from transifex 2021-01-22 02:19:54 +00:00
Roeland Jago Douma 15b0e4d922
Merge pull request #25240 from nextcloud/enh/noid/re-use-fetched-dependencies
Re-use fetched dependencies in lib/base.php
2021-01-21 08:54:05 +01:00
Nextcloud bot 054783e385
[tx-robot] updated from transifex 2021-01-21 02:20:36 +00:00
Morris Jobke d84e1f1951
Re-use fetched dependencies in lib/base.php
Reduces calls to DI container by reusing already fetched dependencies.

For status.php it went from 355 to 344.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:55:16 +01:00
Nextcloud bot e22ce09644
[tx-robot] updated from transifex 2021-01-20 02:20:52 +00:00
Julius Härtl f69a6c675c
Show the actual error on share requests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-18 15:37:02 +01:00
Nextcloud bot 1907cc197d
[tx-robot] updated from transifex 2021-01-17 02:19:53 +00:00
Nextcloud bot 795881739e
[tx-robot] updated from transifex 2021-01-15 02:20:25 +00:00
Christoph Wurst c1d4f8161b
Migrate internal classes to the OCP db col types
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
Morris Jobke 24d436cb60
Remove unneeded casts that were found by Psalm
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +01:00
Nextcloud bot 97743df3fc
[tx-robot] updated from transifex 2021-01-10 02:22:39 +00:00
Nextcloud bot b137ac468f
[tx-robot] updated from transifex 2021-01-09 02:21:37 +00:00
Christoph Wurst 81302f78e5
Merge pull request #24948 from nextcloud/dependabot/composer/doctrine/dbal-3.0.0
Bump doctrine/dbal from 2.12.0 to 3.0.0
2021-01-08 14:58:43 +01:00
Christoph Wurst 8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
Daniel Calviño Sánchez fb19d4afe2 Fix clearing the label of a share
When the label is being edited its value is stored in "newLabel", and
the original label is shown only if "newLabel" is not set. However, as
it was checked against any falsy value instead of only undefined when
the label was cleared and thus it has an empty value the original label
was shown instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-08 09:27:28 +00:00
Nextcloud bot 94188370e7
[tx-robot] updated from transifex 2021-01-08 02:22:30 +00:00
dependabot-preview[bot] dab181a021
Bump core-js from 3.8.1 to 3.8.2
Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.8.1...v3.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-07 14:55:52 +01:00
dependabot-preview[bot] 73f9f3f9ae
Bump @nextcloud/axios from 1.5.0 to 1.6.0
Bumps [@nextcloud/axios](https://github.com/nextcloud/nextcloud-axios) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/nextcloud/nextcloud-axios/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-axios/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-axios/compare/v1.5.0...v1.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-07 09:29:29 +01:00
Julius Härtl 39c67d9868
Merge pull request #24829 from nextcloud/bugfix/24813/add-missing-migrations 2021-01-05 09:32:33 +01:00
Christoph Wurst 969d4312e2
Merge pull request #24907 from nextcloud/fix/license-headers-21-II
Update license headers
2021-01-04 11:06:30 +01:00
Nextcloud bot 8d22ba4a33
[tx-robot] updated from transifex 2021-01-04 02:21:48 +00:00
Nextcloud bot 25fd32cb5c
[tx-robot] updated from transifex 2021-01-01 02:21:03 +00:00
Nextcloud bot d57153940b
[tx-robot] updated from transifex 2020-12-31 02:27:04 +00:00
Christoph Wurst 9ce3ea3368
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +01:00
Julius Härtl 9f5ada5d45
Also include external share results in recommendations
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-30 10:33:52 +01:00
Nextcloud bot f9941347e2
[tx-robot] updated from transifex 2020-12-30 02:19:06 +00:00
Nextcloud bot c15b0b0250
[tx-robot] updated from transifex 2020-12-24 02:20:06 +00:00
Vincent Petry 6c0de14b4c
Also add missing oc_share_external.share_type column
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-23 16:20:01 +01:00
Vincent Petry 07bf663f4c
Adjust share_external table
Add column "parent" if missing.
Drop column "lastscan" if exists.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-23 15:44:32 +01:00
Nextcloud bot 61791962f2
[tx-robot] updated from transifex 2020-12-23 02:20:11 +00:00
Roeland Jago Douma adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
Unify links to php.net
2020-12-22 09:53:31 +01:00
Nextcloud bot de7c54c6ba
[tx-robot] updated from transifex 2020-12-18 02:20:09 +00:00
Nextcloud bot acf9aa19da
[tx-robot] updated from transifex 2020-12-17 02:20:20 +00:00
Christoph Wurst d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
npmbuildbot-nextcloud[bot] abad2efb44 Compile assets
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-12-15 11:05:03 +00:00
Arthur Schiwon d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 11:53:39 +01:00
dependabot-preview[bot] 4652b15a3d Bump core-js from 3.8.0 to 3.8.1
Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.0 to 3.8.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.8.0...v3.8.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-12-15 07:54:33 +00:00
Julius Härtl 8b13fd4a6c
Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:15:59 +01:00
Julius Härtl 102402bfcb
Show unique displayname context in the user share list entries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:59 +01:00
Julius Härtl 131fcac91e
Show unique displayname context in the sharing input
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:59 +01:00
Julius Härtl a86746ea08
Make share results distinguishable if there are more than one with the exact same display name
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:58 +01:00
Nextcloud bot 78ca1819f6
[tx-robot] updated from transifex 2020-12-14 02:19:26 +00:00
Nextcloud bot ea4fc6b507
[tx-robot] updated from transifex 2020-12-13 02:18:32 +00:00