98f79173ed
Keep "encryptedVersion" when calling `\OC\Files\View::copy`
...
When calling `\OC\Files\View::copy` we should also keep the version to ensure that the file will always have the correct version attached and can be successfully decrypted.
To test this the following steps are necessary (from https://github.com/owncloud/core/issues/22781#issuecomment-191328982 ):
1. setup a new ownCloud 9.0 beta2
2. enable encryption
2. upload a docx (5.7MB large)
3. upload the same file again and overwrite the existing file
4. I can download the original file and the first version
5. I restore the first version
6. restored version can no longer be downloaded with the error described above
The manual cache operation in `\OCA\Files_Versions\Storage` is unfortunately necessary since `\OCA\Files_Versions\Storage::copyFileContents` is not using `\OCP\Files\Storage::moveFromStorage` in the case when an object storage is used. Due to the workaround added in 54cea05271
2016-03-03 14:41:53 +01:00
4d69e562a0
Merge pull request #22757 from owncloud/apply-license
...
Update copyright information and author file
2016-03-01 15:36:37 -05:00
5a2fe4107c
Merge branch 'master' into part-file-root
2016-03-01 13:35:04 -05:00
745fdc4800
Merge pull request #22742 from owncloud/ceph-keystone-readiness
...
Use readiness notification socket to be absolutely sure this works
2016-03-01 13:34:23 -05:00
3067367ff3
Add new apps
2016-03-01 17:52:32 +01:00
c353d51810
Remove Scrutinizer Auto Fixer
2016-03-01 17:48:23 +01:00
c430f5ba53
Map Maci
2016-03-01 17:45:05 +01:00
933f60e314
Update author information
...
Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)
2016-03-01 17:25:15 +01:00
37f1206818
allow putting the part file in the view root
2016-03-01 15:21:24 +01:00
900dcf6594
Merge pull request #22699 from owncloud/checksum_int_test
...
Checksum intergration tests and fixes
2016-03-01 14:47:09 +01:00
a83af96dd3
Merge pull request #22686 from owncloud/cleanup_remote_address_books
...
remove remote address book if access was revoked
2016-03-01 14:46:51 +01:00
57babe032b
Save some calls to refreshInfo during upload
2016-03-01 11:44:49 +01:00
ac392457f2
Fix unit tests
2016-03-01 11:37:16 +01:00
ec140fa2ec
Checksums on chunked files
...
We should also store checksums on chunked files.
We do not checksum individual chunks but only the final file.
2016-03-01 11:37:16 +01:00
3e88a5067f
Remove checksum on upload of non checksumed file
...
When we overwrite a checksumed file with a file without a checksum we
should remove the checksum from the server.
This is done by setting the column to empty.
2016-03-01 11:37:16 +01:00
5fe5233f41
Merge pull request #22681 from owncloud/add-autodiscovery-for-ocs
...
Add autodiscovery support to server-to-server sharing implementation
2016-03-01 11:27:28 +01:00
73e145cf63
Merge pull request #22728 from owncloud/external-share-testremote
...
use ocs discover endpoint to test remote
2016-03-01 11:27:07 +01:00
1832bd0fa1
increase version number
2016-03-01 11:21:24 +01:00
a66899c528
Handle null case
2016-03-01 10:41:05 +01:00
1652541150
Merge pull request #22700 from owncloud/only_1_linkshare
...
For now only allow 1 link share per file/folder
2016-03-01 09:22:39 +01:00
25a4571dcd
Merge pull request #22731 from owncloud/hide-nodes-from-listening
...
Hides nodes from listing that the user has no access to
2016-03-01 09:22:08 +01:00
fd4742d430
Merge pull request #22613 from owncloud/quota-changedavreturnvaluewhennoquotaset
...
Don't return quota when none set
2016-03-01 08:30:58 +01:00
ffce4fc6a9
For now only allow 1 link share per file/folder
...
Fixes #22692
This is a temp fix util we get #22327
We just block it in the OCS Share API since we have 1 endpoint now
anyway.
2016-03-01 08:25:40 +01:00
eb740d1dac
Merge pull request #22727 from owncloud/decrypt_all_master_key
...
make decrypt all work with the master key
2016-03-01 08:23:27 +01:00
f3050b3adb
Merge pull request #22740 from owncloud/fix_resare_updates
...
Check correct permissions when resharing
2016-03-01 08:17:56 +01:00
a06f59c580
[tx-robot] updated from transifex
2016-03-01 01:55:33 -05:00
3adb6ae0f5
Merge pull request #22707 from owncloud/use-our-public-api
...
Use IQueryBuilder::PARAM_* instead of \PDO::PARAM_*
2016-03-01 07:24:57 +01:00
9ca1e9c7e9
Only use scanner if remote is an ownCloud
2016-03-01 07:01:52 +01:00
e965dcaebf
/shareinfo is not required
2016-03-01 07:01:52 +01:00
8f95d69954
Fix tests
2016-03-01 07:01:52 +01:00
74e47da883
Add missing trailing slash
2016-03-01 07:01:51 +01:00
080a62231e
use ocs discover endpoint to test remote
2016-03-01 07:01:51 +01:00
88fc5149ed
Fix Scrutinizer issues
2016-02-29 22:44:40 +01:00
078cc3b3f0
Use readiness notification socket to be absolutely sure this works
2016-02-29 21:20:11 +00:00
d04edfaf0d
Hides nodes from listing that the user has no access to
2016-02-29 20:53:38 +01:00
8924b0a0dc
Check correct permissions when resharing
...
Fixes #22675
Since we only get a share id we do not know the path for the sharer.
Now if we edit a share we start searching for shares for that user of
that node. And deduce the permissions that way.
* Intergration test added
* Fix unit tests
2016-02-29 19:30:14 +01:00
9e9cb73987
fix doc-block
2016-02-29 16:50:34 +01:00
87e47afed8
remove synced remote address book if the remote server revoked access to his system address book
2016-02-29 16:50:34 +01:00
7189c72c33
remove remote address book if the admin removes the server from the trusted servers list
2016-02-29 16:50:33 +01:00
52d217d775
Merge pull request #22623 from owncloud/docker-logs-on-swift-external
...
Print docker logs to the console fro debugging
2016-02-29 16:36:34 +01:00
95ea2ccb53
make decrypt all work with the master key
2016-02-29 14:54:32 +01:00
11215f4e27
Return -3 for unlimited quota
...
Returns -3 for unlimited quota in Webdav response.
Also adjusted personal page to show unlimited quota when set.
2016-02-29 14:36:20 +01:00
a38e8b6436
Merge pull request #22662 from owncloud/comments-count
...
remove comments count because it is not that relevant to show directly
2016-02-29 13:44:56 +01:00
2a0cda74d4
Use IQueryBuilder::PARAM_* instead of \PDO::PARAM_*
2016-02-29 09:44:40 +01:00
5800585039
[tx-robot] updated from transifex
2016-02-29 01:55:04 -05:00
a39332832c
[tx-robot] updated from transifex
2016-02-28 01:55:12 -05:00
f9826ec948
[tx-robot] updated from transifex
2016-02-27 01:56:08 -05:00
eccd7cf654
reuse the url_hash instead of calculating a new hash for the address book
2016-02-26 20:00:13 +01:00
e9237dd83c
Merge pull request #22671 from owncloud/issue-22670
...
Move the tag filter at the end for now
2016-02-26 10:48:55 +01:00
66536f912e
Merge pull request #22640 from owncloud/fix_22587
...
Remove delete permissions for read-only federated reshares
2016-02-26 10:48:07 +01:00
c6c15ba825
Merge pull request #22608 from owncloud/collaborative-tags
...
Rename system tags app to collaborative tags
2016-02-26 10:47:40 +01:00
96f15a12a9
Merge pull request #22461 from owncloud/fix_6773
...
Allow theming of actions
2016-02-26 10:47:20 +01:00
4549b82553
Move the tag filter at the end for now
2016-02-26 10:15:07 +01:00
59028cced0
Add autodiscovery support to server-to-server sharing
...
Adds autodiscovery support to server-to-server sharing as specified in the specification. If no discovery data is found it is using the fallback ownCloud endpoints for legacy support.
2016-02-26 09:26:55 +01:00
4471f359b1
Rename system tags app to collaborative tags
2016-02-26 09:14:28 +01:00
5718402277
[tx-robot] updated from transifex
2016-02-26 01:55:44 -05:00
867a8aca12
Fix favorite icon unit test for icon image
2016-02-25 23:01:09 +01:00
b634f1e2c7
Make more action icons themable + style fixes
...
Action icons now appear properly in public link page.
More actions are now CSS icons.
2016-02-25 23:01:07 +01:00
c767030f07
Close class
2016-02-25 22:49:52 +01:00
92cff0984d
Make file actions use icon CSS classes
...
This makes theming of file actions possible
2016-02-25 22:49:52 +01:00
6e97ab1b71
remove comments count because it is not that relevant to show directly
2016-02-25 20:48:19 +01:00
3772a8acdb
Merge pull request #22644 from owncloud/external-share-manager
...
inject the correct external share manager into the storage
2016-02-25 16:58:00 +01:00
29e3c4a60e
Merge pull request #22628 from owncloud/fix-thrashbin-cronjob
...
Skip users with no trashbin
2016-02-25 16:55:36 +01:00
f338329ddf
inject the correct external share manager into the storage
2016-02-25 14:49:25 +01:00
914ac09aae
Merge pull request #22636 from owncloud/fix-ssl-on-external-storages
...
Fix HTTPS support on external storages
2016-02-25 14:36:00 +01:00
202bf17e4a
Merge pull request #22604 from owncloud/fix-google-drive-encryption
...
Copy into local file
2016-02-25 14:35:39 +01:00
5ecf2d5987
Merge pull request #22600 from owncloud/extstorage-disablesharingoptionbydefault
...
Disable sharing by default for external storage mounts
2016-02-25 14:35:24 +01:00
dfaebc36d2
Merge pull request #22599 from owncloud/fix_ldap-cache-2nd-displayname
...
take the first result of that array, if present. Fixes 2nd display na…
2016-02-25 14:35:06 +01:00
0c9c7737b4
Remove delete permissions for read-only federated reshares
...
An incomming federated share is just a mount point. Therefor if we
request the permissions on the mountpoint DELETE permissions will be
returned (among others). Since we can always remove a mountpoint, update
a mount point.
However now when trying to reshare we will try to reshare with DELETE
permissions. Which is false.
This PR removes the delete permissions if it is a shared storage.
Basically a quick hack.
Fixes #22587
2016-02-25 12:19:38 +01:00
aebb900cd4
More error handling
2016-02-25 10:12:31 +01:00
3b5ddb417c
Copy into local file
...
Using the Guzzle stream directly here will only return 1739 characters for `fread` instead of all data. This leads to the problem that the stream is read incorrectly and thus the data cannot be properly decrypted => 💣
This approach copies the data into a local temporary file, as done before in all stable releases as well as other storage connectors.
While this approach will load the whole file into memory, this is already was has happened before in any stable release as well. See d608c37c90https://github.com/owncloud/core/issues/22590
2016-02-25 09:40:30 +01:00
32f4bea0ae
[tx-robot] updated from transifex
2016-02-25 01:58:06 -05:00
b9b85e32be
take the first result of that array, if present. Fixes 2nd display name to be 'Array', if cache is configured and enabled.
2016-02-24 21:32:03 +01:00
db2ddb5441
Properly cast type
...
The current logic is checking whether:
1. The returned value is a boolen
2. The returned value is a string and then matches for "true"
Since the config is now written to the database the data is now a string with the value "1" if HTTPS is set to true. Effectively this option was thus always disabled at the moment, falling back to plain HTTP.
This change casts the data to a boolean if it is defined as boolean.
Fixes https://github.com/owncloud/core/issues/22605
Fixes https://github.com/owncloud/core/issues/22016
2016-02-24 19:58:41 +01:00
aac6932e92
Skip users with no trashbin
2016-02-24 18:08:45 +03:00
4829a2d421
Disable sharing by default for external storage mounts
...
This is for newly created mount points.
Migrated mount points will have sharing enabled as before.
2016-02-24 13:58:21 +01:00
ac9de4ee95
Print docker logs to the console fro debugging
2016-02-24 13:58:13 +01:00
faf65e73b7
Merge pull request #22593 from owncloud/swift-docker-fix
...
Enable upstream entrypoint changes with Ceph Docker
2016-02-24 12:17:58 +01:00
473cd97a45
Merge pull request #22592 from owncloud/fix-response-header
...
Add header for attachment disposition only once
2016-02-24 12:15:32 +01:00
9a0950f10b
Merge pull request #22569 from owncloud/issue-22566-too-much-mapping-entries
...
Allow defining a limit and offset for getObjectIdsForTags
2016-02-23 15:02:08 +01:00
403f11633c
Drop unneeded use statements
2016-02-23 14:53:12 +01:00
1d8c1f5692
Enable upstream entrypoint changes with Ceph Docker
2016-02-23 11:52:05 +00:00
fc2c5fe414
Add header for attachment disposition only once
...
Recent refactorings have resulted in the header being added twice, this makes browsers ignore the header which removes any security gains.
This changeset adds the header only once and adds integration tests ensuring the correct header in future.
https://github.com/owncloud/core/issues/22577
2016-02-23 12:23:41 +01:00
fae6643e6d
Merge pull request #22582 from owncloud/case-insensitive-contact-search
...
Case insensitive contact search
2016-02-23 10:48:38 +01:00
a3d1b2637d
Merge pull request #22516 from owncloud/core-cumulativenotifications
...
Accumulate notifications instead of blinking
2016-02-23 10:36:34 +01:00
3a65bdf4d5
Fix dav unit tests
2016-02-23 09:04:15 +01:00
4dfdb2720c
Case insensitive search in contacts - fixes #22575
2016-02-22 19:47:10 +01:00
27544144ce
Fix unit tests affected by side effects
...
The notification tests were not restoring the clock properly, but
indirectly helped other tests pass.
Since now we're restoring the clock properly, the other tests were fixed
to still work.
2016-02-22 17:25:32 +01:00
8ea80e114a
Accumulate notifications instead of blinking
...
This makes it possible to display multiple notifications.
If the options.type is set to "error", it will also add a close button.
2016-02-22 17:25:32 +01:00
a0d0edc754
Make non-public-method protected
2016-02-22 15:26:59 +01:00
f3b13c7656
Merge pull request #22536 from owncloud/add-integration-tests-for-tags
...
Add integration tests for tags plus fix permissions
2016-02-22 14:14:51 +01:00
7f2b3dbfd2
Merge pull request #22555 from owncloud/jenkins-19978
...
Show username when writing "Insufficient storage" into owncloud.log
2016-02-22 14:13:59 +01:00
642190f333
Fix public page footer position in IE
...
The content element needs hasLayout, so triggering it with a display
attribute.
Without this, the #content element's height would be as high as the
window's height instead of adjusting itself to its contents' height.
2016-02-22 11:26:50 +01:00
1a8a667863
Solution for Proposal #19974
...
Show username when writing into owncloud.log
2016-02-22 10:02:45 +01:00
3e59c04c7f
Fixes pagination in IE
...
* tested in Firefox, Chrome, Safari, IE and Edge with folder and file shares
* fixes #20044
2016-02-22 08:55:20 +01:00
3bd95cca6b
Check if user has permission to create such a tag
...
Fixes https://github.com/owncloud/core/issues/22512
2016-02-19 20:45:20 +01:00
f8677628d4
Merge pull request #22503 from owncloud/issue_22500
...
When (re-)sharing an incomming federated share set the corrent owner
2016-02-19 16:07:43 +01:00
5b3a79a28b
Merge pull request #22509 from owncloud/add-filesplugin-to-new-webdav-endpoint
...
Add FilesPlugin
2016-02-19 14:44:02 +01:00
66f0ba837f
Merge pull request #22348 from owncloud/issue-21812-calendar-old-caldav-url
...
Fix old calendar dav urls
2016-02-19 13:33:16 +01:00
4ef035cc61
make sure that the file name doesn't end with a trailing slash. Can for example happen single files shared across servers
2016-02-19 13:15:09 +01:00
e987d8cd47
Add FilesPlugin - fixes #22507
2016-02-19 12:37:24 +01:00
1106c354ac
Merge pull request #22515 from owncloud/webdav_checksum_only_for_files
...
Only add checksum headers for 'real' files
2016-02-19 12:36:56 +01:00
b216be8cca
Add correct principals for the current user before ACL check
2016-02-19 12:35:33 +01:00
4e2f9ce05b
Convert the old principal to the new principal before getting calendars
2016-02-19 12:35:33 +01:00
ffc2950393
Merge pull request #22198 from owncloud/birthday-calendar
...
Sync a users contacts birthday to the users birthday calendar
2016-02-19 12:33:19 +01:00
751d3df469
Only add checksum headers for files
...
We can only add the checksum header for real ownCloud files (so we have
a fileinfo object etc).
2016-02-19 10:56:43 +01:00
ae2304f23f
Merge pull request #22405 from owncloud/gdrive-mimetype-and-office-fixes
...
Fix GDrive handling of office files
2016-02-19 09:13:35 +01:00
f6e61a296f
Merge pull request #22424 from owncloud/add-generic-csrf-protection-to-webdav
...
Require CSRF token for non WebDAV authenticated requests
2016-02-19 09:13:00 +01:00
d1ef43481d
Merge pull request #22444 from owncloud/fix-federated-share-delete
...
get the actual user instead of a federated cloud id
2016-02-18 16:44:57 +01:00
d8de7d1e73
Adding cli command to sync birthday calendar
2016-02-18 14:49:45 +01:00
6c4cdddba8
Merge pull request #21610 from owncloud/quota-sharedfile
...
Fix quota check for single shared files
2016-02-18 14:25:32 +01:00
e1dbae1467
Properly trigger testRemote after getting a 404 from remote fed share
...
Whenever a remote fed share's shareinfo call returns a 404, don't
directly assume the storage is not available by throwing
StorageNotAvailableException. We need to properly throw
NotFoundException to trigger the later logic that calls testRemote()
that verifies that the 404 is not from a broken server but really from
an obsolete share.
2016-02-18 11:57:03 +01:00
981c73000c
Prevent deletion of birthday calendar
2016-02-18 11:49:16 +01:00
c9187cc820
Sync a users contacts birthday to the users birthday calendar
2016-02-18 11:48:34 +01:00
9b3c4e8dc4
Require CSRF token for non WebDAV authenticated requests
2016-02-18 11:18:36 +01:00
73d46afc3c
Merge pull request #22399 from owncloud/issue-22394-index-names-for-oracle
...
Add index names so Doctrine does not use a too long random string
2016-02-18 11:18:32 +01:00
bba8875fb5
Merge pull request #22434 from owncloud/share_ocs_api_handle_invalid_shares
...
OCS Share API should not return invalid shares
2016-02-18 11:17:41 +01:00
9d24de0ceb
Merge pull request #22478 from owncloud/external-missing-auth
...
dont die when missing an auth backend
2016-02-18 11:17:19 +01:00
8985181305
get the actual user instead of a federated cloud id
...
$view->getUidAndFilename($filename); returns the federated cloud id in case of
a federated share. But in this case we need the local user who "owns" the file
which is the current logged in user in case of a federated share
2016-02-18 10:17:00 +01:00
ac1c3d27b7
get the actual user instead of a federated cloud id
...
$view->getUidAndFilename($filename); returns the federated cloud id in case of
a federated share. But in this case we need the local user who "owns" the file
which is the current logged in user in case of a federated share
2016-02-18 10:16:59 +01:00
3a97a0ad7f
Merge pull request #22475 from owncloud/fix-js-issues
...
Fixes code analysis issues
2016-02-18 10:14:31 +01:00
8798f85e88
Merge pull request #22418 from owncloud/issue-22393-filelist-plugins-for-other-views
...
Show the comments and tags on the share filters
2016-02-18 10:14:20 +01:00
bfd4a9548b
Merge pull request #22408 from owncloud/gdrive-remove-mimetype-detection
...
Fix GDrive mime type detection with encryption
2016-02-18 10:14:01 +01:00
65a283f967
dont die when missing an auth backend
2016-02-17 16:51:40 +01:00
ceaefc2c54
Defer quota check in web UI when overwriting shared file
...
When receiving a shared file, the quota for that file counts in the
owner's storage, not the current user's storage.
To make it possible to overwrite the file even when the current user
doesn't have enough space, the quota check is deferred for such files.
2016-02-17 15:38:21 +01:00
d55cfb4f89
Fixes code analysis issues
2016-02-17 15:19:42 +01:00
7af7d18cfa
Merge pull request #16783 from owncloud/handle-redirects-global
...
Adding global error handler for ajax calls which run into redirection…
2016-02-17 14:49:04 +01:00
670557ffbb
Add unit tests for formatShare
2016-02-17 13:55:39 +01:00
2aa0b885f6
OCS Share API should not return invalid shares
...
Since we have lazy shares it can happen that a share is actually
invalid. See https://github.com/owncloud/core/issues/20908
This add checks for the get methods to handle the NotFound exception.
2016-02-17 13:55:39 +01:00
c2c6caee93
remove global credentials
2016-02-17 13:55:27 +01:00
53eff9792f
Check the quota on the actual file's storage in dav quota plugin
...
Fix quota plugin to use the correct file name when chunking
When chunking, the file name is the compound name, so need to convert it
to the correct final file name before doing the free space check.
This ensures that in the case of shared files, the correct storage is
used for the quota check.
2016-02-17 11:52:49 +01:00
9e415a956a
Merge pull request #22451 from owncloud/use-proper-user-folder
...
Handles null as return code and uses proper UserFolder in trashbin
2016-02-17 10:58:31 +01:00
ff4e040971
Merge pull request #22435 from owncloud/trashbin-hook-nouser
...
Don't resize trash when no user
2016-02-17 10:57:50 +01:00
fe29feae9a
[tx-robot] updated from transifex
2016-02-17 01:56:11 -05:00
de58364eb8
Handles null as return code and uses proper UserFolder in trashbin
2016-02-16 18:45:25 +01:00
7bed529951
Don't resize trash when no user
...
Happens when overwriting files on federated shares.
2016-02-16 16:29:07 +01:00
c6b2457306
Merge pull request #22432 from owncloud/files_external-backends
...
remove login credentails and user provided backends
2016-02-16 16:08:21 +01:00
176fb191b7
remove login credentails and user provided backends
2016-02-16 15:27:55 +01:00
7942f3d7ec
[tx-robot] updated from transifex
2016-02-16 08:49:12 -05:00
3503eb69f2
Adding transifex to new core apps
2016-02-16 14:40:10 +01:00
077a407285
Show the comments and tags on the share filters
2016-02-16 11:24:44 +01:00
1cb3583a9a
Merge pull request #22398 from owncloud/fix-card-properties
...
Queries on the cards table by uri require the addressbook as well
2016-02-16 10:19:51 +01:00
3a55229915
Merge pull request #22400 from owncloud/files-select-closesidebar
...
Close file detail sidebar when selecting/unselecting files
2016-02-16 09:15:14 +01:00
f850871415
Merge pull request #22385 from owncloud/issue-22384-invalid-content-location-on-commenting
...
Posting a comment replies with invalid location URL
2016-02-16 08:30:11 +01:00
9942263409
Merge pull request #22392 from owncloud/create-default-calendar-and-addressbook
...
On login we create a default calendar and a default addressbook for t…
2016-02-16 08:29:54 +01:00
e5641247a3
Merge pull request #22403 from owncloud/improved-error-handling
...
Remove background job if the server accepted to ask for the shared secret
2016-02-16 08:29:38 +01:00
3dd1961f92
[tx-robot] updated from transifex
2016-02-16 01:55:39 -05:00
9d1d08bf9b
forbidden (403) is a valid return status, don't log the whole exception in this case
2016-02-15 18:03:10 +01:00
835e70dbe2
throw exception if we don't find a token for a given server
2016-02-15 18:03:10 +01:00
cc397da1be
Remove background job if the server accepted to ask for the shared secret
...
If we don't remove it the server will later ask the remote server to ask for
the shared secret which will result in a error log message on the remote server
and in some circumstances maybe even to a failure
2016-02-15 18:03:10 +01:00
Lukas Reschke
C. Montero Luque
Robin Appelman
Thomas Müller
Vincent Petry
Roeland Jago Douma
Bjoern Schiessle
Jenkins for ownCloud
Robin McCorkell
Joas Schilling
Jan-Christoph Borchardt
Arthur Schiwon
Victor Dubiniuk
Morris Jobke
Pierre Jochem