10ac844448
Update documentation for QueryBuilder::set
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 19:55:01 +02:00
5b26487f14
Expose status via Collaborators API
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-14 17:04:52 +02:00
8daaf33e3d
Silence duplicate session warnings
...
Fixes #20490
Basically restroring the old behavior.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-14 05:23:11 +02:00
5559570faf
Merge pull request #22242 from nextcloud/techdebt/noid/remove-deprecated-methods
...
Remove deprecated and unused method calls
2020-08-14 10:10:53 +08:00
b12a390220
Always try and show pre rendered preview
...
Currently if the following situation happens
Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)
This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.
After the fix the following would happen
Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)
This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.
Signed-off-by: Scott Dutton <scott@exussum.co.uk>
2020-08-13 22:50:38 +02:00
16d83ab30a
Remove getLastJob from IJobList
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 21:50:06 +02:00
ee23906c3c
Allow writing empty content to new file
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-13 15:41:26 +02:00
52eff4ae7c
Use user mount with matching shared storage only
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 15:10:05 +02:00
0b856329eb
Merge pull request #22202 from nextcloud/enh/noid/cleanup-servercontainer
...
Use autowiring where possible in server container
2020-08-13 10:55:48 +02:00
3c56922444
Merge pull request #22205 from nextcloud/activity-settings-cleanup
...
merge file activity settings into a single 'favorite changed' item
2020-08-13 08:15:06 +02:00
df4bcd616f
Add @deprecated labels for server DI containter aliases
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 07:43:37 +02:00
725fecee34
Merge pull request #21344 from nextcloud/fix/twofactor-cleanup-event
...
Emit an event for every disabled 2FA provider during cleanup
2020-08-13 07:25:01 +02:00
894640206e
Use registerDeprecatedAlias for non-namespaced aliases
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 05:43:38 +02:00
2f2252cfba
Use autowiring where possible in server container
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 05:43:36 +02:00
3a39f2ae91
[tx-robot] updated from transifex
2020-08-13 02:16:38 +00:00
5f58cefbd7
merge file activity settings into a single 'favorite changed' item
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-13 00:01:34 +02:00
ad6a4219a2
[tx-robot] updated from transifex
2020-08-12 02:16:50 +00:00
4dd507675c
Generate password by password_policy app
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-11 21:58:51 +02:00
8fc877ff7d
Merge pull request #22117 from nextcloud/activity-settings-grouping
...
allow grouping of activity settings
2020-08-11 11:24:23 +02:00
bc4df68e56
Merge pull request #22169 from nextcloud/enh/noid/prefer-typed-events
...
Prefer typed event over string based ones
2020-08-11 09:34:48 +02:00
c0be7e329f
Prefer typed event over string based ones
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-10 15:22:55 +02:00
782a2df392
Add PHP doc for events
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-10 14:24:24 +02:00
54726d5934
Merge pull request #21738 from nextcloud/techdebt/14552/migrate-OC_Group-post_removeFromGroup
...
Migrate OC_Group post_removeFromGroup hook to actual event object
2020-08-07 17:46:00 +02:00
96d418b379
Add proper deprecation message
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-07 17:45:45 +02:00
408ed7ebd4
Merge pull request #22139 from nextcloud/fix/noid/check-for-preview-multibucket-fallback-as-second-step
...
Check previews in multibucket fallback folder as the last step and not as first step
2020-08-07 16:02:02 +02:00
9e962fb69f
Allow to update to nightly
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-07 13:51:39 +02:00
0807e29e17
Merge pull request #22133 from nextcloud/boot-app-once
...
only boot apps once
2020-08-07 12:05:09 +02:00
06eb230d24
Merge pull request #22135 from nextcloud/enh/noid/occ-preview-repair
...
Add occ preview:migrate to migrate previews from the old flat structure to a subfolder structure
2020-08-07 11:09:16 +02:00
246ed35d94
only boot apps once
...
in some cases `loadApp` is called more then once which is currently causing apps to be "booted" multiple times which can lead to unexepected behaviour with things like registering hooks
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-07 11:04:47 +02:00
4d0c3fa4a8
Check previews in multibucket fallback folder as the last step and not as first step
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-07 09:37:11 +02:00
45428e4948
Add config option to enable multibucket preview distribution
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-06 22:31:39 +02:00
4fdd38c737
Use fixed preview buckets that are postfixed with -preview-NUMBER
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-06 22:19:21 +02:00
159f28cd52
Mount the old previews in a separate folder for the multi bucket setup and check in them before using the actual locations
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-06 22:19:21 +02:00
438ac23e2a
Distribute preview folders in appdata in multibucket setup to multiple buckets
...
* introduces a new IRootMountProvider to register mount points inside the root storage
* adds a AppdataPreviewObjectStoreStorage to handle the split between preview folders and bucket number
Ref #22033
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-06 22:19:20 +02:00
d8734b3b93
Add occ preview:migrate to migrate previews from the old flat structure to a subfolder structure
...
* `php occ preview:repair` - a preview migration tool that moves existing previews into the new location introduced with #19214
* moves `appdata_INSTANCEID/previews/FILEID` to `appdata_INSTANCEID/previews/0/5/8/4/c/e/5/FILEID`
* migration tool can be stopped during migration via `CTRL+C` - it then finishes the current folder (with the previews of one file) and stops gracefully
* if a PHP memory limit is set in the `php.ini` then it will stop automatically once it has less than 25 MiB memory left (this is to avoid hard crashes in the middle of a migration)
* the tool can be used during operation - possible drawbacks:
* there is the chance of a race condition that a new preview is generated in the moment the folder is already migrated away - so the old folder with the newly cached preview is deleted and one cached preview needs to be re-generated
* there is the chance of a race condition during access of a preview while it is migrated to the other folder - then no preview can be shown and results in a 404 (as of now this is an accepted risk)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-06 22:05:46 +02:00
3f1c48598d
Merge pull request #22112 from nextcloud/enh/noid/flow-entity-recreatable-state
...
Allow Flow entity state to be recreated
2020-08-06 09:36:32 +02:00
5b6246f52a
Merge pull request #21598 from nextcloud/enh/20930/dashboard-drag
2020-08-06 08:17:52 +02:00
ae9ecd521f
Merge pull request #21677 from J0WI/clearstatcache-on-rmdir
...
Do clearstatcache() on rmdir
2020-08-05 23:03:06 +02:00
519cd678ee
Merge pull request #22008 from elijahnyp/OCImage_Leak_Fix
...
Ensured large image is unloaded from memory when generating previews
2020-08-05 22:39:09 +02:00
61cc356e0b
Fix php cs check
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-05 17:03:39 +02:00
018be662f4
Refactor API to match the widget wording
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-05 17:03:38 +02:00
db86bea18c
Allow default app to be overwritten by user config
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-05 17:03:38 +02:00
e25bab98b7
Set Dashboard as default app
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-08-05 17:01:28 +02:00
55473dd2eb
Merge pull request #22104 from nextcloud/enh/search/make-app-handle-the-order-logic
...
Make apps handle the order logic
2020-08-05 16:38:45 +02:00
227e362842
allow grouping of activity settings
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-05 16:13:03 +02:00
79fc7e78b7
Merge pull request #21138 from nextcloud/fix/noid/search-in-group-displayname-email
...
Search also the email and displayname in user mangement for groups
2020-08-05 16:09:00 +02:00
f510da139f
Use class that actually has the destroy() method in preview generator
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 15:52:40 +02:00
6fbf8fceac
Merge pull request #22106 from nextcloud/feature/noid/user_status_api
...
Provide a PHP Api for UserStatus
2020-08-05 15:30:48 +02:00
ea8f68bea6
Hand in the route and the parameters of the request
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-05 12:52:16 +00:00
a4d511d827
Merge pull request #22099 from nextcloud/fix/unified-search
2020-08-05 14:17:42 +02:00
fee13e7ffd
Search also the email and displayname in user mangement for groups
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 14:14:05 +02:00
0e0e0d19e8
Provide a PHP Api for UserStatus
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-05 13:48:46 +02:00
6c1c9273c0
Enable Flow entities to recreate state if necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-05 13:24:20 +02:00
0581356169
Merge pull request #22097 from nextcloud/enh/noid/empty-template
...
Add empty renderAs template
2020-08-05 11:42:29 +02:00
d98f7c1bd8
Make apps handle the order logic
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-05 11:37:45 +02:00
b0c5457c42
IAddressBook: add isShared and isSystemAddressBook
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-05 09:04:41 +02:00
71b62c4203
Show mime icon, bump bundles, make the SearchResultEntry class non-abstract, Fix header search icon, various fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-04 21:36:22 +02:00
6eced42b7a
Remove outdated legacy search scripts
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-04 20:56:22 +02:00
b51746212e
Add base renderAs template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-04 09:48:43 +02:00
489fecac32
Merge pull request #22057 from nextcloud/fix/20009/contactsmenu-limit-users
...
contactsmanager shall limit number of results early
2020-08-03 15:15:46 +02:00
1a1b3e20e4
Fix unified search
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-03 11:26:03 +00:00
0fad921840
Add user-status app
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-31 16:45:27 +02:00
7c56283c3c
contactsmanager shall limit number of results early
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-07-31 12:42:17 +02:00
e19bbce7f6
Merge pull request #22060 from nextcloud/trashbin-s3-fixes
...
Object store trashbin fixes
2020-07-31 10:10:33 +02:00
6cb550d567
fix instanceof ISettings check for activity settings
...
boolean logic is hard
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 17:53:14 +02:00
8c3b22859c
dont update mimetype when moving to trash
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 16:11:45 +02:00
a32e6a7958
Merge pull request #21993 from nextcloud/fix/lower_route_not_found_level
...
Log the route not found exception on a lower level
2020-07-30 10:59:31 +02:00
084f5063f2
Deprecate BeforeUserRemovedEvent because it can't be triggered in all cases
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-30 10:21:08 +02:00
4a7d7e446f
User.php: rename of old dispatcher to legacyDispatcher
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-30 10:21:08 +02:00
36ee37ec0a
Migrate OC_Group post_removeFromGroup hook to actual event object
...
Ref #14552
This adds a BeforeUserRemovedEvent to the LDAP backend because it was missing. It's not really before, but we don't have the before state.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-30 10:21:08 +02:00
5993bd45f3
Correctly remove usergroup shares on removing group members
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-30 09:47:31 +02:00
2af77b2ed7
Merge pull request #22034 from nextcloud/bugfix/noid/parse-url-returns-null
...
parse_url returns null in case a parameter is not found
2020-07-29 18:07:50 +02:00
7e28286e9d
Merge pull request #21542 from nextcloud/activity-notifications
...
basic settings system for activity notifications
2020-07-29 15:36:38 +02:00
9127731c52
parse_url returns null in case a parameter is not found
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-29 08:32:20 +02:00
1f42a8b5cb
[tx-robot] updated from transifex
2020-07-29 02:16:52 +00:00
bab4fb98eb
Fix overwriteService() for apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-28 09:38:43 +02:00
56ed563b0c
fix memory leak caused by not destroying image in Preview/Generate.php
...
Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>
2020-07-27 10:52:44 -04:00
4cac0f6895
[tx-robot] updated from transifex
2020-07-27 02:16:32 +00:00
34c3d0a977
[tx-robot] updated from transifex
2020-07-25 02:16:36 +00:00
b57019bcaa
Log the route not found exception on a lower level
...
This should be logged but it is not that critical to wanner level 3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-24 15:39:53 +02:00
15561b4e0a
Merge pull request #21977 from onehappycat/issue_21960
...
Ignore whitespace in sharing by mail
2020-07-24 13:37:36 +02:00
c8427781b4
implement old settings interface
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-24 13:03:35 +02:00
e1b696929f
Move NotFoundResponse to a proper TemplateResponse
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-24 08:58:14 +02:00
c4a6666e6c
[tx-robot] updated from transifex
2020-07-24 02:16:52 +00:00
e04525c186
Ignore whitespace in sharing by mail
...
Signed-off-by: onehappycat <one.happy.cat@gmx.com>
2020-07-23 22:20:18 +02:00
ce314d9484
Merge pull request #21814 from nextcloud/techdebt/noid/federated_share_added-into-typed-event
...
Move federated_share_added into a typed event
2020-07-23 21:42:48 +02:00
173f8abc7e
Merge pull request #21628 from nextcloud/external-to-s3-trashbin-fix
...
fix moving files from external storage to object store trashbin
2020-07-23 21:35:18 +02:00
c8cf2e8a5b
fix renameFromStorage messing with folder mimetype
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 20:31:35 +02:00
1fc54d3479
Fix header logo size in notification mails
...
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-07-23 17:52:21 +02:00
ad7798f9c9
use exceptions for error signaling in writeStream
...
this remove the ambiguity when writing zero length files
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 15:24:52 +02:00
5949849322
fix moving files from external storage to object store trashbin
...
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.
By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 15:24:44 +02:00
e0cc95f3aa
Allow user backends to specify a custom logout url
...
* Allows SSO backends to do a global logout
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 10:42:40 +02:00
0763a17332
Move federated_share_added into a typed event
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 08:33:17 +02:00
99d0ba5f7e
[tx-robot] updated from transifex
2020-07-23 02:17:03 +00:00
346f647962
Merge pull request #21870 from nextcloud/fix/bootstrap-context-container-interfaces
...
Make the bootstrap context return ContainerInterface instances
2020-07-22 20:38:50 +02:00
7b250db60b
Merge pull request #21658 from nextcloud/trashbin-configurable-size
...
allow admin to configure the max trashbin size
2020-07-21 20:46:43 +02:00
7870ca0663
Use the proper IAppContainer and IServerContainer type hints to know which code runs with which container
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-21 20:44:05 +02:00
e029055e76
Make the bootstrap context return ContainerInterface instances
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-21 20:42:24 +02:00
5eb1e75e24
build autoloader
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-21 19:26:59 +02:00
aa051875f9
improve default notification fallback
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-21 17:40:22 +02:00
fb5ae20722
basic settings system for activity notifications
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-21 17:12:38 +02:00
09e6b26bdd
Merge pull request #21875 from nextcloud/techdebt/deprecate-ilogger
...
Deprecate ILogger in favor of the PSR-3 logger
2020-07-20 16:45:14 +02:00
9ae75a3ca9
Merge pull request #21850 from nextcloud/techdebt/noid/register-alternative-logins
...
Allow to register AlternativeLogin on RegistrationContext
2020-07-20 14:20:03 +02:00
9271d65641
Merge pull request #21880 from nextcloud/webauthn/discourage_user_auth
...
Discourage webauthn user interaction
2020-07-20 09:24:08 +02:00
a1a1349977
Merge pull request #21891 from nextcloud/techdebt/undeprecate-iappcontainer-iservercontainer
...
Undeprecate IAppContainer and IServerContainer
2020-07-19 22:16:59 +02:00
d925c45373
[tx-robot] updated from transifex
2020-07-19 02:17:06 +00:00
22ff03969e
Undeprecate IAppContainer and IServerContainer
...
With 4152216bd8
2020-07-17 10:17:18 +02:00
9bc6a8437d
Deprecate the query mothod on the server container
...
The interface method has already been deprecated, but if some code uses
the concrete type instead, the deprecation is not shown (by phpstorm),
so I think it's better to have this method tagged as well.
The "fix" for this deprecation is to simply use `get` instead of
`query`. Right now this will work 100% the same, but the goal is to slim
down the interface and only use what PSR-11 offers.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-17 08:05:07 +02:00
2c79083f27
[tx-robot] updated from transifex
2020-07-17 02:17:12 +00:00
cae849bcf9
Merge pull request #21869 from nextcloud/techdebt/noid/add-constants-for-magic-strings
...
Add constants for the magic strings of template rendering
2020-07-16 22:00:57 +02:00
884f3d009a
Discourage webauthn user interaction
...
Else people might have the feeling this is also doing 2FA. And since it
is only prefered it can be ignored and hacked around.
Once we have proper 2FA with webauthn in one go this probably needs to
be revisted.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-16 21:10:07 +02:00
dfcb49b9b7
Merge pull request #21873 from nextcloud/techdebt/deprecate-server-container-getters
...
Deprecate the server container getters
2020-07-16 20:27:36 +02:00
8a433a7226
Deprecate ILogger
...
The logger service was always intended to follow the PSR-3 interface.
It's time to embrace this and switch over to the "official" API,
hence this custom interface can be slowly phased out.
With Nextcloud 20 the logger also got support for
* App id filled out automatically
* Exceptions handling (as replacement for logException)
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 19:19:23 +02:00
c889021334
Add a scoped PSR logger for apps
...
Just like for ILogger we should have a version that has the app ID
pre-set for the context (unless overwritten) so that each log entry can
be traced back to the app that produced it.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 19:11:56 +02:00
efd2835b23
Deprecate the server container getters
...
Service locators are an anti pattern. These getters just make it more
appealing to do the wrong thing. If you want to locate a service the bad
way, just use the `get` method on a container – it will do the same in
also one line of code.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 18:59:56 +02:00
49970639fa
Add constants for the magic strings of template rendering
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-16 15:47:28 +02:00
0dfcc132ca
Allow to register AlternativeLogin on RegistrationContext
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-16 14:20:24 +02:00
4152216bd8
Use PSR container interface and deprecate our own abstraction
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 13:35:45 +02:00
89fe5415f8
[tx-robot] updated from transifex
2020-07-16 02:19:30 +00:00
c4b53538af
Better event description for BeforeTemplateRenderedEvent in files and files_sharing
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-15 20:15:51 +02:00
fc41810d2f
Merge pull request #21822 from nextcloud/enh/events/additionalscripts
...
Add real events to load additionalscripts
2020-07-15 19:50:01 +02:00
cc258ad51a
Merge pull request #21844 from bladewing/bladewing-harden-against-mimetype-mismatch
...
Avoid substr() error when strpos returns false
2020-07-15 19:33:09 +02:00
7d7ba61625
Add real events to load additionalscripts
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-15 14:07:18 +02:00
b9a911f0b3
Deprecate the internal Symfony dispatcher adapter
...
This type is not known on the public API, yet we should make sure that
any usage of this class is noticed and migrated as soon as possible.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-15 13:57:35 +02:00
3fe3d1fca3
Extra white space to follow other ifs
...
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-07-15 10:18:47 +02:00
7dafd5831f
Avoid substr() error when strpos returns false
...
"Exception: substr() expects parameter 3 to be int, bool given" can occur on Line 378 $mimePart = substr($icon, 0, strpos($icon, '-'));
This happens, when '-' is not found and strpos returns false instead of an int.
When this occurs, e.g., Activity hangs.
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-07-15 10:18:47 +02:00
35bdb998ef
Dashboard strict typing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:28:12 +02:00
31a1494529
Add load method for apps to bootstrap their panels
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:28:11 +02:00
b71de68f43
Cleanup public api methods
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:28:11 +02:00
f7c04b0415
Deprecate panel register event right away but keep it for not breaking backward compatible apps
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:28:11 +02:00
81e5593133
Move to lazy panel registration during registration context
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:27:57 +02:00
86a7d1641a
Update autoloader
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:24:52 +02:00
544fcdb549
Deprecate old dashboard API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:24:51 +02:00
673d70dfc5
Add new dashboard public API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:24:50 +02:00
157c652762
Merge pull request #21825 from nextcloud/fix/appframework/services
...
Fix AppFramework services
2020-07-14 17:07:38 +02:00
fba64a972f
Merge pull request #21812 from nextcloud/feature/noid/app-bootstrap-without-app.php
...
Do not load app.php if Application implements IBootstrap
2020-07-14 17:06:06 +02:00
dca2469462
Merge pull request #21833 from nextcloud/docfix/noid/irequest_getHeader
...
Fix PHPDoc of IRequest::getHeader
2020-07-14 16:43:09 +02:00
6f167f0dd1
Merge pull request #21828 from nextcloud/enhancement/lazy-bootstrap-registration-delegation
...
Delegate bootstrap registration lazily
2020-07-14 16:37:04 +02:00
fa9dfd83c9
Fix AppFramework services
...
* We can't just register an alias as the services need the appId to be
injected. if we just register an alias this blows up since the main
container doesn't have the appId.
* Moved the Authtokens over to show the PoC works
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-14 16:01:14 +02:00
d9cc2f0213
Do not load app.php if Application implements IBootstrap
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-14 15:55:23 +02:00
f03f88b437
Delegate bootstrap registration lazily
...
* Keep the registration context
* Expose the context object for other components
* Ensure registration is only run once
Search providers are migrated for demonstration.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-14 15:33:32 +02:00
3bdfb380fc
Fix PHPDoc of IRequest::getHeader
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-14 14:20:43 +02:00
ab303dddcd
Make the PSR-3 adapter exception-aware
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-14 09:38:51 +02:00
cbbbbee8b1
Merge pull request #21785 from nextcloud/techdebt/noid/remove-classmap-in-files_external
...
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH us…
2020-07-13 16:47:12 +02:00
7569bc15bd
Merge pull request #21789 from nextcloud/ftp-filter-hash
...
filter files containing a hash in the path for ftp storages
2020-07-13 10:56:16 +02:00
e357d46863
filter files containing a hash in the path for ftp storages
...
the php ftp streamwrapper doesn't handle hashes correctly and will break when it tries to enter a path containing a hash.
By filtering out paths containing a hash we can at least stop the external storage from breaking completely
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-10 14:18:40 +02:00
7868d4e3b2
[tx-robot] updated from transifex
2020-07-10 02:16:48 +00:00
065ef14cb0
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH usage in files_external
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-10 00:02:59 +02:00
10d862e243
Merge pull request #21759 from nextcloud/enh/lazy_subscription
...
Make the subscription registry lazy
2020-07-09 15:43:48 +02:00
725872c23a
Make the subscription registry lazy
...
This will allow to do lazy registration here which should allow for
loading less (or at least only when needed!).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-09 12:21:06 +02:00
70906a359f
ensure home storage is initialized on first setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 11:14:45 +02:00
43efac345e
Use the correct mountpoint to calculate
...
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-09 11:14:44 +02:00
9e88456768
Fix regression in return value of OC_Util::checkDataDirectoryPermissions due to #21761
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-09 09:29:44 +02:00
f3768e2a2a
Merge pull request #21761 from nextcloud/fix/permission_check_translation
...
Kill another unneeded translation
2020-07-09 08:28:57 +02:00
5864501d3f
[tx-robot] updated from transifex
2020-07-09 02:17:35 +00:00
c7d9636e82
Kill another unneeded translation
...
We should only translate things when we actually need them.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 21:47:16 +02:00
ce5cb5ac33
Merge pull request #21758 from nextcloud/fix/routes/defaults
...
Fix supporting defaults for routes
2020-07-08 20:42:28 +02:00
3f447b9c8c
Fix supporting defaults for routes
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 19:52:45 +02:00
76eb793f9b
Only translate if we need the string
...
This translation was done in each call. Over and over and over again.
All while it was probably not used in 99.99999% of the cases. A small
gain. But still.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 15:12:01 +02:00
7a92113fec
Merge pull request #21643 from nextcloud/enh/no_routeactionhadler_inits
...
Do not create a RouteActionHandler object for each route
2020-07-08 09:28:05 +02:00
abe222c979
Merge pull request #21739 from nextcloud/techdebt/14552/migrate-OC-initSession
...
Remove hook for initSession
2020-07-08 09:02:37 +02:00
8ca1208bbb
[tx-robot] updated from transifex
2020-07-08 02:16:58 +00:00
8d2d051841
Remove hook for initSession
...
It's not used anyways and allowed to manipulate the state of the session. Also removed the code handling this.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-07 21:44:36 +02:00
050e2fe346
allow admin to configure the max trashbin size
...
this allows an admin to configure the max trashbin size instead of always relying on the users quota.
The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-07 14:45:08 +02:00
edc1c77dd9
Do not create a RouteActionHandler object for each route
...
This is not required and doesn't allow us to be properly lazy. On top of
it this doesnt allow us to cache the routes (since closures/objects
can't be cached).
This is the first small step into cleaning up the routing we have
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-07 12:33:22 +02:00
cd7a6276f2
Merge pull request #21676 from J0WI/fix-chmod-on-fd
...
Fix chmod on file descriptor
2020-07-07 09:44:57 +02:00
560c485e5d
Merge pull request #21714 from nextcloud/td/remove/getAppFolder
...
Remove old deprecated getAppFolder
2020-07-06 22:36:55 +02:00
7d128ebf3e
Remove old deprecated getAppFolder
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-06 22:06:58 +02:00
e70249e089
Update SecurityMiddleware.php
...
OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header.
in other areas OC::$WEBROOT is always used together with an /
2020-07-06 21:34:46 +02:00
4e8552929b
Merge pull request #20729 from nextcloud/cleanup/noid/shared-tags-code
...
Tags.php and the old sharing mechanism
2020-07-06 21:30:48 +02:00
37b2121ccf
Deprecate registerRoutes
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-06 15:15:20 +02:00
37856cd377
Cascading effect - more code that now is not used anymore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-06 14:13:53 +02:00
e20db42a0c
Tags.php and the old sharing mechanism
...
The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-06 14:12:12 +02:00
e878c0a054
Merge pull request #21074 from jvsalo/shared-lock-multi-release
...
Fix releasing a shared lock multiple times
2020-07-06 14:06:41 +02:00
fb69d6d195
Merge pull request #21238 from nextcloud/techdebt/noid/deferrable-notification-apps
...
Allow notification apps to defer and flush the sending
2020-07-06 13:50:25 +02:00
6c825ee9a0
Merge pull request #21665 from nextcloud/debt/noid/job-list
...
Fix wrong phpdoc for execute method
2020-07-06 11:14:14 +02:00
b1cdd0dd9b
Use formal type hints instead of informal PHPDoc
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-06 10:13:23 +02:00
e900f424ce
Merge pull request #21636 from nextcloud/lock-exception-readable-path
...
add proper paths to locking exceptions
2020-07-05 22:37:12 +02:00
d3d11cb826
Merge pull request #21626 from nextcloud/enhancement/injectible-callables
...
Callable parameter injection
2020-07-05 22:03:12 +02:00
4d8b4ef3cc
Merge pull request #21533 from nextcloud/techdebt/noid/dedicated-method-to-get-a-users-language
...
Techdebt/noid/dedicated method to get a users language
2020-07-04 08:56:13 +02:00
c52e6c8a47
[tx-robot] updated from transifex
2020-07-04 02:16:15 +00:00
356bc50420
Only clear the realpath cache
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-07-03 22:47:13 +02:00
ea08a01999
clearstatcache() on rmdir
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-07-03 22:42:27 +02:00
6ca1599ea4
Fix chmod on file descriptor
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-07-03 20:53:58 +02:00
3d559159f0
Allow notification apps to defer and flush the sending
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-03 16:44:43 +02:00
4a3ea04baa
Callable parameter injection
...
This is like what we have to DI and classes, but for callables.
The motivating factor is to get rid of *service locators* in the `boot`
method of apps as a new pattern is about to emerge where we have lots of
`query` calls on the app or server container in order to fetch some
services.
With this little helper it's possible to call another (public) method
and magically have everything injected.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-03 14:37:46 +02:00
db8267db26
Use the new method everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-03 10:59:43 +02:00
9b10d35477
Fix wrong phpdoc for execute method
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-03 10:47:15 +02:00
318d553dbd
Merge pull request #21662 from nextcloud/fix/s3-bucket-compat-static-call
...
Fix static method call for s3 bucket compat check
2020-07-03 10:22:53 +02:00
19e1efd1dd
Merge pull request #21439 from nextcloud/feature/noid/move-autocomplete-filter-event-to-new-dispatcher-and-class
...
Move AutoComplete::filterResults to new event dispatcher and GenericE…
2020-07-03 10:03:34 +02:00
d3a4bc91f7
Fix static method call for s3 bucket compat check
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-03 09:02:58 +02:00
0825530a1b
[tx-robot] updated from transifex
2020-07-03 02:17:12 +00:00
d53e005458
Merge pull request #21360 from nextcloud/root-storage-prevent-scanning
...
prevent the root storage from accidentally scanning user folders
2020-07-02 21:07:16 +02:00
c79f8b9543
Merge pull request #21580 from therealklanni/master
...
Add audio formats to htaccess
2020-07-02 20:59:54 +02:00
0157e30ad4
Merge pull request #21599 from nextcloud/debt/noid/type-to-types
...
Replace TYPE with TYPES
2020-07-02 12:21:01 +02:00
74a9cadc50
Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-02 11:13:13 +02:00
b997edad10
Add a dedicated method to get the language for another user
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-01 10:20:07 +02:00
35c6b1236f
Move AutoComplete::filterResults to new event dispatcher and GenericEvent
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-01 09:57:33 +02:00
40165340f5
[tx-robot] updated from transifex
2020-07-01 02:16:15 +00:00
87dd760a89
Replace TYPE with TYPES
...
As TYPE::* is deprecated.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-30 23:46:22 +02:00
873be16c8d
Merge pull request #21588 from nextcloud/bug/21214/method-signature
...
Update presign method to match with interface again.
2020-06-30 20:36:30 +02:00
c709dda597
Merge pull request #21589 from nextcloud/debt/noid/wrong-exception-call
...
Set retry = false for forbidden exception.
2020-06-30 20:35:47 +02:00
bc29e361b2
Merge pull request #21596 from nextcloud/debt/noid/share-return-mismatch
...
Replace Share with IShare and add missing return
2020-06-30 19:40:26 +02:00
da2d425044
add proper paths to locking exceptions
...
while some code paths do wrap the "raw" locking exception into one with a proper path, not all of them do
by adding the proper path to the original exception we ensure that we always have the usefull information in out logs
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-30 18:10:42 +02:00
8e9726be5c
Log usages of the deprecated app.php file
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-30 09:43:40 +02:00
c0c841bc93
[tx-robot] updated from transifex
2020-06-30 02:16:10 +00:00
4d44d6be2e
Replace Share with IShare and add missing return.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-26 10:57:55 +02:00
e984357cfc
Set retry = false for forbidden exception.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-25 23:34:41 +02:00
8aa99aa8ff
Update presign method to match with interface again.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-25 22:56:28 +02:00
b7060be18d
Fix robots "noindex, nofollow" signals
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-25 08:29:43 +02:00
c2f2eaf8cc
Add audio formats to htaccess
...
Signed-off-by: Kevin Lanni <therealklanni@gmail.com>
2020-06-24 20:33:51 -07:00
b6ce75066d
Merge pull request #21558 from nextcloud/part-file-rename-mask
...
relax permissions mask check for detecting part file rename
2020-06-24 21:05:07 +02:00
a2f34f46b2
Fix tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 18:13:37 +02:00
89ed2c37bf
Update share type constant usage
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 16:49:16 +02:00
654cd18864
Merge pull request #20916 from nextcloud/feature/unified-search-api
...
Add unified search API
2020-06-24 15:38:03 +02:00
27b8637e3e
Deprecate \OCP\ISearch
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-24 14:20:26 +02:00
f8e08a74ba
Implement unified search for Files
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-24 14:20:26 +02:00
4488e846a5
Add unified search API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-24 14:20:25 +02:00
7972a5fda6
Merge pull request #21525 from nextcloud/techdebt/noid/contacts-manager
...
Techdebt fix contacts manager
2020-06-24 13:55:31 +02:00
35d75dbb38
relax permissions mask check for detecting part file rename
...
with files drop uploads the original file name isn't always used for the '.ocTransferId' source path
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-24 13:06:14 +02:00
95652d4469
Fix language in share notes email for users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 22:01:40 +02:00
ad0731a63c
Make annotations case insensitive
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 20:18:23 +02:00
8ec1b8132e
Merge pull request #21452 from nextcloud/bugfix/21451/allow-autocomplete-by-displayname-again
...
Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
2020-06-23 14:02:17 +02:00
859941db32
Merge pull request #21479 from nextcloud/fix/21474/allow_specifying_cookie_type
...
Allow to specify the cookie type for appframework responses
2020-06-22 13:00:12 +02:00
a899b4775d
Merge pull request #21475 from nextcloud/enh/noid/flow-event-dispatcher
...
flow to not use deprecated event dispatcher methods
2020-06-22 11:18:50 +02:00
404080abb4
More imports
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-22 11:10:44 +02:00
3997856d76
Fix code style
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-22 11:09:32 +02:00
7ed79b64b4
Fix undefined class "IAddressbook" on docs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-22 11:08:23 +02:00
fbf9772a3e
Allow to specify the cookie type for appframework responses
...
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.
Helps with #21474
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-22 08:38:44 +02:00
ce9d3b36df
[tx-robot] updated from transifex
2020-06-20 02:16:35 +00:00
3706eae777
flow to not use deprecated event dispatcher methods
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-19 23:03:07 +02:00
6ec8042d88
Merge pull request #21469 from nextcloud/bugfix/noid/event-service-listener-registration
...
Fix event service listener registration
2020-06-19 21:28:29 +02:00
59093abfaf
Merge pull request #21483 from nextcloud/fix/scss/timeout
...
Give up after 10 seconds in SCSS timeout
2020-06-19 21:26:26 +02:00
4768526b81
Give up after 10 seconds in SCSS timeout
...
Else we keep idling for ages which leads to bad UX
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-19 14:39:31 +02:00
a7f26cfe28
Don't log Keys
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-19 13:44:27 +02:00
2b7b7144d4
Allow crash reporters registration during app bootstrap
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-19 10:38:26 +02:00
9cf32a3999
Fix event service listener registration
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-18 15:00:19 +02:00
1151394739
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-18 11:33:43 +02:00
32bf95c774
Continue with next app when one errors during register
...
My patch at #21461 had a little error in that it exits the method when a
query exception is encountered during the register step of an app. What
we actually want is to continue with the next app and finish the overall
registration procedure.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-18 09:17:00 +02:00
a915b45190
Merge pull request #21461 from nextcloud/fix/catch-app-register-boot-exceptions
...
Catch all exceptions when an app is registering or booting
2020-06-18 08:59:45 +02:00
e324c90a8d
[tx-robot] updated from transifex
2020-06-18 02:16:35 +00:00
5ab5a5f89e
Catch all exceptions when an app is registering or booting
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 21:07:42 +02:00
5bc8510b3b
Load the app.php before running apps' boot method
...
Some apps require the composer autoloader from app.php. If we run boot
before including that file, classes and functions from dependencies
won't be found.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 14:44:02 +02:00
9ff7a9c38e
Fix PHP CS
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:08:17 +02:00
2ec7b59688
Move back to IGroupManager::displayNamesInGroup()
...
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 11:59:56 +02:00
3539bd1751
Merge pull request #21434 from nextcloud/bugfix/noid/dont-break-with-GenericEventWrapper
...
Don't break event listeners with the GenericEventWrapper
2020-06-17 11:55:14 +02:00
6328053105
Merge pull request #21406 from nextcloud/fix/aws-disable-csm
...
Disable Client-Side Monitoring on AWS storage
2020-06-17 10:58:27 +02:00
c5d2958ac7
Migrate Settings to new bootstrap mechanism
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 09:22:22 +02:00
69571fb536
Add dedicated API for apps' bootstrapping process
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 09:22:21 +02:00
c76fa60571
Don't break event listeners with the GenericEventWrapper
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-16 19:30:36 +02:00
68794ebc92
Emit an event for every disabled 2FA provider during cleanup
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-16 14:38:33 +02:00
5e52c110bb
Merge pull request #21416 from nextcloud/fix/user-deleted-token-cleanup
...
Clean up auth tokens when user is deleted
2020-06-16 10:01:29 +02:00
3474afa938
Clean up auth tokens when user is deleted
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-15 19:24:04 +02:00
294e40db5f
Avoid duplicate matches in wide and exact results
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-15 09:34:57 +02:00
9d392891be
Disable Client-Side Monitoring on AWS storage
...
The S3 client enables this by default and then tries to read
`.aws/config`. This causes `open_basedir` restriction related error for
some setups. So this patch disables the CSM because it's most likely
unused anyway.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-15 09:13:08 +02:00
b6d5979d0a
Increase timeout of the appstore requests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-12 13:01:06 +02:00
c3267a58c9
Merge pull request #21358 from nextcloud/enhancement/search-group-by-displayname
...
Allow group search by display name
2020-06-11 16:10:34 +02:00
e9b5514186
prevent the root storage from accidentally scanning user folders
...
while this scan *should* never be triggered, it's good to have some failsafe to ensure
that the users home contents don't end up getting scanned in the root storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-11 15:41:33 +02:00
e1e7de43c1
[tx-robot] updated from transifex
2020-06-11 02:15:48 +00:00
a636aef585
Allow group search by display name
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-10 11:44:07 +02:00
9806dec9b3
[tx-robot] updated from transifex
2020-06-10 02:16:03 +00:00
8bee8e1317
Merge pull request #21317 from FlorentCoppint/s3_upload_part_size
...
Upload part size as S3 parameter instead of constant value
2020-06-09 19:28:58 +02:00
862e3250ff
Merge pull request #21319 from nextcloud/log-level-storage-test
...
increase log level for storage self-test
2020-06-09 13:11:36 +02:00
19712e2773
Merge pull request #21311 from nextcloud/techdebt/noid/make-share-order-reliable
...
Always sort shares in a reliable way
2020-06-09 10:33:41 +02:00
3f07485a04
Merge pull request #21322 from nextcloud/techdebt/deprecate-iservercontainer-geteventdispatcher
...
Deprecate \OCP\IServerContainer::getEventDispatcher
2020-06-09 10:32:41 +02:00
3594ba6971
Upload part size as S3 parameter instead of constant value
...
Some S3 providers need a custom upload part size (500 MB static value in Nextcloud).
Here is a commit to change this value via S3 configuration, instead of using S3_UPLOAD_PART_SIZE constant.
A new parameter is added for an S3 connection : uploadPartSize
Signed-off-by: Florent <florent@coppint.com>
2020-06-09 09:18:42 +02:00
99e14b5ada
[tx-robot] updated from transifex
2020-06-09 02:15:56 +00:00
fec3fefad7
Deprecate \OCP\IServerContainer::getEventDispatcher
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-08 19:10:26 +02:00
e75797ad67
increase log level for storage self-test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-08 18:12:49 +02:00
56b04c65f7
Always sort shares in a reliable way
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-08 14:47:15 +02:00
5e1805d253
Fix missing parent constructor call and get_class usage in GenericEventWrapper
...
* The parent constructor was not called
* `get_class` does not allow null values in php7.2+
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-08 09:42:45 +02:00
4cf4ed3697
[tx-robot] updated from transifex
2020-06-06 02:16:00 +00:00
a5232d9805
[tx-robot] updated from transifex
2020-06-05 02:16:34 +00:00
72a8e15d3a
Merge pull request #20914 from nextcloud/enh/deprecated_event_log_usage
...
Log usage of a deprecated event instead of emitting
2020-06-04 19:19:02 +02:00
59c1ff690a
Merge pull request #21199 from nextcloud/bugfix/noid/prevent-harder-sharing-your-root
...
Prevent harder to share your root
2020-06-04 10:59:22 +02:00
69eda9c0f6
Prevent harder to share your root
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-03 14:47:38 +02:00
f62f23ed1d
[tx-robot] updated from transifex
2020-06-03 02:16:18 +00:00
0f4de3d353
[tx-robot] updated from transifex
2020-06-01 02:16:00 +00:00
43a0bf7215
Merge pull request #21155 from nextcloud/td/move_to_capabilities_package
...
Move to @nextcloud/capabilities package
2020-05-30 08:58:19 +02:00
64c15a15d4
[tx-robot] updated from transifex
2020-05-30 02:16:04 +00:00
0209532638
Move to @nextcloud/capabilities package
...
And kill of oc_capabilities and _oc_capabilities globals
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-29 16:10:08 +02:00
71b2f94101
Fix the loading order of the js files_info and files_client
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-29 15:43:45 +02:00
251a4d3097
Merge pull request #21143 from nextcloud/fix-password-changes-in-link-and-mail-shares
...
Fix password changes in link and mail shares
2020-05-29 13:36:09 +02:00
45de42a6b8
Fix disabling send password by Talk without new password in mail shares
...
When "send password by Talk" was disabled in a mail share it was
possible to keep the same password as before, as it does not pose any
security issue (unlike keeping it when "send password by Talk" is
enabled, as in that case the password was already disclosed by mail).
However, if a mail share is updated but the password is not set again
only the hashed password will be available. In that case it would not
make sense to send the password by mail, so now the password must be
changed when disabling "send password by Talk".
Note that, even if explicitly setting the same password again along with
the "send password by Talk" property would work, this was also prevented
for simplicity.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
a426f84dbe
Fix enabling send password by Talk with same password in mail shares
...
When "send password by Talk" is enabled in a mail share a new password
must be also set. However, when the passwords of the original and the
new share were compared it was not taken into account that the original
password is now hashed, while the new one is not (unless no new password
was sent, in which case the password of the original share was set in
the new share by the controller, but that was already prevented due to
both passwords being literally the same), so it was possible to set the
same password again.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-28 21:51:28 +02:00
7569590514
Fix enabling send password by Talk with empty password in link shares
...
When "send password by Talk" is enabled in a link share now a non empty
password is enforced.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-28 21:51:28 +02:00
97e9823787
Document \OC_App::getAllApps return type
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-28 20:37:24 +02:00
6aa6ab3e02
Add lazy events for the Node API
...
Right now if you want to get events via the Node API you have to have a
real instance of the Root. Which in turns sets up the whole FS.
We should make sure this is done lazy. Else enabling the preview
generator for example makes you setup the whole FS on each and every
authenticated call.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-28 12:35:45 +02:00
5b92f35fe2
Log why a token is not valid during password check
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-27 09:58:44 +02:00
2006a6dd0e
Improve traces of invalid token exceptions
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-27 09:21:47 +02:00
b9d17cfdec
[tx-robot] updated from transifex
2020-05-27 02:16:10 +00:00
4bada5c732
Merge pull request #21092 from nextcloud/enh/noid/recommended-apps
...
Update recommended apps
2020-05-25 20:47:20 +02:00
a6b0bed585
Merge pull request #21090 from nextcloud/bug/noid/do-not-read-cert-from-datadir-by-default
...
Do not read certificate bundle from data dir by default
2020-05-25 19:48:00 +02:00
18b0d753f2
Do not read certificate bundle from data dir by default
...
Before the resources/config/ca-bundle.crt was only used when the list of custom
certificates was empty and the instance was not installed. But it should also
be used when the list is empty and the instance is installed.
This is inverting the logic to stop if the instance is not installed to use the
default bundle. And it also does this when the list is empty.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-25 16:57:56 +02:00
bde5b9577b
Update hub bundle and add proxy rule to htaccess
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-25 16:04:54 +02:00
e57bca31ad
Merge pull request #20005 from joeried/occ-remove-bruteforce-attempts-by-ip
...
Implement occ command to reset bruteforce attemps from a given IP address
2020-05-25 14:04:18 +02:00
bd997a105c
Fix code style
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-25 14:03:21 +02:00
cbde1d102c
[tx-robot] updated from transifex
2020-05-25 02:16:22 +00:00
b7dd278e24
Fix releasing a shared lock multiple times
...
Signed-off-by: Jaakko Salo <jaakkos@gmail.com>
2020-05-24 20:23:57 +03:00
5e35594cb6
Merge pull request #20989 from nextcloud/td/js/move_core_files_webpack
...
Move core/js/files to webpack
2020-05-23 09:47:53 +02:00
533cb6992b
Merge pull request #21065 from nextcloud/fix/cleanstatscache_before_fetching_metadata
...
Clear the statscache before fetching the metadata
2020-05-23 09:46:27 +02:00
23080fcd9c
[tx-robot] updated from transifex
2020-05-23 02:16:22 +00:00
44d05bf356
Move core/js/files to webpack
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-22 20:28:31 +02:00
4dacbbd66d
Log usage of a deprecated event instead of emitting
...
This way we can track down what is being used and migrate them over. And
slowly kill the old way in a release or 2.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-22 14:56:35 +02:00
fd805a0388
Merge pull request #20776 from nextcloud/enh/limit_group_queries
...
Improve group queries
2020-05-22 14:19:28 +02:00
6b26744787
Clear the statscache before fetching the metadata
...
Else if a lot of writes happen. It might happen that an old stat result
is used. Resulting in a wrong file size for the file. For example the
text app when a lot of people edit at the same time.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-22 09:21:53 +02:00
3b519f776a
[tx-robot] updated from transifex
2020-05-22 02:17:20 +00:00
cac844d915
Merge pull request #20814 from nextcloud/group-id-only
...
dont get the group details if we only ask for the id
2020-05-21 09:53:45 +02:00
1c1b349473
Merge pull request #21018 from nextcloud/bug/20498/add-defaults-on-empty
...
Create account structure also for empty record
2020-05-21 09:47:19 +02:00
d870e9ece5
[tx-robot] updated from transifex
2020-05-21 02:17:26 +00:00
8123737a40
Revert "Compress the appstore requests by default"
...
This reverts commit 6ffde128ad
2020-05-20 13:37:28 +02:00
8bcd1c31da
Allow gzip encoded requests by default
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-20 13:37:28 +02:00
526905cfc2
Merge pull request #21050 from nextcloud/bug/noid/caching-and-gzipping-of-appstore-requests
...
Caching and compression for app store requests
2020-05-20 11:05:34 +02:00
6ffde128ad
Compress the appstore requests by default
...
In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-20 09:51:07 +02:00
3e0d8df036
Cache appstore requests for 60 instead of 5 minutes
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-20 09:51:06 +02:00
74e577876c
[tx-robot] updated from transifex
2020-05-20 02:16:28 +00:00
d26169838e
Merge pull request #21041 from nextcloud/enh/dataresponse_etag_lastmod
...
Copy over the ETag and LastModified when formatting a Dataresponse
2020-05-19 14:48:27 +02:00
0556fe351a
Add a message to the log entry of an app being disabled
...
As an admin, it's always a surprise to see that an app got disabled. On
a busy server with many log entries, it's hard to locate the entry that
explains why Nextcloud disabled an app. Adding a message will make it
more obvious, allowing admins and developers to grep for the string.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-19 11:44:51 +02:00
c92c378a9c
Copy over the ETag and LastModified when formatting a Dataresponse
...
This way the ETag checks etc are all working.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-19 09:39:51 +02:00
1b55119c85
[tx-robot] updated from transifex
2020-05-19 02:17:09 +00:00
3e65cc1bba
Merge pull request #21033 from nextcloud/enh/capabilities_initialstate
...
Provide capabilities via initialstate
2020-05-18 19:44:28 +02:00
e822c33a90
Provide capabilities via initialstate
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-18 16:20:25 +02:00
1bba7de28f
Merge pull request #21017 from nextcloud/enh/noid/clean-excluded-groups-list
...
Remove group from excluded_groups_list after delete
2020-05-18 14:24:18 +02:00
a8ac6df1d0
[tx-robot] updated from transifex
2020-05-18 02:16:22 +00:00
c6f770ea59
Create account structure also for empty record
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-05-17 15:30:36 +02:00
16da29caba
Remove group from excluded_groups_list after delete
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-05-17 15:15:06 +02:00
bf2e3c4619
[tx-robot] updated from transifex
2020-05-17 02:16:59 +00:00
a84eec88e8
[tx-robot] updated from transifex
2020-05-16 02:17:14 +00:00
d23c7fff2a
Merge pull request #20957 from nextcloud/Valdnet-patch-5
...
l10n: Adding "The" before "Following"
2020-05-15 19:44:04 +02:00
4e49e1da16
Allow TemplateResponse to be compressed
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-15 08:38:39 +02:00
8e3de41b4b
l10n: Add "The" before "Following"
2020-05-15 14:26:50 +08:00
d132f81d28
[tx-robot] updated from transifex
2020-05-15 02:17:17 +00:00
75d50a55b8
[tx-robot] updated from transifex
2020-05-14 02:16:36 +00:00
23253daa2f
Merge pull request #20958 from nextcloud/bugfix/talk-3523/allow-links-to-conversations
...
Allow links to conversations
2020-05-13 22:12:34 +02:00
787c2a17e3
Allow links to conversations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-13 16:05:55 +02:00
e0d2cd40e7
Fix return code of AppConfig::deleteUserValue
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-13 14:55:00 +02:00
7c15c63b05
Merge pull request #20939 from nextcloud/enh/middleware/not_modified
...
Move not modified check to the middleware
2020-05-13 09:04:56 +02:00
4fbea316a7
Merge pull request #20897 from nextcloud/bugfix/httpcache
...
Proxy server could cache http response when it is not private
2020-05-13 08:27:05 +02:00
12fa748c49
Move the notmodified check to middleware where it belongs
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-13 08:11:24 +02:00
ab2df70e3a
[tx-robot] updated from transifex
2020-05-13 02:16:26 +00:00
dee1d8737b
Merge pull request #20813 from nextcloud/lazy-folder
...
generalize the "lazy folder" concept
2020-05-12 14:25:22 +02:00
12fe83cd43
Merge pull request #20858 from nextcloud/fix/20289/remember_webauth_names
...
Remember the webauthn name of devices
2020-05-12 14:06:20 +02:00
6374c329e3
Merge pull request #20270 from nextcloud/enh/appframework/gzip
...
Add AppFramework compression middleware to gzip responses
2020-05-12 12:20:39 +02:00
203d7eb1d3
Add AppFramework GZip middleware to gzip responses
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-12 09:09:48 +02:00
901110f068
[tx-robot] updated from transifex
2020-05-12 02:16:11 +00:00
f7153a3d0c
generalize the "lazy folder" concept
...
makes it easy to use lazy intialized folder in other places
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-11 15:36:13 +02:00
35ff4aa1c6
Use random_bytes
...
Since we don't care if it is human readbale.
The code is backwards compatible with the old format.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-11 12:46:59 +02:00
90e6b31059
[tx-robot] updated from transifex
2020-05-11 02:16:11 +00:00
e9be3a9090
Add public argument to Http cacheFor()
...
Signed-off-by: Clement Wong <git@clement.hk>
2020-05-10 20:24:14 +02:00
401210d259
Proxy server could cache http response when it is not private
...
Signed-off-by: Clement Wong <git@clement.hk>
2020-05-10 11:24:08 +02:00
Daniel Kesselberg
Georg Ehrke
Roeland Jago Douma
Gary Kim
Scott Dutton
Morris Jobke
Julius Härtl
Nextcloud bot
Robin Appelman
John Molakvoæ (skjnldsv)
John Molakvoæ
Jan C. Borchardt
Joas Schilling
Joas Schilling
Arthur Schiwon
Elijah Martin-Merrill
onehappycat
Simon Spannagel
Christoph Wurst
Roeland Jago Douma
lui87kw
bladewing
Holger Hees
J0WI
Christoph Wurst
Kevin Lanni
Florent
Daniel Calviño Sánchez
Jaakko Salo
Valdnet
Clement Wong