a71bb8a485
Make whole Template class final
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:21 +01:00
6c1b357973
Move TemplateProvider registration to boot context and make template type registration lazy
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:21 +01:00
0111381529
Only create template directory if it is present in the default skeleton
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
4f90766ba3
Skip template picker if none available
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:20 +01:00
7e6d69d166
Add templatedirectory config value to let admins have their custom templates by default
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
66fa3fca83
Add ratio to template creators
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
78e114ed72
Add template picker
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:18 +01:00
4974404774
files: Create files from template API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 11:59:46 +01:00
3a9c7f99f6
Merge pull request #25335 from nextcloud/fix/app-fetcher-php-compat-comparison
...
Fix/app fetcher php compat comparison
2021-01-27 15:14:52 +01:00
e0f0e6e41a
Merge pull request #25268 from nextcloud/enh/previews/sgi-tga
...
Add SGI and TGA preview support
2021-01-27 14:54:27 +01:00
baba83e185
[tx-robot] updated from transifex
2021-01-27 02:20:46 +00:00
b4f71ccf4d
Fix app fetcher php comparison to allow wider ranges
...
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-26 16:35:43 +01:00
6ecf33bfe7
only use share cacheentry when available
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 16:22:00 +01:00
e511a539b7
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:55:38 +01:00
5ae0be08b4
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:54 +01:00
27f9df2e87
fix cachjail searching for root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:50 +01:00
a44aab11f7
do cachejail search filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:46 +01:00
652bf9d363
Revert "Fix comparison of PHP versions"
...
This reverts commit bedd9acf78
2021-01-26 13:48:06 +01:00
b98860eeb3
[tx-robot] updated from transifex
2021-01-25 02:20:31 +00:00
4923c6be25
Use RFC-compliant URL encoding for cookies
...
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.
Fixes #24438
Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-24 14:18:28 +01:00
1d2707ad78
Merge pull request #25273 from nextcloud/enhancement/hide-two-factor-settings-if-no-providers
...
Do not show 2FA settings if the user has no providers available
2021-01-22 16:26:17 +01:00
47b10c3775
Merge pull request #25275 from nextcloud/fix/two-factor-token-type
...
Convert 2FA token type to string
2021-01-22 16:14:45 +01:00
ac591e2fc2
Fully deprecate the old initial state interface, not just the methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:53:26 +01:00
939433363e
Merge pull request #25128 from nextcloud/ldapprovider-get-property
...
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
2021-01-22 14:31:19 +01:00
f15148f695
adjust since
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Co-authored-by: Morris Jobke <hey@morrisjobke.de>
2021-01-22 14:29:39 +01:00
99d525eb36
Convert 2FA token type to string
...
The IConfig service is documented to handle its data as strings, hence
this changes the code a bit to ensure we store keys as string and
convert them back when reading.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:09:37 +01:00
378f116a63
Do not show 2FA settings if the user has no providers available
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 13:55:22 +01:00
0bc9e3ca15
Change license mail alias
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-22 13:06:35 +01:00
d47b84be67
Add SGI and TGA preview support
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-22 10:42:51 +01:00
7989247574
[tx-robot] updated from transifex
2021-01-22 02:19:54 +00:00
10214fbee0
Merge pull request #25214 from nextcloud/dependabot/composer/phpseclib/phpseclib-2.0.30
...
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30
2021-01-21 10:25:02 +01:00
d4d33e3095
Merge pull request #25238 from nextcloud/enh/noid/apps-defacto-in-root
...
Apps folder is defacto in root folder and not above
2021-01-21 09:08:54 +01:00
15b0e4d922
Merge pull request #25240 from nextcloud/enh/noid/re-use-fetched-dependencies
...
Re-use fetched dependencies in lib/base.php
2021-01-21 08:54:05 +01:00
349b65eff3
Merge pull request #25236 from nextcloud/mkdir-explicit-chmod
...
explicitly set permissions on newly created folders
2021-01-21 07:56:10 +01:00
054783e385
[tx-robot] updated from transifex
2021-01-21 02:20:36 +00:00
d84e1f1951
Re-use fetched dependencies in lib/base.php
...
Reduces calls to DI container by reusing already fetched dependencies.
For status.php it went from 355 to 344.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:55:16 +01:00
5b0e69828f
Apps folder is defacto in root folder and not above
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:22:39 +01:00
d182043e83
explicitly set permissions on newly created folders
...
this works around any `umask` that might be set and limiting the folder permissions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-20 17:15:57 +01:00
4c81f5c4ad
Merge pull request #25212 from nextcloud/enh/preview-markdown
...
Enhance markdown file preview rendering
2021-01-20 15:02:41 +01:00
01f013661a
Fix typo in comment
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 15:02:32 +01:00
6129a85187
Merge pull request #25224 from nextcloud/bugfix/24600/fix-saving-user-credentials
...
Update handling of user credentials
2021-01-20 14:59:30 +01:00
aed1fde6fd
Enhance markdown file preview rendering
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-20 11:07:55 +01:00
fcbbcacab4
Also load CA properly in integrity check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 10:57:41 +01:00
d751fedffb
phpsec lib can't parse multiple certs in one go
...
So we have to split it manually and do it ourselves
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 10:57:41 +01:00
3d61adc908
Drop authtoken_version_index
...
The index was used when deleting old tokens. On top of that the index is
of course not that great since the version is either 1 or 2.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 09:34:41 +01:00
6c1e294edd
Compare and store the login name via the event
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 08:50:17 +01:00
6d4afca7ac
Add support for webp
...
Including handling in OC_Image
But also a preview provider
Of course only works if your php actually supports webp
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-19 20:17:10 +01:00
fdc8635afb
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-19 16:33:58 +01:00
0893bba369
Merge pull request #25153 from nextcloud/bugfix/noid/force-signature-verification-on-occ
...
Force signature verification of apps on occ
2021-01-19 09:35:52 +01:00
91864aeb40
[tx-robot] updated from transifex
2021-01-19 02:20:43 +00:00
847aa08ebd
Don't log keys on checkSignature
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 16:09:06 +01:00
76c7356af9
Only use alphanumeric chars for mysql password
...
/ and + can cause problems with other tools that you might want to run on your Nextcloud database.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 12:03:52 +01:00
90c3013d40
Cleanup the constructor
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +01:00
f319660f60
Force run the verification of the signature on occ
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +01:00
6d291c3c19
[tx-robot] updated from transifex
2021-01-18 02:19:28 +00:00
1907cc197d
[tx-robot] updated from transifex
2021-01-17 02:19:53 +00:00
40fde94b4d
fix even more brackets
...
Signed-off-by: Jasper Knockaert jasper@knockaert.nl
2021-01-16 14:49:53 +01:00
252d1ae512
fix brakcets
2021-01-16 14:38:19 +01:00
f9a0380eb1
consolidation of boolean expression
2021-01-16 14:33:44 +01:00
eafd281800
Merge pull request #25138 from gouttegd/fix25137
...
Fix comparison of PHP versions
2021-01-15 15:18:25 +01:00
bcb52d64f0
Merge pull request #25141 from nextcloud/bugfix/noid/add-a-hint-about-priority
...
Add a hint about the direction of priority
2021-01-15 09:46:37 +01:00
b8acf2fe69
Add a hint about the direction of priority
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-15 08:34:24 +01:00
bedd9acf78
Fix comparison of PHP versions
...
Use the builtin function `version_compare` to check an app's
compatibility with the available PHP version, instead of reusing
the `OC\App\CompareVersion::isCompatible` method which is intended
to compare Nextcloud versions. PHP version strings do not always
necessarily follow the simple Major.Minor.Patch format used by
Nextcloud and therefore cannot be properly compared by that method.
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
2021-01-14 23:03:20 +00:00
b9287f9780
Merge pull request #25091 from nextcloud/enhancement/ocp-db-exception-abstraction
...
Add our own DB exception abstraction
2021-01-14 12:27:23 +01:00
f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2
...
respect DB restrictions on number of arguments in statements and queries
2021-01-14 11:36:42 +01:00
6cf9c88596
[tx-robot] updated from transifex
2021-01-13 02:20:19 +00:00
2c9cdc1cdb
Add our own DB exception abstraction
...
Right now our API exports the Doctrine/dbal exception. As we've seen
with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as
a dependency update means lots of work in apps, due to the direct
dependency of what Nextcloud ships. This breaks this dependency so that
apps only need to depend on our public API. That API can then be vendor
(db lib) agnostic and we can work around future deprecations/removals in
dbal more easily.
Right now the type of exception thrown is transported as "reason". For
the more popular types of errors we can extend the new exception class
and allow apps to catch specific errors only. Right now they have to
catch-check-rethrow. This is not ideal, but better than the dependnecy
on dbal.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 16:38:23 +01:00
3447ea4955
Merge pull request #25089 from nextcloud/enhancement/ocp-db-types
...
Add our own db column types via the public API
2021-01-12 15:24:15 +01:00
e44f275cfe
Merge pull request #25088 from nextcloud/fix/allow_app_updates_again
...
Allow installing/updating of apps again
2021-01-12 14:34:21 +01:00
d4e6463eb2
Add our own constants for db column types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
41c80d6c19
Fix option in the client code itself as well
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-12 12:36:21 +01:00
9b58a027e3
Allow installing/updating of apps again
...
The Guzzle API changed. We shall now use sink
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-12 10:51:41 +01:00
ac88bcbd5f
Add 'allow Symlinks' as an option to config.php
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-01-12 10:38:39 +01:00
c8cbb73c05
[tx-robot] updated from transifex
2021-01-12 02:19:49 +00:00
7cdc7adf59
Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8
...
Don't try a transaction for the migrator on MySQL
2021-01-11 18:07:11 +01:00
fdd111924f
Merge pull request #25039 from nextcloud/fix/libxml-use-internal-errors-deprecated
...
Only use libxml_disable_entity_loader on php older than 8
2021-01-11 16:14:38 +01:00
8f614acade
Merge pull request #25034 from nextcloud/bugfix/noid/load-authentication-for-app-upgrades
...
Make sure to do priority app upgrades first
2021-01-11 14:44:10 +01:00
5ed673e5eb
Merge pull request #25073 from nextcloud/psalm/24521/remove-unneeded-casts
...
Remove unneeded casts that were found by Psalm
2021-01-11 14:15:16 +01:00
f9484d15cb
DB: warn on parameter number constraints
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-11 13:43:34 +01:00
683685b72c
Merge pull request #25070 from nextcloud/feature/noid/card-ros-definitions
...
Deck Rich-Object-String definitions for deck boards and cards
2021-01-11 13:31:21 +01:00
24d436cb60
Remove unneeded casts that were found by Psalm
...
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521 )
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +01:00
c3cb288268
Bump scssphp/scssphp from 1.0.3 to 1.4.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-11 12:41:25 +01:00
078ecac188
Deck Rich-Object-String definitions for deck boards and cards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-11 12:03:13 +01:00
ca93c9708c
[tx-robot] updated from transifex
2021-01-11 02:19:52 +00:00
b137ac468f
[tx-robot] updated from transifex
2021-01-09 02:21:37 +00:00
f8efab7c85
Only use libxml_disable_entity_loader on php older than 8
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 16:33:46 +01:00
3cdfe7b0f4
Don't try a transaction for the migrator on MySQL
...
As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450
So now commit() fails because the internal PDO connection implicitly
commited already.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-08 16:25:40 +01:00
81302f78e5
Merge pull request #24948 from nextcloud/dependabot/composer/doctrine/dbal-3.0.0
...
Bump doctrine/dbal from 2.12.0 to 3.0.0
2021-01-08 14:58:43 +01:00
aeb32e1bc8
Merge pull request #22992 from nextcloud/password-urlencode
...
allow authenticating using urlencoded passwords
2021-01-08 14:34:01 +01:00
f31edf1544
Make sure to do priority app upgrades first
...
Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-08 12:27:54 +01:00
dc00c8ac31
Remove "primary" option from schema builder argument $options as it is not used anymore and triggers an exception
...
See 138eb85234 (diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82)
2021-01-08 11:45:19 +01:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
d13f2d984f
Merge pull request #25015 from nextcloud/fix/no-double-intl-polyfill
...
Replace patchwork/utf8 with symfony-polyfill-*
2021-01-08 08:25:31 +01:00
645e3e6d7e
Merge pull request #25021 from nextcloud/enhancement/occ-install-exception-trace
...
Print an exception trace for setup exceptions
2021-01-08 08:22:50 +01:00
94188370e7
[tx-robot] updated from transifex
2021-01-08 02:22:30 +00:00
1e3c071aa5
Merge pull request #24892 from nextcloud/fix/use-symfony-dispatcher-correctly
...
Use the Symfony dispatcher correctly
2021-01-07 21:42:44 +01:00
287c26bda3
Replace patchwork/utf8 with symfony-polyfill-*
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-07 21:22:41 +01:00
171373a944
Merge pull request #24989 from nextcloud/scanner-ignore-non-readable
...
ignore files that have no read permissions during scanning
2021-01-07 21:10:53 +01:00
d0ac76a77c
Add more previous exceptions to database setup code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-07 21:04:11 +01:00
4f52e83695
Merge pull request #24934 from nextcloud/max_file_uploads
...
Remove useless ini_set calls
2021-01-07 20:15:13 +01:00
f1921364d6
Print an exception trace for setup exceptions
...
Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-07 20:11:25 +01:00
bc1b5d7892
Remove useless ini_set functions
2021-01-07 15:24:49 +01:00
317118ef79
Catch throwable instead of exception
...
The error that gets thrown can also be a type error etc. So we should
properly catch the Throwable.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-07 14:32:26 +01:00
f552f23e43
Merge pull request #25003 from nextcloud/psalm/noid/phpdoc-fix-return-type
...
Fix return types for Archive::getStream
2021-01-07 13:31:24 +01:00
59ae722087
Fix warning in PHP 8 about optional parameter before mandatory one
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-07 12:43:56 +01:00
a39bd18654
Fix return types for Archive::getStream
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-07 12:38:41 +01:00
c374bbf14d
allow authenticating using urlencoded passwords
...
this allows authenticating with passwords that contain non ascii-characters in contexts that otherwise do not allow it (http basic)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-07 10:43:43 +01:00
205386b24e
ignore files that have no read permissions during scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-06 17:27:31 +01:00
ed1dcd3651
Set the JSCombiner cache if needed
...
Found while debugging a customer setup. They had to flush their Redis.
Hence the info was no longer there. Since they also used S3 this meant
requesting the files over and over on template render. Which on S3 is
not cheap.
Now we just write it back if we can't get it from the cache in the first
place. So that the next run has it cached properly again.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-06 16:15:17 +01:00
ad3735ba27
Merge pull request #24317 from SMillerDev/app_password_command
...
App password command
2021-01-06 15:35:39 +01:00
85454ac456
Use the Symfony dispatcher correctly
...
* Event object as first arg (otherwise there is a notice in the logs)
* `dispatch` MUST return the event object
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-05 16:00:42 +01:00
40595f3ee0
Command: Add app password generation
...
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-01-05 13:05:17 +01:00
81e3ae4753
avoid fread on directories and unencrypted files
...
Reworking the logic in order to first check the filecache and only then reading the fileheader.
This in order to solve #21578 .
2021-01-05 11:14:49 +01:00
98560c80ea
Properly handle result when copying with failure and throw in tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 09:20:35 +01:00
364b29b1e9
[tx-robot] updated from transifex
2021-01-05 02:21:26 +00:00
969d4312e2
Merge pull request #24907 from nextcloud/fix/license-headers-21-II
...
Update license headers
2021-01-04 11:06:30 +01:00
0cecd54909
[tx-robot] updated from transifex
2021-01-03 02:20:55 +00:00
25fd32cb5c
[tx-robot] updated from transifex
2021-01-01 02:21:03 +00:00
d57153940b
[tx-robot] updated from transifex
2020-12-31 02:27:04 +00:00
9ce3ea3368
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +01:00
f9941347e2
[tx-robot] updated from transifex
2020-12-30 02:19:06 +00:00
8501cf9b5c
dont apply encryption wrapper for root mount
...
the `shouldEncrypt` already disables encryption for anything thats not in the users data folder,
however the encryption wrapper being applied anyway on the root folder breaks groupfolders
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-29 12:29:23 +01:00
c9fcf5f6b1
Merge pull request #24874 from nextcloud/enh/exception_logging
...
Avoid huge exception argument logging
2020-12-29 11:38:27 +01:00
179de95f81
Avoid huge exception argument logging
...
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.
Now it will just print the first 5. And add a line that there are N
more.
If you are on debug level we will still print them all.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-29 10:50:53 +01:00
73c7d0dc81
Bump icewind/streams from 0.7.1 to 0.7.2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-29 09:07:36 +01:00
083f3d2373
[tx-robot] updated from transifex
2020-12-29 02:19:50 +00:00
bb411c75c6
Move to single share event. Just emit more if needed
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-23 11:05:29 +01:00
874a1a4c43
cs fix
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-12-23 11:00:47 +01:00
85783e45e9
+ShareDeletedEvent
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-12-23 11:00:45 +01:00
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
...
Unify links to php.net
2020-12-22 09:53:31 +01:00
5094e29ebd
Merge pull request #24594 from kofemann/dcache
2020-12-22 09:26:07 +01:00
8e9af2bb56
[tx-robot] updated from transifex
2020-12-22 02:19:06 +00:00
4f2dc18f58
storage: update IStorage#file_put_contents docs to match usage
...
The current phpdoc of IStorage#file_put_contents doesnt corresponds to
it's actual usage in code, e.g.
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
2020-12-21 19:04:18 +01:00
4f0fae8f00
Actually set the TTL on redis set
...
Else well the keys remain for ever and ever.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-21 13:33:16 +01:00
fbbb48fcc2
Merge pull request #24730 from J0WI/fix-trusted-ipv6
...
Fix IPv6 localhost regex
2020-12-21 09:59:31 +01:00
4973f9b952
Merge pull request #24715 from nextcloud/bug/noid/limit-get-incomplete-to-1
...
Limit getIncomplete query to one row
2020-12-21 09:15:10 +01:00
dc426f1e21
[tx-robot] updated from transifex
2020-12-20 02:19:27 +00:00
f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api
...
Add well known handlers API
2020-12-18 13:34:04 +01:00
6228cbe852
Merge pull request #24737 from nextcloud/fix/23544/unset_parameter
...
Also unset the other possible unused paramters
2020-12-18 08:38:45 +01:00
de7c54c6ba
[tx-robot] updated from transifex
2020-12-18 02:20:09 +00:00
484f52bb4d
Also unset the other possible unused paramters
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-16 20:31:30 +01:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
331f30f085
Fix IPv6 localhost regex
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-12-16 14:37:56 +01:00
6995223b1e
Add well known handlers API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 13:13:05 +01:00
820f9f4f63
Merge pull request #24629 from nextcloud/enh/noid/optional-before-required
...
Make $vars and $secureRandom required.
2020-12-16 12:43:06 +01:00
1d4c8961ef
Merge pull request #24659 from nextcloud/enh/noid/dav-honour-sharing.maxAutocompleteResults
...
dav principal search to honour sharing.maxAutocompleteResults setting
2020-12-16 10:47:32 +01:00
7a77493038
Merge pull request #24706 from nextcloud/bugfix/noid/log-error-on-setting-custom-headers-on-no-content-responses
...
Log an error when setting a custom header on "Not Modified" responses
2020-12-16 10:28:09 +01:00
45a02ee30c
Fix failing tests
...
Signed-off-by: James Letendre <james.letendre@gmail.com>
2020-12-15 19:06:06 -05:00
ad95e51cbe
Add web identity provider to S3 connection chain
...
Signed-off-by: James Letendre <james.letendre@gmail.com>
2020-12-15 16:37:46 -05:00
e0e76bb784
Limit getIncomplete query to one row
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-12-15 21:42:26 +01:00
a4b5312729
Do not include non-required scripts on the upgrade page
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-15 21:14:07 +01:00
2bedfbd4b0
Merge pull request #24488 from zzkt/patch-1
2020-12-15 15:19:40 +01:00
d37034f161
Merge pull request #24683 from doc75/federation_confidentiality
2020-12-15 14:35:50 +01:00
d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 11:53:39 +01:00
329ffa257e
Log an error when setting a custom header on "Not Modified" responses
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-15 11:24:15 +01:00
1f6537075b
[tx-robot] updated from transifex
2020-12-15 02:22:11 +00:00
5b756a9fb0
Replace defaultProvider with explicit calls to exclude user home directory lookup
...
Signed-off-by: James Letendre <james.letendre@gmail.com>
2020-12-14 16:22:41 -05:00
85aa77539b
Resolves #24699 , Support ES2 and ECS instance providers for S3 buckets
...
Signed-off-by: James Letendre <james.letendre@gmail.com>
2020-12-14 12:55:46 -05:00
b56d7f9f4e
Merge pull request #23017 from nextcloud/enh/distinguish-users
2020-12-14 16:54:47 +01:00
39bee7948d
Merge pull request #24631 from nextcloud/bugfix/noid/prevent-select-asterix-and-specifics
...
Prevent * and other things in the same query for Oracle
2020-12-14 14:31:15 +01:00
131fcac91e
Show unique displayname context in the sharing input
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:59 +01:00
5828f3c4f9
Prevent * and other things in the same query for Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-14 09:35:50 +01:00
99a6665888
Merge pull request #24679 from nextcloud/tcitworld-patch-1
...
Update comment to reflect current CSP policy
2020-12-14 09:11:15 +01:00
b2ef004969
Merge pull request #24663 from nextcloud/sanitizers
...
Add sanitizers for JSON output
2020-12-14 09:11:01 +01:00
83491c6c58
[ Fix #24682 ]: ensure federation cloud id is retruned if FN property not found
...
Signed-off-by: Guillaume Virlet <github@virlet.org>
2020-12-13 13:57:41 +01:00
71cf92697c
Update comment to reflect current CSP policy
...
JS unsafe-eval was removed a long time ago in https://github.com/nextcloud/server/pull/11028
2020-12-12 21:11:42 +01:00
949ae6389b
[tx-robot] updated from transifex
2020-12-12 02:18:46 +00:00
8a8aa4f7dc
Add sanitizers for JSON output
...
Those functions set proper content-types that prevent rendering of
data. Therefore it's safe to mark them as sanitizers.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-12-11 21:23:11 +00:00
794cc3d803
repair text/org MIME types
...
Signed-off-by: nik gaffney <nik@fo.am>
2020-12-11 18:21:33 +01:00
582ce5a6ad
Merge pull request #24416 from nextcloud/fix/app-store-check-php-compat
...
Check php compatibility of app store app releases
2020-12-10 21:42:58 +01:00
8ebd31d686
Make $vars and $secureRandom required.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-12-10 17:06:32 +01:00
ccd5ca5476
Merge pull request #23044 from nextcloud/migration-10.5
...
Handle owncloud migration to latest release
2020-12-10 14:32:13 +01:00
3c693db0ca
Merge pull request #24605 from nextcloud/enh/share-deck
...
Add deck share provider support
2020-12-10 14:30:08 +01:00
5fc20e8862
[tx-robot] updated from transifex
2020-12-10 02:20:14 +00:00
c4ea37b8a1
Address minor comments
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 15:51:41 +01:00
36ffad5ba7
Make sure the migrations table schema is always checked
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Revert "Make sure the migrations table schema is always checked"
This reverts commit 258955ef738a52d9da2ac2fe59466e6093d7e9bc.
Set current vendor during upgrade and perform migrations table change if needed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 15:24:03 +01:00
20949d7f48
Properly migrate from new owncloud avatar location
...
as the files are not scanned we cannot use the OCP\Files api
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 15:23:29 +01:00
c770d33717
Add internal DECK_USER type to allow unsharing for individual users
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:24 +01:00
f3150f29a7
Introduce deck share type to ShareAPIController
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:24 +01:00
f2f3ad733f
Dummy general share checks for deck
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:23 +01:00
e906138d8d
Let sharees endpoint properly handle deck shares
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:23 +01:00
fcc0d35895
Add share type for deck
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:23 +01:00
fdea545415
Allow apps to register their share providers from outside
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:23 +01:00
4ef148a781
Dump autoloader
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 12:14:16 +01:00
9fe94f282f
Readd repair steps that are relevant when migrating from ownCloud
...
This reverts commit d9b1492e03
2020-12-09 12:13:35 +01:00
2607ac3fb2
Allow major/minor match for owncloud version
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 12:13:33 +01:00
f5501ca276
Avoid checking for brute force protection capabilities when upgrading
...
This might happen a releases that doesn't have this table yet
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 12:13:33 +01:00
7518f67f33
Drop fk constraints on locks table
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 12:13:32 +01:00
c8e0f3015f
Merge pull request #24398 from nextcloud/fix/do-not-update-incompatible-app
...
Do not update incompatible apps
2020-12-09 09:28:25 +01:00
13a1eb6494
Merge pull request #24598 from nextcloud/techdebt/noid/wrap-the-exception-to-make-debuggin-easier
...
Make debugging migration exceptions easier
2020-12-08 17:10:20 +01:00
86a3b7e7bf
Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation
...
Phone number validation and search
2020-12-08 17:05:38 +01:00
13a438b322
Fix PHP code style
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-08 13:08:47 +01:00
fda6ffc866
Merge pull request #23780 from nextcloud/enh/ci/php8
...
PHP8 CI
2020-12-08 09:39:45 +01:00
7e784afa65
[tx-robot] updated from transifex
2020-12-08 02:20:20 +00:00
354c5ff024
Add a repairstep to validate the phone numbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 20:35:54 +01:00
c1f28f8d35
Make debugging migration exceptions easier
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 19:35:01 +01:00
f3513f3fe4
files: Local#writeStream should use it's own file_put_contents
...
The OC\Files\Storage\Local#writeStream use system provided file_put_contents.
However, it overrides file_put_contents, thus expects that the default behaviour
can be different.
Use Local#file_put_contents in writeStream to benefit from class specific functionality.
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
2020-12-07 18:11:40 +01:00
7f61535a1a
GD images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
c02e6fcae2
fix appconfig tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
0e10d8cb7c
Fix locking logic
...
The comparrison on php8 return true while <php8 it is false.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
f648635758
Make the throwing optional, so background tasks don't break
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
46b073d7ce
Add a config for default region of phone numbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
fe9c46e595
Add an endpoint to search for accounts based on phone number
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
eaba155a09
Add a database table for the accounts data so we can search it better
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
eab710c2fd
[tx-robot] updated from transifex
2020-12-07 02:20:42 +00:00
e41e2fe003
[tx-robot] updated from transifex
2020-12-06 02:19:28 +00:00
9a6569d4f2
[tx-robot] updated from transifex
2020-12-05 02:18:50 +00:00
cbb34af53f
Do not update incompatible apps
...
Previously there was no (platform) dependency check for an app that was
installed before. So Nextcloud happily upgraded an app that now requires
a php version newer than the current one. Which means in the lucky case
you see a failing upgrade due to the language incompatibility, or in the
unlucky case you see unexpected errors later in production.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-04 17:05:22 +01:00
24237f1a34
Check php compatibility of app store app releases
...
Apps might increase the minimum php version requirement, in which case
an update could break the app or even the whole instance. We must not
install those releases, or better, don't even show them for
update/installation. This extends the app fetcher code to filter out the
releases that are not installable.
The filter respects minimum and maximum requirements. E.g. apps that are
still only released for php7.3 won't show up for php7.4 instances. This
behavior is new but if an app lists an explicit version requirement,
then we ought to repect that.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-04 16:52:31 +01:00
f0862dcfaa
Merge pull request #24552 from nextcloud/enh/remember_me_is_not_app_password
...
Remember me is not an app_password
2020-12-04 16:35:44 +01:00
0d7819eb6c
Merge pull request #24550 from nextcloud/enh/fix/new_session_id_if_decrypt_fails
...
Generate a new session id if the decrypting the session data fails
2020-12-04 12:52:59 +01:00
5cc348ae72
Fix typo
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-04 12:51:45 +01:00
48b4b83b5a
Remember me is not an app_password
...
While technically they are stored the same. This session variable is
used to indicate that a user is using an app password to authenticate.
Like from a client. Or when having it generated automatically.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 12:40:28 +01:00
858f623081
Generate a new session id if the decrypting the session data fails
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 11:42:40 +01:00
9b3361ce87
Don't log params of imagecreatefromstring
...
To prevent flooding the log with actual image data.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-04 09:30:20 +01:00
32ded877dc
Merge pull request #24474 from nextcloud/enhancement/unified-search-result-attributes
...
Allow unified search results to have attributes
2020-12-04 08:42:15 +01:00
3f88dbd259
[tx-robot] updated from transifex
2020-12-04 02:19:19 +00:00
cc92d5a293
Allow unified search results to have attributes
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-03 18:24:33 +01:00
c9cd633665
Fix the download of multiple files from the webUI
...
needed a setupFS call
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 13:20:01 +01:00
64bc7c79e8
Merge pull request #24498 from nextcloud/enhancement/nextcloud-log-normalizer
...
Replace abandoned log normalizer with our fork
2020-12-03 11:04:49 +01:00
04d67d558e
Also handle legacy cipher support when encryption is disabled but an old master key is present
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-03 09:47:05 +01:00
244c53dea1
Replace abandoned log normalizer with our fork
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-03 09:44:25 +01:00
4d64ec9944
Merge pull request #24519 from nextcloud/fix/bug/emailtemplate
...
Fix vsprint parameter
2020-12-03 09:13:58 +01:00
fbc06d39c7
Merge pull request #24429 from nextcloud/3rdparty/closure
...
[3rdparty] Migrate to Opis/Closure
2020-12-03 08:44:53 +01:00
3d315ec64f
Fix vsprint parameter
...
%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 08:25:11 +01:00
0dcc227a6b
[tx-robot] updated from transifex
2020-12-03 02:19:51 +00:00
04c037ebfd
[3rdparty] Migrate to Opis/Closure
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-02 20:16:57 +01:00
6f4d3edb5e
Merge pull request #24113 from nextcloud/extend-cache-events
...
extend cache events
2020-12-02 19:48:20 +01:00
4deff37a3c
Merge pull request #23278 from nextcloud/enh/noid/user-limits
...
Allow subscription to indicate that a userlimit is reached
2020-12-02 18:22:13 +01:00
e580f91143
Merge pull request #23257 from aler9/patch-32bit-filesize-master
...
Fix file size computation on 32bit platforms
2020-12-02 16:22:24 +01:00
32f6bdf067
Merge pull request #24396 from nextcloud/dont-use-system-composer
...
dont use system composer for autoload checker
2020-12-02 16:15:55 +01:00
d69407963c
Merge pull request #24500 from nextcloud/bugfix/noid/log_query_no_crash
...
Prevent log_query to mess up regular execution flow
2020-12-02 16:15:26 +01:00
aef1cdba03
code style and dispatchTyped
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-02 16:15:02 +01:00
c0a05c0412
Add notification for user limit
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 15:20:03 +01:00
d87705a894
Allow subscription to indicate that a userlimit is reached
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 15:20:03 +01:00
a50bcdabcc
Prevent log_query to mess up regular execution flow
...
When the "log_query" debug config parameter is set, SQL queries are
logged. However, if an error occurs when converting the values to
string, it will abort the request.
This fix catches the error and continues instead.
Also added handler for DateTime value which is already known to cause
aborts here.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-02 14:10:35 +01:00
ac0c7a8fe0
Fix file size computation on 32bit platforms
...
Signed-off-by: aler9 <46489434+aler9@users.noreply.github.com>
2020-12-02 12:05:14 +01:00
7ceb98f63b
[tx-robot] updated from transifex
2020-12-01 02:19:46 +00:00
9a3cc099db
Merge pull request #24414 from nextcloud/techdebt/remove-update-php
...
Remove the deprecated update.php
2020-11-30 12:11:03 +01:00
83a75c670b
Replace static call to Share::unshare with ShareManager->deleteShare in tests
...
And then cleanup all the code that is dead then...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-30 09:51:18 +01:00
6564a95160
Remove now unused methods in Share.php due to the reduced code complexity in Share::getItems
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 23:28:16 +01:00
10e5ae5e18
Remove unused method Share Helper::generateTarget
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 22:52:52 +01:00
a125d8aaa1
Reduce code complexity in Share::getItems by tracing all remaining callers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 22:30:09 +01:00
596df8fc6f
Remove unused Share::getItemSharedWithBySource()
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-29 22:24:12 +01:00
fd649afb1f
Remove the deprecated update.php
...
* It was documented as deprecated.
* The app code checker warned about it
* It's been three years
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 13:02:59 +01:00
7956cef622
rebuild autoloader scripts with 2.0.7
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:49:03 +01:00
88f35d52d2
rename cache event to follow new naming standards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:39:46 +01:00
23fb497ff5
extend cache events
...
- adds cache remove event
- expose storage id in event
- emit events during cache move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:22:03 +01:00
7dd39a91ee
Remove dead method \OC\Updater::checkAppUpgrade
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-26 14:48:41 +01:00
54e3beba16
Merge pull request #24319 from nextcloud/techdebt/noid/streamline-user-creation-and-deletion-events
...
Streamline user creation and deletion events
2020-11-26 14:09:54 +01:00
2172432420
Merge pull request #23912 from nextcloud/objectstore-copy
...
use in objectstore copy
2020-11-25 16:09:26 +01:00
9cfa8a6c44
send expected format of cloud id
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-24 23:14:43 +01:00
5d03b5c5dd
Merge pull request #24162 from nextcloud/fix/noid/fedshares-displaynamez
...
set the display name of federated sharees from addressbook
2020-11-24 17:23:37 +01:00
6156a49f6e
Merge pull request #24341 from nextcloud/fix/sharing-enforce-expire-checkbox
...
Fix the config key on the sharing expire checkbox
2020-11-24 15:49:49 +01:00
9d4848e863
use in objectstore copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-24 15:16:58 +01:00
2526c5e042
Fix the config key on the sharing expire checkbox
...
We don't use `shareapi_internal_enforce_expire_date` anywhere.
`shareapi_enforce_internal_expire_date` is the one we want.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-24 14:17:41 +01:00
d4fd61b7c6
Merge pull request #24324 from nextcloud/td/psalm/backgroundjob_job
...
Fix the OCP\BackgroundJob\Job to make it compatible with its interface
2020-11-24 13:16:12 +01:00
16a78f535a
set the display name of federated sharees from addressbook
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-24 11:30:11 +01:00
c2c539a754
Merge pull request #24323 from nextcloud/fix/comments-tab-missing
...
Fix reverse registration and missing comments tab
2020-11-24 09:34:50 +01:00
82d3f50b78
Fix the OCP\BackgroundJob\Job to make it compatible with its interface
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-24 09:33:49 +01:00
8ac9767881
Merge pull request #24312 from nextcloud/bugfix/noid/fix-router-alias
...
Add proper alias for internal router class
2020-11-24 08:43:29 +01:00
decc5c844b
Fix reverse registration and missing comments tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-24 08:28:19 +01:00
d9708ebece
Add proper alias for internal router class
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-24 08:01:39 +01:00
f4c1512bb7
Fix typo in @deprecated PHPDoc tag
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-24 00:13:09 +01:00
9bf76d2bad
Streamline user creation and deletion events
...
CreateUserEvent was the only one that didn't matched the naming scheme of BeforePASTTENSEEvent and PASTTENSEEvent. The event wasn't used at all so this just removes it again as there is BeforeUserCreatedEvent that is also available since 18.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-23 23:59:52 +01:00
a5d4d3d4cc
Add IRequest taint sources
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-22 23:04:43 +01:00
9a0428835f
Merge pull request #24267 from nextcloud/techdebt/noid/auto-wire-encryption-app-view-dependent
...
Auto-wire remaining encryption app services that depend on View
2020-11-22 22:33:53 +01:00
032de4f333
Merge pull request #24269 from nextcloud/taint-specialize
...
Mark getAppPath as specialized taint
2020-11-22 13:39:46 +01:00
d25ca1976b
Mark getAppPath as specialized taint
...
Should remove some false positives.
https://psalm.dev/docs/security_analysis/avoiding_false_positives/
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-21 01:15:15 +00:00
98ddfdd1e8
Mark cleanAppId as sanitizer for include
...
Should remove a bunch of false positive code scanning results.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-21 00:57:25 +00:00
e606c0eef4
Allow View to be used via DI
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-21 00:18:59 +01:00
db3a3bee37
Merge pull request #24064 from nextcloud/techdebt/noid/auto-wire-encryption-app
...
Auto-wire as much as possible in the encryption app
2020-11-21 00:04:54 +01:00
6811274cfd
Merge pull request #24246 from LukasReschke/add-taint-flow-analysis
...
Add Psalm Security Analysis
2020-11-21 00:04:37 +01:00
5be18215fb
Auto-wire as much as possible in the encryption app
...
Also cleans up only non-classname services in the server container
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-20 23:13:22 +01:00
47ac8e0028
Add Psalm Taint Flow Analysis
...
This adds the Psalm Security Analysis, as described at
https://psalm.dev/docs/security_analysis/
It also adds a plugin for adding input into AppFramework.
The results can be viewed in the GitHub Security tab at
https://github.com/nextcloud/server/security/code-scanning
**Q&A:**
Q: Why do you not use the shipped Psalm version?
A: I do a lot of changes to the Psalm Taint behaviour. Using released
versions is not gonna get us the results we want.
Q: How do I improve false positives?
A: https://psalm.dev/docs/security_analysis/avoiding_false_positives/
Q: How do I add custom sources?
A: https://psalm.dev/docs/security_analysis/custom_taint_sources/
Q: We should run this on apps!
A: Yes.
Q: What will change in Psalm?
A: Quite some of the PHP core functions are not yet marked to propagate
the taint. This leads to results where the taint flow is lost. That's
something that I am currently working on.
Q: Why is the plugin MIT licensed?
A: Because its the first of its kind (based on GitHub Code Search) and
I want other people to copy it if they want to. Security is for all :)
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-20 23:12:00 +01:00
a42eb05a35
Simple typo in comments
2020-11-20 20:01:28 +01:00
691409cdec
Merge pull request #24062 from nextcloud/revert-24060-revert-24039-faster-installation
...
Revert "Revert "Installation goes brrrr""
2020-11-20 15:02:51 +01:00
b71803802c
Harden EncryptionLegacyCipher a bit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-20 09:52:55 +01:00
1b613c84e9
Merge pull request #24007 from nextcloud/select-distinct-multiple
...
allow selecting multiple columns with SELECT DISTINCT
2020-11-19 22:39:01 +01:00
c2510ecae9
Merge pull request #24103 from nextcloud/bugfix/noid/groupfolder-share-object-storage
...
Only check path for being accessible when the storage is a object home
2020-11-19 22:37:28 +01:00
650ffc587f
Merge pull request #24164 from nextcloud/fix/lazy-app-registration
...
Allow lazy app registration
2020-11-19 22:35:09 +01:00
1e111b2ad2
Fix DataResponse typehints
...
We use this already in several places where we just pass strings or
numbers.
This all works because we just convert it to a json response in the end.
So better to have the typehints reflect this.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-19 20:34:42 +01:00
d602aa1825
Merge pull request #24135 from medical-cloud/fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20
...
Fix nextcloud logo in email notifications misalignment
2020-11-19 10:48:18 +01:00
ecbc7f62be
Merge pull request #24207 from nextcloud/bugfix/noid/missing-level-psrlogged
...
missing level in ScopedPsrLogger
2020-11-19 08:38:05 +01:00
c773cee305
[tx-robot] updated from transifex
2020-11-19 02:20:10 +00:00
87ec4a0da3
Fix #23357
...
Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>
2020-11-18 22:29:02 +01:00
a0d9b15a80
missing level
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-11-18 18:30:07 -01:00
66013f906d
Merge pull request #24189 from nextcloud/enh/csp/frame-ancestors
...
Set frame-ancestors to none if none are filled
2020-11-18 11:29:28 +01:00
9163790b7c
Set frame-ancestors to none if none are filled
...
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-18 10:13:36 +01:00
3cf39c573f
Allow lazy app registration
...
During app installation we run migration steps. Those steps may use
services the app registers or classes from composer. Hence we have to
make sure the app runs through the registration.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-18 08:48:45 +01:00
72a9c35be3
Remove some IRouter methods
...
This is not the end. IRouter needs to burn.
But it is a start.
🎵 we didn't start the fire 🎵
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-17 14:08:20 +01:00
a8cb8e21c1
Add types to function builder
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-16 19:46:24 +01:00
9a3ce2f71f
Don't drop the table anymore when we create it again
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-16 19:34:38 +01:00
a61a757b85
allow selecting multiple columns with SELECT DISTINCT
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-16 15:45:17 +01:00
426dc68b45
Merge pull request #24069 from nextcloud/fix-default-internal-expiration-date
...
Fix default internal expiration date
2020-11-16 14:13:56 +01:00
d0f738fd59
Merge pull request #24112 from nextcloud/bugfix/24099/setup-fs-before-query-storage-in-settings
...
Set up FS before querying storage info in settings
2020-11-16 11:46:22 +01:00
bcf0a69af4
Fix default internal expiration date
...
The default expiration date for internal shares was set from the default
link expiration date instead of the internal one.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 08:54:18 +01:00
91a3e439cb
Don't throw on SHOW VERSION query
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-16 08:43:48 +01:00
569c615383
[tx-robot] updated from transifex
2020-11-14 02:19:36 +00:00
2143f2bb82
Set up FS before querying storage info in settings
...
The personal info section of the personal settings is querying the
storage quota information. For this it requires the FS to be setup which
is not always guaranteed.
This fixes an issue where refreshing the settings page would cause it to
fail after Redis caches are full. It is likely that when Redis cache is
populated, some code path is initializing the FS, so it works so far.
But when the cache is populated, that code path is skipped so the FS is
not guaranteed to be setup...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-13 17:06:37 +01:00
d665981447
Only check path for being accessible when the storage is a object home
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-13 13:48:32 +01:00
81070c753b
Merge pull request #24053 from nextcloud/bugfix/noid/fix-user-status-for-oracle
2020-11-12 21:43:31 +01:00
51a02c8009
ReflectionParamter::getClass is deprecated
...
In php8 this starts throwing warnings. And since we use it quite often
we flood the log. This moves it to getType which does the same. Only non
deprecated now.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-11 20:42:14 +01:00
d7b5d4cb58
Revert "Revert "Installation goes brrrr""
2020-11-11 20:12:13 +01:00
d36155620c
Revert "Installation goes brrrr"
2020-11-11 17:40:12 +01:00
c27ed22488
Dump autoloader
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-11 16:49:37 +01:00
77713ab454
Don't create a schema to check if the migrations table exists
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-11 11:45:00 +01:00
dde0e73c6b
Reduce the number of schemas we generate when we just run all migrations anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-11 11:45:00 +01:00
7f45f90789
Only update the schema when we install anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-11 11:40:51 +01:00
61496d3482
Merge pull request #24041 from nextcloud/techdebt/noid/remove-oc_hooks-for-group-management
...
Remove old OC_Hook for OC_Group events
2020-11-11 11:17:31 +01:00
e39d657e24
Merge pull request #23882 from nextcloud/tests/oracle
...
Run unit tests against oracle
2020-11-11 10:05:24 +01:00
0ee4f43048
[tx-robot] updated from transifex
2020-11-11 02:20:12 +00:00
e187c1d778
Remove old OC_Hook for OC_Group events
...
Those mappings exist and we will remove the first ones (labeled as `old`):
old: `\OC_Hook::listen('OC_Group', 'pre_createGroup', array('run' => true, 'gid' => $gid));`
since OC 8 (owncloud/core#12618): `$groupManager->listen('\OC\Group', 'preCreate', function ($gid) { ... });`
since NC 17 (#18350 ): `OCP\Group\Events\BeforeGroupCreatedEvent`
old: `\OC_Hook::emit('OC_User', 'post_createGroup', array('gid' => $gid->getGID()));`
since OC 8 (owncloud/core#12618 ): `$groupManager->listen('\OC\Group', 'postCreate', function (\OC\Group\Group $gid) { ... });`
since NC 17 (#18350 ): `OCP\Group\Events\GroupCreatedEvent`
old: `\OC_Hook::emit('OC_Group', 'pre_deleteGroup', array('run' => true, 'gid' => $group->getGID()));`
since OC 8 (owncloud/core#12618 ): `$groupManager->listen('\OC\Group', 'preDelete', function (\OC\Group\Group $group) { ... });`
since NC 17 (#18350 ): `OCP\Group\Events\BeforeGroupDeletedEvent`
old: `\OC_Hook::emit('OC_User', 'post_deleteGroup', array('gid' => $group->getGID()));`
since OC 8 (owncloud/core#12618 ): `$groupManager->listen('\OC\Group', 'postDelete', function (\OC\Group\Group $group) { ... });`
since NC 17 (#18350 ): `OCP\Group\Events\GroupDeletedEvent`
old: `\OC_Hook::emit('OC_Group', 'pre_addToGroup', array('run' => true, 'uid' => $user->getUID(), 'gid' => $group->getGID()));`
since OC 8 (owncloud/core#12618 ): `$groupManager->listen('\OC\Group', 'preAddUser', function (\OC\Group\Group $group, \OC\User\User $user) { ... });`
since NC 17 (#18350 ): `OCP\Group\Events\BeforeUserAddedEvent`
old: `\OC_Hook::emit('OC_Group', 'post_addToGroup', array('uid' => $user->getUID(), 'gid' => $group->getGID()));`
since OC 8 (owncloud/core#12618 ): `$groupManager->listen('\OC\Group', 'postAddUser', function (\OC\Group\Group $group, \OC\User\User $user) { ... });`
since NC 17 (#18350 ): `OCP\Group\Events\UserAddedEvent`
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-10 21:58:44 +01:00
d5df033ede
Create primary keys on all tables and add a command to create the afterwards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +01:00
5b5aebbf66
Replace the credentials table with one that can have empty user
...
Primary key columns on Oracle can not have empty strings
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +01:00
fbda2d1d25
Don't try to update on NotNullConstraintViolationException, only on unique or foreign key
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +01:00
1aa9c9164d
Fix comparing the empty string for global credentials
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:26 +01:00
cffad62771
Empty string is returned as null, but empty string in file cache is the root and exists
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:43 +01:00
ecbb066dec
Make sure columns with an empty default are nullable for Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:16 +01:00
f23c2162ad
Merge pull request #23993 from nextcloud/bugfix/noid/close-cursors
...
Don't leave cursors open
2020-11-10 15:15:03 +01:00
979b291a36
Show the full trace of an exception
...
Because often we catch the exception at some point and then the trace is
misleading. What's really interesting is the trace of the *previous*
exception.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-10 10:35:08 +01:00
4686deb298
Merge pull request #23999 from nextcloud/fix/old-legacy-scripts
...
Remove old legacy scripts references
2020-11-09 16:58:40 +01:00
2b7ea590e1
Merge pull request #23994 from nextcloud/fix/comment_search
...
Update comment search to initFS
2020-11-09 15:52:01 +01:00
8027dcbc6f
Don't leave cursors open when tests fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
3bacb4780b
Removed config.js
2020-11-09 12:23:51 +01:00
72545ffd07
Merge pull request #23937 from nextcloud/bugfix/noid/files-ocdb
...
Use query builder instead of OC_DB in OC\Files\*
2020-11-09 11:58:36 +01:00
f02bab1425
Merge pull request #23976 from nextcloud/enh/reduce_getAppPath_and_autoload_reg
...
Reduce the getAppPath and autoloader calls
2020-11-09 11:10:33 +01:00
28464f71a2
Merge pull request #23982 from nextcloud/fix/quota-storage-getsize
...
Make sure root storage is valid before checking its size
2020-11-09 11:03:25 +01:00
005a132938
Merge pull request #23741 from Ashod/lock-leak
...
Unlock when promoting to exclusive lock fails
2020-11-09 11:00:46 +01:00
2f70a25076
Merge pull request #23978 from nextcloud/enh/query_servercontainer_first
...
First query the server container
2020-11-09 10:58:26 +01:00
d1c53981eb
Update comment search to initFS
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-09 09:52:23 +01:00
c07720de77
Use query builder instead of OC_DB in OC\Files\*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 09:05:15 +01:00
6a453ac184
Make sure root storage is valid before checking its size
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-09 08:49:30 +01:00
f5be2c722a
[tx-robot] updated from transifex
2020-11-09 02:18:51 +00:00
889bb44b42
First query the server container
...
When the servercontainer wants to obtain something changes are very high
this is something from the server container. Esp on setups with a lot of
shares this can change quite a bit as it avoid a needless check on the
strpos OCA\\ etc.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-07 17:51:41 +01:00
d8637c62e0
Reduce the getAppPath and autoloader calls
...
The getAppPath will always return the same data for the same appId. It
is actually already cached. However we do some cleanup of the appId
(again). Same for the autoloading it is actually already checked.
This just removes the unneeded calls. Which can add up if you have a lot
of incomming shares.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-07 17:24:41 +01:00
a5fa9604ba
Merge pull request #23923 from nextcloud/bugfix/oci/fix-greatest-order-for-oracle
...
Fix greatest/least order for oracle
2020-11-07 16:55:13 +01:00
a66fb45c0b
Unlock when promoting to exclusive lock fails
...
In certain cases changeLock to EXCLUSIVE fails
and throws LockedException. This leaves the
file locked as SHARED in file_put_contents,
which prevents retrying (because on second
call file_put_contents takes another SHARED
lock on the same file, and changeLock doesn't
allow more than a single SHARED lock to promote
to EXCLUSIVE).
To avoid this case, we catch the LockedException
and unlock before re-throwing.
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-07 10:31:26 -05:00
d9e471771a
Update parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-07 14:06:03 +01:00
d25e5366b8
Merge pull request #23934 from nextcloud/enh/avoid_scss_compile
2020-11-07 10:11:50 +01:00
1a30e4d28f
Merge pull request #23821 from nextcloud/td/enh/no_fs_setup_by_default
...
Do not setup the default FS on normal routes
2020-11-06 23:03:09 +01:00
cab80e685b
Merge pull request #23942 from nextcloud/techdebt/cookie-lax-php7.3
...
Remove the cookie paths for php<7.3
2020-11-06 22:42:20 +01:00
1da559f5e9
Merge pull request #23938 from nextcloud/bugfix/oci/sharing-ocdb
...
Replace some usages of OC_DB in OC\Share\* with query builder
2020-11-06 22:41:20 +01:00
659ea6ad79
Merge pull request #23851 from nextcloud/enh/read_env_only_once
...
Read the env variables only once
2020-11-06 22:35:00 +01:00
fb5d1b40e4
Merge pull request #23943 from nextcloud/bugfix/oci/fix-ilike-on-oracle
...
Fix iLike() falsely turning escaped % and _ into wildcards
2020-11-06 22:27:30 +01:00
9981ffd784
Merge pull request #23922 from nextcloud/bugfix/noid/fix-query-type-detection
...
Improve query type detection
2020-11-06 22:18:14 +01:00
63f996408b
Merge pull request #23928 from nextcloud/bugfix/oci/dont-leave-stray-cursors-on-mimetype-update
...
Fix repair mimetype step to not leave stray cursors
2020-11-06 22:09:44 +01:00
b70cf435a7
Merge pull request #23940 from nextcloud/enh/skip_already_loaded_apps
...
Skip already loaded apps in loadApps
2020-11-06 21:58:44 +01:00
Julius Härtl
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Christoph Wurst
Nextcloud bot
Christoph Wurst
Robin Appelman
Marco Ziech
Morris Jobke
blizzz
Roeland Jago Douma
Joas Schilling
Jasper Knockaert
Joas Schilling
Damien Goutte-Gattat
Johannes Leuker
Carlos Ferreira
Sean Molenaar
Maxence Lange
Tigran Mkrtchyan
J0WI
James Letendre
Daniel Kesselberg
Guillaume Virlet
Thomas Citharel
Lukas Reschke
nik gaffney
Vincent Petry
aler9
medcloud
Daniel Calviño Sánchez
John Molakvoæ
Ashod Nakashian