Commit Graph

22581 Commits

Author SHA1 Message Date
Arthur Schiwon 7f6e2c5953 fix possible leaking scope in Flow
- a configured flow can be brought into consideration, despite its event
  was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-25 08:42:24 +00:00
Roeland Jago Douma 5cf3c27a03
Merge pull request #22400 from nextcloud/backport/22394/stable19
[stable19] Fix missing FN from federated contact
2020-08-25 09:38:44 +02:00
Nextcloud bot 1277b89a0c
[tx-robot] updated from transifex 2020-08-25 02:17:52 +00:00
John Molakvoæ (skjnldsv) 060672734b Fix missing FN from federated contact
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-24 16:07:25 +00:00
Arthur Schiwon 8860ab6c5d
fix event icon sizes and text alignment
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-24 14:14:41 +02:00
Roeland Jago Douma b3a32f1887
Merge pull request #22337 from nextcloud/backport/22322/stable19
[stable19] Only copy the link when updating a share or no password was forced
2020-08-24 12:20:00 +02:00
Roeland Jago Douma d8c958907f
Make legacy cipher opt in
* Systems that upgrade have this enabled by default
* New systems disable it
* We'll have to add some wargning in the setup checks if this is enabled

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-24 11:50:04 +02:00
Joas Schilling 2215cbc352 Only copy the link when updating a share or no password was forced
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-24 08:49:01 +00:00
Nextcloud bot 14927afaf7
[tx-robot] updated from transifex 2020-08-24 02:16:55 +00:00
Nextcloud bot 0ed1d67c7f
[tx-robot] updated from transifex 2020-08-23 02:16:53 +00:00
Nextcloud bot 3b85a547df
[tx-robot] updated from transifex 2020-08-22 02:16:39 +00:00
Roeland Jago Douma 687b37fa3c
Merge pull request #22348 from nextcloud/backport/22346/stable19
[stable19] l10n:Correct appid for WebAuthn
2020-08-21 11:06:11 +02:00
Roeland Jago Douma 9c99245ed7
Merge pull request #22341 from nextcloud/backport/22335/stable19
[stable19] Remove encryption option for nextcloud external storage
2020-08-21 09:24:35 +02:00
Roeland Jago Douma cb28b81675
Merge pull request #22333 from nextcloud/backport/22236/stable19
[stable19] CalDAV: Add ability to limit sharing to owner
2020-08-21 09:23:35 +02:00
Michiel Janssens 4478854403 l10n:Correct appid for WebAuthn
Signed-off-by: Michiel Janssens <michiel@nexigon.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-21 07:02:33 +00:00
Nextcloud bot 8b5c9a820d
[tx-robot] updated from transifex 2020-08-21 02:16:55 +00:00
Roeland Jago Douma 779df24b62 Remove encryption option for nextcloud external storage
Fixes #16017

Since it never worked we should not show it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-20 16:29:32 +00:00
Georg Ehrke 7f8e43c7a7 Add ability to limit sharing to owner
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-20 12:51:09 +00:00
Morris Jobke 442d174ac3
Merge pull request #22309 from nextcloud/backport/22221/stable19-2
[stable19] fixing a logged deprecation message
2020-08-20 08:02:01 +02:00
Nextcloud bot db324278b5
[tx-robot] updated from transifex 2020-08-20 02:17:50 +00:00
Arthur Schiwon c8956e8893
simplified backport of #22221, fixing a deprecation log message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-19 23:03:22 +02:00
Morris Jobke d7aa1c00ed
Merge pull request #21983 from nextcloud/backport/21628/stable19
[stable19] fix moving files from external storage to object store trashbin
2020-08-19 21:29:01 +02:00
Joas Schilling fef5925ed4
Merge pull request #22239 from nextcloud/backport/22128/stable19
[stable19] Delete chunks if the move on an upload failed
2020-08-19 15:54:36 +02:00
Nextcloud bot fd9ebeefa2
[tx-robot] updated from transifex 2020-08-19 02:17:21 +00:00
Nextcloud bot 6bcb656c5d
[tx-robot] updated from transifex 2020-08-18 02:17:38 +00:00
Nextcloud bot 6bdafb1aa9
[tx-robot] updated from transifex 2020-08-17 02:16:48 +00:00
Nextcloud bot b0470cca30
[tx-robot] updated from transifex 2020-08-16 02:16:38 +00:00
Nextcloud bot 9d77e2ce40
[tx-robot] updated from transifex 2020-08-15 02:17:25 +00:00
Roeland Jago Douma 10ee9791ff
Merge pull request #21975 from nextcloud/backport/21658/stable19
[stable19] allow admin to configure the max trashbin size
2020-08-14 05:58:57 +02:00
Nextcloud bot cb4c197555
[tx-robot] updated from transifex 2020-08-14 02:32:09 +00:00
Julius Härtl 2b34f0e785 Return proper status when file didn't exist before
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:06 +00:00
Julius Härtl b83c858e6d Adjust chunking test for non-existing target node
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:06 +00:00
Julius Härtl 242b19f18e Delete chunks if the move on an upload failed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:05 +00:00
Morris Jobke 5ed3f43927
Add app config option to disable "Email was changed by admin" activity
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 13:31:49 +02:00
Roeland Jago Douma 45bdfd2198
Merge pull request #22131 from nextcloud/backport/22062/stable19-take2
[stable19] fix display of remote users in incoming share notifications
2020-08-13 09:41:22 +02:00
Roeland Jago Douma 1d123c0ccb
Merge pull request #22181 from nextcloud/backport/21775/stable19
[stable19] Do not exit if available space cannot be determined on file transfer
2020-08-13 05:21:52 +02:00
Nextcloud bot 6327b8a6fb
[tx-robot] updated from transifex 2020-08-13 02:16:48 +00:00
blizzz 33db8a97c9
Merge pull request #22203 from nextcloud/backport/21559/stable19
[stable19] shortcut in reading nested group members when IN_CHAIN is available
2020-08-12 13:42:08 +00:00
Arthur Schiwon f32b1e4856 remove logging message carrying no valuable information
the exception caught is not an error, but due to valid configuration and
code flow is expecting this. For an admin it is confusing, and it carries
no information worth for debugging.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 09:18:39 +00:00
Arthur Schiwon 8fd575527d
adapt tests for nc19
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 10:23:13 +02:00
Roeland Jago Douma 8c753f87fc SSE enhancement
Do not blind concatenate ints. Lets add a _ between them. So that we can
distrinquis them properly

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-12 07:11:19 +00:00
Nextcloud bot 659fb3cf06
[tx-robot] updated from transifex 2020-08-12 02:16:59 +00:00
Arthur Schiwon ebb565f7a8
do not flip available state to unavailable, allow empty results
- the detection relies that the first, requested result is not empty
- it might be empty though – groups without members
- protect switching from available to unavailable
  - switching the other way around was also not envisaged either

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-12 00:34:15 +02:00
Arthur Schiwon 74bde3eb49 LDAP: shortcut in reading nested group members when IN_CHAIN is available
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-11 22:24:38 +00:00
Roeland Jago Douma eded52eae7
Merge pull request #22183 from nextcloud/backport/21173/stable19
[stable19] Fix empty 'more' apps navigation after installing an app
2020-08-11 20:25:55 +02:00
Roeland Jago Douma e55591b0f8
Merge pull request #22171 from nextcloud/backport/21728/stable19
[stable19] Reuse cache for directory mtime/size if filesystem changes can be ignored
2020-08-11 15:18:52 +02:00
Jan-Christoph Borchardt 53d99755c5 Fix empty 'more' apps navigation after installing an app
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-08-11 09:30:40 +00:00
Morris Jobke 7f49492117 Use constant instead of magic number
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-11 09:20:08 +00:00
Julius Härtl 3606b4a8ba Do not exit if available space cannot be determined on file transfer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-11 09:20:03 +00:00
Daniel Kesselberg 778e5afcc5 Remove unexpected argument
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-11 07:47:32 +00:00
Nextcloud bot df92a97f5b
[tx-robot] updated from transifex 2020-08-11 02:17:07 +00:00
Julius Härtl 112e2f6747 Reuse cache for directory mtime/size if filesystem changes can be ignored
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-10 13:32:29 +00:00
Nextcloud bot 72e4cd0b93
[tx-robot] updated from transifex 2020-08-09 02:16:47 +00:00
Nextcloud bot 724b59476d
[tx-robot] updated from transifex 2020-08-07 02:16:51 +00:00
Joas Schilling 5728f23b57
Short php syntax
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-06 12:43:47 +02:00
Joas Schilling f213617704
Fix missing placeholders in translations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-06 12:43:47 +02:00
Arthur Schiwon c6becac993
effectively revert 17fae47bdb fixing i10n
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-06 12:43:47 +02:00
Arthur Schiwon f13d5a3ec0
coding style fixes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-06 12:43:47 +02:00
Arthur Schiwon 69a3829940
fix check for Cloud ID, missing return statements, wrong param use
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-06 12:43:47 +02:00
Nextcloud bot dd60e3282d
[tx-robot] updated from transifex 2020-08-06 02:17:22 +00:00
Nextcloud bot 02680cf93d
[tx-robot] updated from transifex 2020-08-05 02:17:09 +00:00
Nextcloud bot 789db73ca5
[tx-robot] updated from transifex 2020-08-04 02:16:40 +00:00
Nextcloud bot 9d56c5142b
[tx-robot] updated from transifex 2020-08-01 02:17:12 +00:00
Robin Appelman 193b3ead51
fix object store trashbin handling
object stores are "special" given how they interact with the cache on their own

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-31 17:21:28 +02:00
Arthur Schiwon b791ea755d reset the cookie internally in new API when abandoning paged results op
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-07-31 08:19:23 +00:00
Nextcloud bot 891e0ccd6e
[tx-robot] updated from transifex 2020-07-31 02:17:32 +00:00
Morris Jobke dba3b513e3
Merge pull request #22050 from nextcloud/dependabot/npm_and_yarn/stable19/elliptic-6.5.3
[Security] Bump elliptic from 6.5.2 to 6.5.3
2020-07-31 00:45:05 +02:00
dependabot-preview[bot] b609a0fe23 [Security] Bump elliptic from 6.5.2 to 6.5.3
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-30 16:05:56 +00:00
Morris Jobke de70dcf708
Merge pull request #21981 from nextcloud/backport/21972/stable19
[stable19] Fix PHPUnit deprecation warnings
2020-07-30 11:03:54 +02:00
Julius Härtl 7e08cb757b
Properly fetch translation for remote wipe confirmation dialog
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-29 08:47:55 +02:00
Nextcloud bot 73132b56d4
[tx-robot] updated from transifex 2020-07-29 02:17:02 +00:00
Nextcloud bot d44a545a32
[tx-robot] updated from transifex 2020-07-28 02:16:48 +00:00
Nextcloud bot 4ceda884ac
[tx-robot] updated from transifex 2020-07-27 02:16:42 +00:00
Nextcloud bot 46715762ce
[tx-robot] updated from transifex 2020-07-25 02:16:45 +00:00
Morris Jobke 874a1ef500
Merge pull request #21978 from nextcloud/backport/21973/stable19
[stable19] Fix risky test in twofactor_backupcodes
2020-07-24 13:20:05 +02:00
Nextcloud bot a05efb5217
[tx-robot] updated from transifex 2020-07-24 02:17:02 +00:00
Robin Appelman b6a600e653 rollback cache rename if trashbin move fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:23 +00:00
Robin Appelman c567b1d6b2 fix moving files from external storage to object store trashbin
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.

By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:22 +00:00
Morris Jobke c813a9e4fb Replace deprecated assertArraySubset with logic that does the same
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:26:45 +00:00
Morris Jobke c4bedf468e Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:26:45 +00:00
Morris Jobke 1d290e15e8 Use assertStringContainsString instead of assertContains on strings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:26:44 +00:00
Morris Jobke 5e97f39dad Fix risky test in twofactor_backupcodes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 20:25:40 +00:00
Joas Schilling c0317e95e0 Improve error reporting on sharing errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-23 19:14:26 +00:00
Morris Jobke 4570534fed
Merge pull request #21967 from nextcloud/backport/21963/stable19
[stable19] Respect default share permissions
2020-07-23 17:28:38 +02:00
Robin Appelman 38db847164 allow admin to configure the max trashbin size
this allows an admin to configure the max trashbin size instead of always relying on the users quota.

The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 14:30:07 +00:00
npmbuildbot[bot] 9ba82fe435 Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-23 13:07:03 +00:00
Roeland Jago Douma fad4f95d56
Merge pull request #21955 from nextcloud/backport/21949/stable19
[stable19] update icewind/smb to 3.2.6
2020-07-23 12:28:05 +02:00
Roeland Jago Douma 3811a5ebad Respect default share permissions
Else we'll always create new shares with the max permissions.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 08:55:55 +00:00
Nextcloud bot 7246ffff9b
[tx-robot] updated from transifex 2020-07-23 02:17:13 +00:00
Robin Appelman d588471f2f update icewind/smb to 3.2.6
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-22 20:22:31 +00:00
Nextcloud bot 5b5cc637e8
[tx-robot] updated from transifex 2020-07-22 02:16:48 +00:00
Julius Härtl ba55e0ad53 Encryption is ready if master key is enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-21 11:44:58 +00:00
Nextcloud bot 0a90eeb62c
[tx-robot] updated from transifex 2020-07-21 02:17:16 +00:00
Morris Jobke d2c152f46b
Merge pull request #21876 from nextcloud/backport/21855/stable19
[stable19] fix typo in revokeShare()
2020-07-20 14:15:15 +02:00
Nextcloud bot ec69ab4ed4
[tx-robot] updated from transifex 2020-07-19 02:17:16 +00:00
Nextcloud bot e56d52fbc0
[tx-robot] updated from transifex 2020-07-18 02:17:08 +00:00
Nextcloud bot 95093e4f27
[tx-robot] updated from transifex 2020-07-17 02:17:21 +00:00
Roeland Jago Douma 387c179e55
Merge pull request #21840 from nextcloud/backport/21838/stable19
[stable19] Do not log RequestedRangeNotSatisfiable exceptions in DAV
2020-07-16 20:46:10 +02:00
Roeland Jago Douma 6506860561
Merge pull request #21782 from nextcloud/backport/21777/stable19
[stable19] lower minimum search length to 2 characters
2020-07-16 20:44:53 +02:00
Sergej Pupykin e400719f73 fix typo 2020-07-16 18:17:26 +00:00